Re: [oe] gst-ffmpeg configure-fix patch and yasm
On Wed, Apr 03, 2013 at 07:07:03AM +0200, Martin Jansa wrote: On Sat, Mar 30, 2013 at 09:30:51PM +0100, dv wrote: On 03/30/13 17:40, Otavio Salvador wrote: On Sat, Mar 30, 2013 at 12:00 PM, dv d...@pseudoterminal.org wrote: Hello, I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13: + if test x$disable_yasm != xyes; then +embffmpeg_configure_args=$embffmpeg_configure_args --disable-yasm + fi Shouldn't the test be: if test x$disable_yasm = xyes ? To me, it seems as if this code adds --disable-yasm if disable_yasm is not set to yes, which is the complete opposite of the intended behavior. Or am I missing some detail about shell script code here? I think you are right here. Maybe you could provide a fix for it? -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel No problem. Patch for the patch attached :) This patch is for oe-core, it needs to be resend to openembedded-c...@lists.openembedded.org Tom's patch was applied in oe-core http://git.openembedded.org/openembedded-core/commit/?id=da9515621134c26e54f43b96cdad0c6e6c5876bf From 4624e30adb13ad361f886eeda4272a7235bedd61 Mon Sep 17 00:00:00 2001 From: Carlos Rafael Giani d...@pseudoterminal.org Date: Sat, 30 Mar 2013 21:29:22 +0100 Subject: [PATCH] gst-ffmpeg: configure-fix patch used wrong test Signed-off-by: Carlos Rafael Giani d...@pseudoterminal.org --- .../recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch index 81029ca..2bb124b 100644 --- a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch +++ b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch @@ -11,7 +11,7 @@ diff -r f2f8f74c6e30 configure.ac --enable-gpl fi -+ if test x$disable_yasm != xyes; then ++ if test x$disable_yasm = xyes; then +embffmpeg_configure_args=$embffmpeg_configure_args --disable-yasm + fi + -- 1.8.2 ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com signature.asc Description: Digital signature ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] gst-ffmpeg configure-fix patch and yasm
On Sat, Mar 30, 2013 at 09:30:51PM +0100, dv wrote: On 03/30/13 17:40, Otavio Salvador wrote: On Sat, Mar 30, 2013 at 12:00 PM, dv d...@pseudoterminal.org wrote: Hello, I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13: + if test x$disable_yasm != xyes; then +embffmpeg_configure_args=$embffmpeg_configure_args --disable-yasm + fi Shouldn't the test be: if test x$disable_yasm = xyes ? To me, it seems as if this code adds --disable-yasm if disable_yasm is not set to yes, which is the complete opposite of the intended behavior. Or am I missing some detail about shell script code here? I think you are right here. Maybe you could provide a fix for it? -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel No problem. Patch for the patch attached :) This patch is for oe-core, it needs to be resend to openembedded-c...@lists.openembedded.org From 4624e30adb13ad361f886eeda4272a7235bedd61 Mon Sep 17 00:00:00 2001 From: Carlos Rafael Giani d...@pseudoterminal.org Date: Sat, 30 Mar 2013 21:29:22 +0100 Subject: [PATCH] gst-ffmpeg: configure-fix patch used wrong test Signed-off-by: Carlos Rafael Giani d...@pseudoterminal.org --- .../recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch index 81029ca..2bb124b 100644 --- a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch +++ b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch @@ -11,7 +11,7 @@ diff -r f2f8f74c6e30 configure.ac --enable-gpl fi -+ if test x$disable_yasm != xyes; then ++ if test x$disable_yasm = xyes; then +embffmpeg_configure_args=$embffmpeg_configure_args --disable-yasm + fi + -- 1.8.2 ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel -- Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com signature.asc Description: Digital signature ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] gst-ffmpeg configure-fix patch and yasm
On Sat, Mar 30, 2013 at 12:00 PM, dv d...@pseudoterminal.org wrote: Hello, I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13: + if test x$disable_yasm != xyes; then +embffmpeg_configure_args=$embffmpeg_configure_args --disable-yasm + fi Shouldn't the test be: if test x$disable_yasm = xyes ? To me, it seems as if this code adds --disable-yasm if disable_yasm is not set to yes, which is the complete opposite of the intended behavior. Or am I missing some detail about shell script code here? I think you are right here. Maybe you could provide a fix for it? -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] gst-ffmpeg configure-fix patch and yasm
On 03/30/13 17:40, Otavio Salvador wrote: On Sat, Mar 30, 2013 at 12:00 PM, dv d...@pseudoterminal.org wrote: Hello, I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13: + if test x$disable_yasm != xyes; then +embffmpeg_configure_args=$embffmpeg_configure_args --disable-yasm + fi Shouldn't the test be: if test x$disable_yasm = xyes ? To me, it seems as if this code adds --disable-yasm if disable_yasm is not set to yes, which is the complete opposite of the intended behavior. Or am I missing some detail about shell script code here? I think you are right here. Maybe you could provide a fix for it? -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel No problem. Patch for the patch attached :) From 4624e30adb13ad361f886eeda4272a7235bedd61 Mon Sep 17 00:00:00 2001 From: Carlos Rafael Giani d...@pseudoterminal.org Date: Sat, 30 Mar 2013 21:29:22 +0100 Subject: [PATCH] gst-ffmpeg: configure-fix patch used wrong test Signed-off-by: Carlos Rafael Giani d...@pseudoterminal.org --- .../recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch index 81029ca..2bb124b 100644 --- a/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch +++ b/meta/recipes-multimedia/gstreamer/gst-ffmpeg-0.10.13/configure-fix.patch @@ -11,7 +11,7 @@ diff -r f2f8f74c6e30 configure.ac --enable-gpl fi -+ if test x$disable_yasm != xyes; then ++ if test x$disable_yasm = xyes; then +embffmpeg_configure_args=$embffmpeg_configure_args --disable-yasm + fi + -- 1.8.2 ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Re: [oe] gst-ffmpeg configure-fix patch and yasm
Hello, On Sat, Mar 30, 2013 at 5:30 PM, dv d...@pseudoterminal.org wrote: On 03/30/13 17:40, Otavio Salvador wrote: On Sat, Mar 30, 2013 at 12:00 PM, dv d...@pseudoterminal.org wrote: Hello, I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13: + if test x$disable_yasm != xyes; then +embffmpeg_configure_args=$embffmpeg_configure_args --disable-yasm + fi Shouldn't the test be: if test x$disable_yasm = xyes ? To me, it seems as if this code adds --disable-yasm if disable_yasm is not set to yes, which is the complete opposite of the intended behavior. Or am I missing some detail about shell script code here? I think you are right here. Maybe you could provide a fix for it? ... No problem. Patch for the patch attached :) Please Martin, Can you review the patch in this thread? Regards, -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
