Re: [Openerp-community] Rationale for proposing the project openerp-nomenclature to join the OCA projects

2014-03-17 Thread Info SHS-AV

Hi Lionel,
I mismatched purpose of the project, sorry.
However, we should be agree about how store data in software.
And, in order to store data for all, we have to know how every data is 
coded by regional and local people.


So, what localized data we wish manage in this project?
I would like:
1. Local address format
2. Administrative division of countries (may be NUTS)
3. Postal code zone (aka ZIP)
4. Domestic bank, may be useful to check IBAN
5. VAT structure: all EU countries have similar VAT tax
6. Is vatnumer checked by OpenERP for all countries?
7. Some countries, like Italy and Spain, have also the fiscalcode; in 
Italy a business may have 2 vatnumber


In my mind, a common country table defines data structure that every 
local team manages indipendently.


What do think about?





Il 16/03/2014 14:55, Lionel Sausin, de la part de l'équipe informatique 
Numérigraphe ha scritto:

Le 15/03/2014 17:31, Info SHS-AV a écrit :

Agree.
UE team should ask regional teams about domestic structure in order 
to build functional software.

In example, for address, UE team shold require these info:
Address format: Italy -  %(zip) %(city)s %(state_id)s
ZIP format: Italy - 5 digits
ZIP - City relanshionship: Italy - Many2Many
State_id means: Italy - NUTS3
State_id - City relanshionship: Italy - One2Many
... and so on
I am avaiable to prepare a form to gather infomations.

This would fit better in a localization effort than in a data-oriented 
project in my opinion.
I think I already read discussions on this topic but i can't find them 
right now.

Lionel


___
Mailing list: openerp-community@lists.launchpad.net
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


--

Antonio M. Vigliotti


___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] [Merge] lp:~camptocamp/openerp-product-attributes/6.1-rights-attribute_set-1254609 into lp:openerp-product-attributes/6.1

2014-03-17 Thread Leonardo Pistone - camptocamp
Note: similar fix already merged on v7

https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-rights-attribute_set-1254609/+merge/196481
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-rights-attribute_set-1254609/+merge/210809
Your team OpenERP Community is subscribed to branch 
lp:openerp-product-attributes/6.1.

___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] Rationale for proposing the project openerp-nomenclature to join the OCA projects

2014-03-17 Thread Markus Schneider
hi,

On 17.03.2014 07:58, Info SHS-AV wrote:
 However, we should be agree about how store data in software.

i think the best way is to store it as xml. The two benefits to csv are:

- with xml ids you can update or extend the data in a second module
- you can mark data as no update to give the user the control to
customize the dataset in openerp installation

Greetings

Markus

-- 
Dipl.-Comp.-Math. Markus Schneider
Softwareentwickler

initOS GmbH  Co. KG
An der Eisenbahn 1
21224 Rosengarten

Mobil:   +49 (0)172 2303699
Phone:   +49 (0)4105 5615613
Fax: +49 (0)4105 5615610

Email:   markus.schnei...@initos.com
Web: http://www.initos.com

Geschäftsführung:
Dipl. Wirt.-Inf. Frederik Kramer  Dipl.-Ing. (FH) Torsten Francke
Haftende Gesellschafterin: initOS Verwaltungs GmbH

Sitz der Gesellschaft: Rosengarten – Klecken
Amtsgericht Tostedt, HRA 201840
USt-IdNr: DE 275698169
Steuer-Nr: 15/205/21402

___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] Rationale for proposing the project openerp-nomenclature to join the OCA projects

2014-03-17 Thread Info SHS-AV


Il 17/03/2014 09:54, Markus Schneider ha scritto:

hi,

On 17.03.2014 07:58, Info SHS-AV wrote:

However, we should be agree about how store data in software.

i think the best way is to store it as xml. The two benefits to csv are:

- with xml ids you can update or extend the data in a second module
- you can mark data as no update to give the user the control to
customize the dataset in openerp installation

Yes I fully agree.
But we have to device how and what data we would record inside xml file

Greetings

Markus



--

Antonio M. Vigliotti


___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] Start using buildbot

2014-03-17 Thread Alexandre Fayolle
On 15/03/2014 09:00, Lorenzo Battistini wrote:
 On 03/14/2014 04:31 PM, Lorenzo Battistini wrote:
 Now, I can't understand how to test the openerp-7.0 configuration.
 Should I
 link a slave to the master? How should I configure the slaves.cfg file?

 Thanks!

 Ok, got it.
 I set my slave name in slaves.cfg and restarted master
 I created my slave with correct name and password (as per slaves.cfg)
 and I can start the build.

 Testing further...

Great, sorry for not seeing your mail. Don't hesitate to use a clear
subject line rather than hijacking an existing thread. It maked triaging
mail much easier :-)

Regards

-- 
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com


___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] Rationale for proposing the project openerp-nomenclature to join the OCA projects

2014-03-17 Thread Daniel Reis

Quoting Lionel Sausin, de la part de l'équipe informatique Numérigraphe
informati...@numerigraphe.com:


This would fit better in a localization effort than in a  
data-oriented project in my opinion.



+1
___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] [Merge] lp:~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss into lp:~openerp-community/server-env-tools/6.1-mass_editing

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing

Instead of dict.update({split_key: m2m_list})

You can simply write 

dict['split_key'] = m2m_list

It might be a bit more readable
-- 
https://code.launchpad.net/~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss/+merge/201321
Your team OpenERP Community is subscribed to branch 
lp:~openerp-community/server-env-tools/6.1-mass_editing.

___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] [Merge] lp:~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss into lp:~openerp-community/server-env-tools/6.1-mass_editing

2014-03-17 Thread Francesco Apruzzese


Il 17/03/2014 17:38, Yannick Vaucher @ Camptocamp ha scritto:

Review: Needs Fixing

Instead of dict.update({split_key: m2m_list})

You can simply write

dict['split_key'] = m2m_list

It might be a bit more readable


If you use dict['split_key'], are you sure 'split_key' key exists in 
dict? If you use update, python create the key for you if not exist or 
update it if exists yet.


___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] [Merge] lp:~openerp-community/server-env-tools/6.1-mass_editing into lp:server-env-tools/6.1

2014-03-17 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Needs Information

@Stefan, could you please explain the dataloss issue in this frame, I don't 
quite understand.
How does the branch you propose come into play here?
-- 
https://code.launchpad.net/~openerp-community/server-env-tools/6.1-mass_editing/+merge/161619
Your team OpenERP Community is subscribed to branch 
lp:~openerp-community/server-env-tools/6.1-mass_editing.

___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-server/7.0-bug-1172156-bank-format-layout-translation into lp:ocb-server

2014-03-17 Thread noreply
The proposal to merge 
lp:~yann-papouin/ocb-server/7.0-bug-1172156-bank-format-layout-translation into 
lp:ocb-server has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-server/7.0-bug-1172156-bank-format-layout-translation/+merge/210167
-- 
https://code.launchpad.net/~yann-papouin/ocb-server/7.0-bug-1172156-bank-format-layout-translation/+merge/210167
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~anybox/ocb-server/7.0-test-report into lp:ocb-server

2014-03-17 Thread Holger Brunn (Therp)
The proposal to merge lp:~anybox/ocb-server/7.0-test-report into lp:ocb-server 
has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~anybox/ocb-server/7.0-test-report/+merge/207978
-- 
https://code.launchpad.net/~anybox/ocb-server/7.0-test-report/+merge/207978
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~anybox/ocb-server/7.0-test-report into lp:ocb-server

2014-03-17 Thread Holger Brunn (Therp)
Review: Approve code review


-- 
https://code.launchpad.net/~anybox/ocb-server/7.0-test-report/+merge/207978
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-web/7.0-lp1167429-binary_fields_in_o2m_representation_and_unnecessary_preloading into lp:ocb-web

2014-03-17 Thread Pedro Manuel Baeza
Very good improvement. Thanks!

Regards.
-- 
https://code.launchpad.net/~stefan-therp/ocb-web/7.0-lp1167429-binary_fields_in_o2m_representation_and_unnecessary_preloading/+merge/210432
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-web/7.0-lp1167429-binary_fields_in_o2m_representation_and_unnecessary_preloading into lp:ocb-web

2014-03-17 Thread Pedro Manuel Baeza
Review: Approve


-- 
https://code.launchpad.net/~stefan-therp/ocb-web/7.0-lp1167429-binary_fields_in_o2m_representation_and_unnecessary_preloading/+merge/210432
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-server/7.0-fix-po-targets-933496-vmt into lp:ocb-server

2014-03-17 Thread Holger Brunn (Therp)
Review: Needs Information

I posted Vo Minh Thu's fix for 6.1 
(https://code.launchpad.net/~therp-nl/ocb-server/6.1-lp933496/+merge/193011) 
but Pedro had an issue with I never managed to figure out. Pedro: Did you ever 
have a chance to dig into that? And do you have the same behavior with this 
patch and version 7.0?
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-server/7.0-fix-po-targets-933496-vmt/+merge/209895
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe into lp:ocb-addons

2014-03-17 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging 
lp:~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe into 
lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1192115 in OpenERP Community Backports (Addons): [trunk/7.0] carrier 
information not propagated from sale order to pickings
  https://bugs.launchpad.net/ocb-addons/+bug/1192115

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe/+merge/211264

[FIX] delivery: carrier information not propagated from sale order to pickings.

port of 
https://code.launchpad.net/~openerp-dev/openobject-addons/7.0-595240-opw-skh/+merge/180790
 to OCB
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe/+merge/211264
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe into 
lp:ocb-addons.
=== modified file 'delivery/sale.py'
--- delivery/sale.py	2012-10-23 16:05:04 +
+++ delivery/sale.py	2014-03-17 08:38:11 +
@@ -72,8 +72,7 @@
 'tax_id': [(6,0,taxes_ids)],
 'type': 'make_to_stock'
 })
-#remove the value of the carrier_id field on the sale order
-return self.write(cr, uid, ids, {'carrier_id': False}, context=context)
+return True
 #return {'type': 'ir.actions.act_window_close'} action reload?
 
 sale_order()

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-983764-partner-task-procurement into lp:ocb-addons/6.1

2014-03-17 Thread noreply
The proposal to merge 
lp:~yann-papouin/ocb-addons/6.1-bug-983764-partner-task-procurement into 
lp:ocb-addons/6.1 has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-983764-partner-task-procurement/+merge/205117
-- 
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-983764-partner-task-procurement/+merge/205117
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_action_rule_processing_lp1190592-afe into lp:ocb-addons

2014-03-17 Thread Holger Brunn (Therp)
The proposal to merge 
lp:~camptocamp/ocb-addons/ocb-7.0-fix_action_rule_processing_lp1190592-afe into 
lp:ocb-addons has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_action_rule_processing_lp1190592-afe/+merge/209086
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_action_rule_processing_lp1190592-afe/+merge/209086
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-03-17 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing code review, test

Hello, 

Thanks for this contribution, the functionality is great and I'd love to see it 
in OCA. And thanks for including tests.

A few minor changes are needed to bring the module to the coding standards


* use orm.Model / orm.TransientModel as base classes instead of osv.osv and 
osv.osv_memory
* model column default values: in OpenERP 7.0, not need to use a lambda for a 
constant value, just use the constant


Additionally:

* in __openerp__.py, I think you should use 'Warehouse Management' for the 
category (i.e. the same one as the official 'stock' addon
* no space before '!' in english (I'd remove the exclamation marks in exception 
messages altogether, that the UI job to display an icon)
* in confirm_uninventoried_location_wizard: you should add a 'if context is 
None: context = {}' at the beginning. 
* in confirm_uninventoried_locations: you are ignoring an osv_except exception. 
Could you add a comment in the code explaining why this is safe? If this is 
about the No product in this location warning raised in the reimplementation 
of _fill_location_lines, then I think a check that we are ignoring the correct 
exception should be added. You could for instance subclass except_osv and raise 
+ ignore the subclass. Otherwise I think the code may hide things we do not 
want to hide (or even fail because of an except_osv 

-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/210630
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-user-specific-info into lp:lp-community-utils

2014-03-17 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, test

LGTM
-- 
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-user-specific-info/+merge/209665
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:lp-community-utils.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Bug 588154] Re: Inventory: movement input with date prior to physical inventory are reflected in stocks

2014-03-17 Thread Lionel Sausin - Numérigraphe
** Also affects: openerp-trunk-wms
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Stock and
Logistic Core Editors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/588154

Title:
  Inventory: movement input with date prior to physical inventory are
  reflected in stocks

Status in New OpenERP WMS:
  New
Status in OpenERP Addons (modules):
  In Progress
Status in OpenERP Addons 5.0 series:
  Confirmed
Status in OpenERP Addons trunk series:
  Won't Fix

Bug description:
  I setup a physical inventory with date 2010/05/19. Stock is 5 for product x
  When I have an internal move  for 1 piece of product x with date 2010/05/01, 
the current calculated stock at 2010/06/01 is 4 which seems to me incorrect as 
the current stock should reflect the physical inventory on 2010/05/19 and be 5.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openerp-trunk-wms/+bug/588154/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Bug 915568] Re: Wrong dates used when confirming stock inventory

2014-03-17 Thread Lionel Sausin - Numérigraphe
Quentin, a distinct bug exists for the remaining problem: would you please get 
in charge of bug #588154 ?
It contains (admitedly hackish) code to work around it in v6/v7, but more 
importantly a test scenario with a YML file.

-- 
You received this bug notification because you are a member of Stock and
Logistic Core Editors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/915568

Title:
  Wrong dates used when confirming stock inventory

Status in OpenERP Community Backports (Addons):
  Confirmed
Status in New OpenERP WMS:
  Fix Released
Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  [ Problem ]
  action_confirm method is not taking in account date from stock.inventory 
object, and update qtys in the moment of confirmation.
  The inventory date is taken into account when querying the stock to compute 
the inventory difference but the stock moves are created at the wrong date, 
making the stock and virtual stock wrong at the date of the inventory.

  Users expect that the inventory date should say _when_ the inventory
  was taken - in this way the amount to correct should effective before
  this date.

  Attached videos gives better explanation, and document with kardex
  expected.

  [ Impact ] the available quantity and virtual stock are wrong near the
  date of the inventory.

  [ Possible fixes ]
  - The preferred fix would be to write the stock moves at the date of the 
inventory.
  - A less-than-ideal fix would be to not take the inventory date is taken into 
account when querying the stock to compute the inventory difference. For the 
moment is the way v8 is being developed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/915568/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_agreement_sourcing-nbi into lp:openerp-humanitarian-ngo

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review

LGTM
-- 
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_agreement_sourcing-nbi/+merge/196676
Your team OpenERP for Humanitarian Core Editors is subscribed to branch 
lp:openerp-humanitarian-ngo.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_agreement_sourcing-nbi into lp:openerp-humanitarian-ngo

2014-03-17 Thread Yannick Vaucher @ Camptocamp
The proposal to merge 
lp:~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_agreement_sourcing-nbi 
into lp:openerp-humanitarian-ngo has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_agreement_sourcing-nbi/+merge/196676
-- 
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_agreement_sourcing-nbi/+merge/196676
Your team OpenERP for Humanitarian Core Editors is subscribed to branch 
lp:openerp-humanitarian-ngo.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-readonly-lines into lp:ocb-addons

2014-03-17 Thread Holger Brunn (Therp)
Review: Approve code review


-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-readonly-lines/+merge/210207
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted into lp:ocb-addons

2014-03-17 Thread Holger Brunn (Therp)
Review: Approve code review

In this context, I would have written
self
instead of
self.pool.get('stock.inventory.line')
but given that it's the same in upstream, I'm fine with it as it is.
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted/+merge/210467
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/lp-community-utils/nag-user-specific-info into lp:lp-community-utils

2014-03-17 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review, test

Thanks!
-- 
https://code.launchpad.net/~camptocamp/lp-community-utils/nag-user-specific-info/+merge/209665
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:lp-community-utils.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_agreement_sourcing-nbi into lp:openerp-humanitarian-ngo

2014-03-17 Thread noreply
The proposal to merge 
lp:~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_agreement_sourcing-nbi 
into lp:openerp-humanitarian-ngo has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_agreement_sourcing-nbi/+merge/196676
-- 
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/ngo-addons-add_agreement_sourcing-nbi/+merge/196676
Your team OpenERP for Humanitarian Core Editors is subscribed to branch 
lp:openerp-humanitarian-ngo.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~andrei-levin/openerp-pos/openerp-pos into lp:openerp-pos

2014-03-17 Thread Andrei Levin
This module creates a base for printing to fiscal printer. It contains
all the functions that can be useful for creating a driver - a
simple module which contains functions that should be different for
various printer models.
The second module is a dummy driver that shows how to write a driver.

2014-03-14 10:49 GMT+01:00 Yannick Vaucher @ Camptocamp
yannick.vauc...@camptocamp.com:
 Review: Needs Fixing description

 Please improve the description

 Anything to do to setup the fiscol printer ?
 --
 https://code.launchpad.net/~andrei-levin/openerp-pos/openerp-pos/+merge/196201
 You are the owner of lp:~andrei-levin/openerp-pos/openerp-pos.



-- 
Didotech Srl

Via T.Aspetti, 248
35133 Padova (PD)

Tel 049 8592286
Cell.: 347-2426694
www.didotech.com

https://code.launchpad.net/~andrei-levin/openerp-pos/openerp-pos/+merge/196201
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:openerp-pos.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Bug 588154] Re: Inventory: movement input with date prior to physical inventory are reflected in stocks

2014-03-17 Thread qdp (OpenERP)
hum... i'm not sure it's a bug: it depends on the time you made the
stock move. Was it before or after the invetory time? Otherwise, i
suppose that when you want the virtual stock of a product at a given
date, you always want the moves of that day included..

-- 
You received this bug notification because you are a member of Stock and
Logistic Core Editors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/588154

Title:
  Inventory: movement input with date prior to physical inventory are
  reflected in stocks

Status in New OpenERP WMS:
  New
Status in OpenERP Addons (modules):
  In Progress
Status in OpenERP Addons 5.0 series:
  Confirmed
Status in OpenERP Addons trunk series:
  Won't Fix

Bug description:
  I setup a physical inventory with date 2010/05/19. Stock is 5 for product x
  When I have an internal move  for 1 piece of product x with date 2010/05/01, 
the current calculated stock at 2010/06/01 is 4 which seems to me incorrect as 
the current stock should reflect the physical inventory on 2010/05/19 and be 5.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openerp-trunk-wms/+bug/588154/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-picking-custom-default-origin into lp:ocb-addons

2014-03-17 Thread Holger Brunn (Therp)
Review: Approve code review


-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-picking-custom-default-origin/+merge/210559
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-latest-move into lp:ocb-addons

2014-03-17 Thread Holger Brunn (Therp)
Review: Approve code review


-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-latest-move/+merge/210795
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/ocb-addons/trunk-lp1292587 into lp:ocb-addons

2014-03-17 Thread Holger Brunn (Therp)
Review: Approve code review


-- 
https://code.launchpad.net/~akretion-team/ocb-addons/trunk-lp1292587/+merge/211095
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe into lp:ocb-addons

2014-03-17 Thread Holger Brunn (Therp)
Review: Approve code review


-- 
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-595240-opw-skh_fix_1192115-afe/+merge/211264
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/7.0-bug-1137541-partial-picking-move-destination into lp:ocb-addons

2014-03-17 Thread Holger Brunn (Therp)
The proposal to merge 
lp:~yann-papouin/ocb-addons/7.0-bug-1137541-partial-picking-move-destination 
into lp:ocb-addons has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1137541-partial-picking-move-destination/+merge/210155
-- 
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1137541-partial-picking-move-destination/+merge/210155
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready into lp:ocb-addons

2014-03-17 Thread Holger Brunn (Therp)
Review: Approve code review


-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready/+merge/210965
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245 into lp:ocb-addons

2014-03-17 Thread Holger Brunn (Therp)
Review: Approve code review


-- 
https://code.launchpad.net/~savoirfairelinux-openerp/ocb-addons/crossovered_unicode_1292245/+merge/210926
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready into lp:ocb-addons

2014-03-17 Thread Holger Brunn (Therp)
The proposal to merge 
lp:~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready into 
lp:ocb-addons has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready/+merge/210965
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready/+merge/210965
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Bug 588154] Re: Inventory: movement input with date prior to physical inventory are reflected in stocks

2014-03-17 Thread Lionel Sausin - Numérigraphe
qdp: sorry I didn't make it clear, but our solution was in a home-grown 
software outside OpenERP, so I don't have a patch at all.
I'm not confident with the new quant code to make a patch for trunk-wms, but if 
you make sure no moves are introduced in the past at all then this bug won't 
happen.
Just 2 things come to my mind:
- if I make a new inventory before an existing inventory, make sure it does not 
change the latest one's stock levels
- make sure no moves with past dates can be introduced through the API either 
(XML-RPC scripts for example)
Lionel.

-- 
You received this bug notification because you are a member of Stock and
Logistic Core Editors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/588154

Title:
  Inventory: movement input with date prior to physical inventory are
  reflected in stocks

Status in New OpenERP WMS:
  New
Status in OpenERP Addons (modules):
  In Progress
Status in OpenERP Addons 5.0 series:
  Confirmed
Status in OpenERP Addons trunk series:
  Won't Fix

Bug description:
  I setup a physical inventory with date 2010/05/19. Stock is 5 for product x
  When I have an internal move  for 1 piece of product x with date 2010/05/01, 
the current calculated stock at 2010/06/01 is 4 which seems to me incorrect as 
the current stock should reflect the physical inventory on 2010/05/19 and be 5.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openerp-trunk-wms/+bug/588154/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-fill-precision into lp:ocb-addons

2014-03-17 Thread Holger Brunn (Therp)
Review: Approve code review


-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-fill-precision/+merge/210459
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/server-env-tools/l10n into lp:server-env-tools

2014-03-17 Thread noreply
The proposal to merge lp:~savoirfairelinux-openerp/server-env-tools/l10n into 
lp:server-env-tools has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/server-env-tools/l10n/+merge/20
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/server-env-tools/l10n/+merge/20
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Bug 588154] Re: Inventory: movement input with date prior to physical inventory are reflected in stocks

2014-03-17 Thread Lionel Sausin - Numérigraphe
Just to avoid confusion : you have to consider that inventory data is 
definitive, like a new starting point for all further calculations.
Whatever you record before/after an inventory, you must always make sure the 
quantity at the date of the inventory is unchanged.

So in a way, you do not always want the moves of that day included: if
ever you allow a past move to be inserted at a time before an inventory,
then it must not change the quantity available at the time of the
inventory because it was already accounted for in the inventory.

-- 
You received this bug notification because you are a member of Stock and
Logistic Core Editors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/588154

Title:
  Inventory: movement input with date prior to physical inventory are
  reflected in stocks

Status in New OpenERP WMS:
  New
Status in OpenERP Addons (modules):
  In Progress
Status in OpenERP Addons 5.0 series:
  Confirmed
Status in OpenERP Addons trunk series:
  Won't Fix

Bug description:
  I setup a physical inventory with date 2010/05/19. Stock is 5 for product x
  When I have an internal move  for 1 piece of product x with date 2010/05/01, 
the current calculated stock at 2010/06/01 is 4 which seems to me incorrect as 
the current stock should reflect the physical inventory on 2010/05/19 and be 5.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openerp-trunk-wms/+bug/588154/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/6.1-web_widget_classes into lp:web-addons/6.1

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review

LGTM
-- 
https://code.launchpad.net/~therp-nl/web-addons/6.1-web_widget_classes/+merge/198703
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname into lp:partner-contact-management

2014-03-17 Thread Holger Brunn (Therp)
Review: Approve code review


-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/user-firstname/+merge/210710
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname into lp:partner-contact-management

2014-03-17 Thread Holger Brunn (Therp)
The proposal to merge 
lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname into 
lp:partner-contact-management has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/user-firstname/+merge/210710
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/user-firstname/+merge/210710
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/pep394 into lp:lp-community-utils

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Abstain


-- 
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/pep394/+merge/204535
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:lp-community-utils.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/6.1-web_print_from_browser-hide_kanban_controls into lp:web-addons/6.1

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Approve

LGTM
-- 
https://code.launchpad.net/~therp-nl/web-addons/6.1-web_print_from_browser-hide_kanban_controls/+merge/203916
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~echeverrifm/oemedical/oemedical_lab into lp:oemedical

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing code review

Please set a description in __openerp__.py

l.71 does it still has errors ?
-- 
https://code.launchpad.net/~echeverrifm/oemedical/oemedical_lab/+merge/205519
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-03-17 Thread Matthieu Dietrich @ camptocamp
To expand a bit: this MP is to add 2 things related to hours block:
- a new field for the department, which is filterable/searchable,
- a new button in the project form view, in order to get the hours block 
related to a project.
-- 
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing

If department is changed in invoice the related field won't be updated.

Please set the proper store triggers.

Cheers,
-- 
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde into lp:carriers-deliveries/6.1

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Approve


-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde/+merge/210772
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/base-deliv-carr-label--improve-file_type-inheritance-shipping-label-dbl into lp:carriers-deliveries

2014-03-17 Thread David BEAL
David BEAL has proposed merging 
lp:~akretion-team/carriers-deliveries/base-deliv-carr-label--improve-file_type-inheritance-shipping-label-dbl
 into lp:carriers-deliveries.

Requested reviews:
  Yannick Vaucher @ Camptocamp (yvaucher-c2c)

For more details, see:
https://code.launchpad.net/~akretion-team/carriers-deliveries/base-deliv-carr-label--improve-file_type-inheritance-shipping-label-dbl/+merge/211287

Improve file_type field inheritance in shipping.label
-- 
https://code.launchpad.net/~akretion-team/carriers-deliveries/base-deliv-carr-label--improve-file_type-inheritance-shipping-label-dbl/+merge/211287
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.
=== modified file 'base_delivery_carrier_label/stock.py'
--- base_delivery_carrier_label/stock.py	2014-01-15 13:13:55 +
+++ base_delivery_carrier_label/stock.py	2014-03-17 11:29:44 +
@@ -283,10 +283,14 @@
 _description = Shipping Label
 
 def _get_file_type_selection(self, cr, uid, context=None):
+ To inherit to add file type 
 return [('pdf', 'PDF')]
 
+def __get_file_type_selection(self, cr, uid, context=None):
+return self._get_file_type_selection(cr, uid, context=context)
+
 _columns = {
-'file_type': fields.selection(_get_file_type_selection, 'File type'),
+'file_type': fields.selection(__get_file_type_selection, 'File type'),
 'tracking_id': fields.many2one('stock.tracking', 'Pack'),
 }
 

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/6.1-leaner-bzrignore-lep into lp:ocb-server/6.1

2014-03-17 Thread Leonardo Pistone - camptocamp
Leonardo Pistone - camptocamp has proposed merging 
lp:~camptocamp/ocb-server/6.1-leaner-bzrignore-lep into lp:ocb-server/6.1.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1293461 in OpenERP Server: .bzrignore ignores all addons
  https://bugs.launchpad.net/openobject-server/+bug/1293461

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-server/6.1-leaner-bzrignore-lep/+merge/211288
-- 
https://code.launchpad.net/~camptocamp/ocb-server/6.1-leaner-bzrignore-lep/+merge/211288
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~camptocamp/ocb-server/6.1-leaner-bzrignore-lep into 
lp:ocb-server/6.1.
=== modified file '.bzrignore'
--- .bzrignore	2012-02-01 13:09:57 +
+++ .bzrignore	2014-03-17 11:33:19 +
@@ -1,7 +1,4 @@
 *.pyc
-.*.swp
-.bzrignore
-openerp/addons/*
 openerp/filestore*
 .Python
 include

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-leaner-bzrignore-lep into lp:ocb-server

2014-03-17 Thread Leonardo Pistone - camptocamp
Leonardo Pistone - camptocamp has proposed merging 
lp:~camptocamp/ocb-server/7.0-leaner-bzrignore-lep into lp:ocb-server.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1293461 in OpenERP Server: .bzrignore ignores all addons
  https://bugs.launchpad.net/openobject-server/+bug/1293461

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-server/7.0-leaner-bzrignore-lep/+merge/211290
-- 
https://code.launchpad.net/~camptocamp/ocb-server/7.0-leaner-bzrignore-lep/+merge/211290
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~camptocamp/ocb-server/7.0-leaner-bzrignore-lep into lp:ocb-server.
=== modified file '.bzrignore'
--- .bzrignore	2012-11-28 12:09:50 +
+++ .bzrignore	2014-03-17 11:39:42 +
@@ -1,12 +1,9 @@
-.*.swp
-.bzrignore
 .idea
 .project
 .pydevproject
 .ropeproject
 .settings
 .DS_Store
-openerp/addons/*
 openerp/filestore*
 .Python
 *.pyc

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into lp:account-financial-report

2014-03-17 Thread Nicolas Bessi - Camptocamp
Nicolas Bessi - Camptocamp has proposed merging 
lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into 
lp:account-financial-report.

Commit message:
[ADD] Aged Partner Balance webkit report. Report inherit Open Invoice Report 
and uses previously computed ledger lines to determin aged lines

Requested reviews:
  Account Report Core Editors (account-report-core-editor)

For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040

[ADD] Aged Partner Balance webkit report. Report inherit Open Invoice Report 
and uses previously computed ledger lines to determin aged linesAdd aged 
partner balance webkit report. 
-- 
https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040
Your team Account Report Core Editors is requested to review the proposed merge 
of lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into 
lp:account-financial-report.
=== modified file 'account_financial_report_webkit/__openerp__.py'
--- account_financial_report_webkit/__openerp__.py	2014-03-13 10:49:47 +
+++ account_financial_report_webkit/__openerp__.py	2014-03-17 12:10:18 +
@@ -30,7 +30,7 @@
  - Partner ledger
  - Partner balance
  - Open invoices report
-
+ - Aged Partner Balance
 
 Main improvements per report:
 -
@@ -100,6 +100,47 @@
 * Subtotal by account and partner
 * Alphabetical sorting (same as in partner balance)
 
+
+Aged Partner Balance: Summary of aged open amount per partner
+
+This report is an accounting tool helping in various tasks.
+You can credit control or partner balance provisions computation for instance.
+
+The aged balance report allows you to print balances per partner
+like the trial balance but add an extra information :
+
+* It will split balances into due amounts
+  (due date not reached à the end date of the report) and overdue amounts
+  Overdue data are also split by period.
+* For each partner following columns will be displayed:
+
+  * Total balance (all figures must match with same date partner balance report).
+ This column equals the sum of all following columns)
+
+   * Due
+   * Overdue = 30 days
+   * Overdue = 60 days
+   * Overdue = 90 days
+   * Overdue = 120 days
+   * Older
+
+Hypothesis / Contraints of aged partner balance
+
+* Overdues columns will be by default  be based on 30 days range fix number of days.
+  This can be changed by changes the RANGES constraint
+* All data will be displayed in company currency
+* When partial payments, the payment must appear in the same colums than the invoice
+  (Except if multiple payment terms)
+* Data granularity: partner (will not display figures at invoices level)
+* The report aggregate data per account with sub-totals
+* Initial balance must be calculated the same way that
+  the partner balance / Ignoring the opening entry
+  in special period (idem open invoice report)
+* Only accounts with internal type payable or receivable are considered
+  (idem open invoice report)
+* If maturity date is null then use move line date
+
+
 Limitations:
 
 
@@ -147,6 +188,7 @@
'wizard/trial_balance_wizard_view.xml',
'wizard/partner_balance_wizard_view.xml',
'wizard/open_invoices_wizard_view.xml',
+   'wizard/aged_partner_balance_wizard.xml',
'wizard/print_journal_view.xml',
'report_menus.xml',
],

=== modified file 'account_financial_report_webkit/report/__init__.py'
--- account_financial_report_webkit/report/__init__.py	2013-09-12 20:53:27 +
+++ account_financial_report_webkit/report/__init__.py	2014-03-17 12:10:18 +
@@ -9,3 +9,4 @@
 from . import partner_balance
 from . import open_invoices
 from . import print_journal
+from . import aged_partner_balance

=== added file 'account_financial_report_webkit/report/aged_partner_balance.py'
--- account_financial_report_webkit/report/aged_partner_balance.py	1970-01-01 00:00:00 +
+++ account_financial_report_webkit/report/aged_partner_balance.py	2014-03-17 12:10:18 +
@@ -0,0 +1,405 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Nicolas Bessi
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public 

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/base-deliv-carr-label--improve-file_type-inheritance-shipping-label-dbl into lp:carriers-deliveries

2014-03-17 Thread Pedro Manuel Baeza
Review: Approve code review


-- 
https://code.launchpad.net/~akretion-team/carriers-deliveries/base-deliv-carr-label--improve-file_type-inheritance-shipping-label-dbl/+merge/211287
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/product-kitting/6.1-fix_1293524-afe into lp:product-kitting/6.1

2014-03-17 Thread Alexandre Fayolle - camptocamp
Alexandre Fayolle - camptocamp has proposed merging 
lp:~camptocamp/product-kitting/6.1-fix_1293524-afe into lp:product-kitting/6.1.

Requested reviews:
  Product Core Editors (product-core-editors)
Related bugs:
  Bug #1293524 in Product - Kitting Management: sale_bom_split: 
_create_picking_and_procurements ignores picking_id
  https://bugs.launchpad.net/product-kitting/+bug/1293524

For more details, see:
https://code.launchpad.net/~camptocamp/product-kitting/6.1-fix_1293524-afe/+merge/211313

[FIX] sale_bom_split: don't ignore picking_id in 
_create_pickings_and_procurements
-- 
https://code.launchpad.net/~camptocamp/product-kitting/6.1-fix_1293524-afe/+merge/211313
Your team Product Core Editors is requested to review the proposed merge of 
lp:~camptocamp/product-kitting/6.1-fix_1293524-afe into lp:product-kitting/6.1.
=== modified file 'sale_bom_split/sale.py'
--- sale_bom_split/sale.py	2012-07-24 12:27:35 +
+++ sale_bom_split/sale.py	2014-03-17 13:23:08 +
@@ -103,8 +103,7 @@
 # if we have at least one line which have to be split
 # we prepare the picking so we'll be able to bind it
 # to the move lines
-picking_id = False
-if bom_order_lines:
+if bom_order_lines and not picking_id:
 picking_id = picking_obj.create(
 cr, uid, self._prepare_order_picking(cr, uid, order, context=context))
 

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/product-kitting/7.0-fix_1293524-afe into lp:product-kitting

2014-03-17 Thread Alexandre Fayolle - camptocamp
I also updated the module to 7.0 standards
-- 
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293524-afe/+merge/211311
Your team Product Core Editors is requested to review the proposed merge of 
lp:~camptocamp/product-kitting/7.0-fix_1293524-afe into lp:product-kitting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/product-kitting/7.0-fix_1293524-afe into lp:product-kitting

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no tests

LGTM

Thanks
-- 
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293524-afe/+merge/211311
Your team Product Core Editors is subscribed to branch lp:product-kitting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~ajite/product-kitting/7.0-product-kitting-fix-0001 into lp:product-kitting

2014-03-17 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no test

LGTM

Thanks for the patch Augustin. In the future, it's better to file a bug report 
for such an issue as people facing this will find the bug report more easily 
than the MP. 
-- 
https://code.launchpad.net/~ajite/product-kitting/7.0-product-kitting-fix-0001/+merge/209636
Your team Product Core Editors is subscribed to branch lp:product-kitting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/checkout-pep8 into lp:lp-community-utils

2014-03-17 Thread Maxime Chambreuil (http://www.savoirfairelinux.com)
Review: Approve


-- 
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/checkout-pep8/+merge/211098
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:lp-community-utils.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~ajite/product-kitting/7.0-product-kitting-fix-0001 into lp:product-kitting

2014-03-17 Thread Pedro Manuel Baeza
Review: Approve code review

LGTM
-- 
https://code.launchpad.net/~ajite/product-kitting/7.0-product-kitting-fix-0001/+merge/209636
Your team Product Core Editors is subscribed to branch lp:product-kitting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-leaner-bzrignore-lep into lp:ocb-server

2014-03-17 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Disapprove

I disagree with taking out .swp files.
Having .swp in the ignore file means that we would never want that kind of file 
tracked.
I suggest using a different method to track swp files such as:
bzr ignored | grep .swp
-- 
https://code.launchpad.net/~camptocamp/ocb-server/7.0-leaner-bzrignore-lep/+merge/211290
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/6.1-leaner-bzrignore-lep into lp:ocb-server/6.1

2014-03-17 Thread Leonardo Pistone - camptocamp
Sandy,

1. Do you think there is a use case where you want to have .swp files around 
but you want bzr status to tell you all is good and clean?

2. What do you think about the other two removals? I'm happy to remove only 
what we find an agreement on.

Thanks!
-- 
https://code.launchpad.net/~camptocamp/ocb-server/6.1-leaner-bzrignore-lep/+merge/211288
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-project_fix_doc_count-lp1251773-vauxoo+afe into lp:ocb-addons

2014-03-17 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Needs Fixing code review, pep8

PEP8:
l.9 E231 missing whitespace after ':'
l.10 E128 continuation line under-indented for visual indent
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-project_fix_doc_count-lp1251773-vauxoo+afe/+merge/209010
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-fix_1280221-afe into lp:margin-analysis

2014-03-17 Thread noreply
The proposal to merge lp:~camptocamp/margin-analysis/7.0-fix_1280221-afe into 
lp:margin-analysis has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix_1280221-afe/+merge/206486
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix_1280221-afe/+merge/206486
Your team Margin Analysis Core Editors is subscribed to branch 
lp:margin-analysis.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/lp754339 into lp:ocb-addons

2014-03-17 Thread Stefan Rijnhart (Therp)
Review: Needs Fixing test, code review

Improvements look good. Tests run fine now. I hope we can get this back in 
again. How can your average OpenERP partner sell service hours without this 
patch?

There is a trivial conflict now in an __init__.py.

Looks like the proposal to upstream needs to be updated with the latest changes?
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/lp754339/+merge/189107
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr into lp:margin-analysis

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Yannick Vaucher @ Camptocamp has proposed merging 
lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr 
into lp:margin-analysis.

Requested reviews:
  Margin Analysis Core Editors (margin-analysis-core-editors)
Related bugs:
  Bug #1293612 in Financial controlling and costing: Cannot enter a supplier 
invoice without product on an invoice line
  https://bugs.launchpad.net/margin-analysis/+bug/1293612

For more details, see:
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354

Make sure we don't read a product of invoice line without product.
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354
Your team Margin Analysis Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr 
into lp:margin-analysis.
=== modified file 'product_historical_margin/invoice.py'
--- product_historical_margin/invoice.py	2013-11-29 15:38:55 +
+++ product_historical_margin/invoice.py	2014-03-17 16:13:09 +
@@ -98,10 +98,10 @@
 company = company_obj.browse(cr, uid, company_id, context=context)
 company_currency_id = company.currency_id.id
 ctx['company_id'] = company.id
+if not obj.product_id:
+continue
 product = product_obj.read(cr, uid, obj.product_id.id,
['id','cost_price'], context=ctx)
-if not product:
-continue
 if obj.invoice_id.currency_id is None:
 currency_id = company_currency_id
 else:

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical_refactoring_step_I into lp:oemedical

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing code review

l.391 could you search the group with it's xml id group_oemedical_doctor 
instead of the name ?

Be careful, in xml you have a mix of spaces and tabs keep only spaces.
-- 
https://code.launchpad.net/~the-clone-master/oemedical/oemedical_refactoring_step_I/+merge/202240
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-fix-button-visibility into lp:purchase-wkfl

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no tests


-- 
https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-button-visibility/+merge/205304
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/product-kitting/7.0-fix_1293582-afe into lp:product-kitting

2014-03-17 Thread Pedro Manuel Baeza
Review: Approve code review

Seems OK. Good to see self.pool[] convention instead of self.pool.get()!

Regards.
-- 
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293582-afe/+merge/211358
Your team Product Core Editors is subscribed to branch lp:product-kitting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr into lp:margin-analysis

2014-03-17 Thread Pedro Manuel Baeza
Review: Needs Information code review

Why do you need to re-read product record? You can make:

product = obj.product_id

Or there is something I'm missing?

Regards.
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354
Your team Margin Analysis Core Editors is subscribed to branch 
lp:margin-analysis.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~factorlibre/sale-wkfl/sale-wkfl-7-partnerrisk-partnerinsurance into lp:sale-wkfl

2014-03-17 Thread Yannick Vaucher @ Camptocamp
Review: Needs Fixing

Hello Alberto,

Please adapt the code to community standards:

osv.osv - orm.Model
PEP8
replacement of mx.Datetime by datetime

ll.912 + 963 + 1114 ..

You can remove the class calls.

Cheers,
-- 
https://code.launchpad.net/~factorlibre/sale-wkfl/sale-wkfl-7-partnerrisk-partnerinsurance/+merge/209204
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl

2014-03-17 Thread Lionel Sausin - Numérigraphe
Lionel Sausin - Numérigraphe has proposed merging 
lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into 
lp:purchase-wkfl.

Requested reviews:
  Purchase Core Editors (purchase-core-editors)

For more details, see:
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374

This branch adds a new module which, when installed, creates one reception 
picking for each expected date on the purchase order.
This way stock workers have a clear view of which goods should be received when.

This modules uses the modular design of purchase orders to create several 
pickings rather that a single one: to the best f my knowledge, this should be 
compatible with the other modules in this branch.
-- 
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into 
lp:purchase-wkfl.
=== added directory 'purchase_delivery_split_date'
=== added file 'purchase_delivery_split_date/__init__.py'
--- purchase_delivery_split_date/__init__.py	1970-01-01 00:00:00 +
+++ purchase_delivery_split_date/__init__.py	2014-03-17 17:30:07 +
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+##
+#
+#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU General Public License as published by
+#the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU General Public License for more details.
+#
+#You should have received a copy of the GNU General Public License
+#along with this program.  If not, see http://www.gnu.org/licenses/.
+#
+##
+
+import purchase

=== added file 'purchase_delivery_split_date/__openerp__.py'
--- purchase_delivery_split_date/__openerp__.py	1970-01-01 00:00:00 +
+++ purchase_delivery_split_date/__openerp__.py	2014-03-17 17:30:07 +
@@ -0,0 +1,32 @@
+# -*- coding: utf-8 -*-
+##
+#
+#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU General Public License as published by
+#the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU General Public License for more details.
+#
+#You should have received a copy of the GNU General Public License
+#along with this program.  If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': Purchase Deliveries split by date,
+'version': '1.0',
+'author': u'Numérigraphe',
+'category': 'Purchase Management',
+'summary': Split Purchase Deliveries in one reception per expected date,
+'description': When this module is installed, each Purchase Order you 
+   confirm will generate one Reception Order per delivery
+   date indicated in the Purchase Order Lines.,
+'license': 'AGPL-3',
+depends: ['purchase'],
+}

=== added file 'purchase_delivery_split_date/purchase.py'
--- purchase_delivery_split_date/purchase.py	1970-01-01 00:00:00 +
+++ purchase_delivery_split_date/purchase.py	2014-03-17 17:30:07 +
@@ -0,0 +1,45 @@
+# -*- coding: utf-8 -*-
+##
+#
+#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU General Public License as published by
+#the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU General Public License for more details.
+#
+#You should have received a copy of the GNU General Public License
+#along with this 

Re: [Openerp-community-reviewer] [Merge] lp:~ajite/product-kitting/7.0-product-kitting-fix-0001 into lp:product-kitting

2014-03-17 Thread Augustin Cisterne-Kaas - www.elico-corp.com
Thanks Alexandre,

Well noted. I will do that next time.
-- 
https://code.launchpad.net/~ajite/product-kitting/7.0-product-kitting-fix-0001/+merge/209636
Your team Product Core Editors is subscribed to branch lp:product-kitting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp