[Openerp-connector-community] Dev branches for next releases

2014-03-19 Thread Guewen Baconnier

Hi there,

I started to create branches that will be the next releases of the 
connector framework and Magento connector.  They are not freezed; I will 
continue to merge the accepted proposal, but the most adventurous of you 
can already start to use them for development / testing.


The branches:
https://code.launchpad.net/~openerp-connector-core-editors/openerp-connector/7.0-next-release
https://code.launchpad.net/~openerp-connector-core-editors/openerp-connector-ecommerce/7.0-next-release
https://code.launchpad.net/~openerp-connector-core-editors/openerp-connector-magento/7.0-next-release

When upgrading, in addition to the usual update of `connector`, you will 
need to install the module `connector_base_product` that is now a 
dependency of connector_ecommerce (and OpenERP fails won't install a new 
dependency).


Thanks to the contributors!

--
Guewen Baconnier
Business Solutions Software Developer

Camptocamp SA
PSE A, CH-1015 Lausanne
Phone: +41 21 619 10 39
Office: +41 21 619 10 10
http://www.camptocamp.com/

--
Mailing list: https://launchpad.net/~openerp-connector-community
Post to : openerp-connector-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-connector-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] OCB branches, communitiy addons and tests

2014-03-19 Thread Leonardo Pistone
Thanks for raising that important point Nicolas.

Let us check what happened:

https://bugs.launchpad.net/openobject-addons/+bug/924200

If I understand correctly, Raphael Collet is saying that all periods in
demo data are allowed to overlap to allow people to create a chart of
accounts in a demo database. That is a special and non-standard situation
that breaks tests that use periods.

Integration tests (both unittest and yaml) use demo data. That means that
we use a very different setup for production and testing. That is
unfortunate, especially as we gradually start to take testing seriously -
at least there is a good trend in that respect in the community.

Best,
Leo


On Wed, Mar 19, 2014 at 8:41 AM, Nicolas Bessi nicolas.be...@camptocamp.com
 wrote:

 Hello,

 Due this bug
 https://bugs.launchpad.net/account-financial-report/+bug/1281579 we have
 some communitiy addons and MP that have green tests on OCB and red tests on
 official addons.
 That raises an interesting question, should community addons tests in
 priority been green against OCB branch, or official branches ?

  The answer to that question will have an impact on MP review and should
 be written on community review guideline.

 Regards

 Nicolas

 ___
 Mailing list: https://launchpad.net/~openerp-community
 Post to : openerp-community@lists.launchpad.net
 Unsubscribe : https://launchpad.net/~openerp-community
 More help   : https://help.launchpad.net/ListHelp


___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] OCB branches, communitiy addons and tests

2014-03-19 Thread Alexandre Fayolle
On mer. 19 mars 2014 08:41:49 CET, Nicolas Bessi wrote:
 Hello,

 Due this bug
 https://bugs.launchpad.net/account-financial-report/+bug/1281579 we
 have some communitiy addons and MP that have green tests on OCB and
 red tests on official addons.
 That raises an interesting question, should community addons tests in
 priority been green against OCB branch, or official branches ?


My vision on this:

1. In the general case, developers should strive to get the tests green
on both branches (OCA and Official). People who have never heard of OCA
and OCB are using community modules downloaded from apps.openerp.com
and having them break when they use the official branches is not a good
experience you are giving them. The end user is certainly not aware of
this issue and he will face the crash. Options : work around the known
bug in the official addon (e.g. by monkey patching until the merge is
done...)

2. in the specific case mentionned above, another similar MP was
rejected by Raphael Collet
(https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-924200-mdi/+merge/91058),
so I'm not sure merging the fix in the ocb addons branch was a good
idea, because it introduces a difference between both branches in the
demo data, and now we have red tests on the official branch, which will
make it hard to find when bugs are introduced in
account-financial-reports. I fear that the MP on the official branch
will never be considered or will be rejected and we will be stuck with
an awkward situation.

I'm interested to know it OpenERP SA's position has evolved since
Raphael's rejection of the MP.



--
Alexandre Fayolle
Chef de Projet
Tel : + 33 (0)4 79 26 57 94

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac Cedex
http://www.camptocamp.com


___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] Rationale for proposing the project openerp-nomenclature to join the OCA projects

2014-03-19 Thread Joël Grand-Guillaume
Hi Franco,


That would be a good idea IMO to have such project. Currently we have those
information in our localization for Switzerland at least. But would make
sense to have a project for all those kind of information.

Do you want me to create it ?

Regards,

Joël






On Sat, Mar 15, 2014 at 9:07 AM, Franco Tampieri 
franco.tampi...@abstract.it wrote:

 Hi Joel,

 Last days talking with Lionel, we have though to propose to create a team
 named: openerp-eu-data with subproject openerp-nomenclature: this project
 aims to contains all the data like bank address lists by nation, NACE
 categorization, City/ZIP address list and so on (Only Data in xml file
 format and very very little logic).

 What do you think?






 Franco Tampieri
 System Engineer




 _
 abstract.it - +39 06 9294 6938




 Registro Imprese di Napoli 788429 / Cap. Soc. 10.000 Euro I.V.
 Avvertenze Legali - D. Lgs. 196/03 Tutela dei dati personali. Le informazioni 
 contenute in questo messaggio
 e in ogni eventuale allegato sono riservate e ne è vietata ogni forma di 
 diffusione. Se avete ricevuto questa
 comunicazione per errore, Vi preghiamo di informare immediatamente il 
 mittente del messaggio e di eliminare l'e-mail.



 2014-03-13 10:23 GMT+01:00 Franco Tampieri franco.tampi...@abstract.it:

 Thats Good!

 Il giovedì 13 marzo 2014, Lionel Sausin l...@numerigraphe.com ha scritto:

 Le 13/03/2014 09:16, Franco Tampieri a écrit :

 Do you think that promote a new project like openerp-eu-data instead
 nomenclature will be more General purpose?

 On the contrary, I think a global project is more effective because it
 would mean a single team.
 In my experience I've seen that adapting the files is a know-how in
 itself: tracing the right sources, getting reliable files, hacking macros
 and scripts to re-format he files, adding translations, making them
 upgradeable...
 On the other hand you don't need to know a lot about the region
 beforehand, because those files are usually well described by the official
 bodies.

 If ever the main branch gets too large, we can always split them into
 region-specific branches inside the same project.

 Lionel.



 --





 Franco Tampieri
 System Engineer
 _




 abstract.it - +39 06 9294 6938





 Registro Imprese di Napoli 788429 / Cap. Soc. 10.000 Euro I.V.
 Avvertenze Legali - D. Lgs. 196/03 Tutela dei dati personali. Le 
 informazioni contenute in questo messaggio
 e in ogni eventuale allegato sono riservate e ne è vietata ogni forma di 
 diffusione. Se avete ricevuto questa
 comunicazione per errore, Vi preghiamo di informare immediatamente il 
 mittente del messaggio e di eliminare l'e-mail.






-- 


*camptocamp*
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS

*Joël Grand-Guillaume*
Division Manager
Business Solutions

+41 21 619 10 28
www.camptocamp.com
___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


[Openerp-community] [Merge] lp:~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss into lp:~openerp-community/server-env-tools/6.1-mass_editing

2014-03-19 Thread noreply
The proposal to merge 
lp:~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss into 
lp:~openerp-community/server-env-tools/6.1-mass_editing has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss/+merge/201321
-- 
https://code.launchpad.net/~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss/+merge/201321
Your team OpenERP Community is subscribed to branch 
lp:~openerp-community/server-env-tools/6.1-mass_editing.

___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] [Merge] lp:~openerp-community/server-env-tools/6.1-mass_editing into lp:server-env-tools/6.1

2014-03-19 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Approve


-- 
https://code.launchpad.net/~openerp-community/server-env-tools/6.1-mass_editing/+merge/161619
Your team OpenERP Community is subscribed to branch 
lp:~openerp-community/server-env-tools/6.1-mass_editing.

___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] [Merge] lp:~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss into lp:~openerp-community/server-env-tools/6.1-mass_editing

2014-03-19 Thread Guewen Baconnier @ Camptocamp
Review: Approve


-- 
https://code.launchpad.net/~therp-nl/server-env-tools/6.1-mass_editing-fix_dataloss/+merge/201321
Your team OpenERP Community is subscribed to branch 
lp:~openerp-community/server-env-tools/6.1-mass_editing.

___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] [Merge] lp:~openerp-community/server-env-tools/6.1-mass_editing into lp:server-env-tools/6.1

2014-03-19 Thread Stefan Rijnhart (Therp)
Review: Approve

Thanks for taking my suggestions!

-- 
https://code.launchpad.net/~openerp-community/server-env-tools/6.1-mass_editing/+merge/161619
Your team OpenERP Community is subscribed to branch 
lp:~openerp-community/server-env-tools/6.1-mass_editing.

___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


[Openerp-community] [Merge] lp:~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep into lp:openerp-product-attributes/6.1

2014-03-19 Thread Leonardo Pistone - camptocamp
Leonardo Pistone - camptocamp has proposed merging 
lp:~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep into 
lp:openerp-product-attributes/6.1.

Requested reviews:
  Product Core Editors (product-core-editors)
Related bugs:
  Bug #1294745 in OpenERP Product Attributes: [6.1] [7.0] 
product_custom_attributes, production_lot_custom_attributes: open by attribute 
set crashes on launguages other than English and French
  https://bugs.launchpad.net/openerp-product-attributes/+bug/1294745

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep/+merge/211798
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep/+merge/211798
Your team OpenERP Community is subscribed to branch 
lp:openerp-product-attributes/6.1.
=== modified file 'production_lot_custom_attributes/lot.py'
--- production_lot_custom_attributes/lot.py	2014-01-31 17:39:49 +
+++ production_lot_custom_attributes/lot.py	2014-03-19 18:03:02 +
@@ -24,7 +24,7 @@
 Production lot customization: custom attributes.
 
 from openerp.osv import fields, osv
-from tools.translate import _
+from tools.translate import translate, _
 from lxml import etree
 import re
 import itertools
@@ -217,6 +217,13 @@
 
 if context is None:
 context = {}
+
+def translate_view(source):
+Return a translation of type view of source.
+return translate(
+cr, None, 'view', context.get('lang'), source
+) or source
+
 attr_pool = self.pool.get('attribute.attribute')
 result = super(stock_production_lot, self).fields_view_get(
 cr, uid, view_id, view_type, context, toolbar=toolbar,
@@ -250,11 +257,11 @@
 # in this case, we know the attribute set beforehand, and we
 # add the attributes to the current view
 main_page = etree.Element(
-'page', string=_('Custom Attributes')
+'page', string=translate_view('Custom Attributes')
 )
 main_page.append(attributes_notebook)
 info_page = eview.xpath(
-//page[@string='%s'] % (_('Stock Moves'),)
+//page[@string='%s'] % (translate_view('Stock Moves'),)
 )[0]
 info_page.addnext(main_page)
 result['arch'] = etree.tostring(eview, pretty_print=True)

___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community] [Merge] lp:~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep into lp:openerp-product-attributes/6.1

2014-03-19 Thread Pedro Manuel Baeza
Review: Approve code review

Same as 7.0.

Do you still need _ import for this version? BTW, I approve it because this is 
not a blocking issue

Regards.
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep/+merge/211798
Your team OpenERP Community is subscribed to branch 
lp:openerp-product-attributes/6.1.

___
Mailing list: https://launchpad.net/~openerp-community
Post to : openerp-community@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into lp:account-financial-report

2014-03-19 Thread Nicolas Bessi - Camptocamp
Hello,
Stéphan is right,

Test runs perfectly on OCB, that is the branches I used to developp communitiy 
addons.

Regards

Nicolas

2014-03-18 15:53:58,357 27853 INFO test_aged_partner openerp.modules.loading: 
module account_financial_report_webkit: loading tests/aged_trial_balance.yml
2014-03-18 15:53:58,364 27853 TEST test_aged_partner openerp.tools.yaml_import: 
In order to test the PDF Aged Partner Balance Report webkit wizard I will print 
report with defau
lt setting  


2014-03-18 15:53:58,815 27853 TEST test_aged_partner openerp.tools.yaml_import: 
In order to test the PDF Aged Partner Balance Report webkit wizard I will print 
report with filte
rs and currency 


2014-03-18 15:53:59,269 27853 TEST test_aged_partner openerp.tools.yaml_import: 
In order to test the PDF Aged Partner Balance Report webkit wizard I will print 
report with filte
rs on partners  


2014-03-18 15:53:59,706 27853 TEST test_aged_partner openerp.tools.yaml_import: 
In order to test the PDF Aged Partner Balance Report webkit wizard I will print 
report with filte
rs on periods   


2014-03-18 15:54:00,145 27853 TEST test_aged_partner openerp.tools.yaml_import: 
In order to test the PDF Aged Partner Balance Report webkit wizard I will print 
report with filte
rs on dates 


2014-03-18 15:54:00,597 27853 INFO test_aged_partner 
openerp.addons.base.ir.ir_translation: module account_financial_report_webkit: 
loading translation file (en_US) for language
 en_US  


2014-03-18 15:54:00,597 27853 INFO test_aged_partner openerp.tools.translate: 
loading 
/home/nbessi/oe/predige_openerp/openerp_trunk_predige/parts/account-financial-report/accoun
-- 
https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040
Your team Account Report Core Editors is subscribed to branch 
lp:account-financial-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into lp:account-financial-report

2014-03-19 Thread Alexandre Fayolle - camptocamp
ok my bad. I generally run the OCA tests on the official branch... 

Still with the OCB branch, the test requires some specific setup:

 here: http://code.google.com/p/wkhtmltopdf/downloads/list and set the path in 
the ir.config_parameter with the webkit_path key.Minimal version is 0.9.9')
Traceback (most recent call last):
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/yaml_import.py,
 line 864, in process
self._process_node(node)
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/yaml_import.py,
 line 877, in _process_node
self.process_python(node)
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/yaml_import.py,
 line 550, in process_python
unsafe_eval(code_obj, {'ref': self.get_id}, code_context)
  File 
/home/afayolle/work/oca/account-financial-reports/add_aged_partner_ledger-nbi/account_financial_report_webkit/tests/general_ledger.yml,
 line 5, in module
ctx={}
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/test_reports.py,
 line 294, in try_report_action
result = _exec_action(action, datas, context)
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/test_reports.py,
 line 278, in _exec_action
res = try_report(cr, uid, 'report.'+action['report_name'], ids, datas, 
context, our_module=our_module)
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/test_reports.py,
 line 53, in try_report
res = netsvc.LocalService(rname).create(cr, uid, ids, data, context)
  File 
/home/afayolle/work/oerp/addons/ocb-7.0/report_webkit/webkit_report.py, line 
340, in create
result = self.create_source_pdf(cursor, uid, ids, data, report_xml, context)
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/report/report_sxw.py,
 line 511, in create_source_pdf
return self.create_single_pdf(cr, uid, ids, data, report_xml, context)
  File 
/home/afayolle/work/oca/account-financial-reports/add_aged_partner_ledger-nbi/account_financial_report_webkit/report/webkit_parser_header_fix.py,
 line 244, in create_single_pdf
bin = self.get_lib(cursor, uid)
  File 
/home/afayolle/work/oerp/addons/ocb-7.0/report_webkit/webkit_report.py, line 
96, in get_lib
_('Please install executable on your system' \
except_osv: (u'Wkhtmltopdf library path is not set', u'Please install 
executable on your system (sudo apt-get install wkhtmltopdf) or download it 
from here: http://code.google.com/p/wkhtmltopdf/downloads/list and set the path 
in the ir.config_parameter with the webkit_path key.Minimal version is 0.9.9')
2014-03-19 07:51:04,798 10999 ERROR test_ocb70 openerp.modules.loading: module 
account_financial_report_webkit: an exception occurred in a test
Traceback (most recent call last):
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/modules/loading.py,
 line 83, in load_test
_load_data(cr, module_name, idref, mode, 'test')
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/modules/loading.py,
 line 122, in _load_data
tools.convert_yaml_import(cr, module_name, fp, kind, idref, mode, noupdate, 
report)
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/yaml_import.py,
 line 928, in yaml_import
yaml_interpreter.process(yaml_string)
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/yaml_import.py,
 line 864, in process
self._process_node(node)
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/yaml_import.py,
 line 877, in _process_node
self.process_python(node)
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/yaml_import.py,
 line 550, in process_python
unsafe_eval(code_obj, {'ref': self.get_id}, code_context)
  File 
/home/afayolle/work/oca/account-financial-reports/add_aged_partner_ledger-nbi/account_financial_report_webkit/tests/general_ledger.yml,
 line 5, in module
ctx={}
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/test_reports.py,
 line 294, in try_report_action
result = _exec_action(action, datas, context)
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/test_reports.py,
 line 278, in _exec_action
res = try_report(cr, uid, 'report.'+action['report_name'], ids, datas, 
context, our_module=our_module)
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/tools/test_reports.py,
 line 53, in try_report
res = netsvc.LocalService(rname).create(cr, uid, ids, data, context)
  File 
/home/afayolle/work/oerp/addons/ocb-7.0/report_webkit/webkit_report.py, line 
340, in create
result = self.create_source_pdf(cursor, uid, ids, data, report_xml, context)
  File 
/home/afayolle/work/oerp/openobject-server/ocb-7.0/openerp/report/report_sxw.py,
 line 511, in create_source_pdf
return self.create_single_pdf(cr, uid, ids, data, report_xml, context)
  File 

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready into lp:ocb-addons

2014-03-19 Thread noreply
The proposal to merge 
lp:~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready into 
lp:ocb-addons has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready/+merge/210965
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready/+merge/210965
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde into lp:carriers-deliveries/6.1

2014-03-19 Thread Yannick Vaucher @ Camptocamp
The proposal to merge 
lp:~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde into 
lp:carriers-deliveries/6.1 has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde/+merge/210772
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde/+merge/210772
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde into lp:carriers-deliveries/6.1

2014-03-19 Thread Leonardo Pistone - camptocamp
Review: Approve code review

ok
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde/+merge/210772
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde into lp:carriers-deliveries/6.1

2014-03-19 Thread noreply
The proposal to merge 
lp:~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde into 
lp:carriers-deliveries/6.1 has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde/+merge/210772
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-fix-base_delivery_carrier_files-rde/+merge/210772
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/account-invoicing/7.0-lp1294623-invoic_id_on_analytic_line into lp:account-invoicing

2014-03-19 Thread Lara (Therp)
Review: Approve test


-- 
https://code.launchpad.net/~therp-nl/account-invoicing/7.0-lp1294623-invoic_id_on_analytic_line/+merge/211708
Your team Account Core Editors is requested to review the proposed merge of 
lp:~therp-nl/account-invoicing/7.0-lp1294623-invoic_id_on_analytic_line into 
lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/product-kitting/7.0-fix_1293582-afe into lp:product-kitting

2014-03-19 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~camptocamp/product-kitting/7.0-fix_1293582-afe into 
lp:product-kitting has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293582-afe/+merge/211358
-- 
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293582-afe/+merge/211358
Your team Product Core Editors is subscribed to branch lp:product-kitting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/product-kitting/7.0-fix_1293582-afe into lp:product-kitting

2014-03-19 Thread Yannick Vaucher @ Camptocamp
Review: Approve

LGTM
-- 
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293582-afe/+merge/211358
Your team Product Core Editors is subscribed to branch lp:product-kitting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/product-kitting/7.0-fix_1293582-afe into lp:product-kitting

2014-03-19 Thread noreply
The proposal to merge lp:~camptocamp/product-kitting/7.0-fix_1293582-afe into 
lp:product-kitting has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293582-afe/+merge/211358
-- 
https://code.launchpad.net/~camptocamp/product-kitting/7.0-fix_1293582-afe/+merge/211358
Your team Product Core Editors is subscribed to branch lp:product-kitting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/stock-logistic-flows/70-product_serial-plus-plus into lp:stock-logistic-flows

2014-03-19 Thread Alexis de Lattre
@Alexandre

Thanks for your review.

You are right, the fact that I don't call super() on 
_create_pickings_and_procurements() in the module product_serial_sale_stock is 
a big problem and I am aware of that. But, unfortunately, I didn't find a 
solution that includes calling super(). If you think it's possible, please give 
me some ideas !

I am not an expert of monkey patching, but I'll see with my colleagues if it is 
possible.

And thanks for pointing out my mistakes on English irregular verbs :)
-- 
https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-product_serial-plus-plus/+merge/195144
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-flows.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~openerp-community/server-env-tools/6.1-mass_editing into lp:server-env-tools/6.1

2014-03-19 Thread Sandy Carter (http://www.savoirfairelinux.com)
Review: Approve


-- 
https://code.launchpad.net/~openerp-community/server-env-tools/6.1-mass_editing/+merge/161619
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~openerp-community/server-env-tools/6.1-mass_editing into lp:server-env-tools/6.1

2014-03-19 Thread Stefan Rijnhart (Therp)
Review: Approve

Thanks for taking my suggestions!

-- 
https://code.launchpad.net/~openerp-community/server-env-tools/6.1-mass_editing/+merge/161619
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons

2014-03-19 Thread Nicolas Bessi - Camptocamp
Hello Stefan,

I prefer to do it in an other MP, in order to fix the case of plain password as 
soon as possible.

Also the refactoring using the passlib will probably be done against the trunk 
branch as there is some difference in implementation and I'm not sure at the 
current time they are fully compatible.

Regards

Nicolas
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/206364
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons

2014-03-19 Thread Stefan Rijnhart (Therp)
Review: Approve

OK, thanks for the info!

-- 
https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/206364
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons

2014-03-19 Thread Nicolas Bessi - Camptocamp
The proposal to merge lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into 
lp:ocb-addons has been updated.

Status: Needs review = Work in progress

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/206364
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/206364
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-stock_split_picking-display-button into lp:stock-logistic-flows

2014-03-19 Thread Guewen Baconnier @ Camptocamp
Guewen Baconnier @ Camptocamp has proposed merging 
lp:~camptocamp/stock-logistic-flows/7.0-stock_split_picking-display-button into 
lp:stock-logistic-flows.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_split_picking-display-button/+merge/211739

One may want to split a draft or confirmed delivery order, not only a available 
one.
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_split_picking-display-button/+merge/211739
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/stock-logistic-flows/7.0-stock_split_picking-display-button into 
lp:stock-logistic-flows.
=== modified file 'stock_split_picking/view/stock_partial_picking.xml'
--- stock_split_picking/view/stock_partial_picking.xml	2013-08-13 19:00:02 +
+++ stock_split_picking/view/stock_partial_picking.xml	2014-03-19 14:24:40 +
@@ -8,7 +8,7 @@
   field name=arch type=xml
 field name =state position=before
   button name=split_process
-  states=assigned
+  states=draft,confirmed,assigned
   string=Split
   groups=stock.group_stock_user
   type=object/

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons

2014-03-19 Thread Nicolas Bessi - Camptocamp
Ho I got your point Stefan, 

I missed the answer of Olivier on addons MP

For this part, your init() method looks fine, but there are already multiple 
instances of the salting+hashing dance. As you're adding one more, it seems a 
good opportunity to refactor a bit and extract that pattern into a private 
method, something like:

def _set_user_password(self, cr, uid, user_id, password, context=None):
 password_hash = md5_crypt(password, gen_salt()) # TODO: update default 
algo in trunk
 cr.execute(UPDATE res_users SET password='', password_crypt=%s WHERE 
id=%s,
(password_hash, user_id))

Yes I should do it
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/206364
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons

2014-03-19 Thread Nicolas Bessi - Camptocamp
I have done the small refactor proposed by Olivier (not the one with passlib).

Please redo a quick review before merging.

Regards

Nicolas
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/206364
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons

2014-03-19 Thread Nicolas Bessi - Camptocamp
Nicolas Bessi - Camptocamp has proposed merging 
lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons.

Requested reviews:
  Nicolas Bessi - Camptocamp (nbessi-c2c)
  Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c): code review, no test
  Stefan Rijnhart (Therp) (stefan-therp)
Related bugs:
  Bug #1280152 in OpenERP Addons: [7.0]Auth crypt encrypts passwords lazily 
and deactivated users will never have password encrypted
  https://bugs.launchpad.net/openobject-addons/+bug/1280152

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/211750

(Improve module auth_crypt use sha256 by default to encrypt password. The 
modification keeps retro compatibility.) REMOVED as OpenERP will not merge this 
part

Add an init function on res.users to encrypt all passwords when installing 
module and avoid plain password for deactivated users.
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/211750
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.
=== modified file 'auth_crypt/auth_crypt.py'
--- auth_crypt/auth_crypt.py	2013-08-12 10:29:50 +
+++ auth_crypt/auth_crypt.py	2014-03-19 14:54:21 +
@@ -105,6 +105,7 @@
 
 return magic + salt + '$' + rearranged
 
+
 def sh256crypt(cls, password, salt, magic=magic_sha256):
 iterations = 1000
 # see http://en.wikipedia.org/wiki/PBKDF2
@@ -114,16 +115,41 @@
 result = result.encode('base64') # doesnt seem to be crypt(3) compatible
 return '%s%s$%s' % (magic_sha256, salt, result)
 
+
 class res_users(osv.osv):
 _inherit = res.users
 
+def init(self, cr):
+Encrypt all passwords at module installation
+cr.execute(SELECT id, password FROM res_users WHERE password != '',)
+to_encrypt = cr.fetchall()
+if to_encrypt:
+for user in to_encrypt:
+self._set_encrypted_password(cr, user[0], user[1])
+return True
+
+def _set_encrypted_password(self, cr, user_id, plain_password):
+Set an encrypted password for a given user
+
+:param cr: database cursor
+:param user_id: user_id
+:param plain_password: plain password to encrypt
+
+:returns: user id
+
+
+salt = gen_salt()
+stored_password_crypt = md5crypt(plain_password, salt)
+cr.execute(UPDATE res_users SET password='', password_crypt=%s WHERE id=%s,
+   (stored_password_crypt, user_id))
+return user_id
+
 def set_pw(self, cr, uid, id, name, value, args, context):
 if value:
-encrypted = md5crypt(value, gen_salt())
-cr.execute(update res_users set password='', password_crypt=%s where id=%s, (encrypted, id))
+self._set_encrypted_password(cr, id, value)
 del value
 
-def get_pw( self, cr, uid, ids, name, args, context ):
+def get_pw(self, cr, uid, ids, name, args, context):
 cr.execute('select id, password from res_users where id in %s', (tuple(map(int, ids)),))
 stored_pws = cr.fetchall()
 res = {}
@@ -144,9 +170,7 @@
 if cr.rowcount:
 stored_password, stored_password_crypt = cr.fetchone()
 if stored_password and not stored_password_crypt:
-salt = gen_salt()
-stored_password_crypt = md5crypt(stored_password, salt)
-cr.execute(UPDATE res_users SET password='', password_crypt=%s WHERE id=%s, (stored_password_crypt, uid))
+self._set_encrypted_password(cr, uid, stored_password)
 try:
 return super(res_users, self).check_credentials(cr, uid, password)
 except openerp.exceptions.AccessDenied:

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/improve_auth_crypt-nbi into lp:ocb-addons

2014-03-19 Thread Pedro Manuel Baeza
Review: Approve code review

LGTM!

Better to have only one method that makes the encryption.

Thanks.
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/improve_auth_crypt-nbi/+merge/206364
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-fix-translate-view-lep into lp:openerp-product-attributes

2014-03-19 Thread Leonardo Pistone - camptocamp
Leonardo Pistone - camptocamp has proposed merging 
lp:~camptocamp/openerp-product-attributes/7.0-fix-translate-view-lep into 
lp:openerp-product-attributes.

Requested reviews:
  Product Core Editors (product-core-editors)
Related bugs:
  Bug #1294745 in OpenERP Product Attributes: [6.1] [7.0] 
product_custom_attributes, production_lot_custom_attributes: open by attribute 
set crashes on launguages other than English and French
  https://bugs.launchpad.net/openerp-product-attributes/+bug/1294745

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-fix-translate-view-lep/+merge/211792
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-fix-translate-view-lep/+merge/211792
Your team Product Core Editors is requested to review the proposed merge of 
lp:~camptocamp/openerp-product-attributes/7.0-fix-translate-view-lep into 
lp:openerp-product-attributes.
=== modified file 'product_custom_attributes/product.py'
--- product_custom_attributes/product.py	2013-09-30 11:55:27 +
+++ product_custom_attributes/product.py	2014-03-19 17:49:16 +
@@ -23,7 +23,7 @@
 from openerp.osv import fields
 from openerp.osv.osv import except_osv
 from openerp.osv.orm import setup_modifiers
-from tools.translate import _
+from tools.translate import translate
 from lxml import etree
 
 class product_template(Model):
@@ -91,6 +91,13 @@
 def fields_view_get(self, cr, uid, view_id=None, view_type='form', context=None, toolbar=False, submenu=False):
 if context is None:
 context = {}
+
+def translate_view(source):
+Return a translation of type view of source.
+return translate(
+cr, None, 'view', context.get('lang'), source
+) or source
+
 result = super(product_product, self).fields_view_get(cr, uid, view_id,view_type,context,toolbar=toolbar, submenu=submenu)
 if view_type == 'form' and context.get('attribute_group_ids'):
 eview = etree.fromstring(result['arch'])
@@ -105,9 +112,14 @@
 placeholder = eview.xpath(//separator[@string='attributes_placeholder'])[0]
 placeholder.getparent().replace(placeholder, attributes_notebook)
 elif context.get('open_product_by_attribute_set'):
-main_page = etree.Element('page', string=_('Custom Attributes'))
+main_page = etree.Element(
+'page',
+string=translate_view('Custom Attributes')
+)
 main_page.append(attributes_notebook)
-info_page = eview.xpath(//page[@string='%s'] % (_('Information'),))[0]
+info_page = eview.xpath(
+//page[@string='%s'] % (translate_view('Information'),)
+)[0]
 info_page.addnext(main_page)
 result['arch'] = etree.tostring(eview, pretty_print=True)
 result = self._fix_size_bug(cr, uid, result, context=context)

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep into lp:openerp-product-attributes/6.1

2014-03-19 Thread Leonardo Pistone - camptocamp
Leonardo Pistone - camptocamp has proposed merging 
lp:~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep into 
lp:openerp-product-attributes/6.1.

Requested reviews:
  Product Core Editors (product-core-editors)
Related bugs:
  Bug #1294745 in OpenERP Product Attributes: [6.1] [7.0] 
product_custom_attributes, production_lot_custom_attributes: open by attribute 
set crashes on launguages other than English and French
  https://bugs.launchpad.net/openerp-product-attributes/+bug/1294745

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep/+merge/211798
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep/+merge/211798
Your team Product Core Editors is requested to review the proposed merge of 
lp:~camptocamp/openerp-product-attributes/6.1-fix-translate-view-lep into 
lp:openerp-product-attributes/6.1.
=== modified file 'production_lot_custom_attributes/lot.py'
--- production_lot_custom_attributes/lot.py	2014-01-31 17:39:49 +
+++ production_lot_custom_attributes/lot.py	2014-03-19 18:03:02 +
@@ -24,7 +24,7 @@
 Production lot customization: custom attributes.
 
 from openerp.osv import fields, osv
-from tools.translate import _
+from tools.translate import translate, _
 from lxml import etree
 import re
 import itertools
@@ -217,6 +217,13 @@
 
 if context is None:
 context = {}
+
+def translate_view(source):
+Return a translation of type view of source.
+return translate(
+cr, None, 'view', context.get('lang'), source
+) or source
+
 attr_pool = self.pool.get('attribute.attribute')
 result = super(stock_production_lot, self).fields_view_get(
 cr, uid, view_id, view_type, context, toolbar=toolbar,
@@ -250,11 +257,11 @@
 # in this case, we know the attribute set beforehand, and we
 # add the attributes to the current view
 main_page = etree.Element(
-'page', string=_('Custom Attributes')
+'page', string=translate_view('Custom Attributes')
 )
 main_page.append(attributes_notebook)
 info_page = eview.xpath(
-//page[@string='%s'] % (_('Stock Moves'),)
+//page[@string='%s'] % (translate_view('Stock Moves'),)
 )[0]
 info_page.addnext(main_page)
 result['arch'] = etree.tostring(eview, pretty_print=True)

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0

2014-03-19 Thread El Hadji Dem (http://www.savoirfairelinux.com)
El Hadji Dem (http://www.savoirfairelinux.com) has proposed merging 
lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into 
lp:knowledge-addons/7.0.

Requested reviews:
  Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter): code review, 
test

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960

Added document_multiple_records module: It allows to manage a document with a 
multiple records.
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:knowledge-addons/7.0.
=== added directory 'document_multiple_records'
=== added file 'document_multiple_records/__init__.py'
--- document_multiple_records/__init__.py	1970-01-01 00:00:00 +
+++ document_multiple_records/__init__.py	2014-03-19 15:30:33 +
@@ -0,0 +1,26 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see http://www.gnu.org/licenses/.
+#
+###
+
+from . import document
+from . import wizard
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'document_multiple_records/__openerp__.py'
--- document_multiple_records/__openerp__.py	1970-01-01 00:00:00 +
+++ document_multiple_records/__openerp__.py	2014-03-19 15:30:33 +
@@ -0,0 +1,60 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'Document Management System for Multiple Records',
+'version': '0.1',
+'category': 'Knowledge Management',
+'summary': 'Document Management System for Multiple Records',
+'description': 
+Document Management System for Multiple Records
+==
+
+Contributors
+
+* El Hadji Dem (elhadji@savoirfairelinux.com)
+,
+'author': 'Savoir-faire Linux',
+'website': 'www.savoirfairelinux.com',
+'license': 'AGPL-3',
+'depends': [
+'document',
+],
+'data': [
+'document_view.xml',
+'security/ir.model.access.csv',
+'wizard/document_wizard_view.xml',
+],
+'js': [
+'static/src/js/document.js'
+],
+'qweb': [
+'static/src/xml/document.xml'
+],
+'test': [],
+'demo': [
+],
+'installable': True,
+'auto_install': False,
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'document_multiple_records/document.py'
--- document_multiple_records/document.py	1970-01-01 00:00:00 +
+++ document_multiple_records/document.py	2014-03-19 15:30:33 +
@@ -0,0 +1,96 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the 

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-server/7.0-fix-po-targets-933496-vmt into lp:ocb-server

2014-03-19 Thread Pedro Manuel Baeza
Review: Approve code review

I have checked at last the problem and see that the problem doesn't come from 
patch itself, but from pot files, so you can unlock both MPs.

I give also my approval to this.
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-server/7.0-fix-po-targets-933496-vmt/+merge/209895
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into lp:knowledge-addons/7.0

2014-03-19 Thread Sandy Carter (http://www.savoirfairelinux.com)
You have been requested to review the proposed merge of 
lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into 
lp:knowledge-addons/7.0.

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960

Added document_multiple_records module: It allows to manage a document with a 
multiple records.

-- 
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/document_multiple_records/+merge/206960
Your team OpenERP Community Reviewer/Maintainer is requested to review the 
proposed merge of 
lp:~savoirfairelinux-openerp/knowledge-addons/document_multiple_records into 
lp:knowledge-addons/7.0.
=== added directory 'document_multiple_records'
=== added file 'document_multiple_records/__init__.py'
--- document_multiple_records/__init__.py	1970-01-01 00:00:00 +
+++ document_multiple_records/__init__.py	2014-03-19 15:30:33 +
@@ -0,0 +1,26 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see http://www.gnu.org/licenses/.
+#
+###
+
+from . import document
+from . import wizard
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'document_multiple_records/__openerp__.py'
--- document_multiple_records/__openerp__.py	1970-01-01 00:00:00 +
+++ document_multiple_records/__openerp__.py	2014-03-19 15:30:33 +
@@ -0,0 +1,60 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'Document Management System for Multiple Records',
+'version': '0.1',
+'category': 'Knowledge Management',
+'summary': 'Document Management System for Multiple Records',
+'description': 
+Document Management System for Multiple Records
+==
+
+Contributors
+
+* El Hadji Dem (elhadji@savoirfairelinux.com)
+,
+'author': 'Savoir-faire Linux',
+'website': 'www.savoirfairelinux.com',
+'license': 'AGPL-3',
+'depends': [
+'document',
+],
+'data': [
+'document_view.xml',
+'security/ir.model.access.csv',
+'wizard/document_wizard_view.xml',
+],
+'js': [
+'static/src/js/document.js'
+],
+'qweb': [
+'static/src/xml/document.xml'
+],
+'test': [],
+'demo': [
+],
+'installable': True,
+'auto_install': False,
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'document_multiple_records/document.py'
--- document_multiple_records/document.py	1970-01-01 00:00:00 +
+++ document_multiple_records/document.py	2014-03-19 15:30:33 +
@@ -0,0 +1,96 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#(http://www.savoirfairelinux.com).
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software 

[Openerp-community-reviewer] [Bug 933496] Re: Mismatching PO comments cause translation issues: translations present in PO not visible in GUI

2014-03-19 Thread Pedro Manuel Baeza
I've filled this bug:

lp:1294887

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is a bug assignee.
https://bugs.launchpad.net/bugs/933496

Title:
  Mismatching PO comments cause translation issues: translations present
  in PO not visible in GUI

Status in OpenERP Community Backports (Server):
  New
Status in OpenERP Community Backports (Server) 6.1 series:
  Fix Committed
Status in OpenERP Community Backports (Server) 7.0 series:
  New
Status in OpenERP Server:
  Fix Committed

Bug description:
  In v6.0, it seems that many translations are not show in the gui anymore 
because the corresponding comments has been removed from the .po file.
  As stated by Olivier: The problem is that PO templates entries are not only 
shared between series, but their comments are shared as well, regardless of the 
destination series.
  So Launchpad removes the comments needed for v6.0 when they disappear from 
the trunk.

  For example, revno 4983 contains:
  @@ -10132,14 +10038,13 @@
   #: report:account.invoice:0
   #: view:account.invoice:0
   #: view:account.invoice.refund:0
  -#: selection:account.invoice.refund,filter_refund:0
   #: view:account.invoice.report:0
   #: model:ir.actions.act_window,name:account.action_account_invoice_refund
   msgid Refund
   msgstr Créer un avoir
  That makes the string Refund untranslatable in the selection on the refund 
wizard.

  If you export the PO file from a running instance of OpenERP, it will
  be generated correctly however.

  Lionel.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-server/+bug/933496/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Bug 1294887] [NEW] [6.1/7.0/trunk] Translation exported is not complete

2014-03-19 Thread Pedro Manuel Baeza
Public bug reported:

This has been detected from bug lp:933496, where a missing translation
has triggered an investigation about that.

In purchase module, you have this menu definition:

   menuitem icon=terp-purchase id=base.menu_purchase_root 
name=Purchases sequence=3
   groups=group_purchase_manager,group_purchase_user
   web_icon=images/purchases.png
   web_icon_hover=images/purchases-hover.png/

Exporting pot file, I get:

#. module: purchase
#: model:ir.actions.act_window,name:purchase.action_purchase_line_product_tree
#: model:ir.actions.act_window,name:purchase.open_board_purchase
#: model:ir.ui.menu,name:purchase.menu_board_purchase
#: model:ir.ui.menu,name:purchase.menu_purchase_config
#: view:res.partner:0
msgid Purchases
msgstr 

But it must be another one comment that is missing:

#: model:ir.ui.menu,name:base.menu_purchase_root

Maybe the problem is because XML ID module is 'base' instead 'purchase',
but if I export 'base' module, this comment isn't exported also.

** Affects: ocb-server
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Server).
https://bugs.launchpad.net/bugs/1294887

Title:
  [6.1/7.0/trunk] Translation exported is not complete

Status in OpenERP Community Backports (Server):
  New

Bug description:
  This has been detected from bug lp:933496, where a missing translation
  has triggered an investigation about that.

  In purchase module, you have this menu definition:

 menuitem icon=terp-purchase id=base.menu_purchase_root 
name=Purchases sequence=3
 groups=group_purchase_manager,group_purchase_user
 web_icon=images/purchases.png
 web_icon_hover=images/purchases-hover.png/

  Exporting pot file, I get:

  #. module: purchase
  #: model:ir.actions.act_window,name:purchase.action_purchase_line_product_tree
  #: model:ir.actions.act_window,name:purchase.open_board_purchase
  #: model:ir.ui.menu,name:purchase.menu_board_purchase
  #: model:ir.ui.menu,name:purchase.menu_purchase_config
  #: view:res.partner:0
  msgid Purchases
  msgstr 

  But it must be another one comment that is missing:

  #: model:ir.ui.menu,name:base.menu_purchase_root

  Maybe the problem is because XML ID module is 'base' instead
  'purchase', but if I export 'base' module, this comment isn't exported
  also.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-server/+bug/1294887/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp