Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact into lp:partner-contact-management

[Sandy Carter (http://www.savoirfairelinux.com)]

Any update on this?
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact/+merge/203979
Your team Partner and Contact Core Editors is requested to review the proposed 
merge of 
lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact
 into lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/server-env-tools/l10n into lp:server-env-tools

[Pedro Manuel Baeza]

The proposal to merge lp:~savoirfairelinux-openerp/server-env-tools/l10n into 
lp:server-env-tools has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/server-env-tools/l10n/+merge/20
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/server-env-tools/l10n/+merge/20
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/server-env-tools/l10n into lp:server-env-tools

[Maxime Chambreuil (http://www.savoirfairelinux.com)]

Review: Approve


-- 
https://code.launchpad.net/~savoirfairelinux-openerp/server-env-tools/l10n/+merge/20
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/server-env-tools/l10n into lp:server-env-tools

[Pedro Manuel Baeza]

Review: Approve code review

Thank you very much for the huge work of generating all pot files.

Regards.
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/server-env-tools/l10n/+merge/20
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into lp:ocb-addons

[Raphaël Valyi - http : //www . akretion . com]

Review: Approve

OCB is for consenting adults, it's a very trivial schema change.
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/209917
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/server-env-tools/l10n into lp:server-env-tools

[Davin Baragiotta]

Review: Approve

Let's translate it in French! Yay!
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/server-env-tools/l10n/+merge/20
Your team Server Environment And Tools Core Editors is requested to review the 
proposed merge of lp:~savoirfairelinux-openerp/server-env-tools/l10n into 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/server-env-tools/l10n into lp:server-env-tools

[Sandy Carter (http://www.savoirfairelinux.com)]

The proposal to merge lp:~savoirfairelinux-openerp/server-env-tools/l10n into 
lp:server-env-tools has been updated.

Description changed to:

Generated each .pot file so translating through the launchpad interface is 
possible.

This change should seem trivially good.

Thank you for reviewing.

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/server-env-tools/l10n/+merge/20
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/server-env-tools/l10n/+merge/20
Your team Server Environment And Tools Core Editors is requested to review the 
proposed merge of lp:~savoirfairelinux-openerp/server-env-tools/l10n into 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/server-env-tools/l10n into lp:server-env-tools

[Sandy Carter (http://www.savoirfairelinux.com)]

Sandy Carter (http://www.savoirfairelinux.com) has proposed merging 
lp:~savoirfairelinux-openerp/server-env-tools/l10n into lp:server-env-tools.

Requested reviews:
  Server Environment And Tools Core Editors (server-env-tools-core-editors)

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/server-env-tools/l10n/+merge/20

Generated each .pot file so translating through the interface is possible.

This change should seem trivially good.

Thank you for reviewing.
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/server-env-tools/l10n/+merge/20
Your team Server Environment And Tools Core Editors is requested to review the 
proposed merge of lp:~savoirfairelinux-openerp/server-env-tools/l10n into 
lp:server-env-tools.
=== added directory 'base_optional_quick_create/i18n'
=== added file 'base_optional_quick_create/i18n/base_optional_quick_create.pot'
--- base_optional_quick_create/i18n/base_optional_quick_create.pot	1970-01-01 00:00:00 +
+++ base_optional_quick_create/i18n/base_optional_quick_create.pot	2014-03-14 17:45:38 +
@@ -0,0 +1,40 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* base_optional_quick_create
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-03-14 17:41+\n"
+"PO-Revision-Date: 2014-03-14 17:41+\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: base_optional_quick_create
+#: model:_description:0
+#: model:ir.model,name:base_optional_quick_create.model_ir_model
+msgid "Models"
+msgstr ""
+
+#. module: base_optional_quick_create
+#: code:addons/base_optional_quick_create/model.py:35
+#, python-format
+msgid "Can't create quickly. Opening create form"
+msgstr ""
+
+#. module: base_optional_quick_create
+#: field:ir.model,avoid_quick_create:0
+msgid "Avoid quick create"
+msgstr ""
+
+#. module: base_optional_quick_create
+#: code:addons/base_optional_quick_create/model.py:35
+#, python-format
+msgid "Error"
+msgstr ""
+

=== modified file 'cron_run_manually/i18n/cron_run_manually.pot'
--- cron_run_manually/i18n/cron_run_manually.pot	2013-08-12 18:58:33 +
+++ cron_run_manually/i18n/cron_run_manually.pot	2014-03-14 17:45:38 +
@@ -6,8 +6,8 @@
 msgstr ""
 "Project-Id-Version: OpenERP Server 7.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2013-08-12 18:26+\n"
-"PO-Revision-Date: 2013-08-12 18:26+\n"
+"POT-Creation-Date: 2014-03-14 17:41+\n"
+"PO-Revision-Date: 2014-03-14 17:41+\n"
 "Last-Translator: <>\n"
 "Language-Team: \n"
 "MIME-Version: 1.0\n"
@@ -16,24 +16,32 @@
 "Plural-Forms: \n"
 
 #. module: cron_run_manually
-#: code:addons/cron_run_manually/model/ir_cron.py:71
+#: code:addons/cron_run_manually/model/ir_cron.py:77
 #, python-format
 msgid "Another process/thread is already busy executing this job"
-msgstr "Another process/thread is already busy executing this job"
+msgstr ""
 
 #. module: cron_run_manually
 #: view:ir.cron:0
 msgid "Run now"
-msgstr "Run now"
-
-#. module: cron_run_manually
+msgstr ""
+
+#. module: cron_run_manually
+#: code:addons/cron_run_manually/model/ir_cron.py:52
+#, python-format
+msgid "Only the admin user is allowed to execute inactive cron jobs manually"
+msgstr ""
+
+#. module: cron_run_manually
+#: model:_description:0
 #: model:ir.model,name:cron_run_manually.model_ir_cron
 msgid "ir.cron"
-msgstr "ir.cron"
+msgstr ""
 
 #. module: cron_run_manually
-#: code:addons/cron_run_manually/model/ir_cron.py:70
+#: code:addons/cron_run_manually/model/ir_cron.py:51
+#: code:addons/cron_run_manually/model/ir_cron.py:76
 #, python-format
 msgid "Error"
-msgstr "Error"
+msgstr ""
 

=== added directory 'dbfilter_from_header/i18n'
=== added file 'dbfilter_from_header/i18n/dbfilter_from_header.pot'
--- dbfilter_from_header/i18n/dbfilter_from_header.pot	1970-01-01 00:00:00 +
+++ dbfilter_from_header/i18n/dbfilter_from_header.pot	2014-03-14 17:45:38 +
@@ -0,0 +1,16 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-03-14 17:40+\n"
+"PO-Revision-Date: 2014-03-14 17:40+\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+

=== added directory 'disable_openerp_online/i18n'
=== added file 'disable_openerp_online/i18n/disable_openerp_online.pot'
--- disable_openerp_online/i18n/disable_openerp_online.pot	1970-01-01 00:00:00 +
+++ disable_openerp_online/i18n/disable_openerp_online.pot	2014-03-14 17:45:38 +
@@ -0,0 +1,16 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#
+msgi

[Openerp-community-reviewer] [Merge] lp:~mileo/ocb-addons/70-bug-1201472 into lp:ocb-addons

[noreply]

The proposal to merge lp:~mileo/ocb-addons/70-bug-1201472 into lp:ocb-addons 
has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~mileo/ocb-addons/70-bug-1201472/+merge/208722
-- 
https://code.launchpad.net/~mileo/ocb-addons/70-bug-1201472/+merge/208722
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/checkout-pep8 into lp:lp-community-utils

[Sandy Carter (http://www.savoirfairelinux.com)]

Sandy Carter (http://www.savoirfairelinux.com) has proposed merging 
lp:~savoirfairelinux-openerp/lp-community-utils/checkout-pep8 into 
lp:lp-community-utils.

Requested reviews:
  OpenERP Community Reviewer/Maintainer (openerp-community-reviewer)

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/checkout-pep8/+merge/211098

A tool I use to quickly check pep8 on MPs.

A few people have asked what tool I use, so I though I would put it up here.

The command I use is:
./checkout-flake8.sh lp:launchpad_openerp_repo module_name
for example:
./checkout-flake8.sh 
lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname/+merge/210710
 partner_firstname

It checks it out in /tmp and runs flake8 on the module
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/checkout-pep8/+merge/211098
Your team OpenERP Community Reviewer/Maintainer is requested to review the 
proposed merge of lp:~savoirfairelinux-openerp/lp-community-utils/checkout-pep8 
into lp:lp-community-utils.
=== added file 'checkout-flake8.sh'
--- checkout-flake8.sh	1970-01-01 00:00:00 +
+++ checkout-flake8.sh	2014-03-14 17:08:06 +
@@ -0,0 +1,47 @@
+#!/usr/bin/bash
+
+# Check if flake8 and bzr exists
+which flake8 > /dev/null || exit 1
+which bzr > /dev/null || exit 1
+# Check that only one parametter was sent
+if [ "$#" -lt "1" ] || [ "$#" -gt "2" ]
+then
+echo "Usage:"
+echo "$0 lp:repository [SUBDIRECTORY]"
+echo "$0 https://code.launchpad.net/~group/repository/branch/+merge/000 [SUBDIRECTORY]"
+	exit 1
+fi
+SUBDIR='.'
+# Subdirectory defined
+if [ "$#" -eq 2 ]
+then
+SUBDIR="$2"
+fi
+# Check that parameters are actually a bazaar branch
+bzr info "$1" > /dev/null || exit 1
+
+echo "Making a temp directory"
+mkdir -p "/tmp/checkout-flake/" || exit 1
+cd "/tmp/checkout-flake/" || exit 1
+SRCBRANCH=$(echo "${1}" | sed 's,/+merge/[0-9]*$,,g')
+TODIR=$SRCBRANCH
+TODIR="${TODIR#lp:}"
+TODIR="${TODIR#http://}";
+TODIR="${TODIR#https://}";
+TODIR="${TODIR.}"
+echo branching to $(pwd)/$TODIR
+if [ -d "$TODIR" ]
+then
+rm -rf "$TODIR"
+fi
+mkdir "$TODIR" || exit 1
+bzr branch "$SRCBRANCH" --use-existing-dir "$TODIR"
+cd "$TODIR"
+echo
+flake8 "$SUBDIR" --filename __init__.py --ignore F401,E501
+flake8 "$SUBDIR" --exclude __init__.py --ignore E501
+echo 
+flake8 "$SUBDIR" --select E501
+echo
+
+echo "Done"

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/server-env-tools/7.0-auth_from_http_basic into lp:server-env-tools

[Sandy Carter (http://www.savoirfairelinux.com)]

Review: Needs Fixing

Flake8's PEP8:
auth_from_http_basic/__init__.py:26:1: E302 expected 2 blank lines, found 1
auth_from_http_basic/__init__.py:31:17: E126 continuation line over-indented 
for hanging indent
auth_from_http_basic/__init__.py:32:17: E126 continuation line over-indented 
for hanging indent
auth_from_http_basic/__init__.py:33:17: E126 continuation line over-indented 
for hanging indent
auth_from_http_basic/__init__.py:34:17: E126 continuation line over-indented 
for hanging indent
auth_from_http_basic/__init__.py:38:21: E123 closing bracket does not match 
indentation of opening bracket's line
auth_from_http_basic/__init__.py:44:1: E302 expected 2 blank lines, found 1
auth_from_http_basic/__openerp__.py:21:1: O603 Manifest "license" key is missing
auth_from_http_basic/__openerp__.py:22:11: E203 whitespace before ':'
auth_from_http_basic/__openerp__.py:23:14: E203 whitespace before ':'
auth_from_http_basic/__openerp__.py:24:13: E203 whitespace before ':'
auth_from_http_basic/__openerp__.py:46:15: E203 whitespace before ':'
auth_from_http_basic/__openerp__.py:47:14: E203 whitespace before ':'
auth_from_http_basic/__openerp__.py:49:11: E203 whitespace before ':'
auth_from_http_basic/__openerp__.py:59:28: E203 whitespace before ':'
auth_from_http_basic/__openerp__.py:60:17: E203 whitespace before ':'

auth_from_http_basic_logout/__openerp__.py:21:1: O603 Manifest "license" key is 
missing
auth_from_http_basic_logout/__openerp__.py:22:11: E203 whitespace before ':'
auth_from_http_basic_logout/__openerp__.py:23:14: E203 whitespace before ':'
auth_from_http_basic_logout/__openerp__.py:24:13: E203 whitespace before ':'
auth_from_http_basic_logout/__openerp__.py:38:15: E203 whitespace before ':'
auth_from_http_basic_logout/__openerp__.py:39:14: E203 whitespace before ':'
auth_from_http_basic_logout/__openerp__.py:43:11: E203 whitespace before ':'
auth_from_http_basic_logout/__openerp__.py:54:28: E203 whitespace before ':'
auth_from_http_basic_logout/__openerp__.py:55:17: E203 whitespace before ':'


-- 
https://code.launchpad.net/~therp-nl/server-env-tools/7.0-auth_from_http_basic/+merge/202316
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~akretion-team/ocb-addons/trunk-lp1292587 into lp:ocb-addons

[Raphaël Valyi - http : //www . akretion . com]

Raphaël Valyi - http://www.akretion.com has proposed merging 
lp:~akretion-team/ocb-addons/trunk-lp1292587 into lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1292587 in OpenERP Addons: "[7.0][trunk][product_manufacturer] cannot 
easily search product by manufacturer"
  https://bugs.launchpad.net/openobject-addons/+bug/1292587

For more details, see:
https://code.launchpad.net/~akretion-team/ocb-addons/trunk-lp1292587/+merge/211095

allows to search product by manufacturer and manufacturer reference
-- 
https://code.launchpad.net/~akretion-team/ocb-addons/trunk-lp1292587/+merge/211095
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~akretion-team/ocb-addons/trunk-lp1292587 into lp:ocb-addons.
=== modified file 'product_manufacturer/product_manufacturer_view.xml'
--- product_manufacturer/product_manufacturer_view.xml	2013-08-23 09:22:31 +
+++ product_manufacturer/product_manufacturer_view.xml	2014-03-14 16:58:46 +
@@ -47,6 +47,16 @@
 
 
 
+
+product.manufacturer.search.form
+product.product
+
+
+
+
+
+
+
 
 
 

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] Sylvain LE GAL application to OpenERP Community Reviewer / Maintainer

[Maxime Chambreuil]

Yes, you missed the subject of the email ;) 

It is Sylvain Le Gal application, not mine. 

Regards, 

-- 
Maxime Chambreuil 
+1 (514) 276-5468 #126 

- Mail original -




Hi Maxime, 


You're in through the Reviewer group right ? 
Or do I miss something ? 

Regards, 

Joël 




On Fri, Mar 14, 2014 at 3:39 PM, Maxime Chambreuil < 
maxime.chambre...@savoirfairelinux.com > wrote: 


Hi, 

I would like to belong to this group. Is it possible ? 

I'm currently active in the following project : 
- https://launchpad.net/web-addons 
- https://launchpad.net/server-env-tools 

Regards. 
-- 
This message was sent from Launchpad by 
Sylvain LE GAL (GRAP) ( https://launchpad.net/~sylvain-legal ) 
using the "Contact this team's admins" link on the OpenERP Community 
Reviewer/Maintainer team page 
( https://launchpad.net/~openerp-community-reviewer ). 

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer 
Post to : openerp-community-reviewer@lists.launchpad.net 
Unsubscribe : https://launchpad.net/~openerp-community-reviewer 
More help : https://help.launchpad.net/ListHelp 





-- 



















camp to camp 
INNOVATIVE SOLUTIONS 
BY OPEN SOURCE EXPERTS 


Joël Grand-Guillaume Division Manager 
Business Solutions 




+41 21 61 9 10 28 
www.camptocamp.com 



-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons

[Sandy Carter (http://www.savoirfairelinux.com)]

Weird indeed.
That's why I do my MPs to v7, trunk and ocb. There's always a chance.

Le 2014-03-14 12:13, Lionel Sausin - Numérigraphe a écrit :
> It just got merged into the official v7.
> Karma is such a weird thing...
>

-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context/+merge/210761
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1291874] Re: Method stock_move.action_cancel() loses context

[Lionel Sausin - Numérigraphe]

** Changed in: openobject-addons
   Status: New => Fix Released

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1291874

Title:
  Method stock_move.action_cancel() loses  context

Status in OpenERP Community Backports (Addons):
  Fix Committed
Status in OpenERP Addons (modules):
  Fix Released

Bug description:
  In versions up to trunk and trunk-wms, stock_move.action_cancel()
  lacks a few "context" arguments when it calls the ORM.

  They are not necessary for the standard addons, but would make it
  possible to use the context in custom modules.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1291874/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/better-age into lp:lp-community-utils

[Sandy Carter (http://www.savoirfairelinux.com)]

Sandy Carter (http://www.savoirfairelinux.com) has proposed merging 
lp:~savoirfairelinux-openerp/lp-community-utils/better-age into 
lp:lp-community-utils.

Requested reviews:
  OpenERP Community Reviewer/Maintainer (openerp-community-reviewer)

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/better-age/+merge/211083

This changes a bit how the MPs are sorted.

First of all, there is a fix of a 1 off error: proposals done on the same day 
showed 1 days old.

Secondly, the age shown has been changed to the date of the last change on the 
source branch.
This means if I did an MP 60 days ago and made a sudden change yesterday, the 
age will set to 1.
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/better-age/+merge/211083
Your team OpenERP Community Reviewer/Maintainer is requested to review the 
proposed merge of lp:~savoirfairelinux-openerp/lp-community-utils/better-age 
into lp:lp-community-utils.
=== modified file 'openerp-nag'
--- openerp-nag	2014-02-20 16:18:06 +
+++ openerp-nag	2014-03-14 16:14:53 +
@@ -196,7 +196,9 @@
 if proposal.date_merged is not None:
 continue
 votes = Votes(proposal.votes)
-
+# Get the age from of the last change to the proposed branch
+review_age = now - max(proposal.source_branch.date_last_modified,
+   proposal.date_review_requested)
 # Nag about missing commit message on merge requests
 if policy.mps_need_commit_message and proposal.commit_message is None:
 yield Nag(
@@ -205,13 +207,12 @@
 subject=proposal.web_link,
 sort_class=SORT_CLASS_MERGE,
 sort_priority=None,  # TODO: get from max(linked bugs)
-sort_age=(proposal.date_review_requested - now).days,
+sort_age=review_age.days,
 project_name=project.name,
 votes=votes,
 )
 
-age = (now - proposal.date_review_requested).days
-
+# Nag about approved merges
 if (votes.approve == votes.total(for_approval=True) and
 (votes.approve >= policy.approvals_to_bypass or
  votes.approve >= policy.min_approve and
@@ -222,21 +223,21 @@
 subject=proposal.web_link,
 sort_class=SORT_CLASS_MERGE,
 sort_priority=None,  # TODO: get from max(linked bugs)
-sort_age=(proposal.date_review_requested - now).days,
+sort_age=review_age.days,
 project_name=project.name,
 votes=votes,
 )
 continue
 
 # Nag about aging merge requests
-if age >= policy.max_review_age:
+if review_age.days >= policy.max_review_age:
 yield Nag(
 person='Someone',
 action="review the merge request",
 subject=proposal.web_link,
 sort_class=SORT_CLASS_MERGE,
 sort_priority=None,  # TODO: get from max(linked bugs)
-sort_age=(proposal.date_review_requested - now).days,
+sort_age=review_age.days,
 project_name=project.name,
 votes=votes,
 )
@@ -336,14 +337,14 @@
 progress.finish()
 
 nags.sort(key=lambda nag: (nag.sort_class, nag.sort_priority,
-   nag.sort_age))
+   -nag.sort_age))
 print("=" * 80)
 print("Done thinking, here's the nag list".center(80))
 print("=" * 80)
 for index1, nag in enumerate(nags, 1):
 print("{index1:-2}: [age {age}] (votes {votes}) {person} should {action} {subject} "
   "on the project {project}".format(
-  index1=index1, age=(nag.sort_age and -nag.sort_age), person=nag.person,
+  index1=index1, age=nag.sort_age, person=nag.person,
   action=nag.action, subject=nag.subject, project=nag.project_name,
   votes=nag.votes or ''))
 

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons

[Lionel Sausin - Numérigraphe]

The proposal to merge 
lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into 
lp:ocb-addons has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context/+merge/210761
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context/+merge/210761
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context into lp:ocb-addons

[Lionel Sausin - Numérigraphe]

It just got merged into the official v7.
Karma is such a weird thing...
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-move-cancel-context/+merge/210761
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/change-button-to-send-email-in-draftpo into lp:openerp-humanitarian-ngo/purchase-wkfl

[Yannick Vaucher @ Camptocamp]

Review: Approve

LGTM

Cheers
-- 
https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/change-button-to-send-email-in-draftpo/+merge/207675
Your team OpenERP for Humanitarian Core Editors is subscribed to branch 
lp:openerp-humanitarian-ngo/purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into lp:ocb-addons

[Lionel Sausin - Numérigraphe]

The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into 
lp:ocb-addons has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/209917
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/209917
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into lp:ocb-addons

[Lionel Sausin - Numérigraphe]

I'll ask the maintenance team if there is a risk that text fields get truncated 
during migration.
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/209917
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/7.0-bug-1188629-price-surchage-uom into lp:ocb-addons

[noreply]

The proposal to merge 
lp:~yann-papouin/ocb-addons/7.0-bug-1188629-price-surchage-uom into 
lp:ocb-addons has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1188629-price-surchage-uom/+merge/210159
-- 
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1188629-price-surchage-uom/+merge/210159
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/7.0-bug-1234678-return-product-backorder-false into lp:ocb-addons

[noreply]

The proposal to merge 
lp:~yann-papouin/ocb-addons/7.0-bug-1234678-return-product-backorder-false into 
lp:ocb-addons has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1234678-return-product-backorder-false/+merge/210170
-- 
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1234678-return-product-backorder-false/+merge/210170
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into lp:ocb-addons

[Leonardo Pistone - camptocamp]

Review: Approve code review

Good point Alexandre.

But unless someone can come up with a practical case where this specific 
example of schema change could be a problem (I don't), I approve. 
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/209917
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/7.0-bug-1260778-sale-date-confirm into lp:ocb-addons

[noreply]

The proposal to merge 
lp:~yann-papouin/ocb-addons/7.0-bug-1260778-sale-date-confirm into 
lp:ocb-addons has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1260778-sale-date-confirm/+merge/210164
-- 
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1260778-sale-date-confirm/+merge/210164
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/7.0-bug-1091268-purchase-merge-no-origin-duplicates into lp:ocb-addons

[noreply]

The proposal to merge 
lp:~yann-papouin/ocb-addons/7.0-bug-1091268-purchase-merge-no-origin-duplicates 
into lp:ocb-addons has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1091268-purchase-merge-no-origin-duplicates/+merge/210169
-- 
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1091268-purchase-merge-no-origin-duplicates/+merge/210169
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into lp:ocb-addons

[Alexandre Fayolle - camptocamp]

Review: Needs Information code review, no test

are we all aware that this MP is not going to be accepted in the official 
stable branch, because it changes the database schema definition?

I personally have nothing against merging in OCB. 
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/209917
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements into lp:~akretion-team/openerp-product-attributes/7.0-product-customer-cod

[noreply]

The proposal to merge 
lp:~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements
 into 
lp:~akretion-team/openerp-product-attributes/7.0-product-customer-code-extraction
 has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements/+merge/202899
-- 
https://code.launchpad.net/~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements/+merge/202899
Your team Product Core Editors is requested to review the proposed merge of 
lp:~agilebg/openerp-product-attributes/7.0-product-customer-code-extraction-improvements
 into 
lp:~akretion-team/openerp-product-attributes/7.0-product-customer-code-extraction.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-997642-fix-services-make-to-stock into lp:ocb-addons/6.1

[noreply]

The proposal to merge 
lp:~yann-papouin/ocb-addons/6.1-bug-997642-fix-services-make-to-stock into 
lp:ocb-addons/6.1 has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-997642-fix-services-make-to-stock/+merge/203903
-- 
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-997642-fix-services-make-to-stock/+merge/203903
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] Sylvain LE GAL application to OpenERP Community Reviewer / Maintainer

[Joël Grand-Guillaume]

Hi Maxime,


You're in through the Reviewer group right ?
 Or do I miss something ?

Regards,

Joël


On Fri, Mar 14, 2014 at 3:39 PM, Maxime Chambreuil <
maxime.chambre...@savoirfairelinux.com> wrote:

> Hi,
>
> I would like to belong to this group. Is it possible ?
>
> I'm currently active in the following project :
> - https://launchpad.net/web-addons
> - https://launchpad.net/server-env-tools
>
> Regards.
> --
> This message was sent from Launchpad by
> Sylvain LE GAL (GRAP) (https://launchpad.net/~sylvain-legal)
> using the "Contact this team's admins" link on the OpenERP Community
> Reviewer/Maintainer team page
> (https://launchpad.net/~openerp-community-reviewer).
>
> --
> Mailing list: https://launchpad.net/~openerp-community-reviewer
> Post to : openerp-community-reviewer@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~openerp-community-reviewer
> More help   : https://help.launchpad.net/ListHelp
>



-- 


*camptocamp*
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS

*Joël Grand-Guillaume*
Division Manager
Business Solutions

+41 21 619 10 28
www.camptocamp.com
-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] Sylvain LE GAL application to OpenERP Community Reviewer / Maintainer

[Pedro Manuel Baeza Romero]

I'm OK with the proposal.

Regards.


2014-03-14 15:39 GMT+01:00 Maxime Chambreuil <
maxime.chambre...@savoirfairelinux.com>:

> Hi,
>
> I would like to belong to this group. Is it possible ?
>
> I'm currently active in the following project :
> - https://launchpad.net/web-addons
> - https://launchpad.net/server-env-tools
>
> Regards.
> --
> This message was sent from Launchpad by
> Sylvain LE GAL (GRAP) (https://launchpad.net/~sylvain-legal)
> using the "Contact this team's admins" link on the OpenERP Community
> Reviewer/Maintainer team page
> (https://launchpad.net/~openerp-community-reviewer).
>
> --
> Mailing list: https://launchpad.net/~openerp-community-reviewer
> Post to : openerp-community-reviewer@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~openerp-community-reviewer
> More help   : https://help.launchpad.net/ListHelp
>
-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 915568] Re: Wrong dates used when confirming stock inventory

[qdp (OpenERP)]

Ok, following improvements have been merged in trunk-wms (revision 9596.) :
- if there are no conflicting moves, compute the stock difference at 
inventory.date and insert the stock moves at the same date.
- indicate the conflicting moves BEFORE we start the inventory
- forbid all stock moves on the impacted locations during an inventory 
(product, owner, lot...)

thanks for your inputs, guys

-- 
You received this bug notification because you are a member of Stock and
Logistic Core Editors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/915568

Title:
  Wrong dates used when confirming stock inventory

Status in OpenERP Community Backports (Addons):
  Confirmed
Status in New OpenERP WMS:
  Won't Fix
Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  [ Problem ]
  action_confirm method is not taking in account "date" from stock.inventory 
object, and update qtys in the moment of confirmation.
  The inventory date is taken into account when querying the stock to compute 
the inventory difference but the stock moves are created at the wrong date, 
making the stock and virtual stock wrong at the date of the inventory.

  Users expect that the inventory date should say _when_ the inventory
  was taken - in this way the amount to correct should effective before
  this date.

  Attached videos gives better explanation, and document with kardex
  expected.

  [ Impact ] the available quantity and virtual stock are wrong near the
  date of the inventory.

  [ Possible fixes ]
  - The preferred fix would be to write the stock moves at the date of the 
inventory.
  - A less-than-ideal fix would be to not take the inventory date is taken into 
account when querying the stock to compute the inventory difference. For the 
moment is the way v8 is being developed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/915568/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-latest-move into lp:ocb-addons

[Lionel Sausin - Numérigraphe]

Merged into the official v7 branch, this change runs green on runbot - 
http://runbot.openerp.com/numerigraphe-team-7-0-stock-latest-move-runbot-30941/logs/
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-latest-move/+merge/210795
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~numerigraphe-team/ocb-addons/7.0-stock-latest-move into 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-latest-move into lp:ocb-addons

[Lionel Sausin - Numérigraphe]

The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-stock-latest-move 
into lp:ocb-addons has been updated.

Description changed to:

This branch improves the report model "latest inventory date", by showing the 
latest Stock Move as well.
This helps users isolate unused products that may deserve special measures like 
discount sales or quality control.
It also optimizes the SQL query a bit, and let users filter inactive products 
or not.

For the moment it is still portable as-is to trunk-WMS and has been proposed 
there: 
https://code.launchpad.net/~numerigraphe-team/openobject-addons/trunk-wms-stock-latest-move/+merge/211059

Even though this does change the database structure, I do not foresee any 
migration problem even using OpenERP SA's migration bot because it is only a 
view report.

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-latest-move/+merge/210795
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-latest-move/+merge/210795
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~numerigraphe-team/ocb-addons/7.0-stock-latest-move into 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] Sylvain LE GAL application to OpenERP Community Reviewer / Maintainer

[Maxime Chambreuil]

Hi,

I would like to belong to this group. Is it possible ?

I'm currently active in the following project :
- https://launchpad.net/web-addons
- https://launchpad.net/server-env-tools

Regards.
-- 
This message was sent from Launchpad by
Sylvain LE GAL (GRAP) (https://launchpad.net/~sylvain-legal)
using the "Contact this team's admins" link on the OpenERP Community
Reviewer/Maintainer team page
(https://launchpad.net/~openerp-community-reviewer).

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-needed_changes_to_fit_with_stock_picking_v7_changes-rde into lp:carriers-deliveries

[Romain Deheele - Camptocamp]

Romain Deheele - Camptocamp has proposed merging 
lp:~camptocamp/carriers-deliveries/7.0-needed_changes_to_fit_with_stock_picking_v7_changes-rde
 into lp:carriers-deliveries.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-needed_changes_to_fit_with_stock_picking_v7_changes-rde/+merge/211056

Hi,

Most of changes are about to fit with stock.picking/stock.picking.out v7 changes
(be careful about fixme in addons/delivery/stock.py in line 207)

Other change:
v7 port wizard

Just one test doesn't work, but for the moment, i dont't understand why :(
last assert "carrier_file_generated == True" in test/carrier_file.yml
Even it works in real case...  :-/
Help is welcome,

Regards,

Romain


-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-needed_changes_to_fit_with_stock_picking_v7_changes-rde/+merge/211056
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/carriers-deliveries/7.0-needed_changes_to_fit_with_stock_picking_v7_changes-rde
 into lp:carriers-deliveries.
=== modified file 'base_delivery_carrier_files/__openerp__.py'
--- base_delivery_carrier_files/__openerp__.py	2014-03-13 16:11:58 +
+++ base_delivery_carrier_files/__openerp__.py	2014-03-14 14:15:29 +
@@ -50,7 +50,7 @@
  'wizard/generate_carrier_files_view.xml',
  'security/ir.model.access.csv'],
 'demo': ['carrier_file_demo.xml',
- 'carrier_file_demo.yml'],
+ 'carrier_file_demo.yml'],
 'test': ['test/carrier_file.yml',
  'test/carrier_file_manual.yml'],
 'images': [],

=== modified file 'base_delivery_carrier_files/carrier_file.py'
--- base_delivery_carrier_files/carrier_file.py	2014-03-13 09:19:28 +
+++ base_delivery_carrier_files/carrier_file.py	2014-03-14 14:15:29 +
@@ -84,7 +84,7 @@
 :param list picking_ids: list of ids of pickings for which we have to generate a file
 :return: True if successful
 """
-picking_obj = self.pool.get('stock.picking')
+picking_obj = self.pool.get('stock.picking.out')
 log = logging.getLogger('delivery.carrier.file')
 file_generator = new_file_generator(carrier_file.type)
 pickings = [picking for picking in

=== modified file 'base_delivery_carrier_files/carrier_file_demo.yml'
--- base_delivery_carrier_files/carrier_file_demo.yml	2014-03-13 09:19:28 +
+++ base_delivery_carrier_files/carrier_file_demo.yml	2014-03-14 14:15:29 +
@@ -28,7 +28,7 @@
 property_stock_account_output: account.o_income
 description: Ice cream can be mass-produced and thus is widely available in developed parts of the world. Ice cream can be purchased in large cartons (vats and squrounds) from supermarkets and grocery stores, in smaller quantities from ice cream shops, convenience stores, and milk bars, and in individual servings from small carts or vans at public events.
 -
- !record {model: stock.picking, id: outgoing_shipment_carrier_file}:
+ !record {model: stock.picking.out, id: outgoing_shipment_carrier_file}:
 type: out
 location_dest_id: location_delivery_counter
 carrier_id: delivery.delivery_carrier
@@ -41,7 +41,7 @@
 location_id: location_refrigerator
 location_dest_id: location_delivery_counter
 -
- !record {model: stock.picking, id: outgoing_shipment_carrier_file_manual}:
+ !record {model: stock.picking.out, id: outgoing_shipment_carrier_file_manual}:
 type: out
 location_dest_id: location_delivery_counter
 carrier_id: delivery.free_delivery_carrier

=== modified file 'base_delivery_carrier_files/stock.py'
--- base_delivery_carrier_files/stock.py	2014-03-13 09:19:28 +
+++ base_delivery_carrier_files/stock.py	2014-03-14 14:15:29 +
@@ -30,6 +30,15 @@
   help="The file for the delivery carrier has been generated."),
 }
 
+
+class stock_picking_out(orm.Model):
+_inherit = 'stock.picking.out'
+
+_columns = {
+'carrier_file_generated': fields.boolean('Carrier File Generated', readonly=True,
+  help="The file for the delivery carrier has been generated."),
+}
+
 def generate_carrier_files(self, cr, uid, ids, auto=True, context=None):
 """
 Generates all the files for a list of pickings according to
@@ -67,7 +76,7 @@
 return True
 
 def action_done(self, cr, uid, ids, context=None):
-result = super(stock_picking, self).action_done(cr, uid, ids, context=context)
+result = super(stock_picking_out, self).action_done(cr, uid, ids, context=context)
 self.generate_carrier_files(cr, uid, ids, auto=True, context=context)
 return result
 
@@ -75,5 +84,5 @@
 if default is None:
 default = {}
 default.update({'carrier_file_generated': False})
-return super(stock_picking, self).co

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-product_brand-migration into lp:openerp-product-attributes

[Guewen Baconnier @ Camptocamp]

Guewen Baconnier @ Camptocamp has proposed merging 
lp:~camptocamp/openerp-product-attributes/7.0-product_brand-migration into 
lp:openerp-product-attributes.

Commit message:
Migration of product_brand for version 7.0

Requested reviews:
  Product Core Editors (product-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_brand-migration/+merge/211043

Migration of the module product brand.
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_brand-migration/+merge/211043
Your team Product Core Editors is requested to review the proposed merge of 
lp:~camptocamp/openerp-product-attributes/7.0-product_brand-migration into 
lp:openerp-product-attributes.
=== modified file 'product_brand/__init__.py' (properties changed: +x to -x)
--- product_brand/__init__.py	2012-03-27 12:50:22 +
+++ product_brand/__init__.py	2014-03-14 12:43:57 +
@@ -24,4 +24,4 @@
 ###
 # Product Brand is an Openobject module wich enable Brand management for products #
 ###
-import product_brand
+from . import product_brand

=== modified file 'product_brand/__openerp__.py'
--- product_brand/__openerp__.py	2013-02-05 09:50:07 +
+++ product_brand/__openerp__.py	2014-03-14 12:43:57 +
@@ -28,22 +28,26 @@
 'name': 'Product Brand Manager',
 'version': '0.1',
 'category': 'Product',
-'description': """This module allows your user to easily manage product brand. You can define brand, attach it a logo and a description.
-It also allows to attach a partner to a brand.
-One installed check the menu Product/configuration/brand
-To do / To come :
-- A view to seeing products by brand.
+'description': """
+Product Brand Manager
+=
+
+This module allows your user to easily manage product brands. You can
+define brand, attach it a logo and a description.  It also allows to
+attach a partner to a brand.  One installed check the menu
+Product/configuration/brand
+
+To do / To come:
+
+- A view to seeing products by brand.
+
 """,
 'author': 'NetAndCo',
 'website': 'http://ww.netandco.net',
 'depends': ['product'],
-'init_xml': [],
-'update_xml': [
+'data': [
 'product_brand_view.xml',
 'security/ir.model.access.csv'
 ],
-'demo_xml': [],
-'installable': False,
-'certificate': '',
+'installable': True,
 }
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== modified file 'product_brand/product_brand.py' (properties changed: +x to -x)
--- product_brand/product_brand.py	2012-08-21 14:10:21 +
+++ product_brand/product_brand.py	2014-03-14 12:43:57 +
@@ -21,23 +21,29 @@
 #along with this program.  If not, see .  #
 #   #
 #
-from openerp.osv.orm import Model
-from openerp.osv import fields
-
-class product_brand(Model):
+from openerp.osv import orm, fields
+
+
+class product_brand(orm.Model):
 _name = 'product.brand'
 _columns = {
-'name': fields.char('Brand Name',size=32),
-'description': fields.text('Description',translate=True),
-'partner_id' : fields.many2one('res.partner','partner', help='Select a partner for this brand if it exist'),
+'name': fields.char('Brand Name'),
+'description': fields.text('Description', translate=True),
+'partner_id': fields.many2one(
+'res.partner',
+'partner',
+help='Select a partner for this brand if it exists.',
+ondelete='restrict'),
 'logo': fields.binary('Logo File')
 }
 
 
-class product_template(Model):
-_name = 'product.template'
+class product_template(orm.Model):
 _inherit = 'product.template'
 _columns = {
-'product_brand_id' : fields.many2one('product.brand','Brand', help='Select a brand for this product'),
+'product_brand_id': fields.many2one(
+'product.brand',
+'Brand',
+help='Select a brand for this product.',
+ondelete='restrict')
 }
-

=== modified file 'product_brand/product_brand_view.xml' (properties changed: +x to -x)
--- product_brand/product_brand_view.xml	2012-03-27 12:50:22 +
+++ product_brand/product_brand_view.xml	2014-03-14 12:43:57 +
@@ -6,27 +6,48 @@
   Copyright (C) 2011 Akretion Benoît Guillot 
   The licence is in the file __openerp__.py
 -->
-  
+
 
+
+product.brand.search.form
+product.brand
+
+
+   
+   
+
+
+
+
 
 product.brand.form

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-product_brand-migration into lp:openerp-product-attributes

[Guewen Baconnier @ Camptocamp]

Guewen Baconnier @ Camptocamp has proposed merging 
lp:~camptocamp/openerp-product-attributes/7.0-product_brand-migration into 
lp:openerp-product-attributes.

Commit message:
Migration of product_brand for version 7.0

Requested reviews:
  Product Core Editors (product-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_brand-migration/+merge/211043

Migration of the module product brand.
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_brand-migration/+merge/211043
Your team Product Core Editors is requested to review the proposed merge of 
lp:~camptocamp/openerp-product-attributes/7.0-product_brand-migration into 
lp:openerp-product-attributes.
=== modified file 'product_brand/__init__.py' (properties changed: +x to -x)
--- product_brand/__init__.py	2012-03-27 12:50:22 +
+++ product_brand/__init__.py	2014-03-14 12:37:06 +
@@ -24,4 +24,4 @@
 ###
 # Product Brand is an Openobject module wich enable Brand management for products #
 ###
-import product_brand
+from . import product_brand

=== modified file 'product_brand/__openerp__.py'
--- product_brand/__openerp__.py	2013-02-05 09:50:07 +
+++ product_brand/__openerp__.py	2014-03-14 12:37:06 +
@@ -28,22 +28,26 @@
 'name': 'Product Brand Manager',
 'version': '0.1',
 'category': 'Product',
-'description': """This module allows your user to easily manage product brand. You can define brand, attach it a logo and a description.
-It also allows to attach a partner to a brand.
-One installed check the menu Product/configuration/brand
-To do / To come :
-- A view to seeing products by brand.
+'description': """
+Product Brand Manager
+=
+
+This module allows your user to easily manage product brands. You can
+define brand, attach it a logo and a description.  It also allows to
+attach a partner to a brand.  One installed check the menu
+Product/configuration/brand
+
+To do / To come:
+
+- A view to seeing products by brand.
+
 """,
 'author': 'NetAndCo',
 'website': 'http://ww.netandco.net',
 'depends': ['product'],
-'init_xml': [],
-'update_xml': [
+'data': [
 'product_brand_view.xml',
 'security/ir.model.access.csv'
 ],
-'demo_xml': [],
-'installable': False,
-'certificate': '',
+'installable': True,
 }
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== modified file 'product_brand/product_brand.py' (properties changed: +x to -x)
--- product_brand/product_brand.py	2012-08-21 14:10:21 +
+++ product_brand/product_brand.py	2014-03-14 12:37:06 +
@@ -21,23 +21,29 @@
 #along with this program.  If not, see .  #
 #   #
 #
-from openerp.osv.orm import Model
-from openerp.osv import fields
-
-class product_brand(Model):
+from openerp.osv import orm, fields
+
+
+class product_brand(orm.Model):
 _name = 'product.brand'
 _columns = {
-'name': fields.char('Brand Name',size=32),
-'description': fields.text('Description',translate=True),
-'partner_id' : fields.many2one('res.partner','partner', help='Select a partner for this brand if it exist'),
+'name': fields.char('Brand Name'),
+'description': fields.text('Description', translate=True),
+'partner_id': fields.many2one(
+'res.partner',
+'partner',
+help='Select a partner for this brand if it exists.',
+ondelete='restrict'),
 'logo': fields.binary('Logo File')
 }
 
 
-class product_template(Model):
-_name = 'product.template'
+class product_template(orm.Model):
 _inherit = 'product.template'
 _columns = {
-'product_brand_id' : fields.many2one('product.brand','Brand', help='Select a brand for this product'),
+'product_brand_id': fields.many2one(
+'product.brand',
+'Brand',
+help='Select a brand for this product.',
+ondelete='restrict')
 }
-

=== modified file 'product_brand/product_brand_view.xml' (properties changed: +x to -x)
--- product_brand/product_brand_view.xml	2012-03-27 12:50:22 +
+++ product_brand/product_brand_view.xml	2014-03-14 12:37:06 +
@@ -6,27 +6,48 @@
   Copyright (C) 2011 Akretion Benoît Guillot 
   The licence is in the file __openerp__.py
 -->
-  
+
 
+
+product.brand.search.form
+product.brand
+
+
+   
+   
+
+
+
+
 
 product.brand.form

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-product_brand-migration into lp:openerp-product-attributes

[Guewen Baconnier @ Camptocamp]

The proposal to merge 
lp:~camptocamp/openerp-product-attributes/7.0-product_brand-migration into 
lp:openerp-product-attributes has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_brand-migration/+merge/211043
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_brand-migration/+merge/211043
Your team Product Core Editors is requested to review the proposed merge of 
lp:~camptocamp/openerp-product-attributes/7.0-product_brand-migration into 
lp:openerp-product-attributes.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-product_brand-migration into lp:openerp-product-attributes

[Guewen Baconnier @ Camptocamp]

The proposal to merge 
lp:~camptocamp/openerp-product-attributes/7.0-product_brand-migration into 
lp:openerp-product-attributes has been updated.

Commit Message changed to:

Migration of product_brand for version 7.0

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_brand-migration/+merge/211043
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-product_brand-migration/+merge/211043
Your team Product Core Editors is requested to review the proposed merge of 
lp:~camptocamp/openerp-product-attributes/7.0-product_brand-migration into 
lp:openerp-product-attributes.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

[Luc De Meyer (Noviat)]

No,

If you agree with the proposed approach, than I an make an MP.

Luc


www.noviat.com
Rusatiralaan 1, 1083 Brussel
+32 2 808 86 38



-Original Message-
From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Yannick 
Vaucher @ Camptocamp
Sent: vrijdag 14 maart 2014 9:48
To: mp+193...@code.launchpad.net
Subject: Re: [Merge] 
lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix
 into lp:account-financial-report

Review: Needs Information

@Luc anything was done about this proposed change ?

> I have the impression that we move to a consensus to fix this issue by adding 
> a parameter on the company settings with callback to current method if not 
> defined.
-- 
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
You are the owner of 
lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix.


https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
Your team Account Report Core Editors is subscribed to branch 
lp:account-financial-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready into lp:ocb-addons

[Pedro Manuel Baeza]

Review: Approve

Thank you

Regards.
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready/+merge/210965
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit into lp:stock-logistic-flows

[Sandy Carter (http://www.savoirfairelinux.com)]

Review: Abstain

Thank you for teachning me thing. I had no idea.
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit/+merge/210599
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-flows.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-fix_1280221-afe into lp:margin-analysis

[Yannick Vaucher @ Camptocamp]

Review: Approve code review, no tests

LGTM thanks
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix_1280221-afe/+merge/206486
Your team Margin Analysis Core Editors is subscribed to branch 
lp:margin-analysis.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/geospatial-addons/geoengine_geocoder_ca_geocoder into lp:geospatial-addons

[Yannick Vaucher @ Camptocamp]

The proposal to merge 
lp:~savoirfairelinux-openerp/geospatial-addons/geoengine_geocoder_ca_geocoder 
into lp:geospatial-addons has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/geospatial-addons/geoengine_geocoder_ca_geocoder/+merge/195296
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/geospatial-addons/geoengine_geocoder_ca_geocoder/+merge/195296
Your team Geospatial Addons Core Editors is subscribed to branch 
lp:geospatial-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/geospatial-addons/geoengine_geocoder_ca_geocoder into lp:geospatial-addons

[Yannick Vaucher @ Camptocamp]

As there was no activity for a month, I set it as Work In Progress
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/geospatial-addons/geoengine_geocoder_ca_geocoder/+merge/195296
Your team Geospatial Addons Core Editors is subscribed to branch 
lp:geospatial-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready into lp:ocb-addons

[Raphaël Valyi - http : //www . akretion . com]

Review: Approve

LGTM
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready/+merge/210965
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-batch_validate-delay-delaying-second-attempt-lep into lp:account-financial-tools

[noreply]

The proposal to merge 
lp:~camptocamp/account-financial-tools/7.0-batch_validate-delay-delaying-second-attempt-lep
 into lp:account-financial-tools has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-batch_validate-delay-delaying-second-attempt-lep/+merge/208614
-- 
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-batch_validate-delay-delaying-second-attempt-lep/+merge/208614
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/7.0-account_invoice_zero into lp:account-invoicing

[Guewen Baconnier @ Camptocamp]

On 03/14/2014 11:06 AM, Pedro Manuel Baeza wrote:
> Hi, Guewen, the case you told it's also forbidden. Let me explain: the only 
> official mechanism for compensating invoices is via refunds. You don't need 
> to make cash flows, but you need to have both documents. That is 
> theoretically. In practice, if you have an amount to compensate (a potential 
> refund) that is lower than the amount of the invoice, it's a common and 
> tolerated practise to discount it from the invoice, but never if the amount 
> is equal.
>
> I hope I explain it well.
>
> Regards.
>

Good to know!
Thanks for the explanation.


-- 
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-account_invoice_zero/+merge/210215
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/7.0-account_invoice_zero into lp:account-invoicing

[Pedro Manuel Baeza]

Hi, Guewen, the case you told it's also forbidden. Let me explain: the only 
official mechanism for compensating invoices is via refunds. You don't need to 
make cash flows, but you need to have both documents. That is theoretically. In 
practice, if you have an amount to compensate (a potential refund) that is 
lower than the amount of the invoice, it's a common and tolerated practise to 
discount it from the invoice, but never if the amount is equal.

I hope I explain it well.

Regards.
-- 
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-account_invoice_zero/+merge/210215
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-batch_validate-delay-delaying-second-attempt-lep into lp:account-financial-tools

[Yannick Vaucher @ Camptocamp]

The proposal to merge 
lp:~camptocamp/account-financial-tools/7.0-batch_validate-delay-delaying-second-attempt-lep
 into lp:account-financial-tools has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-batch_validate-delay-delaying-second-attempt-lep/+merge/208614
-- 
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-batch_validate-delay-delaying-second-attempt-lep/+merge/208614
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/pep394-env into lp:lp-community-utils

[noreply]

The proposal to merge 
lp:~savoirfairelinux-openerp/lp-community-utils/pep394-env into 
lp:lp-community-utils has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/pep394-env/+merge/210217
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/pep394-env/+merge/210217
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:lp-community-utils.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/pep394-env into lp:lp-community-utils

[Yannick Vaucher @ Camptocamp]

The proposal to merge 
lp:~savoirfairelinux-openerp/lp-community-utils/pep394-env into 
lp:lp-community-utils has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/pep394-env/+merge/210217
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/pep394-env/+merge/210217
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:lp-community-utils.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/action-after-install-dbl into lp:carriers-deliveries

[noreply]

The proposal to merge 
lp:~akretion-team/carriers-deliveries/action-after-install-dbl into 
lp:carriers-deliveries has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~akretion-team/carriers-deliveries/action-after-install-dbl/+merge/208956
-- 
https://code.launchpad.net/~akretion-team/carriers-deliveries/action-after-install-dbl/+merge/208956
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/action-after-install-dbl into lp:carriers-deliveries

[Yannick Vaucher @ Camptocamp]

The proposal to merge 
lp:~akretion-team/carriers-deliveries/action-after-install-dbl into 
lp:carriers-deliveries has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~akretion-team/carriers-deliveries/action-after-install-dbl/+merge/208956
-- 
https://code.launchpad.net/~akretion-team/carriers-deliveries/action-after-install-dbl/+merge/208956
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/7.0-account_invoice_zero into lp:account-invoicing

[noreply]

The proposal to merge lp:~camptocamp/account-invoicing/7.0-account_invoice_zero 
into lp:account-invoicing has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-account_invoice_zero/+merge/210215
-- 
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-account_invoice_zero/+merge/210215
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/7.0-account_invoice_zero into lp:account-invoicing

[Yannick Vaucher @ Camptocamp]

The proposal to merge lp:~camptocamp/account-invoicing/7.0-account_invoice_zero 
into lp:account-invoicing has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-account_invoice_zero/+merge/210215
-- 
https://code.launchpad.net/~camptocamp/account-invoicing/7.0-account_invoice_zero/+merge/210215
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~andrei-levin/openerp-pos/openerp-pos into lp:openerp-pos

[Yannick Vaucher @ Camptocamp]

Review: Needs Fixing description

Please improve the description

Anything to do to setup the fiscol printer ?
-- 
https://code.launchpad.net/~andrei-levin/openerp-pos/openerp-pos/+merge/196201
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:openerp-pos.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/server-env-tools/base_module_record into lp:server-env-tools

[Yannick Vaucher @ Camptocamp]

Review: Abstain

Never used that module
-- 
https://code.launchpad.net/~serpentcs/server-env-tools/base_module_record/+merge/196613
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~hbrunn/lp-community-utils/lp1222720 into lp:lp-community-utils

[Stefan Rijnhart (Therp)]

Review: Approve code review

Thanks for fixing this annoyance!

-- 
https://code.launchpad.net/~hbrunn/lp-community-utils/lp1222720/+merge/210982
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:lp-community-utils.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~trobz/web-addons/web-unleashed into lp:web-addons

[Yannick Vaucher @ Camptocamp]

Review: Abstain


-- 
https://code.launchpad.net/~trobz/web-addons/web-unleashed/+merge/195542
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~initos.com/account-analytic/7.0 into lp:account-analytic

[Yannick Vaucher @ Camptocamp]

Review: Needs Fixing description

Please provide a better explanation in module description.
-- 
https://code.launchpad.net/~initos.com/account-analytic/7.0/+merge/195362
Your team Account Core Editors is subscribed to branch lp:account-analytic.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1281492] Re: account: cash statement: onchange_journal_id changes the field last_closing_balance which is not in the bank statement view -> breaks YAML tests

[Stefan Rijnhart (Therp)]

** Changed in: ocb-addons
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1281492

Title:
  account: cash statement: onchange_journal_id changes the field
  last_closing_balance which is not in the bank statement view -> breaks
  YAML tests

Status in OpenERP Community Backports (Addons):
  Fix Released
Status in OpenERP Addons (modules):
  New

Bug description:
  observed in latest v7

  In that on_change:

  http://bazaar.launchpad.net/~openerp/openobject-
  addons/7.0/view/head:/account/account_cash_statement.py#L167

  the field last_closing_balance is set. However, the view of the
  account.bank.statement (which is the same object indeed) does not have
  the field.

  This breaks YAML tests, should someone dare to write one on the bank
  statement.

  I suppose having that field invisible="1" in the bank statement view
  account.view_bank_statement_form would fix that.

  Thanks!

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1281492/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1292245] Re: account_budget has UnicodeEncodeError when raising except_osv

[Stefan Rijnhart (Therp)]

** Also affects: ocb-addons/7.0
   Importance: Undecided
   Status: New

** Changed in: ocb-addons/7.0
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1292245

Title:
  account_budget has UnicodeEncodeError when raising except_osv

Status in OpenERP Community Backports (Addons):
  Fix Committed
Status in OpenERP Community Backports (Addons) 7.0 series:
  Fix Committed
Status in OpenERP Addons (modules):
  New

Bug description:
  Invoice budget's warning when crossovered budget lines are not related
  to any account will cause a UnicodeEncodeError if the account has
  unicode-only characters such as é.

  How to reproduce:
  * Fresh database, install account_budget without demo.
  * Under menu (Invoicing|Budgets|Budgets)
  ** Create a new budget, name it what you want, add the dates and code you 
want.
  ** Add a budget line, choose whatever dates you want and add a new budgetary 
position by clicking Create and Edit.
  *** In the Budgetary Position form, put whatever code you want, but Give it a 
name with a utf character such as "Testé".
  *** Do not add an account to the budgetary position.
  *** Save the budgetary position
  ** Save and close the budgetary line
  * Save the Budget form

  Expected output:
  OpenERP outputs a Warning (except_osv) which reads:
  Error!

  The Budget 'Testé' has no accounts!

  Actual output:
  OpenERP outputs an error message with the following output

  Server Traceback (most recent call last):
File "web/addons/web/session.py", line 89, in send
  return openerp.netsvc.dispatch_rpc(service_name, method, args)
File "openerp/netsvc.py", line 358, in dispatch_rpc
  result = ExportService.getService(service_name).dispatch(method, params)
File "openerp/service/web_services.py", line 626, in dispatch
  res = fn(db, uid, *params)
File "openerp/osv/osv.py", line 190, in execute_kw
  return self.execute(db, uid, obj, method, *args, **kw or {})
File "openerp/osv/osv.py", line 132, in wrapper
  return f(self, dbname, *args, **kwargs)
File "openerp/osv/osv.py", line 199, in execute
  res = self.execute_cr(cr, uid, obj, method, *args, **kw)
File "openerp/osv/osv.py", line 187, in execute_cr
  return getattr(object, method)(cr, uid, *args, **kw)
File "server/openerp/osv/orm.py", line 3674, in read
  result = self._read_flat(cr, user, select, fields, context, load)
File "openerp/osv/orm.py", line 3795, in _read_flat
  res2 = self._columns[f].get(cr, self, ids, f, user, context=context, 
values=res)
File "openerp/osv/fields.py", line 1142, in get
  result = self._fnct(obj, cr, uid, ids, name, self._arg, context)
File "account_budget/account_budget.py", line 139, in _prac
  res[line.id] = self._prac_amt(cr, uid, [line.id], 
context=context)[line.id]
File "account_budget/account_budget.py", line 119, in _prac_amt
  raise osv.except_osv(_('Error!'),_("The Budget '%s' has no accounts!") % 
str(line.general_budget_id.name))
  UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 
4: ordinal not in range(128)

  Version 7.0
  addons: r9900
  server: r5259
  web: 4159

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1292245/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

[Yannick Vaucher @ Camptocamp]

Review: Needs Information

@Luc anything was done about this proposed change ?

> I have the impression that we move to a consensus to fix this issue by adding 
> a parameter on the company settings with callback to current method if not 
> defined.
-- 
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
Your team Account Report Core Editors is subscribed to branch 
lp:account-financial-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready into lp:ocb-addons

[Stefan Rijnhart (Therp)]

Stefan Rijnhart (Therp) has proposed merging 
lp:~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready into 
lp:ocb-addons.

Commit message:
[FIX] Update mrp test with fix for lp:1250053

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1292358 in OpenERP Community Backports (Addons): "[OCB] mrp test needs 
updating after fixing stock move state in lp:1250053"
  https://bugs.launchpad.net/ocb-addons/+bug/1292358

For more details, see:
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready/+merge/210965

Adapts mrp test to the fix for lp:1250053. With this fix, your production order 
will become ready when you have the materials.

-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready/+merge/210965
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~therp-nl/ocb-addons/7.0-lp1250053-fix_mrp_test_state_ready into 
lp:ocb-addons.
=== modified file 'mrp/test/bom_with_service_type_product.yml'
--- mrp/test/bom_with_service_type_product.yml	2013-09-12 11:04:54 +
+++ mrp/test/bom_with_service_type_product.yml	2014-03-14 05:59:07 +
@@ -40,7 +40,7 @@
 -
   !python {model: mrp.production}: |
 order = self.browse(cr, uid, ref("mrp_production_servicetype_mo1"))
-assert order.state == 'confirmed', "Production order should be confirmed."
+assert order.state == 'ready', "Production order should be ready."
 for move_line in order.move_lines:
 move_line.action_consume(move_line.product_qty)
 -

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~serpentcs/web-addons/multi_image_7.0 into lp:web-addons

[Yannick Vaucher @ Camptocamp]

The proposal to merge lp:~serpentcs/web-addons/multi_image_7.0 into 
lp:web-addons has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~serpentcs/web-addons/multi_image_7.0/+merge/179857
-- 
https://code.launchpad.net/~serpentcs/web-addons/multi_image_7.0/+merge/179857
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/web-addons/multi_image_7.0 into lp:web-addons

[Yannick Vaucher @ Camptocamp]

According to message 
https://code.launchpad.net/~serpentcs/web-addons/multi_image_7.0/+merge/179857/comments/430081

This is WIP
-- 
https://code.launchpad.net/~serpentcs/web-addons/multi_image_7.0/+merge/179857
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~jeffery9/oemedical/oemedical into lp:oemedical

[Yannick Vaucher @ Camptocamp]

The proposal to merge lp:~jeffery9/oemedical/oemedical into lp:oemedical has 
been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~jeffery9/oemedical/oemedical/+merge/194051
-- 
https://code.launchpad.net/~jeffery9/oemedical/oemedical/+merge/194051
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~jeffery9/oemedical/oemedical into lp:oemedical

[Yannick Vaucher @ Camptocamp]

I set this one WIP as there was no activity from author
-- 
https://code.launchpad.net/~jeffery9/oemedical/oemedical/+merge/194051
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/trunk-lp1252652 into lp:ocb-addons

[Holger Brunn (Therp)]

Holger Brunn (Therp) has proposed merging lp:~hbrunn/ocb-addons/trunk-lp1252652 
into lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1212197 in OpenERP Community Backports (Addons): "[trunk/7.0] Routing 
field on MRP order has no effect"
  https://bugs.launchpad.net/ocb-addons/+bug/1212197

For more details, see:
https://code.launchpad.net/~hbrunn/ocb-addons/trunk-lp1252652/+merge/210981

Automatically derived from 
https://code.launchpad.net/~therp-nl/openobject-addons/trunk-lp1252652 for 
https://code.launchpad.net/~openerp/openobject-addons/trunk.
-- 
https://code.launchpad.net/~hbrunn/ocb-addons/trunk-lp1252652/+merge/210981
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~hbrunn/ocb-addons/trunk-lp1252652 into lp:ocb-addons.
=== modified file 'mrp/mrp.py'
--- mrp/mrp.py	2014-03-13 17:17:59 +
+++ mrp/mrp.py	2014-03-14 08:15:06 +
@@ -957,8 +957,8 @@
 
 # Take routing address as a Shipment Address.
 # If usage of routing location is a internal, make outgoing shipment otherwise internal shipment
-if production.bom_id.routing_id and production.bom_id.routing_id.location_id:
-routing_loc = production.bom_id.routing_id.location_id
+if production.routing_id and production.routing_id.location_id:
+routing_loc = production.routing_id.location_id
 if routing_loc.usage != 'internal':
 pick_type = 'out'
 partner_id = routing_loc.partner_id and routing_loc.partner_id.id or False
@@ -984,7 +984,13 @@
 
 def _make_production_produce_line(self, cr, uid, production, context=None):
 stock_move = self.pool.get('stock.move')
-source_location_id = production.product_id.property_stock_production.id
+
+if production.routing_id and production.routing_id.location_id:
+source_location_id = production.routing_id.location_id.id
+else:
+source_location_id = production.product_id\
+.property_stock_production.id
+
 destination_location_id = production.location_dest_id.id
 data = {
 'name': production.name,
@@ -1010,7 +1016,13 @@
 # Internal shipment is created for Stockable and Consumer Products
 if production_line.product_id.type not in ('product', 'consu'):
 return False
-destination_location_id = production.product_id.property_stock_production.id
+
+if production.routing_id and production.routing_id.location_id:
+destination_location_id = production.routing_id.location_id.id
+else:
+destination_location_id = production.product_id\
+.property_stock_production.id
+
 if not source_location_id:
 source_location_id = production.location_src_id.id
 move_id = stock_move.create(cr, uid, {
@@ -1044,8 +1056,8 @@
 
 # Take routing location as a Source Location.
 source_location_id = production.location_src_id.id
-if production.bom_id.routing_id and production.bom_id.routing_id.location_id:
-source_location_id = production.bom_id.routing_id.location_id.id
+if production.routing_id and production.routing_id.location_id:
+source_location_id = production.routing_id.location_id.id
 
 for line in production.product_lines:
 consume_move_id = self._make_production_consume_line(cr, uid, line, produce_move_id, source_location_id=source_location_id, context=context)

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~hbrunn/lp-community-utils/lp1222720 into lp:lp-community-utils

[Holger Brunn (Therp)]

Holger Brunn (Therp) has proposed merging 
lp:~hbrunn/lp-community-utils/lp1222720 into lp:lp-community-utils.

Requested reviews:
  OpenERP Community Reviewer/Maintainer (openerp-community-reviewer)
Related bugs:
  Bug #1222720 in OpenERP Launchpad Community Utils: "Invalid stacked on 
location reported by launchpad after clone"
  https://bugs.launchpad.net/lp-community-utils/+bug/1222720

For more details, see:
https://code.launchpad.net/~hbrunn/lp-community-utils/lp1222720/+merge/210982
-- 
https://code.launchpad.net/~hbrunn/lp-community-utils/lp1222720/+merge/210982
Your team OpenERP Community Reviewer/Maintainer is requested to review the 
proposed merge of lp:~hbrunn/lp-community-utils/lp1222720 into 
lp:lp-community-utils.
=== modified file 'clone_mp_to_community.py'
--- clone_mp_to_community.py	2013-09-22 14:36:16 +
+++ clone_mp_to_community.py	2014-03-14 08:09:21 +
@@ -195,7 +195,7 @@
 # TODO: because of this, bzr's output doesn't end up in our logger
 push._setup_outf()
 push.run(
-location=push_location, directory=target_branch_dir, stacked=True)
+location=push_location, directory=target_branch_dir)
 
 initial_comment = 'Automatically derived from %s for %s.' % (
 mp.source_branch.web_link, mp.target_branch.web_link)

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit into lp:stock-logistic-flows

[Yannick Vaucher @ Camptocamp]

@Sandy it is intended. The else is on the for not on the if.

http://docs.python.org/2/tutorial/controlflow.html#break-and-continue-statements-and-else-clauses-on-loops

This is a way to break outer loop from the inner loop.
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-add-variant-dispach-report-resubmit/+merge/210599
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-flows.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1212197] Re: [trunk/7.0] Routing field on MRP order has no effect

[Holger Brunn (Therp)]

** Also affects: ocb-addons
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1212197

Title:
  [trunk/7.0] Routing field on MRP order has no effect

Status in OpenERP Community Backports (Addons):
  New
Status in OpenERP Addons (modules):
  Confirmed

Bug description:
  Addons revno: 9358

  When you create MRP order, Routing field is set automatically with the
  one specified on BOM. If you clear the Routing field, move lines
  created after MRP order confirmation still has Source Location taken
  from the Routing specified on BOM. So the system takes Source Location
  from Routing specified on BOM, not the Routing specified on MRP Order.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1212197/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp