Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm into lp:partner-contact-management

[Alexandre Fayolle - camptocamp]

Review: Approve code review, no test

OK.

I'd still like to see tests in the near future for this one. 
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm/+merge/213673
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde into lp:carriers-deliveries/6.1

[Alexandre Fayolle - camptocamp]

Review: Approve code review, no test

LGTM
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde/+merge/213883
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

[Alexandre Fayolle - camptocamp]

Review: Approve code review, no test

LGTM
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into lp:knowledge-addons/7.0

[El Hadji Dem (http://www.savoirfairelinux.com)]

El Hadji Dem (http://www.savoirfairelinux.com) has proposed merging 
lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into 
lp:knowledge-addons/7.0.

Requested reviews:
  OpenERP Community Reviewer/Maintainer (openerp-community-reviewer)

For more details, see:
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940

Add cmis_write: It allows to create docs from OE in DMS
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis_write/+merge/213940
Your team OpenERP Community Reviewer/Maintainer is requested to review the 
proposed merge of lp:~savoirfairelinux-openerp/knowledge-addons/cmis_write into 
lp:knowledge-addons/7.0.
=== added directory 'cmis_write'
=== added file 'cmis_write/__init__.py'
--- cmis_write/__init__.py	1970-01-01 00:00:00 +
+++ cmis_write/__init__.py	2014-04-02 22:22:35 +
@@ -0,0 +1,26 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#().
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+from . import ir_attachment
+from . import metadata
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'cmis_write/__openerp__.py'
--- cmis_write/__openerp__.py	1970-01-01 00:00:00 +
+++ cmis_write/__openerp__.py	2014-04-02 22:22:35 +
@@ -0,0 +1,71 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2014 Savoir-faire Linux
+#().
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+{
+'name': 'CMIS Write',
+'version': '0.1',
+'category': 'Knowledge Management',
+'summary': 'Create Document in DMS from OpenErp',
+'description': """
+Add Documents from OpenErp
+==
+
+This module allows you to store OpenERP document in the DMS repository.
+
+Configuration
+=
+
+* Create a new CMIS backend with the host, login and password.
+* Configure the path in the repository where documents will be dropped.
+  By default, it uses the home directory of the user.
+
+Usage
+=
+
+* On one OpenERP record, click "Add document".
+* Upload your documents
+* Uploaded documents will be enqueued for storage in the DMS
+
+Contributors
+
+* El Hadji Dem (elhadji@savoirfairelinux.com)
+""",
+'author': 'Savoir-faire Linux',
+'website': 'www.savoirfairelinux.com',
+'license': 'AGPL-3',
+'depends': [
+'document',
+'cmis',
+],
+'data': [
+'metadata_view.xml',
+'security/ir.model.access.csv',
+],
+'js': [],
+'qweb': [],
+'test': [],
+'demo': [],
+'installable': True,
+'auto_install': False,
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added directory 'cmis_write/i18n'
=== added file 'cmis_write/i18n/cmis_write.pot'
--- cmis_write/i18n/cmis_write.pot	1970-01-01 00:00:00 +
+++ cmis_write/i18n/cmis_write.pot	2014-04-02 22:22:35 +
@@ -0,0 +1,89 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+# 	* cmis_write
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-03-21 14:59+\n"
+"PO-Revision

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/branch_pep8 into lp:lp-community-utils

[Sandy Carter (http://www.savoirfairelinux.com)]

@Guewen, thank you for the link, I was wondering if such a tool existed.
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/branch_pep8/+merge/205260
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:lp-community-utils.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into lp:server-env-tools

[Yannick Vaucher @ Camptocamp]

The proposal to merge lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey 
into lp:server-env-tools has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338
-- 
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

[Matthieu Dietrich @ camptocamp]

The proposal to merge lp:~camptocamp/contract-management/hours_block_vre into 
lp:contract-management has been updated.

Description changed to:

- a new field for the department, which is filterable/searchable,
- a new button in the form view in order to display the hours block related to 
a project.

For more details, see:
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
-- 
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde into lp:carriers-deliveries/6.1

[Romain Deheele - Camptocamp]

Romain Deheele - Camptocamp has proposed merging 
lp:~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde 
into lp:carriers-deliveries/6.1.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)
Related bugs:
  Bug #1301458 in Carriers And Deliveries Management: "[6.1/7.0] possible error 
: TypeError: 'must be type, not browse_record'"
  https://bugs.launchpad.net/carriers-deliveries/+bug/1301458

For more details, see:
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde/+merge/213883

Hi,

In base_delivery_carrier_files_document, file carrier_file.py,
by coincidence, the class and a frequently used parameter are both named 
"carrier_file".
in l.55, the super method will take carrier_file parameter while it needs 
carrier_file, the class name.
It causes logically the error : TypeError: 'must be type, not browse_record'

Great catch from Leonardo Pistone, thank you.

Regards,

Romain
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde/+merge/213883
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/carriers-deliveries/6.1-change-class-name-to-avoid-error_rde 
into lp:carriers-deliveries/6.1.
=== modified file 'base_delivery_carrier_files_document/carrier_file.py'
--- base_delivery_carrier_files_document/carrier_file.py	2012-04-02 06:59:30 +
+++ base_delivery_carrier_files_document/carrier_file.py	2014-04-02 16:03:35 +
@@ -24,11 +24,11 @@
 from osv import osv, fields
 
 
-class carrier_file(osv.osv):
+class carrier_file_model(osv.osv):
 _inherit = 'delivery.carrier.file'
 
 def get_write_mode_selection(self, cr, uid, context=None):
-res = super(carrier_file, self).get_write_mode_selection(cr, uid, context=context)
+res = super(carrier_file_model, self).get_write_mode_selection(cr, uid, context=context)
 if 'document' not in res:
 res.append(('document', 'Document'))
 return res
@@ -52,7 +52,7 @@
 self.pool.get('ir.attachment').create(cr, uid, vals, context=context)
 return True
 else:
-return (super(carrier_file, self)
+return (super(carrier_file_model, self)
 ._write_file(cr, uid, carrier_file, filename, file_content, context=None))
 
-carrier_file()
+carrier_file_model()

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

[noreply]

The proposal to merge lp:~camptocamp/contract-management/hours_block_vre into 
lp:contract-management has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
-- 
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into lp:server-env-tools

[Sylvain LE GAL (GRAP)]

Hi yannick, 

Thanks to update your review status. I put quote in the translation file.

@all : 7 approves, Thanks !

Regards.
-- 
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

[Romain Deheele - Camptocamp]

Romain Deheele - Camptocamp has proposed merging 
lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde 
into lp:carriers-deliveries.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)
Related bugs:
  Bug #1301458 in Carriers And Deliveries Management: "[6.1/7.0] possible error 
: TypeError: 'must be type, not browse_record'"
  https://bugs.launchpad.net/carriers-deliveries/+bug/1301458

For more details, see:
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881

Hi,

In base_delivery_carrier_files_document, file carrier_file.py,
by coincidence, the class and a frequently used parameter are both named 
"carrier_file".
in l.61, the super method will take carrier_file parameter while it needs 
carrier_file, the class name.
It causes logically the error : TypeError: 'must be type, not browse_record'

Great catch from Leonardo Pistone, thank you.

Regards,

Romain
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde 
into lp:carriers-deliveries.
=== modified file 'base_delivery_carrier_files_document/carrier_file.py'
--- base_delivery_carrier_files_document/carrier_file.py	2014-03-27 14:49:41 +
+++ base_delivery_carrier_files_document/carrier_file.py	2014-04-02 15:58:23 +
@@ -24,11 +24,11 @@
 from openerp.osv import orm, fields
 
 
-class carrier_file(orm.Model):
+class carrier_file_model(orm.Model):
 _inherit = 'delivery.carrier.file'
 
 def get_write_mode_selection(self, cr, uid, context=None):
-res = super(carrier_file, self).\
+res = super(carrier_file_model, self).\
 get_write_mode_selection(cr, uid, context=context)
 if 'document' not in res:
 res.append(('document', 'Document'))
@@ -58,6 +58,6 @@
 self.pool['ir.attachment'].create(cr, uid, vals, context=context)
 return True
 else:
-return (super(carrier_file, self)
+return (super(carrier_file_model, self)
 ._write_file(cr, uid, carrier_file, filename, file_content,
  context=None))

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh into lp:contract-management

[noreply]

The proposal to merge 
lp:~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh 
into lp:contract-management has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh/+merge/204957
-- 
https://code.launchpad.net/~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh/+merge/204957
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh into lp:contract-management

[Yannick Vaucher @ Camptocamp]

The proposal to merge 
lp:~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh 
into lp:contract-management has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh/+merge/204957
-- 
https://code.launchpad.net/~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh/+merge/204957
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

[Alexandre Fayolle - camptocamp]

Review: Approve code review, no test


-- 
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh into lp:contract-management

[Alexandre Fayolle - camptocamp]

Review: Approve code review, no test


-- 
https://code.launchpad.net/~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh/+merge/204957
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/project-reporting/blank_invoice_vre into lp:project-reporting

[Leonardo Pistone - camptocamp]

Review: Approve

ok!
-- 
https://code.launchpad.net/~camptocamp/project-reporting/blank_invoice_vre/+merge/213842
Your team Project Core Editors is subscribed to branch lp:project-reporting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into lp:server-env-tools

[Yannick Vaucher @ Camptocamp]

Review: Approve

In translation

> Mot de passe bris de glace

I would write "bris de glace" in quotes or replace it by "d'urgence" ou "de 
secours" voir "de récupération"

But I don't block the MP for this.


-- 
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/project-reporting/blank_invoice_vre into lp:project-reporting

[Vincent Renaville@camptocamp]

Leonardo,

Thanks for your review,

from my point of view,this module is only use to create a invoice template, so 
I don't want to add a contact on the project, it can be disturbing for the 
project manager/user.
It's the responsibility of the accountant to set the correct contact. 

Vincent


-- 
https://code.launchpad.net/~camptocamp/project-reporting/blank_invoice_vre/+merge/213842
Your team Project Core Editors is subscribed to branch lp:project-reporting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm into lp:partner-contact-management

[Vincent Renaville@camptocamp]

Hello,

Thanks for the review

I have improve code visibility according to your review and the module 
description.

I have test manually with different kind of email.

Thanks for the review

Vincent



-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm/+merge/213673
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh into lp:contract-management

[Matthieu Dietrich @ camptocamp]

Alexandre,

thanks for the comment; I added values in POT file.

Regards,
Matthieu
-- 
https://code.launchpad.net/~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh/+merge/204957
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:carriers-deliveries

[Alex Comba - Agile BG]

Alex Comba - Agile BG has proposed merging 
lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into 
lp:carriers-deliveries.

Commit message:
[ADD] module delivery_optional_invoice_line

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867

I added the module named 'delivery_optional_invoice_line'.

It allows to remove the default shipping line from the invoices created from 
picking. To do so, the user shall go to the deliver carrier form and select the 
option 'Do not create line on invoice'. 
-- 
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into 
lp:carriers-deliveries.
=== added directory 'delivery_optional_invoice_line'
=== added file 'delivery_optional_invoice_line/__init__.py'
--- delivery_optional_invoice_line/__init__.py	1970-01-01 00:00:00 +
+++ delivery_optional_invoice_line/__init__.py	2014-04-02 15:01:51 +
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Copyright (C) 2014 Agile Business Group sagl
+#	 ()
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as published
+#by the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+from . import delivery

=== added file 'delivery_optional_invoice_line/__openerp__.py'
--- delivery_optional_invoice_line/__openerp__.py	1970-01-01 00:00:00 +
+++ delivery_optional_invoice_line/__openerp__.py	2014-04-02 15:01:51 +
@@ -0,0 +1,45 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Copyright (C) 2014 Agile Business Group sagl
+#()
+#@author Alex Comba 
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as published
+#by the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+{
+'name': "Delivery Optional Invoice Line",
+'version': '0.1',
+'category': 'Sales Management',
+'description': """
+This module allows to remove the default shipping line from the invoices
+created from picking. To do so, the user shall go to the deliver carrier form
+and select the option 'Do not create line on invoice'.
+""",
+'author': 'Agile Business Group',
+'website': 'http://www.agilebg.com',
+'license': 'AGPL-3',
+'depends': [
+'delivery',
+],
+'data': [
+'delivery_view.xml',
+],
+'test': [
+'test/delivery_optional_invoice_line.yml',
+],
+'active': False,
+'installable': True
+}

=== added file 'delivery_optional_invoice_line/delivery.py'
--- delivery_optional_invoice_line/delivery.py	1970-01-01 00:00:00 +
+++ delivery_optional_invoice_line/delivery.py	2014-04-02 15:01:51 +
@@ -0,0 +1,47 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Copyright (C) 2014 Agile Business Group sagl
+#()
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as published
+#by the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the impl

Re: [Openerp-community-reviewer] [Merge] lp:~echeverrifm/oemedical/oemedical_socioeconomics into lp:oemedical

[Yannick Vaucher @ Camptocamp]

Review: Approve

Thanks Frederico
-- 
https://code.launchpad.net/~echeverrifm/oemedical/oemedical_socioeconomics/+merge/205523
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

[Matthieu Dietrich @ camptocamp]

@afayolle: thanks, I re-formatted it now.
-- 
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~echeverrifm/oemedical/oemedical_socioeconomics into lp:oemedical

[Federico Manuel Echeverri Choux]

> Mispellings:
> 
> l.75 Infraestructure
> l.893 please remove commented field
> 
> Otherwise LGTM

Hello Yannick 

I do it 

Could you check it? please

Thanks and regards
-- 
https://code.launchpad.net/~echeverrifm/oemedical/oemedical_socioeconomics/+merge/205523
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-stock-picking-duplication-fix-regression-from-v7port-and-add-a-test_rde into lp:carriers-deliveries

[Alexandre Fayolle - camptocamp]

You have been requested to review the proposed merge of 
lp:~camptocamp/carriers-deliveries/7.0-stock-picking-duplication-fix-regression-from-v7port-and-add-a-test_rde
 into lp:carriers-deliveries.

For more details, see:
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-stock-picking-duplication-fix-regression-from-v7port-and-add-a-test_rde/+merge/212878

Hi,

It :
- moves "def copy" overload from stock.picking object to stock.picking.out 
object.
This overload manages unchecking of carrier_file_generated checkbox when you 
copy a picking.
- adds a test to check stock.picking duplication and unchecking of 
carrier_file_generated checkbox.

Regards,

Romain

-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-stock-picking-duplication-fix-regression-from-v7port-and-add-a-test_rde/+merge/212878
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/carriers-deliveries/7.0-stock-picking-duplication-fix-regression-from-v7port-and-add-a-test_rde
 into lp:carriers-deliveries.
=== modified file 'base_delivery_carrier_files/stock.py'
--- base_delivery_carrier_files/stock.py	2014-03-24 10:53:06 +
+++ base_delivery_carrier_files/stock.py	2014-03-26 15:48:36 +
@@ -78,21 +78,21 @@
 self.generate_carrier_files(cr, uid, ids, auto=True, context=context)
 return result
 
+
+class stock_picking_out(orm.Model):
+_inherit = 'stock.picking.out'
+
+_columns = {
+'carrier_file_generated': fields.boolean('Carrier File Generated',
+ readonly=True,
+ help="The file for "
+ "the delivery carrier "
+ "has been generated."),
+}
+
 def copy(self, cr, uid, id, default=None, context=None):
 if default is None:
 default = {}
 default.update({'carrier_file_generated': False})
-return super(stock_picking, self).copy(cr, uid, id, default,
-   context=context)
-
-
-class stock_picking_out(orm.Model):
-_inherit = 'stock.picking.out'
-
-_columns = {
-'carrier_file_generated': fields.boolean('Carrier File Generated',
- readonly=True,
- help="The file for "
- "the delivery carrier "
- "has been generated."),
-}
+return super(stock_picking_out, self).copy(cr, uid, id, default,
+   context=context)

=== modified file 'base_delivery_carrier_files/test/carrier_file.yml'
--- base_delivery_carrier_files/test/carrier_file.yml	2014-03-18 17:19:02 +
+++ base_delivery_carrier_files/test/carrier_file.yml	2014-03-26 15:48:36 +
@@ -38,3 +38,9 @@
 -
   !assert {model: stock.picking.out, id: outgoing_shipment_carrier_file, string: Carrier file should be generated}:
 - carrier_file_generated == True
+-
+  I check outgoing shipment copy, the carrier_file_generated field must be unchecked
+-
+  !python {model: stock.picking.out}: |
+new_id = self.copy(cr, uid, ref('outgoing_shipment_carrier_file'))
+assert self.read(cr, uid, new_id, ['carrier_file_generated'])['carrier_file_generated'] == False, "After duplication, the file generated checkbox is unchecked"

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-stock-picking-duplication-fix-regression-from-v7port-and-add-a-test_rde into lp:carriers-deliveries

[Alexandre Fayolle - camptocamp]

Review: Approve code review, no test

LGTM


-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-stock-picking-duplication-fix-regression-from-v7port-and-add-a-test_rde/+merge/212878
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

[Alexandre Fayolle - camptocamp]

Review: Needs Fixing code review, no test

42  + 'account.hours.block': (lambda self, cr, uid, ids, c=None:
43  + ids, ['invoice_id'], 10),

this is a very bad line split, please keep the 'ids' on the same line as the 
lambda


missing i18n update
-- 
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm into lp:partner-contact-management

[Alexandre Fayolle - camptocamp]

Review: Needs Fixing code review, no test

I fail to see how the addon name "crm_firstname" relates to the described 
functionality. Please copy the description provided in the MP in __openerp__.py 
: this is what people looking at the module will see. 

__openerp__.py : s/demo_xml/demo/ and then remove it as it is empty

+ 'email': tools.email_split(lead.email_from) and 
tools.email_split(lead.email_from)[0] or False, => use the val if cond else 
default construct if you absolutely want this on a single line. Same thing for 
the other fields in that dict. 

you forgot to add the tests and to link them in __openerp__.py :-)
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm/+merge/213673
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/project-reporting/blank_invoice_vre into lp:project-reporting

[Alexandre Fayolle - camptocamp]

Review: Approve code review, no test

LGTM
-- 
https://code.launchpad.net/~camptocamp/project-reporting/blank_invoice_vre/+merge/213842
Your team Project Core Editors is subscribed to branch lp:project-reporting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

[Yannick Vaucher @ Camptocamp]

Review: Approve code review, no test

Well done Thanks

LGTM
-- 
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-credit-control-scenarios-nbi into lp:account-financial-tools

[noreply]

The proposal to merge 
lp:~camptocamp/account-financial-tools/7.0-fix-credit-control-scenarios-nbi 
into lp:account-financial-tools has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-credit-control-scenarios-nbi/+merge/209050
-- 
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-credit-control-scenarios-nbi/+merge/209050
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh into lp:contract-management

[Alexandre Fayolle - camptocamp]

Review: Needs Fixing code review, no test

missing i18n/analytic_hours_block.pot 
-- 
https://code.launchpad.net/~camptocamp/contract-management/7.0-add-product-attribute-hours-block-mdh/+merge/204957
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/add-base_partner_merge into lp:partner-contact-management

[Yannick Vaucher @ Camptocamp]

@guewen Extracted in portal_partner_merge
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/contract-management/hours_block_vre into lp:contract-management

[Matthieu Dietrich @ camptocamp]

I fixed the store fields (not only department_id; other related() as well) to 
be refreshed if the distant field is modified.

Regards,
Matthieu
-- 
https://code.launchpad.net/~camptocamp/contract-management/hours_block_vre/+merge/205212
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:contract-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm into lp:partner-contact-management

[Yannick Vaucher @ Camptocamp]

Could you provide some docstring and exemples of what will do 
_common_lead_partner ?
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm/+merge/213673
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/project-reporting/blank_invoice_vre into lp:project-reporting

[Leonardo Pistone - camptocamp]

Review: Needs Information

Thanks Vincent.

I don't know the module affected, but shouldn't the contact (now a res.partner 
and not a res.partner.address) be handled somehow?
-- 
https://code.launchpad.net/~camptocamp/project-reporting/blank_invoice_vre/+merge/213842
Your team Project Core Editors is requested to review the proposed merge of 
lp:~camptocamp/project-reporting/blank_invoice_vre into lp:project-reporting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/project-reporting/blank_invoice_vre into lp:project-reporting

[Vincent Renaville@camptocamp]

Vincent Renaville@camptocamp has proposed merging 
lp:~camptocamp/project-reporting/blank_invoice_vre into lp:project-reporting.

Requested reviews:
  Project Core Editors (project-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/project-reporting/blank_invoice_vre/+merge/213842

This fix prevent blank invoice wizard to crash because contact_id is not 
present on V7 project.
-- 
https://code.launchpad.net/~camptocamp/project-reporting/blank_invoice_vre/+merge/213842
Your team Project Core Editors is requested to review the proposed merge of 
lp:~camptocamp/project-reporting/blank_invoice_vre into lp:project-reporting.
=== modified file 'project_billing_utils/wizard/blank_invoice.py'
--- project_billing_utils/wizard/blank_invoice.py	2013-06-20 16:14:51 +
+++ project_billing_utils/wizard/blank_invoice.py	2014-04-02 13:16:22 +
@@ -62,24 +62,11 @@
 pterm_list.sort()
 date_due = pterm_list[-1]
 
-if project.contact_id:
-inv_contact = project.contact_id.id
-else:
-inv_contact = partner_obj.address_get(
-cr, uid,
-[partner.id],
-adr_pref=['invoice'])['invoice']
-
 return {
 'name': '%s - %s' % (time.strftime('%D'), project.name),
 'type':'out_invoice',
 'date_due': date_due,
 'partner_id': partner.id,
-'address_contact_id': partner_obj.address_get(
-cr, uid,
-[partner.id],
-adr_pref=['contact'])['contact'],
-'address_invoice_id': inv_contact,
 'payment_term': partner.property_payment_term.id or False,
 'account_id': partner.property_account_receivable.id,
 'currency_id': project.pricelist_id.currency_id.id,

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into lp:server-env-tools

[David BEAL]

Really good idea !
thanks
-- 
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~florian-dacosta/server-env-tools/sql_query_export_csv_file into lp:server-env-tools

[Florian da Costa]

Florian da Costa has proposed merging 
lp:~florian-dacosta/server-env-tools/sql_query_export_csv_file into 
lp:server-env-tools.

Requested reviews:
  Sébastien BEAU - http://www.akretion.com (sebastien.beau)

For more details, see:
https://code.launchpad.net/~florian-dacosta/server-env-tools/sql_query_export_csv_file/+merge/213826

Add a module named sql_export which allow a group of user to create and edit a 
new object with a sql query.
This query can be executed by the chosen groups or users in order to export the 
data of the query in a CSV file.
-- 
https://code.launchpad.net/~florian-dacosta/server-env-tools/sql_query_export_csv_file/+merge/213826
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.
=== added directory 'sql_export'
=== added file 'sql_export/__init__.py'
--- sql_export/__init__.py	1970-01-01 00:00:00 +
+++ sql_export/__init__.py	2014-04-02 12:02:27 +
@@ -0,0 +1,24 @@
+# -*- coding: utf-8 -*-
+###
+#
+#   action_server_email for OpenERP
+#   Copyright (C) 2013-TODAY Akretion .
+#   @author Florian DA COSTA 
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see .
+#
+###
+
+import sql
+import wizard

=== added file 'sql_export/__openerp__.py'
--- sql_export/__openerp__.py	1970-01-01 00:00:00 +
+++ sql_export/__openerp__.py	2014-04-02 12:02:27 +
@@ -0,0 +1,49 @@
+# -*- coding: utf-8 -*-
+###
+#
+#   action_server_email for OpenERP
+#   Copyright (C) 2013-TODAY Akretion .
+#   @author Florian DA COSTA 
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as
+#   published by the Free Software Foundation, either version 3 of the
+#   License, or (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU Affero General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see .
+#
+###
+
+
+{
+'name': 'SQL Export',
+'version': '0.1',
+'category': 'Generic Modules/Others',
+'license': 'AGPL-3',
+'description': 
+"""
+Allow to execute sql query from openerp interface in order to export datas in csv files.
+To edit or create a query, the user have to be in sql_query editor group.
+To execute a query, the user or group of user have to be specified in the sql_export record.
+""",
+'author': 'Akretion',
+'website': 'http://www.akretion.com/',
+'depends': [
+"base",
+], 
+'init_xml': [],
+'update_xml': [ 
+'sql_view.xml',
+'wizard/wizard_file_view.xml',
+'security/sql_export_security.xml',
+'security/ir.model.access.csv',
+],
+'demo_xml': [],
+'installable': True,
+}

=== added directory 'sql_export/i18n'
=== added file 'sql_export/i18n/fr.po'
--- sql_export/i18n/fr.po	1970-01-01 00:00:00 +
+++ sql_export/i18n/fr.po	2014-04-02 12:02:27 +
@@ -0,0 +1,132 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* sql_export
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-04-01 08:39+\n"
+"PO-Revision-Date: 2014-04-01 08:39+\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: sql_export
+#: model:ir.ui.menu,name:sql_export.menu_export
+msgid "Export"
+msgstr "Export"
+
+#. module: sql_export
+#: code:addons/sql_export/sql.py:103
+#: code:addons/sql_export/sql.py:114
+#, python-format
+msgid "Invalid Query"
+msgstr "Requête Invalide"
+
+#. module: sql_export
+#: model:res.groups,name:sql_exp

[Openerp-community-reviewer] [Merge] lp:~florian-dacosta/server-env-tools/sql_query_export_csv_file into lp:server-env-tools

[Florian da Costa]

The proposal to merge 
lp:~florian-dacosta/server-env-tools/sql_query_export_csv_file into 
lp:server-env-tools has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~florian-dacosta/server-env-tools/sql_query_export_csv_file/+merge/213826
-- 
https://code.launchpad.net/~florian-dacosta/server-env-tools/sql_query_export_csv_file/+merge/213826
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into lp:project-service

[Daniel Reis]

Daniel Reis has proposed merging 
lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into 
lp:project-service.

Requested reviews:
  Project Core Editors (project-core-editors)

For more details, see:
https://code.launchpad.net/~dreis-pt/project-service/7.0-project_issue_reassign-dr/+merge/195275

Module to improve Issue reassignment to other Projects or Users.
-- 
https://code.launchpad.net/~dreis-pt/project-service/7.0-project_issue_reassign-dr/+merge/195275
Your team Project Core Editors is requested to review the proposed merge of 
lp:~dreis-pt/project-service/7.0-project_issue_reassign-dr into 
lp:project-service.
=== added directory 'project_issue_reassign'
=== added file 'project_issue_reassign/__init__.py'
--- project_issue_reassign/__init__.py	1970-01-01 00:00:00 +
+++ project_issue_reassign/__init__.py	2014-04-02 11:39:40 +
@@ -0,0 +1,3 @@
+# -*- coding: utf-8 -*-
+import project
+import wizard

=== added file 'project_issue_reassign/__openerp__.py'
--- project_issue_reassign/__openerp__.py	1970-01-01 00:00:00 +
+++ project_issue_reassign/__openerp__.py	2014-04-02 11:39:40 +
@@ -0,0 +1,54 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Copyright (C) 2013 Daniel Reis
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+{
+'name': 'Reassign Project Issues',
+'summary': 'Reassign Issues to other Responsibles and Projects',
+'version': '1.1',
+"category": "Project Management",
+'description': """\
+The Responsible (``user_id``) field is made read only, and can instead be
+changed through a wizard, accessible only to Project Users.
+
+Regular users (Employee group) will be able to see who is handling the request,
+but won't be able to change it.
+
+Project Users can click on the "=> Reassign" link, in front of the current
+responsible, to open a dialog where they can select the new responsible and/or
+new Project/Service Team it should be assigned to.
+
+Mass reassignments can also be made, through the context menu action on the
+Issues list view.
+
+Also adds notifications to followers when issue is reassigned / responsible
+is changed.
+""",
+'author': 'Daniel Reis',
+'website': '',
+'depends': [
+'project_issue',
+],
+'data': [
+'project_issue_data.xml',
+'wizard/project_issue_reassign_view.xml',
+'project_issue_view.xml',
+],
+'installable': True,
+}
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added directory 'project_issue_reassign/i18n'
=== added file 'project_issue_reassign/i18n/project_issue_reassign.pot'
--- project_issue_reassign/i18n/project_issue_reassign.pot	1970-01-01 00:00:00 +
+++ project_issue_reassign/i18n/project_issue_reassign.pot	2014-04-02 11:39:40 +
@@ -0,0 +1,82 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* project_issue_reassign
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-04-02 10:56+\n"
+"PO-Revision-Date: 2014-04-02 10:56+\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: project_issue_reassign
+#: view:project.issue.reassign:0
+msgid "or"
+msgstr ""
+
+#. module: project_issue_reassign
+#: code:addons/project_issue_reassign/wizard/project_issue_reassign.py:42
+#, python-format
+msgid "No active Issues found."
+msgstr ""
+
+#. module: project_issue_reassign
+#: model:ir.model,name:project_issue_reassign.model_project_issue
+msgid "Project Issue"
+msgstr ""
+
+#. module: project_issue_reassign
+#: model:ir.model,name:project_issue_reassign.model_project_issue_reassign
+msgid "Issue Reassign"
+msgstr ""
+
+#. module: project_issue_reassign
+#: view:project.issue.reassign:0
+msgid "_Reassign"
+msgstr ""
+
+#. module: project_issue_reassign
+#: model:ir.actions.act_window,name:project_issue_reassign.issue_reassign_wizard_action
+msgid "Reassign Issues"
+msgstr ""
+
+#. module: project_issue_reassign
+#: model:ir.actions.act_window,name:project_issue_reassign.action_project_issue_rea

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/add_aged_partner_ledger-nbi into lp:account-financial-report

[Acsone]

Review: Needs Information test

Hi Nicolas,

I did a quick test and found significant differences from the standard report 
which I need to investigate, so if you don't mind I'll put it Need Information 
so it does not get merged accidentally.

It is probably an issue in my test data, I'll get back to you as soon as 
possible.

Another question, is there a particular reason you did not implement the 
"period length" and leave it to 30 days?
-- 
https://code.launchpad.net/~camptocamp/account-financial-report/add_aged_partner_ledger-nbi/+merge/211040
Your team Account Report Core Editors is subscribed to branch 
lp:account-financial-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company into lp:web-addons

[Sylvain LE GAL (GRAP)]

Sylvain LE GAL (GRAP) has proposed merging 
lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company into lp:web-addons.

Requested reviews:
  Guewen Baconnier @ Camptocamp (gbaconnier-c2c)
  Pedro Manuel Baeza (pedro.baeza): code review and test
  arthru (arthru): tested, no-review

For more details, see:
https://code.launchpad.net/~sylvain-legal/web-addons/7.0-web_easy_switch_company/+merge/210289

Add a new module 'web_easy_switch_company'. 

This module allow a user to switch from a company to another more easily. (with 
just 2 mouse click & without warning message).

-- 
https://code.launchpad.net/~sylvain-legal/web-addons/7.0-web_easy_switch_company/+merge/210289
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
=== added directory 'web_easy_switch_company'
=== added file 'web_easy_switch_company/__init__.py'
--- web_easy_switch_company/__init__.py	1970-01-01 00:00:00 +
+++ web_easy_switch_company/__init__.py	2014-04-02 09:20:18 +
@@ -0,0 +1,24 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#Web Easy Switch Company module for OpenERP
+#Copyright (C) 2014 GRAP (http://www.grap.coop)
+#@author Sylvain LE GAL (https://twitter.com/legalsylvain)
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+from . import model
+from . import controllers

=== added file 'web_easy_switch_company/__openerp__.py'
--- web_easy_switch_company/__openerp__.py	1970-01-01 00:00:00 +
+++ web_easy_switch_company/__openerp__.py	2014-04-02 09:20:18 +
@@ -0,0 +1,71 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#Web Easy Switch Company module for OpenERP
+#Copyright (C) 2014 GRAP (http://www.grap.coop)
+#@author Sylvain LE GAL (https://twitter.com/legalsylvain)
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+{
+'name': 'Multicompany - Easy Switch Company',
+'version': '1.0',
+'category': 'web',
+'description': """
+Add menu to allow user to switch to another company more easily
+===
+
+Functionality:
+--
+* Add a new menu in the top bar to switch to another company more easily;
+* Remove the old behaviour to switch company;
+
+Documentations:
+---
+* Video : http://www.youtube.com/watch?v=Cpm6dg-IEQQ
+
+Technical information:
+--
+* Create a field function 'logo_topbar' in res_company to have a good"""
+"""resized logo;
+
+Limits:
+---
+* It would be interesting to show the structure of the companies;
+
+Copyright, Author and Licence:
+--
+* Copyright: 2014, Groupement Régional Alimentaire de Proximité;
+* Author: Sylvain LE GAL (https://twitter.com/legalsylvain);
+* Licence: AGPL-3 (http://www.gnu.org/licenses/)""",
+'author': 'GRAP',
+'website': 'http://www.grap.coop',
+'license': 'AGPL-3',
+'depends': [
+'web',
+],
+'data': [
+'view/res_users_view.xml',
+],
+'js': [
+'static/src/js/switch_company.js',
+],
+'qweb': [
+'static/src/xml/switch_company.xml',
+],
+'installable': True,
+'auto_install': False,
+}

=== added directory 'web_easy_switch_company/controllers'
=== added file 'web_easy_switch_company/controllers/__init__.py'
--- web_easy_switch_company/controllers/__init__.py	1970-01-01 00:00:00 +
+++ web_easy_switch_c

[Openerp-community-reviewer] [Merge] lp:~yajo/server-env-tools/7.0-fix-eval into lp:server-env-tools

[Yajo]

Yajo has proposed merging lp:~yajo/server-env-tools/7.0-fix-eval into 
lp:server-env-tools.

Requested reviews:
  Server Environment And Tools Core Editors (server-env-tools-core-editors)

For more details, see:
https://code.launchpad.net/~yajo/server-env-tools/7.0-fix-eval/+merge/213800

Fix bug 1285619 and bug 1235969.
-- 
https://code.launchpad.net/~yajo/server-env-tools/7.0-fix-eval/+merge/213800
Your team Server Environment And Tools Core Editors is requested to review the 
proposed merge of lp:~yajo/server-env-tools/7.0-fix-eval into 
lp:server-env-tools.
=== modified file 'super_calendar/super_calendar.py'
--- super_calendar/super_calendar.py	2013-01-11 16:43:17 +
+++ super_calendar/super_calendar.py	2014-04-02 10:16:31 +
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 ##
-#
+#
 #Copyright (C) 2012 Agile Business Group sagl ()
 #Copyright (C) 2012 Domsense srl ()
 #
@@ -25,7 +25,7 @@
 from mako.template import Template
 from datetime import datetime
 from openerp import tools
-from openerp.tools import safe_eval as eval
+from openerp.tools.safe_eval import safe_eval
 
 def _models_get(self, cr, uid, context=None):
 obj = self.pool.get('ir.model')
@@ -44,20 +44,25 @@
 def generate_calendar_records(self, cr, uid, ids, context=None):
 configurator_ids = self.search(cr, uid, [])
 super_calendar_pool = self.pool.get('super.calendar')
-
+
 # removing old records
 super_calendar_ids = super_calendar_pool.search(cr, uid, [], context=context)
 super_calendar_pool.unlink(cr, uid, super_calendar_ids, context=context)
-
+
 for configurator in self.browse(cr, uid, configurator_ids, context):
 for line in configurator.line_ids:
 current_pool = self.pool.get(line.name.model)
-current_record_ids = current_pool.search(cr, uid, line.domain and eval(line.domain) or [], context=context)
+current_record_ids = current_pool.search(
+cr,
+uid,
+line.domain and eval(line.domain) or [],
+context=context)
+
 for current_record_id in current_record_ids:
 current_record  = current_pool.browse(cr, uid, current_record_id, context=context)
 if line.user_field_id and \
 current_record[line.user_field_id.name] and current_record[line.user_field_id.name]._table_name != 'res.users':
-raise osv.except_osv(_('Error'), 
+raise osv.except_osv(_('Error'),
 _("The 'User' field of record %s (%s) does not refer to res.users")
 % (current_record[line.description_field_id.name], line.name.model))
 if (((line.description_field_id
@@ -116,7 +121,7 @@
 'user_field_id': fields.many2one('ir.model.fields', 'User field',
 domain="['&',('ttype', '=', 'many2one'),('model_id', '=', name)]"),
 }
-
+
 
 class super_calendar(orm.Model):
 _name = 'super.calendar'

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm into lp:partner-contact-management

[Vincent Renaville@camptocamp]

Thanks Yannick for your review,

I have fixed according to your review at rev 33.

For the _compute_name_custom , I think I have used an old version of the 
version present partner_firstname module.
I have update it as well.

Vincent
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm/+merge/213673
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~stefan-therp/ocb-web/7.0-lp1293085-binary_field_widget_in_list_views into lp:ocb-web

[Yannick Vaucher @ Camptocamp]

Review: Approve code review, no test


-- 
https://code.launchpad.net/~stefan-therp/ocb-web/7.0-lp1293085-binary_field_widget_in_list_views/+merge/211489
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~jeffery9/ocb-addons/ocb-addons-fixups into lp:ocb-addons

[Yannick Vaucher @ Camptocamp]

Review: Disapprove


-- 
https://code.launchpad.net/~jeffery9/ocb-addons/ocb-addons-fixups/+merge/194463
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr into lp:web-addons

[Guewen Baconnier @ Camptocamp]

Guewen Baconnier @ Camptocamp has proposed merging 
lp:~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr
 into lp:web-addons.

Commit message:
Propagate back and forth edited fields on the current language between the 
current view and the translate dialog.

Requested reviews:
  Web-Addons Core Editors (webaddons-core-editors)
Related bugs:
  Bug #1301218 in Web addons for OpenERP: "web_translate_dialog: current 
language not synchronized when edited"
  https://bugs.launchpad.net/web-addons/+bug/1301218

For more details, see:
https://code.launchpad.net/~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr/+merge/213783

Fix lp:1301218

-- 
https://code.launchpad.net/~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr/+merge/213783
Your team Web-Addons Core Editors is requested to review the proposed merge of 
lp:~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr
 into lp:web-addons.
=== modified file 'web_translate_dialog/static/src/js/web_translate_dialog.js'
--- web_translate_dialog/static/src/js/web_translate_dialog.js	2014-02-25 14:29:42 +
+++ web_translate_dialog/static/src/js/web_translate_dialog.js	2014-04-02 08:58:31 +
@@ -126,10 +126,24 @@
 });
 });
 },
-// use a `read_translations` method instead of a `read`
-// this latter leave the fields empty if there is no
-// translation for a field instead of taking the src field
-do_load_fields_values: function(callback) {
+set_fields_values: function(lang, values) {
+var self = this;
+_.each(this.translatable_fields_keys, function(f) {
+self.$el.find('.oe_translation_field[name="' + lang.code + '-' + f + '"]')
+.val(values[f] || '')
+.attr('data-value', values[f] || '');
+
+var $tarea = self.$el.find('.oe_form_field_html .oe_translation_field[name="' + lang.code + '-' + f + '"]');
+if ($tarea.length) {
+$tarea.cleditor()[0].updateFrame();
+}
+});
+var $textarea = this.$el.find('textarea.oe_translation_field');
+$textarea.css({minHeight:'100px'});
+$textarea.autosize();
+$(window).resize();  // triggers the autosize
+},
+do_load_fields_values: function() {
 var self = this,
 deferred = [];
 
@@ -137,31 +151,25 @@
 _.each(self.languages, function(lg) {
 var deff = $.Deferred();
 deferred.push(deff);
-var callback = function(values) {
+if (lg.code === self.view_language) {
+var values = {};
+_.each(self.translatable_fields_keys, function(field) {
+values[field] = self.view.fields[field].get_value();
+});
+self.set_fields_values(lg, values);
+deff.resolve();
+} else {
+self.view.dataset.call(
+'read',
+[[self.view.datarecord.id],
+self.translatable_fields_keys,
+self.view.dataset.get_context({
+'lang': lg.code
+})]).done(function (rows) {
+self.set_fields_values(lg, rows[0]);
+deff.resolve();
+});
 };
-self.view.dataset.call(
-'read',
-[[self.view.datarecord.id],
- self.translatable_fields_keys,
- self.view.dataset.get_context({
-'lang': lg.code
- })]).done(function (values) {
-_.each(self.translatable_fields_keys, function(f) {
-self.$el.find('.oe_translation_field[name="' + lg.code + '-' + f + '"]')
-.val(values[0][f] || '')
-.attr('data-value', values[0][f] || '');
-
-var $tarea = self.$el.find('.oe_form_field_html .oe_translation_field[name="' + lg.code + '-' + f + '"]');
-if ($tarea.length) {
-$tarea.cleditor()[0].updateFrame();
-}
-});
-var $textarea = self.$el.find('textarea.oe_translation_field');
-$textarea.css({minHeight:'100px'});
-$textarea.autosize();
-$(window).resize();  // triggers the autosize
-deff.resolve();
- });
 });
 return deferred;
 },
@@ -178,17 +186,7 @@
 });

Re: [Openerp-community-reviewer] [Merge] lp:~jeffery9/ocb-addons/ocb-addons into lp:ocb-addons

[Yannick Vaucher @ Camptocamp]

Review: Approve code review, no test

Please remove other changes in crm/crm_phonecall_view.xml

Otherwise LGTM
-- 
https://code.launchpad.net/~jeffery9/ocb-addons/ocb-addons/+merge/193883
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~echeverrifm/oemedical/oemedical_socioeconomics into lp:oemedical

[Yannick Vaucher @ Camptocamp]

Review: Needs Fixing

Mispellings:

l.75 Infraestructure
l.893 please remove commented field

Otherwise LGTM
-- 
https://code.launchpad.net/~echeverrifm/oemedical/oemedical_socioeconomics/+merge/205523
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company into lp:web-addons

[Sylvain LE GAL (GRAP)]

Following reviews on another merge proposal i did, I changed this MP. (non 
functional changes : just pep8, copyright & typos changes).

regards.
-- 
https://code.launchpad.net/~sylvain-legal/web-addons/7.0-web_easy_switch_company/+merge/210289
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/server-env-tools/7.0-auth_from_http_basic into lp:server-env-tools

[Stefan Rijnhart (Therp)]

Took the freedom to merge this, with three approvals. While Nicolas' judgment 
was still set to 'Needs fixing', I believe his comments have been addressed 
properly.

-- 
https://code.launchpad.net/~therp-nl/server-env-tools/7.0-auth_from_http_basic/+merge/202316
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company into lp:web-addons

[Sylvain LE GAL (GRAP)]

The proposal to merge lp:~sylvain-legal/web-addons/7.0-web_easy_switch_company 
into lp:web-addons has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~sylvain-legal/web-addons/7.0-web_easy_switch_company/+merge/210289
-- 
https://code.launchpad.net/~sylvain-legal/web-addons/7.0-web_easy_switch_company/+merge/210289
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~therp-nl/server-env-tools/7.0-auth_from_http_basic into lp:server-env-tools

[noreply]

The proposal to merge lp:~therp-nl/server-env-tools/7.0-auth_from_http_basic 
into lp:server-env-tools has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~therp-nl/server-env-tools/7.0-auth_from_http_basic/+merge/202316
-- 
https://code.launchpad.net/~therp-nl/server-env-tools/7.0-auth_from_http_basic/+merge/202316
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addons

[Guewen Baconnier @ Camptocamp]

On 04/02/2014 03:40 AM, Augustin Cisterne-Kaas - www.elico-corp.com wrote:
> Hi Guewen,
> 
> Thanks for your feedback.
> 
> Do you mean by manifest the "__openerp__.py" ? 
> 
> Kind regards,
> 
> Augustin Cisterne-Kaas
> 

Yes


-- 
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm into lp:partner-contact-management

[Yannick Vaucher @ Camptocamp]

Review: Needs Fixing code review, no test

Hello,

Thanks for this proposal. Here are few things to fix.


In _compute_name_custom why not using the same way to construct the full name?

http://bazaar.launchpad.net/~partner-contact-core-editors/partner-contact-management/7.0/view/head:/partner_firstname/partner.py#L43



ir.model.data is defined twice.

128 +obj_data = self.pool.get('ir.model.data')
129 +## We search category for this contact :
130 +obj_data = self.pool.get('ir.model.data')
131 +##

By the way you can use list index

self.pool['ir.model.data']



crm.py|111 col 1| F841 local variable 'create_context' is assigned to but never 
used


ll.133 - 139 missing context in search and browse
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm/+merge/213673
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp