Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management

[Nicolas Bessi - Camptocamp]

Review: Needs Information

Hello thanks for the patch.

Is there a good reason not to merge it here: 
https://launchpad.net/geospatial-addons ?
Some tests would also be a nice addition.
-- 
https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt

[Pedro Manuel Baeza]

Hi, Jordi, thanks for the changes. There are still self.pool.get() references 
that you can replace by self.pool[], but this is not a blocking issue. What 
about my last question about the conveniency of the current flow?

Regards.
-- 
https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286
Your team Department Core Editors is subscribed to branch lp:department-mgmt.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_line_watcher into lp:sale-financial

[Pedro Manuel Baeza]

Why don't you check super method existence?:

parent = super(children, self)
if hasattr(parent, 'method') and callable(getattr(parent, 'method')):
parent.method(cr, uid, ...

This seems a little tricky, but it removes the needed of the glue module. What 
do you think?

Regards.
-- 
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_line_watcher/+merge/214058
Your team Sale Core Editors is subscribed to branch lp:sale-financial.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing

[Pedro Manuel Baeza]

Review: Needs Fixing code review

Hi, Alex,

Thank you for the changes you have made, and the explanation about the sale to 
invoice procedure.

One more thing before the approval: please check again multi-line texts. They 
are still bad constructed and split wiht a lot of spaces on translations. If 
you see my example, you can see that I have put " terminating each line. This 
is the thing that prevents to copy spaces in the string. I have put one space 
though to keep separation between words.

Regards.
-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-web/7.0-opw-605931-msh into lp:ocb-web

[Pedro Manuel Baeza]

Review: Approve code review

LGTM.

Regards.
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-opw-605931-msh/+merge/214482
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr into lp:margin-analysis

[Pedro Manuel Baeza]

Review: Approve code review

OK, thanks for the investigation.

Regards.
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354
Your team Margin Analysis Core Editors is subscribed to branch 
lp:margin-analysis.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1303918] [NEW] [6.1/7.0/trunk] Menu translations doesn't work after module installation because they have ID referenced as "base.xxx"

[Pedro Manuel Baeza]

Public bug reported:

As seen on bug #1294887, some menus doesn't appear translated because
their definitions on XML have an ID with reference to the base module,
so that translation export tool include them on base translation file,
not on each module. In this serie of consequences, only loading base
module loads these translations, but on the base loading, translations
are not loaded because the elements don't exist. The only way to handle
this is to install module (for example purchase), and then update base
module again.

An easy solution to this is to rename these IDs to another ones, and
it's very interesting that this lands on trunk before the v8 debuts,
because this change is not easy to be done on an stable branch.

This is the complete list of menus with this problem that I have
detected:

account:
· base.menu_action_currency_form

association:
· base.menu_association
· base.menu_event_config
· base.menu_report_association

base_action_rule:
· base.menu_base_action_rule_admin

base_calendar:
· base.menu_calendar_configuration

crm:
· base.menu_sales
· base.menu_import_crm
· base.menu_sale_config
· base.menu_base_partner
· base.menu_crm_config_lead
· base.menu_crm_config_opportunity
· base.menu_sale_config_sales
· base.next_id_64

crm_claim:
· base.menu_project_report
· base.menu_aftersale

crm_helpdesk:
· base.menu_project_report
· base.menu_base_partner
· base.menu_aftersale

event:
· base.menu_event_main
· base.menu_marketing_config_root
· base.menu_report_association

hr:
· base.menu_crm_case_job_req_main

hr_recruitment:
· base.menu_crm_case_job_req_main

idea:
· base.menu_tools
· base.menu_lunch_survey_root

marketing:
· base.marketing_menu

marketing_campaign:
· base.menu_report_marketing

membership:
· base.menu_association
· base.menu_marketing_config_association
· base.menu_report_association

mrp:
· base.menu_mrp_root
· base.menu_mrp_config

multicompany:
· base.menu_action_inventory_form

plugin_outlook:
· base.menu_base_config_plugins

plugin_thunderbird:
· base.menu_base_config_plugins

product:
· base.menu_sale_config_sales
· base.menu_product


product_margin:
· base.next_id_73

project:
· base.menu_main_pm
· base.menu_definitions
· base.menu_project_config_project
· base.menu_project_report
· base.menu_definitions
· base.menu_project_config

project_long_term:
· "base.menu_project_long_term

purchase:
· base.menu_purchase_root
· base.menu_procurement_management_supplier_name
· base.next_id_73

sale:
· base.menu_base_partner
· base.menu_product
· base.menu_invoiced
· base.next_id_64
· base.menu_base_partner
· base.menu_base_config
· base.menu_sale_config

subscription:
· base.menu_tools
· base.menu_lunch_survey_root

survey:
· base.menu_tools
· base.menu_lunch_reporting
· base.next_id_10

I know that there are some modules that redefine menus because you
wanted in the past reduce the coupling between modules, but these are
the only solutions I see:

1. Set again some dependencies. Not desirable.
2. Create glue modules with the shared menus that are installed as dependencies 
of the others. Not the best, but it works.
3. Put that menus definitions on base, and add an active field on menus that 
allows to hide some menus. On modules that need this menu, you would define the 
menu again with active flag set to True, and translations will be already 
correct.
4. A variation of the last one, as all these cases are shared root menus, is 
that on web client, if there is a root menu that doesn't have any children, you 
can hide it. Less elegant.
5. At last, develop a method, as commented on the other bug report, to handle 
translation with foreign modules IDs. The costliest (on development and 
processing time), but the best to avoid any problem.

Let me know if you want me to help you on the MP.

Regards.

** Affects: ocb-server
 Importance: Undecided
 Status: New

** Summary changed:

- [6.1/7.0/trunk] Menu translations doesn't work after installation module 
installation because they have ID referenced as "base.xxx"
+ [6.1/7.0/trunk] Menu translations doesn't work after module installation 
because they have ID referenced as "base.xxx"

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Server).
https://bugs.launchpad.net/bugs/1303918

Title:
  [6.1/7.0/trunk] Menu translations doesn't work after module
  installation because they have ID referenced as "base.xxx"

Status in OpenERP Community Backports (Server):
  New

Bug description:
  As seen on bug #1294887, some menus doesn't appear translated because
  their definitions on XML have an ID with reference to the base module,
  so that translation export tool include them on base translation file,
  not on each module. In this serie of consequences, only loading base
  module loads these translations, but on the base loading, translations
  are not loaded because the elements don't exist. The only way to
  handle this is to

Re: [Openerp-community-reviewer] [Merge] lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into lp:server-env-tools

[Holger Brunn (Therp)]

Well, there was a time when write() accepted ints or lists, but that's more and 
more history...
-- 
https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214517
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1294887] Re: [6.1/7.0/trunk] Translation exported is not complete

[Pedro Manuel Baeza]

** Changed in: ocb-server
   Status: New => Invalid

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Server).
https://bugs.launchpad.net/bugs/1294887

Title:
  [6.1/7.0/trunk] Translation exported is not complete

Status in OpenERP Community Backports (Server):
  Invalid
Status in OpenERP Server:
  Invalid

Bug description:
  This has been detected from bug lp:933496, where a missing translation
  has triggered an investigation about that.

  In purchase module, you have this menu definition:

 

  Exporting pot file, I get:

  #. module: purchase
  #: model:ir.actions.act_window,name:purchase.action_purchase_line_product_tree
  #: model:ir.actions.act_window,name:purchase.open_board_purchase
  #: model:ir.ui.menu,name:purchase.menu_board_purchase
  #: model:ir.ui.menu,name:purchase.menu_purchase_config
  #: view:res.partner:0
  msgid "Purchases"
  msgstr ""

  But it must be another one comment that is missing:

  #: model:ir.ui.menu,name:base.menu_purchase_root

  Maybe the problem is because XML ID module is 'base' instead
  'purchase', but if I export 'base' module, this comment isn't exported
  also.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-server/+bug/1294887/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-report/purchase_report_carriage_return_vre into lp:purchase-report

[Yannick Vaucher @ Camptocamp]

Review: Approve code review, no test

Fixed previous 'need fixing'.

The change LGTM

As a side note, it seems there is an extra  opening tag at lines 94, 109, 
221 and 236 but this is unreleated to this MP thus I approve it.
-- 
https://code.launchpad.net/~camptocamp/purchase-report/purchase_report_carriage_return_vre/+merge/214030
Your team Purchase Core Editors is subscribed to branch lp:purchase-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows

[Romain Deheele - Camptocamp]

Romain Deheele - Camptocamp has proposed merging 
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde
 into lp:stock-logistic-flows.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568

Hello,

This MP adds an addon named picking_dispatch_wave, the principle :
 - Allows to set a 'sale order wave' to pick according a number n of sales that 
you set.
1.The picker sets a number n of sale orders.
2.The wizard will select moves from n oldest sales that are linked to ready 
pickings.
3.A picking dispatch is created with found moves

Regards,

Romain
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde
 into lp:stock-logistic-flows.
=== added directory 'picking_dispatch_wave'
=== added file 'picking_dispatch_wave/__init__.py'
--- picking_dispatch_wave/__init__.py	1970-01-01 00:00:00 +
+++ picking_dispatch_wave/__init__.py	2014-04-07 16:00:15 +
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alexandre Fayolle, Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+from . import dispatch_wave  # noqa

=== added file 'picking_dispatch_wave/__openerp__.py'
--- picking_dispatch_wave/__openerp__.py	1970-01-01 00:00:00 +
+++ picking_dispatch_wave/__openerp__.py	2014-04-07 16:00:15 +
@@ -0,0 +1,41 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alexandre Fayolle, Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+
+{
+"name": "Picking Dispatch Wave",
+"version": "0.1",
+"depends": ['picking_dispatch'],
+"author": "Camptocamp",
+'license': 'AGPL-3',
+"description": """Allows to set a 'sale order wave' to pick
+according the number of sales that you set.
+1.The picker sets a number n of sale orders.
+2.The wizard will select moves from n oldest sales
+that are linked to ready pickings.
+3.A picking dispatch is created with found moves""",
+"website": "http://www.camptocamp.com";,
+"category": "Warehouse Management",
+"demo": [],
+"data": ['dispatch_wave_view.xml'],
+"test": [],
+"installable": True,
+}

=== added file 'picking_dispatch_wave/dispatch_wave.py'
--- picking_dispatch_wave/dispatch_wave.py	1970-01-01 00:00:00 +
+++ picking_dispatch_wave/dispatch_wave.py	2014-04-07 16:00:15 +
@@ -0,0 +1,91 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alexandre Fayolle, Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that

[Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_price_history-price-in-future-1295114 into lp:margin-analysis

[noreply]

The proposal to merge 
lp:~camptocamp/margin-analysis/7.0-product_price_history-price-in-future-1295114
 into lp:margin-analysis has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-price-in-future-1295114/+merge/211954
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-price-in-future-1295114/+merge/211954
Your team Margin Analysis Core Editors is subscribed to branch 
lp:margin-analysis.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_price_history-price-in-future-1295114 into lp:margin-analysis

[Yannick Vaucher @ Camptocamp]

The proposal to merge 
lp:~camptocamp/margin-analysis/7.0-product_price_history-price-in-future-1295114
 into lp:margin-analysis has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-price-in-future-1295114/+merge/211954
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-price-in-future-1295114/+merge/211954
Your team Margin Analysis Core Editors is subscribed to branch 
lp:margin-analysis.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-product_price_history-price-in-future-1295114 into lp:margin-analysis

[Yannick Vaucher @ Camptocamp]

Review: Approve code review, no test

LGTM
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-product_price_history-price-in-future-1295114/+merge/211954
Your team Margin Analysis Core Editors is subscribed to branch 
lp:margin-analysis.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr into lp:margin-analysis

[Yannick Vaucher @ Camptocamp]

@Pedro I checked and found no way to have the read method gives a False or an 
empty list when giving a valid id to it.
-- 
https://code.launchpad.net/~camptocamp/margin-analysis/7.0-fix-product_historical_margin-no-product-yvr/+merge/211354
Your team Margin Analysis Core Editors is subscribed to branch 
lp:margin-analysis.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management

[Alexis de Lattre]

Alexis de Lattre has proposed merging 
lp:~akretion-team/partner-contact-management/base-location-geonames-import into 
lp:partner-contact-management.

Requested reviews:
  Partner and Contact Core Editors (partner-contact-core-editors)

For more details, see:
https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564

Add module base_location_geonames_import ; this module adds a wizard to import 
better zip entries from Geonames (http://download.geonames.org/export/zip/).

Nicolas Bessi suggested on twitter that it should be part of the geospacial 
addons. But, after thinking about it, my opinion is that this module would be 
better here, because users of the "base_location" module would have a higher 
chance of finding this module here than in the geospacial addons.
-- 
https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564
Your team Partner and Contact Core Editors is requested to review the proposed 
merge of 
lp:~akretion-team/partner-contact-management/base-location-geonames-import into 
lp:partner-contact-management.
=== added directory 'base_location_geonames_import'
=== added file 'base_location_geonames_import/__init__.py'
--- base_location_geonames_import/__init__.py	1970-01-01 00:00:00 +
+++ base_location_geonames_import/__init__.py	2014-04-07 15:18:55 +
@@ -0,0 +1,23 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#Base Location Geonames Import module for OpenERP
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#@author Alexis de Lattre 
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+from . import wizard

=== added file 'base_location_geonames_import/__openerp__.py'
--- base_location_geonames_import/__openerp__.py	1970-01-01 00:00:00 +
+++ base_location_geonames_import/__openerp__.py	2014-04-07 15:18:55 +
@@ -0,0 +1,47 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#Base Location Geonames Import module for OpenERP
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#@author Alexis de Lattre 
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+
+{
+'name': 'Base Location Geonames Import',
+'version': '0.1',
+'category': 'Extra Tools',
+'license': 'AGPL-3',
+'summary': 'Import better zip entries from Geonames',
+'description': """
+Base Location Geonames Import
+=
+
+This module adds a wizard to import better zip entries from Geonames (http://download.geonames.org/export/zip/).
+
+Please contact Alexis de Lattre from Akretion  for any help or question about this module.
+""",
+'author': 'Akretion',
+'website': 'http://www.akretion.com',
+'depends': ['base_location'],
+'external_dependencies': {'python': ['requests', 'unicodecsv']},
+'data': [
+'wizard/geonames_import_view.xml',
+],
+'installable': True,
+'active': False,
+}

=== added directory 'base_location_geonames_import/i18n'
=== added file 'base_location_geonames_import/i18n/base_location_geonames_import.pot'
--- base_location_geonames_import/i18n/base_location_geonames_import.pot	1970-01-01 00:00:00 +
+++ base_location_geonames_import/i18n/base_location_geonames_import.pot	2014-04-07 15:18:55 +
@@ -0,0 +1,68 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following m

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-fix-1302500 into lp:server-env-tools

[Luis Felipe Miléo - http : //www . kmee . com . br]

@rvalyi

That was the "web" bug that I had spoken last week hangout

[]s
-- 
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-fix-1302500/+merge/214250
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-fix-1302500 into lp:server-env-tools

[Raphaël Valyi - http : //www . akretion . com]

Review: Approve

Thanks for spotting this Yannick
-- 
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-fix-1302500/+merge/214250
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-fix-1302500 into lp:server-env-tools

[Holger Brunn (Therp)]

Review: Approve code review

Thanks Yannick!
-- 
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-fix-1302500/+merge/214250
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/lp1303829 into lp:ocb-web

[Holger Brunn (Therp)]

Holger Brunn (Therp) has proposed merging lp:~therp-nl/ocb-web/lp1303829 into 
lp:ocb-web.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1303829 in OpenERP Web: "Show more in a one2many kanban view does 
nothing"
  https://bugs.launchpad.net/openerp-web/+bug/1303829

For more details, see:
https://code.launchpad.net/~therp-nl/ocb-web/lp1303829/+merge/214542
-- 
https://code.launchpad.net/~therp-nl/ocb-web/lp1303829/+merge/214542
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~therp-nl/ocb-web/lp1303829 into lp:ocb-web.
=== modified file 'addons/web_kanban/static/src/js/kanban.js'
--- addons/web_kanban/static/src/js/kanban.js	2014-01-17 10:19:43 +
+++ addons/web_kanban/static/src/js/kanban.js	2014-04-07 14:03:24 +
@@ -637,12 +637,10 @@
 },
 do_show_more: function(evt) {
 var self = this;
-var ids = self.view.dataset.ids.splice(0);
 return this.dataset.read_slice(this.view.fields_keys.concat(['__last_update']), {
 'limit': self.view.limit,
 'offset': self.dataset_offset += self.view.limit
 }).then(function(records) {
-self.view.dataset.ids = ids.concat(self.dataset.ids);
 self.do_add_records(records);
 self.compute_cards_auto_height();
 self.view.postprocess_m2m_tags();

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-fix-1302500 into lp:server-env-tools

[Yannick Vaucher @ Camptocamp]

@Holger Context elements are passed in CompoundContext init with v_context.

>From this function, we need to provide a CompundContext or it will raise an 
>error when trying to use add method on the returned value.

I removed the set_eval_context as it isn't needed. `this.__eval_context` is 
already set to null in init function.
-- 
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-fix-1302500/+merge/214250
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into lp:server-env-tools

[Stefan Rijnhart (Therp)]

Review: Needs Fixing

Hi Yajo, thanks! I approve the fix, but your branch was not clean. It contains 
additional commits. Can you rebase your changes on a fresh branch of 
lp:server-env-tools?

-- 
https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214517
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into lp:server-env-tools

[Yajo]

Yajo has proposed merging lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into 
lp:server-env-tools.

Requested reviews:
  Server Environment And Tools Core Editors (server-env-tools-core-editors)

For more details, see:
https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214517

Fix bug #1302547.
-- 
https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214517
Your team Server Environment And Tools Core Editors is requested to review the 
proposed merge of lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into 
lp:server-env-tools.
=== modified file 'super_calendar/super_calendar.py'
--- super_calendar/super_calendar.py	2013-01-11 16:43:17 +
+++ super_calendar/super_calendar.py	2014-04-07 11:54:06 +
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 ##
-#
+#
 #Copyright (C) 2012 Agile Business Group sagl ()
 #Copyright (C) 2012 Domsense srl ()
 #
@@ -25,7 +25,7 @@
 from mako.template import Template
 from datetime import datetime
 from openerp import tools
-from openerp.tools import safe_eval as eval
+from openerp.tools.safe_eval import safe_eval
 
 def _models_get(self, cr, uid, context=None):
 obj = self.pool.get('ir.model')
@@ -44,20 +44,25 @@
 def generate_calendar_records(self, cr, uid, ids, context=None):
 configurator_ids = self.search(cr, uid, [])
 super_calendar_pool = self.pool.get('super.calendar')
-
+
 # removing old records
 super_calendar_ids = super_calendar_pool.search(cr, uid, [], context=context)
 super_calendar_pool.unlink(cr, uid, super_calendar_ids, context=context)
-
+
 for configurator in self.browse(cr, uid, configurator_ids, context):
 for line in configurator.line_ids:
 current_pool = self.pool.get(line.name.model)
-current_record_ids = current_pool.search(cr, uid, line.domain and eval(line.domain) or [], context=context)
+current_record_ids = current_pool.search(
+cr,
+uid,
+line.domain and safe_eval(line.domain) or [],
+context=context)
+
 for current_record_id in current_record_ids:
 current_record  = current_pool.browse(cr, uid, current_record_id, context=context)
 if line.user_field_id and \
 current_record[line.user_field_id.name] and current_record[line.user_field_id.name]._table_name != 'res.users':
-raise osv.except_osv(_('Error'), 
+raise osv.except_osv(_('Error'),
 _("The 'User' field of record %s (%s) does not refer to res.users")
 % (current_record[line.description_field_id.name], line.name.model))
 if (((line.description_field_id
@@ -116,7 +121,7 @@
 'user_field_id': fields.many2one('ir.model.fields', 'User field',
 domain="['&',('ttype', '=', 'many2one'),('model_id', '=', name)]"),
 }
-
+
 
 class super_calendar(orm.Model):
 _name = 'super.calendar'

=== modified file 'users_ldap_groups/users_ldap_groups.py'
--- users_ldap_groups/users_ldap_groups.py	2013-07-23 11:21:53 +
+++ users_ldap_groups/users_ldap_groups.py	2014-04-07 11:54:06 +
@@ -83,7 +83,7 @@
 conf_all=self.read(cr, uid, conf['id'], ['only_ldap_groups'])
 if(conf_all['only_ldap_groups']):
 logger.debug('deleting all groups from user %d' % user_id)
-userobj.write(cr, uid, user_id, {'groups_id': [(5, )]})
+userobj.write(cr, uid, [user_id], {'groups_id': [(5, )]})
 
 for mapping in mappingobj.read(cr, uid, mappingobj.search(cr, uid, 
 [('ldap_id', '=', conf['id'])]), []):
@@ -93,6 +93,6 @@
 mapping['value'], conf, self, logger):
 logger.debug('adding user %d to group %s' % 
 (user_id, mapping['group'][1]))
-userobj.write(cr, uid, user_id, 
+userobj.write(cr, uid, [user_id], 
 {'groups_id': [(4, mapping['group'][0])]})
 return user_id

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1303724] [NEW] [7.0] Can't reset a refused vacation request if its amount of days exceeds available days

[Holger Brunn (Therp)]

Public bug reported:

To reproduce:

- create 10 days of leave for your employee
- make a vacation request (called A) for your employee for 10 days
- refuse vacation vacation request A
- make another vacation request for your employee for 5 days
- try to reset vacation request A to draft

This fails because the workflow transition to act_confirm is called
automatically and there's not enough vacation left. Note that you also
can't delete this request as unlink only allows that in the draft,
cancel and confirm states.

In trunk, this problem is solved by having the user click a button to
confirm a vacation request.

** Affects: ocb-addons
 Importance: Undecided
 Status: New

** Affects: ocb-addons/7.0
 Importance: Undecided
 Status: New

** Affects: openobject-addons
 Importance: Undecided
 Status: New

** Also affects: ocb-addons
   Importance: Undecided
   Status: New

** Also affects: ocb-addons/7.0
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Addons).
https://bugs.launchpad.net/bugs/1303724

Title:
  [7.0] Can't reset a refused vacation request if its amount of days
  exceeds available days

Status in OpenERP Community Backports (Addons):
  New
Status in OpenERP Community Backports (Addons) 7.0 series:
  New
Status in OpenERP Addons (modules):
  New

Bug description:
  To reproduce:

  - create 10 days of leave for your employee
  - make a vacation request (called A) for your employee for 10 days
  - refuse vacation vacation request A
  - make another vacation request for your employee for 5 days
  - try to reset vacation request A to draft

  This fails because the workflow transition to act_confirm is called
  automatically and there's not enough vacation left. Note that you also
  can't delete this request as unlink only allows that in the draft,
  cancel and confirm states.

  In trunk, this problem is solved by having the user click a button to
  confirm a vacation request.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1303724/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0-lp1303724 into lp:ocb-addons

[Holger Brunn (Therp)]

Holger Brunn (Therp) has proposed merging lp:~therp-nl/ocb-addons/7.0-lp1303724 
into lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1303724 in OpenERP Community Backports (Addons): "[7.0] Can't reset a 
refused vacation request if its amount of days exceeds available days"
  https://bugs.launchpad.net/ocb-addons/+bug/1303724

For more details, see:
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1303724/+merge/214510
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0-lp1303724/+merge/214510
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~therp-nl/ocb-addons/7.0-lp1303724 into lp:ocb-addons.
=== modified file 'hr_holidays/hr_holidays.py'
--- hr_holidays/hr_holidays.py	2014-03-24 09:12:54 +
+++ hr_holidays/hr_holidays.py	2014-04-07 10:48:34 +
@@ -314,6 +314,7 @@
 'state': 'draft',
 'manager_id': False,
 'manager_id2': False,
+'number_of_days_temp': 0,
 })
 wf_service = netsvc.LocalService("workflow")
 for id in ids:

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:carriers-deliveries

[Alex Comba - Agile BG]

Thanks Lorenzo,

now https://github.com/nbessi/openerp-conventions doesn't show anymore the O600 
Warning.

Cheers.
-- 
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing

[Alex Comba - Agile BG]

> when 'sale' e 'sale_stock

Pedro, 'e' stands for 'and', sorry ;-)
-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~yajo/server-env-tools/7.0-fix-eval into lp:server-env-tools

[Stefan Rijnhart (Therp)]

Review: Approve

LGTM
-- 
https://code.launchpad.net/~yajo/server-env-tools/7.0-fix-eval/+merge/213800
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing

[Alex Comba - Agile BG]

Hi, Pedro, thanks a lot for your review.

I made the changes as you suggested, please have a look at them.

About:
> Don't you think that it's convenient to copy incoterm (if any) from sale 
> order to picking?

This module depends on 'stock_invoice_picking' and has been designed on purpose 
when 'sale' e 'sale_stock are not used. Be the case, for what you suggested, we 
could make something additional like 'stock_invoice_picking_incoterm_sale'.


Cheers.


-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~yajo/server-env-tools/7.0-fix-eval into lp:server-env-tools

[Yajo]

Sorry, it's my editor, it's configured to autotrim on save.
-- 
https://code.launchpad.net/~yajo/server-env-tools/7.0-fix-eval/+merge/213800
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-fix-1302500 into lp:server-env-tools

[Holger Brunn (Therp)]

Review: Needs Information

Won't you lose the field's context here if there's one set?
-- 
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-fix-1302500/+merge/214250
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-tests-backport into lp:ocb-addons

[Stefan Rijnhart (Therp)]

> I don't think mere mortals like can set the "rejected" state

Done


-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-tests-backport/+merge/214234
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis into lp:knowledge-addons/7.0

[Holger Brunn (Therp)]

Review: Approve code review


-- 
https://code.launchpad.net/~savoirfairelinux-openerp/knowledge-addons/cmis/+merge/212258
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:knowledge-addons/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-tests-backport into lp:ocb-addons

[Stefan Rijnhart (Therp)]

The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-stock-tests-backport 
into lp:ocb-addons has been updated.

Status: Merged => Rejected

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-tests-backport/+merge/214234
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-tests-backport/+merge/214234
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~therp-nl/lp-community-utils/target_copy_from_shared_repository into lp:lp-community-utils

[noreply]

The proposal to merge 
lp:~therp-nl/lp-community-utils/target_copy_from_shared_repository into 
lp:lp-community-utils has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~therp-nl/lp-community-utils/target_copy_from_shared_repository/+merge/201446
-- 
https://code.launchpad.net/~therp-nl/lp-community-utils/target_copy_from_shared_repository/+merge/201446
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:lp-community-utils.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~yajo/server-env-tools/7.0-fix-eval into lp:server-env-tools

[Holger Brunn (Therp)]

Review: Approve code review

There are some unnecessary white space changes, but good ones imho
-- 
https://code.launchpad.net/~yajo/server-env-tools/7.0-fix-eval/+merge/213800
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey into lp:server-env-tools

[noreply]

The proposal to merge lp:~sylvain-legal/server-env-tools/7.0-auth_admin_passkey 
into lp:server-env-tools has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338
-- 
https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-auth_admin_passkey/+merge/211338
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde into lp:ocb-addons

[Leonardo Pistone - camptocamp]

Review: Approve code review

same as 
https://code.launchpad.net/~camptocamp/openobject-addons/7.0_fix-document-search-order-by_rde/+merge/214483
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of 
lp:~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde into 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr into lp:web-addons

[Holger Brunn (Therp)]

Review: Approve code review


-- 
https://code.launchpad.net/~camptocamp/web-addons/7.0-web_translate_dialog-sync-current-view-1301218-gbr/+merge/213783
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into lp:ocb-addons

[Lionel Sausin - Numérigraphe]

Well sorry for the noise, but there was a moment of uncertainty after 
you approved, when the migration team announced they would truncate the 
data during migration to v8.
But they won't after all, so this change is really no big deal.

-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/211488
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~onnis-roberto/web-addons/6.1 into lp:web-addons/6.1

[Holger Brunn (Therp)]

Given that Guewen's concern was resolved a while ago, I set this to approved.
-- 
https://code.launchpad.net/~onnis-roberto/web-addons/6.1/+merge/207662
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~onnis-roberto/web-addons/6.1 into lp:web-addons/6.1

[Holger Brunn (Therp)]

The proposal to merge lp:~onnis-roberto/web-addons/6.1 into lp:web-addons/6.1 
has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~onnis-roberto/web-addons/6.1/+merge/207662
-- 
https://code.launchpad.net/~onnis-roberto/web-addons/6.1/+merge/207662
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into lp:ocb-addons

[Leonardo Pistone - camptocamp]

Review: Approve

Thanks Holger.

It's actually more then 5: the "pending votes" are from people like me that 
approved the old version of the proposal (i'm approving again here). The new 
proposal looks identical, what happened?
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/211488
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls into lp:ocb-addons

[Holger Brunn (Therp)]

The proposal to merge 
lp:~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls into 
lp:ocb-addons has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls/+merge/214435
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls/+merge/214435
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls into lp:ocb-addons

[Holger Brunn (Therp)]

Review: Approve code review


-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls/+merge/214435
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness into lp:ocb-addons

[Holger Brunn (Therp)]

Review: Approve code review


-- 
https://code.launchpad.net/~wiz-keed/ocb-addons/7.0-delivery-carrier-multi-company-awareness/+merge/214176
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/6.1-fix-1182111-lep into lp:ocb-addons/6.1

[Holger Brunn (Therp)]

Review: Approve code review


-- 
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix-1182111-lep/+merge/213979
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/6.1-fix-1182111-lep into lp:ocb-addons/6.1

[Holger Brunn (Therp)]

The proposal to merge lp:~camptocamp/ocb-addons/6.1-fix-1182111-lep into 
lp:ocb-addons/6.1 has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix-1182111-lep/+merge/213979
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/6.1-fix-1182111-lep/+merge/213979
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~jeffery9/ocb-addons/ocb-addons-fixups into lp:ocb-addons

[Holger Brunn (Therp)]

The proposal to merge lp:~jeffery9/ocb-addons/ocb-addons-fixups into 
lp:ocb-addons has been updated.

Status: Needs review => Rejected

For more details, see:
https://code.launchpad.net/~jeffery9/ocb-addons/ocb-addons-fixups/+merge/194463
-- 
https://code.launchpad.net/~jeffery9/ocb-addons/ocb-addons-fixups/+merge/194463
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~jeffery9/ocb-addons/ocb-addons-fixups into lp:ocb-addons

[Holger Brunn (Therp)]

Two disapprovals and no replies by the author in months, so I set this one to 
'disapproved'.
-- 
https://code.launchpad.net/~jeffery9/ocb-addons/ocb-addons-fixups/+merge/194463
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into lp:ocb-addons

[Holger Brunn (Therp)]

The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into 
lp:ocb-addons has been updated.

Status: Needs review => Approved

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/211488
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/211488
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo into lp:ocb-addons

[Holger Brunn (Therp)]

We have a lot of approvals but still also a lot of pending review requests. 
Given that 5 approvals already is unusually many, I'll approve this one.
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-bug-1079548-sgo/+merge/211488
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock_use_date_always into lp:ocb-addons/6.1

[Holger Brunn (Therp)]

The proposal to merge lp:~hirt/ocb-addons/6.1_stock_use_date_always into 
lp:ocb-addons/6.1 has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~hirt/ocb-addons/6.1_stock_use_date_always/+merge/194646
-- 
https://code.launchpad.net/~hirt/ocb-addons/6.1_stock_use_date_always/+merge/194646
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink into lp:ocb-addons

[noreply]

The proposal to merge lp:~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink 
into lp:ocb-addons has been updated.

Status: Approved => Merged

For more details, see:
https://code.launchpad.net/~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink/+merge/213086
-- 
https://code.launchpad.net/~wiz-keed/ocb-addons/ocb-7.0-fix-mrp-subproduct-unkink/+merge/213086
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde into lp:ocb-addons

[Alexandre Fayolle - camptocamp]

Alexandre Fayolle - camptocamp has proposed merging 
lp:~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde into 
lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1302630 in OpenERP Community Backports (Addons): "[trunk/7.0] document : 
search method overload breaks "order by" clause on ir.attachment object"
  https://bugs.launchpad.net/ocb-addons/+bug/1302630

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486

[FIX] document: preserve order in search()

port of 
https://code.launchpad.net/~camptocamp/openobject-addons/7.0_fix-document-search-order-by_rde/+merge/214483
 to OCB
-- 
https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of 
lp:~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde into 
lp:ocb-addons.
=== modified file 'document/document.py'
--- document/document.py	2014-03-10 08:54:20 +
+++ document/document.py	2014-04-07 08:38:14 +
@@ -89,6 +89,11 @@
 if not ids:
 return 0 if count else []
 
+# Work with a set, as list.remove() is prohibitive for large lists of documents
+# (takes 20+ seconds on a db with 100k docs during search_count()!)
+orig_ids = ids
+ids = set(ids)
+
 # Filter out documents that are in directories that the user is not allowed to read.
 # Must use pure SQL to avoid access rules exceptions (we want to remove the records,
 # not fail), and the records have been filtered in parent's search() anyway.
@@ -108,7 +113,8 @@
 for parent_id in visible_parent_ids:
 ids.extend(parents[parent_id])
 
-return len(ids) if count else ids
+result = [id for id in orig_ids if id in ids]
+return len(result) if count else result
 
 def copy(self, cr, uid, id, default=None, context=None):
 if not default:

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-web/7.0-opw-605931-msh into lp:ocb-web

[Holger Brunn (Therp)]

Review: Approve code review


-- 
https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-opw-605931-msh/+merge/214482
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-web/7.0-hide-oe_read_only into lp:ocb-web

[Holger Brunn (Therp)]

Review: Disapprove

I also think a module doing that would be better. For example, I made a 
backport for the group_ids feature for views in 6.1: 
http://bazaar.launchpad.net/~server-env-tools-core-editors/server-env-tools/6.1/view/head:/view_groups_id/__openerp__.py
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-hide-oe_read_only/+merge/213016
Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-web/7.0-opw-605931-msh into lp:ocb-web

[Lionel Sausin - Numérigraphe]

Lionel Sausin - Numérigraphe has proposed merging 
lp:~numerigraphe-team/ocb-web/7.0-opw-605931-msh into lp:ocb-web.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1265705 in OpenERP Community Backports (Web): "Duplicate Records, when 
edit a record in OpenERP 7 one2many list editable"
  https://bugs.launchpad.net/ocb-web/+bug/1265705

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-opw-605931-msh/+merge/214482

No-change merge of lp:~openerp-dev/openerp-web/7.0-opw-605931-msh, only adding 
the missing --fixes in the merge commit.
Fixes a bug which creates duplicate lines under cryptic circumstances.

Runs green on runbot: 
http://runbot.openerp.com/numerigraphe-team-7-0-opw-605931-msh-32859/logs/
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-opw-605931-msh/+merge/214482
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~numerigraphe-team/ocb-web/7.0-opw-605931-msh into lp:ocb-web.
=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2014-03-26 12:35:13 +
+++ addons/web/static/src/js/view_form.js	2014-04-07 08:16:45 +
@@ -620,6 +620,9 @@
 });
 }
 return $.when();
+}).fail(function() {
+self.save_list.pop();
+return $.when();
 });
 };
 return iterate();

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls into lp:ocb-addons

[Pedro Manuel Baeza]

Review: Approve code review

Thanks for the work you are doing, Lionel.

Regards.
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-revert-sale-properties-1291903-ls/+merge/214435
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-report/purchase_report_carriage_return_vre into lp:purchase-report

[Guewen Baconnier @ Camptocamp]

Review: Needs Fixing

The name is mandatory, so you can simplify this:
${line.name and line.name.replace('\n','') or '' | n}
by that:
${line.name.replace('\n','') | n}
-- 
https://code.launchpad.net/~camptocamp/purchase-report/purchase_report_carriage_return_vre/+merge/214030
Your team Purchase Core Editors is subscribed to branch lp:purchase-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1265705] Re: Duplicate Records, when edit a record in OpenERP 7 one2many list editable

[Lionel Sausin - Numérigraphe]

** Branch linked: lp:~openerp-dev/openerp-web/7.0-opw-605931-msh

** Also affects: ocb-web
   Importance: Undecided
   Status: New

** Changed in: ocb-web
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Web).
https://bugs.launchpad.net/bugs/1265705

Title:
  Duplicate Records, when edit a record in OpenERP 7 one2many list
  editable

Status in OpenERP Community Backports (Web):
  New
Status in OpenERP Web:
  Confirmed

Bug description:
  Duplicate Records, when edit a record in OpenERP 7 one2many list editable.
  Please check link below for the detail
  
https://docs.google.com/document/d/1wbejCHQcH8qx5fhn3FsP1iN0Hs8MvGR8Syrx6icPqkM/pub
  Thank you very much,

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-web/+bug/1265705/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:carriers-deliveries

[Lorenzo Battistini - Agile BG]

Review: Approve

Thanks to openerp-conventions
https://github.com/nbessi/openerp-conventions
I see
delivery_optional_invoice_line/__openerp__.py:43:5: O600 Warning unknown 
Manifest key ('active')

Apart from this, LGTM
-- 
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-stock-tests-backport into lp:ocb-addons

[Lionel Sausin - Numérigraphe]

Thanks for the advice Pedro.
I don't think mere mortals like can set the "rejected" state, so "merged" was 
the best way to un-clutter the MP list permanently.
Moreover this MP itself is not merged but the branch is, via the official 
addons.
So maybe I should simply delete the MP in such a case?
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-stock-tests-backport/+merge/214234
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp