Re: [Openerp-community-reviewer] [Merge] lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addons

[Augustin Cisterne-Kaas - www.elico-corp.com]

Dear all,

I have made the requested modifications.

Kind Regards,

Augustin Cisterne-Kaas
-- 
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1306136] [NEW] [7.0] web_calendar: Error while removing a task from calendar view on week or day layout

[Pedro Manuel Baeza]

Public bug reported:

If you try to remove an element from the calendar view on day or week
layout (the trash icon that appears when you click on an element), it
appears some errors. For example, this one comes from deleting a task in
this view:

NotImplementedError: Iteration is not allowed on
browse_record(project.task, x)

This is because the parameter ids passed to unlink method is a single
id, not a list of ids. This becomes from web_calendar addon itself, and
it's general for any calendar view (sale orders, manufacturing orders,
etc).

It's easily repaired changing 'delete_event' to pass a list of one ID
instead the ID itself.

Please see attached branch.

** Affects: ocb-web
 Importance: Undecided
 Status: New

** Affects: ocb-web/7.0
 Importance: Undecided
 Status: New

** Affects: openerp-web
 Importance: Undecided
 Status: New

** Also affects: ocb-web
   Importance: Undecided
   Status: New

** Also affects: ocb-web/7.0
   Importance: Undecided
   Status: New

** Branch linked: lp:~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136

** Branch linked: lp:~pedro.baeza/openerp-web/7.0-web_calendar-
fix-1306136

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Web).
https://bugs.launchpad.net/bugs/1306136

Title:
  [7.0] web_calendar: Error while removing a task from calendar view on
  week or day layout

Status in OpenERP Community Backports (Web):
  New
Status in OpenERP Community Backports (Web) 7.0 series:
  New
Status in OpenERP Web:
  New

Bug description:
  If you try to remove an element from the calendar view on day or week
  layout (the trash icon that appears when you click on an element), it
  appears some errors. For example, this one comes from deleting a task
  in this view:

  NotImplementedError: Iteration is not allowed on
  browse_record(project.task, x)

  This is because the parameter ids passed to unlink method is a single
  id, not a list of ids. This becomes from web_calendar addon itself,
  and it's general for any calendar view (sale orders, manufacturing
  orders, etc).

  It's easily repaired changing 'delete_event' to pass a list of one ID
  instead the ID itself.

  Please see attached branch.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-web/+bug/1306136/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136 into lp:ocb-web

[Pedro Manuel Baeza]

Pedro Manuel Baeza has proposed merging 
lp:~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136 into lp:ocb-web.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1306136 in OpenERP Community Backports (Web): "[7.0] web_calendar: Error 
while removing a task from calendar view on week or day layout"
  https://bugs.launchpad.net/ocb-web/+bug/1306136

For more details, see:
https://code.launchpad.net/~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136/+merge/215256

[FIX] web_calendar: Error when deleting an element from calendar view.

It solves lp:1306136. See bug report for details.
-- 
https://code.launchpad.net/~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136/+merge/215256
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~pedro.baeza/ocb-web/7.0-web_calendar-fix-1306136 into lp:ocb-web.
=== modified file 'addons/web_calendar/static/src/js/calendar.js'
--- addons/web_calendar/static/src/js/calendar.js	2014-02-14 11:42:58 +
+++ addons/web_calendar/static/src/js/calendar.js	2014-04-10 17:03:19 +
@@ -533,7 +533,7 @@
 var self = this;
 var index = this.dataset.get_id_index(event_id);
 if (index !== null) {
-this.dataset.unlink(this.dataset.ids[index]);
+this.dataset.unlink([this.dataset.ids[index]]);
 }
 },
 });

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 915568] Re: Wrong dates used when confirming stock inventory

[Ferdinand]

may be this is helpful
http://bazaar.launchpad.net/~camptocamp/c2c-rd-addons/7.0/files/head:/stock_product_zero/

-- 
You received this bug notification because you are a member of Stock and
Logistic Core Editors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/915568

Title:
  Wrong dates used when confirming stock inventory

Status in OpenERP Community Backports (Addons):
  Fix Committed
Status in New OpenERP WMS:
  Fix Released
Status in OpenERP Addons (modules):
  Fix Committed

Bug description:
  [ Problem ]
  action_confirm method is not taking in account "date" from stock.inventory 
object, and update qtys in the moment of confirmation.
  The inventory date is taken into account when querying the stock to compute 
the inventory difference but the stock moves are created at the wrong date, 
making the stock and virtual stock wrong at the date of the inventory.

  Users expect that the inventory date should say _when_ the inventory
  was taken - in this way the amount to correct should effective before
  this date.

  Attached videos gives better explanation, and document with kardex
  expected.

  [ Impact ] the available quantity and virtual stock are wrong near the
  date of the inventory.

  [ Possible fixes ]
  - The preferred fix would be to write the stock moves at the date of the 
inventory.
  - A less-than-ideal fix would be to not take the inventory date is taken into 
account when querying the stock to compute the inventory difference. For the 
moment is the way v8 is being developed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/915568/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-move-date into lp:ocb-addons

[Lionel Sausin - Numérigraphe]

Looks like Quentin changed his mind: 
https://bugs.launchpad.net/openobject-addons/+bug/915568/comments/44
Depending on the final call, this proposal could be unsustainable when v8 
comes. I can always make this a module in that case.
Wait and see.
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-move-date/+merge/213301
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-financial/7.0-port-sale_markup into lp:sale-financial

[Yannick Vaucher @ Camptocamp]

The proposal to merge lp:~camptocamp/sale-financial/7.0-port-sale_markup into 
lp:sale-financial has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_markup/+merge/214061
-- 
https://code.launchpad.net/~camptocamp/sale-financial/7.0-port-sale_markup/+merge/214061
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~camptocamp/sale-financial/7.0-port-sale_markup into lp:sale-financial.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/stock-logistic-flows/70-product_serial-plus-plus into lp:stock-logistic-flows

[Alexis de Lattre]

@Alexandre:

Could you update your review status "Needs fixing" following my commits 45 to 
48 ?
-- 
https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-product_serial-plus-plus/+merge/195144
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-flows.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 915568] Re: Please keep blocking moves during inventory counting

[Lionel Sausin - Numérigraphe]

Le 09/04/2014 15:39, De Paoli Quentin a écrit :
> (...)i don't know if you noticed but we decided to use the inventory 
> post date for the move dates because that's reflect more the reality. 
> There will be a way to force the accounting period for the valuation 
> entries.
>
So, that means you've re-introduced Bug #915568 "Wrong dates used when 
confirming stock inventory"?

This bug is not only about accounting entries, it's about WMS too:
- posting the stock moves later is sure to put someone in fiscal trouble 
because the accounting and stock levels do not match at the end of the 
fiscal year - some tax controllers are very picky about this
- it's so much more convenient for WMS managers to have the adjusted 
quantities at the date of the inventory - this date at least they remember.

Of course... if that's your final call, so be it! Just update mark 
"won't fix" andI'll move on to making a community addon that suits the 
affected user's needs.
In that case it'll be great help if you arrange the code in trunk-wms to 
allow this easily (like delegating the date evaluation to a method we 
can surcharge, or maybe making it context-sensitive).

-- 
You received this bug notification because you are a member of Stock and
Logistic Core Editors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/915568

Title:
  Wrong dates used when confirming stock inventory

Status in OpenERP Community Backports (Addons):
  Fix Committed
Status in New OpenERP WMS:
  Fix Released
Status in OpenERP Addons (modules):
  Fix Committed

Bug description:
  [ Problem ]
  action_confirm method is not taking in account "date" from stock.inventory 
object, and update qtys in the moment of confirmation.
  The inventory date is taken into account when querying the stock to compute 
the inventory difference but the stock moves are created at the wrong date, 
making the stock and virtual stock wrong at the date of the inventory.

  Users expect that the inventory date should say _when_ the inventory
  was taken - in this way the amount to correct should effective before
  this date.

  Attached videos gives better explanation, and document with kardex
  expected.

  [ Impact ] the available quantity and virtual stock are wrong near the
  date of the inventory.

  [ Possible fixes ]
  - The preferred fix would be to write the stock moves at the date of the 
inventory.
  - A less-than-ideal fix would be to not take the inventory date is taken into 
account when querying the stock to compute the inventory difference. For the 
moment is the way v8 is being developed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/915568/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1305872-afe into lp:ocb-server

[Yannick Vaucher @ Camptocamp]

Review: Disapprove

Disapproved as a fix has been push by odony in official branch
-- 
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305872-afe/+merge/215176
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-move-date into lp:ocb-addons

[Lionel Sausin - Numérigraphe]

The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-inventory-move-date 
into lp:ocb-addons has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-move-date/+merge/213301
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-move-date/+merge/213301
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

[Nicola Malcontenti - Agile BG]

> LGTM.
> 
> Is there any chance I could convince you to write an automated test for this?
Hi Alexandre,
Sorry For the late, i have write the automated test for checking the bug.

Regards.
-N.
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1305872] Re: [7.0] rev 5276 prevents from using pywebdav 0.9.4.1

[Olivier Dony (OpenERP)]

The 0.9.4.1 patch is not really a concern for OpenERP but there is indeed no 
reason to forbid using it.
Fixed at revision [1], thanks for reporting!

[1] revno 5280 revision-id:
o...@openerp.com-20140410140244-wu2l4hb5o1ct7tmm

** Changed in: openobject-server
   Importance: Undecided => Wishlist

** Changed in: openobject-server
   Status: Fix Committed => Fix Released

** Changed in: openobject-server
Milestone: None => 7.0

** Changed in: openobject-server
 Assignee: (unassigned) => OpenERP's Framework R&D (openerp-dev-framework)

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Server).
https://bugs.launchpad.net/bugs/1305872

Title:
  [7.0] rev 5276 prevents from using pywebdav 0.9.4.1

Status in OpenERP Community Backports (Server):
  Fix Committed
Status in OpenERP Community Backports (Server) 7.0 series:
  Fix Committed
Status in OpenERP Server:
  Fix Released

Bug description:
  http://bazaar.launchpad.net/~openerp/openobject-
  server/7.0/revision/5276  is too restrictive, as pywebdav 0.9.4.1 is a
  valid version (which fixes some issues cf. the note at the top of
  http://code.google.com/p/pywebdav/)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-server/+bug/1305872/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

[Yannick Vaucher @ Camptocamp]

Review: Approve


-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde into lp:carriers-deliveries

[noreply]

The proposal to merge 
lp:~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde 
into lp:carriers-deliveries has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-change-class-name-to-avoid-error_rde/+merge/213881
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into lp:carriers-deliveries

[Yannick Vaucher @ Camptocamp]

The proposal to merge 
lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into 
lp:carriers-deliveries has been updated.

Commit Message changed to:

delivery_carrier_label_dispatch - Improve efficiency of label generation by 
threading it. For instance for postlogistics, using serialized calls to the 
SOAP web service is a really slow as it would wait for a response before 
sending the next request.

Also improve exception feed back. And thus exception are non blocking for all 
label generation. You will only have to relaunch generation for failed ones.

For more details, see:
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation/+merge/215184
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation/+merge/215184
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into lp:carriers-deliveries

[Yannick Vaucher @ Camptocamp]

Yannick Vaucher @ Camptocamp has proposed merging 
lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into 
lp:carriers-deliveries with 
lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_dispatch-output-file-yvr
 as a prerequisite.

Commit message:
delivery_carrier_label_dispatch - Improve efficiency of label generation by 
threading it. For instance for postlogistics, using serialized calls to the 
SOAP web service is a really slow as it would wait for a response before 
sending the next request.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation/+merge/215184
-- 
https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation/+merge/215184
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into 
lp:carriers-deliveries.
=== modified file 'delivery_carrier_label_dispatch/__openerp__.py'
--- delivery_carrier_label_dispatch/__openerp__.py	2014-04-10 13:58:38 +
+++ delivery_carrier_label_dispatch/__openerp__.py	2014-04-10 13:58:38 +
@@ -37,6 +37,20 @@
 
 If you don't define your pack it will be considered a picking is a single pack.
 
+
+Tips
+
+For picking dispatch with huge number of labels to generate your can add a
+number of worker with ir.config_parameter `shipping_label.num_workers` to
+parallelize the generation on multiple workers.
+This can be really useful for exemple using PostLogistics web service to
+gain speed.
+
+Be careful not to set too many worker as each one will need to instanciate
+a cursor on database and this could generate PoolErrors.
+A good choice would be to set it as `db_maxconn` / number_of_worker / 2
+>>> MERGE-SOURCE
+
 Contributors
 
 

=== modified file 'delivery_carrier_label_dispatch/wizard/generate_labels.py'
--- delivery_carrier_label_dispatch/wizard/generate_labels.py	2014-04-10 13:58:38 +
+++ delivery_carrier_label_dispatch/wizard/generate_labels.py	2014-04-10 13:58:38 +
@@ -20,13 +20,21 @@
 ##
 from operator import attrgetter
 from itertools import groupby
+import sys
+import Queue
+import threading
+import logging
 
+from openerp import pooler
 from openerp.osv import orm, fields
 from openerp.tools.translate import _
 
 from ..pdf_utils import assemble_pdf
 
 
+_logger = logging.getLogger(__name__)
+
+
 class DeliveryCarrierLabelGenerate(orm.TransientModel):
 
 _name = 'delivery.carrier.label.generate'
@@ -85,37 +93,139 @@
 return None
 return label_obj.browse(cr, uid, label_id[0], context=context)
 
+def _do_generate_labels(self, cr, uid, wizard, pack, picking,
+  label, context=None):
+""" Generate a label in a thread safe context
+
+Here we declare a specific cursor so do not launch
+too many threads
+"""
+picking_out_obj = self.pool['stock.picking.out']
+# generate the label of the pack
+tracking_ids = [pack.id] if pack else None
+# create a cursor to be thread safe
+thread_cr = pooler.get_db(cr.dbname).cursor()
+try:
+try:
+picking_out_obj.generate_labels(
+thread_cr, uid, [picking.id],
+tracking_ids=tracking_ids,
+context=context)
+except orm.except_orm as e:
+# add information on picking and pack in the exception
+picking_name = _('Picking: %s') % picking.name
+pack_num = _('Pack: %s') % pack.name if pack else ''
+raise orm.except_orm(
+e.name,
+_('%s %s - %s') % (picking_name, pack_num, e.value))
+thread_cr.commit()
+except Exception:
+thread_cr.rollback()
+raise
+finally:
+thread_cr.close()
+
+def worker(self, q, q_except):
+""" A worker to generate labels
+
+Takes data from queue q
+
+And if the worker encounters errors, he will add them in
+q_except queue
+"""
+while not q.empty():
+args, kwargs = q.get()
+try:
+self._do_generate_labels(*args, **kwargs)
+except Exception as e:
+q_except.put(e)
+finally:
+q.task_done()
+
+def _get_num_workers(self, cr, uid, context=None):
+""" Get number of worker parameter for labels generation
+
+Optional ir.config_parameter is `shipping_label.num_workers`
+"""
+param_obj = self.pool['ir.config_parameter']
+num_workers = param_obj.get_param(cr, uid,
+  's

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1305872-afe into lp:ocb-server

[Vincent Renaville@camptocamp]

Review: Approve

Thanks for the fix
-- 
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305872-afe/+merge/215176
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~camptocamp/ocb-server/7.0-fix_1305872-afe into lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 588154] Re: Inventory: movement input with date prior to physical inventory are reflected in stocks

[qdp (OpenERP)]

this doesn't affect trunk-wms anymore

** Changed in: openerp-trunk-wms
   Status: New => Invalid

-- 
You received this bug notification because you are a member of Stock and
Logistic Core Editors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/588154

Title:
  Inventory: movement input with date prior to physical inventory are
  reflected in stocks

Status in New OpenERP WMS:
  Invalid
Status in OpenERP Addons (modules):
  In Progress
Status in OpenERP Addons 5.0 series:
  Confirmed
Status in OpenERP Addons trunk series:
  Won't Fix

Bug description:
  I setup a physical inventory with date 2010/05/19. Stock is 5 for product x
  When I have an internal move  for 1 piece of product x with date 2010/05/01, 
the current calculated stock at 2010/06/01 is 4 which seems to me incorrect as 
the current stock should reflect the physical inventory on 2010/05/19 and be 5.

To manage notifications about this bug go to:
https://bugs.launchpad.net/openerp-trunk-wms/+bug/588154/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1305872-afe into lp:ocb-server

[Alexandre Fayolle - camptocamp]

Alexandre Fayolle - camptocamp has proposed merging 
lp:~camptocamp/ocb-server/7.0-fix_1305872-afe into lp:ocb-server.

Requested reviews:
  Leonardo Pistone - camptocamp (lpistone)
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1305872 in OpenERP Community Backports (Server): "[7.0] rev 5276 
prevents from using pywebdav 0.9.4.1"
  https://bugs.launchpad.net/ocb-server/+bug/1305872

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305872-afe/+merge/215176

allow using pywebdav 0.9.4.1

port of 
https://code.launchpad.net/~camptocamp/openobject-server/7.0-fix_1305872-afe/+merge/215175
 to OCB
-- 
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305872-afe/+merge/215176
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~camptocamp/ocb-server/7.0-fix_1305872-afe into lp:ocb-server.
=== modified file 'setup.py'
--- setup.py	2014-04-09 08:13:49 +
+++ setup.py	2014-04-10 13:21:59 +
@@ -131,7 +131,7 @@
   'python-ldap', # optional
   'python-openid',
   'pytz',
-  'pywebdav <= 0.9.4',
+  'pywebdav <= 0.9.4.1',
   'pyyaml',
   'reportlab', # windows binary pypi.python.org/pypi/reportlab
   'simplejson',

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-server/7.0-fix-po-targets-933496-vmt into lp:ocb-server

[Lionel Sausin - Numérigraphe]

This branch currently runs red on runbot, and the original branch by VMT runs 
orange - missing access rules on demo data. I'll check what the problem is as 
soon as I can.

-- 
https://code.launchpad.net/~numerigraphe-team/ocb-server/7.0-fix-po-targets-933496-vmt/+merge/209895
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1305872-afe into lp:ocb-server

[Leonardo Pistone - camptocamp]

Review: Approve

thanks
-- 
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305872-afe/+merge/215176
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~camptocamp/ocb-server/7.0-fix_1305872-afe into lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1305872] Re: [7.0] rev 5276 prevents from using pywebdav 0.9.4.1

[Alexandre Fayolle - camptocamp]

** Also affects: ocb-server
   Importance: Undecided
   Status: New

** Also affects: ocb-server/7.0
   Importance: Undecided
   Status: New

** Changed in: openobject-server
   Status: New => Fix Committed

** Changed in: ocb-server/7.0
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Server).
https://bugs.launchpad.net/bugs/1305872

Title:
  [7.0] rev 5276 prevents from using pywebdav 0.9.4.1

Status in OpenERP Community Backports (Server):
  Fix Committed
Status in OpenERP Community Backports (Server) 7.0 series:
  Fix Committed
Status in OpenERP Server:
  Fix Committed

Bug description:
  http://bazaar.launchpad.net/~openerp/openobject-
  server/7.0/revision/5276  is too restrictive, as pywebdav 0.9.4.1 is a
  valid version (which fixes some issues cf. the note at the top of
  http://code.google.com/p/pywebdav/)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-server/+bug/1305872/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-web/ocb-6.1-bug-1163912-calendar-view into lp:ocb-web/6.1

[Cedric Le Brouster(OpenFire)]

Cedric Le Brouster(OpenFire) has proposed merging 
lp:~cedric-lebrouster/ocb-web/ocb-6.1-bug-1163912-calendar-view into 
lp:ocb-web/6.1.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1163912 in OpenERP Web: "[Trunk/7.0] Calendar month view does not show 
events starting in previous month"
  https://bugs.launchpad.net/openerp-web/+bug/1163912

For more details, see:
https://code.launchpad.net/~cedric-lebrouster/ocb-web/ocb-6.1-bug-1163912-calendar-view/+merge/215171

Fixes the bug 1163912 (Calendar views did not show events starting in previous 
month).
-- 
https://code.launchpad.net/~cedric-lebrouster/ocb-web/ocb-6.1-bug-1163912-calendar-view/+merge/215171
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~cedric-lebrouster/ocb-web/ocb-6.1-bug-1163912-calendar-view into 
lp:ocb-web/6.1.
=== modified file 'addons/web_calendar/static/src/js/calendar.js'
--- addons/web_calendar/static/src/js/calendar.js	2013-03-01 09:35:20 +
+++ addons/web_calendar/static/src/js/calendar.js	2014-04-10 13:09:33 +
@@ -438,8 +438,10 @@
 get_range_domain: function() {
 var format = openerp.web.date_to_str,
 domain = this.last_search[0].slice(0);
-domain.unshift([this.date_start, '>=', format(this.range_start.clone().addDays(-6))]);
 domain.unshift([this.date_start, '<=', format(this.range_stop.clone().addDays(6))]);
+if (this.date_stop) {
+domain.unshift([this.date_stop, '>=', format(this.range_start.clone().addDays(-6))]);
+}
 return domain;
 },
 do_show: function () {

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows

[Romain Deheele - Camptocamp]

Romain Deheele - Camptocamp has proposed merging 
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde
 into lp:stock-logistic-flows.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568

Hello,

This MP adds an addon named picking_dispatch_wave, the principle :
 - Allows to set a 'sale order wave' to pick according a number n of sales that 
you set.
1.The picker sets a number n of sale orders.
2.The wizard will select moves from n oldest sales that are linked to ready 
pickings.
3.A picking dispatch is created with found moves

Regards,

Romain
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde
 into lp:stock-logistic-flows.
=== added directory 'picking_dispatch_wave'
=== added file 'picking_dispatch_wave/__init__.py'
--- picking_dispatch_wave/__init__.py	1970-01-01 00:00:00 +
+++ picking_dispatch_wave/__init__.py	2014-04-10 12:50:01 +
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alexandre Fayolle, Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+from . import dispatch_wave  # noqa

=== added file 'picking_dispatch_wave/__openerp__.py'
--- picking_dispatch_wave/__openerp__.py	1970-01-01 00:00:00 +
+++ picking_dispatch_wave/__openerp__.py	2014-04-10 12:50:01 +
@@ -0,0 +1,41 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alexandre Fayolle, Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+
+{
+"name": "Picking Dispatch Wave",
+"version": "0.1",
+"depends": ['picking_dispatch'],
+"author": "Camptocamp",
+'license': 'AGPL-3',
+"description": """Allows to set a 'sale order wave' to pick
+according the number of sales that you set.
+1.The picker sets a number n of sale orders.
+2.The wizard will select moves from n oldest sales
+that are linked to ready pickings.
+3.A picking dispatch is created with found moves""",
+"website": "http://www.camptocamp.com";,
+"category": "Warehouse Management",
+"demo": [],
+"data": ['dispatch_wave_view.xml'],
+"test": [],
+"installable": True,
+}

=== added file 'picking_dispatch_wave/dispatch_wave.py'
--- picking_dispatch_wave/dispatch_wave.py	1970-01-01 00:00:00 +
+++ picking_dispatch_wave/dispatch_wave.py	2014-04-10 12:50:01 +
@@ -0,0 +1,105 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alexandre Fayolle, Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope tha

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools

[Nicolas Bessi - Camptocamp]

Review: Approve

Ahh tests, I'm feeling better now.

Thanks for the fixes LGTM :-D


-- 
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools

[Alexandre Fayolle - camptocamp]

> Hello,
> 
> Thanks for the module, it is really a valuable tool.
> 
> Some comments below:
> 
> Some PEP8 error in manifest

fixed

> 728+   name = '%s.%s' % (cls.__module__, cls.__name__)
> There is a logical risk that cls is not initialized if it is not an old/new
> style class.

fixed

> 
> 729 +try:
> 730 +counts[name] += 1
> 731 +except KeyError:
> 732 +counts[name] = 1
> 
> Just a matter of taste but I prefer the use of a defaultdict or "if name in
> counts .. else .."
> Maybe there is a performance advantage to using try catch approach I do not
> know.

AFAIR in this specific case where KeyErrors are supposed to be really the 
exception, this version is supposed to be faster. 


> I think the TODO to log comment is not up to date.

fixed 

> Some test are missing even if they will just ensure that code will not crash.
> I agree that testing returned values is not reasonable here.

done

> Nice to Have:
> 
> It would be nice to have a parameter to disable process logging (just in case
> ;P) in config without having to uninstall the module.

agreed. I'll add this. 

> Maybe we can DRY function that does SQL queries to measure and add some
> exception management, If one query fail It would be nice to have other
> monitoring data saved.

I can't see why the query would fail? Do you have something in mind?

> Not really useful but we may add an abstract model parent of
> server.monitor.table.xxx

I'll see if I can slip this in. 
-- 
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-server/7.0-fix-po-targets-933496-vmt into lp:ocb-server

[Lionel Sausin - Numérigraphe]

The proposal to merge 
lp:~numerigraphe-team/ocb-server/7.0-fix-po-targets-933496-vmt into 
lp:ocb-server has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-server/7.0-fix-po-targets-933496-vmt/+merge/209895
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-server/7.0-fix-po-targets-933496-vmt/+merge/209895
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows

[Romain Deheele - Camptocamp]

The proposal to merge 
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde
 into lp:stock-logistic-flows has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde
 into lp:stock-logistic-flows.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix into lp:account-financial-report

[Nicolas Bessi - Camptocamp]

hello, 

Any news on this one
-- 
https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_financial_report_webkit-first-special-fix/+merge/193717
Your team Account Report Core Editors is subscribed to branch 
lp:account-financial-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size into lp:report-print-send

[Lionel Sausin - Numérigraphe]

I'm interested in this feature and I'm porting a custom module which hacked 
this feature in v6.
I'll do my best to make a review here.
-- 
https://code.launchpad.net/~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size/+merge/202892
Your team Report Printing and Sending Core Editors is requested to review the 
proposed merge of 
lp:~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size into 
lp:report-print-send.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Question #246689]: Is there a module for customer details on POS screen for V7.0 ?

[Alexandre Fayolle - camptocamp]

Question #246689 on OpenERP POS addons changed:
https://answers.launchpad.net/openerp-pos/+question/246689

Status: Open => Answered

Alexandre Fayolle - camptocamp proposed the following answer:
There is a link: pos sale orders are linked to customers. To specify the
customer for a pos order, you have to scan the barcode of the customer,
which has to be a EAN13 code starting with 042.

-- 
You received this question notification because you are a member of
OpenERP Community Reviewer/Maintainer, which is an answer contact for
OpenERP POS addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools

[Nicolas Bessi - Camptocamp]

Review: Needs Fixing

Hello,

Thanks for the module, it is really a valuable tool.

Some comments below:

Some PEP8 error in manifest 

728+   name = '%s.%s' % (cls.__module__, cls.__name__)
There is a logical risk that cls is not initialized if it is not an old/new 
style class. 

729 +try:
730 +counts[name] += 1
731 +except KeyError:
732 +counts[name] = 1

Just a matter of taste but I prefer the use of a defaultdict or "if name in 
counts .. else .."
Maybe there is a performance advantage to using try catch approach I do not 
know. 

I think the TODO to log comment is not up to date.

Some test are missing even if they will just ensure that code will not crash.
I agree that testing returned values is not reasonable here. 

Nice to Have:

It would be nice to have a parameter to disable process logging (just in case 
;P) in config without having to uninstall the module.

Maybe we can DRY function that does SQL queries to measure and add some 
exception management, If one query fail It would be nice to have other 
monitoring data saved.

Not really useful but we may add an abstract model parent of 
server.monitor.table.xxx

Thanks again

Regards

Nicolas
-- 
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1305653-afe into lp:ocb-server

[Nicolas Bessi - Camptocamp]

Review: Approve

LGTM
-- 
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305653-afe/+merge/215121
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde into lp:stock-logistic-flows

[Romain Deheele - Camptocamp]

Romain Deheele - Camptocamp has proposed merging 
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde
 into lp:stock-logistic-flows.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde/+merge/215147

Hi,

It adds a picking dispatch extension, with a picking_oriented use.
Description:
The picking_dispatch addon is stock move-oriented.
This addon changes it for a picking-oriented use.
On "Done" button, a wizard is displayed (same as picking_dispatch), but:
- moves are not passed to "done" state, but splitted between picked 
quantity and remains.
- unpicked moves are moved in a new backorder.
Then, when the picking dispatch state is done :
- the picking dispatch hides the "Stock Moves" tab, to deliver, the user 
uses "Related Picking" tab
- the "Transfer Products" wizard ("Deliver" button) displays only moves 
linked to a done picking dispatch.

The process is the next:
  - A picking dispatch is created with several moves from several pickings.
  - When the user 


I'm not necessarily satisfied about addon's name, I'm ok to change it if we 
find.

Regards,
Romain
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde/+merge/215147
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_picking_oriented_use-rde
 into lp:stock-logistic-flows.
=== added directory 'picking_dispatch_picking_oriented'
=== added file 'picking_dispatch_picking_oriented/__init__.py'
--- picking_dispatch_picking_oriented/__init__.py	1970-01-01 00:00:00 +
+++ picking_dispatch_picking_oriented/__init__.py	2014-04-10 10:49:06 +
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alexandre Fayolle, Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+from . import dispatch  # noqa

=== added file 'picking_dispatch_picking_oriented/__openerp__.py'
--- picking_dispatch_picking_oriented/__openerp__.py	1970-01-01 00:00:00 +
+++ picking_dispatch_picking_oriented/__openerp__.py	2014-04-10 10:49:06 +
@@ -0,0 +1,47 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alexandre Fayolle, Romain Deheele
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+
+{
+"name": "Picking Dispatch picking-oriented",
+"version": "0.1",
+"depends": ['picking_dispatch'],
+"author": "Camptocamp",
+"license": "AGPL-3",
+"description": """
+The picking_dispatch addon is stock move-oriented.
+This addon changes it for a picking-oriented use.
+
+On "Done" button, a wizard is displayed (same as picking_dispatch), but:
+- moves are not passed to "done" state, but split between picked quantity and remains.
+- unpicked moves are moved in a new backorder.
+
+Then, when the picking dispatch state is done:
+- the picking dispatch hides the "Stock Moves" tab, to deliver, the user uses "Related Picking" tab
+- the "Transfer Products" wizard ("Deliver" button) displays only moves linked to a done picking dispatch.
+""",
+"website": "http://www.camptocamp.com";,
+

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1305653-afe into lp:ocb-server

[Yannick Vaucher @ Camptocamp]

Review: Approve code review, no test

LGTM
-- 
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305653-afe/+merge/215121
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools

[Alexandre Fayolle - camptocamp]

Alexandre Fayolle - camptocamp has proposed merging 
lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools.

Requested reviews:
  Server Environment And Tools Core Editors (server-env-tools-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138

new addon: server_monitoring

This addon logs information in the OpenERP database, which can be used to 
monitor the health of the instance:

* database information (table size, number of reads, inserts, updates, 
deletes...)
* process information (cpu time, memory, rpc calls...)
-- 
https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138
Your team Server Environment And Tools Core Editors is requested to review the 
proposed merge of lp:~camptocamp/server-env-tools/7.0-monitoring into 
lp:server-env-tools.
=== added directory 'server_monitoring'
=== added file 'server_monitoring/__init__.py'
--- server_monitoring/__init__.py	1970-01-01 00:00:00 +
+++ server_monitoring/__init__.py	2014-04-10 10:25:03 +
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alexandre Fayolle
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+from . import server_monitoring

=== added file 'server_monitoring/__openerp__.py'
--- server_monitoring/__openerp__.py	1970-01-01 00:00:00 +
+++ server_monitoring/__openerp__.py	2014-04-10 10:25:03 +
@@ -0,0 +1,53 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alexandre Fayolle
+#Copyright 2014 Camptocamp SA
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+{'name': 'Server Monitoring',
+ 'version': '0.1',
+ 'category': 'Connector',
+ 'depends': ['base',
+ ],
+ 'author': 'Camptocamp',
+ 'license': 'AGPL-3',
+ 'description': """
+Server Monitoring
+=
+
+This module allows in-database logging of some statistics in order to monitor
+the health of an openerp instance.
+
+Database indicators are logged (number of rows, table size, number of reads,
+number of updates...), with a cron running each week by default.
+
+Some process indicators are logged (cpu time, memory) together with information
+about the different XMLRPC calls made to the server (user, model, method).
+
+Two crons are provided to cleanup old logs from the database.
+""",
+ 'data': [
+ 'server_monitoring_view.xml',
+ 'server_monitoring_data.xml',
+ 'security/ir.model.access.csv',
+ ],
+ 'test':[],
+ 'installable': True,
+ 'application': False,
+}
+

=== added directory 'server_monitoring/security'
=== added file 'server_monitoring/security/ir.model.access.csv'
--- server_monitoring/security/ir.model.access.csv	1970-01-01 00:00:00 +
+++ server_monitoring/security/ir.model.access.csv	2014-04-10 10:25:03 +
@@ -0,0 +1,8 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+access_server_monitor_class_instance_count,access_server_monitor_class_instance_count,model_server_monitor_class_instance_count,base.group_no_one,1,0,1,0
+access_server_monitor_process,access_server_monitor_process,model_server_monitor_process,base.group_no_one,1,0,1,0
+access_server_monitor_model_row_count,access_server_monitor_model_row_count,model_server_monitor_model_row_count,base.group_no_one,1,0,1,0
+access_server_monitor_model_table_size,access_server_monitor_model_t

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1305653-afe into lp:ocb-server

[Pedro Manuel Baeza]

Review: Approve code review

LGTM.

Regards.
-- 
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305653-afe/+merge/215121
Your team OpenERP Community Backports Team is subscribed to branch 
lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-server/7.0-fix_1305653-afe into lp:ocb-server

[Alexandre Fayolle - camptocamp]

Alexandre Fayolle - camptocamp has proposed merging 
lp:~camptocamp/ocb-server/7.0-fix_1305653-afe into lp:ocb-server.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1305653 in OpenERP Community Backports (Server): "[7.0] missing 
arguments to logging statement in workers.py"
  https://bugs.launchpad.net/ocb-server/+bug/1305653

For more details, see:
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305653-afe/+merge/215121

add missing parameter to logging statement

port of 
https://code.launchpad.net/~camptocamp/openobject-server/7.0-fix_1305653-afe/+merge/215120
 to OCB 
-- 
https://code.launchpad.net/~camptocamp/ocb-server/7.0-fix_1305653-afe/+merge/215121
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~camptocamp/ocb-server/7.0-fix_1305653-afe into lp:ocb-server.
=== modified file 'openerp/service/workers.py'
--- openerp/service/workers.py	2013-11-25 10:38:42 +
+++ openerp/service/workers.py	2014-04-10 09:38:11 +
@@ -269,7 +269,7 @@
 r = resource.getrusage(resource.RUSAGE_SELF)
 cpu_time = r.ru_utime + r.ru_stime
 def time_expired(n, stack):
-_logger.info('Worker (%d) CPU time limit (%s) reached.', config['limit_time_cpu'])
+_logger.info('Worker (%d) CPU time limit (%s) reached.', os.getpid(), config['limit_time_cpu'])
 # We dont suicide in such case
 raise Exception('CPU time limit exceeded.')
 signal.signal(signal.SIGXCPU, time_expired)

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1305653] [NEW] [7.0] missing arguments to logging statement in workers.py

[Alexandre Fayolle - camptocamp]

Public bug reported:

in openerp/services/workers.py:

   def time_expired(n, stack):
_logger.info('Worker (%d) CPU time limit (%s) reached.', 
config['limit_time_cpu'])

There is a missing parameter, which cause a stack trace in the logging
module:

Traceback (most recent call last):
  File "/usr/lib/python2.7/logging/__init__.py", line 846, in emit
msg = self.format(record)
  File "/usr/lib/python2.7/logging/__init__.py", line 723, in format
return fmt.format(record)
  File 
"/home/afayolle/work/customers/avosdim/buildout/parts/server/openerp/netsvc.py",
 line 150, in format
logging.exception('while formatting %r', record)
  File 
"/home/afayolle/work/customers/avosdim/buildout/parts/server/openerp/netsvc.py",
 line 144, in format
try:
  File "/usr/lib/python2.7/logging/__init__.py", line 464, in format
record.message = record.getMessage()
  File "/usr/lib/python2.7/logging/__init__.py", line 328, in getMessage
msg = msg % self.args
TypeError: not enough arguments for format string

** Affects: ocb-server
 Importance: Undecided
 Assignee: Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)
 Status: Fix Committed

** Affects: ocb-server/7.0
 Importance: Undecided
 Assignee: Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)
 Status: Fix Committed

** Affects: openobject-server
 Importance: Undecided
 Status: Fix Committed

** Also affects: ocb-server
   Importance: Undecided
   Status: New

** Also affects: ocb-server/7.0
   Importance: Undecided
   Status: New

** Changed in: ocb-server/7.0
 Assignee: (unassigned) => Alexandre Fayolle - camptocamp 
(alexandre-fayolle-c2c)

** Changed in: ocb-server/7.0
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Server).
https://bugs.launchpad.net/bugs/1305653

Title:
  [7.0] missing arguments to logging statement in workers.py

Status in OpenERP Community Backports (Server):
  Fix Committed
Status in OpenERP Community Backports (Server) 7.0 series:
  Fix Committed
Status in OpenERP Server:
  Fix Committed

Bug description:
  in openerp/services/workers.py:

 def time_expired(n, stack):
  _logger.info('Worker (%d) CPU time limit (%s) reached.', 
config['limit_time_cpu'])

  There is a missing parameter, which cause a stack trace in the logging
  module:

  Traceback (most recent call last):
File "/usr/lib/python2.7/logging/__init__.py", line 846, in emit
  msg = self.format(record)
File "/usr/lib/python2.7/logging/__init__.py", line 723, in format
  return fmt.format(record)
File 
"/home/afayolle/work/customers/avosdim/buildout/parts/server/openerp/netsvc.py",
 line 150, in format
  logging.exception('while formatting %r', record)
File 
"/home/afayolle/work/customers/avosdim/buildout/parts/server/openerp/netsvc.py",
 line 144, in format
  try:
File "/usr/lib/python2.7/logging/__init__.py", line 464, in format
  record.message = record.getMessage()
File "/usr/lib/python2.7/logging/__init__.py", line 328, in getMessage
  msg = msg % self.args
  TypeError: not enough arguments for format string

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-server/+bug/1305653/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-web/ocb-7.0-bug-1163912-calendar-view into lp:ocb-web

[Cedric Le Brouster(OpenFire)]

Cedric Le Brouster(OpenFire) has proposed merging 
lp:~cedric-lebrouster/ocb-web/ocb-7.0-bug-1163912-calendar-view into lp:ocb-web.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1163912 in OpenERP Web: "[Trunk/7.0] Calendar month view does not show 
events starting in previous month"
  https://bugs.launchpad.net/openerp-web/+bug/1163912

For more details, see:
https://code.launchpad.net/~cedric-lebrouster/ocb-web/ocb-7.0-bug-1163912-calendar-view/+merge/215111

Correction of the fix 3989 for the bug 1163912 (didn't work for calendars using 
date_delay instead of date_stop).
-- 
https://code.launchpad.net/~cedric-lebrouster/ocb-web/ocb-7.0-bug-1163912-calendar-view/+merge/215111
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~cedric-lebrouster/ocb-web/ocb-7.0-bug-1163912-calendar-view into 
lp:ocb-web.
=== modified file 'addons/web_calendar/static/src/js/calendar.js'
--- addons/web_calendar/static/src/js/calendar.js	2014-02-14 11:42:58 +
+++ addons/web_calendar/static/src/js/calendar.js	2014-04-10 08:56:57 +
@@ -396,19 +396,12 @@
 });
 },
 get_range_domain: function() {
-var format = instance.web.date_to_str;
-var A = format(this.range_start.clone().addDays(-6));
-var B = format(this.range_stop.clone().addDays(6));
-var domain = [
-'&', [this.date_start, '>=', A], [this.date_start, '<=', B]
-];
+var format = instance.web.date_to_str,
+domain = this.last_search[0].slice(0);
+domain.unshift([this.date_start, '<=', format(this.range_stop.clone().addDays(6))]);
 if (this.date_stop) {
-domain.push(
-'&', [this.date_stop, '>=', A], [this.date_stop, '<=', B],
-'&', [this.date_start, '<', A], [this.date_stop, '>', B]);
-domain.unshift("|", "|");
+domain.unshift([this.date_stop, '>=', format(this.range_start.clone().addDays(-6))]);
 }
-domain.concat(this.last_search[0].slice(0))
 return domain;
 },
 do_show: function () {

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into lp:server-env-tools

[Pedro Manuel Baeza]

Review: Approve code review

LGTM.

Thanks.
-- 
https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214890
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 1220110] Re: Server crashes executing Duplicate BoM

[Alejandro Santana]

As the two merge proposal didn't solve the core nature of the bug and
thanks to Stefan the bug was really solved, I remove those two merge
proposal.

** Changed in: ocb-server/7.0
   Status: New => Invalid

-- 
You received this bug notification because you are a member of OpenERP
Community Backports Team, which is subscribed to OpenERP Community
Backports (Server).
https://bugs.launchpad.net/bugs/1220110

Title:
  Server crashes executing Duplicate BoM

Status in OpenERP Community Backports (Server):
  Invalid
Status in OpenERP Community Backports (Server) 7.0 series:
  Invalid
Status in OpenERP Server:
  Invalid

Bug description:
  1) Query on BoM items, select one and execute "Duplicate"
  2) System crashes reporting the following error:
  Client Traceback (most recent call last):
File "/opt/server/openerp/addons/web/http.py", line 204, in dispatch
  response["result"] = method(self, **self.params)
File "/opt/server/openerp/addons/web/controllers/main.py", line 1128, in 
call_kw
  return self._call_kw(req, model, method, args, kwargs)
File "/opt/server/openerp/addons/web/controllers/main.py", line 1120, in 
_call_kw
  return getattr(req.session.model(model), method)(*args, **kwargs)
File "/opt/server/openerp/addons/web/session.py", line 42, in proxy
  result = self.proxy.execute_kw(self.session._db, self.session._uid, 
self.session._password, self.model, method, args, kw)
File "/opt/server/openerp/addons/web/session.py", line 30, in proxy_method
  result = self.session.send(self.service_name, method, *args)
File "/opt/server/openerp/addons/web/session.py", line 103, in send
  raise xmlrpclib.Fault(openerp.tools.ustr(e), formatted_info)

  
  Server Traceback (most recent call last):
File "/opt/server/openerp/addons/web/session.py", line 89, in send
  return openerp.netsvc.dispatch_rpc(service_name, method, args)
File "/opt/openerp-7.0-20130901-231054/openerp/netsvc.py", line 292, in 
dispatch_rpc
  result = ExportService.getService(service_name).dispatch(method, params)
File "/opt/openerp-7.0-20130901-231054/openerp/service/web_services.py", 
line 626, in dispatch
  res = fn(db, uid, *params)
File "/opt/openerp-7.0-20130901-231054/openerp/osv/osv.py", line 188, in 
execute_kw
  return self.execute(db, uid, obj, method, *args, **kw or {})
File "/opt/openerp-7.0-20130901-231054/openerp/osv/osv.py", line 131, in 
wrapper
  return f(self, dbname, *args, **kwargs)
File "/opt/openerp-7.0-20130901-231054/openerp/osv/osv.py", line 197, in 
execute
  res = self.execute_cr(cr, uid, obj, method, *args, **kw)
File "/opt/openerp-7.0-20130901-231054/openerp/osv/osv.py", line 185, in 
execute_cr
  return getattr(object, method)(cr, uid, *args, **kw)
File "/opt/addons/OpenERPPLM/install/plm_base_entities.py", line 465, in 
copy
  newId=super(plm_relation,self).copy(cr,uid,oid,defaults,context=context)
File "/opt/server/openerp/addons/mail/mail_thread.py", line 302, in copy
  return super(mail_thread, self).copy(cr, uid, id, default=default, 
context=context)
File "/opt/openerp-7.0-20130901-231054/openerp/osv/orm.py", line 5027, in 
copy
  data = self.copy_data(cr, uid, id, default, context)
File "/opt/server/openerp/addons/mrp/mrp.py", line 376, in copy_data
  bom_data = self.read(cr, uid, id, [], context=context)
File "/opt/openerp-7.0-20130901-231054/openerp/osv/orm.py", line 3606, in 
read
  result = self._read_flat(cr, user, select, fields, context, load)
File "/opt/openerp-7.0-20130901-231054/openerp/osv/orm.py", line 3726, in 
_read_flat
  res2 = self._columns[f].get(cr, self, ids, f, user, context=context, 
values=res)
File "/opt/openerp-7.0-20130901-231054/openerp/osv/fields.py", line 1140, 
in get
  result[id] = self.postprocess(cr, uid, obj, name, result[id], context)
File "/opt/openerp-7.0-20130901-231054/openerp/osv/fields.py", line 1129, 
in postprocess
  result = __builtin__.float(value)
  TypeError: float() argument must be a string or a number

  3) I'm expecting to have BoM duplicated.

  4) I'm working on Windows XP, with Google Chrome as browser.

  5) I'm working on openerp-7.0-20130901-231054 server version on Debian 7.0 
server.
  This crash happens only on unix servers and not on windows ones.
  In my configuration I added some fields to mrp_bom :

  class plm_relation(osv.osv):
  _name = 'mrp.bom'
  _inherit = 'mrp.bom'

  _columns = {
  'state': 
fields.related('product_id','state',type="char",relation="product.template",string="Status",store=False),
  'engineering_revision': 
fields.related('product_id','engineering_revision',type="char",relation="product.template",string="Revision",store=False),
  'description': 
fields.related('product_id','description',type="char",relation="product.template",string="Description",store=False),
  'weight_net':