Re: [Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web-addons into lp:web-addons
Review: Approve code review -- https://code.launchpad.net/~aristobulo/web-addons/web-addons/+merge/217277 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl
Thanks Joël, I've updated the module as you suggested. -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/analytic_department_vre into lp:department-mgmt
The proposal to merge lp:~camptocamp/department-mgmt/analytic_department_vre into lp:department-mgmt has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~camptocamp/department-mgmt/analytic_department_vre/+merge/218976 -- https://code.launchpad.net/~camptocamp/department-mgmt/analytic_department_vre/+merge/218976 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web_fields_masks into lp:web-addons
Review: Needs Fixing You should put library files into /static/lib (why? If another module uses the same library, it would be loaded twice otherwise and is likely to clash) Further, #2492 means we can't have apostrophes or quotes in the input mask. Why don't you simply eval() this attribute? This way, the user can fill in either a simple input mask or an object as applicable? What would be nice is if you set the standard OpenERP error class (oe_form_invalid) if the user's input doesn't match the mask. -- https://code.launchpad.net/~aristobulo/web-addons/web_fields_masks/+merge/219084 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted into lp:ocb-addons
While the index is a good thing to have, I merge this already as we can add the index afterwards -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted/+merge/210467 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~alhashash/ocb-addons/7.0-alhashash-bug1179705 into lp:ocb-addons
The proposal to merge lp:~alhashash/ocb-addons/7.0-alhashash-bug1179705 into lp:ocb-addons has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~alhashash/ocb-addons/7.0-alhashash-bug1179705/+merge/217681 -- https://code.launchpad.net/~alhashash/ocb-addons/7.0-alhashash-bug1179705/+merge/217681 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted into lp:ocb-addons
The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted into lp:ocb-addons has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted/+merge/210467 -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-lines-sorted/+merge/210467 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False into lp:ocb-addons/6.1
The proposal to merge lp:~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False into lp:ocb-addons/6.1 has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False/+merge/218060 -- https://code.launchpad.net/~therp-nl/ocb-addons/6.1-lp1315367-task_work_timesheet_lines_False/+merge/218060 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM into lp:ocb-addons
Review: Approve code review -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM/+merge/217049 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM into lp:ocb-addons
Review: Abstain co-author Thanks Holger, I've updated Loïc's patch according to your suggestion. Of course I'll abstain now that I'm co-author :) -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM/+merge/217049 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~lmi/ocb-addons/7.0-opw-596916-rgo into lp:ocb-addons
Review: Approve code review -- https://code.launchpad.net/~lmi/ocb-addons/7.0-opw-596916-rgo/+merge/218476 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde into lp:ocb-addons
Review: Approve code review -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~lmi/ocb-addons/7.0-opw-596916-rgo into lp:ocb-addons
The proposal to merge lp:~lmi/ocb-addons/7.0-opw-596916-rgo into lp:ocb-addons has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~lmi/ocb-addons/7.0-opw-596916-rgo/+merge/218476 -- https://code.launchpad.net/~lmi/ocb-addons/7.0-opw-596916-rgo/+merge/218476 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~alhashash/ocb-addons/7.0-bug-1219204 into lp:ocb-addons
Review: Needs Fixing
#24 don't loose the context here. I propose
context=dict(context or {}, regenerate_opening=True)
Then you should move #9 before the loop, as we don't need to loop if this key
is set
--
https://code.launchpad.net/~alhashash/ocb-addons/7.0-bug-1219204/+merge/217676
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~vauxoo/server-env-tools/7.0_merge_partner_duplicates into lp:server-env-tools
What is the status if this MP in regard to https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616 ? So where is the main development going on? -- https://code.launchpad.net/~vauxoo/server-env-tools/7.0_merge_partner_duplicates/+merge/170122 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/lp-community-utils/pep394 into lp:lp-community-utils
Review: Approve If I understand correctly, we are trading a small smoothness advantage for old distributions vs. more up-to-date ones that received pep394. I lean a bit for calling python2 explicitly. I prefer those with old distributions to go through some (easy) hoops to comply with future-proof pep's that the contrary. In any case, these scripts are used by people that can figure out how to work around the problem in both cases, so I won't fight over this. -- https://code.launchpad.net/~savoirfairelinux-openerp/lp-community-utils/pep394/+merge/204535 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:lp-community-utils. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge into lp:department-mgmt
Hi, Thanks for the review I missed the trigger :( I corrected all the points. Regards, Joël -- https://code.launchpad.net/~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge/+merge/218807 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/account-invoicing/account_invoice_line_merge into lp:account-invoicing
Review: Needs Fixing I think the problem Joël means is that the sale_origin addon simply contains the code for purchase_origin. Then for #344ff: I think it's a bad idea to copy the original function and break inheritance. Better call super and set the origin field in the dictionary you get back. -- https://code.launchpad.net/~savoirfairelinux-openerp/account-invoicing/account_invoice_line_merge/+merge/216327 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge into lp:department-mgmt
Review: Approve code review Thanks! LGTM -- https://code.launchpad.net/~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge/+merge/218807 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~vauxoo/server-env-tools/7.0_merge_partner_duplicates into lp:server-env-tools
The developments were made in parallel. Both are backport of v8 merge wizard. Nhomar said he wanted to test it. But we had no feed back. https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616/comments/436062 Nor I took the time to fully compare both MP. So there is no convergence yet. And main dev seems neither of the 2 MPs. Though the other MP has more approval, yet. About seeing it in server-env-tools or in partner-contact-management. I don't want to see server-env-tools becomming a dumping ground. For me, even advanced tool like partner merge should be in their topic. It is the responsibility of admin to choice what he installs and who has access to it. -- https://code.launchpad.net/~vauxoo/server-env-tools/7.0_merge_partner_duplicates/+merge/170122 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing
Review: Needs Fixing #197ff, #202ff missing spaces at end of strings @218ff can't you avoid code duplication and breaking inheritance by using super's result and simply adding the months as applicable? -- https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma
Hi Benoit, I'm 100% ok with you, I changed it. Thanks for the suggestion. Romain -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools
The proposal to merge lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138 -- https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/server-env-tools/7.0-monitoring into lp:server-env-tools
thanks for the review, Daniel. I'm setting this back to WIP until I get the time for take your comments into account. -- https://code.launchpad.net/~camptocamp/server-env-tools/7.0-monitoring/+merge/215138 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings into lp:hr-timesheet
Review: Needs Fixing code review Hi, Lorenzo, Please use correct indentation in if sentence for PEP8 compliance (higher than nested block). Functionally speaking, it seems good, but maybe you can do: if (float_end_time - float_start_time) 0.001: and simplify the condition. Regards. -- https://code.launchpad.net/~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings/+merge/206493 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal into lp:sale-wkfl
Review: Needs Fixing code review Hi, David, in that case, please put a journal_id field on sale.order, that is filled by default with journal_id selected on shop, but that can be changed and passed to invoice. On v8, when shops dissapear, you have to only remove sale.shop part. Regards. -- https://code.launchpad.net/~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal/+merge/215440 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~alhashash/ocb-addons/7.0-bug-1317455-check-show-amount-in-words into lp:ocb-addons
Review: Approve code review Thanks for the fix and for the detailed explanation of the bug. Regards. -- https://code.launchpad.net/~alhashash/ocb-addons/7.0-bug-1317455-check-show-amount-in-words/+merge/218930 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1318668] [NEW] [7.0] Product view slow with many stock_locations
Public bug reported: Hi ! With 13000 stock locations, it takes nearly 10 seconds to see the product list view, and another 10 seconds each time you click anywhere related to a product. We analysed that bug, and saw that the fields_view_get request returns our 13000 locations and our warehouses... This problem is related to these two fields (file: stock/product.py): 'location_id': fields.dummy(string='Location', relation='stock.location', type='many2one'), 'warehouse_id': fields.dummy(string='Warehouse', relation='stock.warehouse', type='many2one') Does anybody knows why these fields are dummy ? We replaced those with true many2one fields and the problem is gone. Best regards ** Affects: ocb-addons Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1318668 Title: [7.0] Product view slow with many stock_locations Status in OpenERP Community Backports (Addons): New Bug description: Hi ! With 13000 stock locations, it takes nearly 10 seconds to see the product list view, and another 10 seconds each time you click anywhere related to a product. We analysed that bug, and saw that the fields_view_get request returns our 13000 locations and our warehouses... This problem is related to these two fields (file: stock/product.py): 'location_id': fields.dummy(string='Location', relation='stock.location', type='many2one'), 'warehouse_id': fields.dummy(string='Warehouse', relation='stock.warehouse', type='many2one') Does anybody knows why these fields are dummy ? We replaced those with true many2one fields and the problem is gone. Best regards To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1318668/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~invitu/ocb-server/7.0 into lp:ocb-server
the thing is, it is different to store a birthday (which should still be machine parseable) and a birthdate. When the field is called birthdate, I expect a date. -- https://code.launchpad.net/~invitu/ocb-server/7.0/+merge/169658 Your team OpenERP Community Backports is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal into lp:sale-wkfl
Hi Pedro, Thanks for this idea but in ecommerce for example, shop allows to store several config values, not only journal. It seems more interesting to develop a module for shop in v8 -- https://code.launchpad.net/~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal/+merge/215440 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde into lp:stock-logistic-flows
Thanks Yannick, I've reworked terms and translation. Romain -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-picking_dispatch_wave-according-defined-number-of-sales_rde/+merge/214568 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal into lp:sale-wkfl
Yeah, and that plans are compatible with the proposal, because you can have a basic module with only journal at sale order level, and an additional one with the dependency to new shop module with this feature. Regards. -- https://code.launchpad.net/~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal/+merge/215440 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl
Review: Approve code review -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/account-analytic-required-vre into lp:account-invoicing
Review: Needs Fixing Thanks Vincent, some style fixes: account_invoice_analytic_required/__init__.py:3:2: W291 trailing whitespace account_invoice_analytic_required/__init__.py:19:75: W291 trailing whitespace account_invoice_analytic_required/__init__.py:23:14: E271 multiple spaces after keyword account_invoice_analytic_required/__openerp__.py:3:2: W291 trailing whitespace account_invoice_analytic_required/__openerp__.py:19:75: W291 trailing whitespace account_invoice_analytic_required/__openerp__.py:23:1: O603 Manifest license key is missing account_invoice_analytic_required/__openerp__.py:24:11: E203 whitespace before ':' account_invoice_analytic_required/__openerp__.py:25:14: E203 whitespace before ':' account_invoice_analytic_required/__openerp__.py:26:15: E203 whitespace before ':' account_invoice_analytic_required/__openerp__.py:28:13: E203 whitespace before ':' account_invoice_analytic_required/__openerp__.py:29:14: E203 whitespace before ':' account_invoice_analytic_required/__openerp__.py:30:14: E203 whitespace before ':' account_invoice_analytic_required/__openerp__.py:32:11: E203 whitespace before ':' account_invoice_analytic_required/__openerp__.py:33:11: E203 whitespace before ':' account_invoice_analytic_required/__openerp__.py:34:11: E203 whitespace before ':' account_invoice_analytic_required/__openerp__.py:35:18: E203 whitespace before ':' account_invoice_analytic_required/__openerp__.py:36:19: E203 whitespace before ':' account_invoice_analytic_required/__openerp__.py:37:18: E203 whitespace before ':' account_invoice_analytic_required/account_invoice_analytic_required.py:23:1: O603 Manifest license key is missing account_invoice_analytic_required/account_invoice_analytic_required.py:25:1: E302 expected 2 blank lines, found 1 account_invoice_analytic_required/account_invoice_analytic_required.py:27:13: E225 missing whitespace around operator account_invoice_analytic_required/__openerp__.py:24:80: E501 line too long (84 79 characters) account_invoice_analytic_required/__openerp__.py:27:80: E501 line too long (94 79 characters) account_invoice_analytic_required/account_invoice_analytic_required.py:30:80: E501 line too long (110 79 characters) -- https://code.launchpad.net/~camptocamp/account-invoicing/account-analytic-required-vre/+merge/218974 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/purchase-wkfl/pallet-delivery-missing-security-access into lp:purchase-wkfl
Review: Needs Fixing line 35: missing description -- https://code.launchpad.net/~savoirfairelinux-openerp/purchase-wkfl/pallet-delivery-missing-security-access/+merge/218508 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-consolidation/7.0-bug-1296740-elbati into lp:account-consolidation/7.0
Dear Yannick, I don't think this MP would break compatibility with account_financial_report_webkit. I installed account_financial_report_webkit and account_parralel_currency and I can use them without problems. It just doesn't copy the centralized field to the parallel accounts. For that, a link module can be surely done. But I think it has less priority than fixing the linked bug. -- https://code.launchpad.net/~agilebg/account-consolidation/7.0-bug-1296740-elbati/+merge/212487 Your team Account Core Editors is subscribed to branch lp:account-consolidation/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl
Review: Needs Fixing
Thanks Pedro,
line 349: I think discount should not be -100 too
line 399: amount_untaxed and following fields are present 2 times
some PEP8:
purchase_discount/__openerp__.py:21:1: O603 Manifest license key is missing
purchase_discount/__openerp__.py:29:5: O600 Warning unknown Manifest key
('contributors')
purchase_discount/__openerp__.py:43:5: O600 Warning unknown Manifest key
('active')
purchase_discount/purchase_discount.py:21:1: O603 Manifest license key is
missing
purchase_discount/purchase_discount.py:24:1: E302 expected 2 blank lines, found
1
purchase_discount/purchase_discount.py:29:5: O600 Warning unknown Manifest key
('contributors')
purchase_discount/purchase_discount.py:35:75: W291 trailing whitespace
purchase_discount/purchase_discount.py:43:5: O600 Warning unknown Manifest key
('active')
purchase_discount/purchase_discount.py:43:75: W291 trailing whitespace
purchase_discount/purchase_discount.py:44:33: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:52:56: W291 trailing whitespace
purchase_discount/purchase_discount.py:86:29: E127 continuation line
over-indented for visual indent
purchase_discount/purchase_discount.py:103:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:104:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:105:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:109:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:110:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:114:17: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:115:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:118:55: W291 trailing whitespace
purchase_discount/purchase_discount.py:119:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:119:28: E251 unexpected spaces around
keyword / parameter equals
purchase_discount/purchase_discount.py:119:57: W291 trailing whitespace
purchase_discount/purchase_discount.py:120:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:121:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:123:60: W291 trailing whitespace
purchase_discount/purchase_discount.py:125:51: W291 trailing whitespace
purchase_discount/purchase_discount.py:126:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:126:28: E251 unexpected spaces around
keyword / parameter equals
purchase_discount/purchase_discount.py:127:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:130:53: W291 trailing whitespace
purchase_discount/purchase_discount.py:131:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:131:28: E251 unexpected spaces around
keyword / parameter equals
purchase_discount/purchase_discount.py:132:13: E128 continuation line
under-indented for visual indent
purchase_discount/purchase_discount.py:134:28: E231 missing whitespace after ','
--
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
Your team Purchase Core Editors is requested to review the proposed merge of
lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix into lp:openerp-reporting-engines
Luc De Meyer (Noviat) has proposed merging
lp:~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix into
lp:openerp-reporting-engines.
Requested reviews:
OpenERP Community Reviewer/Maintainer (openerp-community-reviewer)
For more details, see:
https://code.launchpad.net/~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix/+merge/219267
timezone fix
--
https://code.launchpad.net/~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix/+merge/219267
Your team OpenERP Community Reviewer/Maintainer is requested to review the
proposed merge of
lp:~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix into
lp:openerp-reporting-engines.
=== modified file 'report_xls/__init__.py'
--- report_xls/__init__.py 2014-01-06 22:22:39 +
+++ report_xls/__init__.py 2014-05-12 20:55:28 +
@@ -3,7 +3,7 @@
#
#OpenERP, Open Source Management Solution
#
-#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#Copyright (c) 2014 Noviat nv/sa (www.noviat.com). All rights reserved.
#
#This program is free software: you can redistribute it and/or modify
#it under the terms of the GNU Affero General Public License as
@@ -16,7 +16,7 @@
#GNU Affero General Public License for more details.
#
#You should have received a copy of the GNU Affero General Public License
-#along with this program. If not, see http://www.gnu.org/licenses/.
+#along with this program. If not, see http://www.gnu.org/licenses/.
#
##
=== modified file 'report_xls/__openerp__.py'
--- report_xls/__openerp__.py 2014-01-06 22:22:39 +
+++ report_xls/__openerp__.py 2014-05-12 20:55:28 +
@@ -3,7 +3,7 @@
#
#OpenERP, Open Source Management Solution
#
-#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#Copyright (c) 2014 Noviat nv/sa (www.noviat.com). All rights reserved.
#
#This program is free software: you can redistribute it and/or modify
#it under the terms of the GNU Affero General Public License as
@@ -16,7 +16,7 @@
#GNU Affero General Public License for more details.
#
#You should have received a copy of the GNU Affero General Public License
-#along with this program. If not, see http://www.gnu.org/licenses/.
+#along with this program. If not, see http://www.gnu.org/licenses/.
#
##
{
@@ -67,7 +67,7 @@
Development assistance
''
-Contact i...@noviat.com for help with the development of Excel reports in OpenERP, .
+Contact i...@noviat.com for help with the development of Excel reports in OpenERP.
,
'depends': ['base'],
=== modified file 'report_xls/report_xls.py'
--- report_xls/report_xls.py 2014-01-06 22:22:39 +
+++ report_xls/report_xls.py 2014-05-12 20:55:28 +
@@ -24,6 +24,7 @@
from xlwt.Style import default_style
import cStringIO
from datetime import datetime
+from openerp.osv.fields import datetime as datetime_field
from openerp.tools import DEFAULT_SERVER_DATETIME_FORMAT
import inspect
from types import CodeType
@@ -58,7 +59,6 @@
# TO DO: move parameters infra to configurable data
# header/footer
-DT_FORMAT = '%Y-%m-%d %H:%M:%S'
hf_params = {
'font_size': 8,
'font_style': 'I', # B: Bold, I: Italic, U: Underline
@@ -120,8 +120,9 @@
self.xls_headers = {
'standard': '',
}
+report_date = datetime_field.context_timestamp(cr, uid, datetime.now(), context).strftime(DEFAULT_SERVER_DATETIME_FORMAT)
self.xls_footers = {
-'standard': ('L%(font_size)s%(font_style)s' + datetime.now().strftime(DEFAULT_SERVER_DATETIME_FORMAT) +
+'standard': ('L%(font_size)s%(font_style)s' + report_date +
'R%(font_size)s%(font_style)sP / N') % self.hf_params,
}
self.generate_xls_report(_p, _xs, data, objs, wb)
=== modified file 'report_xls/utils.py'
--- report_xls/utils.py 2014-01-06 22:22:39 +
+++ report_xls/utils.py 2014-05-12 20:55:28 +
@@ -3,7 +3,7 @@
#
#OpenERP, Open Source Management Solution
#
-#Copyright (c) 2013 Noviat nv/sa (www.noviat.com). All rights reserved.
+#Copyright (c) 2014 Noviat nv/sa (www.noviat.com). All rights reserved.
#
#This program is free software: you can redistribute it and/or modify
#it under the terms of the GNU Affero General Public License as
@@ -16,7 +16,7 @@
#GNU Affero General Public License for more details.
#
#You should have received a copy of the GNU Affero General Public License
-#along with this program. If not, see http://www.gnu.org/licenses/.
+#along with this program. If not, see http://www.gnu.org/licenses/.
#
##
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools
Hi, Yannick, Thanks for taking the time to review such a huge change that I have made on the module. I know that there's still a lot to do to comply with all the conventions, but this is a beginning motivated by some requirements not met in it. I have fixed things you have point about missing contexts. About tax_template to tax_templ it was to favour PEP8 80 cols restriction, because with that long names was very difficult to fit lines. I think it's still enough readable and I win 3 chars less. I removed required=True from fill to avoid a strange situation that happens when removing a chart template (a strange user case, but I faced it in one case): if you put this field as required, and you run the wizard, a row is created on the temporary table form the transient model. This table is not clean up until next vacuum. Meanwhile, if you try to remove the chart template that has been selected on the wizard, due to ondelete=cascade attribute, chart_template_id is emptied on temporary table, but required constraint throws an error, avoiding you to remove this chart template. That's why I have moved required condition to view. Regards. -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced/+merge/212074 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools
s/required=True from fill/required=True from wizard -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced/+merge/212074 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl
Hi, Lorenzo, thanks for your review. I have corrected flake8 output. But about negative restriction in the percentage amount, I don't think it's a good idea, because you can apply a surcharge of whatever percentage you want: for example, -100% to double original price, -200% to triple it, and so on. Regards. -- https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030 Your team Purchase Core Editors is requested to review the proposed merge of lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
