Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl
Ok, thanks. What about the amount_untaxed, amount_tax, amount_total fields repeated 2 times? -- https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030 Your team Purchase Core Editors is requested to review the proposed merge of lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl
You're right. I don't know how can I overpassed that! I have corrected. Thanks. Regards. -- https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030 Your team Purchase Core Editors is requested to review the proposed merge of lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl
Review: Approve code review no test Thanks Pedro, I had long wanted to propose this module on the branch. -- https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1291903] Re: [OCB] sale_stock: property_ids set on procurement.order
** Changed in: ocb-addons Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1291903 Title: [OCB] sale_stock: property_ids set on procurement.order Status in OpenERP Community Backports (Addons): Fix Released Bug description: The fix for https://bugs.launchpad.net/openobject-addons/+bug/1083077 merge in ocb-addons at http://bazaar.launchpad.net/~ocb/ocb- addons/7.0/revision/9733 has an issue : the field which is added in the changeset is defined in mrp, which is not a dependency of sale_stock. As a result, the tests generate WARNING : 2014-03-13 09:53:19,607 12269 WARNING test_ocb70 openerp.osv.orm: No such field(s) in model procurement.order: property_ids. and the runbot branch is orange. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1291903/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1079548] Re: Message field(char) too short to allow long messages
** Changed in: ocb-addons/7.0
Status: Fix Committed = Fix Released
--
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Addons).
https://bugs.launchpad.net/bugs/1079548
Title:
Message field(char) too short to allow long messages
Status in OpenERP Community Backports (Addons):
Fix Released
Status in OpenERP Community Backports (Addons) 7.0 series:
Fix Released
Status in OpenERP Addons (modules):
Fix Committed
Bug description:
On trunk build 14921
Following error occur when trying to convert from Quotation -- Sales Order
(to confirm order, given my product has a very long name)
pre
File /opt/openerp7/server/openerp/tools/safe_eval.py, line 242, in
safe_eval
return eval(test_expr(expr, _SAFE_OPCODES, mode=mode), globals_dict,
locals_dict)
File , line 1, in module
File /opt/openerp7/server/openerp/osv/orm.py, line 375, in function_proxy
return attr(self._cr, self._uid, [self._id], *args, **kwargs)
File /opt/openerp7/addons/procurement/procurement.py, line 255, in
check_make_to_stock
ok = ok and self._check_make_to_stock_product(cr, uid, procurement,
context)
File /opt/openerp7/addons/procurement/procurement.py, line 396, in
_check_make_to_stock_product
cr.execute('update procurement_order set message=%s where id=%s',
(message, procurement.id))
File /opt/openerp7/server/openerp/sql_db.py, line 162, in wrapper
return f(self, *args, **kwargs)
File /opt/openerp7/server/openerp/sql_db.py, line 227, in execute
res = self._obj.execute(query, params)
DataError: value too long for type character varying(124)
/pre
Steps:
=
1. New Quotation
2. Add product with very long name
3. Confirm order
Problem:
In procurement.py -- object = procurement.order, field message has length
only 124, which I guess not enough when the message is logged.
Solution:
I try changing length to 1024 and repeat the process. It works now.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1079548/+subscriptions
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 691534] Re: [trunk] Inventory analysis displays lines with quantity is zero
** Changed in: ocb-addons/7.0 Assignee: Lionel Sausin - Numérigraphe (lionel-sausin) = Numérigraphe (numerigraphe-team) -- You received this bug notification because you are a member of Stock and Logistic Core Editors, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/691534 Title: [trunk] Inventory analysis displays lines with quantity is zero Status in OpenERP Community Backports (Addons): Fix Committed Status in OpenERP Community Backports (Addons) 7.0 series: Fix Committed Status in OpenERP Addons (modules): Won't Fix Bug description: Revno 4028 On Inventory analysis, tree view displays lines with Quantity = 0. To reproduce this bug : On installation with demo data, create a new 'Internal move' with one line : Product : [RAM] DDR 256MB PC400 Quantity : 39.00 Source Location : Shelf 1 Destination Location : Shelf 2 and process it. Then, open Inventory analysis and check 'Group By' in this order : Location / Product. Open the Shelf 1 line, then search the product [RAM] DDR 256MB PC400. The displaying line is a line with 0 in quantity row. Is it normal or is it a displaying bug ? IMHO, it's a displaying bug, we wan't see the product which are not present in stock. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/691534/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-web/7.0-hide-oe_read_only into lp:ocb-web
Review: Disapprove I'm abandoning this proposal, but not deleting it to keep the interesting comments. I can't mark it rejected myself but feel free to do it. -- https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-hide-oe_read_only/+merge/213016 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/add-crm-claim-rma-repair into lp:openerp-rma
The proposal to merge lp:~akretion-team/openerp-rma/add-crm-claim-rma-repair into lp:openerp-rma has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~akretion-team/openerp-rma/add-crm-claim-rma-repair/+merge/215976 -- https://code.launchpad.net/~akretion-team/openerp-rma/add-crm-claim-rma-repair/+merge/215976 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma
Review: Approve code review, no tests -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/rma-fix-lp1311520_rde into lp:openerp-rma
Review: Approve code review, no tests Hi Romain, Thanks for this improvements. LGTM ! Regards, -- https://code.launchpad.net/~camptocamp/openerp-rma/rma-fix-lp1311520_rde/+merge/216839 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma-fix-lp1317045_rde into lp:openerp-rma
Review: Approve code review + test Hi Romain, Thanks for the fix, after testing and looking with other customers uses cases, I approve this improvement. Regards -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma-fix-lp1317045_rde/+merge/218595 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays into lp:hr-timesheet
The proposal to merge lp:~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays into lp:hr-timesheet has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124 -- https://code.launchpad.net/~camptocamp/hr-timesheet/7.0-port-hr_timesheet_holidays/+merge/162124 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge into lp:department-mgmt
Review: Approve
I believe this covers the distinct user cases better than Jordi's MP.
So I would prefer for this one to be merged.
Anyway, I invited him for this review.
On the syle side, it's just a personal preference, but for:
employee_ids = employee_obj.search(cr, uid,
[('user_id','=', uid)],
context=context)
I usually prefer:
employee_ids = employee_obj.search(
cr, uid,[('user_id','=', uid)], context=context)
--
https://code.launchpad.net/~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge/+merge/218807
Your team Department Core Editors is subscribed to branch lp:department-mgmt.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-web/7.0-hide-oe_read_only into lp:ocb-web
Lionel, I rejected this following your comments. Thanks -- https://code.launchpad.net/~numerigraphe-team/ocb-web/7.0-hide-oe_read_only/+merge/213016 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge into lp:department-mgmt
The proposal to merge lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge into lp:department-mgmt has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge/+merge/218807 -- https://code.launchpad.net/~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge/+merge/218807 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic into lp:department-mgmt
Review: Disapprove code review + test Hi, As this MP :https://code.launchpad.net/~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge/+merge/218807 Has been merged, I mark this one as disapproved. Reply in there if anything wrong with that. Regards, Joël -- https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic/+merge/212299 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic into lp:department-mgmt
The proposal to merge lp:~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic into lp:department-mgmt has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic/+merge/212299 -- https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfixes_analytic/+merge/212299 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/project-service/project_service_project_closing_vre into lp:project-service
Vincent Renaville@camptocamp has proposed merging
lp:~camptocamp/project-service/project_service_project_closing_vre into
lp:project-service.
Requested reviews:
Project Core Editors (project-core-editors)
For more details, see:
https://code.launchpad.net/~camptocamp/project-service/project_service_project_closing_vre/+merge/219388
Hello,
The module project_closing, allow that an analytic account related to a project
is automatically closed.
This feature is to prevent a person to enter time-sheet on a closed project.
--
https://code.launchpad.net/~camptocamp/project-service/project_service_project_closing_vre/+merge/219388
Your team Project Core Editors is requested to review the proposed merge of
lp:~camptocamp/project-service/project_service_project_closing_vre into
lp:project-service.
=== added directory 'project_closing'
=== added file 'project_closing/__init__.py'
--- project_closing/__init__.py 1970-01-01 00:00:00 +
+++ project_closing/__init__.py 2014-05-13 15:08:57 +
@@ -0,0 +1,25 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#Copyright (C) 2013 Camptocamp Author Vincent Renaville
+#
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import project
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'project_closing/__openerp__.py'
--- project_closing/__openerp__.py 1970-01-01 00:00:00 +
+++ project_closing/__openerp__.py 2014-05-13 15:08:57 +
@@ -0,0 +1,35 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#Copyright (C) 2013 Camtpcaomp
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+{
+name: Project closing,
+version: 1.1dr,
+author: Camptocamp,
+website: http://www.camptocamp.com;,
+category: project Management,
+depends: [project],
+description: \
+Automatic account analytic closing when related project is closed.
+In case of multiple analytic account on a same project, a warning is raise.
+,
+data: [],
+'installable': True,
+}
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
=== added file 'project_closing/project.py'
--- project_closing/project.py 1970-01-01 00:00:00 +
+++ project_closing/project.py 2014-05-13 15:08:57 +
@@ -0,0 +1,35 @@
+# -*- coding: utf-8 -*-
+from osv import orm
+
+
+class project_project(orm.Model):
+_inherit = 'project.project'
+
+def set_done(self, cr, uid, ids, context=None):
+## We will close related analytic account
+analytic_account_obj = self.pool.get('account.analytic.account')
+if isinstance(ids, (int, long)):
+ids = [ids]
+projects = self.browse(cr, uid, ids, context=context)
+for project in projects:
+analytic_account_obj.write(cr, uid,
+ [project.analytic_account_id.id],
+ {'state': 'close'},
+ context=context)
+return super(project_project, self).set_done(cr, uid, ids,
+ context=context)
+
+def set_open(self, cr, uid, ids, context=None):
+## We will re-open related analytic account
+analytic_account_obj = self.pool.get('account.analytic.account')
+if isinstance(ids, (int, long)):
+
[Openerp-community-reviewer] [Bug 1290820] Re: report_webkit not thread-safe: risk of document corruption
Here is the second MP: https://code.launchpad.net/~camptocamp/openobject- addons/7.0-fix-1319109/+merge/219406 ** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New ** Branch linked: lp:~camptocamp/openobject-addons/7.0-fix-1319095 -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1290820 Title: report_webkit not thread-safe: risk of document corruption Status in OpenERP Community Backports (Addons): New Status in OpenERP Community Backports (Addons) 7.0 series: New Status in OpenERP Addons (modules): New Bug description: While generating a high number of PDF (20 000) with report_webkit, we got a PDF generated with wrong content. We tracked down the bug being a collision on temporary HTML files created by this module. Our hotfix is: http://hastebin.com/yiregeqoso.diff To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1290820/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
