[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls into lp:report-print-send
Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls into lp:report-print-send. Requested reviews: Report Printing and Sending Core Editors (report-print-send-core-editors) For more details, see: https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls/+merge/219787 Improve the preference views of base_report_to_printer: Menus: - move the printing settings to a menu of their own in the settings page (ie. move one level up) - add a shortcut to the list of reports to the printing menu Printing preferences: - fix the preference view (the group was inserted inside another group, now it's cleanly inserted at the end) - add the printing preferences to the user prefs (preferences in the menu on the far upper-right corner) -- https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls/+merge/219787 Your team Report Printing and Sending Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls into lp:report-print-send. === modified file 'base_report_to_printer/printing_view.xml' --- base_report_to_printer/printing_view.xml 2013-10-01 13:04:19 + +++ base_report_to_printer/printing_view.xml 2014-05-16 07:25:13 + @@ -2,7 +2,7 @@ openerp data -menuitem name=Printing id=menu_printing_main parent=base.menu_config groups=res_groups_printingprintoperator0/ +menuitem name=Printing id=menu_printing_main parent=base.menu_administration groups=res_groups_printingprintoperator0/ record model=ir.ui.view id=view_printing_printer_form field name=nameprinting.printer.form/field @@ -76,12 +76,27 @@ field name=modelres.users/field field name=inherit_id ref=base.view_users_form / field name=arch type=xml -field name=lang position=after - group -field name=printing_action/ -field name=printing_printer_id/ - /group -/field +page string=Preferences + group name=printing +field name=printing_action/ +field name=printing_printer_id/ + /group +/page + /field +/record + +!-- My Preferences -- +record model=ir.ui.view id=view_printing_users_prefs + field name=nameres.users.form.printing/field + field name=modelres.users/field + field name=inherit_id ref=base.view_users_form_simple_modif / + field name=arch type=xml +footer position=before + group string=Printing name=printing +field name=printing_action/ +field name=printing_printer_id/ + /group +/footer /field /record @@ -91,10 +106,11 @@ field name=modelprinting.report.xml.action/field field name=arch type=xml form string=Report Printing Actions - field name=user_id/ - label string=/ - field name=action/ - field name=printer_id select=1/ + group col=2 + field name=user_id/ + field name=action/ + field name=printer_id select=1/ + /group /form /field /record @@ -110,5 +126,9 @@ /field /record +!-- Add a shorcut to Actions/Report in the Printing menu -- +menuitem id=menu_printing_reports + parent=menu_printing_main + action=base.ir_action_report_xml/ /data /openerp -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls into lp:report-print-send
Review: Approve code review LGTM. Regards. -- https://code.launchpad.net/~numerigraphe-team/report-print-send/7.0-improve-prefs-ui-ls/+merge/219787 Your team Report Printing and Sending Core Editors is subscribed to branch lp:report-print-send. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1256199] Re: [7.0] Ubuntu 13.10 Conflict with python package resource
The branches attached seem to work, is it worth merging them in OCB ? ** Also affects: ocb-addons Importance: Undecided Status: New ** Also affects: ocb-server Importance: Undecided Status: New ** Also affects: ocb-server/7.0 Importance: Undecided Status: New ** Also affects: ocb-addons/7.0 Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1256199 Title: [7.0] Ubuntu 13.10 Conflict with python package resource Status in OpenERP Community Backports (Addons): New Status in OpenERP Community Backports (Addons) 7.0 series: New Status in OpenERP Community Backports (Server): New Status in OpenERP Community Backports (Server) 7.0 series: New Status in OpenERP Addons (modules): Confirmed Status in OpenERP Server: New Bug description: Hello. RUn openerp 7.0 on Ubuntu 13.10. 2013-11-29 05:04:54,408 23539 WARNING ? openerp.modules.module: Ambiguous import: the OpenERP module `resource` is shadowed by another module (available at /usr/lib/python2.7/lib-dynload/resource.x86_64-linux-gnu.so). To import it, use `import openerp.addons.module.`. It only appear with workers I tried to patch with: === modified file 'resource/__init__.py' --- resource/__init__.py 2011-01-14 00:11:01 + +++ resource/__init__.py 2013-11-29 05:04:23 + @@ -19,8 +19,8 @@ # ## -import resource -import faces +from . import resource +from . import faces # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: === modified file 'resource/faces/__init__.py' --- resource/faces/__init__.py2011-01-14 00:11:01 + +++ resource/faces/__init__.py2013-11-29 04:57:46 + @@ -25,6 +25,6 @@ STRICT, SLOPPY, SMART, Multi, YearlyMax, WeeklyMax, MonthlyMax, \ DailyMax, VariableLoad -from resource import Resource +from .resource import Resource # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: === modified file 'resource/faces/task.py' --- resource/faces/task.py2013-05-14 14:28:37 + +++ resource/faces/task.py2013-11-29 05:04:52 + @@ -33,7 +33,7 @@ #@ Imports #@+node: Imports import pcalendar -import resource +from . import resource import types import sys import datetime But the message still appear. I made an rgrep on addons and resource is only there: ./project_long_term/project_long_term.py:25:from openerp.addons.resource.faces import task as Task ./resource/__init__.py:22:import resource ./resource/faces/task.py:36:import resource ./resource/faces/__init__.py:28:from resource import Resource ./project/project.py:32:from openerp.addons.resource.faces import task as Task ./project/project.py:455:result = from openerp.addons.resource.faces import *\n The module: resource/ should be called in a more particular way (for v8.0) but for this version it is really painfull have this kind of warnings in an stable version I think. It is not happening in Trunk. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1256199/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error into lp:ocb-addons/6.1
Yann Papouin has proposed merging
lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error into
lp:ocb-addons/6.1.
Requested reviews:
OpenERP Community Backports (ocb)
Related bugs:
Bug #1008513 in OpenERP Community Backports (Addons): [6.1]document_webdav -
pywebdav import error if pywebdav=0.9.8
https://bugs.launchpad.net/ocb-addons/+bug/1008513
For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794
Backport from 7.0 needed to run OpenERP 6.1 with DAV support on latest Linux
distribution
--
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794
Your team OpenERP Community Backports is requested to review the proposed merge
of lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error into
lp:ocb-addons/6.1.
=== modified file 'document_webdav/dav_fs.py'
--- document_webdav/dav_fs.py 2011-12-19 16:54:40 +
+++ document_webdav/dav_fs.py 2014-05-16 08:45:40 +
@@ -27,13 +27,19 @@
import netsvc
import urlparse
-
-from DAV.constants import COLLECTION #, OBJECT
-from DAV.errors import DAV_Error, DAV_Forbidden, DAV_NotFound
-from DAV.iface import dav_interface
import urllib
-from DAV.davcmd import copyone, copytree, moveone, movetree, delone, deltree
+try:
+from pywebdav.lib.constants import COLLECTION # , OBJECT
+from pywebdav.lib.errors import DAV_Error, DAV_Forbidden, DAV_NotFound
+from pywebdav.lib.iface import dav_interface
+from pywebdav.lib.davcmd import copyone, copytree, moveone, movetree, delone, deltree
+except ImportError:
+from DAV.constants import COLLECTION #, OBJECT
+from DAV.errors import DAV_Error, DAV_Forbidden, DAV_NotFound
+from DAV.iface import dav_interface
+from DAV.davcmd import copyone, copytree, moveone, movetree, delone, deltree
+
from cache import memoize
from tools import misc
=== modified file 'document_webdav/webdav.py'
--- document_webdav/webdav.py 2011-12-19 16:54:40 +
+++ document_webdav/webdav.py 2014-05-16 08:45:40 +
@@ -30,11 +30,13 @@
from tools.translate import _
try:
+from pywebdav.lib import utils
+from pywebdav.lib.propfind import PROPFIND
+from pywebdav.lib.report import REPORT
+except ImportError:
from DAV import utils
from DAV.propfind import PROPFIND
from DAV.report import REPORT
-except ImportError:
-raise osv.except_osv(_('PyWebDAV Import Error!'), _('Please install PyWebDAV from http://code.google.com/p/pywebdav/downloads/detail?name=PyWebDAV-0.9.4.tar.gzcan=2q=/'))
import tools
=== modified file 'document_webdav/webdav_server.py'
--- document_webdav/webdav_server.py 2012-02-09 09:06:22 +
+++ document_webdav/webdav_server.py 2014-05-16 08:45:40 +
@@ -38,7 +38,6 @@
import netsvc
from dav_fs import openerp_dav_handler
from tools.config import config
-from DAV.WebDAVServer import DAVRequestHandler
from service import http_server
from service.websrv_lib import FixSendError, HttpOptions
from BaseHTTPServer import BaseHTTPRequestHandler
@@ -48,13 +47,20 @@
import time
from string import atoi
import addons
-from DAV.utils import IfParser, TagList
-from DAV.errors import DAV_Error, DAV_Forbidden, DAV_NotFound
-from DAV.propfind import PROPFIND
-# from DAV.constants import DAV_VERSION_1, DAV_VERSION_2
from xml.dom import minidom
from redirect import RedirectHTTPHandler
+try:
+from pywebdav.lib.WebDAVServer import DAVRequestHandler
+from pywebdav.lib.utils import IfParser, TagList
+from pywebdav.lib.errors import DAV_Error, DAV_Forbidden, DAV_NotFound
+from pywebdav.lib.propfind import PROPFIND
+except ImportError:
+from DAV.WebDAVServer import DAVRequestHandler
+from DAV.utils import IfParser, TagList
+from DAV.errors import DAV_Error, DAV_Forbidden, DAV_NotFound
+from DAV.propfind import PROPFIND
+
khtml_re = re.compile(r' KHTML/([0-9\.]+) ')
def OpenDAVConfig(**kw):
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error into lp:ocb-addons/6.1
Review: Needs Fixing code review I think you may keep osv.except_osv in case both imports fail, or put an external dependency on manifest. Regards. -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1008513] Re: [6.1]document_webdav - pywebdav import error if pywebdav=0.9.8
** Summary changed: - document_webdav - pywebdav import error if pywebdav=0.9.8 + [6.1]document_webdav - pywebdav import error if pywebdav=0.9.8 ** Also affects: ocb-addons Importance: Undecided Status: New ** Changed in: ocb-addons Importance: Undecided = Low ** Changed in: ocb-addons Status: New = Fix Committed ** Changed in: ocb-addons Assignee: (unassigned) = Yann Papouin (yann-papouin) ** Also affects: ocb-addons/6.1 Importance: Undecided Status: New ** Changed in: ocb-addons/6.1 Status: New = Fix Committed ** Changed in: ocb-addons/6.1 Importance: Undecided = Low ** Changed in: ocb-addons/6.1 Assignee: (unassigned) = Yann Papouin (yann-papouin) ** Changed in: ocb-addons Status: Fix Committed = Won't Fix ** Changed in: ocb-addons Status: Won't Fix = Invalid -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1008513 Title: [6.1]document_webdav - pywebdav import error if pywebdav=0.9.8 Status in OpenERP Community Backports (Addons): Invalid Status in OpenERP Community Backports (Addons) 6.1 series: Fix Committed Status in OpenERP Addons (modules): Confirmed Bug description: starting from pywebdav 0.9.8 you should import from pywebdav.lib (see http://pypi.python.org/pypi/PyWebDAV). Find the right patch attached To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1008513/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_picking_line_description_7 into lp:stock-logistic-flows
Alex Comba - Agile BG has proposed merging
lp:~agilebg/stock-logistic-flows/adding_picking_line_description_7 into
lp:stock-logistic-flows.
Commit message:
[ADD] module picking_line_description
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more details, see:
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_picking_line_description_7/+merge/219800
On the basis of 'invoice_line_description' and 'sale_line_description' modules,
previously released, I created 'picking_line_description' which allows to use
only the product description on the picking order lines. To do so, the user has
to belong to group_use_product_description_per_picking_line.
This is possible by selecting the related option in the following menu:
Settings -- Configuration -- Warehouse -- Products
--
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_picking_line_description_7/+merge/219800
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of lp:~agilebg/stock-logistic-flows/adding_picking_line_description_7
into lp:stock-logistic-flows.
=== added directory 'picking_line_description'
=== added file 'picking_line_description/__init__.py'
--- picking_line_description/__init__.py 1970-01-01 00:00:00 +
+++ picking_line_description/__init__.py 2014-05-16 09:05:37 +
@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alex Comba alex.co...@agilebg.com
+#Copyright (C) 2014 Agile Business Group sagl
+#(http://www.agilebg.com)
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as published
+#by the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+from . import res_config
+from . import stock
=== added file 'picking_line_description/__openerp__.py'
--- picking_line_description/__openerp__.py 1970-01-01 00:00:00 +
+++ picking_line_description/__openerp__.py 2014-05-16 09:05:37 +
@@ -0,0 +1,49 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alex Comba alex.co...@agilebg.com
+#Copyright (C) 2014 Agile Business Group sagl
+#(http://www.agilebg.com)
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as published
+#by the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+{
+'name': Picking line description,
+'version': '0.1',
+'category': 'Warehouse Management',
+'description':
+This module allows to use only the product description on the picking
+order lines. To do so, the user has to belong to
+group_use_product_description_per_picking_line.
+This is possible by selecting the related option in the following menu:
+
+Settings -- Configuration -- Warehouse -- Products
+,
+'author': 'Agile Business Group',
+'website': 'http://www.agilebg.com',
+'license': 'AGPL-3',
+'depends': [
+'stock',
+],
+'data': [
+'security/stock_security.xml',
+'res_config_view.xml',
+'stock_view.xml',
+],
+'test': [
+'test/picking_line_description.yml',
+],
+'installable': True
+}
=== added directory 'picking_line_description/i18n'
=== added file 'picking_line_description/i18n/it.po'
--- picking_line_description/i18n/it.po 1970-01-01 00:00:00 +
+++ picking_line_description/i18n/it.po 2014-05-16 09:05:37 +
@@ -0,0 +1,42 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+# * picking_line_description
+#
+msgid
+msgstr
+Project-Id-Version: OpenERP Server 7.0\n
+Report-Msgid-Bugs-To: \n
+POT-Creation-Date: 2014-05-13
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/account-invoicing/7.0-account_cash_discount into lp:account-invoicing
Hi Holger, good work. Question. Is there any integration between this cash discount and payment orders? When i make a payment order on time then discount can be extracted. When im passed my discount days it can't. Curious if this exists or is in planning. Thanks. -- https://code.launchpad.net/~therp-nl/account-invoicing/7.0-account_cash_discount/+merge/203359 Your team Account Core Editors is requested to review the proposed merge of lp:~therp-nl/account-invoicing/7.0-account_cash_discount into lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error into lp:ocb-addons/6.1
You're right. Fixed! -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error into lp:ocb-addons/6.1
Review: Approve code review Thanks for the changes! Regards. -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/add-base_partner_merge into lp:partner-contact-management
The proposal to merge lp:~camptocamp/partner-contact-management/add-base_partner_merge into lp:partner-contact-management has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616 -- https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/add-base_partner_merge into lp:partner-contact-management
As Maxime's remarks should have been addressed, I proceed with the merge. Thank you -- https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/add-base_partner_merge into lp:partner-contact-management
The proposal to merge lp:~camptocamp/partner-contact-management/add-base_partner_merge into lp:partner-contact-management has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616 -- https://code.launchpad.net/~camptocamp/partner-contact-management/add-base_partner_merge/+merge/189616 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error into lp:ocb-addons/6.1
Review: Approve Thanks, I was aware of the problem and the fix looks good. -- https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma
Review: Approve code review ok, thanks -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma
Review: Needs Fixing nitpicking Looks good from code point of view, not tested because I don't use this module. Now for the nitpicking: - multiline docstrings should have the short description on the first line, and the details in the following lines. This lets IDEs show the first line as a quick help. - please don't initialize the context if you don't use it - it's ok to pass None to other methods. -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma
Thanks Lionel, I updated it. -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma
Review: Approve code review, not test -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into lp:purchase-wkfl
Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into
lp:purchase-wkfl.
Requested reviews:
Romain Deheele - Camptocamp (romaindeheele): code review
Loïc Bellier - Numérigraphe (lb-b)
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit/+merge/219829
Here is a new module to block purchase orders when the budget is at risk of
being exhausted.
Only validated budgets are checked.
Also, only invoiced purchases are counted (because only invoices are counted in
the budget). I'll soon be publishing an additional module to count draft
purchases in the budgets too.
Unfortunately, no automatic test bundled because the account_budget does not
provide any either.
--
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit/+merge/219829
Your team Purchase Core Editors is requested to review the proposed merge of
lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into
lp:purchase-wkfl.
=== added directory 'purchase_budget_limit'
=== added file 'purchase_budget_limit/__init__.py'
--- purchase_budget_limit/__init__.py 1970-01-01 00:00:00 +
+++ purchase_budget_limit/__init__.py 2014-05-16 12:31:09 +
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##
+#
+#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import wizard
+from . import purchase
=== added file 'purchase_budget_limit/__openerp__.py'
--- purchase_budget_limit/__openerp__.py 1970-01-01 00:00:00 +
+++ purchase_budget_limit/__openerp__.py 2014-05-16 12:31:09 +
@@ -0,0 +1,54 @@
+# -*- coding: utf-8 -*-
+##
+#
+#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': Block over-budget Purchase Orders,
+'version': '1.1',
+'author': u'Numérigraphe SARL',
+'category': 'Purchase Management',
+'description': '''
+Let Budget managers define limits on Purchase Orders
+
+
+When new Purchase Orders are being confirmed, this module will put them in a
+special state if the remaining budget is not sufficient to pay the expected
+invoice in one of the Budget Lines in the same period.
+
+Purchase managers can :
+- either wait until the financial situation changes
+- or override the budget and approve the Purchase Order
+- or cancel the Purchase Order.
+''',
+'depends': ['account_budget', 'purchase'],
+'data': [
+'purchase_workflow.xml',
+'purchase_view.xml',
+'wizard/purchase_budget_view.xml',
+'security/ir.model.access.csv',
+],
+'test': [
+# TODO add an automatic test:
+# - create a budget line for 1 EUR
+# - create a PO for 100 EUR and validate it, check it's not blocked
+# - create a budget line for 150 EUR
+# - create a PO for 200 EUR and validate it, check it's blocked
+# - override the budget and check the PO is validated
+]
+}
=== added directory 'purchase_budget_limit/i18n'
=== added file 'purchase_budget_limit/i18n/fr.po'
--- purchase_budget_limit/i18n/fr.po 1970-01-01 00:00:00 +
+++
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into lp:purchase-wkfl
Review: Needs Fixing code review Hi, Several flake8 suggestions: 7.0-add-purchase_budget_limit/purchase_budget_limit/purchase.py:69:25: E128 continuation line under-indented for visual indent 7.0-add-purchase_budget_limit/purchase_budget_limit/purchase.py:76:30: E128 continuation line under-indented for visual indent 7.0-add-purchase_budget_limit/purchase_budget_limit/purchase.py:79:37: E127 continuation line over-indented for visual indent 7.0-add-purchase_budget_limit/purchase_budget_limit/purchase.py:80:20: E122 continuation line missing indentation or outdented 7.0-add-purchase_budget_limit/purchase_budget_limit/wizard/purchase_budget.py:42:13: E128 continuation line under-indented for visual indent 7.0-add-purchase_budget_limit/purchase_budget_limit/wizard/purchase_budget.py:61:6: E121 continuation line indentation is not a multiple of four -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit/+merge/219829 Your team Purchase Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp into lp:hr-timesheet
Review: Needs Information code review Hello Pedro, Can you explain the use case where you need to enter time on tasks in other state than done? Domains such as this one may vary from a company to another, but I thought allowing only open tasks was a good default? Thanks! -- https://code.launchpad.net/~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp/+merge/219821 Your team HR Core Editors is requested to review the proposed merge of lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp into lp:hr-timesheet. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into lp:purchase-wkfl
PEP8 compliance fixed. -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit/+merge/219829 Your team Purchase Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma
The proposal to merge lp:~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde into lp:openerp-rma has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666 -- https://code.launchpad.net/~camptocamp/openerp-rma/7.0-crm_claim_rma_auto_set_warranty-rde/+merge/218666 Your team OpenERP RMA is subscribed to branch lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp into lp:hr-timesheet
I think now in two possible scenarios: - Bad configured project provokes that initial state of a task is not set. - There is a third person that inputs all times. I'm thinking now that tasks can be also even in done state, because inputation is done afterwards. Do you think there is a better way? Regards. -- https://code.launchpad.net/~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp/+merge/219821 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp into lp:hr-timesheet
Review: Needs Fixing In that case I would change de domain in an additional module that is perhaps specific to your use case, because I believe current users of hr_timesheet_task expect to see only open tasks. -- https://code.launchpad.net/~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp/+merge/219821 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl
The proposal to merge lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl
The proposal to merge lp:~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep into lp:purchase-wkfl has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-merge-po-hooks-lep/+merge/216745 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp into lp:hr-timesheet
I have reverted back to original domain. Please review rest of the changes. Regards. -- https://code.launchpad.net/~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp/+merge/219821 Your team HR Core Editors is requested to review the proposed merge of lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp into lp:hr-timesheet. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp into lp:hr-timesheet
The proposal to merge lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp into lp:hr-timesheet has been updated. Description changed to: [FIX] hr_timesheet_sheet: Fix error if there is no project associated to task. [FIX] hr_timesheet_sheet: Tree view for hr.analytic.timesheet inherited instead of overwritten, to allow other modules to modifiy this view (for example, hr_timesheet_department). [IMP] hr_timesheet_sheet: Remove obsolete type labels on XML views. For more details, see: https://code.launchpad.net/~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp/+merge/219821 -- https://code.launchpad.net/~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp/+merge/219821 Your team HR Core Editors is requested to review the proposed merge of lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp into lp:hr-timesheet. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix into lp:openerp-reporting-engines
Review: Approve code review, no test LGTM Cheers. -- https://code.launchpad.net/~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix/+merge/219267 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:openerp-reporting-engines. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl
Review: Needs Fixing Please don't add AUTHOR.txt file and add Contributors in __openerp__.py For who did exaclty what there is the CVS -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into lp:purchase-wkfl
Review: Needs Fixing code review, test Thanks, other details: -l.454 s/dificulties/difficulties -Maybe you could precise that we need to check Analytic accounting for purchases in settings/configuration/Purchases or check it directly during addon install. Otherwise, it seems ok. Romain -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit/+merge/219829 Your team Purchase Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/7.0-bug-1169074-pricelist-category-depth into lp:ocb-addons
It does not seems to be simple to parameterize this query. Maybe this change could be made in another proposal and this one could be merged now ? -- https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1169074-pricelist-category-depth/+merge/210163 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:server-env-tools
The proposal to merge lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:server-env-tools has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530 -- https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:server-env-tools
The proposal to merge lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:server-env-tools has been updated. Commit Message changed to: [ADD] Regression Tests; [FIX] Uncaught error is raised when the admin user tries to connect with a bad login and his password; [ADD] Test for the fixed bug; For more details, see: https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530 -- https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:server-env-tools
Already merged -- https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase into lp:account-financial-tools
Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase
into lp:account-financial-tools.
Requested reviews:
Loïc Bellier - Numérigraphe (lb-b)
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase/+merge/219849
Add account_budget_purchase: new module to let budget managers optionally count
purchase orders not yet invoiced in their budgets.
--
https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase/+merge/219849
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
=== added directory 'account_budget_purchase'
=== added file 'account_budget_purchase/__init__.py'
--- account_budget_purchase/__init__.py 1970-01-01 00:00:00 +
+++ account_budget_purchase/__init__.py 2014-05-16 14:18:57 +
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+##
+#
+#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+import account_budget
=== added file 'account_budget_purchase/__openerp__.py'
--- account_budget_purchase/__openerp__.py 1970-01-01 00:00:00 +
+++ account_budget_purchase/__openerp__.py 2014-05-16 14:18:57 +
@@ -0,0 +1,52 @@
+# -*- coding: utf-8 -*-
+##
+#
+#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': Take uninvoiced Purchase Orders into account in Budget Lines,
+'version': '1.0',
+'author': u'Numérigraphe SARL',
+'category': 'Generic Modules/Accounting',
+'description': '''
+Take pending Purchase Orders into account in Budget Lines
+=
+Normally the Budgets are based on the Entries of General Accounting, and may be
+filtered by Analytic Account.
+The problem for purchase Budgets is that invoices may come in very late in the
+process. This often hides future problems from the budget managers.
+
+To help with this problem, this module lets Budget Lines include the amounts
+of Purchase Order Lines that have been confirmed but not yet invoiced.''',
+'depends': ['account_budget', 'purchase'],
+'data': [
+'account_budget_view.xml',
+],
+'test': [
+# TODO add an automatic test:
+# - create 3 identical budget lines:
+# - line A ignoring POs
+# - line B adding POs to amount
+# - line C subtracting POs from amount
+# - record the initial real amount of line A
+# - create a PO for 100 EUR and validate it
+# - check that the amount of line A is unchanged
+# - check that the amount of line B is A+100
+# - check that the amount of line C is A-100
+]
+}
=== added file 'account_budget_purchase/account_budget.py'
--- account_budget_purchase/account_budget.py 1970-01-01 00:00:00 +
+++ account_budget_purchase/account_budget.py 2014-05-16 14:18:57 +
@@ -0,0 +1,90 @@
+# -*- coding: utf-8 -*-
+##
+#
+#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#This program is free software:
Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/purchase-wkfl/pallet-delivery into lp:purchase-wkfl
Review: Needs Fixing MP Description : '' MP Commit message : '' __openerp__.py 'description': , My remarks : '''?''' Please fix this lack of information about this module -- https://code.launchpad.net/~savoirfairelinux-openerp/purchase-wkfl/pallet-delivery/+merge/216325 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into lp:purchase-wkfl
Review: Approve code review Ok for me too ! -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit/+merge/219829 Your team Purchase Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:server-env-tools
The proposal to merge lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:server-env-tools has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530 -- https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:server-env-tools
Please next time explain what you do in your commit message. Fix bug XY is not really understandable at a first glance. To link the bug --fixes=lp:XY is there -- https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp into lp:hr-timesheet
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp/+merge/219821 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:hr-timesheet. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase into lp:account-financial-tools
Review: Approve code review -- https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase/+merge/219849 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size into lp:report-print-send
Review: Needs Information Wouldn't it be cleaner to add a hook in report_webkit to create the command ? -- https://code.launchpad.net/~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size/+merge/202892 Your team Report Printing and Sending Core Editors is subscribed to branch lp:report-print-send. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] OCA LP Project migration to Github
Dear community, After the announcement of the brand new odoo instead of OpenERP, the main changes for contributors currently is the switch to Github. As I know, most of you waited for such a move ! Now it's done :) Though it remain a quite huge question : How the hell do we, as the community, will manage this switch ? I know there is lots of side questions (like making one repository per module, using subtree and many more). I see those options: a) Move all projects from LP to Github, but only the 7.0 series to create only the master branch. Every devs should create the pull request needed if they want their LP MP to be shown as pull request on github. Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Easy, quick,simple to understand, only still active MP will be ported by each devs - = Every devs will have to rebuild the pull request, loss of review infos in the pull request (though people can copy/paste the link to LP) b) Move all projects from LP to Github and try to take all branches related to a project using [1], create the master branch from the 7.0 series. Then all devs will have to take back his branch, branch by branch, in his own name (that process [1] was use to move openstack to github). Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Keep all branches of all projects - = Doesn't help to take back the MP as pull request, will let lots of obsolete branches c) Try to immediately split repository to have one repo by module, all owned by the OCA project (only one project, many, many repos). Just making one repo by module. Then we can have those many repos grouped by topic using submodule (here an example: https://github.com/camptocamp/puppet-modules). By topic I mean Apps (like sale, purchase, ..). + = We have one repo by module and start clean on github - = Not that easy to split, not clear exactly how to do that, we have the risk that by the time we figure that out we remain on LP for quite a while, change the architecture and tools all at once. My suggestion to allow a fast move forward is option a) as the following: 1) Take all OCA projects on LP and create one under the OCA umbrella on github 2) Then I suggest to create the master branch on Github from the 7.0 series on LP. Older one remain on LP only. 3) All current MPs must be made as pull request by his owner on GitHub to be merged. 4) All the 7.0 series starts on Github as soon as we have build them all (should not take more than 1 or 2 days to achieve. The older one (5, 6, 6.1) remain on LP. 5) For 8.0, we starts creating all needed sub-module repo Mains args: * Easy and fast * Make a smooth transition as projects are kept, just moved on github * Avoid having old MP or obsolete branches in the OCA umbrella * For 7.0 serie we have everything on github, so we avoid working with both git and bzr * For older serie we keep all on bzr, while future v8.0 will have a clean one repo by module solution Who's in favor of which option here (a,b,c) ? Any others I missed ? Thanks for your vote ! Please try to be as short as possible on your answer, so we can see who's voting for which option :) Best regards, Joël [1] https://github.com/termie/lp2gh/blob/master/docs/moving_branches.rst -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/server-env-tools/7.0-fix-1319391 into lp:server-env-tools
Review: Approve code review, no test LGTM Thanks for the tests -- https://code.launchpad.net/~sylvain-legal/server-env-tools/7.0-fix-1319391/+merge/219530 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/openerp-product-attributes/7.0-add-bremskrel-modules into lp:openerp-product-attributes
Loïc Bellier - Numérigraphe has proposed merging
lp:~numerigraphe-team/openerp-product-attributes/7.0-add-bremskrel-modules into
lp:openerp-product-attributes.
Requested reviews:
Product Core Editors (product-core-editors)
For more details, see:
https://code.launchpad.net/~numerigraphe-team/openerp-product-attributes/7.0-add-bremskrel-modules/+merge/219858
I propose these 2 new modules :
product_code_mandatory: all is in the module name.
product_code_unique: having a unique product code, without sequence.
These modules have come from BREMSKERL branch (they are OK to merge).
Loïc BELLIER
--
https://code.launchpad.net/~numerigraphe-team/openerp-product-attributes/7.0-add-bremskrel-modules/+merge/219858
Your team Product Core Editors is requested to review the proposed merge of
lp:~numerigraphe-team/openerp-product-attributes/7.0-add-bremskrel-modules into
lp:openerp-product-attributes.
=== added directory 'product_code_mandatory'
=== added file 'product_code_mandatory/__init__.py'
--- product_code_mandatory/__init__.py 1970-01-01 00:00:00 +
+++ product_code_mandatory/__init__.py 2014-05-16 15:13:56 +
@@ -0,0 +1,1 @@
+import product
\ No newline at end of file
=== added file 'product_code_mandatory/__openerp__.py'
--- product_code_mandatory/__openerp__.py 1970-01-01 00:00:00 +
+++ product_code_mandatory/__openerp__.py 2014-05-16 15:13:56 +
@@ -0,0 +1,38 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP Module
+#
+#Copyright (C) 2010-2011 BREMSKERL-REIBBELAGWERKE EMMERLING GmbH Co. KG
+#Author Marco Dieckhoff
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+{
+name: Make product code mandatory,
+version: 1.01,
+depends: [product],
+author: Marco Dieckhoff, BREMSKERL,
+category: Inventory Control,
+description: Makes product code (default_code) a mandatory field
+,
+'depends' : ['product'],
+init_xml: [],
+'update_xml': [],
+'demo_xml': [],
+'installable': True,
+'active': False,
+#'certificate': '${certificate}',
+}
\ No newline at end of file
=== added file 'product_code_mandatory/product.py'
--- product_code_mandatory/product.py 1970-01-01 00:00:00 +
+++ product_code_mandatory/product.py 2014-05-16 15:13:56 +
@@ -0,0 +1,16 @@
+# -*- coding: utf-8 -*-
+
+from openerp.osv import osv, fields
+
+
+class product_code_mandatory_product(osv.osv):
+_name = product.product
+_inherit = product.product
+
+_columns = {
+'default_code': fields.char('Reference', size=64, required=True),
+}
+
+_defaults ={
+'default_code': lambda *a: 'NEW',
+}
=== added directory 'product_code_unique'
=== added file 'product_code_unique/__init__.py'
--- product_code_unique/__init__.py 1970-01-01 00:00:00 +
+++ product_code_unique/__init__.py 2014-05-16 15:13:56 +
@@ -0,0 +1,1 @@
+import product
\ No newline at end of file
=== added file 'product_code_unique/__openerp__.py'
--- product_code_unique/__openerp__.py 1970-01-01 00:00:00 +
+++ product_code_unique/__openerp__.py 2014-05-16 15:13:56 +
@@ -0,0 +1,38 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP Module
+#
+#Copyright (C) 2010-2011 BREMSKERL-REIBBELAGWERKE EMMERLING GmbH Co. KG
+#Author Marco Dieckhoff
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+{
+name: Make product code unique,
+version: 1.01,
+
Re: [Openerp-community-reviewer] [Openerp-community] OCA LP Project migration to Github
Hi Joel ! On Fri, May 16, 2014 at 10:16 AM, Joël Grand-Guillaume joel.grandguilla...@camptocamp.com wrote: Dear community, After the announcement of the brand new odoo instead of OpenERP, the main changes for contributors currently is the switch to Github. As I know, most of you waited for such a move ! Now it's done :) Though it remain a quite huge question : How the hell do we, as the community, will manage this switch ? I know there is lots of side questions (like making one repository per module, using subtree and many more). I see those options: a) Move all projects from LP to Github, but only the 7.0 series to create only the master branch. Every devs should create the pull request needed if they want their LP MP to be shown as pull request on github. Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Easy, quick,simple to understand, only still active MP will be ported by each devs - = Every devs will have to rebuild the pull request, loss of review infos in the pull request (though people can copy/paste the link to LP) b) Move all projects from LP to Github and try to take all branches related to a project using [1], create the master branch from the 7.0 series. Then all devs will have to take back his branch, branch by branch, in his own name (that process [1] was use to move openstack to github). Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Keep all branches of all projects - = Doesn't help to take back the MP as pull request, will let lots of obsolete branches c) Try to immediately split repository to have one repo by module, all owned by the OCA project (only one project, many, many repos). Just making one repo by module. Then we can have those many repos grouped by topic using submodule (here an example: https://github.com/camptocamp/puppet-modules). By topic I mean Apps (like sale, purchase, ..). + = We have one repo by module and start clean on github - = Not that easy to split, not clear exactly how to do that, we have the risk that by the time we figure that out we remain on LP for quite a while, change the architecture and tools all at once. My suggestion to allow a fast move forward is option a) as the following: 1) Take all OCA projects on LP and create one under the OCA umbrella on github 2) Then I suggest to create the master branch on Github from the 7.0 series on LP. Older one remain on LP only. 3) All current MPs must be made as pull request by his owner on GitHub to be merged. 4) All the 7.0 series starts on Github as soon as we have build them all (should not take more than 1 or 2 days to achieve. The older one (5, 6, 6.1) remain on LP. 5) For 8.0, we starts creating all needed sub-module repo Mains args: * Easy and fast * Make a smooth transition as projects are kept, just moved on github * Avoid having old MP or obsolete branches in the OCA umbrella * For 7.0 serie we have everything on github, so we avoid working with both git and bzr * For older serie we keep all on bzr, while future v8.0 will have a clean one repo by module solution Who's in favor of which option here (a,b,c) ? Any others I missed ? I think c) is the best but will not fast move, extract per module and create a repo will take time. I am agree with choose a) option, so one Q here, when you named 5) arg point what will be the process ? Thanks for your vote ! Please try to be as short as possible on your answer, so we can see who's voting for which option :) Best regards, Joël [1] https://github.com/termie/lp2gh/blob/master/docs/moving_branches.rst -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-commun...@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Cristian Salamea @ovnicraft -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web-addons into lp:web-addons
Pedro, Just install the module and add duplicate=false to the definition of the view that you want you modify. Thanks for the icon. 2014-05-15 19:35 GMT-04:30 Pedro Manuel Baeza pedro.ba...@gmail.com: Review: Needs Fixing test Hi, Aristóbulo, thanks for the contribution. I didn't get to work. Is there something special to do apart from installing the module? I have designed an icon for the module if you like: https://www.dropbox.com/s/3gupycgxtfowhw7/icon.png Regards. -- https://code.launchpad.net/~aristobulo/web-addons/web-addons/+merge/217277 You are the owner of lp:~aristobulo/web-addons/web-addons. -- La experiencia es la más dura maestra; primero pone la prueba, luego dá la explicación... - https://code.launchpad.net/~aristobulo/web-addons/web-addons/+merge/217277 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into lp:purchase-wkfl
Thanks Romain, I fixed it. Not sure why account_budget does not activate analytic accounting on sales purchase, I don't think you can enter a budget without that. So I only added in the module description -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit/+merge/219829 Your team Purchase Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_budget_limit into lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web-addons into lp:web-addons
Review: Needs Fixing code review Please include then this info on module description, and a example of usage. Regards. -- https://code.launchpad.net/~aristobulo/web-addons/web-addons/+merge/217277 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size into lp:report-print-send
Yannick yes it would be much cleaner, but the problem is the same as with what was initially proposed: unfortunately it won't be accepted in stable releases. So for v7 we can only - either take this white-box reuse module - or refuse it and ask those interested to patch their installation on their own (I for one would not mind doing that). -- https://code.launchpad.net/~bruno-bottacini/report-print-send/7.0-report_webkit_custom_paper_size/+merge/202892 Your team Report Printing and Sending Core Editors is subscribed to branch lp:report-print-send. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Openerp-community] OCA LP Project migration to Github
Hi Joël, Maybe I don't understand, but having one addon per repo does that mean that when an API change requires a change in all the banking addons (for instance), that I have to make a pull request for all those repos? I'd be in favour of keeping OCA projects in bzr for 7.0 and in GitHub for 8.0. Should be less work for everybody. Just because OpenERP SA causes this overnight disruptive change does not mean that the OCA has to follow. Or does the app store not support Launchpad anymore either? Cheers, Stefan. On 16-05-14 17:16, Joël Grand-Guillaume wrote: Dear community, After the announcement of the brand new odoo instead of OpenERP, the main changes for contributors currently is the switch to Github. As I know, most of you waited for such a move ! Now it's done :) Though it remain a quite huge question : How the hell do we, as the community, will manage this switch ? I know there is lots of side questions (like making one repository per module, using subtree and many more). I see those options: a) Move all projects from LP to Github, but only the 7.0 series to create only the master branch. Every devs should create the pull request needed if they want their LP MP to be shown as pull request on github. Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Easy, quick,simple to understand, only still active MP will be ported by each devs - = Every devs will have to rebuild the pull request, loss of review infos in the pull request (though people can copy/paste the link to LP) b) Move all projects from LP to Github and try to take all branches related to a project using [1], create the master branch from the 7.0 series. Then all devs will have to take back his branch, branch by branch, in his own name (that process [1] was use to move openstack to github). Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Keep all branches of all projects - = Doesn't help to take back the MP as pull request, will let lots of obsolete branches c) Try to immediately split repository to have one repo by module, all owned by the OCA project (only one project, many, many repos). Just making one repo by module. Then we can have those many repos grouped by topic using submodule (here an example: https://github.com/camptocamp/puppet-modules). By topic I mean Apps (like sale, purchase, ..). + = We have one repo by module and start clean on github - = Not that easy to split, not clear exactly how to do that, we have the risk that by the time we figure that out we remain on LP for quite a while, change the architecture and tools all at once. My suggestion to allow a fast move forward is option a) as the following: 1) Take all OCA projects on LP and create one under the OCA umbrella on github 2) Then I suggest to create the master branch on Github from the 7.0 series on LP. Older one remain on LP only. 3) All current MPs must be made as pull request by his owner on GitHub to be merged. 4) All the 7.0 series starts on Github as soon as we have build them all (should not take more than 1 or 2 days to achieve. The older one (5, 6, 6.1) remain on LP. 5) For 8.0, we starts creating all needed sub-module repo Mains args: * Easy and fast * Make a smooth transition as projects are kept, just moved on github * Avoid having old MP or obsolete branches in the OCA umbrella * For 7.0 serie we have everything on github, so we avoid working with both git and bzr * For older serie we keep all on bzr, while future v8.0 will have a clean one repo by module solution Who's in favor of which option here (a,b,c) ? Any others I missed ? Thanks for your vote ! Please try to be as short as possible on your answer, so we can see who's voting for which option :) Best regards, Joël [1] https://github.com/termie/lp2gh/blob/master/docs/moving_branches.rst -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com http://www.camptocamp.com/ ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-commun...@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Therp - Maatwerk in open ontwikkeling Stefan Rijnhart - Ontwerp en implementatie mail: ste...@therp.nl tel: +31 (0) 614478606 http://therp.nl https://twitter.com/therp_stefan -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Openerp-community] OCA LP Project migration to Github
I vote for a) as the quickest and easiest option to arrive to the full split for v8. (unless someone can manage to do the split of v7 in a few days, but I suppose that's not possible). On Fri, May 16, 2014 at 5:31 PM, Ovnicraft ovnicr...@gmail.com wrote: Hi Joel ! On Fri, May 16, 2014 at 10:16 AM, Joël Grand-Guillaume joel.grandguilla...@camptocamp.com wrote: Dear community, After the announcement of the brand new odoo instead of OpenERP, the main changes for contributors currently is the switch to Github. As I know, most of you waited for such a move ! Now it's done :) Though it remain a quite huge question : How the hell do we, as the community, will manage this switch ? I know there is lots of side questions (like making one repository per module, using subtree and many more). I see those options: a) Move all projects from LP to Github, but only the 7.0 series to create only the master branch. Every devs should create the pull request needed if they want their LP MP to be shown as pull request on github. Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Easy, quick,simple to understand, only still active MP will be ported by each devs - = Every devs will have to rebuild the pull request, loss of review infos in the pull request (though people can copy/paste the link to LP) b) Move all projects from LP to Github and try to take all branches related to a project using [1], create the master branch from the 7.0 series. Then all devs will have to take back his branch, branch by branch, in his own name (that process [1] was use to move openstack to github). Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Keep all branches of all projects - = Doesn't help to take back the MP as pull request, will let lots of obsolete branches c) Try to immediately split repository to have one repo by module, all owned by the OCA project (only one project, many, many repos). Just making one repo by module. Then we can have those many repos grouped by topic using submodule (here an example: https://github.com/camptocamp/puppet-modules). By topic I mean Apps (like sale, purchase, ..). + = We have one repo by module and start clean on github - = Not that easy to split, not clear exactly how to do that, we have the risk that by the time we figure that out we remain on LP for quite a while, change the architecture and tools all at once. My suggestion to allow a fast move forward is option a) as the following: 1) Take all OCA projects on LP and create one under the OCA umbrella on github 2) Then I suggest to create the master branch on Github from the 7.0 series on LP. Older one remain on LP only. 3) All current MPs must be made as pull request by his owner on GitHub to be merged. 4) All the 7.0 series starts on Github as soon as we have build them all (should not take more than 1 or 2 days to achieve. The older one (5, 6, 6.1) remain on LP. 5) For 8.0, we starts creating all needed sub-module repo Mains args: * Easy and fast * Make a smooth transition as projects are kept, just moved on github * Avoid having old MP or obsolete branches in the OCA umbrella * For 7.0 serie we have everything on github, so we avoid working with both git and bzr * For older serie we keep all on bzr, while future v8.0 will have a clean one repo by module solution Who's in favor of which option here (a,b,c) ? Any others I missed ? I think c) is the best but will not fast move, extract per module and create a repo will take time. I am agree with choose a) option, so one Q here, when you named 5) arg point what will be the process ? Thanks for your vote ! Please try to be as short as possible on your answer, so we can see who's voting for which option :) Best regards, Joël [1] https://github.com/termie/lp2gh/blob/master/docs/moving_branches.rst -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-commun...@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Cristian Salamea @ovnicraft ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-commun...@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Openerp-community] OCA LP Project migration to Github
I think Stefan raises an interesting approach: let v7 as is on Launchpad, and move quietly to GitHub for v8 modules (one module migration, a module that is tested on v8 and works, etc) in the form 1 module/1 repo. About the other problem, I don't know exactly GitHub, but I think you can propose a merge at project or subproject level. Raphäel is an expert on GitHub, so he can guide us. Regards. 2014-05-16 17:51 GMT+02:00 Leonardo Pistone leonardo.pist...@camptocamp.com : I vote for a) as the quickest and easiest option to arrive to the full split for v8. (unless someone can manage to do the split of v7 in a few days, but I suppose that's not possible). On Fri, May 16, 2014 at 5:31 PM, Ovnicraft ovnicr...@gmail.com wrote: Hi Joel ! On Fri, May 16, 2014 at 10:16 AM, Joël Grand-Guillaume joel.grandguilla...@camptocamp.com wrote: Dear community, After the announcement of the brand new odoo instead of OpenERP, the main changes for contributors currently is the switch to Github. As I know, most of you waited for such a move ! Now it's done :) Though it remain a quite huge question : How the hell do we, as the community, will manage this switch ? I know there is lots of side questions (like making one repository per module, using subtree and many more). I see those options: a) Move all projects from LP to Github, but only the 7.0 series to create only the master branch. Every devs should create the pull request needed if they want their LP MP to be shown as pull request on github. Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Easy, quick,simple to understand, only still active MP will be ported by each devs - = Every devs will have to rebuild the pull request, loss of review infos in the pull request (though people can copy/paste the link to LP) b) Move all projects from LP to Github and try to take all branches related to a project using [1], create the master branch from the 7.0 series. Then all devs will have to take back his branch, branch by branch, in his own name (that process [1] was use to move openstack to github). Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Keep all branches of all projects - = Doesn't help to take back the MP as pull request, will let lots of obsolete branches c) Try to immediately split repository to have one repo by module, all owned by the OCA project (only one project, many, many repos). Just making one repo by module. Then we can have those many repos grouped by topic using submodule (here an example: https://github.com/camptocamp/puppet-modules). By topic I mean Apps (like sale, purchase, ..). + = We have one repo by module and start clean on github - = Not that easy to split, not clear exactly how to do that, we have the risk that by the time we figure that out we remain on LP for quite a while, change the architecture and tools all at once. My suggestion to allow a fast move forward is option a) as the following: 1) Take all OCA projects on LP and create one under the OCA umbrella on github 2) Then I suggest to create the master branch on Github from the 7.0 series on LP. Older one remain on LP only. 3) All current MPs must be made as pull request by his owner on GitHub to be merged. 4) All the 7.0 series starts on Github as soon as we have build them all (should not take more than 1 or 2 days to achieve. The older one (5, 6, 6.1) remain on LP. 5) For 8.0, we starts creating all needed sub-module repo Mains args: * Easy and fast * Make a smooth transition as projects are kept, just moved on github * Avoid having old MP or obsolete branches in the OCA umbrella * For 7.0 serie we have everything on github, so we avoid working with both git and bzr * For older serie we keep all on bzr, while future v8.0 will have a clean one repo by module solution Who's in favor of which option here (a,b,c) ? Any others I missed ? I think c) is the best but will not fast move, extract per module and create a repo will take time. I am agree with choose a) option, so one Q here, when you named 5) arg point what will be the process ? Thanks for your vote ! Please try to be as short as possible on your answer, so we can see who's voting for which option :) Best regards, Joël [1] https://github.com/termie/lp2gh/blob/master/docs/moving_branches.rst -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-commun...@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Cristian Salamea @ovnicraft
Re: [Openerp-community-reviewer] [Openerp-community] OCA LP Project migration to Github
vote : A Big thanks to Joel for this mail ;) 2014-05-16 17:16 GMT+02:00 Joël Grand-Guillaume joel.grandguilla...@camptocamp.com: Dear community, After the announcement of the brand new odoo instead of OpenERP, the main changes for contributors currently is the switch to Github. As I know, most of you waited for such a move ! Now it's done :) Though it remain a quite huge question : How the hell do we, as the community, will manage this switch ? I know there is lots of side questions (like making one repository per module, using subtree and many more). I see those options: a) Move all projects from LP to Github, but only the 7.0 series to create only the master branch. Every devs should create the pull request needed if they want their LP MP to be shown as pull request on github. Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Easy, quick,simple to understand, only still active MP will be ported by each devs - = Every devs will have to rebuild the pull request, loss of review infos in the pull request (though people can copy/paste the link to LP) b) Move all projects from LP to Github and try to take all branches related to a project using [1], create the master branch from the 7.0 series. Then all devs will have to take back his branch, branch by branch, in his own name (that process [1] was use to move openstack to github). Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Keep all branches of all projects - = Doesn't help to take back the MP as pull request, will let lots of obsolete branches c) Try to immediately split repository to have one repo by module, all owned by the OCA project (only one project, many, many repos). Just making one repo by module. Then we can have those many repos grouped by topic using submodule (here an example: https://github.com/camptocamp/puppet-modules). By topic I mean Apps (like sale, purchase, ..). + = We have one repo by module and start clean on github - = Not that easy to split, not clear exactly how to do that, we have the risk that by the time we figure that out we remain on LP for quite a while, change the architecture and tools all at once. My suggestion to allow a fast move forward is option a) as the following: 1) Take all OCA projects on LP and create one under the OCA umbrella on github 2) Then I suggest to create the master branch on Github from the 7.0 series on LP. Older one remain on LP only. 3) All current MPs must be made as pull request by his owner on GitHub to be merged. 4) All the 7.0 series starts on Github as soon as we have build them all (should not take more than 1 or 2 days to achieve. The older one (5, 6, 6.1) remain on LP. 5) For 8.0, we starts creating all needed sub-module repo Mains args: * Easy and fast * Make a smooth transition as projects are kept, just moved on github * Avoid having old MP or obsolete branches in the OCA umbrella * For 7.0 serie we have everything on github, so we avoid working with both git and bzr * For older serie we keep all on bzr, while future v8.0 will have a clean one repo by module solution Who's in favor of which option here (a,b,c) ? Any others I missed ? Thanks for your vote ! Please try to be as short as possible on your answer, so we can see who's voting for which option :) Best regards, Joël [1] https://github.com/termie/lp2gh/blob/master/docs/moving_branches.rst -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-commun...@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Openerp-community] OCA LP Project migration to Github
We agree with Stefan here. -- Maxime Chambreuil +1 (514) 276-5468 #126 - Mail original - Stefan's approach has my vote. Keep = 7.0 on lauchpad and use github for = 8.0. Cheers, -sbi On Fri, May 16, 2014 at 5:51 PM, Stefan Rijnhart ste...@therp.nl wrote: Hi Joël, Maybe I don't understand, but having one addon per repo does that mean that when an API change requires a change in all the banking addons (for instance), that I have to make a pull request for all those repos? I'd be in favour of keeping OCA projects in bzr for 7.0 and in GitHub for 8.0. Should be less work for everybody. Just because OpenERP SA causes this overnight disruptive change does not mean that the OCA has to follow. Or does the app store not support Launchpad anymore either? Cheers, Stefan. On 16-05-14 17:16, Joël Grand-Guillaume wrote: blockquote Dear community, After the announcement of the brand new odoo instead of OpenERP, the main changes for contributors currently is the switch to Github. As I know, most of you waited for such a move ! Now it's done :) Though it remain a quite huge question : How the hell do we, as the community, will manage this switch ? I know there is lots of side questions (like making one repository per module, using subtree and many more). I see those options: a) Move all projects from LP to Github, but only the 7.0 series to create only the master branch. Every devs should create the pull request needed if they want their LP MP to be shown as pull request on github. Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Easy, quick,simple to understand, only still active MP will be ported by each devs - = Every devs will have to rebuild the pull request, loss of review infos in the pull request (though people can copy/paste the link to LP) b) Move all projects from LP to Github and try to take all branches related to a project using [1], create the master branch from the 7.0 series. Then all devs will have to take back his branch, branch by branch, in his own name (that process [1] was use to move openstack to github). Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Keep all branches of all projects - = Doesn't help to take back the MP as pull request, will let lots of obsolete branches c) Try to immediately split repository to have one repo by module, all owned by the OCA project (only one project, many, many repos). Just making one repo by module. Then we can have those many repos grouped by topic using submodule (here an example: https://github.com/camptocamp/puppet-modules ). By topic I mean Apps (like sale, purchase, ..). + = We have one repo by module and start clean on github - = Not that easy to split, not clear exactly how to do that, we have the risk that by the time we figure that out we remain on LP for quite a while, change the architecture and tools all at once. My suggestion to allow a fast move forward is option a) as the following: 1) Take all OCA projects on LP and create one under the OCA umbrella on github 2) Then I suggest to create the master branch on Github from the 7.0 series on LP. Older one remain on LP only. 3) All current MPs must be made as pull request by his owner on GitHub to be merged. 4) All the 7.0 series starts on Github as soon as we have build them all (should not take more than 1 or 2 days to achieve. The older one (5, 6, 6.1) remain on LP. 5) For 8.0, we starts creating all needed sub-module repo Mains args: * Easy and fast * Make a smooth transition as projects are kept, just moved on github * Avoid having old MP or obsolete branches in the OCA umbrella * For 7.0 serie we have everything on github, so we avoid working with both git and bzr * For older serie we keep all on bzr, while future v8.0 will have a clean one repo by module solution Who's in favor of which option here (a,b,c) ? Any others I missed ? Thanks for your vote ! Please try to be as short as possible on your answer, so we can see who's voting for which option :) Best regards, Joël [1] https://github.com/termie/lp2gh/blob/master/docs/moving_branches.rst -- camp to camp INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS Joël Grand-Guillaume Division Manager Business Solutions +41 21 61 9 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-commun...@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Therp - Maatwerk in open ontwikkeling Stefan Rijnhart - Ontwerp en implementatie mail: ste...@therp.nl tel: +31 (0) 614478606 http://therp.nl https://twitter.com/therp_stefan
Re: [Openerp-community-reviewer] [Openerp-community] OCA LP Project migration to Github
On Fri, May 16, 2014 at 10:51 AM, Stefan Rijnhart ste...@therp.nl wrote: Hi Joël, Maybe I don't understand, but having one addon per repo does that mean that when an API change requires a change in all the banking addons (for instance), that I have to make a pull request for all those repos? I'd be in favour of keeping OCA projects in bzr for 7.0 and in GitHub for 8.0. Should be less work for everybody. Just because OpenERP SA causes this overnight disruptive change does not mean that the OCA has to follow. Or does the app store not support Launchpad anymore either? So akretion has a mirror for OCB at github[1] and all of us can works, in fact ocb-7.0 is master :-) and it follows option a) suggested by Joel. By now its now possible so i dont understand organization in github from odoo, now master has server and addons in single repo, BTW move ASAP to github approaching what exists is better. Comments ! [1] https://github.com/akretion/openerp-server Cheers, Stefan. On 16-05-14 17:16, Joël Grand-Guillaume wrote: Dear community, After the announcement of the brand new odoo instead of OpenERP, the main changes for contributors currently is the switch to Github. As I know, most of you waited for such a move ! Now it's done :) Though it remain a quite huge question : How the hell do we, as the community, will manage this switch ? I know there is lots of side questions (like making one repository per module, using subtree and many more). I see those options: a) Move all projects from LP to Github, but only the 7.0 series to create only the master branch. Every devs should create the pull request needed if they want their LP MP to be shown as pull request on github. Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Easy, quick,simple to understand, only still active MP will be ported by each devs - = Every devs will have to rebuild the pull request, loss of review infos in the pull request (though people can copy/paste the link to LP) b) Move all projects from LP to Github and try to take all branches related to a project using [1], create the master branch from the 7.0 series. Then all devs will have to take back his branch, branch by branch, in his own name (that process [1] was use to move openstack to github). Then for serie 8.0, we start with one repo by module (as in option c): + = one LP project = one github project, Keep all branches of all projects - = Doesn't help to take back the MP as pull request, will let lots of obsolete branches c) Try to immediately split repository to have one repo by module, all owned by the OCA project (only one project, many, many repos). Just making one repo by module. Then we can have those many repos grouped by topic using submodule (here an example: https://github.com/camptocamp/puppet-modules). By topic I mean Apps (like sale, purchase, ..). + = We have one repo by module and start clean on github - = Not that easy to split, not clear exactly how to do that, we have the risk that by the time we figure that out we remain on LP for quite a while, change the architecture and tools all at once. My suggestion to allow a fast move forward is option a) as the following: 1) Take all OCA projects on LP and create one under the OCA umbrella on github 2) Then I suggest to create the master branch on Github from the 7.0 series on LP. Older one remain on LP only. 3) All current MPs must be made as pull request by his owner on GitHub to be merged. 4) All the 7.0 series starts on Github as soon as we have build them all (should not take more than 1 or 2 days to achieve. The older one (5, 6, 6.1) remain on LP. 5) For 8.0, we starts creating all needed sub-module repo Mains args: * Easy and fast * Make a smooth transition as projects are kept, just moved on github * Avoid having old MP or obsolete branches in the OCA umbrella * For 7.0 serie we have everything on github, so we avoid working with both git and bzr * For older serie we keep all on bzr, while future v8.0 will have a clean one repo by module solution Who's in favor of which option here (a,b,c) ? Any others I missed ? Thanks for your vote ! Please try to be as short as possible on your answer, so we can see who's voting for which option :) Best regards, Joël [1] https://github.com/termie/lp2gh/blob/master/docs/moving_branches.rst -- *camptocamp* INNOVATIVE SOLUTIONS BY OPEN SOURCE EXPERTS *Joël Grand-Guillaume* Division Manager Business Solutions +41 21 619 10 28 www.camptocamp.com ___ Mailing list: https://launchpad.net/~openerp-community Post to : openerp-commun...@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community More help : https://help.launchpad.net/ListHelp -- Therp - Maatwerk in open ontwikkeling
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0-form_destroy_buttons into lp:ocb-web
Review: Approve code review and test I have tried and it works like intended. Thanks for the fix. Regards. -- https://code.launchpad.net/~therp-nl/ocb-web/7.0-form_destroy_buttons/+merge/216898 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename into lp:ocb-web/6.1
Review: Approve code review and partial testing Approve Code review and ported the code to 7.0 to test. Working there, so will submit merge proposal for 7.0 as well. -- https://code.launchpad.net/~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename/+merge/27 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp:ocb-web
Ronald Portier (Therp) has proposed merging
lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp:ocb-web.
Requested reviews:
OpenERP Community Backports (ocb)
Related bugs:
Bug #1261322 in OpenERP Web: [6.1][7.0][trunk] Default report filename is
useless in daily use
https://bugs.launchpad.net/openerp-web/+bug/1261322
For more details, see:
https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1261332_better_report_name/+merge/219901
Port 6.1 proposal to 7.0.
Please ignore the typo in the branchname (1261332 instead of 126322).
--
https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1261332_better_report_name/+merge/219901
Your team OpenERP Community Backports is requested to review the proposed merge
of lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp:ocb-web.
=== modified file 'addons/web/controllers/main.py'
--- addons/web/controllers/main.py 2014-02-21 11:58:55 +
+++ addons/web/controllers/main.py 2014-05-16 20:21:31 +
@@ -1751,16 +1751,24 @@
report = zlib.decompress(report)
report_mimetype = self.TYPES_MAPPING.get(
report_struct['format'], 'octet-stream')
-file_name = action.get('name', 'report')
-if 'name' not in action:
-reports = req.session.model('ir.actions.report.xml')
-res_id = reports.search([('report_name', '=', action['report_name']),],
-0, False, False, context)
-if len(res_id) 0:
-file_name = reports.read(res_id[0], ['name'], context)['name']
-else:
-file_name = action['report_name']
+file_name = action['report_name']
+# Try to get current object model and their ids from context
+if 'context' in action:
+action_context = action['context']
+if (action_context.get('active_model')
+and action_context['active_ids']):
+# Use built-in ORM method to get data from DB
+m = req.session.model(action_context['active_model'])
+r = m.name_get(action_context['active_ids'], context)
+# Parse result to create a better filename
+item_names = [item[1] or str(item[0]) for item in r]
+if action.get('name'):
+item_names.insert(0, action['name'])
+file_name = '-'.join(item_names)
file_name = '%s.%s' % (file_name, report_struct['format'])
+# Create safe filename
+p = re.compile('[/:()|?*]|(\\\)')
+file_name = p.sub('_', file_name)
return req.make_response(report,
headers=[
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
