Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:purchase-wkfl
Review: Needs Information code review Hi, Lorenzo, thanks for expanding this module. I see a possible problem giving more priority to partner search than to any other, because you make a return in case that there are ids in this search. I think you must join all results to allow for example "Search more..." option to appear. Regards. -- https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/219017 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal into lp:sale-wkfl
Hi, David, I'm still relucent about the name. Why not naming this module for v7 as sale_journal_shop, and for v8, we change it to the one you proposed? Regards. -- https://code.launchpad.net/~akretion-team/sale-wkfl/sale-wkfl-sale-multi-journal/+merge/215440 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools
Hi, Yannick, I have updated according your comments, and found that we can avoid to remove required=True putting ondelete="cascade". Regards. -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced/+merge/212074 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/web-addons/bug-1303944-sbi into lp:web-addons
The proposal to merge lp:~acsone-openerp/web-addons/bug-1303944-sbi into lp:web-addons has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~acsone-openerp/web-addons/bug-1303944-sbi/+merge/216422 -- https://code.launchpad.net/~acsone-openerp/web-addons/bug-1303944-sbi/+merge/216422 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/web-addons/bug-1303944-sbi into lp:web-addons
Review: Approve code review and test I have tried and it works good for admin and non admin users. It's a pity the logos issue, but module is very good even with that! Regards -- https://code.launchpad.net/~acsone-openerp/web-addons/bug-1303944-sbi/+merge/216422 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test into lp:ocb-addons
Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test into
lp:ocb-addons.
Requested reviews:
Stefan Rijnhart (Therp) (stefan-therp)
Loïc Bellier - Numérigraphe (lb-b): code review
Related bugs:
Bug #1228156 in OpenERP Addons: "Wizard "Fill inventory" creates wrong lines
for moves where source=destination"
https://bugs.launchpad.net/openobject-addons/+bug/1228156
For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test/+merge/215453
This branch adds a YAML test to detect possible regressions regarding bug
#1228156.
It runs green on runbot:
http://runbot.openerp.com/numerigraphe-team-7-0-ocb-runbot-inventory-dummy-moves-test-30874/logs/
Upstream MP:
https://code.launchpad.net/~numerigraphe-team/openobject-addons/7.0-inventory-dummy-moves-test/+merge/214910
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test/+merge/215453
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.
=== modified file 'stock/__openerp__.py'
--- stock/__openerp__.py 2014-04-04 18:52:40 +
+++ stock/__openerp__.py 2014-05-16 08:48:48 +
@@ -96,6 +96,7 @@
'test/shipment.yml',
'test/stock_report.yml',
'test/stock_move_chain_validation.yml',
+'test/stock_inventory_dummy_moves.yml',
],
'installable': True,
'application': True,
=== added file 'stock/test/stock_inventory_dummy_moves.yml'
--- stock/test/stock_inventory_dummy_moves.yml 1970-01-01 00:00:00 +
+++ stock/test/stock_inventory_dummy_moves.yml 2014-05-16 08:48:48 +
@@ -0,0 +1,47 @@
+-
+ This file test will verify the bug reported at https://bugs.launchpad.net/openobject-addons/+bug/1228156.
+ In order to test the bug fix, I will create stock move with same location for source and destination location,
+ create inventory, import inventory lines
+-
+ I create stock move with same source and destination location for product_pc2.
+-
+ !record {model: stock.move, id: same_location_move}:
+name: 'Test move with same source and destination location'
+location_id: stock_location_14
+location_dest_id: stock_location_14
+product_id: product.product_product_9
+product_qty: 12.0
+product_uom: product.product_uom_unit
+state: 'done'
+-
+ I create inventory.
+-
+ !record {model: stock.inventory, id: stock_inventory_same_location}:
+company_id: base.main_company
+date: !eval time.strftime('%Y-%m-%d %H:%M:%S')
+date_done: !eval time.strftime('%Y-%m-%d %H:%M:%S')
+name: Physical inventory
+state: draft
+-
+ I create a stock.fill.inventory wizard .
+-
+ !record {model: stock.fill.inventory, id: stock_fill_inventory_1}:
+location_id: stock.stock_location_14
+-
+ I fill the inventory for location stock_location_14.
+-
+ !python {model: stock.fill.inventory}: |
+from osv import osv
+self.fill_inventory(cr, uid, [ref("stock_fill_inventory_1")], {"lang": 'en_US',
+ "full": "1", "tz": False, "active_model": "stock.inventory", "active_ids":
+ [ref("stock_inventory_same_location")], "active_id": ref("stock_inventory_same_location"), })
+-
+ I confirm and validate inventory - the quantity available must not change
+-
+ !python {model: stock.inventory}: |
+prod_obj = self.pool.get("product.product")
+old_qty = prod_obj.read(cr, uid, [ref('product.product_product_9')], ['qty_available'])[0]['qty_available']
+self.action_confirm(cr,uid,[ref('stock_inventory_same_location')])
+self.action_done(cr,uid,[ref('stock_inventory_same_location')])
+new_qty = prod_obj.read(cr, uid, [ref('product.product_product_9')], ['qty_available'])[0]['qty_available']
+assert old_qty == new_qty, "The quantity available should not change (%s -> %s)." % (old_qty, new_qty)
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test into lp:ocb-addons
Fixed, still green in runbot. -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-inventory-dummy-moves-test/+merge/215453 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
Review: Approve code review, no test LGTM Thanks -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
Review: Approve code review, no test LGTM thanks! -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
Romain Deheele - Camptocamp has proposed merging
lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde
into lp:account-financial-tools.
Requested reviews:
Account Core Editors (account-core-editors)
Related bugs:
Bug #1320918 in Account - Financial Tools: "Error when you edit Siret or
Company Registry on partner attached to the company"
https://bugs.launchpad.net/account-financial-tools/+bug/1320918
For more details, see:
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090
Hello,
It fixes https://bugs.launchpad.net/account-financial-tools/+bug/1320918
Search args weren't corrects.
I've taken advantage to set a string label on the two related fields on company
: siret and company registry.
Regards,
Romain
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
=== modified file 'l10n_fr_siret/company.py'
--- l10n_fr_siret/company.py 2014-03-27 09:59:12 +
+++ l10n_fr_siret/company.py 2014-05-19 15:33:32 +
@@ -28,16 +28,17 @@
def _get_partner_change(self, cr, uid, ids, context=None):
return self.pool.get('res.partner').search(
-cr, uid, [('partner_id', 'in', ids)], context=context)
+cr, uid, [('id', 'in', ids)], context=context)
_columns = {
'siret': fields.related(
-'partner_id', 'siret', type='char', store={
+'partner_id', 'siret', type='char', string='SIRET', store={
'res.partner': (_get_partner_change, ['siren', 'nic'], 20),
'res.company': (lambda self, cr, uid, ids, c={}:
ids, ['partner_id'], 20), }),
'company_registry': fields.related(
-'partner_id', 'company_registry', type='char', store={
+'partner_id', 'company_registry', type='char',
+string='Company Registry', store={
'res.partner': (_get_partner_change, ['company_registry'], 20),
'res.company': (lambda self, cr, uid, ids, c={}:
ids, ['partner_id'], 20), })
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp:ocb-web
Review: Approve Thanks, Note that you can easily rename a branch from launchpad. -- https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1261332_better_report_name/+merge/219901 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_picking_line_description_7 into lp:stock-logistic-flows
Review: Approve code review -- https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_picking_line_description_7/+merge/219800 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~agilebg/stock-logistic-flows/adding_picking_line_description_7 into lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename into lp:ocb-web/6.1
The proposal to merge lp:~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename into lp:ocb-web/6.1 has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename/+merge/27 -- https://code.launchpad.net/~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename/+merge/27 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-stock_available_immediately-compute-error into lp:stock-logistic-warehouse
Yes you're right, sorry. I'll delete this proposal. -- https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-stock_available_immediately-compute-error/+merge/220023 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/stock-logistic-warehouse/7.0-stock_available_immediately-compute-error into lp:stock-logistic-warehouse. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename into lp:ocb-web/6.1
Review: Approve code review Yann, thanks for this useful patch. Try on a 7.0, and code review here. Regards. -- https://code.launchpad.net/~yann-papouin/ocb-web/6.1-bug-1261322-useful-report-filename/+merge/27 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-stock_available_immediately-compute-error into lp:stock-logistic-warehouse
Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/stock-logistic-warehouse/7.0-stock_available_immediately-compute-error into lp:stock-logistic-warehouse. Requested reviews: Guewen Baconnier @ Camptocamp (gbaconnier-c2c) Loïc Bellier - Numérigraphe (lb-b) Sébastien BEAU - http://www.akretion.com (sebastien.beau) Stock and Logistic Core Editors (stock-logistic-core-editors) Related bugs: Bug #1320857 in Stock And Logistic Warehouse: "stock_available_immediately computes wrong stock level" https://bugs.launchpad.net/stock-logistic-warehouse/+bug/1320857 For more details, see: https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-stock_available_immediately-compute-error/+merge/220023 compute "Immediately Usable" as: Quantity On Hand - Outgoing as stated by the description -- https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-stock_available_immediately-compute-error/+merge/220023 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/stock-logistic-warehouse/7.0-stock_available_immediately-compute-error into lp:stock-logistic-warehouse. === modified file 'stock_available_immediately/product.py' --- stock_available_immediately/product.py 2014-02-19 11:43:35 + +++ stock_available_immediately/product.py 2014-05-19 12:45:19 + @@ -55,7 +55,7 @@ if 'immediately_usable_qty' in field_names: for product_id, stock_qty in res.iteritems(): res[product_id]['immediately_usable_qty'] = \ -stock_qty['qty_available'] + stock_qty['outgoing_qty'] +stock_qty['qty_available'] - stock_qty['outgoing_qty'] return res -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-stock_available_immediately-compute-error into lp:stock-logistic-warehouse
Review: Needs Information Isn't "Outgoing" a negative value? I think that "stock_qty['qty_available'] + stock_qty['outgoing_qty']" is correct to compute an "immediately usable quantity". Am I wrong? -- https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-stock_available_immediately-compute-error/+merge/220023 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/stock-logistic-warehouse/7.0-stock_available_immediately-compute-error into lp:stock-logistic-warehouse. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp:ocb-web
Thanks Pedro for the review. I corrected the pep8 issue (and a trailing whitespace two lines before). Regards, -- https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1261332_better_report_name/+merge/219901 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp:ocb-web
Review: Approve code review and test It works perfectly, and it's a very needed feature. Thanks for bringing to 7.0. A non-blocking question is PEP8 issue on l.22. Regards. -- https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1261332_better_report_name/+merge/219901 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl
Review: Approve code review, no test Perfect, thanks for the changes Lionel -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl
I think it's fixed now. -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl
The proposal to merge lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi/+merge/217948 -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi/+merge/217948 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-use-super-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl
The proposal to merge lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-use-super-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl has been updated. Status: Work in progress => Merged For more details, see: https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-use-super-nbi/+merge/219989 -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-use-super-nbi/+merge/219989 Your team OpenERP for Humanitarian Core Editors is requested to review the proposed merge of lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-use-super-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl
Review: Approve code review, no tests As the next MP is WIP, I merge this one to move further ! -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi/+merge/217948 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl
Here is an exemple: http://bazaar.launchpad.net/~report-print-send-core-editors/report-print-send/7.0/view/head:/base_report_to_printer/__openerp__.py -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl
I moved the crediting to a comment in __openerp__.py, is it right? -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl
Here is the reference for this community Guideline. https://doc.openerp.com/contribute/05_developing_modules/#modules-description This has the advantage to show who contributed directly on apps.odoo.com as we don't have such field in manifest. -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl
Yannick, I agree, but I thought it was required for OCA modules - I can't remember why I assumed that, maybe read it in some guide somewhere. I'll fix it. -- https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi into lp:openerp-humanitarian-ngo/purchase-wkfl
As disscused and in order not to break dependency during a too long period, the use to super will be done in following MP: https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-use-super-nbi/+merge/219989 -- https://code.launchpad.net/~camptocamp/openerp-humanitarian-ngo/purchase-wkfl-improve-preq-cancel-nbi/+merge/217948 Your team OpenERP for Humanitarian Core Editors is subscribed to branch lp:openerp-humanitarian-ngo/purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
