Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/partner-contact-management/7.0_1184983_compute_display_name into lp:partner-contact-management
Review: Needs Information Doesn't the module firstname_display_name_trigger already does this job? There is already a trigger in it to recompute display_name. -- https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_1184983_compute_display_name/+merge/220629 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/partner-contact-management/7.0_1184983_compute_display_name into lp:partner-contact-management
Review: Disapprove firstname_display_name_trigger should already fix this issue. Thus I disapprove it. -- https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_1184983_compute_display_name/+merge/220629 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale into lp:stock-logistic-warehouse
Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale into lp:stock-logistic-warehouse with lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available as a prerequisite. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see: https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale/+merge/220761 Add stock_available_sale: take sale quotations into account in the stock quantity available to promise stock_available stock_available_sale. This branch builds upon lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available, which adds a generic module to compute the stock available to promise in a configurable way. Module Co-authored by Loïc Bellier and your humble servant. -- https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale/+merge/220761 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale into lp:stock-logistic-warehouse. === modified file 'stock_available/res_config.py' --- stock_available/res_config.py 2014-05-23 07:53:49 + +++ stock_available/res_config.py 2014-05-23 07:53:49 + @@ -31,4 +31,11 @@ help=This will subtract incoming quantities from the quantities available to promise.\n This installs the module stock_available_immediately.), +'module_stock_available_sale': fields.boolean( +'Exclude goods already in sale quotations', +help=This will subtract quantities from the sale quotations from + the quantities available to promise.\n + This installs the modules stock_available_sale.\n + If the modules sale and sale_delivery_date are not + installed, this will install them too), } === modified file 'stock_available/res_config_view.xml' --- stock_available/res_config_view.xml 2014-05-23 07:53:49 + +++ stock_available/res_config_view.xml 2014-05-23 07:53:49 + @@ -15,6 +15,10 @@ field name=module_stock_available_immediately class=oe_inline / label for=module_stock_available_immediately / /div +div +field name=module_stock_available_sale class=oe_inline / +label for=module_stock_available_sale / +/div /div /group /xpath === added directory 'stock_available_sale' === added file 'stock_available_sale/__init__.py' --- stock_available_sale/__init__.py 1970-01-01 00:00:00 + +++ stock_available_sale/__init__.py 2014-05-23 07:53:49 + @@ -0,0 +1,22 @@ +# -*- coding: utf-8 -*- +## +# +#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved. +# +#This program is free software: you can redistribute it and/or modify +#it under the terms of the GNU Affero General Public License as +#published by the Free Software Foundation, either version 3 of the +#License, or (at your option) any later version. +# +#This program is distributed in the hope that it will be useful, +#but WITHOUT ANY WARRANTY; without even the implied warranty of +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +#GNU Affero General Public License for more details. +# +#You should have received a copy of the GNU Affero General Public License +#along with this program. If not, see http://www.gnu.org/licenses/. +# +## + +from . import product +from . import sale_stock === added file 'stock_available_sale/__openerp__.py' --- stock_available_sale/__openerp__.py 1970-01-01 00:00:00 + +++ stock_available_sale/__openerp__.py 2014-05-23 07:53:49 + @@ -0,0 +1,48 @@ +# -*- coding: utf-8 -*- +## +# +#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved. +# +#This program is free software: you can redistribute it and/or modify +#it under the terms of the GNU Affero General Public License as +#published by the Free Software Foundation, either version 3 of the +#License, or (at your option) any later version. +# +#This program is distributed in the hope that it will be useful, +#but WITHOUT ANY WARRANTY; without even the implied warranty of +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +#GNU Affero General Public License for more details. +# +#
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available into lp:stock-logistic-warehouse
Lionel Sausin - Numérigraphe has proposed merging
lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available into
lp:stock-logistic-warehouse.
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more details, see:
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available/+merge/220758
Add a generic module to compute the stock quantity available to promise using
several implementations and make stock_available_immediately the first
configurable implementation.
stock_available_immediately is rewritten to compute virtual - incoming instead
of real - outgoing, which should be mostly the same except for rounding .
The field name immediately_usable_qty is unchanged for compatibility, but the
field is now called Available to promise in the views and help texts (this
wording seems more widespread).
By default function fields are not very modular (you need to redefine the whole
field to override the method). stock_available takes care of this by making the
function fields call the pool instead, so that stock_available_immediately and
other future implementations need only override the function _product_available.
Module Co-authored by Loïc Bellier and your humble servant.
--
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available/+merge/220758
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available
into lp:stock-logistic-warehouse.
=== added directory 'stock_available'
=== added file 'stock_available/__init__.py'
--- stock_available/__init__.py 1970-01-01 00:00:00 +
+++ stock_available/__init__.py 2014-05-23 07:51:43 +
@@ -0,0 +1,24 @@
+# -*- coding: utf-8 -*-
+##
+#
+#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import product
+from . import res_config
+
+from .product import _product_available_fnct
=== added file 'stock_available/__openerp__.py'
--- stock_available/__openerp__.py 1970-01-01 00:00:00 +
+++ stock_available/__openerp__.py 2014-05-23 07:51:43 +
@@ -0,0 +1,42 @@
+# -*- coding: utf-8 -*-
+##
+#
+#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved.
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'Stock available to promise',
+'version': '2.0',
+'author': u'Numérigraphe',
+'category': 'Stock',
+'depends': ['stock'],
+'description':
+Stock available to promise
+==
+This module proposes several options to compute the quantity available to
+promise for each product.
+This quantity is based on the projected stock and, depending on the
+configuration, it can account for various data such as sales quotations or
+immediate production capacity.
+This can be configured in the menu Settings Configuration Warehouse.
+,
+'license': 'AGPL-3',
+'data': [
+'product_view.xml',
+'res_config_view.xml',
+]
+}
=== added file 'stock_available/product.py'
--- stock_available/product.py 1970-01-01 00:00:00 +
+++ stock_available/product.py 2014-05-23 07:51:43 +
@@ -0,0 +1,125 @@
+# -*- coding: utf-8 -*-
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-mrp into lp:stock-logistic-warehouse
Lionel Sausin - Numérigraphe has proposed merging lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-mrp into lp:stock-logistic-warehouse with lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale as a prerequisite. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see: https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-mrp/+merge/220764 Add stock_available_mrp: take immediate manufaturing capability into account in the stock quantity available to promise This branch builds upon lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available, which adds a generic module to compute the stock available to promise in a configurable way. It also includes lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale, which adds another //unrelated// implementation. This is only to avoid merge conflicts in case both are accepted, but they are independent works I can rebase this branch if needed. Module by Loïc Bellier with contributions from your humble servant. -- https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-mrp/+merge/220764 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-mrp into lp:stock-logistic-warehouse. === modified file 'stock_available/res_config.py' --- stock_available/res_config.py 2014-05-23 07:58:49 + +++ stock_available/res_config.py 2014-05-23 07:58:49 + @@ -38,4 +38,12 @@ This installs the modules stock_available_sale.\n If the modules sale and sale_delivery_date are not installed, this will install them too), +'module_stock_available_mrp': fields.boolean( +'Include the production potential', +help=This will add the quantities of goods that can be + immediately manufactured, to the quantities available to + promise.\n + This installs the module stock_available_mrp.\n + If the module mrp is not installed, this will install it + too), } === modified file 'stock_available/res_config_view.xml' --- stock_available/res_config_view.xml 2014-05-23 07:58:49 + +++ stock_available/res_config_view.xml 2014-05-23 07:58:49 + @@ -19,6 +19,10 @@ field name=module_stock_available_sale class=oe_inline / label for=module_stock_available_sale / /div +div +field name=module_stock_available_mrp class=oe_inline / +label for=module_stock_available_mrp / +/div /div /group /xpath === added directory 'stock_available_mrp' === added file 'stock_available_mrp/__init__.py' --- stock_available_mrp/__init__.py 1970-01-01 00:00:00 + +++ stock_available_mrp/__init__.py 2014-05-23 07:58:49 + @@ -0,0 +1,21 @@ +# -*- coding: utf-8 -*- +## +# +#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved. +# +#This program is free software: you can redistribute it and/or modify +#it under the terms of the GNU Affero General Public License as +#published by the Free Software Foundation, either version 3 of the +#License, or (at your option) any later version. +# +#This program is distributed in the hope that it will be useful, +#but WITHOUT ANY WARRANTY; without even the implied warranty of +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +#GNU Affero General Public License for more details. +# +#You should have received a copy of the GNU Affero General Public License +#along with this program. If not, see http://www.gnu.org/licenses/. +# +## + +from . import product === added file 'stock_available_mrp/__openerp__.py' --- stock_available_mrp/__openerp__.py 1970-01-01 00:00:00 + +++ stock_available_mrp/__openerp__.py 2014-05-23 07:58:49 + @@ -0,0 +1,39 @@ +# -*- coding: utf-8 -*- +## +# +#This module is copyright (C) 2014 Numérigraphe SARL. All Rights Reserved. +# +#This program is free software: you can redistribute it and/or modify +#it under the terms of the GNU Affero General Public License as +#published by the Free Software Foundation, either version 3 of the +#License, or (at your option) any later version. +# +#This program is distributed in the hope that it
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons
Review: Needs Fixing Aggreed with Raphaël, Please provide a bug report and the same MP on official branch Thus the bug report will link ocb and official branch fixes. Cheers -- https://code.launchpad.net/~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank/+merge/208021 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-fix-button-visibility into lp:purchase-wkfl
Review: Approve lgtm thanks -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-button-visibility/+merge/205304 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/purchase-wkfl/7.0-fix-button-visibility into lp:purchase-wkfl
The proposal to merge lp:~camptocamp/purchase-wkfl/7.0-fix-button-visibility into lp:purchase-wkfl has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-button-visibility/+merge/205304 -- https://code.launchpad.net/~camptocamp/purchase-wkfl/7.0-fix-button-visibility/+merge/205304 Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale into lp:stock-logistic-warehouse
The proposal to merge lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale into lp:stock-logistic-warehouse has been updated. Description changed to: Add stock_available_sale: take sale quotations into account in the stock quantity available to promise stock_available stock_available_sale. This branch builds upon lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available, which adds a generic module to compute the stock available to promise in a configurable way. The new module uses a context trick introduced in the previous branch, to make the Sale module warn salesman over insufficient quantity available to promise instead of insufficient virtual stock, with a very low code impact. Module Co-authored by Loïc Bellier and your humble servant. For more details, see: https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale/+merge/220761 -- https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale/+merge/220761 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/stock-logistic-warehouse/7.0-add-stock-available-sale into lp:stock-logistic-warehouse. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp:ocb-web
Please do not forgot the MP against official branch -- https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1261332_better_report_name/+merge/219901 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons
I won't do a bug report on the official branch myself and a new MP because it will certainly be ignored and I don't have motivation nor time (cf https://lists.launchpad.net/banking-addons-drivers/msg00053.html). I did this bug report and MP on OCB because other members of the banking-addons mailing-list suggested it ; but it was not my initial idea. So if a volunteer can take care of that and re-use my patch, he will be more than welcomed. For those who arrive on this bug report and need an immediate fix, they can use the module account_payment_security from lp:~akretion-team/+junk/70-usability/ -- https://code.launchpad.net/~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank/+merge/208021 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1261322] Re: [6.1][7.0][trunk] Default report filename is useless in daily use
** Also affects: ocb-web Importance: Undecided Status: New ** Also affects: ocb-web/6.1 Importance: Undecided Status: New ** Also affects: ocb-web/7.0 Importance: Undecided Status: New ** Changed in: ocb-web/6.1 Assignee: (unassigned) = Yann Papouin (yann-papouin) ** Changed in: ocb-web/6.1 Importance: Undecided = Medium ** Changed in: ocb-web/7.0 Importance: Undecided = Medium ** Changed in: ocb-web/7.0 Assignee: (unassigned) = Ronald Portier (Therp) (rportier1962) ** Changed in: ocb-web/6.1 Status: New = Fix Committed ** Changed in: ocb-web/7.0 Status: New = Fix Committed -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Web). https://bugs.launchpad.net/bugs/1261322 Title: [6.1][7.0][trunk] Default report filename is useless in daily use Status in OpenERP Community Backports (Web): Fix Committed Status in OpenERP Community Backports (Web) 6.1 series: Fix Committed Status in OpenERP Community Backports (Web) 7.0 series: Fix Committed Status in OpenERP Web: New Bug description: This bug report is related to a question asked [1] on stackoverflow. The main idea is to allow the user to download its report with a reliable filename: -PO6.pdf instead of Request For Quotation.pdf for a single object report -PO6-PO2.pdf instead of Request For Quotation.pdf for a multiple objects report My proposal is to use the object field name if exists and else to use the current behavior to create the report filename. (Note that the browser will trim invalid filename data like slash, backslash, etc.) [1] http://stackoverflow.com/questions/14434846/openerp-custom-report- filename To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-web/+bug/1261322/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde into lp:ocb-addons
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1302630_document_search_order_by-rde/+merge/214486 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt
Review: Approve code review, no test It should be fine. If employee has no department_id, employee. Employee.department_id will return browse_null and browse_null.id will return False -- https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt
The proposal to merge lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 -- https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt
The proposal to merge lp:~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055 into lp:department-mgmt has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 -- https://code.launchpad.net/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055/+merge/212286 Your team Department Core Editors is subscribed to branch lp:department-mgmt. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix into lp:account-financial-tools
Review: Approve Thanks for the changes Pedro LGTM -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account-renumber-menu-fix/+merge/214832 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix into lp:openerp-reporting-engines
The proposal to merge lp:~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix into lp:openerp-reporting-engines has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix/+merge/219267 -- https://code.launchpad.net/~luc-demeyer/openerp-reporting-engines/7.0-report_xls-tz_fix/+merge/219267 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:openerp-reporting-engines. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
This MP fixes the bug... but I still get a crash when I try to update a partner
and add a SIREN + NIC. On a recent ocb 7.0 with an up-to-date
lp:account-financial-tools merged with
lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde,
I get this crash :
Server Traceback (most recent call last):
File /home/alexis/new_boite/dev/web-70/addons/web/session.py, line 89, in
send
return openerp.netsvc.dispatch_rpc(service_name, method, args)
File /home/alexis/new_boite/dev/server-70/openerp/netsvc.py, line 296, in
dispatch_rpc
result = ExportService.getService(service_name).dispatch(method, params)
File /home/alexis/new_boite/dev/server-70/openerp/service/web_services.py,
line 626, in dispatch
res = fn(db, uid, *params)
File /home/alexis/new_boite/dev/server-70/openerp/osv/osv.py, line 190, in
execute_kw
return self.execute(db, uid, obj, method, *args, **kw or {})
File /home/alexis/new_boite/dev/server-70/openerp/osv/osv.py, line 132, in
wrapper
return f(self, dbname, *args, **kwargs)
File /home/alexis/new_boite/dev/server-70/openerp/osv/osv.py, line 199, in
execute
res = self.execute_cr(cr, uid, obj, method, *args, **kw)
File /home/alexis/new_boite/dev/server-70/openerp/osv/osv.py, line 187, in
execute_cr
return getattr(object, method)(cr, uid, *args, **kw)
File
/home/alexis/new_boite/dev/server-70/openerp/addons/base/res/res_partner.py,
line 507, in write
result = super(res_partner,self).write(cr, uid, ids, vals, context=context)
File /home/alexis/new_boite/dev/addons-70/mail/mail_thread.py, line 292, in
write
result = super(mail_thread, self).write(cr, uid, ids, values,
context=context)
File /home/alexis/new_boite/dev/server-70/openerp/osv/orm.py, line 4348, in
write
self.pool.get(object)._store_set_values(cr, user, todo,
fields_to_recompute, context)
File /home/alexis/new_boite/dev/server-70/openerp/osv/orm.py, line 4711, in
_store_set_values
result = self._columns[f].get(cr, self, ids, f, SUPERUSER_ID,
context=context)
File /home/alexis/new_boite/dev/server-70/openerp/osv/fields.py, line 1145,
in get
result = self._fnct(obj, cr, uid, ids, name, self._arg, context)
File /home/alexis/new_boite/dev/server-70/openerp/osv/fields.py, line 1211,
in _fnct_read
value = value[field] or False
File /home/alexis/new_boite/dev/server-70/openerp/osv/orm.py, line 432, in
__getitem__
raise KeyError('Field %s not found in %s'%(name, self))
KeyError: 'Field partner_id not found in browse_record(res.company, 18)'
So l10n_fr_siret is still not usable for me.
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
Review: Needs Fixing according to Alexis, this needs fixing -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
The bug is in the invalidation function _get_partner_change in company.py : the
invalidation function should be :
def _get_partner_change(self, cr, uid, ids, context=None):
return self.pool['res.company'].search(
cr, uid, [('partner_id', 'in', ids)], context=context)
The invalidation function is this MP is wrong : it returns IDs of partners...
where as it should return IDs of companies !!!
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1322248] Re: GTK client assertion error
** Project changed: ocb-addons = ocb-server -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Server). https://bugs.launchpad.net/bugs/1322248 Title: GTK client assertion error Status in OpenERP Community Backports (Server): New Bug description: I have this error when I go to accounting - customers - customer invoices and try to make an concatenated OR filter. I tried in other objets like product.product or res.partner and this doesn't happen, don't know if it is truly a gtk client error. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-server/+bug/1322248/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
Review: Approve code review and test Thanks Yannick for applying the fix. I have tested the new branch and it works well. -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
Review: Approve -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
The proposal to merge lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
The proposal to merge lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-web/7.0_lp1261332_better_report_name into lp:ocb-web
Review: Approve -- https://code.launchpad.net/~therp-nl/ocb-web/7.0_lp1261332_better_report_name/+merge/219901 Your team OpenERP Community Backports is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools
The proposal to merge lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced/+merge/212074 -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced/+merge/212074 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools
The proposal to merge lp:~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced into lp:account-financial-tools has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced/+merge/212074 -- https://code.launchpad.net/~pedro.baeza/account-financial-tools/7.0-account_chart_update-enhanced/+merge/212074 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde/+merge/213427 -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde/+merge/213427 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries
The proposal to merge lp:~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde into lp:carriers-deliveries has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde/+merge/213427 -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-associate-attachment-and-picking_rde/+merge/213427 Your team Stock and Logistic Core Editors is subscribed to branch lp:carriers-deliveries. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools
Review: Needs Fixing I set as need fixing after Frederic's comment -- https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1322248] Re: GTK client assertion error
Hi, Daniel, this error is specific of GTK client, and this one is not supported on OCB, only web client. Regards. ** Changed in: ocb-server Status: New = Invalid -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Server). https://bugs.launchpad.net/bugs/1322248 Title: GTK client assertion error Status in OpenERP Community Backports (Server): Invalid Bug description: I have this error when I go to accounting - customers - customer invoices and try to make an concatenated OR filter. I tried in other objets like product.product or res.partner and this doesn't happen, don't know if it is truly a gtk client error. To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-server/+bug/1322248/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report
Review: Approve code review, no test LGTM thanks for the contrib! -- https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi/+merge/217240 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report
Review: Needs Information This method has been removed from 8.0 version, so I'm wondering if it's convenient to change this in 7 to revert back again on 8. Regards. -- https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi/+merge/217240 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report
HI, Finally not sure if it's the right way to solve our problem since Odoo has decided to remove the call to migration scripts on first install of a module :( https://bugs.launchpad.net/openobject-server/+bug/1314680 Regards, lmi -- https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi/+merge/217240 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report
Review: Needs Information You are right forgot that sudden move from Odoo At least it fixes this issue in 7.0 but this would be more effort when porting to 8.0. Thus I revert my review as we need to find an other way of ensuring values are defined. BTW shouldn't store be computed when adding the column on install? -- https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi/+merge/217240 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
