Re: [Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
Review: Needs Fixing Thanks! Agree with Pedro. Apart from that, the diff looks odd with its executable permission changes. Could you revert those? -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM into lp:ocb-addons
Review: Approve code review, test LGTM. Thanks! -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM/+merge/217049 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM into lp:ocb-addons
The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM into lp:ocb-addons has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM/+merge/217049 -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM/+merge/217049 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1312045] Re: Importing inventory pushes the OS to out-of-memory condition when many Stock Moves exist
** Changed in: ocb-addons Status: Fix Committed = In Progress ** Changed in: ocb-addons Status: In Progress = Fix Released -- You received this bug notification because you are a member of OpenERP Community Backports, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1312045 Title: Importing inventory pushes the OS to out-of-memory condition when many Stock Moves exist Status in OpenERP Community Backports (Addons): Fix Released Status in New OpenERP WMS: New Status in Odoo Addons: Confirmed Bug description: Using v6.0 we're having problems importing an inventory for a location that contains 63 Stock Moves. The problem seems to lie in the python loop based on the browse() of the Stock Moves: it preloads too much data and pushes the OS to an out-of-memory condition (which Linux responds to by killing the openerp server). To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1312045/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM into lp:ocb-addons
The proposal to merge lp:~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM into lp:ocb-addons has been updated. Description changed to: We're having problems importing an inventory for a location that contains 63 Stock Moves. The problem seems to lie in the python loop based on the browse() of the Stock Moves: it preloads too much data and pushes the OS to an out-of-memory condition (which Linux responds to by killing the openerp server). This patch solve this bug by splitting stock moves lines ids on separated list of 10 000 lines Run GREEN on runbot. pull request on standard 7.0: https://github.com/odoo/odoo/pull/341 For more details, see: https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM/+merge/217049 -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM/+merge/217049 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM into lp:ocb-addons
Thank you. For the archives, the MP on official addons was turned into a pull request on github here: https://github.com/odoo/odoo/pull/341 -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM/+merge/217049 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM into lp:ocb-addons
Review: Approve code review Thanks for the MP. LGTM for V7 Note that for V8, with the new API (https://github.com/odoo-dev/odoo/blob/master-apiculture/openerp/osv/orm.py), the cache is managed in an other way and is no more reset on each call to the browse method. lmi -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill-inventory-OOM/+merge/217049 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl
After several various changes, I think it's time to review it again. Thanks, Romain -- https://code.launchpad.net/~camptocamp/sale-wkfl/product_procurement_type/+merge/222111 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
The proposal to merge lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1 has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/partner-firstname-inheritable into lp:partner-contact-management
Alexis de Lattre has proposed merging
lp:~akretion-team/partner-contact-management/partner-firstname-inheritable into
lp:partner-contact-management.
Requested reviews:
Partner and Contact Core Editors (partner-contact-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/partner-contact-management/partner-firstname-inheritable/+merge/222730
This MP is small but very usefull : with the partner_firstname module, the
'name' field on res.partner becomes a fields.function ; this MP make the code
of the fields.function inheritable.
--
https://code.launchpad.net/~akretion-team/partner-contact-management/partner-firstname-inheritable/+merge/222730
Your team Partner and Contact Core Editors is requested to review the proposed
merge of
lp:~akretion-team/partner-contact-management/partner-firstname-inheritable into
lp:partner-contact-management.
=== modified file 'partner_firstname/partner.py'
--- partner_firstname/partner.py 2014-02-18 17:09:53 +
+++ partner_firstname/partner.py 2014-06-10 20:59:58 +
@@ -35,14 +35,19 @@
if cursor.fetchone():
cursor.execute('ALTER TABLE res_partner ALTER COLUMN lastname SET NOT NULL')
+def _prepare_name_custom(self, cursor, uid, partner, context=None):
+
+This function is designed to be inherited in a custom module
+
+names = (partner.lastname, partner.firstname)
+fullname = .join([s for s in names if s])
+return fullname
+
def _compute_name_custom(self, cursor, uid, ids, fname, arg, context=None):
res = {}
-partners = self.read(cursor, uid, ids,
- ['firstname', 'lastname'], context=context)
-for rec in partners:
-names = (rec['lastname'], rec['firstname'])
-fullname = .join([s for s in names if s])
-res[rec['id']] = fullname
+for partner in self.browse(cursor, uid, ids, context=context):
+res[partner.id] = self._prepare_name_custom(
+cursor, uid, partner, context=context)
return res
def _write_name(self, cursor, uid, partner_id, field_name, field_value, arg, context=None):
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
Etienne Hirt has proposed merging lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports (ocb) Related bugs: Bug #1327887 in OpenERP Community Backports (Addons): [6.1] stock.move.tree2 wrong priority, stock.move.tree3 leftover https://bugs.launchpad.net/ocb-addons/+bug/1327887 For more details, see: https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222726 request merge again after addressing review comments -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222726 Your team OpenERP Community Backports is requested to review the proposed merge of lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1. === modified file 'stock/stock_view.xml' --- stock/stock_view.xml 2013-09-10 15:12:35 + +++ stock/stock_view.xml 2014-06-10 20:30:27 + @@ -1536,7 +1536,7 @@ field name=namestock.move.tree2/field field name=modelstock.move/field field name=typetree/field -field name=priority eval=6 / +field name=priority eval=18 / field name=arch type=xml tree colors=grey:state == 'cancel' string=Moves field name=picking_id string=Reference/ @@ -1576,7 +1576,7 @@ field name=namestock.move.tree3/field field name=modelstock.move/field field name=typetree/field -field eval=6 name=priority/ +field eval=20 name=priority/ field name=arch type=xml tree string=Moves field name=picking_id string=Reference/ -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/partner-firstname-inheritable into lp:partner-contact-management
Review: Approve code review LGTM -- https://code.launchpad.net/~akretion-team/partner-contact-management/partner-firstname-inheritable/+merge/222730 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
The proposal to merge lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1 has been updated. Status: Merged = Rejected For more details, see: https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
See new MP: https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222726 -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/partner-firstname-inheritable into lp:partner-contact-management
Review: Approve code review LGTM -- https://code.launchpad.net/~akretion-team/partner-contact-management/partner-firstname-inheritable/+merge/222730 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/partner-firstname-inheritable into lp:partner-contact-management
Review: Approve LGTM -- https://code.launchpad.net/~akretion-team/partner-contact-management/partner-firstname-inheritable/+merge/222730 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
