[Openerp-community-reviewer] [Merge] lp:~ajite/purchase-wkfl/7.0-add-purchase_landed_costs_extended into lp:purchase-wkfl

2014-06-18 Thread Augustin Cisterne-Kaas - www.elico-corp.com 
The proposal to merge 
lp:~ajite/purchase-wkfl/7.0-add-purchase_landed_costs_extended into 
lp:purchase-wkfl has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~ajite/purchase-wkfl/7.0-add-purchase_landed_costs_extended/+merge/223669
-- 
https://code.launchpad.net/~ajite/purchase-wkfl/7.0-add-purchase_landed_costs_extended/+merge/223669
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~ajite/purchase-wkfl/7.0-add-purchase_landed_costs_extended into 
lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address into lp:account-invoice-report

2014-06-18 Thread Pedro Manuel Baeza 
Review: Approve code review

OK, then. Do you think any extended explanation on module description can clear 
more doubts?

Regards.
-- 
https://code.launchpad.net/~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address/+merge/207915
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address into lp:account-invoice-report

2014-06-18 Thread Ronald Portier (Therp) 
Hello Pedro,

No, nothing to do with the invoice document.

The delivery address added to invoice is basically the same as on sales order.

It is usefull for customers with a lot of locations/addresses, where the person 
receiving the invoice needs to know to which location / address an invoice 
applies.
-- 
https://code.launchpad.net/~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address/+merge/207915
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0_lp914670_update_picking_date into lp:ocb-addons

2014-06-18 Thread noreply 
The proposal to merge lp:~therp-nl/ocb-addons/7.0_lp914670_update_picking_date 
into lp:ocb-addons has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~therp-nl/ocb-addons/7.0_lp914670_update_picking_date/+merge/223551
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0_lp914670_update_picking_date/+merge/223551
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-reports/vre-sale_order_proformat into lp:sale-reports

2014-06-18 Thread Pedro Manuel Baeza 
Review: Needs Fixing code review and test

Hi, Vincent,

Thanks you very much for this module. It's something that I have also on my 
pendings. I have tested, and these are the issues I have found:

- Module doesn't install because you have on __init__.py "from . import 
report", but there is no __init__.py on that folder. Please remove this line.
- Module title put "ProFormat" instead of "Pro Forma"
- When I try to print the report, I get:

SyntaxError: JSON.parse: unexpected end of data at line 2 column 1 of the JSON 
data

Regards.
-- 
https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:sale-reports.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0_lp914670_update_picking_date into lp:ocb-addons

2014-06-18 Thread Ronald Portier (Therp) 
Updated merge proposal according to suggestion from Pedro Manual Baeza.

Much better this way!
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0_lp914670_update_picking_date/+merge/223551
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-reports/vre-sale_order_proformat into lp:sale-reports

2014-06-18 Thread Vincent Renaville@camptocamp 
Vincent Renaville@camptocamp has proposed merging 
lp:~camptocamp/sale-reports/vre-sale_order_proformat into lp:sale-reports.

Requested reviews:
  Sale Core Editors (sale-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563

Hello,

This add a report for proforma required for the customs.

Thanks,

Vincent
-- 
https://code.launchpad.net/~camptocamp/sale-reports/vre-sale_order_proformat/+merge/223563
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:sale-reports.
=== added directory 'sale_order_proforma_webkit'
=== added file 'sale_order_proforma_webkit/__init__.py'
--- sale_order_proforma_webkit/__init__.py	1970-01-01 00:00:00 +
+++ sale_order_proforma_webkit/__init__.py	2014-06-18 13:58:46 +
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+##
+#
+#   Copyright (c) 2014 Camptocamp SA (http://www.camptocamp.com)
+#   @author Romain Deheele ,Vincent Renaville 
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+from . import report

=== added file 'sale_order_proforma_webkit/__openerp__.py'
--- sale_order_proforma_webkit/__openerp__.py	1970-01-01 00:00:00 +
+++ sale_order_proforma_webkit/__openerp__.py	2014-06-18 13:58:46 +
@@ -0,0 +1,43 @@
+# -*- coding: utf-8 -*-
+##
+#
+#   Copyright (c) 2014 Camptocamp SA (http://www.camptocamp.com)
+# @author Romain Deheele ,Vincent Renaville 
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+{'name': 'Sales Order ProFormat Report using Webkit Library',
+ 'version': '1.1.1',
+ 'category': 'Reports/Webkit',
+ 'description': """
+Sale order webkit
+#
+
+* Add a sale proforma report in webkit .
+
+Depends on base_header_webkit community addon available here:
+`https://launchpad.net/webkit-utils `_
+""",
+ 'author': 'Camptocamp',
+ 'website': 'http://www.camptocamp.com',
+ 'depends': ['base', 'report_webkit', 'base_headers_webkit', 'sale'],
+ 'data': ['report.xml',
+  ],
+ 'demo_xml': [],
+ 'test': [],
+ 'installable': True,
+ 'active': False,
+ }

=== added directory 'sale_order_proforma_webkit/i18n'
=== added file 'sale_order_proforma_webkit/i18n/en.po'
--- sale_order_proforma_webkit/i18n/en.po	1970-01-01 00:00:00 +
+++ sale_order_proforma_webkit/i18n/en.po	2014-06-18 13:58:46 +
@@ -0,0 +1,114 @@
+#. module: sale_report_proforma
+#: report:addons/sale_report_proforma/report/sale_proforma.mako:301
+msgid "Thank you for your prompt payment"
+msgstr "Thank you for your prompt payment"
+
+ 
+#. module: sale_report_proforma
+#: report:addons/sale_report_proforma/report/sale_proforma.mako:218
+msgid "Responsible"
+msgstr "Responsible"
+
+#. module: sale_report_proforma
+#: report:addons/sale_report_proforma/report/sale_proforma.mako:211
+msgid "Subject : "
+msgstr "Subject : "
+
+ 
+#. module: sale_report_proforma
+#: report:addons/sale_report_proforma/report/sale_proforma.mako:243
+msgid "Unit Price"
+msgstr "Unit Price"
+
+ 
+#. module: sale_report_proforma
+#: report:addons/sale_report_proforma/report/sale_proforma.mako:245
+msgid "Disc.(%)"
+msgstr "Disc.(%)"
+
+#. module: sale_report_proforma
+#: report:addons/sale_report_proforma/report/sale_proforma.mako:208
+msgid "PRO-FORMA"
+msgstr "PRO-FORMA"
+
+#. module: sale_report_proforma
+#: report:addons/sale_report_proforma/report/sale_proforma.mako:28

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0_lp914670_update_picking_date into lp:ocb-addons

2014-06-18 Thread Pedro Manuel Baeza 
Review: Approve code review

I see the code more elegant in this way, but it doesn't really matter:

picking_ids = set()
for move_obj in move_pool.browse(cr, uid, ids, context=context):
if move_obj.picking_id:
picking_ids.add(move_obj.picking_id.id)
return list(picking_ids)

Regards.
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0_lp914670_update_picking_date/+merge/223551
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:account-invoice-report

2014-06-18 Thread Lorenzo Battistini - Agile BG 
Hello Yannick and Vincent,

I renamed list_invoice_table to list_main_table.

As you saw, in order to fix bug 1277024 we had to remove the nested tables but 
this reintroduced the bug 1231329.
In order to fix bug 1231329, I moved the formatted_note within the 'nobreak' 
div containing line.name

See the result of the new layout at https://app.box.com/s/0i8ra35jlnqken7dvp7n

Thanks

-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:account-invoice-report

2014-06-18 Thread Alex Comba - Agile BG 
Alex Comba - Agile BG has proposed merging 
lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into 
lp:account-invoice-report.

Commit message:
[FIX] invoice_webkit bugs: #1208389, #1231329 and #1277024

Requested reviews:
  Vincent Renaville@camptocamp (vrenaville-c2c)
  Yannick Vaucher @ Camptocamp (yvaucher-c2c)
  Lorenzo Battistini - Agile BG (elbati)
Related bugs:
  Bug #1208389 in Account - Invoicing Reports: "[7.0] invoice_webkit - invoice 
line does not print line description"
  https://bugs.launchpad.net/account-invoice-report/+bug/1208389
  Bug #1231329 in Account - Invoicing Reports: "[7.0] invoice_webkit - lines 
are separated from their description on page break"
  https://bugs.launchpad.net/account-invoice-report/+bug/1231329
  Bug #1277024 in Account - Invoicing Reports: "[7.0] invoice_webkit - 
'Description' field overlaps the next one 'Qty' when it is very long"
  https://bugs.launchpad.net/account-invoice-report/+bug/1277024

For more details, see:
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204

Merge proposal to fix the following bugs:

https://bugs.launchpad.net/account-invoice-report/+bug/1208389
https://bugs.launchpad.net/account-invoice-report/+bug/1231329
https://bugs.launchpad.net/account-invoice-report/+bug/1277024

As explained in the bug #1277024 report.
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.
=== modified file 'invoice_webkit/report/account_invoice.mako'
--- invoice_webkit/report/account_invoice.mako	2014-05-01 15:23:35 +
+++ invoice_webkit/report/account_invoice.mako	2014-06-18 13:27:10 +
@@ -9,92 +9,34 @@
 text-align:center;
 border-collapse: collapse;
 }
-table.list_main_table {
-margin-top: 20px;
-}
-.list_main_headers {
-padding: 0;
-}
-.list_main_headers th {
+.list_main_table th {
+background-color: #EE;
 border: thin solid #00;
+text-align:center;
+font-size:12;
+font-weight:bold;
 padding-right:3px;
 padding-left:3px;
-background-color: #EE;
-text-align:center;
-font-size:12;
-font-weight:bold;
 }
 .list_main_table td {
+border-top : thin solid #EE;
+text-align:left;
+font-size:12;
 padding-right:3px;
 padding-left:3px;
 padding-top:3px;
 padding-bottom:3px;
 }
-.list_main_lines,
-.list_main_footers {
-padding: 0;
-}
-.list_main_footers {
-padding-top: 15px;
-}
-.list_main_lines td,
-.list_main_footers td,
-.list_main_footers th {
-border-style: none;
-text-align:left;
-font-size:12;
-padding:0;
-}
-.list_main_footers th {
-text-align:right;
-}
-
-td .total_empty_cell {
-width: 77%;
-}
-td .total_sum_cell {
-width: 13%;
-}
-
-.nobreak {
-page-break-inside: avoid;
-}
-caption.formatted_note {
-text-align:left;
-border-right:thin solid #EE;
-border-left:thin solid #EE;
-border-top:thin solid #EE;
+.list_main_table thead {
+display:table-header-group;
+}
+
+div.formatted_note {
+text-align:left;
 padding-left:10px;
 font-size:11;
-caption-side: bottom;
-}
-caption.formatted_note p {
-margin: 0;
 }
 
-.main_col1 {
-width: 40%;
-}
-td.main_col1 {
-text-align:left;
-}
-.main_col2,
-.main_col3,
-.main_col4,
-.main_col6 {
-width: 10%;
-}
-.main_col5 {
-width: 7%;
-}
-td.main_col5 {
-text-align: center;
-font-style:italic;
-font-size: 10;
-}
-.main_col7 {
-width: 13%;
-}
 
 .list_bank_table {
 text-align:center;
@@ -169,6 +111,11 @@
 display:table-header-group;
 }
 
+
+.no_bloc {
+border-top: thin solid  #ff ;
+}
+
 .right_table {
 right: 4cm;
 width:"100%";
@@ -178,6 +125,10 @@
 font-size:12;
 }
 
+tfoot.totals tr:first-child td{
+padding-top: 15px;
+}
+
 th.date {
 width: 90px;
 }
@@ -186,6 +137,19 @@
 text-align: right;
 white-space: nowrap;
 }
+.header_table {
+text-align: center;
+border: 1px solid lightGrey;
+border-collapse: collapse;
+}
+.header_table th {
+font-size: 12px;
+border: 1px solid lightGrey;
+}
+.header_table td {
+font-size: 12px;
+border: 1px solid lightGrey;
+}
 
 td.date {
 white-space: nowrap;
@@ -202,6 +166,14 @@
 float: right;
 }
 
+.nobreak {
+ page-break-inside: avoid;
+ }
+
+.align_top {
+ vertical-align:text-top;
+ }
+
 
 
 
@@ -300,87 +272,62 @@
 %endif
 
 
-
-  
-
-  
-
-  
-${_("Description")}
-${_("Qty")}
-${_("UoM")}
-${_("Unit Price")}
-${_("Taxes")}
-${_("Disc.(%)")}
-${_("Net Sub Total")}
-  
-
-  
-
-  
-  
-%for line in inv.invoice_l

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0_lp914670_update_picking_date into lp:ocb-addons

2014-06-18 Thread Sébastien BEAU - http : //www . akretion . com 
Review: Approve code review, no test

Great fix ! Approve
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0_lp914670_update_picking_date/+merge/223551
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0_lp914670_update_picking_date into lp:ocb-addons

2014-06-18 Thread Raphaël Valyi - http : //www . akretion . com 
Review: Approve

LGTM
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0_lp914670_update_picking_date/+merge/223551
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~therp-nl/ocb-addons/7.0_lp914670_update_picking_date into lp:ocb-addons

2014-06-18 Thread Ronald Portier (Therp) 
Ronald Portier (Therp) has proposed merging 
lp:~therp-nl/ocb-addons/7.0_lp914670_update_picking_date into lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports (ocb)
Related bugs:
  Bug #914670 in OpenERP Community Backports (Addons): "[STOCK] 6.0 6.1 change 
move date don't update picking date"
  https://bugs.launchpad.net/ocb-addons/+bug/914670

For more details, see:
https://code.launchpad.net/~therp-nl/ocb-addons/7.0_lp914670_update_picking_date/+merge/223551

Fixes lp 914670. Expected date on stock.picking should change (be recomputed) 
when expected date on stock.move changes.
-- 
https://code.launchpad.net/~therp-nl/ocb-addons/7.0_lp914670_update_picking_date/+merge/223551
Your team OpenERP Community Backports is requested to review the proposed merge 
of lp:~therp-nl/ocb-addons/7.0_lp914670_update_picking_date into lp:ocb-addons.
=== modified file 'stock/stock.py'
--- stock/stock.py	2014-05-12 08:21:37 +
+++ stock/stock.py	2014-06-18 13:06:34 +
@@ -629,6 +629,18 @@
 res[pick]['min_date'] = dt1
 res[pick]['max_date'] = dt2
 return res
+
+def _get_stock_move_changes(self, cr, uid, ids, context=None):
+'''Return the ids of pickings that should change, due to changes
+in stock moves.'''
+move_pool = self.pool['stock.move']
+picking_ids = []
+for move_obj in move_pool.browse(cr, uid, ids, context=context):
+if move_obj.picking_id:
+picking_id = move_obj.picking_id.id
+if picking_id not in picking_ids:
+picking_ids.append(picking_id)
+return picking_ids
 
 def create(self, cr, user, vals, context=None):
 if ('name' not in vals) or (vals.get('name')=='/'):
@@ -664,12 +676,31 @@
 * Transferred: has been processed, can't be modified or cancelled anymore\n
 * Cancelled: has been cancelled, can't be confirmed anymore"""
 ),
-'min_date': fields.function(get_min_max_date, fnct_inv=_set_minimum_date, multi="min_max_date",
- store=True, type='datetime', string='Scheduled Time', select=1, help="Scheduled time for the shipment to be processed"),
+'min_date': fields.function(
+get_min_max_date,
+fnct_inv=_set_minimum_date, multi='min_max_date',
+store={
+'stock.move': (
+_get_stock_move_changes,
+['date_expected'], 10,
+)
+},
+type='datetime', string='Scheduled Time', select=True,
+help="Scheduled time for the shipment to be processed"
+),
 'date': fields.datetime('Creation Date', help="Creation date, usually the time of the order.", select=True, states={'done':[('readonly', True)], 'cancel':[('readonly',True)]}),
 'date_done': fields.datetime('Date of Transfer', help="Date of Completion", states={'done':[('readonly', True)], 'cancel':[('readonly',True)]}),
-'max_date': fields.function(get_min_max_date, fnct_inv=_set_maximum_date, multi="min_max_date",
- store=True, type='datetime', string='Max. Expected Date', select=2),
+'max_date': fields.function(
+get_min_max_date,
+fnct_inv=_set_maximum_date, multi='min_max_date',
+store={
+'stock.move': (
+_get_stock_move_changes,
+['date_expected'], 10,
+)
+},
+type='datetime', string='Max. Expected Date', select=True
+),
 'move_lines': fields.one2many('stock.move', 'picking_id', 'Internal Moves', states={'done': [('readonly', True)], 'cancel': [('readonly', True)]}),
 'product_id': fields.related('move_lines', 'product_id', type='many2one', relation='product.product', string='Product'),
 'auto_picking': fields.boolean('Auto-Picking', states={'done':[('readonly', True)], 'cancel':[('readonly',True)]}),

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows

2014-06-18 Thread Romain Deheele - Camptocamp 
Your remark makes sense about canceled pickings.
Maybe it's better to let freedom to developers to specify access 
rights/visibility according to the context.

-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers/+merge/223529
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-flows.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows

2014-06-18 Thread Pedro Manuel Baeza 
Review: Needs Information code review

Well, I think that this function is both used by warehouse managers and users: 
I see not much sense to contact a manager to reopen one picking canceled by 
error. But maybe for done pickings, re-open task is more sensible.

What do you think?

Regards.
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers/+merge/223529
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-flows.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into lp:sale-wkfl

2014-06-18 Thread Alex Comba - Agile BG 
Alex Comba - Agile BG has proposed merging 
lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into 
lp:sale-wkfl.

Commit message:
 [ADD] module 'sale_line_quantity_properties_based'

Requested reviews:
  Sale Core Editors (sale-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7/+merge/223538

This branch adds the module 'sale_line_quantity_properties_based' which allows 
the calculation of the product quantity on the basis of a formula that 
considers the properties specified by the user on the sale order line and on 
the quantity (UoS).

The module description contains an example to explain how this module works.
-- 
https://code.launchpad.net/~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7/+merge/223538
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into 
lp:sale-wkfl.
=== added directory 'sale_line_quantity_properties_based'
=== added file 'sale_line_quantity_properties_based/__init__.py'
--- sale_line_quantity_properties_based/__init__.py	1970-01-01 00:00:00 +
+++ sale_line_quantity_properties_based/__init__.py	2014-06-18 10:58:40 +
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alex Comba 
+#Copyright (C) 2014 Agile Business Group sagl
+#()
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as published
+#by the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+from . import sale

=== added file 'sale_line_quantity_properties_based/__openerp__.py'
--- sale_line_quantity_properties_based/__openerp__.py	1970-01-01 00:00:00 +
+++ sale_line_quantity_properties_based/__openerp__.py	2014-06-18 10:58:40 +
@@ -0,0 +1,100 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Author: Alex Comba 
+#Copyright (C) 2014 Agile Business Group sagl
+#()
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as published
+#by the Free Software Foundation, either version 3 of the License, or
+#(at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+{
+'name': "Sale line quantity properties based",
+'version': '0.1',
+'category': 'Sales Management',
+'description': """
+Sale line quantity based on line properties
+===
+
+*This module allows the calculation of the product quantity on the basis of a
+formula that considers the properties specified by the user on the sale order
+line and on the quantity (UoS).*
+
+Example
+
+
+Provided the sale of a given number of pieces (shelves), that may be
+’x’ meter long and ’y’ meter large, the formula enables the calculation of the
+total area sold expressed in square meters:
+10 [pcs of] (4 m x 0.5 m) shelves = 20 m² of wood
+
+In order to have this function working, it is necessary to have the user
+proceeding as follows:
+
+before starting, s/he has to belong to **sale.group_mrp_properties** by
+selecting the option "Invoice products in a different unit of measure than the
+sales order" in the following menu: **Settings --> Configration --> Warehouse** 
+
+Then s/he shall create properties such as ‘length 4’, ‘width 0.5’. 
+
+Properties must respond the following criteria:
+
+* Name: ‘length 1’, ‘length 4’, ‘width 0.5’
+* Property Group : either ‘length’ or ‘width’
+* Description : the corresponding quantity (1, 4, 0.5...)
+
+Property 'length 4' 
+* Name: ‘length 4’
+* Property Group : ‘length’
+* Description : 4
+
+Property 'width 0

[Openerp-community-reviewer] [Bug 1261322] Re: [6.1][7.0][trunk] Default report filename is useless in daily use

2014-06-18 Thread Ronald Portier (Therp) 
** Changed in: ocb-web/7.0
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Web).
https://bugs.launchpad.net/bugs/1261322

Title:
  [6.1][7.0][trunk] Default report filename is useless in daily use

Status in OpenERP Community Backports (Web):
  Fix Released
Status in OpenERP Community Backports (Web) 6.1 series:
  Fix Released
Status in OpenERP Community Backports (Web) 7.0 series:
  Fix Released
Status in Odoo Web:
  New

Bug description:
  This bug report is related to a question asked [1] on stackoverflow.
  The main idea is to allow the user to download its report with a reliable 
filename:
   -"PO6.pdf" instead of "Request For Quotation.pdf" for a single object 
report
   -"PO6-PO2.pdf" instead of "Request For Quotation.pdf" for a multiple 
objects report

  My proposal is to use the object field name if exists and else to use the 
current behavior to create the report filename.
  (Note that the browser will trim invalid filename data like slash, backslash, 
etc.)

  [1] http://stackoverflow.com/questions/14434846/openerp-custom-report-
  filename

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-web/+bug/1261322/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Bug 914670] Re: [STOCK] 6.0 6.1 change move date don't update picking date

2014-06-18 Thread Ronald Portier (Therp) 
The problem still exists in OpenERP 7.0, and is much annoying to one of
our clients, where we installed the very useful module(s) from Akretion.

** Also affects: ocb-addons
   Importance: Undecided
   Status: New

** Also affects: ocb-addons/7.0
   Importance: Undecided
   Status: New

** Changed in: ocb-addons/7.0
   Importance: Undecided => Medium

** Changed in: ocb-addons/7.0
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Addons).
https://bugs.launchpad.net/bugs/914670

Title:
  [STOCK] 6.0 6.1 change move date don't update picking date

Status in OpenERP Community Backports (Addons):
  Confirmed
Status in OpenERP Community Backports (Addons) 7.0 series:
  Confirmed
Status in Odoo Addons:
  Incomplete

Bug description:
  Hi
  I found a bug in stock module.

  Scenario:
  Create a sale order
  Validate it
  Using the menu "Product Move => Delivery Product"
  open on line of the "stock move" generated by the sale order
  change the "planned date" of the "stock move"
  save
  Now Open the picking related to this move
  Check the max date

  => the "max date" was not updated.

  Indeed the "max date" on the "stock.picking" have the option
  store=True

  'max_date': fields.function(get_min_max_date, 
fnct_inv=_set_maximum_date, multi="min_max_date",
   store=True, type='datetime', string='Max. Expected Date', 
select=2),

  It's the same for "min date"

  'min_date': fields.function(get_min_max_date, 
fnct_inv=_set_minimum_date, multi="min_max_date",
   store=True, type='datetime', string='Expected Date', 
select=1, help="Expected date for the picking to be processed"),

  You should add invalidation function for this two computed fields.

  Best regards

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/914670/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into lp:purchase-report

2014-06-18 Thread Romain Deheele - Camptocamp 
Review: Approve code review

ok
-- 
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into 
lp:purchase-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into lp:purchase-report

2014-06-18 Thread Alex Comba - Agile BG 
Review: Approve


-- 
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into 
lp:purchase-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into lp:purchase-report

2014-06-18 Thread Lorenzo Battistini - Agile BG 
Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into 
lp:purchase-report.

Requested reviews:
  Purchase Core Editors (purchase-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531

[FIX] purchase-report-7.0/purchase_order_webkit/__init__.py", line 31, in 

from . import purchase_order
ImportError: cannot import name purchase_order
-- 
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into 
lp:purchase-report.
=== modified file 'purchase_order_webkit/__init__.py'
--- purchase_order_webkit/__init__.py	2014-04-16 07:35:50 +
+++ purchase_order_webkit/__init__.py	2014-06-18 10:02:23 +
@@ -28,4 +28,3 @@
 ##
 
 from . import report
-from . import purchase_order
\ No newline at end of file

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows

2014-06-18 Thread Romain Deheele - Camptocamp 
Romain Deheele - Camptocamp has proposed merging 
lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers
 into lp:stock-logistic-flows.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers/+merge/223529

Hello,

stock_cancel addon introduces a button named "re-open" that allows to re-open a 
done or canceled picking.
It seems that in practical it's safer to restrict this feature to warehouse 
managers.
What do you think about it?

Feel free to share your opinion,

Romain
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers/+merge/223529
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers
 into lp:stock-logistic-flows.
=== modified file 'stock_cancel/stock_view.xml'
--- stock_cancel/stock_view.xml	2013-06-05 14:38:18 +
+++ stock_cancel/stock_view.xml	2014-06-18 09:46:16 +
@@ -8,7 +8,8 @@
 
 
 
-
+
 
 
 		
@@ -19,7 +20,8 @@
 
 
 
-
+
 
 
 		
@@ -30,7 +32,8 @@
 			
 			
 
-	
+	
 
 			
 		

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into lp:purchase-report

2014-06-18 Thread Lorenzo Battistini - Agile BG 
The proposal to merge 
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into 
lp:purchase-report has been updated.

Description changed to:

[FIX] purchase-report-7.0/purchase_order_webkit/__init__.py", line 31, in 

from . import purchase_order
ImportError: cannot import name purchase_order

For more details, see:
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531
-- 
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into 
lp:purchase-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account into lp:partner-contact-management

2014-06-18 Thread Yannick Vaucher @ Camptocamp 
Thanks for the review Ana

My point about title_bank_account is that most of Models have standard `name` 
and `description` fields.
I agree having a second field description is quiet useful to add note on the 
object when you open it.

However as res.partner.bank is already a bank account, naming a field 
xxx_bank_account seams also redundant. Thus I think it is badly named.

Still, module description doesn't match what the module does. This is more 
about adding fields for informations than allowing to manage multiple bank 
accounts. Or am I missing something?
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account/+merge/204047
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp