Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report

2014-06-20 Thread Alex Comba - Agile BG
Review: Approve code review


-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi into lp:account-financial-report

2014-06-20 Thread Laurent Mignon (Acsone)
Hi,
s
Following a discussion with Christophe Simonis at Opendays, an alternative to 
the migration script for fresh install has been implemented 
(https://github.com/odoo/odoo/commit/4105b5f0285821d8056c721b5fd50b9cae902988and)
 and merged for V8. For V7 the system will remain unchanged. It's now probably 
safe to merge this MP for V7 and use the new post_init_hook in the future V8 
branch...
-- 
https://code.launchpad.net/~acsone-openerp/account-financial-report/7.0-bug-1312732-lmi/+merge/217240
Your team Account Report Core Editors is subscribed to branch 
lp:account-financial-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe into lp:stock-logistic-barcode

2014-06-20 Thread Pedro Manuel Baeza
The proposal to merge 
lp:~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe into 
lp:stock-logistic-barcode has been updated.

Description changed to:

Rename hight to height

Integrate and enhance Sébastien Gendre's fix, add a migration script.

For more details, see:
https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe/+merge/223866
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe/+merge/223866
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-barcode.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe into lp:stock-logistic-barcode

2014-06-20 Thread Pedro Manuel Baeza
Review: Approve code review

Thank you very much for the MP and the migration script.

LGTM.

Regards.
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe/+merge/223866
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-barcode.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_product_customer_code_invoice into lp:account-invoicing

2014-06-20 Thread Raphaël Valyi - http : //www . akretion . com
Review: Approve

LGTM, also proceeding with the merge now as pending merge was just processed 
and as we got 2 approvals here.
-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_product_customer_code_invoice/+merge/202469
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_product_customer_code_invoice into lp:account-invoicing

2014-06-20 Thread noreply
The proposal to merge 
lp:~agilebg/account-invoicing/adding_product_customer_code_invoice into 
lp:account-invoicing has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~agilebg/account-invoicing/adding_product_customer_code_invoice/+merge/202469
-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_product_customer_code_invoice/+merge/202469
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-06-20 Thread Raphaël Valyi - http : //www . akretion . com
Review: Approve

LGTM, pending merges have been processed now
-- 
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-flows.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

2014-06-20 Thread Holger Brunn (Therp)
Thanks for your review Pedro! I basically rewrote the code, you might want to 
have another test.

The two colons are rst for preformatted text: 
http://docutils.sourceforge.net/docs/user/rst/quickref.html#literal-blocks
-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-06-20 Thread Pedro Manuel Baeza
Review: Needs Fixing code review

I have made some comments inline, and I wonder if the module name wouldn't be 
better as stock_picking_product_customer_code to follow current core 
conventions (more or less, you know that there is no written rules).

Regards.

Diff comments:

 === added directory 'product_customer_code_picking'
 === added file 'product_customer_code_picking/__init__.py'
 --- product_customer_code_picking/__init__.py 1970-01-01 00:00:00 +
 +++ product_customer_code_picking/__init__.py 2014-01-21 14:55:23 +
 @@ -0,0 +1,21 @@
 +# -*- coding: utf-8 -*-
 +##
 +#
 +#Copyright (C) 2013 Agile Business Group sagl (http://www.agilebg.com)
 +#Author: Nicola Malcontenti nicola.malconte...@agilebg.com
 +#
 +#This program is free software: you can redistribute it and/or modify
 +#it under the terms of the GNU Affero General Public License as published
 +#by the Free Software Foundation, either version 3 of the License, or
 +#(at your option) any later version.
 +#
 +#This program is distributed in the hope that it will be useful,
 +#but WITHOUT ANY WARRANTY; without even the implied warranty of
 +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +#GNU Affero General Public License for more details.
 +#
 +#You should have received a copy of the GNU Affero General Public License
 +#along with this program.  If not, see http://www.gnu.org/licenses/.
 +#
 +##
 +from . import stock_picking
 
 === added file 'product_customer_code_picking/__openerp__.py'
 --- product_customer_code_picking/__openerp__.py  1970-01-01 00:00:00 
 +
 +++ product_customer_code_picking/__openerp__.py  2014-01-21 14:55:23 
 +
 @@ -0,0 +1,44 @@
 +# -*- coding: utf-8 -*-
 +##
 +#
 +#Copyright (C) 2013 Agile Business Group sagl (http://www.agilebg.com)
 +#Author: Nicola Malcontenti nicola.malconte...@agilebg.com
 +#
 +#This program is free software: you can redistribute it and/or modify
 +#it under the terms of the GNU Affero General Public License as published
 +#by the Free Software Foundation, either version 3 of the License, or
 +#(at your option) any later version.
 +#
 +#This program is distributed in the hope that it will be useful,
 +#but WITHOUT ANY WARRANTY; without even the implied warranty of
 +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +#GNU Affero General Public License for more details.
 +#
 +#You should have received a copy of the GNU Affero General Public License
 +#along with this program.  If not, see http://www.gnu.org/licenses/.
 +#
 +##
 +{
 +name : Product Customer code for stock picking,
 +version : 1.0,
 +author : Agile Business Group,
 +website : http://www.agilebg.com;,
 +category : Stock,
 +depends : [
 +'base',
 +'product',
 +'stock',
 +'product_customer_code'
 +],
 +description: 
 +Based on product_customer_code,
 +this module loads in every stock picking
 +the customer code defined in the product,
 +,
 +demo : [],
 +data : [
 +'stock_picking_view.xml',
 +],
 +'installable' : True,
 +'active' : False,
 +}
 
 === added directory 'product_customer_code_picking/i18n'
 === added file 'product_customer_code_picking/i18n/it.po'
 --- product_customer_code_picking/i18n/it.po  1970-01-01 00:00:00 +
 +++ product_customer_code_picking/i18n/it.po  2014-01-21 14:55:23 +
 @@ -0,0 +1,33 @@
 +# Translation of OpenERP Server.
 +# This file contains the translation of the following modules:
 +#* product_customer_code_picking
 +#
 +msgid 
 +msgstr 
 +Project-Id-Version: OpenERP Server 7.0\n
 +Report-Msgid-Bugs-To: \n
 +POT-Creation-Date: 2014-01-15 14:28+\n
 +PO-Revision-Date: 2014-01-15 15:29+0100\n
 +Last-Translator: \n
 +Language-Team: \n
 +MIME-Version: 1.0\n
 +Content-Type: text/plain; charset=UTF-8\n
 +Content-Transfer-Encoding: 8bit\n
 +Plural-Forms: \n
 +Language: it\n
 +X-Generator: Poedit 1.6.2\n
 +
 +#. module: product_customer_code_picking
 +#: field:stock.move,product_customer_code:0
 +msgid Product Customer Code
 +msgstr Codice Prodotto Cliente
 +
 +#. module: product_customer_code_picking
 +#: model:ir.model,name:product_customer_code_picking.model_stock_move
 +msgid Stock Move
 +msgstr Movimento di magazzino
 +
 +#. module: product_customer_code_picking
 +#: model:ir.model,name:product_customer_code_picking.model_stock_picking
 +msgid Picking List
 +msgstr Documento di trasporto
 
 === added file 
 'product_customer_code_picking/i18n/product_customer_code_picking.pot'
 --- 

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe into lp:stock-logistic-barcode

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review no tests

LGTM thanks
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe/+merge/223866
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-barcode.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

2014-06-20 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging 
lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports.

Requested reviews:
  Sale Core Editors (sale-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871

In order to solve https://bugs.launchpad.net/sale-reports/+bug/1331541
i have made this change
-- 
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports.
=== modified file 'sale_order_webkit/sale_report.xml'
--- sale_order_webkit/sale_report.xml	2013-01-24 10:40:06 +
+++ sale_order_webkit/sale_report.xml	2014-06-20 08:24:55 +
@@ -7,7 +7,11 @@
 model=sale.order
 file=sale_order_webkit/report/sale_order.mako
 string=Quotation - Order
-webkit_header=base_headers_webkit.base_reports_portrait_header
 report_type=webkit/
-  /data
+  /data/
+  data noupdate=1
+record id=sale.report_sale_order model=ir.actions.report.xml
+   field name=webkit_header ref=base_headers_webkit.base_reports_portrait_header/field
+/record
+   /data
 /openerp

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/vre-budget-responsible-group into lp:account-budgeting

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, test

LGTM

Thanks
-- 
https://code.launchpad.net/~camptocamp/account-budgeting/vre-budget-responsible-group/+merge/223705
Your team Account Core Editors is subscribed to branch lp:account-budgeting.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe into lp:stock-logistic-barcode

2014-06-20 Thread noreply
The proposal to merge 
lp:~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe into 
lp:stock-logistic-barcode has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe/+merge/223866
-- 
https://code.launchpad.net/~camptocamp/stock-logistic-barcode/7.0-fix_1330459-sge+afe/+merge/223866
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-barcode.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

2014-06-20 Thread Alex Comba - Agile BG
Review: Approve code review


-- 
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:sale-reports.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report

2014-06-20 Thread Alexandre Fayolle - camptocamp
Review: Approve code review, no tests

LGTM
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report

2014-06-20 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~agilebg/account-invoice-report/7_fix_1221570 into 
lp:account-invoice-report has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review, no test

Thanks

LGTM
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report

2014-06-20 Thread noreply
The proposal to merge lp:~agilebg/account-invoice-report/7_fix_1221570 into 
lp:account-invoice-report has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Thanks again Lorenzo, will be a time saver.
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

2014-06-20 Thread Yannick Vaucher @ Camptocamp
The proposal to merge lp:~agilebg/sale-reports/7_fix_1331541 into 
lp:sale-reports has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
-- 
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:sale-reports.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Review: Approve code review


-- 
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:sale-reports.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0

2014-06-20 Thread Guewen Baconnier @ Camptocamp
Hi,

It seems nice.

I left a few comments in the diff. I won't really block on them but you should 
have a look.

Diff comments:

 === added directory 'cmis_read'
 === added file 'cmis_read/__init__.py'
 --- cmis_read/__init__.py 1970-01-01 00:00:00 +
 +++ cmis_read/__init__.py 2014-06-12 19:57:17 +
 @@ -0,0 +1,25 @@
 +# -*- encoding: utf-8 -*-
 +##
 +#
 +#OpenERP, Open Source Management Solution
 +#This module copyright (C) 2014 Savoir-faire Linux
 +#(http://www.savoirfairelinux.com).
 +#
 +#This program is free software: you can redistribute it and/or modify
 +#it under the terms of the GNU Affero General Public License as
 +#published by the Free Software Foundation, either version 3 of the
 +#License, or (at your option) any later version.
 +#
 +#This program is distributed in the hope that it will be useful,
 +#but WITHOUT ANY WARRANTY; without even the implied warranty of
 +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +#GNU Affero General Public License for more details.
 +#
 +#You should have received a copy of the GNU Affero General Public License
 +#along with this program.  If not, see http://www.gnu.org/licenses/.
 +#
 +##
 +
 +from . import wizard
 +
 +# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
 
 === added file 'cmis_read/__openerp__.py'
 --- cmis_read/__openerp__.py  1970-01-01 00:00:00 +
 +++ cmis_read/__openerp__.py  2014-06-12 19:57:17 +
 @@ -0,0 +1,74 @@
 +# -*- encoding: utf-8 -*-
 +##
 +#
 +#OpenERP, Open Source Management Solution
 +#This module copyright (C) 2014 Savoir-faire Linux
 +#(http://www.savoirfairelinux.com).
 +#
 +#This program is free software: you can redistribute it and/or modify
 +#it under the terms of the GNU Affero General Public License as
 +#published by the Free Software Foundation, either version 3 of the
 +#License, or (at your option) any later version.
 +#
 +#This program is distributed in the hope that it will be useful,
 +#but WITHOUT ANY WARRANTY; without even the implied warranty of
 +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +#GNU Affero General Public License for more details.
 +#
 +#You should have received a copy of the GNU Affero General Public License
 +#along with this program.  If not, see http://www.gnu.org/licenses/.
 +#
 +##
 +
 +{
 +'name': 'CMIS Read',
 +'version': '0.1',
 +'category': 'Knowledge Management',
 +'summary': 'Store Document File in a Remote CMIS Server',
 +'description': 
 +This module allows you to use the CMIS backend to search in the DMS 
 repository
 +and attach documents to OpenERP records.
 +
 +Configuration
 +=
 +
 +Create a new CMIS backend with the host, login and password.
 +
 +Usage
 +=
 +
 +* On one OpenERP record, click Add from DMS.
 +* Type your query and then click on Search.
 +* Filter your results if necessary
 +* Select the documents you want to attach
 +* Selected documents will be enqueued for importing
 +
 +Contributors
 +
 +* El Hadji Dem (elhadji@savoirfairelinux.com)
 +,
 +'author': 'Savoir-faire Linux',
 +'website': 'www.savoirfairelinux.com',
 +'license': 'AGPL-3',
 +'depends': [
 +'document',
 +'cmis'
 +],
 +'data': [
 +'security/ir.model.access.csv',
 +'wizard/document_wizard_view.xml',
 +],
 +'js': [
 +'static/src/js/document.js'
 +],
 +'qweb': [
 +'static/src/xml/document.xml'
 +],
 +'test': [],
 +'demo': [
 +],
 +'installable': True,
 +'auto_install': False,
 +}
 +
 +# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
 
 === added directory 'cmis_read/i18n'
 === added file 'cmis_read/i18n/cmis_read.pot'
 --- cmis_read/i18n/cmis_read.pot  1970-01-01 00:00:00 +
 +++ cmis_read/i18n/cmis_read.pot  2014-06-12 19:57:17 +
 @@ -0,0 +1,119 @@
 +# Translation of OpenERP Server.
 +# This file contains the translation of the following modules:
 +#* cmis_read
 +#
 +msgid 
 +msgstr 
 +Project-Id-Version: OpenERP Server 7.0\n
 +Report-Msgid-Bugs-To: \n
 +POT-Creation-Date: 2014-03-21 14:55+\n
 +PO-Revision-Date: 2014-03-21 10:55-0500\n
 +Last-Translator: EL Hadji DEM elhadji@savoirfairelinux.com\n
 +Language-Team: \n
 +MIME-Version: 1.0\n
 +Content-Type: text/plain; charset=UTF-8\n
 +Content-Transfer-Encoding: 8bit\n
 +Plural-Forms: \n
 +X-Generator: Poedit 1.5.4\n
 +
 +#. module: cmis_read
 +#: field:ir.attachment.dms,file_id:0
 +msgid File ID
 +msgstr 
 +
 +#. module: cmis_read
 +#: 

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Thanks for the patch
-- 
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:sale-reports.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error into lp:ocb-addons/6.1

2014-06-20 Thread noreply
The proposal to merge 
lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error into 
lp:ocb-addons/6.1 has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794
-- 
https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error/+merge/219794
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-addons/7.0-lp1122155 into lp:ocb-addons

2014-06-20 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review


-- 
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-lp1122155/+merge/217629
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/ocb-addons/7.0-lp1122155 into lp:ocb-addons

2014-06-20 Thread noreply
The proposal to merge lp:~pedro.baeza/ocb-addons/7.0-lp1122155 into 
lp:ocb-addons has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-lp1122155/+merge/217629
-- 
https://code.launchpad.net/~pedro.baeza/ocb-addons/7.0-lp1122155/+merge/217629
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

2014-06-20 Thread Lorenzo Battistini - Agile BG
Review: Needs Fixing

/data/ should be /data
-- 
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:sale-reports.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

2014-06-20 Thread Yannick Vaucher @ Camptocamp
Fixed in merge
-- 
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:sale-reports.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Bug 1329342] Re: stock.fill.inventory doesn't consider all the records

2014-06-20 Thread Lionel Sausin - Numérigraphe
Hi, this was done on purpose because loading all the records at once
brings the server to an out-of-memory condition when there are lots of
stock moves involved. So the loop is here to protect from that by
processing only a limited number of them at a time.


** Changed in: ocb-addons
   Status: New = Invalid

-- 
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Addons).
https://bugs.launchpad.net/bugs/1329342

Title:
  stock.fill.inventory doesn't consider all the records

Status in OpenERP Community Backports (Addons):
  Invalid

Bug description:
  rev 10204 introduce this bad loop:

  MAX_IMPORT_LINES = 1
  for i in range(0, len(all_move_ids), self.MAX_IMPORT_LINES):
  move_ids = all_move_ids[i * self.MAX_IMPORT_LINES:
  (i + 1) * self.MAX_IMPORT_LINES]

  i will have the values: 0, 1, 2, etc.
  so move_ids will be all_move_ids[0:1], all_move_ids[1:10001], 
all_move_ids[2:20001] etc.

  suggestion: move_ids = all_move_ids[i:i + self.MAX_RECORDS]

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1329342/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-report/7_fix_1331543 into lp:stock-logistic-report

2014-06-20 Thread Nicola Malcontenti - Agile BG
Nicola Malcontenti - Agile BG has proposed merging 
lp:~agilebg/stock-logistic-report/7_fix_1331543 into lp:stock-logistic-report.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/stock-logistic-report/7_fix_1331543/+merge/223878

In order to solve,
https://bugs.launchpad.net/stock-logistic-report/+bug/1331543
i propose this fiz
-- 
https://code.launchpad.net/~agilebg/stock-logistic-report/7_fix_1331543/+merge/223878
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of lp:~agilebg/stock-logistic-report/7_fix_1331543 into 
lp:stock-logistic-report.
=== modified file 'stock_picking_webkit/report.xml'
--- stock_picking_webkit/report.xml	2013-12-23 14:23:14 +
+++ stock_picking_webkit/report.xml	2014-06-20 09:32:01 +
@@ -9,8 +9,7 @@
 file=stock_picking_webkit/report/picking.html.mako
 string=Aggregated pickings
 report_type=webkit
-header=False
-webkit_header=base_headers_webkit.base_minimum_reports_portrait_header /
+header=False/
 report id=webkit_aggregated_delivery
 name=webkit.aggregated_delivery
 auto=False
@@ -18,8 +17,7 @@
 file=stock_picking_webkit/report/delivery.html.mako
 string=Aggregated deliveries
 report_type=webkit
-header=False
-webkit_header=base_headers_webkit.base_minimum_reports_portrait_header /
+header=False/
 report id=stock.report_picking_list_out
 name=webkit.delivery_slip
 auto=False
@@ -27,8 +25,26 @@
 file=stock_picking_webkit/report/delivery_slip.mako
 string=Delivery Order
 report_type=webkit
-header=True
-webkit_header=base_headers_webkit.base_reports_portrait_header /
+header=True/
 
   /data
+
+data noupdate=1
+record id=webkit_aggregated_picking model=ir.actions.report.xml
+   field name=webkit_header ref=base_headers_webkit.base_minimum_reports_portrait_header/field
+/record
+/data
+
+data noupdate=1
+record id=webkit_aggregated_delivery model=ir.actions.report.xml
+   field name=webkit_header ref=base_headers_webkit.base_minimum_reports_portrait_header/field
+/record
+/data
+
+data noupdate=1
+record id=stock.report_picking_list_out model=ir.actions.report.xml
+   field name=webkit_header ref=base_headers_webkit.base_reports_portrait_header/field
+/record
+   /data
+
 /openerp

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-fix-decimal-precision into lp:stock-logistic-warehouse

2014-06-20 Thread Lionel Sausin - Numérigraphe
Lionel Sausin - Numérigraphe has proposed merging 
lp:~numerigraphe-team/stock-logistic-warehouse/7.0-fix-decimal-precision into 
lp:stock-logistic-warehouse.

Requested reviews:
  Loïc Bellier - Numérigraphe (lb-b)
  Stock and Logistic Core Editors (stock-logistic-core-editors)

For more details, see:
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-fix-decimal-precision/+merge/223881

In version 7 the name of the digital precision parameter for UoMs has changed : 
this branch updates the modules where the change is missing.
-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-fix-decimal-precision/+merge/223881
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~numerigraphe-team/stock-logistic-warehouse/7.0-fix-decimal-precision into 
lp:stock-logistic-warehouse.
=== modified file 'configurable_stock_level/product.py'
--- configurable_stock_level/product.py	2012-04-04 11:20:48 +
+++ configurable_stock_level/product.py	2014-06-20 09:34:11 +
@@ -48,7 +48,7 @@
 
 _columns = {'configurable_stock_level': fields.function(_compute_configurable_level,
 type='float',
-digits_compute=dp.get_precision('Product UoM'),
+digits_compute=dp.get_precision('Product Unit of Measure'),
 string='Custom level')}
 
 

=== modified file 'stock_available_immediately/product.py'
--- stock_available_immediately/product.py	2014-02-19 11:43:35 +
+++ stock_available_immediately/product.py	2014-06-20 09:34:11 +
@@ -64,7 +64,7 @@
 _product_available,
 multi='qty_available',
 type='float',
-digits_compute=dp.get_precision('Product UoM'),
+digits_compute=dp.get_precision('Product Unit of Measure'),
 string='Quantity On Hand',
 help=Current quantity of products.\n
  In a context with a single Stock Location, this includes 
@@ -82,7 +82,7 @@
 _product_available,
 multi='qty_available',
 type='float',
-digits_compute=dp.get_precision('Product UoM'),
+digits_compute=dp.get_precision('Product Unit of Measure'),
 string='Quantity Available',
 help=Forecast quantity (computed as Quantity On Hand 
  - Outgoing + Incoming)\n
@@ -101,7 +101,7 @@
 _product_available,
 multi='qty_available',
 type='float',
-digits_compute=dp.get_precision('Product UoM'),
+digits_compute=dp.get_precision('Product Unit of Measure'),
 string='Incoming',
 help=Quantity of products that are planned to arrive.\n
  In a context with a single Stock Location, this includes 
@@ -118,7 +118,7 @@
 _product_available,
 multi='qty_available',
 type='float',
-digits_compute=dp.get_precision('Product UoM'),
+digits_compute=dp.get_precision('Product Unit of Measure'),
 string='Outgoing',
 help=Quantity of products that are planned to leave.\n
  In a context with a single Stock Location, this includes 
@@ -133,7 +133,7 @@
  Location typed as 'internal'.),
 'immediately_usable_qty': fields.function(
 _product_available,
-digits_compute=dp.get_precision('Product UoM'),
+digits_compute=dp.get_precision('Product Unit of Measure'),
 type='float',
 string='Immediately Usable',
 multi='qty_available',

=== modified file 'stock_inventory_existing_lines/stock.py'
--- stock_inventory_existing_lines/stock.py	2012-03-07 12:56:37 +
+++ stock_inventory_existing_lines/stock.py	2014-06-20 09:34:11 +
@@ -81,7 +81,7 @@
 'location_id': fields.many2one('stock.location', 'Location', required=True),
 'product_id': fields.many2one('product.product', 'Product', required=True, select=True),
 'product_uom': fields.many2one('product.uom', 'Product UOM', required=True),
-'product_qty': fields.float('Quantity', digits_compute=dp.get_precision('Product UoM')),
+'product_qty': fields.float('Quantity', digits_compute=dp.get_precision('Product Unit of Measure')),
 'company_id': fields.related('inventory_id', 'company_id', type='many2one', relation='res.company', string='Company', store=True, select=True, readonly=True),
 'prod_lot_id': fields.many2one('stock.production.lot', 'Production Lot', domain=[('product_id','=',product_id)]),
 'state': fields.related('inventory_id', 'state', type='char', string='State',readonly=True),

-- 
Mailing list: 

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl

2014-06-20 Thread Guewen Baconnier @ Camptocamp
Review: Needs Fixing

Hi,

I left some diff comments.
I'm also annoyed by the incompatibily introduced by this module (override of 
amount_all and amount_line), but on the other hand there is maybe no other way 
to do that.

Thanks Pedro

Diff comments:

 === added directory 'purchase_discount'
 === added file 'purchase_discount/__init__.py'
 --- purchase_discount/__init__.py 1970-01-01 00:00:00 +
 +++ purchase_discount/__init__.py 2014-05-13 08:16:14 +
 @@ -0,0 +1,22 @@
 +# -*- encoding: utf-8 -*-
 +##
 +#
 +#OpenERP, Open Source Management Solution
 +#Copyright (C) 2004-2009 Tiny SPRL (http://tiny.be).
 +#
 +#This program is free software: you can redistribute it and/or modify
 +#it under the terms of the GNU Affero General Public License as
 +#published by the Free Software Foundation, either version 3 of the
 +#License, or (at your option) any later version.
 +#
 +#This program is distributed in the hope that it will be useful,
 +#but WITHOUT ANY WARRANTY; without even the implied warranty of
 +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +#GNU Affero General Public License for more details.
 +#
 +#You should have received a copy of the GNU Affero General Public License
 +#along with this program.  If not, see http://www.gnu.org/licenses/.
 +#
 +##
 +from . import purchase_discount
 +# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
 
 === added file 'purchase_discount/__openerp__.py'
 --- purchase_discount/__openerp__.py  1970-01-01 00:00:00 +
 +++ purchase_discount/__openerp__.py  2014-05-13 08:16:14 +
 @@ -0,0 +1,48 @@
 +# -*- encoding: utf-8 -*-
 +##
 +#
 +#OpenERP, Open Source Management Solution
 +#Copyright (C) 2004-2009 Tiny SPRL (http://tiny.be).
 +#
 +#This program is free software: you can redistribute it and/or modify
 +#it under the terms of the GNU Affero General Public License as
 +#published by the Free Software Foundation, either version 3 of the
 +#License, or (at your option) any later version.
 +#
 +#This program is distributed in the hope that it will be useful,
 +#but WITHOUT ANY WARRANTY; without even the implied warranty of
 +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +#GNU Affero General Public License for more details.
 +#
 +#You should have received a copy of the GNU Affero General Public License
 +#along with this program.  If not, see http://www.gnu.org/licenses/.
 +#
 +##
 +{
 +name: Purchase order lines with discounts,
 +author: Tiny, Acysos S.L.,
 +description: It allows to define a discount per line in the purchase
 +orders. This discount can be also negative, interpreting it as an increment.
 +
 +**Contributors**:
 + * Pedro Manuel Baeza pedro.ba...@serviciosbaeza.com
 +,
 +version: 1.0,
 +contributors: [
 +'Pedro M. Baeza',
 +],
 +category: Generic Modules/Sales  Purchases,
 +depends: [
 +stock,
 +purchase,
 +],
 +demo: [],
 +data: [
 +purchase_discount_view.xml,
 +account_invoice_view.xml,
 +report/purchase_discount_report.xml,
 +],
 +license: 'AGPL-3',
 +installable: True
 +}
 +# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
 
 === added file 'purchase_discount/account_invoice_view.xml'
 --- purchase_discount/account_invoice_view.xml1970-01-01 00:00:00 
 +
 +++ purchase_discount/account_invoice_view.xml2014-05-13 08:16:14 
 +
 @@ -0,0 +1,17 @@
 +openerp
 +data
 +
 +record id=invoice_supplier_form_discount model=ir.ui.view
 +field name=nameaccount.invoice.supplier.form.discount/field
 +field name=modelaccount.invoice/field
 +field name=typeform/field
 +field name=inherit_id ref=account.invoice_supplier_form/
 +field name=arch type=xml
 +field name=price_unit position=after
 +field name=discount/
 +/field
 +/field
 +/record
 +
 +/data
 +/openerp
 
 === added directory 'purchase_discount/i18n'
 === added file 'purchase_discount/i18n/es.po'
 --- purchase_discount/i18n/es.po  1970-01-01 00:00:00 +
 +++ purchase_discount/i18n/es.po  2014-05-13 08:16:14 +
 @@ -0,0 +1,43 @@
 +# Translation of OpenERP Server.
 +# This file contains the translation of the following modules:
 +#* purchase_discount
 +#
 +msgid 
 +msgstr 
 +Project-Id-Version: OpenERP Server 5.0.11\n
 +Report-Msgid-Bugs-To: supp...@openerp.com\n
 +POT-Creation-Date: 2013-11-07 01:07+\n
 +PO-Revision-Date: 2013-11-08 17:57+\n
 

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-report/7_fix_1331543 into lp:stock-logistic-report

2014-06-20 Thread Pedro Manuel Baeza
Review: Approve code review

LGTM.

Regards.
-- 
https://code.launchpad.net/~agilebg/stock-logistic-report/7_fix_1331543/+merge/223878
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-fix-decimal-precision into lp:purchase-wkfl

2014-06-20 Thread Lionel Sausin - Numérigraphe
Lionel Sausin - Numérigraphe has proposed merging 
lp:~numerigraphe-team/purchase-wkfl/7.0-fix-decimal-precision into 
lp:purchase-wkfl.

Requested reviews:
  Purchase Core Editors (purchase-core-editors)

For more details, see:
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-fix-decimal-precision/+merge/223883

In version 7 the name of the digital precision parameter for UoMs has changed : 
this branch updates the modules where the change is missing.
-- 
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-fix-decimal-precision/+merge/223883
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~numerigraphe-team/purchase-wkfl/7.0-fix-decimal-precision into 
lp:purchase-wkfl.
=== modified file 'purchase_delivery_term/purchase.py'
--- purchase_delivery_term/purchase.py	2013-10-10 07:55:36 +
+++ purchase_delivery_term/purchase.py	2014-06-20 09:43:34 +
@@ -101,7 +101,7 @@
 digits_compute= dp.get_precision('Product Price')),
 'price_subtotal': fields.function(_amount_line, string='Subtotal',
 digits_compute= dp.get_precision('Product Price')),
-'product_qty': fields.float('Quantity', digits_compute=dp.get_precision('Product UoM'), required=True),
+'product_qty': fields.float('Quantity', digits_compute=dp.get_precision('Product Unit of Measure'), required=True),
 'product_uom': fields.many2one('product.uom', 'Product UOM', required=True),
 'order_line_ids': fields.one2many('purchase.order.line',
 'master_line_id', 'Detailed lines'),

=== modified file 'purchase_landed_costs/purchase.py'
--- purchase_landed_costs/purchase.py	2014-03-03 13:49:27 +
+++ purchase_landed_costs/purchase.py	2014-06-20 09:43:34 +
@@ -486,7 +486,7 @@
 string='Landed Costs Total Untaxed'),
 'quantity_total': fields.function(
 _quantity_total,
-digits_compute=dp.get_precision('Product UoM'),
+digits_compute=dp.get_precision('Product Unit of Measure'),
 string='Total Quantity'),
 }
 

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Bug 1329342] Re: stock.fill.inventory doesn't consider all the records

2014-06-20 Thread Stefan Rijnhart (Therp)
No, it seems there is a logical error in the algoritm:

Current implementation:

 for i in range(0, 25, 5):
... print %s:%s % (i * 5, (i+1) * 5)
... 
0:5
25:30
50:55
75:80
100:105

Suggested fix:

 for i in range(0, 25, 5):
... print %s:%s % (i,i + 5)
... 
0:5
5:10
10:15
15:20
20:25


** Changed in: ocb-addons
   Status: Invalid = Confirmed

-- 
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Addons).
https://bugs.launchpad.net/bugs/1329342

Title:
  stock.fill.inventory doesn't consider all the records

Status in OpenERP Community Backports (Addons):
  Confirmed

Bug description:
  rev 10204 introduce this bad loop:

  MAX_IMPORT_LINES = 1
  for i in range(0, len(all_move_ids), self.MAX_IMPORT_LINES):
  move_ids = all_move_ids[i * self.MAX_IMPORT_LINES:
  (i + 1) * self.MAX_IMPORT_LINES]

  i will have the values: 0, 1, 2, etc.
  so move_ids will be all_move_ids[0:1], all_move_ids[1:10001], 
all_move_ids[2:20001] etc.

  suggestion: move_ids = all_move_ids[i:i + self.MAX_RECORDS]

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1329342/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-server/7.0-bug-1319285-translation-overwrite-module-update into lp:ocb-server

2014-06-20 Thread noreply
The proposal to merge 
lp:~yann-papouin/ocb-server/7.0-bug-1319285-translation-overwrite-module-update 
into lp:ocb-server has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~yann-papouin/ocb-server/7.0-bug-1319285-translation-overwrite-module-update/+merge/219468
-- 
https://code.launchpad.net/~yann-papouin/ocb-server/7.0-bug-1319285-translation-overwrite-module-update/+merge/219468
Your team OpenERP Community Backports is subscribed to branch lp:ocb-server.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-report/7_fix_1331543 into lp:stock-logistic-report

2014-06-20 Thread Alex Comba - Agile BG
Review: Approve code review, no test


-- 
https://code.launchpad.net/~agilebg/stock-logistic-report/7_fix_1331543/+merge/223878
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-date-constraint into lp:stock-logistic-warehouse

2014-06-20 Thread Lionel Sausin - Numérigraphe
Review: Disapprove duplicate feature and perfs regression

We don't need this anymore, it is superseded by our other proposal regarding 
exhaustive inventories.
And it would be a burden on stock moves, not good for performance.
Loïc and I used to use this in v6 but we're abandoning it in v7.
Please reject.
-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-date-constraint/+merge/210632
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-date-constraint 
into lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-fix-decimal-precision into lp:purchase-wkfl

2014-06-20 Thread Pedro Manuel Baeza
Review: Approve code review

Good catch!

LGTM.

Regards.
-- 
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-fix-decimal-precision/+merge/223883
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-fix-decimal-precision into lp:stock-logistic-warehouse

2014-06-20 Thread Pedro Manuel Baeza
Review: Approve code review

LGTM.

Regards.
-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-fix-decimal-precision/+merge/223881
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Bug 1319285] Re: Module update does not overwrite existing therms when i18n-overwrite is set

2014-06-20 Thread Pedro Manuel Baeza
** Also affects: ocb-server/6.1
   Importance: Undecided
   Status: New

** Also affects: ocb-server/7.0
   Importance: Undecided
   Status: New

** Changed in: ocb-server/7.0
   Status: New = Fix Released

-- 
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Server).
https://bugs.launchpad.net/bugs/1319285

Title:
  Module update does not overwrite existing therms when i18n-overwrite
  is set

Status in OpenERP Community Backports (Server):
  Fix Released
Status in OpenERP Community Backports (Server) 6.1 series:
  New
Status in OpenERP Community Backports (Server) 7.0 series:
  Fix Released
Status in Odoo Server:
  New

Bug description:
  If the server is started with the --i18n-overwrite  option, it is entirely 
ignored when updating module in these two cases:
  - update from command line
  - update from module view

  In tools/config.py, following is stated:
  the i18n-overwrite option cannot be used without the i18n-import option or 
without the update option

  I made a fix in _load_data in modules/loading.py where a context is created 
with the overwite option (was None before):
  # Update translations for all installed languages
  modobj.update_translations(cr, SUPERUSER_ID, [module_id], None, {'overwrite': 
openerp.tools.config[overwrite_existing_translations]})

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-server/+bug/1319285/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-06-20 Thread Laetitia Gangloff (Acsone)
Review: Needs Fixing

Hello,

I see some little mistake that I correct in :
http://bazaar.launchpad.net/~acsone-openerp/stock-logistic-warehouse/7.0-inventory-hierarchical-fill2-lga/revision/40
http://bazaar.launchpad.net/~acsone-openerp/stock-logistic-warehouse/7.0-inventory-hierarchical-fill2-lga/revision/41

It seems I forgot to report them on this branch :(.

The most important of them is the second one.

The change is the following:

l.699 ids_to_check = ids
should be : ids_to_check = list(ids)
-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl

2014-06-20 Thread Pedro Manuel Baeza
Hi, Guewen, thanks for the review.

I have fixed your remarks.

I don't like also to overwrite function fields methods, but I assure you that 
there's no other way for now. I'm going to propose a hook method for purchase 
line base price on core to see if we can improve this module for next version.

Regards.
-- 
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-06-20 Thread Lionel Sausin - Numérigraphe
laetitia-gangloff you're right, Loïc had to split the proposal in 2 branches to 
make the review easier but I forgot to push back the fixes he an you made to 
the modules in this branch.
I'll fix it now.
-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-06-20 Thread Lionel Sausin - Numérigraphe
laetitia-gangloff,
Can you please explain this change in your branch? I don't see the point 
because ids is already sure to be Iterable. Does it really have to be a list?

@@ -285,11 +285,11 @@
 def write(self, cr, uid, ids, vals, context=None):
 Refuse write if an inventory is being conducted
 self._check_inventory(cr, uid, ids, context=context)
 if not isinstance(ids, Iterable):
 ids = [ids]
-ids_to_check = list(ids)
+ids_to_check = ids
 # If changing the parent, no inventory must conducted there either
 if vals.get('location_id'):
 ids_to_check.append(vals['location_id'])
 self._check_inventory(cr, uid, ids_to_check, context=context)
 return super(StockLocation, self).write(cr, uid, ids, vals,

-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-06-20 Thread Laetitia Gangloff (Acsone)
It is to avoid a RuntimeError: maximum recursion depth exceeded when change 
location_id.

ids was just assigned in ids_to_check so, when ids_to_check change, ids change 
too and the write is not done with right parameter, an we get the above error.

With list(ids) we create a new list, so ids and ids_to_check are not same.
-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl

2014-06-20 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review

Great, thanks!
-- 
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-06-20 Thread Lionel Sausin - Numérigraphe
laetitia-gangloff, right you are again.
I propose to write it explicitly this way, is it OK for you?
if not isinstance(ids, Iterable):
ids_to_check = [ids]
else:
# Copy the date to avoid changing 'ids', it would trigger an 
infinite recursion
ids_to_check = list(ids)
-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl

2014-06-20 Thread noreply
The proposal to merge lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into 
lp:purchase-wkfl has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
-- 
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-06-20 Thread Lionel Sausin - Numérigraphe
I meant copy the datA, not copy the date of course...
-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-06-20 Thread Laetitia Gangloff (Acsone)
Your proposition is OK for me.

Maybe, can you take test of this problem ?
-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-06-20 Thread Laetitia Gangloff (Acsone)
l. 509/l. 516 : raise osv.except_osv

Is it not better to use orm.except_orm ?
-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-06-20 Thread Lionel Sausin - Numérigraphe
laetitia-gangloff: that part of the code was backported from trunk-wms at the 
time, and I wanted to ease the migration to v8.
But eventually Odoo's Quentin Di Paoli changed his mind about that feature and 
removed it from odoo/master. But he still uses osv.except_osv all over the WMS 
code.
So I have no idea what's best, opinions welcome.
-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~ajite/multi-company/multi-company-add-0001 into lp:multi-company

2014-06-20 Thread Alexandre Fayolle - camptocamp
Review: Needs Fixing tried to install and run the tests

This looks like a great module. However it needs some work before further
review is done:

1. this module will cause a crash at server startup if it is present in the 
addons path (not necessarily installed) and the connector module is not 
available in the addons path::

CRITICAL test_70 openerp.modules.module: Couldn't load module web
CRITICAL test_70 openerp.modules.module: No module named connector
ERROR test_70 openerp: Failed to initialize database `test_70`.
Traceback (most recent call last):
  File 
/home/afayolle/work/oerp/openobject-server/7.0/openerp/cli/server.py, line 
97, in preload_registry
db, registry = 
openerp.pooler.get_db_and_pool(dbname,update_module=update_module)
  File /home/afayolle/work/oerp/openobject-server/7.0/openerp/pooler.py, 
line 33, in get_db_and_pool
registry = RegistryManager.get(db_name, force_demo, status, 
update_module)
  File 
/home/afayolle/work/oerp/openobject-server/7.0/openerp/modules/registry.py, 
line 203, in get
update_module)
  File 
/home/afayolle/work/oerp/openobject-server/7.0/openerp/modules/registry.py, 
line 233, in new
openerp.modules.load_modules(registry.db, force_demo, status, 
update_module)
  File 
/home/afayolle/work/oerp/openobject-server/7.0/openerp/modules/loading.py, 
line 354, in load_modules
loaded_modules, update_module)
  File 
/home/afayolle/work/oerp/openobject-server/7.0/openerp/modules/loading.py, 
line 256, in load_marked_modules
loaded, processed = load_module_graph(cr, graph, progressdict, 
report=report, skip_modules=loaded_modules, perform_checks=perform_checks)
  File 
/home/afayolle/work/oerp/openobject-server/7.0/openerp/modules/loading.py, 
line 159, in load_module_graph
load_openerp_module(package.name)
  File 
/home/afayolle/work/oerp/openobject-server/7.0/openerp/modules/module.py, 
line 415, in load_openerp_module
getattr(sys.modules['openerp.addons.' + module_name], 
info['post_load'])()
  File /home/afayolle/work/oerp/web/7.0/addons/web/http.py, line 628, in 
wsgi_postload
openerp.wsgi.register_wsgi_handler(Root())
  File /home/afayolle/work/oerp/web/7.0/addons/web/http.py, line 517, in 
__init__
self.load_addons()
  File /home/afayolle/work/oerp/web/7.0/addons/web/http.py, line 580, in 
load_addons
m = __import__('openerp.addons.' + module)
  File 
/home/afayolle/work/oerp/openobject-server/7.0/openerp/modules/module.py, 
line 133, in load_module
mod = imp.load_module('openerp.addons.' + module_part, f, path, descr)
  File 
/home/afayolle/work/oca/multi-company/multi-company-add-0001/base_intercompany/__init__.py,
 line 23, in module
import connector
  File 
/home/afayolle/work/oca/multi-company/multi-company-add-0001/base_intercompany/connector.py,
 line 25, in module
from openerp.addons.connector.connector import Environment
  File 
/home/afayolle/work/oerp/openobject-server/7.0/openerp/modules/module.py, 
line 132, in load_module
f, path, descr = imp.find_module(module_part, ad_paths)
ImportError: No module named connector

2. The addon has tests (good!) but they trigger a number of ERROR level log
lines which may not be bugs, but I would at least need some confirmation of
this. Since the runbot considers the tests failed if there are such log
messages, this could be an issue for future automated tests:

TEST test_70 openerp.modules.module: module base_intercompany_sale: 
executing 1 `fast_suite` and/or `checks` sub-modules
TEST test_70 openerp.modules.module: test_01_creation 
(openerp.addons.base_intercompany_sale.tests.test_sale.test_sale_so2po)
ERROR test_70 openerp.osv.expression: The field 'Object' (model) can not be 
searched: non-stored function field without fnct_search
ERROR test_70 openerp.osv.expression: The field 'Object' (model) can not be 
searched: non-stored function field without fnct_search
TEST test_70 openerp.modules.module: test_02_creation_raise_exception 
(openerp.addons.base_intercompany_sale.tests.test_sale.test_sale_so2po)
ERROR test_70 openerp.osv.expression: The field 'Object' (model) can not be 
searched: non-stored function field without fnct_search
TEST test_70 openerp.modules.module: 
test_03_creation_without_write_permission 
(openerp.addons.base_intercompany_sale.tests.test_sale.test_sale_so2po)
ERROR test_70 openerp.osv.expression: The field 'Object' (model) can not be 
searched: non-stored function field without fnct_search
ERROR test_70 openerp.osv.expression: The field 'Object' (model) can not be 
searched: non-stored function field without fnct_search
TEST test_70 openerp.modules.module: test_01_creation 
(openerp.addons.base_intercompany_sale.tests.test_sale.test_sale_so2so)
ERROR test_70 openerp.osv.expression: The field 'Object' (model) can not be 
searched: non-stored 

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-report/7_fix_1331543 into lp:stock-logistic-report

2014-06-20 Thread Lorenzo Battistini - Agile BG
Review: Approve code review


-- 
https://code.launchpad.net/~agilebg/stock-logistic-report/7_fix_1331543/+merge/223878
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/multi-company/multi-company-action-user into lp:multi-company

2014-06-20 Thread Alexandre Fayolle - camptocamp
Review: Needs Information code review, no tests

Could you update the description of the module to make it clear that there is 
no magic done in the module. 

Suggestion:

'description': Defines a user to be used for automatic action

This module adds a field 'automatic_action_user_id' 
on the company to define a specific user to be used for the automatic actions. 
This field can
then be used by other modules defining such actions.

Even then, the concept of automatic action is not clear to me. An example 
would be welcome. 
-- 
https://code.launchpad.net/~akretion-team/multi-company/multi-company-action-user/+merge/179179
Your team Multi Company Core Editors is subscribed to branch lp:multi-company.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-06-20 Thread Laetitia Gangloff (Acsone)
Review: Approve code, test, functional test

Thank you for the explanation.
I have no idea what's best.

I retested this module and it seems now OK.
-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

2014-06-20 Thread Alex Comba - Agile BG
Hi Pedro,

thank you for your review and for your precious hints!

I made the changes as you suggested us. In addition I fixed a bug in rev.58.


Cheers.
-- 
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-flows.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~agilebg/openerp-manufacturing/adding_mrp_production_properties_7 into lp:openerp-manufacturing

2014-06-20 Thread noreply
The proposal to merge 
lp:~agilebg/openerp-manufacturing/adding_mrp_production_properties_7 into 
lp:openerp-manufacturing has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~agilebg/openerp-manufacturing/adding_mrp_production_properties_7/+merge/219559
-- 
https://code.launchpad.net/~agilebg/openerp-manufacturing/adding_mrp_production_properties_7/+merge/219559
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:openerp-manufacturing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/knowledge-addons/cmis_read into lp:knowledge-addons/7.0

2014-06-20 Thread Sandy Carter (http://www.savoirfairelinux.com)
Thank you for your review, Guewen, I learned a few things.

Diff comments:

 === added directory 'cmis_read'
 === added file 'cmis_read/__init__.py'
 --- cmis_read/__init__.py 1970-01-01 00:00:00 +
 +++ cmis_read/__init__.py 2014-06-12 19:57:17 +
 @@ -0,0 +1,25 @@
 +# -*- encoding: utf-8 -*-
 +##
 +#
 +#OpenERP, Open Source Management Solution
 +#This module copyright (C) 2014 Savoir-faire Linux
 +#(http://www.savoirfairelinux.com).
 +#
 +#This program is free software: you can redistribute it and/or modify
 +#it under the terms of the GNU Affero General Public License as
 +#published by the Free Software Foundation, either version 3 of the
 +#License, or (at your option) any later version.
 +#
 +#This program is distributed in the hope that it will be useful,
 +#but WITHOUT ANY WARRANTY; without even the implied warranty of
 +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +#GNU Affero General Public License for more details.
 +#
 +#You should have received a copy of the GNU Affero General Public License
 +#along with this program.  If not, see http://www.gnu.org/licenses/.
 +#
 +##
 +
 +from . import wizard
 +
 +# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
 
 === added file 'cmis_read/__openerp__.py'
 --- cmis_read/__openerp__.py  1970-01-01 00:00:00 +
 +++ cmis_read/__openerp__.py  2014-06-12 19:57:17 +
 @@ -0,0 +1,74 @@
 +# -*- encoding: utf-8 -*-
 +##
 +#
 +#OpenERP, Open Source Management Solution
 +#This module copyright (C) 2014 Savoir-faire Linux
 +#(http://www.savoirfairelinux.com).
 +#
 +#This program is free software: you can redistribute it and/or modify
 +#it under the terms of the GNU Affero General Public License as
 +#published by the Free Software Foundation, either version 3 of the
 +#License, or (at your option) any later version.
 +#
 +#This program is distributed in the hope that it will be useful,
 +#but WITHOUT ANY WARRANTY; without even the implied warranty of
 +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 +#GNU Affero General Public License for more details.
 +#
 +#You should have received a copy of the GNU Affero General Public License
 +#along with this program.  If not, see http://www.gnu.org/licenses/.
 +#
 +##
 +
 +{
 +'name': 'CMIS Read',
 +'version': '0.1',
 +'category': 'Knowledge Management',
 +'summary': 'Store Document File in a Remote CMIS Server',
 +'description': 
 +This module allows you to use the CMIS backend to search in the DMS 
 repository
 +and attach documents to OpenERP records.
 +
 +Configuration
 +=
 +
 +Create a new CMIS backend with the host, login and password.
 +
 +Usage
 +=
 +
 +* On one OpenERP record, click Add from DMS.
 +* Type your query and then click on Search.
 +* Filter your results if necessary
 +* Select the documents you want to attach
 +* Selected documents will be enqueued for importing
 +
 +Contributors
 +
 +* El Hadji Dem (elhadji@savoirfairelinux.com)
 +,
 +'author': 'Savoir-faire Linux',
 +'website': 'www.savoirfairelinux.com',
 +'license': 'AGPL-3',
 +'depends': [
 +'document',
 +'cmis'
 +],
 +'data': [
 +'security/ir.model.access.csv',
 +'wizard/document_wizard_view.xml',
 +],
 +'js': [
 +'static/src/js/document.js'
 +],
 +'qweb': [
 +'static/src/xml/document.xml'
 +],
 +'test': [],
 +'demo': [
 +],
 +'installable': True,
 +'auto_install': False,
 +}
 +
 +# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
 
 === added directory 'cmis_read/i18n'
 === added file 'cmis_read/i18n/cmis_read.pot'
 --- cmis_read/i18n/cmis_read.pot  1970-01-01 00:00:00 +
 +++ cmis_read/i18n/cmis_read.pot  2014-06-12 19:57:17 +
 @@ -0,0 +1,119 @@
 +# Translation of OpenERP Server.
 +# This file contains the translation of the following modules:
 +#* cmis_read
 +#
 +msgid 
 +msgstr 
 +Project-Id-Version: OpenERP Server 7.0\n
 +Report-Msgid-Bugs-To: \n
 +POT-Creation-Date: 2014-03-21 14:55+\n
 +PO-Revision-Date: 2014-03-21 10:55-0500\n
 +Last-Translator: EL Hadji DEM elhadji@savoirfairelinux.com\n
 +Language-Team: \n
 +MIME-Version: 1.0\n
 +Content-Type: text/plain; charset=UTF-8\n
 +Content-Transfer-Encoding: 8bit\n
 +Plural-Forms: \n
 +X-Generator: Poedit 1.5.4\n
 +
 +#. module: cmis_read
 +#: field:ir.attachment.dms,file_id:0
 +msgid File ID
 +msgstr 
 +
 +#. module: cmis_read
 +#: field:ir.attachment.dms.wizard,attachment_ids:0
 +msgid Attachments
 +msgstr 
 +
 +#. module: 

[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into lp:ocb-addons

2014-06-20 Thread Lionel Sausin - Numérigraphe
Lionel Sausin - Numérigraphe has proposed merging 
lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into 
lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports (ocb)

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928

Fixes a regression introduced while fixing #1312045 - we were confused and 
mixed 2 notations, so we skipped stock moves and the results were wrong.
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is requested to review the proposed merge 
of lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into 
lp:ocb-addons.
=== modified file 'stock/wizard/stock_fill_inventory.py'
--- stock/wizard/stock_fill_inventory.py	2014-05-12 08:27:47 +
+++ stock/wizard/stock_fill_inventory.py	2014-06-20 13:46:57 +
@@ -111,8 +111,7 @@
 local_context['raise-exception'] = False
 # To avoid running out of memory, process limited batches
 for i in range(0, len(all_move_ids), self.MAX_IMPORT_LINES):
-move_ids = all_move_ids[i * self.MAX_IMPORT_LINES:
-(i + 1) * self.MAX_IMPORT_LINES]
+move_ids = all_move_ids[i:i+self.MAX_IMPORT_LINES]
 for move in move_obj.browse(cr, uid, move_ids, context=context):
 lot_id = move.prodlot_id.id
 prod_id = move.product_id.id

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into lp:ocb-addons

2014-06-20 Thread Loïc Bellier - Numérigraphe
Loïc Bellier - Numérigraphe has proposed merging 
lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports (ocb)
Related bugs:
  Bug #1229646 in OpenERP Community Backports (Addons): Wizard Fill 
inventory does not respect the UoM's precision at the end of the computation
  https://bugs.launchpad.net/ocb-addons/+bug/1229646

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty/+merge/223929

In v7.0, when a Physical inventory is filled with the wizard, the quantity of 
products is computed by summing all the stock moves, but it's not rounded to 
the correct precision.
This can lead to tiny differences when validating the inventory.

Our previous patch work with v6.0, but not with v7.0 because _compute_qty_obj 
function has been refactored.
This is the patch for v7.0.
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty/+merge/223929
Your team OpenERP Community Backports is requested to review the proposed merge 
of lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into 
lp:ocb-addons.
=== modified file 'stock/stock.py'
--- stock/stock.py	2014-06-18 14:06:14 +
+++ stock/stock.py	2014-06-20 13:48:54 +
@@ -2922,7 +2922,7 @@
 # to perform the correct inventory corrections we need analyze stock location by
 # location, never recursively, so we use a special context
 product_context = dict(context, compute_child=False)
-
+uom_obj = self.pool['product.uom']
 location_obj = self.pool.get('stock.location')
 for inv in self.browse(cr, uid, ids, context=context):
 move_ids = []
@@ -2931,6 +2931,8 @@
 product_context.update(uom=line.product_uom.id, to_date=inv.date, date=inv.date, prodlot_id=line.prod_lot_id.id)
 amount = location_obj._product_get(cr, uid, line.location_id.id, [pid], product_context)[pid]
 change = line.product_qty - amount
+if abs(change)  uom_obj.browse(cr, uid, line.product_uom.id).rounding:
+continue
 lot_id = line.prod_lot_id.id
 if change:
 location_id = line.product_id.property_stock_inventory.id

=== modified file 'stock/wizard/stock_fill_inventory.py'
--- stock/wizard/stock_fill_inventory.py	2014-05-12 08:27:47 +
+++ stock/wizard/stock_fill_inventory.py	2014-06-20 13:48:54 +
@@ -126,11 +126,6 @@
 if datas.get((prod_id, lot_id)):
 qty += datas[(prod_id, lot_id)]['product_qty']
 
-# Floating point sum could introduce tiny rounding errors :
-# Use the UoM API for the rounding (same UoM in  out).
-qty = uom_obj._compute_qty_obj(cr, uid,
-   move.product_id.uom_id, qty,
-   move.product_id.uom_id)
 datas[(prod_id, lot_id)] = {'product_id': prod_id, 'location_id': location, 'product_qty': qty, 'product_uom': move.product_id.uom_id.id, 'prod_lot_id': lot_id}
 
 if datas:
@@ -142,6 +137,9 @@
 
 for stock_move in res.values():
 for stock_move_details in stock_move.values():
+# remove product with qty  to product uom rounding (rouding error computation)
+if abs(stock_move_details['product_qty'])  uom_obj.browse(cr, uid, stock_move_details['product_uom']).rounding:
+continue
 stock_move_details.update({'inventory_id': context['active_ids'][0]})
 domain = []
 for field, value in stock_move_details.items():
@@ -156,6 +154,14 @@
 line_ids = inventory_line_obj.search(cr, uid, domain, context=context)
 
 if not line_ids:
+# Floating point sum could introduce tiny rounding errors :
+# Use the UoM API for the rounding (same UoM in  out).
+line_uom = uom_obj.browse(cr, uid, [stock_move_details['product_uom']])[0]
+qty = uom_obj._compute_qty_obj(cr, uid,
+  line_uom,
+  stock_move_details['product_qty'],
+  line_uom)
+stock_move_details.update({'product_qty': qty})
 inventory_line_obj.create(cr, uid, stock_move_details, context=context)
 
 return {'type': 'ir.actions.act_window_close'}

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into lp:ocb-addons

2014-06-20 Thread Weste
Review: Approve

That will fix the bug, thanks!
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is requested to review the proposed merge 
of lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into 
lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Bug 1008513] Re: [6.1]document_webdav - pywebdav import error if pywebdav=0.9.8

2014-06-20 Thread Guewen Baconnier @ Camptocamp
** Changed in: ocb-addons/6.1
   Status: Fix Committed = Fix Released

-- 
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Addons).
https://bugs.launchpad.net/bugs/1008513

Title:
  [6.1]document_webdav - pywebdav import error if pywebdav=0.9.8

Status in OpenERP Community Backports (Addons):
  Invalid
Status in OpenERP Community Backports (Addons) 6.1 series:
  Fix Released
Status in Odoo Addons:
  Confirmed

Bug description:
  starting from pywebdav 0.9.8 you should import from pywebdav.lib (see
  http://pypi.python.org/pypi/PyWebDAV).

  Find the right patch attached

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1008513/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into lp:ocb-addons

2014-06-20 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review

LGTM
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into lp:ocb-addons

2014-06-20 Thread Loïc Bellier - Numérigraphe
Review: Approve code review

Great !
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp into lp:hr-timesheet

2014-06-20 Thread noreply
The proposal to merge lp:~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp 
into lp:hr-timesheet has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp/+merge/219821
-- 
https://code.launchpad.net/~pedro.baeza/hr-timesheet/7.0-hr_timesheet_task-imp/+merge/219821
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:hr-timesheet.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into lp:ocb-addons

2014-06-20 Thread Leonardo Pistone - camptocamp
Review: Approve

+1
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~mikel-martin/purchase-wkfl/6.1-purchase_landed_costs into lp:purchase-wkfl/6.1

2014-06-20 Thread noreply
The proposal to merge lp:~mikel-martin/purchase-wkfl/6.1-purchase_landed_costs 
into lp:purchase-wkfl/6.1 has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~mikel-martin/purchase-wkfl/6.1-purchase_landed_costs/+merge/199587
-- 
https://code.launchpad.net/~mikel-martin/purchase-wkfl/6.1-purchase_landed_costs/+merge/199587
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools

2014-06-20 Thread Lorenzo Battistini - Agile BG
Hello Sébastien,
some PEP8 improvements here
https://code.launchpad.net/~agilebg/server-env-tools/binary_field_pep8/+merge/223935
-- 
https://code.launchpad.net/~akretion-team/server-env-tools/server-env-tools/+merge/91
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addons

2014-06-20 Thread Sylvain LE GAL (GRAP)
Review: Abstain

Hi.

Sorry, I totally forgot to review again that MP.
-- 
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addons

2014-06-20 Thread noreply
The proposal to merge lp:~ajite/web-addons/7.0-web-addons-add-0001 into 
lp:web-addons has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
-- 
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~ajite/web-addons/7.0-web-addons-add-0001 into lp:web-addons

2014-06-20 Thread Guewen Baconnier @ Camptocamp
Review: Approve code review

Hi Augustin,

LGTM finally!

Thanks for you work.

Since Sylvain's comments have been addressed, I'll merge it.
-- 
https://code.launchpad.net/~ajite/web-addons/7.0-web-addons-add-0001/+merge/210620
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into lp:ocb-addons

2014-06-20 Thread Laetitia Gangloff (Acsone)
Review: Approve code

Thank you !
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into lp:ocb-addons

2014-06-20 Thread Alexandre Fayolle - camptocamp
The proposal to merge 
lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into 
lp:ocb-addons has been updated.

Status: Needs review = Approved

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into lp:ocb-addons

2014-06-20 Thread noreply
The proposal to merge 
lp:~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM into 
lp:ocb-addons has been updated.

Status: Approved = Merged

For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
-- 
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fix-regression-fill-inventory-OOM/+merge/223928
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


[Openerp-community-reviewer] [Bug 1329342] Re: stock.fill.inventory doesn't consider all the records

2014-06-20 Thread Lionel Sausin - Numérigraphe
** Changed in: ocb-addons
   Status: Fix Committed = Fix Released

-- 
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Addons).
https://bugs.launchpad.net/bugs/1329342

Title:
  stock.fill.inventory doesn't consider all the records

Status in OpenERP Community Backports (Addons):
  Fix Released

Bug description:
  rev 10204 introduce this bad loop:

  MAX_IMPORT_LINES = 1
  for i in range(0, len(all_move_ids), self.MAX_IMPORT_LINES):
  move_ids = all_move_ids[i * self.MAX_IMPORT_LINES:
  (i + 1) * self.MAX_IMPORT_LINES]

  i will have the values: 0, 1, 2, etc.
  so move_ids will be all_move_ids[0:1], all_move_ids[1:10001], 
all_move_ids[2:20001] etc.

  suggestion: move_ids = all_move_ids[i:i + self.MAX_RECORDS]

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1329342/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location into lp:stock-logistic-warehouse

2014-06-20 Thread Lionel Sausin - Numérigraphe
Review: Abstain i'm a contributor


-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-location/+merge/223880
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-hierarchical into lp:stock-logistic-warehouse

2014-06-20 Thread Lionel Sausin - Numérigraphe
Review: Abstain i'm a contributor


-- 
https://code.launchpad.net/~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-hierarchical/+merge/223882
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~numerigraphe-team/stock-logistic-warehouse/7.0-inventory-hierarchical into 
lp:stock-logistic-warehouse.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp