Re: [Openerp-community-reviewer] [Merge] lp:~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order into lp:ocb-server
https://github.com/odoo/odoo/pull/829 -- https://code.launchpad.net/~cedric-lebrouster/ocb-server/ocb-7.0-bug-1253052-parent-order/+merge/209708 Your team OpenERP Community Backports is subscribed to branch lp:ocb-server. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into lp:ocb-addons
Loïc Bellier - Numérigraphe has proposed merging
lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into lp:ocb-addons.
Requested reviews:
Lionel Sausin - Numérigraphe (lionel-sausin)
Laetitia Gangloff (Acsone) (laetitia-gangloff)
OpenERP Community Backports (ocb)
Related bugs:
Bug #1229646 in OpenERP Community Backports (Addons): Wizard Fill
inventory does not respect the UoM's precision at the end of the computation
https://bugs.launchpad.net/ocb-addons/+bug/1229646
For more details, see:
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty/+merge/223929
In v7.0, when a Physical inventory is filled with the wizard, the quantity of
products is computed by summing all the stock moves, but it's not rounded to
the correct precision.
This can lead to tiny differences when validating the inventory.
Our previous patch work with v6.0, but not with v7.0 because _compute_qty_obj
function has been refactored.
This is the patch for v7.0.
--
https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty/+merge/223929
Your team OpenERP Community Backports is requested to review the proposed merge
of lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into
lp:ocb-addons.
=== modified file 'stock/stock.py'
--- stock/stock.py 2014-06-18 14:06:14 +
+++ stock/stock.py 2014-06-30 09:11:23 +
@@ -2922,7 +2922,7 @@
# to perform the correct inventory corrections we need analyze stock location by
# location, never recursively, so we use a special context
product_context = dict(context, compute_child=False)
-
+uom_obj = self.pool['product.uom']
location_obj = self.pool.get('stock.location')
for inv in self.browse(cr, uid, ids, context=context):
move_ids = []
@@ -2931,6 +2931,8 @@
product_context.update(uom=line.product_uom.id, to_date=inv.date, date=inv.date, prodlot_id=line.prod_lot_id.id)
amount = location_obj._product_get(cr, uid, line.location_id.id, [pid], product_context)[pid]
change = line.product_qty - amount
+if abs(change) uom_obj.browse(cr, uid, line.product_uom.id).rounding:
+continue
lot_id = line.prod_lot_id.id
if change:
location_id = line.product_id.property_stock_inventory.id
=== modified file 'stock/wizard/stock_fill_inventory.py'
--- stock/wizard/stock_fill_inventory.py 2014-06-20 14:27:46 +
+++ stock/wizard/stock_fill_inventory.py 2014-06-30 09:11:23 +
@@ -22,6 +22,7 @@
from openerp.osv import fields, osv, orm
from openerp.tools.translate import _
from openerp.tools import mute_logger
+from product._common import rounding
class stock_fill_inventory(osv.osv_memory):
_name = stock.fill.inventory
@@ -116,20 +117,16 @@
lot_id = move.prodlot_id.id
prod_id = move.product_id.id
if move.location_dest_id.id != move.location_id.id:
-if move.location_dest_id.id == location:
-qty = uom_obj._compute_qty_obj(cr, uid, move.product_uom,move.product_qty, move.product_id.uom_id, context=local_context)
-else:
-qty = -uom_obj._compute_qty_obj(cr, uid, move.product_uom,move.product_qty, move.product_id.uom_id, context=local_context)
+qty = move.product_qty
+if move.product_uom.id != move.product_id.uom_id.id:
+qty = uom_obj._compute_qty_obj(cr, uid, move.product_uom, qty, move.product_id.uom_id, context=local_context)
+if move.location_dest_id.id != location:
+qty = -qty
if datas.get((prod_id, lot_id)):
qty += datas[(prod_id, lot_id)]['product_qty']
-# Floating point sum could introduce tiny rounding errors :
-# Use the UoM API for the rounding (same UoM in out).
-qty = uom_obj._compute_qty_obj(cr, uid,
- move.product_id.uom_id, qty,
- move.product_id.uom_id)
datas[(prod_id, lot_id)] = {'product_id': prod_id, 'location_id': location, 'product_qty': qty, 'product_uom': move.product_id.uom_id.id, 'prod_lot_id': lot_id}
if datas:
@@ -141,6 +138,9 @@
for stock_move in res.values():
for stock_move_details in stock_move.values():
+# remove product with qty to product uom rounding (rouding error computation)
+if abs(stock_move_details['product_qty']) uom_obj.browse(cr, uid, stock_move_details['product_uom']).rounding:
+continue
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into lp:ocb-addons
Review: Approve co-author -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty/+merge/223929 Your team OpenERP Community Backports is requested to review the proposed merge of lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into lp:ocb-addons
Review: Abstain This seems to fix the rounding issues we still encountered with precision=0.01. It's still not the exact same rounding rules as the computation of qty_available but it should be close enough. -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty/+merge/223929 Your team OpenERP Community Backports is requested to review the proposed merge of lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into lp:ocb-addons
Review: Abstain co-author -- https://code.launchpad.net/~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty/+merge/223929 Your team OpenERP Community Backports is requested to review the proposed merge of lp:~numerigraphe-team/ocb-addons/7.0-fill_inventory_zero_qty into lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1311087-rgo into lp:ocb-addons
Review: Needs Information Hi Yannick, so this is already on the v7 on github. Now that OCB migration to github is in progress, should we merge that in ocb on launchpad? Other than that, I would approve the change. Thanks! -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1311087-rgo/+merge/224247 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase into lp:~account-core-editors/account-financial-tools/7.0
The proposal to merge lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase into lp:~account-core-editors/account-financial-tools/7.0 has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase/+merge/219849 -- https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase/+merge/219849 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:~account-core-editors/account-financial-tools/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/account-financial-tools-check-deposit into lp:~account-core-editors/account-financial-tools/7.0
The proposal to merge lp:~akretion-team/account-financial-tools/account-financial-tools-check-deposit into lp:~account-core-editors/account-financial-tools/7.0 has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~akretion-team/account-financial-tools/account-financial-tools-check-deposit/+merge/210315 -- https://code.launchpad.net/~akretion-team/account-financial-tools/account-financial-tools-check-deposit/+merge/210315 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:~account-core-editors/account-financial-tools/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/account-financial-tools-check-deposit into lp:~account-core-editors/account-financial-tools/7.0
The project has moved to Github https://github.com/OCA/account-financial-tools. Please resubmit your MP on github using following procedure https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub. I put this MP in rejected in the meanwhile. Regards -- https://code.launchpad.net/~akretion-team/account-financial-tools/account-financial-tools-check-deposit/+merge/210315 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:~account-core-editors/account-financial-tools/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/7-account-journal-sale-refund-link-cde into lp:~account-core-editors/account-financial-tools/7.0
The project has moved to Github https://github.com/OCA/account-financial-tools. Please resubmit your MP on github using following procedure https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub. I put this MP in rejected in the meanwhile. Regards -- https://code.launchpad.net/~akretion-team/account-financial-tools/7-account-journal-sale-refund-link-cde/+merge/223037 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:~account-core-editors/account-financial-tools/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:~account-core-editors/account-financial-tools/7.0
The proposal to merge lp:~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh into lp:~account-core-editors/account-financial-tools/7.0 has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh/+merge/224847 -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0_override_menu_for_search_improvement_mdh/+merge/224847 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:~account-core-editors/account-financial-tools/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoice-report/vre_account_invoice_report into lp:account-invoice-report
Review: Disapprove Hi Vincent, Being an invoice an official document, It is a good idea to store the report generated when the invoice was confirmed. If, for example, the customer data, the product name, taxes, company name/header change, the invoice document should not change. The current functionality reproduces what you get by actually printing the invoice and archiving the piece of paper. thanks! -- https://code.launchpad.net/~camptocamp/account-invoice-report/vre_account_invoice_report/+merge/224593 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7-add-base-class-for-carrier-configs into lp:~stock-logistic-core-editors/carriers-deliveries/7.0
This project is now hosted on https://github.com/OCA/carriers-deliveries. Please move your proposal there if you still want to merge it once fixed. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub -- https://code.launchpad.net/~akretion-team/carriers-deliveries/7-add-base-class-for-carrier-configs/+merge/224598 Your team Stock and Logistic Core Editors is subscribed to branch lp:~stock-logistic-core-editors/carriers-deliveries/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl into lp:~stock-logistic-core-editors/carriers-deliveries/7.0
This project is now hosted on https://github.com/OCA/carriers-deliveries. Please move your proposal there if you still want to merge it once fixed. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub (sorry David should have merged it first at least this will make you some training to create PR on github ;) ) -- https://code.launchpad.net/~akretion-team/carriers-deliveries/7-split-default-option-state-from-deliv-method-dbl/+merge/224027 Your team Stock and Logistic Core Editors is subscribed to branch lp:~stock-logistic-core-editors/carriers-deliveries/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_dispatch-output-file-yvr into lp:~stock-logistic-core-editors/carriers-deliveries/7.0
This project is now hosted on https://github.com/OCA/carriers-deliveries. Please move your proposal there if you still want to merge it once fixed. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_dispatch-output-file-yvr/+merge/202444 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~camptocamp/carriers-deliveries/7.0-delivery_carrier_label_dispatch-output-file-yvr into lp:~stock-logistic-core-editors/carriers-deliveries/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:~stock-logistic-core-editors/carriers-deliveries/7.0
This project is now hosted on https://github.com/OCA/carriers-deliveries. Please move your proposal there if you still want to merge it once fixed. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub -- https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867 Your team Stock and Logistic Core Editors is subscribed to branch lp:~stock-logistic-core-editors/carriers-deliveries/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into lp:~stock-logistic-core-editors/carriers-deliveries/7.0
Note to myself This project is now hosted on https://github.com/OCA/carriers-deliveries. Please move your proposal there if you still want to merge it once fixed. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub -- https://code.launchpad.net/~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation/+merge/215184 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~camptocamp/carriers-deliveries/7.0-threaded-dispatch-label-generation into lp:~stock-logistic-core-editors/carriers-deliveries/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoice-report/vre_account_invoice_report into lp:account-invoice-report
Review: Disapprove code review I also agree with Leonardo. Regards. -- https://code.launchpad.net/~camptocamp/account-invoice-report/vre_account_invoice_report/+merge/224593 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoice-report/vre_account_invoice_report into lp:account-invoice-report
The proposal to merge lp:~camptocamp/account-invoice-report/vre_account_invoice_report into lp:account-invoice-report has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~camptocamp/account-invoice-report/vre_account_invoice_report/+merge/224593 -- https://code.launchpad.net/~camptocamp/account-invoice-report/vre_account_invoice_report/+merge/224593 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft into lp:account-invoice-report
Review: Approve code review, no test LGTM -- https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft into lp:account-invoice-report
The proposal to merge lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft into lp:account-invoice-report has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109 -- https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft into lp:account-invoice-report
The proposal to merge lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft into lp:account-invoice-report has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109 -- https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~initos.com/account-invoice-report/7.0-fix_lang_for_draft into lp:account-invoice-report
Thanks for the fix. -- https://code.launchpad.net/~initos.com/account-invoice-report/7.0-fix_lang_for_draft/+merge/224109 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1311087-rgo into lp:ocb-addons
Replay isn't working yet and passing from lp to github will make us having to replay all the MP we did. I think that while we don't have OCB fully working on github we can fill the gap by merging that kind of MP in OCB on launchpad. -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1311087-rgo/+merge/224247 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation into lp:account-invoice-report
The proposal to merge lp:~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation into lp:account-invoice-report has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation/+merge/214179 -- https://code.launchpad.net/~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation/+merge/214179 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation into lp:account-invoice-report
The proposal to merge lp:~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation into lp:account-invoice-report has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation/+merge/214179 -- https://code.launchpad.net/~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation/+merge/214179 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation into lp:account-invoice-report
I merge this before migration to github. Missing 1 approve but only touch translation so this is not critical. -- https://code.launchpad.net/~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation/+merge/214179 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation into lp:account-invoice-report
Thanks Leatitia for this MP -- https://code.launchpad.net/~acsone-openerp/account-invoice-report/invoice_webkit_fr_translation/+merge/214179 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address into lp:account-invoice-report
The proposal to merge lp:~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address into lp:account-invoice-report has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address/+merge/207915 -- https://code.launchpad.net/~therp-nl/account-invoice-report/account-invoice-report-7.0_delivery_address/+merge/207915 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1311087-rgo into lp:ocb-addons
Please merge here on LP for the coming days, not on GitHub. The OCB branches will be overwritten by the final migration. -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1311087-rgo/+merge/224247 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:~account-core-editors/account-invoice-report/7.0
This project is now hosted on https://github.com/OCA/account-invoice-reporting. Please move your proposal there if you still want to merge it once fixed. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub Sorry Lorenzo didn't had the time to look closely at this MP again. Can we continue this on github ? -- https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:~account-core-editors/account-invoice-report/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:~stock-logistic-core-editors/carriers-deliveries/7.0
Hi Yannick, does the migration still needed even if the MP has 3 approves? I remain awaiting your confirmation before to proceed it. Thank you in advance. -- https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867 Your team Stock and Logistic Core Editors is subscribed to branch lp:~stock-logistic-core-editors/carriers-deliveries/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:~stock-logistic-core-editors/carriers-deliveries/7.0
Sorry for having a bit rushed the migration of this branch. One way or the other we must replicate this MP as a PR on github, now. Can you do this and putting this MP as reference, the PR will be merged fast as it was already approved. -- https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867 Your team Stock and Logistic Core Editors is subscribed to branch lp:~stock-logistic-core-editors/carriers-deliveries/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:~stock-logistic-core-editors/carriers-deliveries/7.0
Ok, no problem! I will migrate it to github asap. Thank you. -- https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867 Your team Stock and Logistic Core Editors is subscribed to branch lp:~stock-logistic-core-editors/carriers-deliveries/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1311087-rgo into lp:ocb-addons
Review: Approve Thanks a lot Stefan. -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1311087-rgo/+merge/224247 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep into lp:sale-wkfl
Review: Approve Romain, I approve your changes, thanks -- https://code.launchpad.net/~camptocamp/sale-wkfl/7.0-dropshipping-merge-po-lep/+merge/216756 Your team Sale Core Editors is subscribed to branch lp:sale-wkfl. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~yann-papouin/ocb-addons/7.0-bug-1091268-purchase-merge-no-origin-duplicates into lp:ocb-addons
This MP introduced a bug If first purchase order has no origin, it will raise ... if not porder.origin in order_infos['origin'] and not order_infos['origin'] in porder.origin: TypeError: argument of type 'bool' is not iterable because order_infos['origin'] will contains False -- https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1091268-purchase-merge-no-origin-duplicates/+merge/210169 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Bug 1335887] [NEW] [7.0] Merging purchase order will fail when first one has no origin
Public bug reported:
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1091268
-purchase-merge-no-origin-duplicates/+merge/210169
Introduced a bug:
When first purchase order has no origin, it will raise the following
error:
OpenERP Server Error Client Traceback (most recent call last):
File .../webclient/addons/web/http.py, line 204, in dispatch
response[result] = method(self, **self.params)
File .../webclient/addons/web/controllers/main.py, line 1132, in
call_button
action = self._call_kw(req, model, method, args, {})
File .../webclient/addons/web/controllers/main.py, line 1120, in _call_kw
return getattr(req.session.model(model), method)(*args, **kwargs)
File .../webclient/addons/web/session.py, line 42, in proxy
result = self.proxy.execute_kw(self.session._db, self.session._uid,
self.session._password, self.model, method, args, kw)
File .../webclient/addons/web/session.py, line 30, in proxy_method
result = self.session.send(self.service_name, method, *args)
File .../webclient/addons/web/session.py, line 103, in send
raise xmlrpclib.Fault(openerp.tools.ustr(e), formatted_info)
Server Traceback (most recent call last):
File .../webclient/addons/web/session.py, line 89, in send
return openerp.netsvc.dispatch_rpc(service_name, method, args)
File .../server/openerp/netsvc.py, line 296, in dispatch_rpc
result = ExportService.getService(service_name).dispatch(method, params)
File .../server/openerp/service/web_services.py, line 626, in dispatch
res = fn(db, uid, *params)
File .../server/openerp/osv/osv.py, line 190, in execute_kw
return self.execute(db, uid, obj, method, *args, **kw or {})
File .../server/openerp/osv/osv.py, line 132, in wrapper
return f(self, dbname, *args, **kwargs)
File .../server/openerp/osv/osv.py, line 199, in execute
res = self.execute_cr(cr, uid, obj, method, *args, **kw)
File .../server/openerp/osv/osv.py, line 187, in execute_cr
return getattr(object, method)(cr, uid, *args, **kw)
File .../addons/purchase/wizard/purchase_order_group.py, line 71, in
merge_orders
allorders = order_obj.do_merge(cr, uid, context.get('active_ids',[]),
context)
File .../addons/purchase/purchase.py, line 796, in do_merge
if not porder.origin in order_infos['origin'] and not order_infos['origin']
in porder.origin: TypeError: argument of type 'bool' is not iterable
** Affects: ocb-addons
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Addons).
https://bugs.launchpad.net/bugs/1335887
Title:
[7.0] Merging purchase order will fail when first one has no origin
Status in OpenERP Community Backports (Addons):
New
Bug description:
https://code.launchpad.net/~yann-papouin/ocb-addons/7.0-bug-1091268
-purchase-merge-no-origin-duplicates/+merge/210169
Introduced a bug:
When first purchase order has no origin, it will raise the following
error:
OpenERP Server Error Client Traceback (most recent call last):
File .../webclient/addons/web/http.py, line 204, in dispatch
response[result] = method(self, **self.params)
File .../webclient/addons/web/controllers/main.py, line 1132, in
call_button
action = self._call_kw(req, model, method, args, {})
File .../webclient/addons/web/controllers/main.py, line 1120, in
_call_kw
return getattr(req.session.model(model), method)(*args, **kwargs)
File .../webclient/addons/web/session.py, line 42, in proxy
result = self.proxy.execute_kw(self.session._db, self.session._uid,
self.session._password, self.model, method, args, kw)
File .../webclient/addons/web/session.py, line 30, in proxy_method
result = self.session.send(self.service_name, method, *args)
File .../webclient/addons/web/session.py, line 103, in send
raise xmlrpclib.Fault(openerp.tools.ustr(e), formatted_info)
Server Traceback (most recent call last):
File .../webclient/addons/web/session.py, line 89, in send
return openerp.netsvc.dispatch_rpc(service_name, method, args)
File .../server/openerp/netsvc.py, line 296, in dispatch_rpc
result = ExportService.getService(service_name).dispatch(method, params)
File .../server/openerp/service/web_services.py, line 626, in dispatch
res = fn(db, uid, *params)
File .../server/openerp/osv/osv.py, line 190, in execute_kw
return self.execute(db, uid, obj, method, *args, **kw or {})
File .../server/openerp/osv/osv.py, line 132, in wrapper
return f(self, dbname, *args, **kwargs)
File .../server/openerp/osv/osv.py, line 199, in execute
res = self.execute_cr(cr, uid, obj, method, *args, **kw)
File .../server/openerp/osv/osv.py, line 187, in execute_cr
return getattr(object, method)(cr, uid, *args, **kw)
File
[Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons
Yannick Vaucher @ Camptocamp has proposed merging
lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons.
Commit message:
Fix purchase order do_merge w/ 1st origin empty introduced on OCB on rev 10009
Requested reviews:
Yann Papouin (yann-papouin)
OpenERP Community Backports (ocb)
Related bugs:
Bug #1335887 in OpenERP Community Backports (Addons): [7.0] Merging purchase
order will fail when first one has no origin
https://bugs.launchpad.net/ocb-addons/+bug/1335887
For more details, see:
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028
Fix a bug only introduced on OCB
--
https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028
Your team OpenERP Community Backports is requested to review the proposed merge
of lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons.
=== modified file 'purchase/purchase.py'
--- purchase/purchase.py 2014-04-15 08:12:11 +
+++ purchase/purchase.py 2014-06-30 15:10:08 +
@@ -775,7 +775,7 @@
order_infos = new_order[0]
if not order_infos:
order_infos.update({
-'origin': porder.origin,
+'origin': porder.origin or '',
'date_order': porder.date_order,
'partner_id': porder.partner_id.id,
'dest_address_id': porder.dest_address_id.id,
@@ -794,7 +794,7 @@
order_infos['notes'] = (order_infos['notes'] or '') + ('\n%s' % (porder.notes,))
if porder.origin:
if not porder.origin in order_infos['origin'] and not order_infos['origin'] in porder.origin:
-order_infos['origin'] = (order_infos['origin'] or '') + ' ' + porder.origin
+order_infos['origin'] = order_infos['origin'] + ' ' + porder.origin
for order_line in porder.order_line:
line_key = make_key(order_line, ('name', 'date_planned', 'taxes_id', 'price_unit', 'product_id', 'move_dest_id', 'account_analytic_id'))
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons
Review: Disapprove Personally I think this merge proposal is tackling the problem from the wrong end. If we do not have an origin for a purchase order, the value for origin should be NULL, not an empty string. The original code that introduced the bug should be amended to account for the possibility of NULL values in the database. -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase into lp:~account-core-editors/account-financial-tools/7.0
The proposal to merge lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase into lp:~account-core-editors/account-financial-tools/7.0 has been updated. Status: Rejected = Work in progress For more details, see: https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase/+merge/219849 -- https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase/+merge/219849 Your team Account Core Editors is requested to review the proposed merge of lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase into lp:~account-core-editors/account-financial-tools/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase into lp:~account-core-editors/account-financial-tools/7.0
Submitted on github: https://github.com/OCA/account-financial-tools/pull/4 -- https://code.launchpad.net/~numerigraphe-team/account-financial-tools/7.0-add-account_budget_purchase/+merge/219849 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:~account-core-editors/account-financial-tools/7.0. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons
Ok I though empty string were store as Null as zero value for integer. Just check and it seems I'm wrong. I'll add a check instead of forcing to empty string. Thanks for the review -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/7.0-fix-1335887 into lp:ocb-addons
@Ronald, I changed the fix according to your review -- https://code.launchpad.net/~camptocamp/ocb-addons/7.0-fix-1335887/+merge/225028 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
