[Openerp-community-reviewer] [Bug 1359711] [NEW] [7.0] Bank statement wrong currency

2014-08-21 Thread Kinner Vachhani
Public bug reported:

Hi,

The bank statement currency is taking user company currency which is
wrong. Ideally it should take currency from journal.

Wrong code:

res_users_obj = self.pool.get('res.users')
default_currency = res_users_obj.browse(cursor, user,
user, context=context).company_id.currency_id
for statement in self.browse(cursor, user, ids, context=context):
currency = statement.journal_id.currency
if not currency:
currency = default_currency

Recommendation
  currency = statement.journal_id.currency or 
statement.journal_id.company_id.currency_id

** Affects: ocb-addons
 Importance: Undecided
 Status: New

** Summary changed:

- [7.0] Bank statement currency  is wrong
+ [7.0] Bank statement wrong currency

-- 
You received this bug notification because you are a member of OpenERP
Community Backports, which is subscribed to OpenERP Community Backports
(Addons).
https://bugs.launchpad.net/bugs/1359711

Title:
  [7.0] Bank statement wrong currency

Status in OpenERP Community Backports (Addons):
  New

Bug description:
  Hi,

  The bank statement currency is taking user company currency which is
  wrong. Ideally it should take currency from journal.

  Wrong code:

  res_users_obj = self.pool.get('res.users')
  default_currency = res_users_obj.browse(cursor, user,
  user, context=context).company_id.currency_id
  for statement in self.browse(cursor, user, ids, context=context):
  currency = statement.journal_id.currency
  if not currency:
  currency = default_currency

  Recommendation
currency = statement.journal_id.currency or 
statement.journal_id.company_id.currency_id

To manage notifications about this bug go to:
https://bugs.launchpad.net/ocb-addons/+bug/1359711/+subscriptions

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/openerp-pos/7.0_pos_select_customer into lp:openerp-pos

2014-08-21 Thread Pedro Manuel Baeza
Maybe this feature doesnt' have to be offline. We can see if POS is online, and 
get prices in this case, and on contrary, take standar price. What do you think?
-- 
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_select_customer/+merge/228826
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:openerp-pos.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~sylvain-legal/openerp-pos/7.0_pos_select_customer into lp:openerp-pos

2014-08-21 Thread Sylvain LE GAL (GRAP)
Hi pedro, 

Yes, it is quite a big job to realize. We have to load all the pricelist 
behaviour and write the algorithm in Javascript. Pricelist is a big algorithm 
depending of quantity, date and other pricelist recursively. I think this is 
why it's not managed in Odoo by default.

For that, I wrote 'pos_backup_draft_orders' and 'fix_pos_change_pricelist' to 
realize that.
but of course it's not optimized.

Regards.
-- 
https://code.launchpad.net/~sylvain-legal/openerp-pos/7.0_pos_select_customer/+merge/228826
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:openerp-pos.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~echeverrifm/oemedical/oemedical_lifestyle into lp:oemedical

2014-08-21 Thread Alexandre Fayolle - camptocamp
Review: Resubmit

Hello,

The management of the project has moved to Github: 
https://github.com/OCA/vertical-medical

Please migrate your merge proposal to Github. You may want to check 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
 for an explanation on how to proceed. 

Thanks for contributing to the project


-- 
https://code.launchpad.net/~echeverrifm/oemedical/oemedical_lifestyle/+merge/205518
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~echeverrifm/oemedical/oemedical_lab into lp:oemedical

2014-08-21 Thread Alexandre Fayolle - camptocamp
Review: Resubmit

Hello,

The management of the project has moved to Github: 
https://github.com/OCA/vertical-medical

Please migrate your merge proposal to Github. You may want to check 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
 for an explanation on how to proceed. 

Thanks for contributing to the project


-- 
https://code.launchpad.net/~echeverrifm/oemedical/oemedical_lab/+merge/205519
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~echeverrifm/oemedical/oemedical_socioeconomics into lp:oemedical

2014-08-21 Thread Alexandre Fayolle - camptocamp
Review: Resubmit

Hello,

The management of the project has moved to Github: 
https://github.com/OCA/vertical-medical

Please migrate your merge proposal to Github. You may want to check 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
 for an explanation on how to proceed. 

Thanks for contributing to the project


-- 
https://code.launchpad.net/~echeverrifm/oemedical/oemedical_socioeconomics/+merge/205523
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical_refactoring_step_I into lp:oemedical

2014-08-21 Thread Alexandre Fayolle - camptocamp
Review: Resubmit

Hello,

The management of the project has moved to Github: 
https://github.com/OCA/vertical-medical

Please migrate your merge proposal to Github. You may want to check 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
 for an explanation on how to proceed. 

Thanks for contributing to the project


-- 
https://code.launchpad.net/~the-clone-master/oemedical/oemedical_refactoring_step_I/+merge/202240
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~jeffery9/oemedical/oemedical into lp:oemedical

2014-08-21 Thread Alexandre Fayolle - camptocamp
Review: Resubmit

Hello,

The management of the project has moved to Github: 
https://github.com/OCA/vertical-medical

Please migrate your merge proposal to Github. You may want to check 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
 for an explanation on how to proceed. 

Thanks for contributing to the project


-- 
https://code.launchpad.net/~jeffery9/oemedical/oemedical/+merge/194051
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp


Re: [Openerp-community-reviewer] [Merge] lp:~svass/oemedical/oemedical into lp:oemedical

2014-08-21 Thread Alexandre Fayolle - camptocamp
Hello,

The management of the project has moved to Github: 
https://github.com/OCA/vertical-medical

If you feel this change is still needed, please migrate your merge proposal to 
Github. You may want to check 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
 for an explanation on how to proceed. 

Thanks for contributing to the project


-- 
https://code.launchpad.net/~svass/oemedical/oemedical/+merge/141364
Your team OEmedical Commiter is subscribed to branch lp:oemedical.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp