Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/stock-logistic-flows/70-product_serial-plus-plus into lp:stock-logistic-flows
Well... product_serial will have to be largely re-written for v8, given all the big changes in stock management. If the modules in v7.0 stay on LP, we could keep this branch here. -- https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-product_serial-plus-plus/+merge/195144 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into lp:openerp-product-attributes
Review: Approve code review and test Alexandre, could you replay my commit revno 249 in the branch lp:~akretion-team/openerp-product-attributes/70-update-and-fix-product-gtin ; it's a small code simplification. -- https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe/+merge/222760 Your team Product Core Editors is requested to review the proposed merge of lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into lp:openerp-product-attributes. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into lp:openerp-product-attributes
Review: Approve code review and test BTW, for those who want to make EAN8 work in the POS, here is the patch for odoo master : http://people.via.ecp.fr/~alexis/ean8-pos-works.diff -- https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe/+merge/222760 Your team Product Core Editors is requested to review the proposed merge of lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into lp:openerp-product-attributes. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/partner-firstname-inheritable into lp:partner-contact-management
Alexis de Lattre has proposed merging
lp:~akretion-team/partner-contact-management/partner-firstname-inheritable into
lp:partner-contact-management.
Requested reviews:
Partner and Contact Core Editors (partner-contact-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/partner-contact-management/partner-firstname-inheritable/+merge/222730
This MP is small but very usefull : with the partner_firstname module, the
'name' field on res.partner becomes a fields.function ; this MP make the code
of the fields.function inheritable.
--
https://code.launchpad.net/~akretion-team/partner-contact-management/partner-firstname-inheritable/+merge/222730
Your team Partner and Contact Core Editors is requested to review the proposed
merge of
lp:~akretion-team/partner-contact-management/partner-firstname-inheritable into
lp:partner-contact-management.
=== modified file 'partner_firstname/partner.py'
--- partner_firstname/partner.py 2014-02-18 17:09:53 +
+++ partner_firstname/partner.py 2014-06-10 20:59:58 +
@@ -35,14 +35,19 @@
if cursor.fetchone():
cursor.execute('ALTER TABLE res_partner ALTER COLUMN lastname SET NOT NULL')
+def _prepare_name_custom(self, cursor, uid, partner, context=None):
+
+This function is designed to be inherited in a custom module
+
+names = (partner.lastname, partner.firstname)
+fullname = .join([s for s in names if s])
+return fullname
+
def _compute_name_custom(self, cursor, uid, ids, fname, arg, context=None):
res = {}
-partners = self.read(cursor, uid, ids,
- ['firstname', 'lastname'], context=context)
-for rec in partners:
-names = (rec['lastname'], rec['firstname'])
-fullname = .join([s for s in names if s])
-res[rec['id']] = fullname
+for partner in self.browse(cursor, uid, ids, context=context):
+res[partner.id] = self._prepare_name_custom(
+cursor, uid, partner, context=context)
return res
def _write_name(self, cursor, uid, partner_id, field_name, field_value, arg, context=None):
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/add-partner_relation into lp:partner-contact-management
@Holger I had a quick look at your code. Let's try to look at it together tomorrow or Friday to see what's common, what's different, and see if we can enhance the partner_relation module with some ideas from your module. -- https://code.launchpad.net/~akretion-team/partner-contact-management/add-partner_relation/+merge/220726 Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~akretion-team/partner-contact-management/add-partner_relation into lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/add-partner_relation into lp:partner-contact-management
No problem ; I'm in Louvain la neuve until Friday afternoon. -- https://code.launchpad.net/~akretion-team/partner-contact-management/add-partner_relation/+merge/220726 Your team Partner and Contact Core Editors is requested to review the proposed merge of lp:~akretion-team/partner-contact-management/add-partner_relation into lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons
I won't do a bug report on the official branch myself and a new MP because it will certainly be ignored and I don't have motivation nor time (cf https://lists.launchpad.net/banking-addons-drivers/msg00053.html). I did this bug report and MP on OCB because other members of the banking-addons mailing-list suggested it ; but it was not my initial idea. So if a volunteer can take care of that and re-use my patch, he will be more than welcomed. For those who arrive on this bug report and need an immediate fix, they can use the module account_payment_security from lp:~akretion-team/+junk/70-usability/ -- https://code.launchpad.net/~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank/+merge/208021 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
This MP fixes the bug... but I still get a crash when I try to update a partner
and add a SIREN + NIC. On a recent ocb 7.0 with an up-to-date
lp:account-financial-tools merged with
lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde,
I get this crash :
Server Traceback (most recent call last):
File /home/alexis/new_boite/dev/web-70/addons/web/session.py, line 89, in
send
return openerp.netsvc.dispatch_rpc(service_name, method, args)
File /home/alexis/new_boite/dev/server-70/openerp/netsvc.py, line 296, in
dispatch_rpc
result = ExportService.getService(service_name).dispatch(method, params)
File /home/alexis/new_boite/dev/server-70/openerp/service/web_services.py,
line 626, in dispatch
res = fn(db, uid, *params)
File /home/alexis/new_boite/dev/server-70/openerp/osv/osv.py, line 190, in
execute_kw
return self.execute(db, uid, obj, method, *args, **kw or {})
File /home/alexis/new_boite/dev/server-70/openerp/osv/osv.py, line 132, in
wrapper
return f(self, dbname, *args, **kwargs)
File /home/alexis/new_boite/dev/server-70/openerp/osv/osv.py, line 199, in
execute
res = self.execute_cr(cr, uid, obj, method, *args, **kw)
File /home/alexis/new_boite/dev/server-70/openerp/osv/osv.py, line 187, in
execute_cr
return getattr(object, method)(cr, uid, *args, **kw)
File
/home/alexis/new_boite/dev/server-70/openerp/addons/base/res/res_partner.py,
line 507, in write
result = super(res_partner,self).write(cr, uid, ids, vals, context=context)
File /home/alexis/new_boite/dev/addons-70/mail/mail_thread.py, line 292, in
write
result = super(mail_thread, self).write(cr, uid, ids, values,
context=context)
File /home/alexis/new_boite/dev/server-70/openerp/osv/orm.py, line 4348, in
write
self.pool.get(object)._store_set_values(cr, user, todo,
fields_to_recompute, context)
File /home/alexis/new_boite/dev/server-70/openerp/osv/orm.py, line 4711, in
_store_set_values
result = self._columns[f].get(cr, self, ids, f, SUPERUSER_ID,
context=context)
File /home/alexis/new_boite/dev/server-70/openerp/osv/fields.py, line 1145,
in get
result = self._fnct(obj, cr, uid, ids, name, self._arg, context)
File /home/alexis/new_boite/dev/server-70/openerp/osv/fields.py, line 1211,
in _fnct_read
value = value[field] or False
File /home/alexis/new_boite/dev/server-70/openerp/osv/orm.py, line 432, in
__getitem__
raise KeyError('Field %s not found in %s'%(name, self))
KeyError: 'Field partner_id not found in browse_record(res.company, 18)'
So l10n_fr_siret is still not usable for me.
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
The bug is in the invalidation function _get_partner_change in company.py : the
invalidation function should be :
def _get_partner_change(self, cr, uid, ids, context=None):
return self.pool['res.company'].search(
cr, uid, [('partner_id', 'in', ids)], context=context)
The invalidation function is this MP is wrong : it returns IDs of partners...
where as it should return IDs of companies !!!
--
https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch
lp:account-financial-tools.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde into lp:account-financial-tools
Review: Approve code review and test Thanks Yannick for applying the fix. I have tested the new branch and it works well. -- https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-fix-l10n_fr_siret-fix-lp1320918-rde/+merge/220090 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/add-partner_relation into lp:partner-contact-management
Alexis de Lattre has proposed merging
lp:~akretion-team/partner-contact-management/add-partner_relation into
lp:partner-contact-management.
Requested reviews:
Partner and Contact Core Editors (partner-contact-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/partner-contact-management/add-partner_relation/+merge/220726
This merge proposal adds a new module partner_relation. Here is the description
:
===
This module adds relations between partners. The type of relation is
configurable ; it supports symetric and asymetric relations.
For example, you will be able to define on the form view of partner A that :
* Partner A is a competitor of Partner B (symetric relation : B is a competitor
of A),
* Partner A has been recommended by Partner C (asymetric relation : C
recommands A),
* Partner A is the editor of Partner D (asymetric relation : D is the
integrator of A).
The relations that you define on Partner A towards Partner B will automatically
be visible on the form view of Partner B.
Technically, it is not easy to implement in OpenERP. This implementation
inherit the create() of the relation object to automatically generate a reverse
relation (src_partner_id and dest_partner_id are swapped and the type of
relation is the reverse if the relation is asymetric).
I have tried other implementations that would avoid to create a double entry
for each relation, but all the other implementations were not good enough
because I wanted relations to be simple and easy-to-use inside the partner form
view.
This module is flake8 compliant, has demo data, ACLs, POT file and even an icon
! :)
--
https://code.launchpad.net/~akretion-team/partner-contact-management/add-partner_relation/+merge/220726
Your team Partner and Contact Core Editors is requested to review the proposed
merge of lp:~akretion-team/partner-contact-management/add-partner_relation into
lp:partner-contact-management.
=== added directory 'partner_relation'
=== added file 'partner_relation/__init__.py'
--- partner_relation/__init__.py 1970-01-01 00:00:00 +
+++ partner_relation/__init__.py 2014-05-22 21:44:09 +
@@ -0,0 +1,23 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#Partner Relation module for OpenERP
+#Copyright (C) 2014 Artisanat Monastique de Provence (www.barroux.org)
+#@author: Alexis de Lattre alexis.delat...@akretion.com
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import partner_relation
=== added file 'partner_relation/__openerp__.py'
--- partner_relation/__openerp__.py 1970-01-01 00:00:00 +
+++ partner_relation/__openerp__.py 2014-05-22 21:44:09 +
@@ -0,0 +1,57 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#Partner Relation module for OpenERP
+#Copyright (C) 2014 Artisanat Monastique de Provence (www.barroux.org)
+#@author: Alexis de Lattre alexis.delat...@akretion.com
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+
+{
+'name': 'Partner Relation',
+'version': '0.1',
+'category': 'Partner',
+'license': 'AGPL-3',
+'summary': 'Adds relations between partners',
+'description':
+Partner Relation
+
+
+This module adds relations between partners. The type of relation is configurable ; it supports symetric and asymetric relations.
+
+For example, you will be able to define on the form view of partner
[Openerp-community-reviewer] [Merge] lp:~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456 into lp:hr-timesheet
Alexis de Lattre has proposed merging
lp:~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456 into
lp:hr-timesheet.
Requested reviews:
HR Core Editors (hr-core-editors)
Related bugs:
Bug #1316456 in HR - Timesheet Management: hr_timesheet_task : can't save
new task : Analytic Account field is invalid
https://bugs.launchpad.net/hr-timesheet/+bug/1316456
For more details, see:
https://code.launchpad.net/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456/+merge/218364
I have fixed the bug https://bugs.launchpad.net/hr-timesheet/+bug/1316456 in
this merge proposal. Please refer to the bug report to get a complete bug
description with the scenario to reproduce it.
--
https://code.launchpad.net/~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456/+merge/218364
Your team HR Core Editors is requested to review the proposed merge of
lp:~akretion-team/hr-timesheet/70-fix-timesheet-task-bug1316456 into
lp:hr-timesheet.
=== modified file 'timesheet_task/project_task.py'
--- timesheet_task/project_task.py 2013-10-08 11:06:18 +
+++ timesheet_task/project_task.py 2014-05-06 08:39:54 +
@@ -135,7 +135,8 @@
_name = hr.analytic.timesheet
def on_change_unit_amount(self, cr, uid, sheet_id, prod_id, unit_amount, company_id,
- unit=False, journal_id=False, task_id=False, to_invoice=False,
+ unit=False, journal_id=False, task_id=False,
+ to_invoice=False, project_id=False,
context=None):
res = super(HrAnalyticTimesheet, self).on_change_unit_amount(cr,
uid,
@@ -146,9 +147,14 @@
unit,
journal_id,
context)
-if 'value' in res and task_id:
-task_obj = self.pool.get('project.task')
-p = task_obj.browse(cr, uid, task_id).project_id
+if 'value' in res and (task_id or project_id):
+if task_id:
+task_obj = self.pool.get('project.task')
+p = task_obj.browse(
+cr, uid, task_id, context=context).project_id
+elif project_id:
+p = self.pool['project.project'].browse(
+cr, uid, project_id, context=context)
if p:
res['value']['account_id'] = p.analytic_account_id.id
if p.to_invoice and not to_invoice:
=== modified file 'timesheet_task/project_task_view.xml'
--- timesheet_task/project_task_view.xml 2013-04-24 12:53:33 +
+++ timesheet_task/project_task_view.xml 2014-05-06 08:39:54 +
@@ -76,7 +76,7 @@
required=1 invisible=1/
field name=name /
field name=unit_amount
-on_change=on_change_unit_amount(product_id, unit_amount, False, product_uom_id,journal_id, parent.id, to_invoice)
+on_change=on_change_unit_amount(product_id, unit_amount, False, product_uom_id,journal_id, parent.id, to_invoice, parent.project_id, context)
sum=Total time widget=float_time /
field name=date
on_change=on_change_date(date) /
@@ -209,4 +209,4 @@
/record
/data
-/openerp
\ No newline at end of file
+/openerp
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1
Alexis de Lattre has proposed merging
lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into
lp:account-financial-report/6.1.
Requested reviews:
Account Report Core Editors (account-report-core-editor)
Related bugs:
Bug #1274194 in Account - Financial Report: Wrong balance formula in trial
balance xls when using date filter
https://bugs.launchpad.net/account-financial-report/+bug/1274194
For more details, see:
https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070
Same as this MP
https://code.launchpad.net/~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls/+merge/217063
but for the 6.1 branch.
--
https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070
Your team Account Report Core Editors is requested to review the proposed merge
of lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls
into lp:account-financial-report/6.1.
=== modified file 'account_financial_report_webkit_xls/report/trial_balance_xls.py'
--- account_financial_report_webkit_xls/report/trial_balance_xls.py 2014-01-27 14:32:33 +
+++ account_financial_report_webkit_xls/report/trial_balance_xls.py 2014-04-24 15:24:58 +
@@ -218,9 +218,9 @@
('account', account_span, 0, 'text', current_account.name),
]
if _p.comparison_mode == 'no_comparison':
-
-debit_cell = rowcol_to_cell(row_pos, 3)
-credit_cell = rowcol_to_cell(row_pos, 4)
+
+debit_cell = rowcol_to_cell(row_pos, 4)
+credit_cell = rowcol_to_cell(row_pos, 5)
bal_formula = debit_cell + '-' + credit_cell
if _p.initial_balance_mode:
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma
Just adding a small comment to say that Raphaël Valyi discovered a bug when doing a -u crm_claim_rma with that branch (it breaks on the duplicate constraint). We started digging to find a solution, but we didn't had time to implement it yet. -- https://code.launchpad.net/~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup/+merge/215970 Your team OpenERP RMA is requested to review the proposed merge of lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup into lp:openerp-rma. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-analytic/account_analytic_required-test_suite-sbi into lp:account-analytic
OK, let's go and merge it in the main branch now :) -- https://code.launchpad.net/~acsone-openerp/account-analytic/account_analytic_required-test_suite-sbi/+merge/216451 Your team Account Core Editors is subscribed to branch lp:account-analytic. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-analytic/account_analytic_required-test_suite-sbi into lp:account-analytic
Review: Approve code review and tests Nice update. Thank you Stefan. I am pushing to you a branch with pep8 stuff and the additional of the field in the tree view (and not just form view). -- https://code.launchpad.net/~acsone-openerp/account-analytic/account_analytic_required-test_suite-sbi/+merge/216451 Your team Account Core Editors is subscribed to branch lp:account-analytic. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-analytic/account_analytic_required-test_suite-sbi into lp:account-analytic
There it is : https://code.launchpad.net/~akretion-team/account-analytic/account-analytic-required-pep8/+merge/216497 -- https://code.launchpad.net/~acsone-openerp/account-analytic/account_analytic_required-test_suite-sbi/+merge/216451 Your team Account Core Editors is subscribed to branch lp:account-analytic. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/openerp-rma/add-crm-claim-rma-repair into lp:openerp-rma
Alexis de Lattre has proposed merging
lp:~akretion-team/openerp-rma/add-crm-claim-rma-repair into lp:openerp-rma with
lp:~akretion-team/openerp-rma/rma-cleanup-cleanup-cleanup as a prerequisite.
Requested reviews:
OpenERP RMA (openerprma)
For more details, see:
https://code.launchpad.net/~akretion-team/openerp-rma/add-crm-claim-rma-repair/+merge/215976
This MP adds the module crm_claim_rma_repair. It is a small module that adds
the ability to create a repair from a CRM claim. It depends on 'mrp_repair' and
'crm_claim_rma'.
--
https://code.launchpad.net/~akretion-team/openerp-rma/add-crm-claim-rma-repair/+merge/215976
Your team OpenERP RMA is requested to review the proposed merge of
lp:~akretion-team/openerp-rma/add-crm-claim-rma-repair into lp:openerp-rma.
=== added directory 'crm_claim_rma_repair'
=== added file 'crm_claim_rma_repair/__init__.py'
--- crm_claim_rma_repair/__init__.py 1970-01-01 00:00:00 +
+++ crm_claim_rma_repair/__init__.py 2014-04-15 22:17:58 +
@@ -0,0 +1,24 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#CRM Claim RMA Repair module for OpenERP
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#@author Alexis de Lattre alexis.delat...@akretion.com
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import wizard
+from . import crm_claim
=== added file 'crm_claim_rma_repair/__openerp__.py'
--- crm_claim_rma_repair/__openerp__.py 1970-01-01 00:00:00 +
+++ crm_claim_rma_repair/__openerp__.py 2014-04-15 22:17:58 +
@@ -0,0 +1,46 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#CRM Claim RMA Repair extension module for OpenERP
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#@author Alexis de Lattre alexis.delat...@akretion.com
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+
+{
+'name': 'CRM Claim RMA Repair',
+'version': '0.1',
+'category': 'Customer Relationship Management',
+'license': 'AGPL-3',
+'summary': 'Connect crm_claim_rma with mrp_repair',
+'description':
+CRM Claim RMA Repair
+
+
+Add ability to create a repair from a CRM claim.
+
+Please contact Alexis de Lattre from Akretion alexis.delat...@akretion.com for any help or question about this module.
+,
+'author': 'Akretion',
+'website': 'http://www.akretion.com',
+'depends': ['mrp_repair', 'crm_claim_rma'],
+'data': [
+'wizard/claim_make_repair_view.xml',
+'crm_claim_view.xml',
+],
+'active': False,
+}
=== added file 'crm_claim_rma_repair/crm_claim.py'
--- crm_claim_rma_repair/crm_claim.py 1970-01-01 00:00:00 +
+++ crm_claim_rma_repair/crm_claim.py 2014-04-15 22:17:58 +
@@ -0,0 +1,43 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#CRM Claim RMA Repair module for OpenERP
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#@author Alexis de Lattre alexis.delat...@akretion.com
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management
@Nicolas: I confirm that it returns 404 if you try to download a wrong country. I have taken into account your other remarks in my last commits (unless the tests ; I don't have experience in this). I am not sure I fully understand the benefit of the FOR UPDATE NOWAIT in this particular case... at least I hope I implemented it as you wanted. -- https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management
@Nicolas As I said in my comment, I think that it's better for the module base_location_geonames_import to sit right next to the base_location module, so that it's easier to find for users of the base_location module. We could even imagine that the wizard that is provided by base_location_geonames_import could be provided inside base_location and not in a separate module. -- https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564 Your team Partner and Contact Core Editors is subscribed to branch lp:partner-contact-management. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management
Alexis de Lattre has proposed merging
lp:~akretion-team/partner-contact-management/base-location-geonames-import into
lp:partner-contact-management.
Requested reviews:
Partner and Contact Core Editors (partner-contact-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564
Add module base_location_geonames_import ; this module adds a wizard to import
better zip entries from Geonames (http://download.geonames.org/export/zip/).
Nicolas Bessi suggested on twitter that it should be part of the geospacial
addons. But, after thinking about it, my opinion is that this module would be
better here, because users of the base_location module would have a higher
chance of finding this module here than in the geospacial addons.
--
https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564
Your team Partner and Contact Core Editors is requested to review the proposed
merge of
lp:~akretion-team/partner-contact-management/base-location-geonames-import into
lp:partner-contact-management.
=== added directory 'base_location_geonames_import'
=== added file 'base_location_geonames_import/__init__.py'
--- base_location_geonames_import/__init__.py 1970-01-01 00:00:00 +
+++ base_location_geonames_import/__init__.py 2014-04-07 15:18:55 +
@@ -0,0 +1,23 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#Base Location Geonames Import module for OpenERP
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#@author Alexis de Lattre alexis.delat...@akretion.com
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import wizard
=== added file 'base_location_geonames_import/__openerp__.py'
--- base_location_geonames_import/__openerp__.py 1970-01-01 00:00:00 +
+++ base_location_geonames_import/__openerp__.py 2014-04-07 15:18:55 +
@@ -0,0 +1,47 @@
+# -*- encoding: utf-8 -*-
+##
+#
+#Base Location Geonames Import module for OpenERP
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#@author Alexis de Lattre alexis.delat...@akretion.com
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+
+{
+'name': 'Base Location Geonames Import',
+'version': '0.1',
+'category': 'Extra Tools',
+'license': 'AGPL-3',
+'summary': 'Import better zip entries from Geonames',
+'description':
+Base Location Geonames Import
+=
+
+This module adds a wizard to import better zip entries from Geonames (http://download.geonames.org/export/zip/).
+
+Please contact Alexis de Lattre from Akretion alexis.delat...@akretion.com for any help or question about this module.
+,
+'author': 'Akretion',
+'website': 'http://www.akretion.com',
+'depends': ['base_location'],
+'external_dependencies': {'python': ['requests', 'unicodecsv']},
+'data': [
+'wizard/geonames_import_view.xml',
+],
+'installable': True,
+'active': False,
+}
=== added directory 'base_location_geonames_import/i18n'
=== added file 'base_location_geonames_import/i18n/base_location_geonames_import.pot'
--- base_location_geonames_import/i18n/base_location_geonames_import.pot 1970-01-01 00:00:00 +
+++ base_location_geonames_import/i18n/base_location_geonames_import.pot 2014-04-07 15:18:55 +
@@ -0,0 +1,68 @@
+# Translation
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into lp:account-invoice-report
I see that this module got merged without modification, and none of the points that I raise in my review were addressed, which is a bit surprising. For example, the point 3 that I raised was : on the invoice line, you add a field 'displayed_lot_id' but you don't use it anywhere. What is this field for ? Lorenzo answered that this field was useless and could be removed. But the module was commited to the branch with this field. So we have a just added a module with a field that nobody knows what it is for. Joël, why did you commit the module without changes ? We could have at least cleaned-up this ! -- https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~jeffery9/ocb-addons/ocb-addons into lp:ocb-addons
I confirm that the addition of
field name=context{'default_state': 'open'}/field
in crm/wizard/crm_phonecall_to_phonecall_view.xml
fixes the bug.
The other changes are not related to the bug.
--
https://code.launchpad.net/~jeffery9/ocb-addons/ocb-addons/+merge/193883
Your team OpenERP Community Backports Team is subscribed to branch
lp:ocb-addons.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/stock-logistic-flows/70-product_serial-plus-plus into lp:stock-logistic-flows
@Alexandre Thanks for your review. You are right, the fact that I don't call super() on _create_pickings_and_procurements() in the module product_serial_sale_stock is a big problem and I am aware of that. But, unfortunately, I didn't find a solution that includes calling super(). If you think it's possible, please give me some ideas ! I am not an expert of monkey patching, but I'll see with my colleagues if it is possible. And thanks for pointing out my mistakes on English irregular verbs :) -- https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-product_serial-plus-plus/+merge/195144 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-forecast-prepaid into lp:account-closing
Alexis de Lattre has proposed merging
lp:~akretion-team/account-closing/70-forecast-prepaid into lp:account-closing.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/account-closing/70-forecast-prepaid/+merge/210066
The main change in this MP is the addition of one new feature : the ability to
compute forecasts of prepaid expense and prepaid revenue. This is important
when working on budgets ; it allows the Accountant to easily compute the amount
of prepaid revenue and prepaid expense between 2 dates in the future (you can
also use it for dates in the past...).
This feature used to be available in the module account_prepaid_reporting
from lp:~akretion-team/+junk/70-prepaid-reporting, but this module had a lot of
duplicate code with the module account_cutoff_prepaid and it was based on two
TransientModels which caused some bugs in some scenarios when doing CSV
exports. So I eventually decided to try to integrate this feature inside the
module account_cutoff_prepaid ; I am happy with the result (it avoids code
duplication and only introduce a few lines of additional code) so I propose it
for inclusion in the official branch.
--
https://code.launchpad.net/~akretion-team/account-closing/70-forecast-prepaid/+merge/210066
Your team Account Core Editors is requested to review the proposed merge of
lp:~akretion-team/account-closing/70-forecast-prepaid into lp:account-closing.
=== modified file 'account_cutoff_base/account_cutoff.py'
--- account_cutoff_base/account_cutoff.py 2013-12-24 15:31:15 +
+++ account_cutoff_base/account_cutoff.py 2014-03-09 00:20:56 +
@@ -61,7 +61,7 @@
_columns = {
'cutoff_date': fields.date(
-'Cut-off Date', required=True, readonly=True,
+'Cut-off Date', readonly=True,
states={'draft': [('readonly', False)]},
track_visibility='always'),
'type': fields.selection([
@@ -75,7 +75,7 @@
'account.move', 'Cut-off Journal Entry', readonly=True),
'move_label': fields.char(
'Label of the Cut-off Journal Entry',
-size=64, required=True, readonly=True,
+size=64, readonly=True,
states={'draft': [('readonly', False)]},
help=This label will be written in the 'Name' field of the
Cut-off Account Move Lines and in the 'Reference' field of
@@ -83,10 +83,9 @@
'cutoff_account_id': fields.many2one(
'account.account', 'Cut-off Account',
domain=[('type', '', 'view'), ('type', '', 'closed')],
-required=True, readonly=True,
-states={'draft': [('readonly', False)]}),
+readonly=True, states={'draft': [('readonly', False)]}),
'cutoff_journal_id': fields.many2one(
-'account.journal', 'Cut-off Account Journal', required=True,
+'account.journal', 'Cut-off Account Journal',
readonly=True, states={'draft': [('readonly', False)]}),
'total_cutoff_amount': fields.function(
_compute_total_cutoff, type='float', string=Total Cut-off Amount,
@@ -165,12 +164,15 @@
)]
def cutoff_date_onchange(
-self, cr, uid, ids, type, cutoff_date, move_label):
+self, cr, uid, ids, type, cutoff_date, move_label, context=None):
+if context is None:
+context = {}
res = {'value': {}}
if type and cutoff_date:
-context = {'type': type, 'cutoff_date': cutoff_date}
+ctx = context.copy()
+ctx.update({'type': type, 'cutoff_date': cutoff_date})
res['value']['move_label'] = self._default_move_label(
-cr, uid, context=context)
+cr, uid, context=ctx)
return res
def back2draft(self, cr, uid, ids, context=None):
=== modified file 'account_cutoff_base/account_cutoff_view.xml'
--- account_cutoff_base/account_cutoff_view.xml 2013-10-15 19:35:48 +
+++ account_cutoff_base/account_cutoff_view.xml 2014-03-09 00:20:56 +
@@ -35,15 +35,15 @@
/div
group name=top
group name=general-params
-field name=cutoff_date on_change=cutoff_date_onchange(type, cutoff_date, move_label)/
+field name=cutoff_date on_change=cutoff_date_onchange(type, cutoff_date, move_label, context)/
field name=total_cutoff_amount widget=monetary options={'currency_field': 'company_currency_id'}/
field name=company_id groups=base.group_multi_company widget=selection /
field name=company_currency_id invisible=1/
/group
group name=accounting-params
-field name=cutoff_journal_id/
-field name=cutoff_account_id/
-field name
[Openerp-community-reviewer] [Merge] lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons
Alexis de Lattre has proposed merging
lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into lp:ocb-addons.
Requested reviews:
OpenERP Community Backports Team (ocb)
For more details, see:
https://code.launchpad.net/~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank/+merge/208021
This MP aims at fixing the issue that I described long ago in this mail :
https://lists.launchpad.net/openerp-community/msg01035.html
In short : regular users are usually in the Contact Creation group because
they need to create/modify partners. By default in OpenERP, it also grants them
create/write permissions on bank accounts. If you use OpenERP to generate SEPA
files and make payments, a regular user could modify the bank account of a
supplier and put it's own bank account instead and receive the payments for the
supplier on its own bank account ! As you can imagine, this is a problem :)
This merge proposal follows a discussion that took place in the
banking-addons-drivers mailing-list, cf this thread
https://lists.launchpad.net/banking-addons-drivers/msg00050.html
--
https://code.launchpad.net/~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank/+merge/208021
Your team OpenERP Community Backports Team is requested to review the proposed
merge of lp:~akretion-team/ocb-addons/70-addons-fix-payment-acls-bank into
lp:ocb-addons.
=== modified file 'account/security/account_security.xml'
--- account/security/account_security.xml 2012-10-23 16:05:04 +
+++ account/security/account_security.xml 2014-02-24 21:35:22 +
@@ -30,6 +30,15 @@
field name=nameCheck Total on supplier invoices/field
field name=category_id ref=base.module_category_hidden/
/record
+
+!-- Remove ACLs that give configuration rights on bank accounts to
+to base.group_partner_manager. In the CSV file, we give those rights
+to group_account_manager --
+delete model=ir.model.access
+ id=base.access_res_partner_bank_type_group_partner_manager/
+delete model=ir.model.access
+id=base.access_res_partner_bank_type_field_group_partner_manager/
+
/data
data noupdate=1
=== modified file 'account/security/ir.model.access.csv'
--- account/security/ir.model.access.csv 2012-10-23 16:05:04 +
+++ account/security/ir.model.access.csv 2014-02-24 21:35:22 +
@@ -98,3 +98,5 @@
access_account_treasury_report_manager,account.treasury.report.manager,model_account_treasury_report,account.group_account_manager,1,0,0,0
access_account_financial_report,account.financial.report,model_account_financial_report,account.group_account_user,1,1,1,1
access_account_financial_report_invoice,account.financial.report invoice,model_account_financial_report,account.group_account_invoice,1,0,0,0
+access_res_partner_bank_type_account_manager,Full access on res.partner.bank.type to Financial Manager,base.model_res_partner_bank_type,group_account_manager,1,1,1,1
+access_res_partner_bank_type_field_account_manager,Full access on res.partner.bank.type.field to Financial Manager,base.model_res_partner_bank_type_field,group_account_manager,1,1,1,1
=== modified file 'account_payment/security/account_payment_security.xml'
--- account_payment/security/account_payment_security.xml 2012-10-23 16:05:04 +
+++ account_payment/security/account_payment_security.xml 2014-02-24 21:35:22 +
@@ -10,6 +10,20 @@
field name=implied_ids eval=[(4, ref('group_account_payment'))]/
/record
+!-- When the account_payment module is installed, we don't want
+users that belong to the Contract Creation group
+(base.group_partner_manager) to be able to create/modify bank accounts
+because they could change bank account information of suppliers
+and divert wire transfers to suppliers. So we delete the ACLs
+that give create/write access on res.partner.bank and res.bank to the
+group base.group_partner_manager and we add ACLs in the CSV file
+that give those rights to members of account_payment.group_account_payment
+--
+delete model=ir.model.access
+id=base.access_res_bank_group_partner_manager/
+delete model=ir.model.access
+id=base.access_res_partner_bank_group_partner_manager/
+
/data
data noupdate=1
=== modified file 'account_payment/security/ir.model.access.csv'
--- account_payment/security/ir.model.access.csv 2011-12-19 16:54:40 +
+++ account_payment/security/ir.model.access.csv 2014-02-24 21:35:22 +
@@ -6,3 +6,5 @@
access_account_invoice_payment,account.invoice payment,account.model_account_invoice,group_account_payment,1,0,0,0
access_account_move_line_payment,account.move.line payment,account.model_account_move_line,group_account_payment,1,0,0,0
access_payment_order_manager,payment.order manager,model_payment_order,account.group_account_manager,1,0,0,0
+access_res_partner_bank_account_payment,Full access on res.partner.bank to Account Payment,base.model_res_partner_bank,group_account_payment,1,1,1,1
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/stock-logistic-flows/70-product_serial-plus-plus into lp:stock-logistic-flows
@Yannick: As I said, this MP is a first step towards a split ; as you can see, it introduce 2 new modules : product_serial_sale_stock and product_serial_purchase. I am about to do an MP on lp:openerp-manufacturing for product_serial_mrp. BUT I didn't say that i'll do all the work for the split by myself. You say : You should already create an other MP : you are also invited to do it, it's a community work, not just my own work ! I am not the original author of the module product_serial, I am just a modest contributor on this module. -- https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-product_serial-plus-plus/+merge/195144 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-addons/ocb-7.0-fix_1281687-afe into lp:ocb-addons
Review: Approve code review and tests Thanks Alexandre for the MP and the additionnal test. -- https://code.launchpad.net/~camptocamp/ocb-addons/ocb-7.0-fix_1281687-afe/+merge/207116 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced into lp:stock-logistic-flows
I see what you mean. It's a bit heavy, but I don't see a better solution... i'll try to find time to implement this shortly. -- https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced/+merge/205051 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced into lp:stock-logistic-flows
@Pedro I have made the implementation: it works well, but one may consider that it's too much code for a small detail... By the way, we also had a problem with the view of invoices : I had put Delivery Orders for the tab of customer invoices... but, on a customer refund, it should be Incoming Shipments ; so I took the simple option to always use the word Picking. -- https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced/+merge/205051 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced into lp:stock-logistic-flows
@Pedro: You are right, it doesn't select the right invoice view for returns. If you have a better idea, please tell me. -- https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-picking-invoice-link-enhanced/+merge/205051 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/stock-logistic-flows/70-picking-priority-small-enhancements into lp:stock-logistic-flows
Alexis de Lattre has proposed merging
lp:~akretion-team/stock-logistic-flows/70-picking-priority-small-enhancements
into lp:stock-logistic-flows.
Requested reviews:
Stock and Logistic Core Editors (stock-logistic-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-picking-priority-small-enhancements/+merge/204410
Update of the module stock_picking_priority. The 2 main changes are :
- Add POT file and FR translation
- More reasonable size for the dialog box Recompute Picking Availability
--
https://code.launchpad.net/~akretion-team/stock-logistic-flows/70-picking-priority-small-enhancements/+merge/204410
Your team Stock and Logistic Core Editors is requested to review the proposed
merge of
lp:~akretion-team/stock-logistic-flows/70-picking-priority-small-enhancements
into lp:stock-logistic-flows.
=== modified file 'stock_picking_priority/__openerp__.py'
--- stock_picking_priority/__openerp__.py 2013-12-11 07:57:43 +
+++ stock_picking_priority/__openerp__.py 2014-02-02 21:47:11 +
@@ -21,7 +21,7 @@
{
-name: Picking priority,
+name: Picking Priority,
version: 0.1,
depends: ['stock'],
author: Camptocamp,
@@ -32,7 +32,7 @@
wizard can be run to recompute the availability of pickings
depending on the new priorities.,
website: http://www.camptocamp.com;,
-category: Warehouse management,
+category: Warehouse Management,
demo: [
'picking_priority_demo.yml',
],
=== added directory 'stock_picking_priority/i18n'
=== added file 'stock_picking_priority/i18n/fr.po'
--- stock_picking_priority/i18n/fr.po 1970-01-01 00:00:00 +
+++ stock_picking_priority/i18n/fr.po 2014-02-02 21:47:11 +
@@ -0,0 +1,113 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+# * stock_picking_priority
+#
+msgid
+msgstr
+Project-Id-Version: OpenERP Server 7.0\n
+Report-Msgid-Bugs-To: \n
+POT-Creation-Date: 2014-02-02 18:32+\n
+PO-Revision-Date: 2014-02-02 18:32+\n
+Last-Translator: \n
+Language-Team: \n
+MIME-Version: 1.0\n
+Content-Type: text/plain; charset=UTF-8\n
+Content-Transfer-Encoding: \n
+Plural-Forms: \n
+
+#. module: stock_picking_priority
+#: selection:stock.picking,priority:0
+#: selection:stock.picking.in,priority:0
+#: selection:stock.picking.out,priority:0
+msgid Very Urgent
+msgstr Très urgent
+
+#. module: stock_picking_priority
+#: model:ir.actions.act_window,name:stock_picking_priority.action_retry_assign
+#: model:ir.ui.menu,name:stock_picking_priority.menu_retry_availability
+#: view:stock.picking.retry.availability:0
+msgid Recompute Picking Availability
+msgstr Recalcule la disponibilité
+
+#. module: stock_picking_priority
+#: selection:stock.picking,priority:0
+#: selection:stock.picking.in,priority:0
+#: selection:stock.picking.out,priority:0
+msgid Normal
+msgstr Normale
+
+#. module: stock_picking_priority
+#: model:ir.model,name:stock_picking_priority.model_stock_picking_retry_availability
+msgid stock.picking.retry.availability
+msgstr stock.picking.retry.availability
+
+#. module: stock_picking_priority
+#: view:stock.picking.retry.availability:0
+msgid Recompute Availability
+msgstr Recalcule la disponibilité
+
+#. module: stock_picking_priority
+#: model:ir.model,name:stock_picking_priority.model_stock_picking_in
+msgid Incoming Shipments
+msgstr Bons de réception
+
+#. module: stock_picking_priority
+#: field:stock.picking,priority:0
+#: field:stock.picking.in,priority:0
+#: field:stock.picking.out,priority:0
+msgid Priority
+msgstr Priorité
+
+#. module: stock_picking_priority
+#: help:stock.picking,priority:0
+#: help:stock.picking.in,priority:0
+#: help:stock.picking.out,priority:0
+msgid The priority of the picking
+msgstr La priorité de la livraison
+
+#. module: stock_picking_priority
+#: code:addons/stock_picking_priority/picking_priority.py:69
+#, python-format
+msgid Warning
+msgstr Avertissement
+
+#. module: stock_picking_priority
+#: view:stock.picking.retry.availability:0
+msgid This action will recompute the availability of the pickings based on their priority. Before running it, make sure that you have changed the priority of at least one picking.
+msgstr Cette action va recalculer la disponibilité des livraisons en se basant sur leur priorité. Avant de la lancer, vous devez avoir changé la priorité d'au moins une livraison.
+
+#. module: stock_picking_priority
+#: model:ir.model,name:stock_picking_priority.model_stock_picking
+msgid Picking List
+msgstr Opération de manutention
+
+#. module: stock_picking_priority
+#: view:stock.picking.retry.availability:0
+msgid Cancel
+msgstr Annuler
+
+#. module: stock_picking_priority
+#: selection:stock.picking,priority:0
+#: selection:stock.picking.in,priority:0
+#: selection:stock.picking.out,priority:0
+msgid Urgent
+msgstr Urgent
+
+#. module: stock_picking_priority
+#: model:ir.model,name:stock_picking_priority.model_stock_picking_out
+msgid
[Openerp-community-reviewer] [Bug 1271139] [NEW] Crash when clicking on Split in Serial Numbers
Public bug reported: I just found a regression in OCB : the following bug is present in an up-to-date OCB 7.0 environnement, but it is not present in an up-to-date official environnement ! Here are the steps to reproduce the problem : 1) Get an up-to-date OCB 7.0 environnement (server, web, addons) 2) Create a new DB with demo data 3) Login as admin and install the stock module 4) Add the admin user to the group Manage serial numbers 5) Create a new delivery order with 1 stock move : - product : USB adaptateur - Qty : 3 Save this move line and save the delivery order. 6) Click on the icon Split in Serial Numbers in the move line (icon representing a sheet of paper with lines) = You get View error message : Can't find field 'product_uos_qty' in the following view parts composing the view of object model 'stock.move': * stock.move.form Either you wrongly customized this view, or some modules bringing those views are not compatible with your current data model This bug is not present in with server+addons+web from the official branches (as a consequence, the bug is not present on the runbot for v7.0). ** Affects: ocb-addons Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenERP Community Backports Team, which is subscribed to OpenERP Community Backports (Addons). https://bugs.launchpad.net/bugs/1271139 Title: Crash when clicking on Split in Serial Numbers Status in OpenERP Community Backports (Addons): New Bug description: I just found a regression in OCB : the following bug is present in an up-to-date OCB 7.0 environnement, but it is not present in an up-to- date official environnement ! Here are the steps to reproduce the problem : 1) Get an up-to-date OCB 7.0 environnement (server, web, addons) 2) Create a new DB with demo data 3) Login as admin and install the stock module 4) Add the admin user to the group Manage serial numbers 5) Create a new delivery order with 1 stock move : - product : USB adaptateur - Qty : 3 Save this move line and save the delivery order. 6) Click on the icon Split in Serial Numbers in the move line (icon representing a sheet of paper with lines) = You get View error message : Can't find field 'product_uos_qty' in the following view parts composing the view of object model 'stock.move': * stock.move.form Either you wrongly customized this view, or some modules bringing those views are not compatible with your current data model This bug is not present in with server+addons+web from the official branches (as a consequence, the bug is not present on the runbot for v7.0). To manage notifications about this bug go to: https://bugs.launchpad.net/ocb-addons/+bug/1271139/+subscriptions -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/ocb-web/7.0-ContextGroupByPropagationIssue-1101840 into lp:ocb-web
Review: Approve tests only I confirm that this MP solves the bug Crash when clicking on Split in Serial Numbers https://bugs.launchpad.net/ocb-addons/+bug/1271139 So this patch is now in production :) -- https://code.launchpad.net/~camptocamp/ocb-web/7.0-ContextGroupByPropagationIssue-1101840/+merge/198582 Your team OpenERP Community Backports Team is subscribed to branch lp:ocb-web. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/bugfix-account_journal_report_xls into lp:account-financial-report
@Luc I am surprised that your customer base never asked for analytic account in the journal export. Most of my customers use analytic accounting and your module account_journal_report_xls export is quite convenient to export journals to another accounting software (for the customers who have an external accountant). If it's a 5 minutes job to add analytic account, let's do it :) It's not a problem if it's not in the default list, as it's easy to modify via inheritance. A second field would be convenient for me : the journal code (no need to put it in the default list, because we already have a tab per journal). -- https://code.launchpad.net/~luc-demeyer/account-financial-report/bugfix-account_journal_report_xls/+merge/201660 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/70-sale-validity-enhanced into lp:sale-wkfl
Alexis de Lattre has proposed merging lp:~akretion-team/sale-wkfl/70-sale-validity-enhanced into lp:sale-wkfl. Requested reviews: Sale Core Editors (sale-core-editors) For more details, see: https://code.launchpad.net/~akretion-team/sale-wkfl/70-sale-validity-enhanced/+merge/201762 This is a small update to the sale_validity module : 1) Update v7 code style and PEP8 2) Add POT file 3) Add default duration (in days) for sale order validity on res.company. If you leave this value to 0 (which is the default), there won't be a default value for the validity date on the sale order. So, if you upgrade to this new version and you don't change the configuration, the behavior of the module will not change (= safe upgrade). -- https://code.launchpad.net/~akretion-team/sale-wkfl/70-sale-validity-enhanced/+merge/201762 Your team Sale Core Editors is requested to review the proposed merge of lp:~akretion-team/sale-wkfl/70-sale-validity-enhanced into lp:sale-wkfl. === modified file 'sale_validity/__openerp__.py' --- sale_validity/__openerp__.py 2013-11-08 08:42:37 + +++ sale_validity/__openerp__.py 2014-01-15 12:05:13 + @@ -30,10 +30,15 @@ Add a validity date on the sales quotation defining -until when the quotation is valid +until when the quotation is valid. + +A default validity duration (in days) can be configured on the company. , - 'data': [view/sale_order.xml], + 'data': [ +view/sale_order.xml, +view/company_view.xml, +], 'installable': True, 'active': False, } === added directory 'sale_validity/i18n' === added file 'sale_validity/i18n/sale_validity.pot' --- sale_validity/i18n/sale_validity.pot 1970-01-01 00:00:00 + +++ sale_validity/i18n/sale_validity.pot 2014-01-15 12:05:13 + @@ -0,0 +1,57 @@ +# Translation of OpenERP Server. +# This file contains the translation of the following modules: +# * sale_validity +# +msgid +msgstr +Project-Id-Version: OpenERP Server 7.0\n +Report-Msgid-Bugs-To: \n +POT-Creation-Date: 2014-01-15 11:51+\n +PO-Revision-Date: 2014-01-15 11:51+\n +Last-Translator: \n +Language-Team: \n +MIME-Version: 1.0\n +Content-Type: text/plain; charset=UTF-8\n +Content-Transfer-Encoding: \n +Plural-Forms: \n + +#. module: sale_validity +#: view:sale.order:0 +msgid date_order_change(date_order, date_validity, company_id, context) +msgstr + +#. module: sale_validity +#: help:sale.order,date_validity:0 +msgid Define date until when quotation is valid +msgstr + +#. module: sale_validity +#: field:sale.order,date_validity:0 +msgid Valid Until +msgstr + +#. module: sale_validity +#: model:ir.model,name:sale_validity.model_res_company +msgid Companies +msgstr + +#. module: sale_validity +#: field:res.company,default_sale_order_validity_days:0 +msgid Default Validity of Sale Orders (in days) +msgstr + +#. module: sale_validity +#: help:res.company,default_sale_order_validity_days:0 +msgid By default, the validity date of sale orders will be the date of the sale order plus the number of days defined in this field. If the value of this field is 0, the sale orders will not have a validity date by default. +msgstr + +#. module: sale_validity +#: model:ir.model,name:sale_validity.model_sale_order +msgid Sales Order +msgstr + +#. module: sale_validity +#: sql_constraint:res.company:0 +msgid The value of the field 'Default Validity Duration of Sale Orders' must be positive or 0. +msgstr + === modified file 'sale_validity/model/__init__.py' --- sale_validity/model/__init__.py 2013-11-08 08:50:45 + +++ sale_validity/model/__init__.py 2014-01-15 12:05:13 + @@ -18,4 +18,5 @@ # ## +from . import company from . import sale_order === added file 'sale_validity/model/company.py' --- sale_validity/model/company.py 1970-01-01 00:00:00 + +++ sale_validity/model/company.py 2014-01-15 12:05:13 + @@ -0,0 +1,42 @@ +# -*- coding: utf-8 -*- +## +# +#Copyright (C) 2014 Akretion (http://www.akretion.com) +#@author Alexis de Lattre alexis.delat...@akretion.com +# +#This program is free software: you can redistribute it and/or modify +#it under the terms of the GNU Affero General Public License as +#published by the Free Software Foundation, either version 3 of the +#License, or (at your option) any later version. +# +#This program is distributed in the hope that it will be useful, +#but WITHOUT ANY WARRANTY; without even the implied warranty of +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +#GNU Affero General Public License for more details. +# +#You should have received a copy of the GNU Affero General Public License +#along with this program. If not, see http://www.gnu.org/licenses/. +# +## + +from openerp.osv import
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/update-7.0-account_move_line_report_xls into lp:account-financial-report
Review: Approve code review LGTM. Thanks Luc for this new MP. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/update-7.0-account_move_line_report_xls/+merge/200990 Your team Account Report Core Editors is requested to review the proposed merge of lp:~luc-demeyer/account-financial-report/update-7.0-account_move_line_report_xls into lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/purchase-wkfl/70-add-purchase_fiscal_position_update into lp:purchase-wkfl
Alexis de Lattre has proposed merging
lp:~akretion-team/purchase-wkfl/70-add-purchase_fiscal_position_update into
lp:purchase-wkfl.
Requested reviews:
Purchase Core Editors (purchase-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/purchase-wkfl/70-add-purchase_fiscal_position_update/+merge/201115
Add purchase_fiscal_position_update module. Extract from the description :
With this module, when a user changes the fiscal position of a purchase order,
the taxes on all the purchase order lines which have a product are
automatically updated. The purchase order lines without a product are not
updated and a warning is displayed to the user in this case.
The module is the equivalent of :
- the module invoice_fiscal_position_update, which is under review here :
https://code.launchpad.net/~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update/+merge/200358
- the module sale_fiscal_position_update, which is under review here :
https://code.launchpad.net/~akretion-team/sale-wkfl/70-add-sale_fiscal_position_update/+merge/200611
So, with this MP, the family of fiscal_position_update is complete : sale +
purchase + invoice !
--
https://code.launchpad.net/~akretion-team/purchase-wkfl/70-add-purchase_fiscal_position_update/+merge/201115
Your team Purchase Core Editors is requested to review the proposed merge of
lp:~akretion-team/purchase-wkfl/70-add-purchase_fiscal_position_update into
lp:purchase-wkfl.
=== added directory 'purchase_fiscal_position_update'
=== added file 'purchase_fiscal_position_update/__init__.py'
--- purchase_fiscal_position_update/__init__.py 1970-01-01 00:00:00 +
+++ purchase_fiscal_position_update/__init__.py 2014-01-09 22:36:59 +
@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Purchase Fiscal Position Update module for OpenERP
+#Copyright (C) 2011-2014 Julius Network Solutions SARL cont...@julius.fr
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import purchase
=== added file 'purchase_fiscal_position_update/__openerp__.py'
--- purchase_fiscal_position_update/__openerp__.py 1970-01-01 00:00:00 +
+++ purchase_fiscal_position_update/__openerp__.py 2014-01-09 22:36:59 +
@@ -0,0 +1,40 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Purchase Fiscal Position Update module for OpenERP
+#Copyright (C) 2011-2014 Julius Network Solutions SARL cont...@julius.fr
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'Purchase Fiscal Position Update',
+'version': '1.0',
+'category': 'Purchase Management',
+'license': 'AGPL-3',
+'summary': 'Changing the fiscal position of a purchase order will auto-update purchase order lines',
+'description':
+Purchase Fiscal Position Update
+===
+
+With this module, when a user changes the fiscal position of a purchase order, the taxes on all the purchase order lines which have a product are automatically updated. The purchase order lines without a product are not updated and a warning is displayed to the user in this case.
+,
+'author': 'Julius Network Solutions, Akretion',
+'depends': ['purchase'],
+'data': ['purchase_view.xml'],
+'installable': True,
+'active': False,
+}
=== added directory
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report
@Alexandre : Thanks for the merge... but it doesn't contain the new list of default fields we decided above in the function _report_xls_fields() in account_move_line.py. Could you update it ? -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report
@Luc I approve your proposal for the new list of default fields ! -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update into lp:account-invoicing
Just a quick note about what I discovered while trying to backport the module to OpenERP 6.1 : the ORM function resolve_2many_commands exists in OpenERP 6.1 under a different name : resolve_o2m_commands_to_record_dicts But, unfortunately, when trying to use it, I often get : File /home/alexis/new_boite/dev/server-61/openerp/osv/orm.py, line 4975, in resolve_o2m_commands_to_record_dicts Only CREATE, UPDATE and LINK_TO commands are supported in resolver When you look at the code of this function in openerp 6.1 in openerp/osv/orm.py, you see that it only handles commands 0, 1 and 4 ; whereas the same code in OpenERP 7.0 handles 0, 1, 2, 3, 4, 5 and 6. During my tests, I got a command 6, so I hit the assert and it crashes. So, if you don't have a better idea, a backport to OpenERP 6.1 of this module would probably use the update button approach. -- https://code.launchpad.net/~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update/+merge/200358 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/70-add-sale_fiscal_position_update into lp:sale-wkfl
Alexis de Lattre has proposed merging
lp:~akretion-team/sale-wkfl/70-add-sale_fiscal_position_update into
lp:sale-wkfl.
Requested reviews:
Sale Core Editors (sale-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/sale-wkfl/70-add-sale_fiscal_position_update/+merge/200611
Add sale_fiscal_position_update module. Extract from the description :
With this module, when a user changes the fiscal position of a sale order, the
taxes on all the sale order lines which have a product are automatically
updated. The sale order lines without a product are not updated and a warning
is displayed to the user in this case.
The module is the equivalent of the module invoice_fiscal_position_update,
which is under final review here :
https://code.launchpad.net/~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update/+merge/200358
--
https://code.launchpad.net/~akretion-team/sale-wkfl/70-add-sale_fiscal_position_update/+merge/200611
Your team Sale Core Editors is requested to review the proposed merge of
lp:~akretion-team/sale-wkfl/70-add-sale_fiscal_position_update into
lp:sale-wkfl.
=== added directory 'sale_fiscal_position_update'
=== added file 'sale_fiscal_position_update/__init__.py'
--- sale_fiscal_position_update/__init__.py 1970-01-01 00:00:00 +
+++ sale_fiscal_position_update/__init__.py 2014-01-06 23:32:02 +
@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Sale Fiscal Position Update module for OpenERP
+#Copyright (C) 2011-2014 Julius Network Solutions SARL cont...@julius.fr
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import sale
=== added file 'sale_fiscal_position_update/__openerp__.py'
--- sale_fiscal_position_update/__openerp__.py 1970-01-01 00:00:00 +
+++ sale_fiscal_position_update/__openerp__.py 2014-01-06 23:32:02 +
@@ -0,0 +1,40 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Sale Fiscal Position Update module for OpenERP
+#Copyright (C) 2011-2014 Julius Network Solutions SARL cont...@julius.fr
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'Sale Fiscal Position Update',
+'version': '1.0',
+'category': 'Sales Management',
+'license': 'AGPL-3',
+'summary': 'Changing the fiscal position of a sale order will auto-update sale order lines',
+'description':
+Sale Fiscal Position Update
+===
+
+With this module, when a user changes the fiscal position of a sale order, the taxes on all the sale order lines which have a product are automatically updated. The sale order lines without a product are not updated and a warning is displayed to the user in this case.
+,
+'author': 'Julius Network Solutions, Akretion',
+'depends': ['sale'],
+'data': ['sale_view.xml'],
+'installable': True,
+'active': False,
+}
=== added directory 'sale_fiscal_position_update/i18n'
=== added file 'sale_fiscal_position_update/i18n/fr.po'
--- sale_fiscal_position_update/i18n/fr.po 1970-01-01 00:00:00 +
+++ sale_fiscal_position_update/i18n/fr.po 2014-01-06 23:32:02 +
@@ -0,0 +1,51 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+# * sale_fiscal_position_update
+#
+msgid
+msgstr
+Project-Id-Version
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update into lp:account-invoicing
@Graeme I agree with your remarks about the fact that a fiscal position is not dependant on a product. But, as you say, implementing it without relying on the product is not really possible, because if you already had a fiscal position and you change to another fiscal position, that you can't use the mapping of the new fiscal position to update the taxes and accounts. One solution would be to raise an error message, which would block the executing and prevent all lines from being updated. The second solution would be to display a warning, but AFAIK, it is not possible on a function executed by a button unfortunately. @Ronald About the on_change vs the update button : I don't have a strong opinion on this. The original author of the module (Mathieu Vatel) implemented it via an update button and I kept this approach. If there is a consensus to use an on_change, then I'm OK to use an on_change. -- https://code.launchpad.net/~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update/+merge/200358 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/70-reversal-fix-improve into lp:account-financial-tools
Alexis de Lattre has proposed merging
lp:~akretion-team/account-financial-tools/70-reversal-fix-improve into
lp:account-financial-tools.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/account-financial-tools/70-reversal-fix-improve/+merge/200378
Avoid a crash when the next period doesn't exist (for example : you are in
December 2013 and FY 2014 is not created yet).
Add prefer_normal_period in period selection.
--
https://code.launchpad.net/~akretion-team/account-financial-tools/70-reversal-fix-improve/+merge/200378
Your team Account Core Editors is requested to review the proposed merge of
lp:~akretion-team/account-financial-tools/70-reversal-fix-improve into
lp:account-financial-tools.
=== modified file 'account_reversal/account_reversal.py'
--- account_reversal/account_reversal.py 2013-01-14 12:19:55 +
+++ account_reversal/account_reversal.py 2014-01-03 09:23:55 +
@@ -65,6 +65,7 @@
period_obj = self.pool.get('account.period')
period_ctx = context.copy()
period_ctx['company_id'] = move.company_id.id
+period_ctx['account_period_prefer_normal'] = True
if not reversal_period_id:
reversal_period_id = period_obj.find(
=== modified file 'account_reversal/wizard/account_move_reverse.py'
--- account_reversal/wizard/account_move_reverse.py 2013-01-04 11:11:41 +
+++ account_reversal/wizard/account_move_reverse.py 2014-01-03 09:23:55 +
@@ -62,15 +62,23 @@
}
def _next_period_first_date(self, cr, uid, context=None):
+if context is None:
+context = {}
+res = False
+period_ctx = context.copy()
+period_ctx['account_period_prefer_normal'] = True
period_obj = self.pool.get('account.period')
-current_period_id = period_obj.find(cr, uid, context=context)[0]
-current_period = period_obj.browse(
-cr, uid, current_period_id, context=context)
-next_period_id = period_obj.next(
-cr, uid, current_period, 1, context=context)
-next_period = period_obj.browse(
-cr, uid, next_period_id, context=context)
-return next_period.date_start
+today_period_id = period_obj.find(cr, uid, context=period_ctx)
+if today_period_id:
+today_period = period_obj.browse(
+cr, uid, today_period_id[0], context=context)
+next_period_id = period_obj.next(
+cr, uid, today_period, 1, context=context)
+if next_period_id:
+next_period = period_obj.browse(
+cr, uid, next_period_id, context=context)
+res = next_period.date_start
+return res
_defaults = {
'date': _next_period_first_date,
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update into lp:account-invoicing
Thanks for all these comments ! I have started to implement the on_change approch, cf the code in this branch : lp:~akretion-team/account-invoicing/70-invoice_fiscal_position_update-onchange But, during the implementation, I have been confronted to the following problem : In the code of the fiscal_position_change function, I do a write on all the invoice lines to update the taxes and account. But this is a problem in the following scenario : 1) edit an invoice with fiscal position A 2) add an invoice line with product HDD1 3) change the fiscal position to B 4) click on save = the invoice line with product HDD1 will not be updated, because it is not created in the DB at the time of the execution of the on_change. The solution for this is to update the taxes and account via the 'value' key of the dict that is returned by the on_change, but I don't know if it's possible in OpenERP 7 to update the field of the invoice_lines (one2many) via an on_change of a field that belong to the invoice. If this is possible in OpenERP 7, please explain me how to implement it and I will do it. If this is not possible in OpenERP 7, I think it gives a significant advantage to the button approach. -- https://code.launchpad.net/~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update/+merge/200358 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update into lp:account-invoicing
@Graeme Thanks for pointing me to resolve_2many_commands. I managed to make the on_change work in the interface (the tax and account fields are properly updated), but I get a crash when I save... so it's not usable for the moment. The current code is here : https://code.launchpad.net/~akretion-team/account-invoicing/70-invoice_fiscal_position_update-onchange -- https://code.launchpad.net/~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update/+merge/200358 Your team Account Core Editors is subscribed to branch lp:account-invoicing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update into lp:account-invoicing
Alexis de Lattre has proposed merging
lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update into
lp:account-invoicing.
Requested reviews:
Account Core Editors (account-core-editors)
For more details, see:
https://code.launchpad.net/~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update/+merge/200358
Add the module invoice_fiscal_position_update. Here is the description :
When the invoice is in draft state, you can change the fiscal position and
click on a button (update) next to the fiscal position to update the taxes
and the accounts on all the invoice lines.
--
https://code.launchpad.net/~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update/+merge/200358
Your team Account Core Editors is requested to review the proposed merge of
lp:~akretion-team/account-invoicing/70-add-invoice_fiscal_position_update into
lp:account-invoicing.
=== added directory 'invoice_fiscal_position_update'
=== added file 'invoice_fiscal_position_update/__init__.py'
--- invoice_fiscal_position_update/__init__.py 1970-01-01 00:00:00 +
+++ invoice_fiscal_position_update/__init__.py 2014-01-02 23:23:00 +
@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Invoice Fiscal Position Update module for OpenERP
+#Copyright (C) 2011-2014 Julius Network Solutions SARL cont...@julius.fr
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+from . import account_invoice
=== added file 'invoice_fiscal_position_update/__openerp__.py'
--- invoice_fiscal_position_update/__openerp__.py 1970-01-01 00:00:00 +
+++ invoice_fiscal_position_update/__openerp__.py 2014-01-02 23:23:00 +
@@ -0,0 +1,42 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Invoice Fiscal Position Update module for OpenERP
+#Copyright (C) 2011-2014 Julius Network Solutions SARL cont...@julius.fr
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program. If not, see http://www.gnu.org/licenses/.
+#
+##
+
+{
+'name': 'Invoice Fiscal Position Update',
+'version': '1.0',
+'category': 'Accounting Finance',
+'license': 'AGPL-3',
+'summary': 'Update the fiscal position of an invoice in one click',
+'description':
+Invoice Fiscal Position Update
+==
+
+When the invoice is in draft state, you can change the fiscal position and click on a button *(update)* next to the fiscal position to update the taxes and the accounts on all the invoice lines.
+,
+'author': 'Julius Network Solutions',
+'website': 'http://www.julius.fr/',
+'depends': ['account'],
+'data': ['account_invoice_view.xml'],
+'images': ['images/invoice_fiscal_position_update.jpg'],
+'installable': True,
+'active': False,
+}
=== added file 'invoice_fiscal_position_update/account_invoice.py'
--- invoice_fiscal_position_update/account_invoice.py 1970-01-01 00:00:00 +
+++ invoice_fiscal_position_update/account_invoice.py 2014-01-02 23:23:00 +
@@ -0,0 +1,70 @@
+# -*- coding: utf-8 -*-
+#
+#
+#Invoice Fiscal Position Update module for OpenERP
+#Copyright (C) 2011-2014 Julius Network Solutions SARL cont...@julius.fr
+#Copyright (C) 2014 Akretion (http://www.akretion.com)
+#@author Mathieu Vatel mathieu _at_ julius.fr
+#@author
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-cutoff-modules into lp:account-closing
@Yannick All your remarks are now integrated. -- https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992 Your team Account Core Editors is subscribed to branch lp:account-closing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls into lp:account-financial-report
About the crash that I mentionned 2 comments above, the reason is quite obvious when you look at the code in report/move_line_list_xls.py in the function generate_xls_report() : the variable debit_pos is declared and initialized in a block of code under : if 'balance' in wanted_list': and then it is used in a block of code which is executed in all cases. -- https://code.launchpad.net/~luc-demeyer/account-financial-report/7.0-account_move_line_report_xls/+merge/192250 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/web-context-tunnel into lp:server-env-tools
Review: Approve This is a great workaround for a very very annoying problem of OpenERP : 2 modules inherit the same on_change to add arguments and it makes the 2 modules incompatible. Almost all experienced OpenERP developers were already confronted to this headache. This seems a clever and lightweight solution. I am not a JS developer so I can't give my opinion on the code itself, but it approve this from an OpenERP module developer point of view. -- https://code.launchpad.net/~akretion-team/server-env-tools/web-context-tunnel/+merge/198599 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/70-always-check-date into lp:account-financial-tools
@Nhomar : Could you explain exactly why you disapprove this merge proposal ? I don't understand your answer. -- https://code.launchpad.net/~akretion-team/account-financial-tools/70-always-check-date/+merge/196398 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into lp:account-invoice-report
Review: Needs Information Dear Lorenzo, Thank you for this very interesting module. I was looking for such a module for a new development I want to do to replace my fleet_maintenance module (lp:fleet-maintenance). Here are my remarks, from the most important to the least important : 1) the dependancy on invoice_webkit is not a good idea. I would really like to use this module, but I use aeroo reports. That would require splitting the module in 2 : - one generic module account_invoice_prodlots that adds the field prod_lot_ids on the invoice lines, - a second module account_invoice_prodlots_webkit with a dependancy on invoice_webkit which writes on formatted_note and adds the button Load Lines Lots. I think it's important to keep modules that bring additionnal functionalities independant from the reporting engine as much as we can. 2) for the field 'prod_lot_ids' in the invoice lines, I would prefer to have a fields.many2many instead of a field.function. Not only for performance reasons, but also for flexibility reasons. For example, as you will see in my specifications on the replacement of the fleet_maintenance module (cf https://docs.google.com/document/d/1EH1lnvkD3-aZjOTQ2jv_fTon1ZE0MzMm7hmmMgs9dJg/edit?usp=sharing), I want to have a many2many link from the invoice lines to the production lots for the maintenance service lines, in order to know on which prodlots the maintenance service apply. For that, the fields.function 'prod_lot_ids' needs to be converted to a fields.many2many. This many2many field would have to be set: - when creating the invoice from the picking, by an inherit of the function _prepare_invoice_line() from stock/stock.py - when creating the invoice from the sale order, by an inherit of the function _prepare_order_line_invoice_line() from sale/sale.py If you think it's not a good idea and you want to keep the prod_lot_ids fields as field.function, then I will have to create another field 'maintenance_prodlot_ids' in the invoice lines that only applies for the maintenance service lines. 3) on the invoice line, you add a field 'displayed_lot_id' but you don't use it anywhere. What is this field for ? 4) on the stock moves, the many2one to the prodlot is called 'prodlot_id', so I would suggest to name the field 'prodlot_ids' instead of 'prod_lot_ids' on the invoice lines -- https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into lp:account-invoice-report
@Lorenzo I forgot to say that I am ready to do the work to have the changes that I suggest if you agree with the changes. I could do that in another branch and then propose to merge it. -- https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-invoice-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/70-always-check-date into lp:account-financial-tools
@Nhomar : I don't understand your answer. My collegues at Akretion France don't understand it either. Could you explain it again ? @Sylvain : Of course, I could use the mass edit module to set all journals to allow_date=True. But it find your suggestion too complicated for such a simple need. I want it to be as simple as possible for the user. I want that, once the module is installed, the user has the warranty that all his journals have allow_date=True and it will stays like this forever. -- https://code.launchpad.net/~akretion-team/account-financial-tools/70-always-check-date/+merge/196398 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~luc-demeyer/account-financial-tools/7.0-account_pain into lp:account-financial-tools
Here is result of the Akretion-Noviat code sprint on SEPA credit transfer to add the additionnal features of the module account_pain inside the module account_banking_sepa_credit_transfer : https://code.launchpad.net/~akretion-team/banking-addons/70-akretion-noviat-sepa-sprint But before I propose this branch for a merge on lp:banking-addons, I will need to have the following MP approved : https://code.launchpad.net/~akretion-team/banking-addons/70-sepa-credit-transfer-update/+merge/194948 -- https://code.launchpad.net/~luc-demeyer/account-financial-tools/7.0-account_pain/+merge/192256 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-tools/70-fiscal-position-check-vat into lp:account-financial-tools
My branch only contains my module, it's not a full branch. So a bzr replay should work, but a merge doesn't work. If it's a problem, I will prepare a full branch of account-financial-tools with my module inside, but i'm not sure if I will be able to push it in the same branch (if I can't, it would be a new branch and a new MP). -- https://code.launchpad.net/~akretion-team/account-financial-tools/70-fiscal-position-check-vat/+merge/186515 Your team OpenERP Community Reviewer/Maintainer is subscribed to branch lp:account-financial-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-closing/70-cutoff-modules into lp:account-closing
@Lorenzo You're welcome ! I am happy that you like my modules. @Guewen I replaced the raise by an assert -- https://code.launchpad.net/~akretion-team/account-closing/70-cutoff-modules/+merge/185992 Your team Account Core Editors is subscribed to branch lp:account-closing. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
