Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into lp:carriers-deliveries

[Lorenzo Battistini - Agile BG]

Review: Approve

Thanks to openerp-conventions
https://github.com/nbessi/openerp-conventions
I see
delivery_optional_invoice_line/__openerp__.py:43:5: O600 Warning unknown 
Manifest key ('active')

Apart from this, LGTM
-- 
https://code.launchpad.net/~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7/+merge/213867
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of 
lp:~agilebg/carriers-deliveries/adding_delivery_optional_invoice_line_7 into 
lp:carriers-deliveries.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7 into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

Review: Approve code review


-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_stock_invoice_picking_incoterm_7/+merge/213987
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~onnis-roberto/web-addons/web-addons into lp:web-addons

[Lorenzo Battistini - Agile BG]

Review: Approve code review


-- 
https://code.launchpad.net/~onnis-roberto/web-addons/web-addons/+merge/214906
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

[Lorenzo Battistini - Agile BG]

Review: Needs Fixing

Nico,

line 74,76: I think you should use 'lot_icecream_0' and 'lot_icecream_1'

line 91: you are writing 'prodlot_id' field with another lot, but I think it's 
unnecessary, as lots are already assigned by 'stock.move.split' wizard.

line 115: the test is checking if the invoice lines are 2, but the bug said
"Now the 2 different serial number will be repeat for each invoice line, while 
each line must have only its serial"
So, the test should check if every invoice line has got only one lot

line 112: 'ac' is unnecessary

Thanks
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico into lp:account-invoice-report

[Lorenzo Battistini - Agile BG]

Review: Approve code review

just remove "name = ''" at line 110

Thanks!
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-bug-1284049-hurrinico/+merge/208753
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hotel-management-system/7.0-bug-1308639-hurrinico into lp:hotel-management-system/7.0

[Lorenzo Battistini - Agile BG]

Review: Abstain

I suspect the modules contained in lp:hotel-management-system/7.0 are not ready 
for v7

I would test the modules contained in 
lp:~serpentcs/hotel-management-system/hotel-7.0 and possibly merge them into 
lp:hotel-management-system/7.0
-- 
https://code.launchpad.net/~agilebg/hotel-management-system/7.0-bug-1308639-hurrinico/+merge/216308
Your team Hotel Editors is requested to review the proposed merge of 
lp:~agilebg/hotel-management-system/7.0-bug-1308639-hurrinico into 
lp:hotel-management-system/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~openerp-community/hotel-management-system/porting-to-7-branch into lp:hotel-management-system/7.0

[Lorenzo Battistini - Agile BG]

The proposal to merge 
lp:~openerp-community/hotel-management-system/porting-to-7-branch into 
lp:hotel-management-system/7.0 has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~openerp-community/hotel-management-system/porting-to-7-branch/+merge/216465
-- 
https://code.launchpad.net/~openerp-community/hotel-management-system/porting-to-7-branch/+merge/216465
Your team Hotel Editors is requested to review the proposed merge of 
lp:~openerp-community/hotel-management-system/porting-to-7-branch into 
lp:hotel-management-system/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools

[Lorenzo Battistini - Agile BG]

Review: Needs Information

Hello Stéphane,

why not using '_constraints' member instead of overriding create and write 
methods?

Is there any technical reason to avoid YAML tests?

Thanks!
-- 
https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_partner_required-sbi/+merge/216442
Your team Account Core Editors is requested to review the proposed merge of 
lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl

[Lorenzo Battistini - Agile BG]

Review: Needs Information

Thanks Alex,
why did you remove the 'images' and 'sequence' items?
-- 
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into lp:account-financial-tools

[Lorenzo Battistini - Agile BG]

Review: Approve code review

Ok :-)
-- 
https://code.launchpad.net/~acsone-openerp/account-financial-tools/account_partner_required-sbi/+merge/216442
Your team Account Core Editors is requested to review the proposed merge of 
lp:~acsone-openerp/account-financial-tools/account_partner_required-sbi into 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/sale-wkfl/70-add-sale_order_revision into lp:sale-wkfl

[Lorenzo Battistini - Agile BG]

Review: Approve code review

Thanks
-- 
https://code.launchpad.net/~akretion-team/sale-wkfl/70-add-sale_order_revision/+merge/202735
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~akretion-team/sale-wkfl/70-add-sale_order_revision into lp:sale-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru into lp:purchase-wkfl

[Lorenzo Battistini - Agile BG]

Review: Approve code review


-- 
https://code.launchpad.net/~agilebg/purchase-wkfl/7.0-bug-1312024-tafaru/+merge/217061
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:purchase-wkfl

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:purchase-wkfl.

Requested reviews:
  Purchase Core Editors (purchase-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/219017

adding funciotnalities from product_search_reference.
Now it's possible to search products everywhere by supplier code
-- 
https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/219017
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:purchase-wkfl.
=== modified file 'product_by_supplier/product.py'
--- product_by_supplier/product.py	2013-11-12 01:44:31 +
+++ product_by_supplier/product.py	2014-05-09 16:21:02 +
@@ -2,6 +2,7 @@
 ##
 #
 #OpenERP, Open Source Management Solution
+#Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>).
 #Copyright (c) 2010-2013 Elico Corp. All Rights Reserved.
 #Author: Yannick Gouin 
 #
@@ -53,4 +54,46 @@
  ),
 }
 
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
+
+class product_product(orm.Model):
+_inherit = 'product.product'
+
+def _partner_ref2(self, cr, user, ids, name, arg, context=None):
+res = {}
+for product in self.browse(cr, user, ids, context=context):
+res[product.id] = '\n'.join(
+[x.product_code for x in product.seller_ids if x.product_code]
+) or ''
+return res
+
+def _partner_ref2_search(self, cr, user, obj, name, args, context={}):
+supplierinfo_obj = self.pool.get('product.supplierinfo')
+args = args[:]
+i = 0
+while i < len(args):
+args[i] = ('product_code', args[i][1], args[i][2])
+i += 1
+supplierinfo_ids = supplierinfo_obj.search(cr, user, args)
+product_ids = [x.product_id.id for x in supplierinfo_obj.browse(
+cr, user,
+supplierinfo_ids) if x.product_id]
+return [('id', 'in', product_ids)]
+
+_columns = {
+'partner_ref2': fields.function(
+_partner_ref2, method=True,
+type='char', string='Supplier codes',
+fnct_search=_partner_ref2_search),
+}
+
+def name_search(
+self, cr, user, name='', args=None, operator='ilike',
+context=None, limit=80):
+ids = self.search(
+cr, user, [('partner_ref2', '=', name)] + args,
+limit=limit, context=context)
+if ids:
+return self.name_get(cr, user, ids, context=context)
+return super(product_product, self).name_search(
+cr, user, name=name, args=args,
+operator=operator, context=context, limit=limit)

=== modified file 'product_by_supplier/product_view.xml'
--- product_by_supplier/product_view.xml	2014-02-06 19:59:12 +
+++ product_by_supplier/product_view.xml	2014-05-09 16:21:02 +
@@ -1,6 +1,9 @@
 
 
 
+
+
+
 
 product.supplierinfo.search
 product.supplierinfo
@@ -71,5 +74,30 @@
 sequence="15"
 action="action_product_supplier_info"
 parent="purchase.menu_procurement_management_product"/>
+
+
+
+
+product.product.tree.inherit
+product.product
+
+
+
+
+
+
+
+
+
+product_search_form_view
+product.product
+
+
+
+
+
+
+
+
 
 

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date into lp:purchase-wkfl

[Lorenzo Battistini - Agile BG]

Review: Approve code review


-- 
https://code.launchpad.net/~numerigraphe-team/purchase-wkfl/7.0-add-purchase_delivery_split_date/+merge/211374
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-invoicing/account-analytic-required-vre into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

Review: Needs Fixing

Thanks Vincent,

some style fixes:

account_invoice_analytic_required/__init__.py:3:2: W291 trailing whitespace
account_invoice_analytic_required/__init__.py:19:75: W291 trailing whitespace
account_invoice_analytic_required/__init__.py:23:14: E271 multiple spaces after 
keyword
account_invoice_analytic_required/__openerp__.py:3:2: W291 trailing whitespace
account_invoice_analytic_required/__openerp__.py:19:75: W291 trailing whitespace
account_invoice_analytic_required/__openerp__.py:23:1: O603 Manifest "license" 
key is missing
account_invoice_analytic_required/__openerp__.py:24:11: E203 whitespace before 
':'
account_invoice_analytic_required/__openerp__.py:25:14: E203 whitespace before 
':'
account_invoice_analytic_required/__openerp__.py:26:15: E203 whitespace before 
':'
account_invoice_analytic_required/__openerp__.py:28:13: E203 whitespace before 
':'
account_invoice_analytic_required/__openerp__.py:29:14: E203 whitespace before 
':'
account_invoice_analytic_required/__openerp__.py:30:14: E203 whitespace before 
':'
account_invoice_analytic_required/__openerp__.py:32:11: E203 whitespace before 
':'
account_invoice_analytic_required/__openerp__.py:33:11: E203 whitespace before 
':'
account_invoice_analytic_required/__openerp__.py:34:11: E203 whitespace before 
':'
account_invoice_analytic_required/__openerp__.py:35:18: E203 whitespace before 
':'
account_invoice_analytic_required/__openerp__.py:36:19: E203 whitespace before 
':'
account_invoice_analytic_required/__openerp__.py:37:18: E203 whitespace before 
':'
account_invoice_analytic_required/account_invoice_analytic_required.py:23:1: 
O603 Manifest "license" key is missing
account_invoice_analytic_required/account_invoice_analytic_required.py:25:1: 
E302 expected 2 blank lines, found 1
account_invoice_analytic_required/account_invoice_analytic_required.py:27:13: 
E225 missing whitespace around operator

account_invoice_analytic_required/__openerp__.py:24:80: E501 line too long (84 
> 79 characters)
account_invoice_analytic_required/__openerp__.py:27:80: E501 line too long (94 
> 79 characters)
account_invoice_analytic_required/account_invoice_analytic_required.py:30:80: 
E501 line too long (110 > 79 characters)
-- 
https://code.launchpad.net/~camptocamp/account-invoicing/account-analytic-required-vre/+merge/218974
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/purchase-wkfl/pallet-delivery-missing-security-access into lp:purchase-wkfl

[Lorenzo Battistini - Agile BG]

Review: Needs Fixing

line 35: missing description
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/purchase-wkfl/pallet-delivery-missing-security-access/+merge/218508
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-consolidation/7.0-bug-1296740-elbati into lp:account-consolidation/7.0

[Lorenzo Battistini - Agile BG]

Dear Yannick,

I don't think this MP would break compatibility with 
account_financial_report_webkit.
I installed account_financial_report_webkit and account_parralel_currency and I 
can use them without problems.

It just doesn't copy the centralized field to the parallel accounts. For that, 
a link module can be surely done. But I think it has less priority than fixing 
the linked bug.
-- 
https://code.launchpad.net/~agilebg/account-consolidation/7.0-bug-1296740-elbati/+merge/212487
Your team Account Core Editors is subscribed to branch 
lp:account-consolidation/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl

[Lorenzo Battistini - Agile BG]

Review: Needs Fixing

Thanks Pedro,

line 349: I think discount should not be < -100 too
line 399: amount_untaxed and following fields are present 2 times

some PEP8:

purchase_discount/__openerp__.py:21:1: O603 Manifest "license" key is missing
purchase_discount/__openerp__.py:29:5: O600 Warning unknown Manifest key 
('contributors')
purchase_discount/__openerp__.py:43:5: O600 Warning unknown Manifest key 
('active')
purchase_discount/purchase_discount.py:21:1: O603 Manifest "license" key is 
missing
purchase_discount/purchase_discount.py:24:1: E302 expected 2 blank lines, found 
1
purchase_discount/purchase_discount.py:29:5: O600 Warning unknown Manifest key 
('contributors')
purchase_discount/purchase_discount.py:35:75: W291 trailing whitespace
purchase_discount/purchase_discount.py:43:5: O600 Warning unknown Manifest key 
('active')
purchase_discount/purchase_discount.py:43:75: W291 trailing whitespace
purchase_discount/purchase_discount.py:44:33: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:52:56: W291 trailing whitespace
purchase_discount/purchase_discount.py:86:29: E127 continuation line 
over-indented for visual indent
purchase_discount/purchase_discount.py:103:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:104:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:105:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:109:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:110:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:114:17: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:115:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:118:55: W291 trailing whitespace
purchase_discount/purchase_discount.py:119:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:119:28: E251 unexpected spaces around 
keyword / parameter equals
purchase_discount/purchase_discount.py:119:57: W291 trailing whitespace
purchase_discount/purchase_discount.py:120:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:121:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:123:60: W291 trailing whitespace
purchase_discount/purchase_discount.py:125:51: W291 trailing whitespace
purchase_discount/purchase_discount.py:126:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:126:28: E251 unexpected spaces around 
keyword / parameter equals
purchase_discount/purchase_discount.py:127:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:130:53: W291 trailing whitespace
purchase_discount/purchase_discount.py:131:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:131:28: E251 unexpected spaces around 
keyword / parameter equals
purchase_discount/purchase_discount.py:132:13: E128 continuation line 
under-indented for visual indent
purchase_discount/purchase_discount.py:134:28: E231 missing whitespace after ','
-- 
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl

[Lorenzo Battistini - Agile BG]

Ok, thanks.

What about the
amount_untaxed, amount_tax, amount_total
fields repeated 2 times?
-- 
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount into lp:purchase-wkfl

[Lorenzo Battistini - Agile BG]

Review: Approve code review


-- 
https://code.launchpad.net/~pedro.baeza/purchase-wkfl/7.0-purchase_discount/+merge/217030
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/openerp-manufacturing/adding_mrp_production_properties_7 into lp:openerp-manufacturing

[Lorenzo Battistini - Agile BG]

Review: Approve code review


-- 
https://code.launchpad.net/~agilebg/openerp-manufacturing/adding_mrp_production_properties_7/+merge/219559
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:openerp-manufacturing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_picking_line_description_7 into lp:stock-logistic-flows

[Lorenzo Battistini - Agile BG]

Review: Approve code review


-- 
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_picking_line_description_7/+merge/219800
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of lp:~agilebg/stock-logistic-flows/adding_picking_line_description_7 
into lp:stock-logistic-flows.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7 into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

Review: Approve code review


-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7/+merge/220289
Your team Account Core Editors is requested to review the proposed merge of 
lp:~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7 into 
lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:purchase-wkfl

[Lorenzo Battistini - Agile BG]

Hello Pedro,
just modified the name_search.
Thanks
-- 
https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/219017
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings into lp:hr-timesheet

[Lorenzo Battistini - Agile BG]

Hello Pedro and Yannick,
I made the changes.
Thanks
-- 
https://code.launchpad.net/~agilebg/hr-timesheet/imp_hr_attendance_analysis_roundings/+merge/206493
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:hr-timesheet.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

Ciao Nicola.
Just refactored the compute method and added tests with
https://code.launchpad.net/~agilebg/account-invoicing/add_module_account_payment_term_month_improvements/+merge/221124

-- 
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined into lp:hr-timesheet

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined 
into lp:hr-timesheet.

Requested reviews:
  HR Core Editors (hr-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined/+merge/221250

[FIX]
File 
"/home/elbati/workspace/openerp/progetti/agilebg/git/agilebg/parts/hr-timesheet-7.0/hr_attendance_analysis/wizard/print_calendar_report.py",
 line 160, in print_calendar
for calendar_attendance in reference.attendance_ids:
NameError: global name 'reference' is not defined
-- 
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-reference-is-not-defined/+merge/221250
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:hr-timesheet.
=== modified file 'hr_attendance_analysis/wizard/print_calendar_report.py'
--- hr_attendance_analysis/wizard/print_calendar_report.py	2013-11-19 13:32:00 +
+++ hr_attendance_analysis/wizard/print_calendar_report.py	2014-05-28 15:00:11 +
@@ -157,7 +157,7 @@
 if reference_calendar:
 if reference_calendar.attendance_ids:
 current_total_due = 0.0
-for calendar_attendance in reference.attendance_ids:
+for calendar_attendance in reference_calendar.attendance_ids:
 if ((
 not calendar_attendance.dayofweek
 or int(calendar_attendance.dayofweek) == current_date.weekday()

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into lp:hr-timesheet

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into 
lp:hr-timesheet.

Requested reviews:
  Alex Comba - Agile BG (tafaru)
  HR Core Editors (hr-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket/+merge/221278



[FIX] wrong opening bracket due to PEP8 restyle:

http://bazaar.launchpad.net/~hr-core-editors/hr-timesheet/7.0/revision/40.2.21

[ADD] button_dummy to force recomputing attendace

-- 
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket/+merge/221278
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:hr-timesheet.
=== modified file 'hr_attendance_analysis/hr_attendance.py'
--- hr_attendance_analysis/hr_attendance.py	2014-05-21 22:04:08 +
+++ hr_attendance_analysis/hr_attendance.py	2014-05-28 17:15:30 +
@@ -298,7 +298,7 @@
 attendance_start.hour + attendance_start.minute / 60.0
 + attendance_start.second / 60.0 / 60.0
 )
-if attendance_start_hour >= (
+if (attendance_start_hour >=
 calendar_attendance.hour_from and
 (attendance_start_hour - (calendar_attendance.hour_from +
 calendar_attendance.tolerance_to)) < 0.01
@@ -315,7 +315,7 @@
 + attendance_stop.second / 60.0 / 60.0
 )
 calendar_attendance = attendance_pool.browse(cr, uid, matched_schedule_ids[0], context=context)
-if attendance_stop_hour <= (
+if (attendance_stop_hour <=
 calendar_attendance.hour_to and
 (attendance_stop_hour - (calendar_attendance.hour_to -
 calendar_attendance.tolerance_from)) > -0.01
@@ -414,4 +414,8 @@
 store=_store_rules),
 }
 
-
+def button_dummy(self, cr, uid, ids, context=None):
+for att in self.browse(cr, uid, ids, context=context):
+#  Force recomputing stored values
+att.write({'action': att.action})
+return True

=== modified file 'hr_attendance_analysis/hr_attendance_view.xml'
--- hr_attendance_analysis/hr_attendance_view.xml	2013-03-05 11:28:38 +
+++ hr_attendance_analysis/hr_attendance_view.xml	2014-05-28 17:15:30 +
@@ -11,6 +11,7 @@
 
 
 
+
 
 
 

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into lp:hr-timesheet

[Lorenzo Battistini - Agile BG]

Hello Pedro,
what do you mean by store triggers?
I'm triggering recomputing because 'action' is in the store dictionary:
'hr.attendance': (_get_attendances, ['name', 'action', 'employee_id'], 20),

-- 
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket/+merge/221278
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:hr-timesheet.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into lp:hr-timesheet

[Lorenzo Battistini - Agile BG]

The proposal to merge 
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into 
lp:hr-timesheet has been updated.

Description changed to:

[FIX] wrong opening bracket due to PEP8 restyle:

http://bazaar.launchpad.net/~hr-core-editors/hr-timesheet/7.0/revision/40.2.21

[ADD] button_dummy to force recomputing attendace (on attendance form and 
company form)

For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket/+merge/221278
-- 
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket/+merge/221278
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:hr-timesheet.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into lp:hr-timesheet

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into 
lp:hr-timesheet.

Requested reviews:
  HR Core Editors (hr-core-editors)
  Alex Comba - Agile BG (tafaru)

For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone/+merge/221374

[FIX] hr_attendance_analysis
using correct timezone to print the sign in/out time
-- 
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone/+merge/221374
Your team HR Core Editors is requested to review the proposed merge of 
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into 
lp:hr-timesheet.
=== modified file 'hr_attendance_analysis/wizard/print_calendar_report.py'
--- hr_attendance_analysis/wizard/print_calendar_report.py	2013-11-19 13:32:00 +
+++ hr_attendance_analysis/wizard/print_calendar_report.py	2014-05-29 13:03:53 +
@@ -25,6 +25,7 @@
 from datetime import *
 import math
 import calendar
+import pytz
 
 class wizard_calendar_report(orm.TransientModel):
 
@@ -86,6 +87,8 @@
 employee_ids=form['employee_ids']
 delta = to_date - from_date
 max_number_of_attendances_per_day = 0
+active_tz = pytz.timezone(
+context.get("tz","UTC") if context else "UTC")
 
 for employee_id in employee_ids:
 employee_id = str(employee_id)
@@ -136,14 +139,24 @@
 count = 1
 for attendance in sorted(attendance_pool.browse(cr, uid, attendance_ids, context=context),
 key=lambda x: x['name']):
-days_by_employee[employee_id][str_current_date][
-'signin_'+str(count)] = attendance.name[11:16]
-days_by_employee[employee_id][str_current_date][
-'signout_'+str(count)] = attendance.end_datetime[11:16]
+
+attendance_start = datetime.strptime(
+attendance.name, '%Y-%m-%d %H:%M:%S'
+).replace(tzinfo=pytz.utc).astimezone(active_tz)
+attendance_end = datetime.strptime(
+attendance.end_datetime, '%Y-%m-%d %H:%M:%S'
+).replace(tzinfo=pytz.utc).astimezone(active_tz)
+
+days_by_employee[employee_id][str_current_date][
+'signin_'+str(count)] = '%s:%s' % (
+attendance_start.hour, attendance_start.minute)
+days_by_employee[employee_id][str_current_date][
+'signout_'+str(count)] = '%s:%s' % (
+attendance_end.hour, attendance_end.minute)
 count += 1
 if len(attendance_ids) > max_number_of_attendances_per_day:
 max_number_of_attendances_per_day = len(attendance_ids)
-
+
 days_by_employee[employee_id][str_current_date][
 'attendances'
 ] = current_total_attendances

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into lp:hr-timesheet

[Lorenzo Battistini - Agile BG]

You have been requested to review the proposed merge of 
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into 
lp:hr-timesheet.

For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone/+merge/221374

[FIX] hr_attendance_analysis
using correct timezone to print the sign in/out time

-- 
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone/+merge/221374
Your team HR Core Editors is requested to review the proposed merge of 
lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into 
lp:hr-timesheet.
=== modified file 'hr_attendance_analysis/wizard/print_calendar_report.py'
--- hr_attendance_analysis/wizard/print_calendar_report.py	2013-11-19 13:32:00 +
+++ hr_attendance_analysis/wizard/print_calendar_report.py	2014-05-29 13:03:53 +
@@ -25,6 +25,7 @@
 from datetime import *
 import math
 import calendar
+import pytz
 
 class wizard_calendar_report(orm.TransientModel):
 
@@ -86,6 +87,8 @@
 employee_ids=form['employee_ids']
 delta = to_date - from_date
 max_number_of_attendances_per_day = 0
+active_tz = pytz.timezone(
+context.get("tz","UTC") if context else "UTC")
 
 for employee_id in employee_ids:
 employee_id = str(employee_id)
@@ -136,14 +139,24 @@
 count = 1
 for attendance in sorted(attendance_pool.browse(cr, uid, attendance_ids, context=context),
 key=lambda x: x['name']):
-days_by_employee[employee_id][str_current_date][
-'signin_'+str(count)] = attendance.name[11:16]
-days_by_employee[employee_id][str_current_date][
-'signout_'+str(count)] = attendance.end_datetime[11:16]
+
+attendance_start = datetime.strptime(
+attendance.name, '%Y-%m-%d %H:%M:%S'
+).replace(tzinfo=pytz.utc).astimezone(active_tz)
+attendance_end = datetime.strptime(
+attendance.end_datetime, '%Y-%m-%d %H:%M:%S'
+).replace(tzinfo=pytz.utc).astimezone(active_tz)
+
+days_by_employee[employee_id][str_current_date][
+'signin_'+str(count)] = '%s:%s' % (
+attendance_start.hour, attendance_start.minute)
+days_by_employee[employee_id][str_current_date][
+'signout_'+str(count)] = '%s:%s' % (
+attendance_end.hour, attendance_end.minute)
 count += 1
 if len(attendance_ids) > max_number_of_attendances_per_day:
 max_number_of_attendances_per_day = len(attendance_ids)
-
+
 days_by_employee[employee_id][str_current_date][
 'attendances'
 ] = current_total_attendances

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone into lp:hr-timesheet

[Lorenzo Battistini - Agile BG]

Pedro, right, thanks.

I added the conversion to UTC while searching for attendances within the 
current_date.
This way, if selected current_date is 29/05/2014 (for a user in GMT+2), the 
sign in at 28/05/2014 22:12 UTC will be included in current_date.
So, every datetime is always expressed in the timezone of the user.
-- 
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-report-timezone/+merge/221374
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:hr-timesheet.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket into lp:hr-timesheet

[Lorenzo Battistini - Agile BG]

Ah, sure. It is so already.
See
http://bazaar.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket/view/69/hr_attendance_analysis/hr_attendance.py#L401

By writing the 'action' field without changing it, I'm forcing the 
'_get_attendance_duration' to be executed.
I'm doing this in order to allow the user to recompute values by clicking 
buttons on the interface, without changing the record (I don't know another 
way).

This is useful when the computation went wrong for some error and you want to 
explicit recompute the function fields without changing the data which the 
field depends on.

I improved the comment
-- 
https://code.launchpad.net/~agilebg/hr-timesheet/fix-hr_attendance_analysis-bracket/+merge/221278
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:hr-timesheet.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Openobject-italia-core-devs] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

On 06/03/2014 10:35 PM, Sergio Corato wrote:
> Hi Nicola, Lorenzo, Holger,
> what about delete "commercial_month" field and put this code instead?
> "if line.months != 0:"
>
> And in the view set the field "days" required if "months" if false and 
> viceversa:
>
> 
>
> and
>
> 
>  {'required':[('months','=',False)]}
> 

Ciao Sergio,

this means a user could fill both the 'months' and 'days' fields at the 
same time, despite they are mutually exclusive.


-- 
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Openobject-italia-core-devs] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

On 06/04/2014 08:18 AM, Sergio Corato wrote:
> In everyway, I overwritten the function (instead of overriden) and cover
> the case of 'days' too (for other purposes).
>
>
> 2014-06-04 8:12 GMT+02:00 Sergio Corato :
>
>> Ciao Lorenzo,
>> they aren't mutually exclusive, in this way only one of them is needed.
>> But it would be better to set field days invisibile if months are set.

I mean, if one field is used, the other one should not be used. If the 
user can fill both, it can create confusion.

What problem do you see with keeping the 'commercial_month' field? It 
seems useable to me.

-- 
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

Review: Approve code review


-- 
https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/sale-wkfl/product_procurement_type into lp:sale-wkfl

[Lorenzo Battistini - Agile BG]

Review: Needs Fixing code review

Hello Romain and Alexandre,

diff comments + some PEP8 remarks

product_procurement_type/product.py:27:1: E302 expected 2 blank lines, found 1
product_procurement_type/product.py:34:1: E302 expected 2 blank lines, found 1
product_procurement_type/product.py:99:13: E123 closing bracket does not match 
indentation of opening bracket's line

product_procurement_type/product.py:42:80: E501 line too long (95 > 79 
characters)

product_procurement_type_dropshipping/product.py:28:1: E302 expected 2 blank 
lines, found 0
product_procurement_type_dropshipping/product.py:33:1: E302 expected 2 blank 
lines, found 1
product_procurement_type_dropshipping/product.py:52:5: E303 too many blank 
lines (2)
product_procurement_type_dropshipping/product.py:111:17: E123 closing bracket 
does not match indentation of opening bracket's line
product_procurement_type_dropshipping/product.py:115:1: W391 blank line at end 
of file

product_procurement_type_dropshipping/product.py:25:80: E501 line too long (90 
> 79 characters)
product_procurement_type_dropshipping/product.py:46:80: E501 line too long (116 
> 79 characters)
product_procurement_type_dropshipping/product.py:64:80: E501 line too long (80 
> 79 characters)


Diff comments:

> === added directory 'product_procurement_type'
> === added file 'product_procurement_type/__init__.py'
> --- product_procurement_type/__init__.py  1970-01-01 00:00:00 +
> +++ product_procurement_type/__init__.py  2014-06-10 15:36:28 +
> @@ -0,0 +1,22 @@
> +# -*- coding: utf-8 -*-
> +##
> +#
> +#Author: Romain Deheele
> +#Copyright 2014 Camptocamp SA
> +#
> +#This program is free software: you can redistribute it and/or modify
> +#it under the terms of the GNU Affero General Public License as
> +#published by the Free Software Foundation, either version 3 of the
> +#License, or (at your option) any later version.
> +#
> +#This program is distributed in the hope that it will be useful,
> +#but WITHOUT ANY WARRANTY; without even the implied warranty of
> +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +#GNU Affero General Public License for more details.
> +#
> +#You should have received a copy of the GNU Affero General Public License
> +#along with this program.  If not, see .
> +#
> +##
> +
> +from . import product
> 
> === added file 'product_procurement_type/__openerp__.py'
> --- product_procurement_type/__openerp__.py   1970-01-01 00:00:00 +
> +++ product_procurement_type/__openerp__.py   2014-06-10 15:36:28 +
> @@ -0,0 +1,52 @@
> +# -*- coding: utf-8 -*-
> +##
> +#
> +#Author: Romain Deheele
> +#Copyright 2014 Camptocamp SA
> +#
> +#This program is free software: you can redistribute it and/or modify
> +#it under the terms of the GNU Affero General Public License as
> +#published by the Free Software Foundation, either version 3 of the
> +#License, or (at your option) any later version.
> +#
> +#This program is distributed in the hope that it will be useful,
> +#but WITHOUT ANY WARRANTY; without even the implied warranty of
> +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +#GNU Affero General Public License for more details.
> +#
> +#You should have received a copy of the GNU Affero General Public License
> +#along with this program.  If not, see .
> +#
> +##
> +
> +{
> +"name": "Product Procurement Types",
> +"version": "0.1",
> +"author": "Camptocamp",
> +"license": "AGPL-3",
> +"category": "Sales",
> +"description":
> +"""
> +Add a procurement type selection on products.
> +Let create products as :
> + - On stock, buy
> + - On stock, produce
> + - On order, buy
> + - On order, produce
> +
> +Choose "On stock, buy" changes automatically
> +procurement method as "make to stock" and supply method as "buy".
> +Choose "On demand, produce" changes automatically
> +procurement method as "make to order" and supply method as "produce".
> +
> +""",
> +"website": "http://camptocamp.com";,
> +"depends": ['sale',
> +'procurement',
> +'mrp'],
> +"data": ['product_view.xml'],
> +"demo": [],
> +"test": ['test/test_onchange_procurement_type.yml'],
> +"active": False,
> +"installable": True,
> +}
> 
> === added file 'product_procurement_type/product.py'
> --- product_procurement_type/product.py   1970-01-01 00:00:00 +
> +++ product_procurement_type/product.py   2014-06-10 15:36:28 +
> @@ -0,0 +1,139 @@
> +# -*- coding: ut

[Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into lp:purchase-report

[Lorenzo Battistini - Agile BG]

The proposal to merge 
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into 
lp:purchase-report has been updated.

Description changed to:

[FIX] purchase-report-7.0/purchase_order_webkit/__init__.py", line 31, in 

from . import purchase_order
ImportError: cannot import name purchase_order

For more details, see:
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531
-- 
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into 
lp:purchase-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into lp:purchase-report

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into 
lp:purchase-report.

Requested reviews:
  Purchase Core Editors (purchase-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531

[FIX] purchase-report-7.0/purchase_order_webkit/__init__.py", line 31, in 

from . import purchase_order
ImportError: cannot import name purchase_order
-- 
https://code.launchpad.net/~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order/+merge/223531
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~agilebg/purchase-report/7_fix_cannot_import_name_purchase_order into 
lp:purchase-report.
=== modified file 'purchase_order_webkit/__init__.py'
--- purchase_order_webkit/__init__.py	2014-04-16 07:35:50 +
+++ purchase_order_webkit/__init__.py	2014-06-18 10:02:23 +
@@ -28,4 +28,3 @@
 ##
 
 from . import report
-from . import purchase_order
\ No newline at end of file

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:account-invoice-report

[Lorenzo Battistini - Agile BG]

Hello Yannick and Vincent,

I renamed list_invoice_table to list_main_table.

As you saw, in order to fix bug 1277024 we had to remove the nested tables but 
this reintroduced the bug 1231329.
In order to fix bug 1231329, I moved the formatted_note within the 'nobreak' 
div containing line.name

See the result of the new layout at https://app.box.com/s/0i8ra35jlnqken7dvp7n

Thanks

-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/account-invoice-report/7_fix_1221570 into lp:account-invoice-report.

Requested reviews:
  Account Core Editors (account-core-editors)
Related bugs:
  Bug #1221570 in Account - Invoicing Reports: "[7.0] invoice_webkit overwrites 
report changes"
  https://bugs.launchpad.net/account-invoice-report/+bug/1221570

For more details, see:
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7_fix_1221570/+merge/223781
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-invoice-report.
=== modified file 'invoice_webkit/invoice_report.xml'
--- invoice_webkit/invoice_report.xml	2012-12-04 14:19:45 +
+++ invoice_webkit/invoice_report.xml	2014-06-19 15:57:15 +
@@ -12,7 +12,11 @@
 attachment="(object.state in ('open','paid')) and ('INV'+(object.number or '').replace('/',''))"
 attachment_use="1"
 multi="True"
-webkit_header="base_headers_webkit.base_reports_portrait_header"
 report_type="webkit"/>
 
+
+
+
+
+
 

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1315445 into lp:sale-reports

[Lorenzo Battistini - Agile BG]

The proposal to merge lp:~agilebg/sale-reports/7_fix_1315445 into 
lp:sale-reports has been updated.

Description changed to:

Same as 
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204

For more details, see:
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1315445/+merge/223795
-- 
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1315445/+merge/223795
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~agilebg/sale-reports/7_fix_1315445 into lp:sale-reports.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1315445 into lp:sale-reports

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/sale-reports/7_fix_1315445 into lp:sale-reports.

Requested reviews:
  Sale Core Editors (sale-core-editors)
Related bugs:
  Bug #1315445 in Sales - Reports: "[7.0] sale_order_webkit - 'Description' 
field overlaps the next one 'Qty' when it is very long"
  https://bugs.launchpad.net/sale-reports/+bug/1315445

For more details, see:
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1315445/+merge/223795

Same as 
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204
-- 
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1315445/+merge/223795
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~agilebg/sale-reports/7_fix_1315445 into lp:sale-reports.
=== modified file 'sale_order_webkit/report/sale_order.mako'
--- sale_order_webkit/report/sale_order.mako	2014-02-17 10:20:33 +
+++ sale_order_webkit/report/sale_order.mako	2014-06-19 17:05:51 +
@@ -8,92 +8,113 @@
 border:thin solid #E3E4EA;
 text-align:center;
 border-collapse: collapse;
-}
-table.list_main_table {
-margin-top: 20px;
-}
-.list_main_headers {
-padding: 0;
-}
-.list_main_headers th {
+margin-top: 15px;
+}
+.list_main_table th {
+background-color: #EE;
 border: thin solid #00;
+text-align:center;
+font-size:12;
+font-weight:bold;
 padding-right:3px;
 padding-left:3px;
-background-color: #EE;
-text-align:center;
-font-size:12;
-font-weight:bold;
 }
 .list_main_table td {
+border-bottom : thin solid #EE;
+text-align:left;
+font-size:12;
 padding-right:3px;
 padding-left:3px;
 padding-top:3px;
 padding-bottom:3px;
 }
-.list_main_lines,
-.list_main_footers {
-padding: 0;
-}
-.list_main_footers {
-padding-top: 15px;
-}
-.list_main_lines td,
-.list_main_footers td,
-.list_main_footers th {
-border-style: none;
-text-align:left;
-font-size:12;
-padding:0;
-}
-.list_main_footers th {
-text-align:right;
-}
-
-td .total_empty_cell {
-width: 77%;
-}
-td .total_sum_cell {
-width: 13%;
-}
-
-.nobreak {
-page-break-inside: avoid;
-}
-caption.formatted_note {
-text-align:left;
-border-right:thin solid #EE;
-border-left:thin solid #EE;
-border-top:thin solid #EE;
+.list_main_table thead {
+display:table-header-group;
+}
+
+div.formatted_note {
+text-align:left;
 padding-left:10px;
 font-size:11;
-caption-side: bottom;
-}
-caption.formatted_note p {
-margin: 0;
-}
-
-.main_col1 {
-width: 40%;
-}
-td.main_col1 {
-text-align:left;
-}
-.main_col2,
-.main_col3,
-.main_col4,
-.main_col6 {
-width: 10%;
-}
-.main_col5 {
-width: 7%;
-}
-td.main_col5 {
-text-align: center;
-font-style:italic;
-font-size: 10;
-}
-.main_col7 {
-width: 13%;
+}
+
+
+.list_bank_table {
+text-align:center;
+border-collapse: collapse;
+page-break-inside: avoid;
+display:table;
+}
+
+.act_as_row {
+   display:table-row;
+}
+.list_bank_table .act_as_thead {
+background-color: #EE;
+text-align:left;
+font-size:12;
+font-weight:bold;
+padding-right:3px;
+padding-left:3px;
+white-space:nowrap;
+background-clip:border-box;
+display:table-cell;
+}
+.list_bank_table .act_as_cell {
+text-align:left;
+font-size:12;
+padding-right:3px;
+padding-left:3px;
+padding-top:3px;
+padding-bottom:3px;
+white-space:nowrap;
+display:table-cell;
+}
+
+
+.list_tax_table {
+}
+.list_tax_table td {
+text-align:left;
+font-size:12;
+}
+.list_tax_table th {
+}
+.list_tax_table thead {
+display:table-header-group;
+}
+
+
+.list_total_table {
+border:thin solid #E3E4EA;
+text-align:center;
+border-collapse: collapse;
+}
+.list_total_table td {
+border-top : thin solid #EE;
+text-align:left;
+font-size:12;
+padding-right:3px;
+padding-left:3px;
+padding-top:3px;
+padding-bottom:3px;
+}
+.list_total_table th {
+background-color: #EE;
+border: thin solid #00;
+text-align:center;
+font-size:12;
+font-weight:bold;
+padding-right:3px
+padding-left:3px
+}
+.list_total_table thead {
+display:table-header-group;
+}
+
+
+.no_bloc {
+border-top: thin solid  #ff ;
 }
 
 .right_table {
@@ -105,6 +126,14 @@
 font-size:12;
 }
 
+tfoot.totals tr:first-child td{
+padding-top: 15px;
+}
+
+tfoot.totals td {
+border: none;
+}
+
 th.date {
 width: 90px;
 }
@@ -113,16 +142,43 @@
 text-align: right;
 white-space: nowrap;
 }
+.header_table {
+text-align: center;
+border: 1px solid lightGrey;
+border-collapse: collapse;
+}
+.header_table th {
+font-size: 12px;
+border: 1px solid lightGrey;
+}
+.header_table td {
+font-size: 12px;
+border: 1px solid lightGrey;
+}
 
 td.dat

[Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-report/7_fix_1331394 into lp:purchase-report

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/purchase-report/7_fix_1331394 into lp:purchase-report.

Requested reviews:
  Purchase Core Editors (purchase-core-editors)
Related bugs:
  Bug #1331394 in Purchase - Reports: "[7.0] purchase_order_webkit - 
'Description' field overlaps the next one 'Qty' when it is very long"
  https://bugs.launchpad.net/purchase-report/+bug/1331394

For more details, see:
https://code.launchpad.net/~agilebg/purchase-report/7_fix_1331394/+merge/223799

see 
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204
-- 
https://code.launchpad.net/~agilebg/purchase-report/7_fix_1331394/+merge/223799
Your team Purchase Core Editors is requested to review the proposed merge of 
lp:~agilebg/purchase-report/7_fix_1331394 into lp:purchase-report.
=== modified file 'purchase_order_webkit/report/purchase_order.mako'
--- purchase_order_webkit/report/purchase_order.mako	2014-04-17 10:55:08 +
+++ purchase_order_webkit/report/purchase_order.mako	2014-06-19 17:56:00 +
@@ -43,8 +43,12 @@
 border-style: none;
 text-align:left;
 font-size:12;
-padding:0;
-}
+}
+
+.list_main_lines td {
+border-bottom:thin solid #EE
+}
+
 .list_main_footers th {
 text-align:right;
 }
@@ -288,79 +292,57 @@
 
 
 
-
-	  
-	
-	  
-${_("Description")}
-${_("Taxes")}
-${_("Date Req.")}
-${_("Qty")}
-${_("UoM")}
-${_("Unit Price")}
-${_("Net Price")}
-  
-
-  
-
+  
+${_("Description")}
+${_("Taxes")}
+${_("Date Req.")}
+${_("Qty")}
+${_("UoM")}
+${_("Unit Price")}
+${_("Net Price")}
+  
 
 
 %for line in purch.order_line :
-  
-
-  
-
-  
-${line.name.replace('\n','') or '' | n}
-${ ', '.join([ tax.name or '' for tax in line.taxes_id ])}
-${formatLang(line.date_planned, date=True)}
-${line.product_qty}
-${line.product_uom.name}
-${formatLang(line.price_unit, digits=get_digits(dp='Purchase Price'))}
-${formatLang(line.price_subtotal, digits=get_digits(dp='Purchase Price'))} ${purch.pricelist_id.currency_id.symbol}
-  
- 
-  
-
-  
+  
+${line.name.replace('\n','') or '' | n}
+${ ', '.join([ tax.name or '' for tax in line.taxes_id ])}
+${formatLang(line.date_planned, date=True)}
+${line.product_qty}
+${line.product_uom.name}
+${formatLang(line.price_unit, digits=get_digits(dp='Purchase Price'))}
+${formatLang(line.price_subtotal, digits=get_digits(dp='Purchase Price'))} ${purch.pricelist_id.currency_id.symbol}
+  
%endfor
 
 	  
-	
-	  
-	
-	  
-	
-	  
-  
-${_("Net :")}
-  
-  
-${formatLang(purch.amount_untaxed, digits=get_digits(dp='Purchase Price'))} ${purch.pricelist_id.currency_id.symbol}
-  
-
-
-  
-  
-${_("Taxes:")}
-  
-  
-${formatLang(purch.amount_tax, digits=get_digits(dp='Purchase Price'))} ${purch.pricelist_id.currency_id.symbol}
-  
-
-
-  
-  
-${_("Total:")}
-  
-  
-${formatLang(purch.amount_total, digits=get_digits(dp='Purchase Price'))} ${purch.pricelist_id.currency_id.symbol}
-  
-
-  
-
-  
-
+
+
+  
+${_("Net :")}
+  
+  
+${formatLang(purch.amount_untaxed, digits=get_digits(dp='Purchase Price'))} ${purch.pricel

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1331541 into lp:sale-reports

[Lorenzo Battistini - Agile BG]

Review: Needs Fixing

 should be 
-- 
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1331541/+merge/223871
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:sale-reports.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-report/7_fix_1331543 into lp:stock-logistic-report

[Lorenzo Battistini - Agile BG]

Review: Approve code review


-- 
https://code.launchpad.net/~agilebg/stock-logistic-report/7_fix_1331543/+merge/223878
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-report.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools

[Lorenzo Battistini - Agile BG]

Hello Sébastien,
some PEP8 improvements here
https://code.launchpad.net/~agilebg/server-env-tools/binary_field_pep8/+merge/223935
-- 
https://code.launchpad.net/~akretion-team/server-env-tools/server-env-tools/+merge/91
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/server-env-tools/server-env-tools into lp:server-env-tools

[Lorenzo Battistini - Agile BG]

"I am asking myself about adding an object "storage.configuration" and a field 
"storing_configuration_id" on the model "ir.model.fields". The idea will to use 
a default storing configuration for every field (on file sytem for exemple) but 
after we will be able to customise on every field from the backend where where 
you want to store each binary/image fields (database, S3, ftp, SFTP, 
Filestore)
Do you like the idea?"

I like it :-)
-- 
https://code.launchpad.net/~akretion-team/server-env-tools/server-env-tools/+merge/91
Your team Server Environment And Tools Core Editors is subscribed to branch 
lp:server-env-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

[Lorenzo Battistini - Agile BG]

Review: Needs Fixing

Including 1 diff comment

About the module name: in general I agree with Pedro.
In this case, the other modules follow the same naming as this: see
http://bazaar.launchpad.net/~account-core-editors/account-invoicing/7.0/files/47/product_customer_code_invoice/
So, for now, I would keep the current name

Diff comments:

> === added directory 'product_customer_code_picking'
> === added file 'product_customer_code_picking/__init__.py'
> --- product_customer_code_picking/__init__.py 1970-01-01 00:00:00 +
> +++ product_customer_code_picking/__init__.py 2014-06-20 13:26:57 +
> @@ -0,0 +1,21 @@
> +# -*- coding: utf-8 -*-
> +##
> +#
> +#Copyright (C) 2013 Agile Business Group sagl ()
> +#Author: Nicola Malcontenti 
> +#
> +#This program is free software: you can redistribute it and/or modify
> +#it under the terms of the GNU Affero General Public License as published
> +#by the Free Software Foundation, either version 3 of the License, or
> +#(at your option) any later version.
> +#
> +#This program is distributed in the hope that it will be useful,
> +#but WITHOUT ANY WARRANTY; without even the implied warranty of
> +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +#GNU Affero General Public License for more details.
> +#
> +#You should have received a copy of the GNU Affero General Public License
> +#along with this program.  If not, see .
> +#
> +##
> +from . import stock_picking
> 
> === added file 'product_customer_code_picking/__openerp__.py'
> --- product_customer_code_picking/__openerp__.py  1970-01-01 00:00:00 
> +
> +++ product_customer_code_picking/__openerp__.py  2014-06-20 13:26:57 
> +
> @@ -0,0 +1,48 @@
> +# -*- coding: utf-8 -*-
> +##
> +#
> +#Copyright (C) 2013 Agile Business Group sagl ()
> +#Author: Nicola Malcontenti 
> +#
> +#This program is free software: you can redistribute it and/or modify
> +#it under the terms of the GNU Affero General Public License as published
> +#by the Free Software Foundation, either version 3 of the License, or
> +#(at your option) any later version.
> +#
> +#This program is distributed in the hope that it will be useful,
> +#but WITHOUT ANY WARRANTY; without even the implied warranty of
> +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +#GNU Affero General Public License for more details.
> +#
> +#You should have received a copy of the GNU Affero General Public License
> +#along with this program.  If not, see .
> +#
> +##
> +{
> +"name": "Product Customer code for stock picking",
> +"version": "1.0",
> +"author": "Agile Business Group",
> +"website": "http://www.agilebg.com";,
> +"license": 'AGPL-3',
> +"category": "Stock",
> +"depends": [
> +'base',
> +'product',
> +'stock',
> +'product_customer_code'
> +],
> +"description": """
> +Based on product_customer_code, this module loads in every stock picking
> +the customer code defined in the product.
> +
> +Contributors
> +
> +* Nicola Malcontenti  
> +* Alex Comba 
> +""",
> +"demo": [],
> +"data": [
> +'stock_picking_view.xml',
> +],
> +"installable": True,
> +}
> 
> === added directory 'product_customer_code_picking/i18n'
> === added file 'product_customer_code_picking/i18n/it.po'
> --- product_customer_code_picking/i18n/it.po  1970-01-01 00:00:00 +
> +++ product_customer_code_picking/i18n/it.po  2014-06-20 13:26:57 +
> @@ -0,0 +1,33 @@
> +# Translation of OpenERP Server.
> +# This file contains the translation of the following modules:
> +#* product_customer_code_picking
> +#
> +msgid ""
> +msgstr ""
> +"Project-Id-Version: OpenERP Server 7.0\n"
> +"Report-Msgid-Bugs-To: \n"
> +"POT-Creation-Date: 2014-01-15 14:28+\n"
> +"PO-Revision-Date: 2014-01-15 15:29+0100\n"
> +"Last-Translator: <>\n"
> +"Language-Team: \n"
> +"MIME-Version: 1.0\n"
> +"Content-Type: text/plain; charset=UTF-8\n"
> +"Content-Transfer-Encoding: 8bit\n"
> +"Plural-Forms: \n"
> +"Language: it\n"
> +"X-Generator: Poedit 1.6.2\n"
> +
> +#. module: product_customer_code_picking
> +#: field:stock.move,product_customer_code:0
> +msgid "Product Customer Code"
> +msgstr "Codice Prodotto Cliente"
> +
> +#. module: product_customer_code_picking
> +#: model:ir.model,name:product_customer_code_picking.model_stock_move
> +msgid "Stock Move"
> +msgstr "Movimento di magazzino"
> +
> +#. module: product_customer_code_picking
> +#: model:ir.model,name:product_cust

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/adding_product_customer_code_picking into lp:stock-logistic-flows

[Lorenzo Battistini - Agile BG]

2014-06-22 23:10 GMT+02:00 Alex Comba - Agile BG :

> Lorenzo,
>
> please have a look at my last commit, now it should be ok.
>
>
Thanks Alex,

maybe we could handle even more particular cases by using the address_get
method to retrieve the company?

-- 
https://code.launchpad.net/~agilebg/stock-logistic-flows/adding_product_customer_code_picking/+merge/202472
Your team Stock and Logistic Core Editors is subscribed to branch 
lp:stock-logistic-flows.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Hello Alexis, many thanks for the module.

What do you think about creating the res.country.state records if they don't 
exist, before mapping them in the 'states' dictionary?

The current version is supposed to correctly work with states if you first 
create states data by modules like l10n_fr_state.
But if base_location_geonames_import also imported states data from geonames 
(creating records if they don't exist yet) we would not need an extra module 
just to create states data.
-- 
https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into lp:sale-wkfl

[Lorenzo Battistini - Agile BG]

Review: Approve

Thanks Alex, just 1 diff remark

Diff comments:

> === added directory 'sale_line_quantity_properties_based'
> === added file 'sale_line_quantity_properties_based/__init__.py'
> --- sale_line_quantity_properties_based/__init__.py   1970-01-01 00:00:00 
> +
> +++ sale_line_quantity_properties_based/__init__.py   2014-06-18 12:43:45 
> +
> @@ -0,0 +1,22 @@
> +# -*- coding: utf-8 -*-
> +##
> +#
> +#Author: Alex Comba 
> +#Copyright (C) 2014 Agile Business Group sagl
> +#()
> +#
> +#This program is free software: you can redistribute it and/or modify
> +#it under the terms of the GNU Affero General Public License as published
> +#by the Free Software Foundation, either version 3 of the License, or
> +#(at your option) any later version.
> +#
> +#This program is distributed in the hope that it will be useful,
> +#but WITHOUT ANY WARRANTY; without even the implied warranty of
> +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +#GNU Affero General Public License for more details.
> +#
> +#You should have received a copy of the GNU Affero General Public License
> +#along with this program.  If not, see .
> +#
> +##
> +from . import sale
> 
> === added file 'sale_line_quantity_properties_based/__openerp__.py'
> --- sale_line_quantity_properties_based/__openerp__.py1970-01-01 
> 00:00:00 +
> +++ sale_line_quantity_properties_based/__openerp__.py2014-06-18 
> 12:43:45 +
> @@ -0,0 +1,100 @@
> +# -*- coding: utf-8 -*-
> +##
> +#
> +#Author: Alex Comba 
> +#Copyright (C) 2014 Agile Business Group sagl
> +#()
> +#
> +#This program is free software: you can redistribute it and/or modify
> +#it under the terms of the GNU Affero General Public License as published
> +#by the Free Software Foundation, either version 3 of the License, or
> +#(at your option) any later version.
> +#
> +#This program is distributed in the hope that it will be useful,
> +#but WITHOUT ANY WARRANTY; without even the implied warranty of
> +#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +#GNU Affero General Public License for more details.
> +#
> +#You should have received a copy of the GNU Affero General Public License
> +#along with this program.  If not, see .
> +#
> +##
> +{
> +'name': "Sale line quantity properties based",
> +'version': '0.1',
> +'category': 'Sales Management',
> +'description': """
> +Sale line quantity based on line properties
> +===
> +
> +*This module allows the calculation of the product quantity on the basis of a
> +formula that considers the properties specified by the user on the sale order
> +line and on the quantity (UoS).*
> +
> +Example
> +
> +
> +Provided the sale of a given number of pieces (shelves), that may be
> +’x’ meter long and ’y’ meter large, the formula enables the calculation of 
> the
> +total area sold expressed in square meters:
> +10 [pcs of] (4 m x 0.5 m) shelves = 20 m² of wood
> +
> +In order to have this function working, it is necessary to have the user
> +proceeding as follows:
> +
> +before starting, s/he has to belong to **sale.group_mrp_properties** by
> +selecting the option "Invoice products in a different unit of measure than 
> the
> +sales order" in the following menu: **Settings --> Configration --> 
> Warehouse** 
> +
> +Then s/he shall create properties such as ‘length 4’, ‘width 0.5’. 
> +
> +Properties must respond the following criteria:
> +
> +* Name: ‘length 1’, ‘length 4’, ‘width 0.5’
> +* Property Group : either ‘length’ or ‘width’
> +* Description : the corresponding quantity (1, 4, 0.5...)
> +
> +Property 'length 4' 
> +* Name: ‘length 4’
> +* Property Group : ‘length’
> +* Description : 4
> +
> +Property 'width 0.5' 
> +* Name: ‘width 0.5’
> +* Property Group : ‘width’
> +* Description : 0.5
> +
> +After this, the formula 'surface' must be created:
> +
> +**P['length'] * P['width']**
> +whereas P is a mandatory element and 'length' and 'width' must be provided
> +in square brackets **[ ]**
> +
> +This is possible by using the menu:
> +**Manufacturing --> Configuration--> Formulas**
> +
> +Upon the registering of the order, the user will apply in the properties 
> field
> +the desired properties (in this example the ‘lenght 4’ and ‘width 2’), the 
> +needed formula (in this example 'surface') and last the quantity (UoS).
> +
> +Contributors
> +
> +* Alex Comba 
> +* Loren

[Openerp-community-reviewer] [Merge] lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into lp:sale-wkfl

[Lorenzo Battistini - Agile BG]

The proposal to merge 
lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into 
lp:sale-wkfl has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7/+merge/223538
-- 
https://code.launchpad.net/~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7/+merge/223538
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into 
lp:sale-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-consolidation/7.0-fix_1334639-afe into lp:account-consolidation

[Lorenzo Battistini - Agile BG]

Review: Resubmit

wrong target
-- 
https://code.launchpad.net/~camptocamp/account-consolidation/7.0-fix_1334639-afe/+merge/224629
Your team Account Core Editors is requested to review the proposed merge of 
lp:~camptocamp/account-consolidation/7.0-fix_1334639-afe into 
lp:account-consolidation.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-wkfl/imp_product_by_supplier into lp:purchase-wkfl

[Lorenzo Battistini - Agile BG]

Review: Approve


-- 
https://code.launchpad.net/~agilebg/purchase-wkfl/imp_product_by_supplier/+merge/225197
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs into lp:~account-core-editors/account-invoice-report/7.0

[Lorenzo Battistini - Agile BG]

"Sorry Lorenzo didn't had the time to look closely at this MP again. Can we 
continue this on github ?"

Gladly!

Here it is
https://github.com/OCA/account-invoice-reporting/pull/2
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/7.0-fix_invoice_webkit_description_bugs/+merge/205204
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:~account-core-editors/account-invoice-report/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-consolidation/7.0-fix-1334645-elbati into lp:account-consolidation/7.0

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/account-consolidation/7.0-fix-1334645-elbati into 
lp:account-consolidation/7.0.

Requested reviews:
  Account Core Editors (account-core-editors)
Related bugs:
  Bug #1334645 in Account - Consolidation: "account_parallel_currency: test 
failure test/mapping_parallel_accounts.yml"
  https://bugs.launchpad.net/account-consolidation/+bug/1334645

For more details, see:
https://code.launchpad.net/~agilebg/account-consolidation/7.0-fix-1334645-elbati/+merge/225266
-- 
https://code.launchpad.net/~agilebg/account-consolidation/7.0-fix-1334645-elbati/+merge/225266
Your team Account Core Editors is requested to review the proposed merge of 
lp:~agilebg/account-consolidation/7.0-fix-1334645-elbati into 
lp:account-consolidation/7.0.
=== modified file 'account_parallel_currency/account.py'
--- account_parallel_currency/account.py	2014-03-24 18:16:13 +
+++ account_parallel_currency/account.py	2014-07-02 07:17:41 +
@@ -455,8 +455,8 @@
 for tax_code in self.browse(cr, SUPERUSER_ID, ids, context):
 for parallel_company in tax_code.company_id.parallel_company_ids:
 if not tax_code.parent_id:
-raise orm.except_orm(_('Error'),_('Tax code %s does not have parent')
-% tax_code.code)
+# can't do the mapping as it's based on parent tax code
+return True
 existing_ids = self.search(cr, SUPERUSER_ID, [
 ('code', '=', tax_code.code),
 ('company_id', '=', parallel_company.id),

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message into lp:hr-timesheet

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message 
into lp:hr-timesheet.

Requested reviews:
  HR Core Editors (hr-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message/+merge/225275
-- 
https://code.launchpad.net/~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message/+merge/225275
Your team HR Core Editors is requested to review the proposed merge of 
lp:~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message 
into lp:hr-timesheet.
=== modified file 'hr_attendance_analysis/hr_attendance.py'
--- hr_attendance_analysis/hr_attendance.py	2014-05-21 22:04:08 +
+++ hr_attendance_analysis/hr_attendance.py	2014-07-02 08:57:12 +
@@ -75,16 +75,26 @@
 def total_seconds(self, td):
 return (td.microseconds + (td.seconds + td.days * 24 * 3600) * 10**6) / 10**6
 
-def time_difference(self, float_start_time, float_end_time):
+def time_difference(
+self, float_start_time, float_end_time, attendance_id=False
+):
 if float_compare(
 float_end_time, float_start_time, precision_rounding=0.001
 ) == -1:
 # that means a difference smaller than 0.36 milliseconds
+message = _('End time %s < start time %s') % (
+str(float_end_time), str(float_start_time)
+if attendance_id:
+message = _(
+'End time %s < start time %s (attendance ID: %s)'
+) % (
+str(float_end_time),
+str(float_start_time),
+str(attendance_id)
+)
 raise orm.except_orm(
 _('Error'),
-_('End time %s < start time %s') % (
-str(float_end_time), str(float_start_time)
-)
+message
 )
 delta = self.float_to_datetime(
 float_end_time) - self.float_to_datetime(
@@ -329,9 +339,12 @@
 res[attendance.id]['inside_calendar_duration'] = intervals_within * precision
 # make difference using time in order to avoid rounding errors
 # inside_calendar_duration can't be > duration
-res[attendance.id]['outside_calendar_duration'] = self.time_difference(
+res[attendance.id][
+'outside_calendar_duration'
+] = self.time_difference(
 res[attendance.id]['inside_calendar_duration'],
-res[attendance.id]['duration'])
+res[attendance.id]['duration'],
+attendance_id = attendance.id)
 
 if reference_calendar.overtime_rounding:
 if res[attendance.id]['outside_calendar_duration']:

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message into lp:hr-timesheet

[Lorenzo Battistini - Agile BG]

The proposal to merge 
lp:~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message 
into lp:hr-timesheet has been updated.

Description changed to:

This allows, when time diff errors are raised, to identify the raising 
attendance

For more details, see:
https://code.launchpad.net/~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message/+merge/225275
-- 
https://code.launchpad.net/~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message/+merge/225275
Your team HR Core Editors is requested to review the proposed merge of 
lp:~agilebg/hr-timesheet/hr_attendance_analysis-imp-time_difference-message 
into lp:hr-timesheet.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-consolidation/7.0-fix-1334645-elbati into lp:account-consolidation/7.0

[Lorenzo Battistini - Agile BG]

I confirm.
Note that the bug only occurs when you create a new tax code without parent.
-- 
https://code.launchpad.net/~agilebg/account-consolidation/7.0-fix-1334645-elbati/+merge/225266
Your team Account Core Editors is subscribed to branch 
lp:account-consolidation/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-consolidation/7.0-fix-1334645-elbati into lp:account-consolidation/7.0

[Lorenzo Battistini - Agile BG]

lep, right. I looked at it better and saw that if parent_id is missing, I 
should just not fill the parent_id field of the parallel account.
-- 
https://code.launchpad.net/~agilebg/account-consolidation/7.0-fix-1334645-elbati/+merge/225266
Your team Account Core Editors is subscribed to branch 
lp:account-consolidation/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-consolidation/7.0-fix-1334645-elbati into lp:account-consolidation/7.0

[Lorenzo Battistini - Agile BG]

On 07/07/2014 03:00 PM, Leonardo Pistone - camptocamp wrote:
> maybe you could refactor a bit putting
>
> parent_parallel_tax_code_id = False
>
> in an else: block a few lines down? otherwise, lgtm

Done

-- 
https://code.launchpad.net/~agilebg/account-consolidation/7.0-fix-1334645-elbati/+merge/225266
Your team Account Core Editors is subscribed to branch 
lp:account-consolidation/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-reports/7_fix_1315445 into lp:~sale-core-editors/sale-reports/7.0

[Lorenzo Battistini - Agile BG]

Done
https://github.com/OCA/sale-reporting/pull/13
-- 
https://code.launchpad.net/~agilebg/sale-reports/7_fix_1315445/+merge/223795
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:~sale-core-editors/sale-reports/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name/+merge/204023
Your team Partner and Contact Core Editors is requested to review the proposed 
merge of 
lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name
 into lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_supplier_information into lp:partner-contact-manage

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_supplier_information/+merge/204046
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account/+merge/204047
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/partner_firstname_vre_firstname_crm/+merge/213673
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner_category_description into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner_category_description/+merge/213697
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_modules/+merge/217775
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/partner-contact-management/7.0_1184983_compute_display_name into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_1184983_compute_display_name/+merge/220629
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/partner-contact-management/7.0-add_birthdate_nbi into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~camptocamp/partner-contact-management/7.0-add_birthdate_nbi/+merge/220637
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/add-partner_relation into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~akretion-team/partner-contact-management/add-partner_relation/+merge/220726
Your team Partner and Contact Core Editors is requested to review the proposed 
merge of lp:~akretion-team/partner-contact-management/add-partner_relation into 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~yannick-buron/partner-contact-management/partner-contact-management into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~yannick-buron/partner-contact-management/partner-contact-management/+merge/221742
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~dr.clearcorp/partner-contact-management/7.0-review_partner_merge into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~dr.clearcorp/partner-contact-management/7.0-review_partner_merge/+merge/223137
Your team Partner and Contact Core Editors is subscribed to branch 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/partner-contact-management/7.0_partner_relations into lp:partner-contact-management

[Lorenzo Battistini - Agile BG]

Review: Resubmit

This project is now hosted on https://github.com/OCA/partner-contact. Please 
move your proposal there. This guide may help you 
https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub
-- 
https://code.launchpad.net/~therp-nl/partner-contact-management/7.0_partner_relations/+merge/223734
Your team Partner and Contact Core Editors is requested to review the proposed 
merge of lp:~therp-nl/partner-contact-management/7.0_partner_relations into 
lp:partner-contact-management.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-consolidation/7.0-fix-1334645-elbati into lp:~account-core-editors/account-consolidation/7.0

[Lorenzo Battistini - Agile BG]

Moved to https://github.com/OCA/account-consolidation/pull/3
-- 
https://code.launchpad.net/~agilebg/account-consolidation/7.0-fix-1334645-elbati/+merge/225266
Your team Account Core Editors is subscribed to branch 
lp:~account-core-editors/account-consolidation/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into lp:sale-wkfl

[Lorenzo Battistini - Agile BG]

The proposal to merge 
lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into 
lp:sale-wkfl has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7/+merge/223538
-- 
https://code.launchpad.net/~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7/+merge/223538
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into 
lp:sale-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into lp:sale-wkfl

[Lorenzo Battistini - Agile BG]

Review: Abstain

Setting WIP because this will need refactoring after 
https://github.com/eLBati/sale-workflow/tree/7.0_add_price_propreties_based
-- 
https://code.launchpad.net/~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7/+merge/223538
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into 
lp:sale-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/partner-contact-management/base-location-geonames-import into lp:~partner-contact-core-editors/partner-contact-management/7.0

[Lorenzo Battistini - Agile BG]

PR for v8 at https://github.com/OCA/partner-contact/pull/22
-- 
https://code.launchpad.net/~akretion-team/partner-contact-management/base-location-geonames-import/+merge/214564
Your team Partner and Contact Core Editors is subscribed to branch 
lp:~partner-contact-core-editors/partner-contact-management/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into lp:~sale-core-editors/sale-wkfl/7.0

[Lorenzo Battistini - Agile BG]

Review: Disapprove

moved to https://github.com/OCA/sale-workflow/pull/9
-- 
https://code.launchpad.net/~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7/+merge/223538
Your team Sale Core Editors is requested to review the proposed merge of 
lp:~agilebg/sale-wkfl/adding_sale_line_quantity_properties_based_7 into 
lp:~sale-core-editors/sale-wkfl/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7 into lp:~account-core-editors/account-invoicing/7.0

[Lorenzo Battistini - Agile BG]

Review: Disapprove

moved to https://github.com/OCA/account-invoicing/pull/9
-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_invoice_line_no_picking_name_7/+merge/220289
Your team Account Core Editors is subscribed to branch 
lp:~account-core-editors/account-invoicing/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/purchase-report/7_fix_1331394 into lp:~purchase-core-editors/purchase-report/7.0

[Lorenzo Battistini - Agile BG]

Done at https://github.com/OCA/purchase-reporting/pull/1
-- 
https://code.launchpad.net/~agilebg/purchase-report/7_fix_1331394/+merge/223799
Your team Purchase Core Editors is subscribed to branch 
lp:~purchase-core-editors/purchase-report/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into lp:~account-core-editors/account-invoice-report/7.0

[Lorenzo Battistini - Agile BG]

Ciao banane,
you have to use
from openerp.tools.translate import _ (see for instance 
https://github.com/OCA/account-invoice-reporting/blob/7.0/invoice_webkit/invoice.py#L52
 )

Anyway, the project has moved to github. Please open an issue (or better a PR) 
at https://github.com/OCA/account-invoice-reporting

Thanks
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:~account-core-editors/account-invoice-report/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_account_invoice_production_lot_7 into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

On 09/25/2013 12:46 AM, Pedro Manuel Baeza wrote:
> - Use invoice_webkit as dependency. It introduces a higher dependency 
> (webkit) that is not needed by the funcionality itself. There are a lot of 
> people that don't still use webkit.

Hello Pedro,

the main purpose of the module is to print the invoice with lots 
information (just changed a bit the module description). So, a report 
engine is needed.
Maybe we could move it to 
lp:~account-core-editors/account-invoice-report/7.0 branch


> - Load data into a text field. Why don't load it in a many2many field like 
> other references (order_lines and so on)?

Data is already available within a (function) m2m field: 'prod_lot_ids'.
Loading data into 'note' is for printing purpose only.

-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_account_invoice_production_lot_7/+merge/181747
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/ocb-addons/7.0-bug-1206538-elbati into lp:ocb-addons

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/ocb-addons/7.0-bug-1206538-elbati into lp:ocb-addons.

Requested reviews:
  OpenERP Community Backports Team (ocb)
Related bugs:
  Bug #1206538 in OpenERP Addons: "[7.0] l10n_it - wrong types for view 
accounts"
  https://bugs.launchpad.net/openobject-addons/+bug/1206538

For more details, see:
https://code.launchpad.net/~agilebg/ocb-addons/7.0-bug-1206538-elbati/+merge/187984
-- 
https://code.launchpad.net/~agilebg/ocb-addons/7.0-bug-1206538-elbati/+merge/187984
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~agilebg/ocb-addons/7.0-bug-1206538-elbati into lp:ocb-addons.
=== modified file 'l10n_it/data/account.account.template.csv'
--- l10n_it/data/account.account.template.csv	2012-10-23 16:05:04 +
+++ l10n_it/data/account.account.template.csv	2013-09-27 06:31:45 +
@@ -1,14 +1,14 @@
 id,code,name,parent_id:id,user_type:id,type,reconcile
 0,0,Azienda,,account.data_account_type_view,view,FALSE
-1,1,ATTIVO ,0,account.data_account_type_view,view,TRUE
-11,11,IMMOBILIZZAZIONI IMMATERIALI ,1,account.data_account_type_view,view,TRUE
+1,1,ATTIVO ,0,account.account_type_asset_view1,view,TRUE
+11,11,IMMOBILIZZAZIONI IMMATERIALI ,1,account.account_type_asset_view1,view,TRUE
 1101,1101,costi di impianto ,11,account.data_account_type_asset,other,TRUE
 1106,1106,software ,11,account.data_account_type_asset,other,TRUE
 1108,1108,avviamento ,11,account.data_account_type_asset,other,TRUE
 ,,fondo ammortamento costi di impianto ,11,account.data_account_type_asset,other,TRUE
 1116,1116,fondo ammortamento software ,11,account.data_account_type_asset,other,TRUE
 1118,1118,fondo ammortamento avviamento ,11,account.data_account_type_asset,other,TRUE
-12,12,IMMOBILIZZAZIONI MATERIALI ,1,account.data_account_type_view,view,TRUE
+12,12,IMMOBILIZZAZIONI MATERIALI ,1,account.account_type_asset_view1,view,TRUE
 1201,1201,fabbricati ,12,account.data_account_type_asset,other,TRUE
 1202,1202,impianti e macchinari ,12,account.data_account_type_asset,other,TRUE
 1204,1204,attrezzature commerciali ,12,account.data_account_type_asset,other,TRUE
@@ -24,13 +24,13 @@
 1217,1217,fondo ammortamento automezzi ,12,account.data_account_type_asset,other,TRUE
 1218,1218,fondo ammortamento imballaggi durevoli ,12,account.data_account_type_asset,other,TRUE
 1220,1220,fornitori immobilizzazioni c/acconti ,12,account.data_account_type_asset,other,TRUE
-13,13,IMMOBILIZZAZIONI FINANZIARIE ,1,account.data_account_type_view,view,TRUE
+13,13,IMMOBILIZZAZIONI FINANZIARIE ,1,account.account_type_asset_view1,view,TRUE
 1301,1301,mutui attivi ,13,account.data_account_type_asset,other,TRUE
-14,14,RIMANENZE ,1,account.data_account_type_view,view,TRUE
+14,14,RIMANENZE ,1,account.account_type_asset_view1,view,TRUE
 1401,1401,materie di consumo ,14,account.data_account_type_asset,other,TRUE
 1404,1404,merci ,14,account.data_account_type_asset,other,TRUE
 1410,1410,fornitori c/acconti ,14,account.data_account_type_asset,other,TRUE
-15,15,CREDITI COMMERCIALI ,1,account.data_account_type_view,view,TRUE
+15,15,CREDITI COMMERCIALI ,1,account.account_type_asset_view1,view,TRUE
 1501,1501,crediti v/clienti ,15,account.data_account_type_receivable,receivable,TRUE
 1502,1502,crediti commerciali diversi ,15,account.data_account_type_asset,other,TRUE
 1503,1503,clienti c/spese anticipate ,15,account.data_account_type_receivable,receivable,TRUE
@@ -43,7 +43,7 @@
 1531,1531,crediti da liquidare ,15,account.data_account_type_asset,other,TRUE
 1540,1540,fondo svalutazione crediti ,15,account.data_account_type_asset,other,TRUE
 1541,1541,fondo rischi su crediti ,15,account.data_account_type_asset,other,TRUE
-16,16,CREDITI DIVERSI ,1,account.data_account_type_view,view,TRUE
+16,16,CREDITI DIVERSI ,1,account.account_type_asset_view1,view,TRUE
 1601,1601,IVA n/credito ,16,account.data_account_type_asset,other,TRUE
 1602,1602,IVA c/acconto ,16,account.data_account_type_asset,other,TRUE
 1605,1605,crediti per IVA ,16,account.data_account_type_asset,other,TRUE
@@ -54,30 +54,30 @@
 1620,1620,personale c/acconti ,16,account.data_account_type_asset,other,TRUE
 1630,1630,crediti v/istituti previdenziali ,16,account.data_account_type_asset,other,TRUE
 1640,1640,debitori diversi ,16,account.data_account_type_receivable,receivable,TRUE
-18,18,DISPONIBILITÀ LIQUIDE ,1,account.data_account_type_view,view,TRUE
+18,18,DISPONIBILITÀ LIQUIDE ,1,account.account_type_asset_view1,view,TRUE
 1801,1801,banche c/c ,18,account.data_account_type_bank,liquidity,TRUE
 1810,1810,c/c postali ,18,account.data_account_type_bank,liquidity,TRUE
 1820,1820,denaro in cassa ,18,account.data_account_type_cash,liquidity,TRUE
 1821,1821,assegni ,18,account.data_account_type_cash,liquidity,TRUE
 1822,1822,valori bollati ,18,account.data_account_type_cash,liquidity,TRUE
-19,19,RATEI E RISCONTI ATTIVI ,1,account.data_account_type_view,view,TRUE
+19,19,RATEI 

Re: [Openerp-community-reviewer] [Merge] lp:~elbati/account-consolidation/adding_account_parallel_currency_7 into lp:account-consolidation/7.0

[Lorenzo Battistini - Agile BG]

On 09/08/2013 08:17 AM, Stefan Rijnhart (Therp) wrote:
> It would be nice to know whether this module has already been used in 
> production by now?

Hello Stefan.

The module has been used in production from this winter.

Unfortunately, we could not verify deeply the data accuracy yet. We will 
probably do it at the end the year.


-- 
https://code.launchpad.net/~elbati/account-consolidation/adding_account_parallel_currency_7/+merge/151723
Your team Account Core Editors is subscribed to branch 
lp:account-consolidation/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~elbati/purchase-wkfl/adding_purchase_partial_invoicing_7 into lp:purchase-wkfl

[Lorenzo Battistini - Agile BG]

On 09/19/2013 05:09 PM, Pedro Manuel Baeza wrote:
> Review: Needs Fixing code review and test
>
> Hi, Lorenzo, congratulations for your work.
>
> I have tried the module and it works very well, but I have found one problem 
> that must be solved, because it can produce very bad results: in partial 
> picking quantity, you can put any quantity, even greater than the pending 
> one. Imagine you type incorrectly two times key '3' and click "Confirm": you 
> will invoice 33 units instead of 3.

Hello Pedro, thanks, it should be fixed now.


>
> Is there any chance to get pending quantity field on "Invoice Control > On 
> Purchase Order Lines"?

Added 'invoiced quantity' field to order lines list


>
> >From technical side, please add pot file to allow translations of the 
> >module. There are also some errors in flake8 output that you would like to 
> >correct.

pot added and PEP8 respected

Thanks

-- 
https://code.launchpad.net/~elbati/purchase-wkfl/adding_purchase_partial_invoicing_7/+merge/167065
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_account_fiscal_position_country_7 into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

Review: Disapprove

Guewen, you are right. The functionality seems to be already covered by 
account_fiscal_position_rule*
I'm closing this MP
-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_account_fiscal_position_country_7/+merge/182636
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_account_fiscal_position_country_7 into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

"I'm closing this MP"

I can't :-)

You can reject this MP.

Thanks
-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_account_fiscal_position_country_7/+merge/182636
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~elbati/account-consolidation/adding_account_parallel_currency_7 into lp:account-consolidation/7.0

[Lorenzo Battistini - Agile BG]

On 09/29/2013 08:30 PM, Stefan Rijnhart (Therp) wrote:
> and for updating the code style a little bit

I had no time to complete it for now..


-- 
https://code.launchpad.net/~elbati/account-consolidation/adding_account_parallel_currency_7/+merge/151723
Your team Account Core Editors is subscribed to branch 
lp:account-consolidation/7.0.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/ocb-addons/ocb7.0-add-it-vat-22 into lp:ocb-addons

[Lorenzo Battistini - Agile BG]

Review: Approve code review

Same review as for
https://code.launchpad.net/~agilebg/openobject-addons/7.0-add-it-vat-22/+merge/189282

Of course, this can also be done by simply merging from lp:openobject-addons/7.0
-- 
https://code.launchpad.net/~agilebg/ocb-addons/ocb7.0-add-it-vat-22/+merge/189283
Your team OpenERP Community Backports Team is requested to review the proposed 
merge of lp:~agilebg/ocb-addons/ocb7.0-add-it-vat-22 into lp:ocb-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~elbati/purchase-wkfl/adding_purchase_partial_invoicing_7 into lp:purchase-wkfl

[Lorenzo Battistini - Agile BG]

On 10/01/2013 07:30 PM, Pedro Manuel Baeza wrote:
> Review: Needs Fixing code review and test
>
> Hi, Lorenzo, thank you very much for the changes.
>
> There's only one more thing that I have detected: if you make a partial 
> invoice, when you make again another invoice, you can let deselected "Partial 
> invoice" field and invoice the full quantity instead the remaining.

Hello Pedro.

I removed the 'partial invoice' flag: now the behaviour is always based 
on what has been set in the wizard's lines. So, you can't invoice the 
full quantity.

-- 
https://code.launchpad.net/~elbati/purchase-wkfl/adding_purchase_partial_invoicing_7/+merge/167065
Your team Purchase Core Editors is subscribed to branch lp:purchase-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/openerp-fiscal-rules/7.0-bug-1239999-elbati into lp:openerp-fiscal-rules

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/openerp-fiscal-rules/7.0-bug-123-elbati into 
lp:openerp-fiscal-rules.

Requested reviews:
  Account Core Editors (account-core-editors)
Related bugs:
  Bug #123 in openerp-fiscal-rules: "account_fiscal_position_rule - error 
on selecting partner in invoice"
  https://bugs.launchpad.net/openerp-fiscal-rules/+bug/123

For more details, see:
https://code.launchpad.net/~agilebg/openerp-fiscal-rules/7.0-bug-123-elbati/+merge/191132
-- 
https://code.launchpad.net/~agilebg/openerp-fiscal-rules/7.0-bug-123-elbati/+merge/191132
Your team Account Core Editors is requested to review the proposed merge of 
lp:~agilebg/openerp-fiscal-rules/7.0-bug-123-elbati into 
lp:openerp-fiscal-rules.
=== modified file 'account_fiscal_position_rule/account_fiscal_position_rule.py'
--- account_fiscal_position_rule/account_fiscal_position_rule.py	2013-02-11 13:25:39 +
+++ account_fiscal_position_rule/account_fiscal_position_rule.py	2013-10-15 09:17:33 +
@@ -112,7 +112,7 @@
 
 return domain
 
-def apply_fiscal_mapping(self, cr, uid, result, kwargs):
+def apply_fiscal_mapping(self, cr, uid, result, **kwargs):
 result['value'].update(self.fiscal_position_map(cr, uid, **kwargs))
 return result
 

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~agilebg/stock-logistic-flows/imp_stock_picking_invoice_link into lp:stock-logistic-flows/7.0

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/stock-logistic-flows/imp_stock_picking_invoice_link into 
lp:stock-logistic-flows/7.0.

Requested reviews:
  Stock and Logistic Core Editors (stock-logistic-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/stock-logistic-flows/imp_stock_picking_invoice_link/+merge/191175
-- 
https://code.launchpad.net/~agilebg/stock-logistic-flows/imp_stock_picking_invoice_link/+merge/191175
Your team Stock and Logistic Core Editors is requested to review the proposed 
merge of lp:~agilebg/stock-logistic-flows/imp_stock_picking_invoice_link into 
lp:stock-logistic-flows/7.0.
=== modified file 'stock_picking_invoice_link/__init__.py'
--- stock_picking_invoice_link/__init__.py	2013-06-03 14:50:36 +
+++ stock_picking_invoice_link/__init__.py	2013-10-15 12:48:46 +
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 ##
-#
+#
 #Copyright (C) 2013 Agile Business Group sagl (<http://www.agilebg.com>)
 #
 #This program is free software: you can redistribute it and/or modify

=== modified file 'stock_picking_invoice_link/__openerp__.py'
--- stock_picking_invoice_link/__openerp__.py	2013-09-02 14:04:48 +
+++ stock_picking_invoice_link/__openerp__.py	2013-10-15 12:48:46 +
@@ -24,7 +24,8 @@
 'category': 'Warehouse Management',
 'summary': 'Adds link between pickings and generated invoices',
 'description': """
-This module adds a link between pickings and generated invoices. So that user can easly reach the invoice related to the picking.
+This module adds a link between pickings and generated invoices.
+So that user can easly reach the invoice related to the picking.
 
 Probably to be modified according to bug 1169998 (when solution will come)
 https://bugs.launchpad.net/openobject-addons/+bug/1169998

=== modified file 'stock_picking_invoice_link/stock.py'
--- stock_picking_invoice_link/stock.py	2013-06-03 14:50:36 +
+++ stock_picking_invoice_link/stock.py	2013-10-15 12:48:46 +
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 ##
-#
+#
 #Copyright (C) 2013 Agile Business Group sagl (<http://www.agilebg.com>)
 #
 #This program is free software: you can redistribute it and/or modify
@@ -21,28 +21,50 @@
 from openerp.osv import fields, orm
 from openerp.tools.translate import _
 
+
+class stock_move(orm.Model):
+_inherit = "stock.move"
+
+_columns = {
+'invoice_line_id': fields.many2one(
+'account.invoice.line', 'Invoice line', readonly=True),
+}
+
+
 class stock_picking(orm.Model):
 _inherit = "stock.picking"
-
+
 _columns = {
-'invoice_id': fields.many2one('account.invoice', 'Invoice', readonly=True),
-}
-
+'invoice_id': fields.many2one(
+'account.invoice', 'Invoice', readonly=True),
+}
+
 def _invoice_hook(self, cr, uid, picking, invoice_id):
-res = super(stock_picking,self)._invoice_hook(cr, uid, picking, invoice_id)
+res = super(stock_picking, self)._invoice_hook(
+cr, uid, picking, invoice_id)
 picking.write({'invoice_id': invoice_id})
 return res
 
+def _invoice_line_hook(self, cr, uid, move_line, invoice_line_id):
+res = super(stock_picking, self)._invoice_line_hook(
+cr, uid, move_line, invoice_line_id)
+move_line.write({'invoice_line_id': invoice_line_id})
+return res
+
+
 class stock_picking_out(orm.Model):
 _inherit = "stock.picking.out"
-
+
 _columns = {
-'invoice_id': fields.many2one('account.invoice', 'Invoice', readonly=True),
-}
+'invoice_id': fields.many2one(
+'account.invoice', 'Invoice', readonly=True),
+}
+
 
 class stock_picking_in(orm.Model):
 _inherit = "stock.picking.in"
-
+
 _columns = {
-'invoice_id': fields.many2one('account.invoice', 'Invoice', readonly=True),
-}
+'invoice_id': fields.many2one(
+'account.invoice', 'Invoice', readonly=True),
+}

=== modified file 'stock_picking_invoice_link/stock_view.xml'
--- stock_picking_invoice_link/stock_view.xml	2013-06-03 14:59:40 +
+++ stock_picking_invoice_link/stock_view.xml	2013-10-15 12:48:46 +
@@ -1,6 +1,9 @@
 
 
 
+
+
+
 
 stock.picking.out.form
 stock.picking.out
@@ -21,5 +24,36 @@

[Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into lp:account-invoice-report

[Lorenzo Battistini - Agile BG]

Lorenzo Battistini - Agile BG has proposed merging 
lp:~agilebg/account-invoice-report/adding_account_invoice_production_lot_7 into 
lp:account-invoice-report.

Requested reviews:
  Account Core Editors (account-core-editors)

For more details, see:
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
-- 
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
Your team OpenERP Community Reviewer is subscribed to branch 
lp:account-invoice-report.
=== added directory 'account_invoice_production_lot'
=== added file 'account_invoice_production_lot/AUTHORS.txt'
--- account_invoice_production_lot/AUTHORS.txt	1970-01-01 00:00:00 +
+++ account_invoice_production_lot/AUTHORS.txt	2013-10-15 15:41:03 +
@@ -0,0 +1,1 @@
+Lorenzo Battistini 

=== added file 'account_invoice_production_lot/__init__.py'
--- account_invoice_production_lot/__init__.py	1970-01-01 00:00:00 +
+++ account_invoice_production_lot/__init__.py	2013-10-15 15:41:03 +
@@ -0,0 +1,23 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#Copyright (C) 2011 Domsense s.r.l. (<http://www.domsense.com>).
+#Copyright (C) 2013 Agile Business Group sagl (<http://www.agilebg.com>)
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##
+
+from . import invoice

=== added file 'account_invoice_production_lot/__openerp__.py'
--- account_invoice_production_lot/__openerp__.py	1970-01-01 00:00:00 +
+++ account_invoice_production_lot/__openerp__.py	2013-10-15 15:41:03 +
@@ -0,0 +1,48 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#Copyright (C) 2011 Domsense s.r.l. (<http://www.domsense.com>).
+#Copyright (C) 2013 Agile Business Group sagl (<http://www.agilebg.com>)
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##
+
+
+{
+"name": "Invoice Production Lots",
+"version": "1.1",
+'category': 'Generic Modules/Accounting',
+"depends": [
+"sale_stock",
+"invoice_webkit",
+],
+"author": "Agile Business Group",
+"summary": "Dislpay delivered serial numbers in invoice",
+"description": """
+This module prints, for each (customer) invoice line, the delivered production
+lots. The serial numbers are displayed in the "formatted note" field,
+introduced by invoice_webkit module""",
+'website': 'http://www.agilebg.com',
+'data': [
+'invoice_view.xml',
+],
+'demo': [],
+'test': [
+'test/sale.yml',
+],
+'installable': True,
+'active': False,
+}

=== added directory 'account_invoice_production_lot/i18n'
=== added file 'account_invoice_production_lot/i18n/account_invoice_production_lot.pot'
--- account_invoice_production_lot/i18n/account_invoice_production_lot.pot	1970-01-01 00:00:00 +
+++ account_invoice_production_lot/i18n/account_invoice_production_lot.pot	2013-10-15 15:41:03 +
@@ -0,0 +1,53 @@
+# Tran

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_account_invoice_production_lot_7 into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

Review: Disapprove

Hello Pedro,
just created
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230

Thanks
-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_account_invoice_production_lot_7/+merge/181747
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/sale-wkfl/adding_sale_line_description_7 into lp:sale-wkfl

[Lorenzo Battistini - Agile BG]

Review: Approve code review


-- 
https://code.launchpad.net/~agilebg/sale-wkfl/adding_sale_line_description_7/+merge/190600
Your team Sale Core Editors is subscribed to branch lp:sale-wkfl.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~agilebg/account-invoicing/adding_account_invoice_production_lot_7 into lp:account-invoicing

[Lorenzo Battistini - Agile BG]

On 10/16/2013 04:24 PM, Joël Grand-Guillaume @ camptocamp wrote:
> We may close this review as it has move right ? In that case, you can use the 
> menu "Resubmit proposal" to change both source and destination branch while 
> keeping the history of the MP..

Thanks Joel, I didn't know that.
Yes, this MP can be closed.

But now, as the MP
https://code.launchpad.net/~agilebg/account-invoice-report/adding_account_invoice_production_lot_7/+merge/191230
 

already exists, using the 'Resubmit proposal' link will create a 
duplicated proposal I think.


-- 
https://code.launchpad.net/~agilebg/account-invoicing/adding_account_invoice_production_lot_7/+merge/181747
Your team Account Core Editors is subscribed to branch lp:account-invoicing.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp