Re: [Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/6.1-lp1376743 into lp:ocb-addons/6.1

2014-10-03 Thread Ronald Portier (Therp) 
Review: Approve code review

LGTM
-- 
https://code.launchpad.net/~hbrunn/ocb-addons/6.1-lp1376743/+merge/236886
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/6.1-lp1376743 into lp:ocb-addons/6.1

2014-10-03 Thread Pedro Manuel Baeza 
Review: Approve code review

LGTM
-- 
https://code.launchpad.net/~hbrunn/ocb-addons/6.1-lp1376743/+merge/236886
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/6.1-lp1376743 into lp:ocb-addons/6.1

2014-10-03 Thread noreply 
The proposal to merge lp:~hbrunn/ocb-addons/6.1-lp1376743 into 
lp:ocb-addons/6.1 has been updated.

Status: Needs review = Merged

For more details, see:
https://code.launchpad.net/~hbrunn/ocb-addons/6.1-lp1376743/+merge/236886
-- 
https://code.launchpad.net/~hbrunn/ocb-addons/6.1-lp1376743/+merge/236886
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/6.1-lp1376743 into lp:ocb-addons/6.1

2014-10-02 Thread Holger Brunn (Therp) 
Holger Brunn (Therp) has proposed merging lp:~hbrunn/ocb-addons/6.1-lp1376743 
into lp:ocb-addons/6.1.

Requested reviews:
  OpenERP Community Backports (ocb)
Related bugs:
  Bug #1376743 in OpenERP Community Backports (Addons): space at the end of 
user names confuse users_ldap
  https://bugs.launchpad.net/ocb-addons/+bug/1376743

For more details, see:
https://code.launchpad.net/~hbrunn/ocb-addons/6.1-lp1376743/+merge/236886
-- 
https://code.launchpad.net/~hbrunn/ocb-addons/6.1-lp1376743/+merge/236886
Your team OpenERP Community Backports is requested to review the proposed merge 
of lp:~hbrunn/ocb-addons/6.1-lp1376743 into lp:ocb-addons/6.1.
=== modified file 'users_ldap/users_ldap.py'
--- users_ldap/users_ldap.py	2013-09-10 15:12:35 +
+++ users_ldap/users_ldap.py	2014-10-02 14:09:16 +
@@ -181,7 +181,7 @@
 
 
 user_id = False
-login = tools.ustr(login.lower())
+login = tools.ustr(login.lower().strip())
 cr.execute(SELECT id, active FROM res_users WHERE login=%s, (login,))
 res = cr.fetchone()
 if res:

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/6.1-lp1376743 into lp:ocb-addons/6.1

2014-10-02 Thread Holger Brunn (Therp) 
see https://github.com/odoo/odoo/pull/2865
-- 
https://code.launchpad.net/~hbrunn/ocb-addons/6.1-lp1376743/+merge/236886
Your team OpenERP Community Backports is requested to review the proposed merge 
of lp:~hbrunn/ocb-addons/6.1-lp1376743 into lp:ocb-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~hbrunn/ocb-addons/6.1-lp1376743 into lp:ocb-addons/6.1

2014-10-02 Thread Stefan Rijnhart (Therp) 
Review: Approve

Thanks!
-- 
https://code.launchpad.net/~hbrunn/ocb-addons/6.1-lp1376743/+merge/236886
Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp