Re: [Openerp-community-reviewer] [Merge] lp:~jeffery9/oemedical/oemedical into lp:oemedical
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/vertical-medical Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how to proceed. Thanks for contributing to the project -- https://code.launchpad.net/~jeffery9/oemedical/oemedical/+merge/194051 Your team OEmedical Commiter is subscribed to branch lp:oemedical. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~jeffery9/oemedical/oemedical into lp:oemedical
I set this one WIP as there was no activity from author -- https://code.launchpad.net/~jeffery9/oemedical/oemedical/+merge/194051 Your team OEmedical Commiter is subscribed to branch lp:oemedical. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~jeffery9/oemedical/oemedical into lp:oemedical
The proposal to merge lp:~jeffery9/oemedical/oemedical into lp:oemedical has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~jeffery9/oemedical/oemedical/+merge/194051 -- https://code.launchpad.net/~jeffery9/oemedical/oemedical/+merge/194051 Your team OEmedical Commiter is subscribed to branch lp:oemedical. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~jeffery9/oemedical/oemedical into lp:oemedical
Review: Needs Fixing code review, no tests Same as Pedro, please remove the import line. Otherwise as we talk about import you could also improve from osv import fields, osv by repacing it with from openerp.osv import fields, osv -- https://code.launchpad.net/~jeffery9/oemedical/oemedical/+merge/194051 Your team OEmedical Commiter is subscribed to branch lp:oemedical. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~jeffery9/oemedical/oemedical into lp:oemedical
jeffery chen fan has proposed merging lp:~jeffery9/oemedical/oemedical into lp:oemedical. Requested reviews: OEmedical Commiter (oemedical-commiter) For more details, see: https://code.launchpad.net/~jeffery9/oemedical/oemedical/+merge/194051 fix xml data loading order and wrong import -- https://code.launchpad.net/~jeffery9/oemedical/oemedical/+merge/194051 Your team OEmedical Commiter is requested to review the proposed merge of lp:~jeffery9/oemedical/oemedical into lp:oemedical. === modified file 'oemedical/__openerp__.py' --- oemedical/__openerp__.py 2013-09-23 18:29:30 + +++ oemedical/__openerp__.py 2013-11-06 02:46:12 + @@ -139,9 +139,9 @@ 'oemedical_genetics/oemedical_disease_gene_view.xml', 'oemedical_genetics/data/disease_genes.xml', 'oemedical_socioeconomics/oemedical_socioeconomics_view.xml', -'oemedical_lab/oemedical_lab_view.xml', 'security/ir.model.access.csv', 'oemedical_menu.xml', +'oemedical_lab/oemedical_lab_view.xml', ], demo: [ === modified file 'oemedical/oemedical_lab/oemedical_lab.py' --- oemedical/oemedical_lab/oemedical_lab.py 2013-09-23 18:55:14 + +++ oemedical/oemedical_lab/oemedical_lab.py 2013-11-06 02:46:12 + @@ -17,7 +17,7 @@ import time -from mx import DateTime +#from mx import DateTime import datetime from osv import fields, osv from tools.translate import _ -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
