[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1
The proposal to merge lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1 has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070 -- https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1
The proposal to merge lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1 has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070 -- https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1
Alexis de Lattre has proposed merging lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1. Requested reviews: Account Report Core Editors (account-report-core-editor) Related bugs: Bug #1274194 in Account - Financial Report: Wrong balance formula in trial balance xls when using date filter https://bugs.launchpad.net/account-financial-report/+bug/1274194 For more details, see: https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070 Same as this MP https://code.launchpad.net/~akretion-team/account-financial-report/70-fix-bug-1274194-webkit-xls/+merge/217063 but for the 6.1 branch. -- https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070 Your team Account Report Core Editors is requested to review the proposed merge of lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1. === modified file 'account_financial_report_webkit_xls/report/trial_balance_xls.py' --- account_financial_report_webkit_xls/report/trial_balance_xls.py 2014-01-27 14:32:33 + +++ account_financial_report_webkit_xls/report/trial_balance_xls.py 2014-04-24 15:24:58 + @@ -218,9 +218,9 @@ ('account', account_span, 0, 'text', current_account.name), ] if _p.comparison_mode == 'no_comparison': - -debit_cell = rowcol_to_cell(row_pos, 3) -credit_cell = rowcol_to_cell(row_pos, 4) + +debit_cell = rowcol_to_cell(row_pos, 4) +credit_cell = rowcol_to_cell(row_pos, 5) bal_formula = debit_cell + '-' + credit_cell if _p.initial_balance_mode: -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1
Review: Approve code review Also OK. Thanks. -- https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls into lp:account-financial-report/6.1
Review: Approve code review tested the 7.0 branche -- https://code.launchpad.net/~akretion-team/account-financial-report/61-fix-bug-1274194-webkit-xls/+merge/217070 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp