[Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Alexandre Fayolle - camptocamp]

The proposal to merge 
lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search
 into lp:account-financial-tools has been updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Pedro Manuel Baeza]

Pedro Manuel Baeza has proposed merging 
lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search
 into lp:account-financial-tools.

Requested reviews:
  Account Core Editors (account-core-editors)

For more details, see:
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092

New module account_account_extended_search that allows to search any account 
with the character '.' inside as a wildcard.
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.
=== added directory 'account_account_extended_search'
=== added file 'account_account_extended_search/__init__.py'
--- account_account_extended_search/__init__.py	1970-01-01 00:00:00 +
+++ account_account_extended_search/__init__.py	2013-12-27 09:29:33 +
@@ -0,0 +1,28 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#Copyright (c) All rights reserved:
+#(c) 2008-2010 Zikzakmedia S.L. (http://zikzakmedia.com)
+#  Jordi Esteve 
+#(c) 2013  Joan M. Grande 
+#(c) 2013  Anubía, soluciones en la nube,SL (http://www.anubia.es)
+#  Alejandro Santana 
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+from . import account

=== added file 'account_account_extended_search/__openerp__.py'
--- account_account_extended_search/__openerp__.py	1970-01-01 00:00:00 +
+++ account_account_extended_search/__openerp__.py	2013-12-27 09:29:33 +
@@ -0,0 +1,67 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#
+#Copyright (c) All rights reserved:
+#(c) 2008-2010 Zikzakmedia S.L. (http://zikzakmedia.com)
+#  Jordi Esteve 
+#(c) 2013  Joan M. Grande 
+#(c) 2013  Anubía, soluciones en la nube,SL (http://www.anubia.es)
+#  Alejandro Santana 
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+{
+"name": "Spanish account tools",
+"version": "3.2",
+"category": "Localization/Accounting",
+"description": """
+Adds several tools to help Spanish accountants:
+===
+
+  * Searching of accounts using a dot to fill the zeroes (e.g. 43.27 to search
+account 4327).
+  * The account chart template field is added to account templates, tax
+templates, tax codes templates and fiscal positions templates in list and
+search views. It helps to filter the template items by the account chart
+template that they belong.
+
+""",
+# "complexity": "normal",
+"license": "AGPL-3",
+"author": "Spanish Localization Team",
+"website": "https://launchpad.net/openerp-spain";,
+"contributors": [
+"Jordi Esteve ",
+"Joan M. Grande ",
+"Alejandro Santana ",
+],
+"depends": [
+"l10n_es",
+],
+"data": [
+"account_view.xml",
+],
+"demo": [],
+"test": [],
+"images": [],
+"active": False,
+"installable": True,
+"application": False,
+"auto_install": False,
+"certificate": ""

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Stefan Rijnhart (Therp)]

Guewen and Frederic, do the responses satisfy your information requests? Also, 
anyone else has an opinion about the name of the module?

-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Alejandro Santana]

Review: Needs Information

Maybe the wildcard could be made configurable.
This way, Spanish accountants could use a dot (.), as they are so used to. And 
in other countries it could be configured to be other character, like asterisk 
(*) or any other.
Also, the pattern to search could be configurable too, or maybe modified to 
accept finding dots. Right now it searches for zeroes only. Not sure what to 
allow, though. What would be the needs in other countries?

What do you think? That way its case of use broadens to almost? every country.
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Frederic Clementi - Camptocamp]

Personally, I have been practicing accounting in UK, France and Switzerland and 
I have never used a search based on dots. So +1 for something more configurable 
(hence, more generic and potentially used by more people).

If not possible, like Stefan said, we should give a more specific name (like 
maybe : account_wildcard_dot_search)


Frederic

-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Yannick Vaucher @ Camptocamp]

Review: Needs Fixing

I set as need fixing after Frederic's comment
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Alexandre Fayolle - camptocamp]

setting the MP as work in progress. Please set it back to "needs review" when 
requested changes are made. 
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Pedro Manuel Baeza]

Review: Needs Fixing code review

Alejandro, please fix these things:

- Remove all the chart template stuff, that doesn't belong to this module.
- Change module name and description in manifest file accordingly.
- Restart the version numbering to 1.0.
- Remove comment about templates at the beginning in account.py.
- Change the icon to one that is not duplicated from standard ones. You can 
make a slightly variation, for example.
- Remove 'l10n_es' as dependency and add 'account'.
- Remove template views modifications.
- Rebuild translations.

Thank you very much.

Regards.
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Alejandro Santana]

Review: Needs Information

So, in a nutshell, keep only the search via dot wildcard functionality, isn't 
it?
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Pedro Manuel Baeza]

Yeah, that is!
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Alejandro Santana]

Review: Resubmit

Changes made.
Yet I am not able to load module description translation after installing it.
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Pedro Manuel Baeza]

Review: Needs Fixing

Hi, Alejandro, there is still some stuff from the previous functionality: you 
can safely remove account_account_view.xml file, because it contains only 
reference to chart_template_id stuff and it's not referenced in manifest file.

As I told you in another message, translations are always handle on base 
module, so you are not going to be able to load any translation from the module 
itself. You can remove also i18n directory then.

Regards.
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Alejandro Santana]

Review: Resubmit

Done.
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Pedro Manuel Baeza]

Review: Approve

Perfect! Thank you very much.

Regards
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Alejandro Santana]

Always welcome.

Alejandro Santana
alejandrosant...@anubia.es
~
ANUBÍA, soluciones en la nube, S.L.
www.anubia.es
 El 30/12/2013 15:37, "Pedro Manuel Baeza"  escribió:

> Review: Approve
>
> Perfect! Thank you very much.
>
> Regards
> --
>
> https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
> You are the owner of
> lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search.
>

-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Graeme Gellatly]

Review: Approve (code review, no test)

LGTM!
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Guewen Baconnier @ Camptocamp]

Review: Needs Information

Is it something only used in spain? Do you have an idea?
(If yes wouldn't it be better to put it in the Spanish localization?)
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Pedro Manuel Baeza]

Hi, Guewen, it is used in Spain, but it's a generic tool useful for anyone that 
has complex account charts (some countries on South America, and so on).

Regards.
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Frederic Clementi - Camptocamp]

Review: Needs Information

Hello, I find this features really great but why using a . instead of a * for 
example which is more commonly used.

It is also a shame for us in switzerland since the structure of ou chart can be 
something like:

10.0
  101.0
1000
1001
  102.0

...So if I am looking for a account of the account 101.0 the result will be 
101.0, 1000, 1001.
Am I correct ?


Thanks
  



-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Alejandro Santana]

Hello. It comes from the usage in Spain, where accounts in chart have no dots 
(.) and probably 99% of accountants expect and demand the dot as a wildcard.
I am not sure about the current behaviour on accounts with dots, like Swiss one 
you comment. I will give it a try.

One thought: Maybe the wildcard used could be selected or specified somewhere 
('.', '*', other?). That way would fit in both scenarios (and maybe others).
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Alejandro Santana]

@Frederic
OK, tested and also took a look at the code again. Right now, when using a dot 
in the search it serves as a wildcard for zeroes. 
So in your example if you search 101.0, you would find: 101.0, 1010, 1010, 
101(any number of zeroes or the dot itself)0, but not 1001.
Also, if you search for 102.1, it will not find 102.01

Its original goal is to be used for accounts like 4721, 4722... (fixed 
digists), so you could search 472.1 and find 4721, typing no zeroes.
-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search into lp:account-financial-tools

[Stefan Rijnhart (Therp)]

Review: Needs Information

Code looks good to me, and it's working fine. It looks to me like a very 
specific use case, which also does not apply to Dutch accounting habits but it 
may be broader than just Spanish (you never know, right?) so I think having the 
module here is fine.

What bothers me a little is the module name. Yes, it extends the search but it 
does so in a very specific way. Would you consider to change the name to 
something like "account_account_wildcard_zero_search"?


-- 
https://code.launchpad.net/~alejandrosantana/account-financial-tools/7.0-account-financial_tools--add--account_account_extended_search/+merge/200092
Your team OpenERP Community Reviewer/Maintainer is subscribed to branch 
lp:account-financial-tools.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp