Re: [Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web_fields_masks into lp:web-addons
Review: Needs Fixing You should put library files into /static/lib (why? If another module uses the same library, it would be loaded twice otherwise and is likely to clash) Further, #2492 means we can't have apostrophes or quotes in the input mask. Why don't you simply eval() this attribute? This way, the user can fill in either a simple input mask or an object as applicable? What would be nice is if you set the standard OpenERP error class (oe_form_invalid) if the user's input doesn't match the mask. -- https://code.launchpad.net/~aristobulo/web-addons/web_fields_masks/+merge/219084 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web_fields_masks into lp:web-addons
Review: Approve code and test We have been testing it and is working flawlessly... -- https://code.launchpad.net/~aristobulo/web-addons/web_fields_masks/+merge/219084 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web_fields_masks into lp:web-addons
Hi, what is still pending for this MP? I'd be glad to keep track of one less branch... Regards, -Mario -- https://code.launchpad.net/~aristobulo/web-addons/web_fields_masks/+merge/219084 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~aristobulo/web-addons/web_fields_masks into lp:web-addons
Review: Needs Fixing test Don't know what happened, but now it is not triggering the mask check. I had to re-create my test environments and when reinstalled it didn't work anymore... -- https://code.launchpad.net/~aristobulo/web-addons/web_fields_masks/+merge/219084 Your team Web-Addons Core Editors is subscribed to branch lp:web-addons. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
