Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting
Review: Approve LGTM. -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix_red_test-afe/+merge/224581 Your team Account Core Editors is requested to review the proposed merge of lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting
Alexandre Fayolle - camptocamp has proposed merging
lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting.
Requested reviews:
Account Core Editors (account-core-editors)
Related bugs:
Bug #1334605 in Account - Budgeting: budget: tests are red
https://bugs.launchpad.net/account-budgeting/+bug/1334605
For more details, see:
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix_red_test-afe/+merge/224602
fix failing test
I think the failure is caused by a typo in the test source code.
--
https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix_red_test-afe/+merge/224602
Your team Account Core Editors is requested to review the proposed merge of
lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting.
=== modified file 'budget/test/analytic_amount.yml'
--- budget/test/analytic_amount.yml 2014-04-23 13:53:39 +
+++ budget/test/analytic_amount.yml 2014-06-26 11:51:38 +
@@ -60,5 +60,5 @@
line = self.browse(cr, uid, ref('budget_line_1'))
assert abs(line.analytic_amount + 200.0) 1e-4, Analytic amount is not correct! -200.0 != %s % line.analytic_amount
assert abs(line.analytic_real_amount + 12.0) 1e-4, Analytic real amount is not correct! -12.0 != %s % line.analytic_real_amount
-assert abs(line.analytic_diff_amount + 188.0) 1e-4, Analytic diff amount is not correct! 188.0 != %s % line.analytic_diff_amount
+assert abs(line.analytic_diff_amount - 188.0) 1e-4, Analytic diff amount is not correct! 188.0 != %s % line.analytic_diff_amount
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting
Review: Approve code review LGTM too, Romain -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix_red_test-afe/+merge/224602 Your team Account Core Editors is requested to review the proposed merge of lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting
The proposal to merge lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix_red_test-afe/+merge/224602 -- https://code.launchpad.net/~camptocamp/account-budgeting/7.0-fix_red_test-afe/+merge/224602 Your team Account Core Editors is requested to review the proposed merge of lp:~camptocamp/account-budgeting/7.0-fix_red_test-afe into lp:account-budgeting. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
