[Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh into lp:account-financial-report
The proposal to merge lp:~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh into lp:account-financial-report has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh/+merge/214905 -- https://code.launchpad.net/~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh/+merge/214905 Your team Account Report Core Editors is requested to review the proposed merge of lp:~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh into lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh into lp:account-financial-report
Review: Approve functional LGTM -- https://code.launchpad.net/~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh/+merge/214905 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh into lp:account-financial-report
Review: Needs Fixing code review, no test please add an automated test which exercises the new code, so that we can at least easily check that it does not crash. -- https://code.launchpad.net/~camptocamp/account-financial-report/7.0-add-reference-field-xls-mdh/+merge/214905 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
