[Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into lp:openerp-product-attributes

[Alexandre Fayolle - camptocamp]

Alexandre Fayolle - camptocamp has proposed merging 
lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into 
lp:openerp-product-attributes.

Requested reviews:
  Product Core Editors (product-core-editors)

For more details, see:
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe/+merge/222760

replace product_gtin with chricar_product_gtin (from c2c-rd-addons), which 
works (whereas the existing module was not installable). 

I ported the history of changes of that addon using bazaar-extractor, and 
Alexis de Lattre did the actual porting to V7 + OCA coding standards
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe/+merge/222760
Your team Product Core Editors is requested to review the proposed merge of 
lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into 
lp:openerp-product-attributes.
=== added directory 'product_gtin'
=== removed directory 'product_gtin'
=== added file 'product_gtin/__init__.py'
--- product_gtin/__init__.py	1970-01-01 00:00:00 +
+++ product_gtin/__init__.py	2014-06-11 08:42:55 +
@@ -0,0 +1,26 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Product GTIN module for OpenERP
+#Copyright (c) 2004 TINY SPRL. (http://tiny.be) All Rights Reserved.
+#   Fabien Pinckaers 
+#Copyright (c) 2008 ChriCar Beteilugungs- und Beratungs- GmbH
+#   All Rights Reserved.
+#   Ferdinand Gassauer 
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+
+from . import product_gtin

=== removed file 'product_gtin/__init__.py'
--- product_gtin/__init__.py	2009-04-09 07:06:02 +
+++ product_gtin/__init__.py	1970-01-01 00:00:00 +
@@ -1,31 +0,0 @@
-##
-#
-# Copyright (c) 2004 TINY SPRL. (http://tiny.be) All Rights Reserved.
-#Fabien Pinckaers 
-# Copyright (c) 2008 ChriCar Beteilugungs- und Beratungs- GmbH All Rights Reserved.
-#Ferdinand Gassauer 
-#
-# WARNING: This program as such is intended to be used by professional
-# programmers who take the whole responsability of assessing all potential
-# consequences resulting from its eventual inadequacies and bugs
-# End users who are looking for a ready-to-use solution with commercial
-# garantees and support are strongly adviced to contract a Free Software
-# Service Company
-#
-# This program is Free Software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License
-# as published by the Free Software Foundation; either version 2
-# of the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
-#
-##
-
-import product_gtin
\ No newline at end of file

=== added file 'product_gtin/__openerp__.py'
--- product_gtin/__openerp__.py	1970-01-01 00:00:00 +
+++ product_gtin/__openerp__.py	2014-06-11 08:42:55 +
@@ -0,0 +1,39 @@
+# -*- coding: utf-8 -*-
+##
+#
+#Product GTIN module for OpenERP
+#Copyright (C) 2004-2011 Tiny SPRL ().
+#Copyright (C) 2010-2011 Camptocamp Austria ()
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warrant

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into lp:openerp-product-attributes

[Quentin THEURET @TeMPO Consulting]

LGTM
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe/+merge/222760
Your team Product Core Editors is requested to review the proposed merge of 
lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into 
lp:openerp-product-attributes.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into lp:openerp-product-attributes

[Alexis de Lattre]

Review: Approve code review and test

Alexandre, could you replay my commit revno 249 in the branch 
lp:~akretion-team/openerp-product-attributes/70-update-and-fix-product-gtin ; 
it's a small code simplification.
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe/+merge/222760
Your team Product Core Editors is requested to review the proposed merge of 
lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into 
lp:openerp-product-attributes.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into lp:openerp-product-attributes

[Alexis de Lattre]

Review: Approve code review and test

BTW, for those who want to make EAN8 work in the POS, here is the patch for 
odoo master :

http://people.via.ecp.fr/~alexis/ean8-pos-works.diff
-- 
https://code.launchpad.net/~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe/+merge/222760
Your team Product Core Editors is requested to review the proposed merge of 
lp:~camptocamp/openerp-product-attributes/7.0-add_product_gtin-afe into 
lp:openerp-product-attributes.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp