[Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows
Romain Deheele - Camptocamp has proposed merging lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows. Requested reviews: Stock and Logistic Core Editors (stock-logistic-core-editors) For more details, see: https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers/+merge/223529 Hello, stock_cancel addon introduces a button named "re-open" that allows to re-open a done or canceled picking. It seems that in practical it's safer to restrict this feature to warehouse managers. What do you think about it? Feel free to share your opinion, Romain -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers/+merge/223529 Your team Stock and Logistic Core Editors is requested to review the proposed merge of lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows. === modified file 'stock_cancel/stock_view.xml' --- stock_cancel/stock_view.xml 2013-06-05 14:38:18 + +++ stock_cancel/stock_view.xml 2014-06-18 09:46:16 + @@ -8,7 +8,8 @@ - + @@ -19,7 +20,8 @@ - + @@ -30,7 +32,8 @@ - + -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows
Review: Needs Information code review Well, I think that this function is both used by warehouse managers and users: I see not much sense to contact a manager to reopen one picking canceled by error. But maybe for done pickings, re-open task is more sensible. What do you think? Regards. -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers/+merge/223529 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows
Your remark makes sense about canceled pickings. Maybe it's better to let freedom to developers to specify access rights/visibility according to the context. -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers/+merge/223529 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers into lp:stock-logistic-flows
Review: Resubmit The source code management for this project has been moved to https://github.com/OCA/stock-logistics-workflow Could you resubmit this MP on the new site? -- https://code.launchpad.net/~camptocamp/stock-logistic-flows/7.0-stock_cancel_restrict_reopen_button_to_wh_managers/+merge/223529 Your team Stock and Logistic Core Editors is subscribed to branch lp:stock-logistic-flows. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
