Re: [Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
Review: Approve code review Hi, Etienne, Thanks for the new MP. Although I wonder why are you still modifying priority on stock.move.tree3, I'm not going to block the MP for this question, because I don't think that this alters behaviour on possible modules relying on that view. Regards. -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222726 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
Dear Pedro, Thanks for the approval. As you mentioned correctly not to remove stock.move.tree3 in a stable version, I wanted to make clear that this view is less important by changing the priority. But I agree it has no effect. BestRegards Etienne On 11.06.2014 08:18, Pedro Manuel Baeza wrote: Review: Approve code review Hi, Etienne, Thanks for the new MP. Although I wonder why are you still modifying priority on stock.move.tree3, I'm not going to block the MP for this question, because I don't think that this alters behaviour on possible modules relying on that view. Regards. -- ++ Dr. Etienne Hirt Art of Technology Director RD www.art-of-technology.ch Technoparkstrasse 1 Ph: +41-43-311 77 02 8005 Zurich Sw: +41-43-311 77 00 Switzerland Skype: etiennehirt == https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222726 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
Review: Needs Fixing Thanks! Agree with Pedro. Apart from that, the diff looks odd with its executable permission changes. Could you revert those? -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
The proposal to merge lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1 has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
Etienne Hirt has proposed merging lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports (ocb) Related bugs: Bug #1327887 in OpenERP Community Backports (Addons): [6.1] stock.move.tree2 wrong priority, stock.move.tree3 leftover https://bugs.launchpad.net/ocb-addons/+bug/1327887 For more details, see: https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222726 request merge again after addressing review comments -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222726 Your team OpenERP Community Backports is requested to review the proposed merge of lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1. === modified file 'stock/stock_view.xml' --- stock/stock_view.xml 2013-09-10 15:12:35 + +++ stock/stock_view.xml 2014-06-10 20:30:27 + @@ -1536,7 +1536,7 @@ field name=namestock.move.tree2/field field name=modelstock.move/field field name=typetree/field -field name=priority eval=6 / +field name=priority eval=18 / field name=arch type=xml tree colors=grey:state == 'cancel' string=Moves field name=picking_id string=Reference/ @@ -1576,7 +1576,7 @@ field name=namestock.move.tree3/field field name=modelstock.move/field field name=typetree/field -field eval=6 name=priority/ +field eval=20 name=priority/ field name=arch type=xml tree string=Moves field name=picking_id string=Reference/ -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
The proposal to merge lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1 has been updated. Status: Merged = Rejected For more details, see: https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
See new MP: https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222726 -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
Review: Needs Fixing code review The change on priority LGTM, but there are two things that you have to fix: - You cannot remove a view from an stable version, because maybe someone has constructed an inherited view around it in his custom module. Please keep it, although it is a leftover view. - Change executable flags on a separate MP. Regards. -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 Your team OpenERP Community Backports is subscribed to branch lp:ocb-addons/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
[Openerp-community-reviewer] [Merge] lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1
Etienne Hirt has proposed merging lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1. Requested reviews: OpenERP Community Backports (ocb) Related bugs: Bug #1327887 in OpenERP Community Backports (Addons): [6.1] stock.move.tree2 wrong priority, stock.move.tree3 leftover https://bugs.launchpad.net/ocb-addons/+bug/1327887 For more details, see: https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 * change stock.move.tree2 to 18 as directly referenced when used * remove stock.move.tree3 as a leftover from a test -- https://code.launchpad.net/~hirt/ocb-addons/6.1_stock-move-tree/+merge/222463 Your team OpenERP Community Backports is requested to review the proposed merge of lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1. === modified file 'account_asset/i18n/ca.po' (properties changed: +x to -x) === modified file 'account_asset/i18n/de.po' (properties changed: +x to -x) === modified file 'account_asset/i18n/es.po' (properties changed: +x to -x) === modified file 'account_asset/i18n/es_CR.po' (properties changed: +x to -x) === modified file 'account_asset/i18n/fr.po' (properties changed: +x to -x) === modified file 'account_asset/i18n/fr_BE.po' (properties changed: +x to -x) === modified file 'account_asset/i18n/pl.po' (properties changed: +x to -x) === modified file 'account_asset/i18n/pt.po' (properties changed: +x to -x) === modified file 'account_asset/i18n/sv.po' (properties changed: +x to -x) === modified file 'account_asset/security/ir.model.access.csv' (properties changed: +x to -x) === modified file 'account_asset/wizard/__init__.py' (properties changed: +x to -x) === modified file 'account_asset/wizard/account_asset_change_duration.py' (properties changed: +x to -x) === modified file 'account_asset/wizard/wizard_asset_compute.py' (properties changed: +x to -x) === modified file 'base_report_designer/plugin/openerp_report_designer/bin/OOo_run.sh' (properties changed: +x to -x) === modified file 'document/odt2txt.py' (properties changed: +x to -x) === modified file 'document/test_cindex.py' (properties changed: +x to -x) === modified file 'document_ftp/ftpserver/ftpserver.py' (properties changed: +x to -x) === modified file 'document_webdav/test_davclient.py' (properties changed: +x to -x) === modified file 'email_template/html2text.py' (properties changed: +x to -x) === modified file 'l10n_ch/report/ocrbb.ttf' (properties changed: +x to -x) === modified file 'l10n_ch/test/test.v11' (properties changed: +x to -x) === modified file 'l10n_ch/test/test_part_1.v11' (properties changed: +x to -x) === modified file 'l10n_ch/test/test_part_2.v11' (properties changed: +x to -x) === modified file 'mail/static/scripts/openerp_mailgate.py' (properties changed: +x to -x) === modified file 'plugin_thunderbird/static/thunderbird_plugin/install.sh' (properties changed: +x to -x) === modified file 'purchase/wizard/purchase_line_invoice.py' (properties changed: +x to -x) === modified file 'purchase_double_validation/test/purchase_double_validation_test.yml' (properties changed: +x to -x) === modified file 'purchase_requisition/test/purchase_requisition_demo.yml' (properties changed: +x to -x) === modified file 'stock/stock_view.xml' --- stock/stock_view.xml 2013-09-10 15:12:35 + +++ stock/stock_view.xml 2014-06-08 21:56:37 + @@ -1536,7 +1536,7 @@ field name=namestock.move.tree2/field field name=modelstock.move/field field name=typetree/field -field name=priority eval=6 / +field name=priority eval=18 / field name=arch type=xml tree colors=grey:state == 'cancel' string=Moves field name=picking_id string=Reference/ @@ -1571,26 +1571,6 @@ /tree /field /record -!-- test -- - record id=view_move_tree_reception_picking_board model=ir.ui.view -field name=namestock.move.tree3/field -field name=modelstock.move/field -field name=typetree/field -field eval=6 name=priority/ -field name=arch type=xml -tree string=Moves -field name=picking_id string=Reference/ -field name=partner_id string=Partner/ -field name=product_id/ -field name=product_qty / -field name=product_uom string=UoM/ -field name=date/ -field name=state/ -button name=action_done states=confirmed,assigned string=Process type=object icon=gtk-go-forward/ -/tree -/field -/record - record id=view_move_form_reception_picking model=ir.ui.view field name=namestock.move.form2/field === modified file 'wiki/static/src/lib/wiky/Readme.md' (properties changed: +x to -x) === modified file 'wiki/static/src/lib/wiky/autogit.sh' (properties changed: +x
