[Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-report/6.1-balance-reporting into lp:account-financial-report/6.1
The proposal to merge lp:~pedro.baeza/account-financial-report/6.1-balance-reporting into lp:account-financial-report/6.1 has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~pedro.baeza/account-financial-report/6.1-balance-reporting/+merge/183114 -- https://code.launchpad.net/~pedro.baeza/account-financial-report/6.1-balance-reporting/+merge/183114 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-report/6.1-balance-reporting into lp:account-financial-report/6.1
Review: Needs Fixing I would really love to see this code exercised by a couple of yaml tests... -- https://code.launchpad.net/~pedro.baeza/account-financial-report/6.1-balance-reporting/+merge/201166 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-report/6.1-balance-reporting into lp:account-financial-report/6.1
Review: Needs Fixing code review Hello Pedro, Please fix PEP8 issues given by flake8 and consider translating the spanish comments in the code (l257). Otherwise LGTM. Thanks! -- https://code.launchpad.net/~pedro.baeza/account-financial-report/6.1-balance-reporting/+merge/183114 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-report/6.1-balance-reporting into lp:account-financial-report/6.1
Review: Needs Information
Hello,
I cannot print the report, I get the folowing error...
Traceback (most recent call last):
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/service/web_services.py",
line 727, in go
(result, format) = obj.create(cr, uid, ids, datas, context)
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/report_sxw.py",
line 440, in create
fnct_ret = fnct(cr, uid, ids, data, report_xml, context)
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/report_sxw.py",
line 509, in create_source_pdf
return self.create_single_pdf(cr, uid, ids, data, report_xml, context)
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/report_sxw.py",
line 531, in create_single_pdf
pdf =
create_doc(etree.tostring(processed_rml),rml_parser.localcontext,logo,title.encode('utf8'))
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/interface.py",
line 207, in create_pdf
obj.render()
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/render.py",
line 59, in render
self._result = self._render()
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml.py",
line 41, in _render
return rml2pdf.parseNode(self.rml, self.localcontext,
images=self.bin_datas, path=self.path,title=self.title)
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py",
line 1007, in parseNode
r.render(fp)
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py",
line 314, in render
pt_obj.render(el)
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py",
line 983, in render
fis += r.render(node_story)
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py",
line 877, in render
return process_story(node_story)
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py",
line 870, in process_story
flow = self._flowable(node)
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py",
line 793, in _flowable
return self._table(node)
File
"/home/vrenaville/tmpinstance/61Uptodate/src/server/openerp/report/render/rml2pdf/trml2pdf.py",
line 697, in _table
assert length == len(node.get('colWidths').split(','))
AssertionError
I set a very basic template with just 1 as value in fy 1. Balance mode
Debit-credit...and print the report for the fy 2013 (no fy 2)
Any idea ?
Frederic
--
https://code.launchpad.net/~pedro.baeza/account-financial-report/6.1-balance-reporting/+merge/183114
Your team Account Report Core Editors is subscribed to branch
lp:account-financial-report/6.1.
--
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~pedro.baeza/account-financial-report/6.1-balance-reporting into lp:account-financial-report/6.1
Hi, I have made some improvements in the code. Please try again to see if all is correct. Regards. -- https://code.launchpad.net/~pedro.baeza/account-financial-report/6.1-balance-reporting/+merge/183114 Your team Account Report Core Editors is subscribed to branch lp:account-financial-report/6.1. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
