Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/server-env-tools/base_module_record into lp:server-env-tools
Review: Needs Fixing code review, no tests Never used it, code looks shaggy, and there are not tests. Are there known issues? In it's current state, this module is not on par with the standards of OCA and it needs care and love. If someone has use for this module and is volunteering to maintain it, I'm willing to perform a detailed review of the code and help that person to improve the module. -- https://code.launchpad.net/~serpentcs/server-env-tools/base_module_record/+merge/196613 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/server-env-tools/base_module_record into lp:server-env-tools
Review: Disapprove code review, no tests Hi, Thanks for the work. I'm wondering why OpenERP SA dropped this module. Seems like, at least on my experience, it was producing a very randomized result and never really succeed to use it... So, for my own opinion, I'm not in favor of taking it here under the community umbrella. But if other people want to, then say it and I may change my mind. In the meanwhile I disapprove that MP. Regards, Joël -- https://code.launchpad.net/~serpentcs/server-env-tools/base_module_record/+merge/196613 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/server-env-tools/base_module_record into lp:server-env-tools
Review: Disapprove The problem with this module is IMHO that you need a very controlled environment to get results from it, and doesn't fulfill all the requirements that a "module creator" must have, so I also vote for having out from OCA repositories. If not, we can receive a lot of bugs reports for this or that thing from unexperienced users that believe that this module resolves all their problems. Regards. -- https://code.launchpad.net/~serpentcs/server-env-tools/base_module_record/+merge/196613 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/server-env-tools/base_module_record into lp:server-env-tools
Sounds alright if community feels so. Let this be out of server-env-tools, yet available for end users to use if they wish. Thank you guys, appreciate your efforts and time on this. -- https://code.launchpad.net/~serpentcs/server-env-tools/base_module_record/+merge/196613 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/server-env-tools/base_module_record into lp:server-env-tools
Review: Needs Information Interesting. I would not have judged so hard on this module. Then again, I only ever used it to export data that was at that time easier for me to configure in the interface than in XML, such as email templates. I don't use it anymore, but I would not mind keeping it in a community repository where it has the chance to improve. So I'm voting needs information, but to ask from other reviewers if anyone else thinks this one can be saved. -- https://code.launchpad.net/~serpentcs/server-env-tools/base_module_record/+merge/196613 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/server-env-tools/base_module_record into lp:server-env-tools
Review: Approve module used, no code review Hi, I used this module some times in V7, like Stephen to export datas (demo or not) and only for that this module is very usefull. For exemple to write this file, that populate french departments, (http://bazaar.launchpad.net/~sylvain-legal/openerp-grap-shared/7.0/view/head:/l10n_fr_res_department/data/res_country_department_fr_data.yml), I earned an hour of work. My PoV is : "better something than nothing", and even if this module receive a lot of bug reports, it doesn't really matter because it's a tools only for admin user. My 2 cents. -- https://code.launchpad.net/~serpentcs/server-env-tools/base_module_record/+merge/196613 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/server-env-tools/base_module_record into lp:server-env-tools
The Core and simple purpose of the module is to save your job of writing the simple yml n xml files. OpenERP does not have a UI editor as of now, so this module does the job! -- https://code.launchpad.net/~serpentcs/server-env-tools/base_module_record/+merge/196613 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/server-env-tools/base_module_record into lp:server-env-tools
Review: Abstain Hello, I let the other decide. Basically my PoV is that this is a shitty module that will remain a shitty module because it produces output that you should reprocess quite a lot manually. Now if some find it useful, why not. -- https://code.launchpad.net/~serpentcs/server-env-tools/base_module_record/+merge/196613 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~serpentcs/server-env-tools/base_module_record into lp:server-env-tools
Review: Abstain Never used that module -- https://code.launchpad.net/~serpentcs/server-env-tools/base_module_record/+merge/196613 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
