Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical_refactoring_step_I into lp:oemedical
Review: Resubmit Hello, The management of the project has moved to Github: https://github.com/OCA/vertical-medical Please migrate your merge proposal to Github. You may want to check https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub for an explanation on how to proceed. Thanks for contributing to the project -- https://code.launchpad.net/~the-clone-master/oemedical/oemedical_refactoring_step_I/+merge/202240 Your team OEmedical Commiter is subscribed to branch lp:oemedical. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical_refactoring_step_I into lp:oemedical
Review: Needs Fixing code review l.391 could you search the group with it's xml id group_oemedical_doctor instead of the name ? Be careful, in xml you have a mix of spaces and tabs keep only spaces. -- https://code.launchpad.net/~the-clone-master/oemedical/oemedical_refactoring_step_I/+merge/202240 Your team OEmedical Commiter is subscribed to branch lp:oemedical. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical_refactoring_step_I into lp:oemedical
Review: Needs Information Hi, Mario, Thanks for your great efforts to bring this project to a usable state. Waiting for a deeper review, I have seen something that flash me and want you to tell: you told about a new module called oemedical_first_name to split personal names in two, but this functionality is already present in module partner_first_name on partner-contact-management OCA repository, so I would prefer to use this module to join efforts in its maintenance and adapt OE to its use when required. What do you think? Regards. -- https://code.launchpad.net/~the-clone-master/oemedical/oemedical_refactoring_step_I/+merge/202240 Your team OEmedical Commiter is subscribed to branch lp:oemedical. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~the-clone-master/oemedical/oemedical_refactoring_step_I into lp:oemedical
Hi Pedro, In fact it is based on that one. It just adds inherited fields on new views... Regards El 20/01/2014 04:09, Pedro Manuel Baeza pedro.ba...@gmail.com escribió: Review: Needs Information Hi, Mario, Thanks for your great efforts to bring this project to a usable state. Waiting for a deeper review, I have seen something that flash me and want you to tell: you told about a new module called oemedical_first_name to split personal names in two, but this functionality is already present in module partner_first_name on partner-contact-management OCA repository, so I would prefer to use this module to join efforts in its maintenance and adapt OE to its use when required. What do you think? Regards. -- https://code.launchpad.net/~the-clone-master/oemedical/oemedical_refactoring_step_I/+merge/202240 You are the owner of lp:~the-clone-master/oemedical/oemedical_refactoring_step_I. -- https://code.launchpad.net/~the-clone-master/oemedical/oemedical_refactoring_step_I/+merge/202240 Your team OEmedical Commiter is subscribed to branch lp:oemedical. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
