[Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

[Holger Brunn (Therp)]

Holger Brunn (Therp) has proposed merging 
lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons.

Requested reviews:
  Guewen Baconnier @ Camptocamp (gbaconnier-c2c): code review
  Sylvain LE GAL (GRAP) (sylvain-legal): functional test

For more details, see:
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655

This is weird: Launchpad says this was merged, but I can't see the code being 
added. Does anyone have an idea what went wrong here?

I simply resubmit this MP


A widget restoring the old behavior of many2one fields in tree views
-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.
-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

[Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

[Holger Brunn (Therp)]

Holger Brunn (Therp) has proposed merging 
lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons.

Requested reviews:
  Web-Addons Core Editors (webaddons-core-editors)

For more details, see:
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/197238

A widget restoring the old behavior of many2one fields in tree views
-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/197238
Your team Web-Addons Core Editors is requested to review the proposed merge of 
lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons.
=== added directory 'web_tree_many2one_clickable'
=== added file 'web_tree_many2one_clickable/__init__.py'
--- web_tree_many2one_clickable/__init__.py	1970-01-01 00:00:00 +
+++ web_tree_many2one_clickable/__init__.py	2013-11-29 16:21:47 +
@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2013 Therp BV ().
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##

=== added file 'web_tree_many2one_clickable/__openerp__.py'
--- web_tree_many2one_clickable/__openerp__.py	1970-01-01 00:00:00 +
+++ web_tree_many2one_clickable/__openerp__.py	2013-11-29 16:21:47 +
@@ -0,0 +1,52 @@
+# -*- coding: utf-8 -*-
+##
+#
+#OpenERP, Open Source Management Solution
+#This module copyright (C) 2013 Therp BV ().
+#
+#This program is free software: you can redistribute it and/or modify
+#it under the terms of the GNU Affero General Public License as
+#published by the Free Software Foundation, either version 3 of the
+#License, or (at your option) any later version.
+#
+#This program is distributed in the hope that it will be useful,
+#but WITHOUT ANY WARRANTY; without even the implied warranty of
+#MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#GNU Affero General Public License for more details.
+#
+#You should have received a copy of the GNU Affero General Public License
+#along with this program.  If not, see .
+#
+##
+{
+"name" : "Clickable many2one widget for tree views",
+"version" : "1.0",
+"author" : "Therp BV",
+"complexity": "normal",
+"description": """
+This addon provides a widget to have many2one fields in a tree view open the
+linked resource::
+
+
+
+will open the linked partner in a form view.
+""",
+"category" : "Dependency",
+"depends" : [
+'web',
+],
+"data" : [
+],
+"js": [
+'static/src/js/web_tree_many2one_clickable.js',
+],
+"css": [
+],
+"qweb": [
+],
+"auto_install": False,
+"installable": True,
+"external_dependencies" : {
+'python' : [],
+},
+}

=== added directory 'web_tree_many2one_clickable/static'
=== added directory 'web_tree_many2one_clickable/static/src'
=== added directory 'web_tree_many2one_clickable/static/src/css'
=== added directory 'web_tree_many2one_clickable/static/src/img'
=== added file 'web_tree_many2one_clickable/static/src/img/icon.png'
Binary files web_tree_many2one_clickable/static/src/img/icon.png	1970-01-01 00:00:00 + and web_tree_many2one_clickable/static/src/img/icon.png	2013-11-29 16:21:47 + differ
=== added directory 'web_tree_many2one_clickable/static/src/js'
=== added file 'web_tree_many2one_clickable/static/src/js/web_tree_many2one_clickable.js'
--- web_tree_many2one_clickable/static/src/js/web_tree_many2one_clickable.js	1970-01-01 00:00:00 +
+++ web_tree_many2one_clickable/static/src/js/web_tree_many2one_clickable.js	2013-11-29 16:21:47 +
@@ -0,0 +1,45 @@
+//-*- coding: utf-8 -*-
+//
+//
+//   OpenERP, Open Source Management Solution
+//   This module copyright (C) 2013 Therp BV ().
+//
+//   This program is free software: you can redistribute it and/or modify
+//   it under the term

[Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

[noreply]

The proposal to merge lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable 
into lp:web-addons has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/197238
-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/197238
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

[Stefan Rijnhart (Therp)]

Review: Resubmit

You reused the same branch for web_ckeditor4, removing 
web_tree_many2one_clickable in the same commit as adding that module. When 
web_ckeditor4 was merged, the revisions were adopted in lp:web-addons, while 
the changes were reverted at the same time.

You will need to reapply the changes in a new revision.

-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

[Stefan Rijnhart (Therp)]

To see what I mean, branch lp:web-addons and inspect using

bzr status -r 9.2.2..13.1.1

-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

[Sylvain LE GAL (GRAP)]

Review: Needs Information no review

Hi,

Yes this is weird because launchpad says "Diff against target: 0 lines". Are 
you sure that your new MP is valid ?

Regards.
-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

[Holger Brunn (Therp)]

Thanks for your input, now it should be okay
-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

[Pedro Manuel Baeza]

Review: Approve code review and test

Please change description to fit in correct english to:

- This addon provides a widget to allow many2one fields in a tree view to open 
the linked resource:

but I have tried and it works correctly, so I'm not going to block MP.

Have you considered to have another module that completely replace default 
many2one widget with this functionality to avoid to reprogram all views?

Regards.
-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

[Holger Brunn (Therp)]

Thanks for your review Pedro! I basically rewrote the code, you might want to 
have another test.

The two colons are rst for preformatted text: 
http://docutils.sourceforge.net/docs/user/rst/quickref.html#literal-blocks
-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

[Ronald Portier (Therp)]

Review: Approve test

Tested it and it is working
-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/217655
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

[Guewen Baconnier @ Camptocamp]

Review: Approve code review

Very interesting! Seems fine
Thanks
-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/197238
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp

Re: [Openerp-community-reviewer] [Merge] lp:~therp-nl/web-addons/7.0-web_tree_many2one_clickable into lp:web-addons

[Sylvain LE GAL (GRAP)]

Review: Approve functional test

Nice !

it works perfectly.


-- 
https://code.launchpad.net/~therp-nl/web-addons/7.0-web_tree_many2one_clickable/+merge/197238
Your team Web-Addons Core Editors is subscribed to branch lp:web-addons.

-- 
Mailing list: https://launchpad.net/~openerp-community-reviewer
Post to : openerp-community-reviewer@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-community-reviewer
More help   : https://help.launchpad.net/ListHelp