Re: [Openerp-community-reviewer] [Merge] lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into lp:server-env-tools
Review: Approve code review LGTM. Thanks. -- https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214890 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into lp:server-env-tools
Thanks, done. -- https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214890 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into lp:server-env-tools
Hi Yajo, thanks! I approve the fix, but your branch was not clean. It contains additional commits. Can you rebase your changes on a fresh branch of lp :server-env-tools? I have done that, and created rev. 70, but now the bottom diff is empty, I don't understand why. Must I submit a different MP? -- https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214517 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into lp:server-env-tools
It's probably because the branch now has fewer commits and Launchpad MPs cannot handle that. Try resubmitting the proposal (there's a link on the right hand top of the window). -- https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214517 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp
Re: [Openerp-community-reviewer] [Merge] lp:~grupoesoc/server-env-tools/7.0-fix-1302547 into lp:server-env-tools
Well, there was a time when write() accepted ints or lists, but that's more and more history... -- https://code.launchpad.net/~grupoesoc/server-env-tools/7.0-fix-1302547/+merge/214517 Your team Server Environment And Tools Core Editors is subscribed to branch lp:server-env-tools. -- Mailing list: https://launchpad.net/~openerp-community-reviewer Post to : openerp-community-reviewer@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-community-reviewer More help : https://help.launchpad.net/ListHelp