Re: [openib-general] [PATCH] for OFED 1.2

2007-02-25 Thread Vladimir Sokolovsky
On Fri, 2007-02-23 at 12:15 -0800, Sean Hefty wrote:
 I would like these fixes in OFED 1.2 as well.  What git tree / branch do I
 generate a patch against?
 
 - Sean

git://git.openfabrics.org/~vlad/ofed_1_2/.git
branch: ofed_1_2

- Vladimir

 
 ---
 
 rdma_cm: remove unused node_guid from cma_device structure.
 ib_cm: remove ca_guid from cm_device structure.
 rdma_cm: request reversible paths only.
 ib_core: Set hop limit in ib_init_ah_from_wc correctly.
 
 The patches are in:
 
   git://git.openfabrics.org/~shefty/rdma-dev.git for-roland
 
 (sign-off line was added to the actual commit messages)
 
 Signed-off-by: Sean Hefty [EMAIL PROTECTED]
 ---
 commit 28e218621d36cf9da42f07af08775769eb289fc0
 Author: Sean Hefty [EMAIL PROTECTED]
 Date:   Thu Feb 22 11:37:44 2007 -0800
 
 rdma_cm: remove unused node_guid from cma_device structure.
 
 diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
 index bb27ce9..d441815 100644
 --- a/drivers/infiniband/core/cma.c
 +++ b/drivers/infiniband/core/cma.c
 @@ -77,7 +77,6 @@ static int next_port;
  struct cma_device {
   struct list_headlist;
   struct ib_device*device;
 - __be64  node_guid;
   struct completion   comp;
   atomic_trefcount;
   struct list_headid_list;
 @@ -2674,7 +2673,6 @@ static void cma_add_one(struct ib_device *device)
   return;
  
   cma_dev-device = device;
 - cma_dev-node_guid = device-node_guid;
  
   init_completion(cma_dev-comp);
   atomic_set(cma_dev-refcount, 1);
 
 commit 6de97f2a3373357d720b1653dfc0aac6d40b7506
 Author: Sean Hefty [EMAIL PROTECTED]
 Date:   Thu Feb 22 11:37:38 2007 -0800
 
 ib_cm: remove ca_guid from cm_device structure.
 
 The cm_device references an ib_device, which contains the node_guid.
 
 diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
 index d446998..842cd0b 100644
 --- a/drivers/infiniband/core/cm.c
 +++ b/drivers/infiniband/core/cm.c
 @@ -88,7 +88,6 @@ struct cm_port {
  struct cm_device {
   struct list_head list;
   struct ib_device *device;
 - __be64 ca_guid;
   struct cm_port port[0];
  };
  
 @@ -739,8 +738,8 @@ retest:
   ib_cancel_mad(cm_id_priv-av.port-mad_agent, cm_id_priv-msg);
   spin_unlock_irqrestore(cm_id_priv-lock, flags);
   ib_send_cm_rej(cm_id, IB_CM_REJ_TIMEOUT,
 -cm_id_priv-av.port-cm_dev-ca_guid,
 -sizeof cm_id_priv-av.port-cm_dev-ca_guid,
 +cm_id_priv-id.device-node_guid,
 +sizeof cm_id_priv-id.device-node_guid,
  NULL, 0);
   break;
   case IB_CM_REQ_RCVD:
 @@ -883,7 +882,7 @@ static void cm_format_req(struct cm_req_msg *req_msg,
  
   req_msg-local_comm_id = cm_id_priv-id.local_id;
   req_msg-service_id = param-service_id;
 - req_msg-local_ca_guid = cm_id_priv-av.port-cm_dev-ca_guid;
 + req_msg-local_ca_guid = cm_id_priv-id.device-node_guid;
   cm_req_set_local_qpn(req_msg, cpu_to_be32(param-qp_num));
   cm_req_set_resp_res(req_msg, param-responder_resources);
   cm_req_set_init_depth(req_msg, param-initiator_depth);
 @@ -1442,7 +1441,7 @@ static void cm_format_rep(struct cm_rep_msg *rep_msg,
   cm_rep_set_flow_ctrl(rep_msg, param-flow_control);
   cm_rep_set_rnr_retry_count(rep_msg, param-rnr_retry_count);
   cm_rep_set_srq(rep_msg, param-srq);
 - rep_msg-local_ca_guid = cm_id_priv-av.port-cm_dev-ca_guid;
 + rep_msg-local_ca_guid = cm_id_priv-id.device-node_guid;
  
   if (param-private_data  param-private_data_len)
   memcpy(rep_msg-private_data, param-private_data,
 @@ -3385,7 +3384,6 @@ static void cm_add_one(struct ib_device *device)
   return;
  
   cm_dev-device = device;
 - cm_dev-ca_guid = device-node_guid;
  
   set_bit(IB_MGMT_METHOD_SEND, reg_req.method_mask);
   for (i = 1; i = device-phys_port_cnt; i++) {
 
 commit 87680047dd09ca4a4e8ec575dad215c92cf45ed3
 Author: Sean Hefty [EMAIL PROTECTED]
 Date:   Wed Feb 21 16:40:44 2007 -0800
 
 rdma_cm: request reversible paths only
 
 The rdma_cm requires that path records be reversible.  Set the reversible
 bit when issuing an path record query.
 
 diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
 index f8d69b3..bb27ce9 100644
 --- a/drivers/infiniband/core/cma.c
 +++ b/drivers/infiniband/core/cma.c
 @@ -1492,11 +1492,13 @@ static int cma_query_ib_route(struct rdma_id_private
 *id_priv, int timeout_ms,
   ib_addr_get_dgid(addr, path_rec.dgid);
   path_rec.pkey = cpu_to_be16(ib_addr_get_pkey(addr));
   path_rec.numb_path = 1;
 + path_rec.reversible = 1;
  
   id_priv-query_id = ib_sa_path_rec_get(sa_client, id_priv-id.device,
   id_priv-id.port_num, path_rec,
 

[openib-general] ofa_1_2_kernel 20070225-0200 daily build status

2007-02-25 Thread vlad
This email was generated automatically, please do not reply


Common build parameters:  --with-ipoib-mod --with-sdp-mod --with-srp-mod 
--with-user_mad-mod --with-user_access-mod --with-mthca-mod --with-core-mod 
--with-addr_trans-mod --with-cxgb3-mod --with-rds-mod 

Passed:
Passed on i686 with 2.6.15-23-server
Passed on i686 with linux-2.6.18
Passed on i686 with linux-2.6.19
Passed on i686 with linux-2.6.16
Passed on i686 with linux-2.6.17
Passed on i686 with linux-2.6.12
Passed on i686 with linux-2.6.14
Passed on i686 with linux-2.6.13
Passed on i686 with linux-2.6.15
Passed on powerpc with linux-2.6.19
Passed on x86_64 with linux-2.6.20
Passed on ppc64 with linux-2.6.12
Passed on powerpc with linux-2.6.18
Passed on x86_64 with linux-2.6.19
Passed on x86_64 with linux-2.6.18
Passed on x86_64 with linux-2.6.16
Passed on x86_64 with linux-2.6.17
Passed on x86_64 with linux-2.6.15
Passed on x86_64 with linux-2.6.12
Passed on powerpc with linux-2.6.17
Passed on powerpc with linux-2.6.16
Passed on x86_64 with linux-2.6.13
Passed on x86_64 with linux-2.6.14
Passed on ppc64 with linux-2.6.19
Passed on powerpc with linux-2.6.13
Passed on ppc64 with linux-2.6.13
Passed on x86_64 with linux-2.6.9-42.ELsmp
Passed on powerpc with linux-2.6.12
Passed on powerpc with linux-2.6.14
Passed on ppc64 with linux-2.6.15
Passed on ppc64 with linux-2.6.18
Passed on ppc64 with linux-2.6.16
Passed on x86_64 with linux-2.6.16.21-0.8-smp
Passed on ppc64 with linux-2.6.17
Passed on powerpc with linux-2.6.15
Passed on ppc64 with linux-2.6.14
Passed on x86_64 with linux-2.6.18-1.2798.fc6

Failed:
Build failed on ia64 with linux-2.6.19
Log:
/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.19_ia64_check/include/rdma/ib_verbs.h:1590:
 error: implicit declaration of function ‘sg_dma_len’
/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.19_ia64_check/drivers/infiniband/core/addr.c:
 At top level:
/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.19_ia64_check/drivers/infiniband/core/addr.c:62:
 warning: initialization from incompatible pointer type
make[4]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.19_ia64_check/drivers/infiniband/core/addr.o]
 Error 1
make[3]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.19_ia64_check/drivers/infiniband/core]
 Error 2
make[2]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.19_ia64_check/drivers/infiniband]
 Error 2
make[1]: *** 
[_module_/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.19_ia64_check] 
Error 2
make[1]: Leaving directory `/home/vlad/kernel.org/ia64/linux-2.6.19'
make: *** [kernel] Error 2
--
Build failed on ia64 with linux-2.6.18
Log:
/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.18_ia64_check/include/rdma/ib_verbs.h:1590:
 error: implicit declaration of function ‘sg_dma_len’
/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.18_ia64_check/drivers/infiniband/core/addr.c:
 At top level:
/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.18_ia64_check/drivers/infiniband/core/addr.c:62:
 warning: initialization from incompatible pointer type
make[4]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.18_ia64_check/drivers/infiniband/core/addr.o]
 Error 1
make[3]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.18_ia64_check/drivers/infiniband/core]
 Error 2
make[2]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.18_ia64_check/drivers/infiniband]
 Error 2
make[1]: *** 
[_module_/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.18_ia64_check] 
Error 2
make[1]: Leaving directory `/home/vlad/kernel.org/ia64/linux-2.6.18'
make: *** [kernel] Error 2
--
Build failed on ia64 with linux-2.6.12
Log:
/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.12_ia64_check/include/rdma/ib_verbs.h:1590:
 error: implicit declaration of function ‘sg_dma_len’
/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.12_ia64_check/drivers/infiniband/core/addr.c:
 At top level:
/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.12_ia64_check/drivers/infiniband/core/addr.c:61:
 warning: initialization from incompatible pointer type
make[4]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.12_ia64_check/drivers/infiniband/core/addr.o]
 Error 1
make[3]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.12_ia64_check/drivers/infiniband/core]
 Error 2
make[2]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.12_ia64_check/drivers/infiniband]
 Error 2
make[1]: *** 
[_module_/home/vlad/tmp/ofa_1_2_kernel-20070225-0200_linux-2.6.12_ia64_check] 
Error 2
make[1]: Leaving directory `/home/vlad/kernel.org/ia64/linux-2.6.12'
make: *** [kernel] Error 2
--
Build failed on ia64 with linux-2.6.13
Log:
/home/vlad/tmp/ofa_1_2_kernel

Re: [openib-general] ipoib the partial pkey

2007-02-25 Thread Or Gerlitz
Sean Hefty wrote:
 I looked into this more...
 RFC 4391 states (middle of page 5):
 For a node to join a partition, one of its ports must be assigned the relevant
 P_Key by the SM [RFC4392].

 Jumping to RFC 4392 (top of page 4):

Just to have us agree on the quote, it is from section 4 of rfc 4392 
(page 14) eg in http://www.ietf.org/rfc/rfc4392.txt

 at the time of creating an IB multicast group, multiple values such as the
 P_Key, Q_Key, Service Level, Hop Limit, Flow ID, TClass, MTU, etc.  have to be
 specified.  These values should be such that all potential members of the IB
 multicast group are able to communicate with one another when using them.

OK, I suggest to remove this spec limitation, as it does not allow the 
use case of a server using a partition for which inter-client 
communication is not allowed.

Actually since it does not let people use partial membership 
partitioning with IPoIB as every ipoib device needs to join the 
broadcast group, it is probably a spec bug and not a limitation done on 
purpose.

A simple real-life example is I/O target, the system admin wants IB 
block and/or file storage traffic to use a partition, but he does not 
want initiators to communicate among themselves on this partition.

To achieve that the SM is configured to assign the partial pkey to the 
initiator nodes and the full pkey to the target ports.

The current implementation of IPoIB and core perfectly (and 
transparently...) supports that.

Or.


___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



Re: [openib-general] [PATCH for-2.6.21] IPoIB/cm: improve small message bandwidth

2007-02-25 Thread Michael S. Tsirkin
 Quoting Roland Dreier [EMAIL PROTECTED]:
 Subject: Re: [openib-general] [PATCH for-2.6.21] IPoIB/cm: improve small 
 message bandwidth
 
 OK, I applied the following patch (I had to change one line of your
 patch to get it to apply because the small-message changed the context
 so one chunk didn't apply).
 
 Anyway I don't see any difference in small message latency or large
 message throughput.  (Actually latency seems slightly worse but I
 think the change is within my normal variability so I'm don't think
 the difference is significant)

OK.
I wonder whether unrolling the loop in skb_put_frags might be helpful.
Could you please try the following? Does this affect latency for you?
(I don't see any difference in between UD and CM either with or without
 this patch).


Try to improve small message latency some more by unrolling more loops.

Signed-off-by: Michael S. Tsirkin [EMAIL PROTECTED]

---

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c 
b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
index a389854..a8895b4 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
@@ -311,38 +311,6 @@ static int ipoib_cm_rx_handler(struct ib_cm_id *cm_id,
return 0;
}
 }
-/* Adjust length of skb with fragments to match received data */
-static void skb_put_frags(struct sk_buff *skb, unsigned int hdr_space,
- unsigned int length, struct sk_buff *toskb)
-{
-   int i, num_frags;
-   unsigned int size;
-
-   /* put header into skb */
-   size = min(length, hdr_space);
-   skb-tail += size;
-   skb-len += size;
-   length -= size;
-
-   num_frags = skb_shinfo(skb)-nr_frags;
-   for (i = 0; i  num_frags; i++) {
-   skb_frag_t *frag = skb_shinfo(skb)-frags[i];
-
-   if (length == 0) {
-   /* don't need this page */
-   skb_fill_page_desc(toskb, i, frag-page, 0, PAGE_SIZE);
-   --skb_shinfo(skb)-nr_frags;
-   } else {
-   size = min(length, (unsigned) PAGE_SIZE);
-
-   frag-size = size;
-   skb-data_len += size;
-   skb-truesize += size;
-   skb-len += size;
-   length -= size;
-   }
-   }
-}
 
 void ipoib_cm_handle_rx_wc(struct net_device *dev, struct ib_wc *wc)
 {
@@ -352,7 +320,7 @@ void ipoib_cm_handle_rx_wc(struct net_device *dev, struct 
ib_wc *wc)
struct ipoib_cm_rx *p;
unsigned long flags;
u64 mapping[IPOIB_CM_RX_SG];
-   int frags;
+   unsigned head_size, frag_size, frags;
 
ipoib_dbg_data(priv, cm recv completion: id %d, op %d, status: %d\n,
   wr_id, wc-opcode, wc-status);
@@ -388,8 +356,9 @@ void ipoib_cm_handle_rx_wc(struct net_device *dev, struct 
ib_wc *wc)
}
}
 
-   frags = PAGE_ALIGN(wc-byte_len - min(wc-byte_len,
- (unsigned)IPOIB_CM_HEAD_SIZE)) / 
PAGE_SIZE;
+   head_size = min(wc-byte_len, (unsigned)IPOIB_CM_HEAD_SIZE);
+   frag_size = wc-byte_len - head_size;
+   frags = PAGE_ALIGN(frag_size) / PAGE_SIZE;
 
newskb = ipoib_cm_alloc_rx_skb(dev, wr_id, frags, mapping);
if (unlikely(!newskb)) {
@@ -408,7 +377,18 @@ void ipoib_cm_handle_rx_wc(struct net_device *dev, struct 
ib_wc *wc)
ipoib_dbg_data(priv, received %d bytes, SLID 0x%04x\n,
   wc-byte_len, wc-slid);
 
-   skb_put_frags(skb, IPOIB_CM_HEAD_SIZE, wc-byte_len, newskb);
+   memcpy(skb_shinfo(newskb)-frags[frags], 
skb_shinfo(skb)-frags[frags],
+  (IPOIB_CM_RX_SG - 1 - frags) * sizeof(skb_frag_t));
+   skb_shinfo(newskb)-nr_frags = IPOIB_CM_RX_SG - 1;
+
+   skb_shinfo(skb)-nr_frags = frags;
+   skb-tail += head_size;
+   skb-len += wc-byte_len;
+   skb-data_len += frag_size;
+   skb-truesize += frag_size;
+   if (frags)
+   skb_shinfo(skb)-frags[frags - 1].size =
+   (frag_size - 1) % PAGE_SIZE + 1;
 
skb-protocol = ((struct ipoib_header *) skb-data)-proto;
skb-mac.raw = skb-data;





-- 
MST

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



Re: [openib-general] [PATCH] IB/core: Set static rate in ib_init_ah_from_path()

2007-02-25 Thread Dotan Barak
Hi and sorry about the delay in the reply.

Roland Dreier wrote:
   In issue number 296 that i opened several months ago in the Bugzilla, i
   reported about two missing attributes: the first one is the static_rate,
   and the second one is the src_path_bits which is not being filled right.

 The patch I posted fixes the static rate, right?

 You'll need to explain what you mean about src_path_bits, because at
 first glance the code looks OK to me.
   
Here is the code that handles the src_path_bits:

int ib_init_ah_from_path(struct ib_device *device, u8 port_num,
 struct ib_sa_path_rec *rec, struct ib_ah_attr 
*ah_attr)
{
int ret;
u16 gid_index;

memset(ah_attr, 0, sizeof *ah_attr);
ah_attr-dlid = be16_to_cpu(rec-dlid);
ah_attr-sl = rec-sl;
ah_attr-src_path_bits = be16_to_cpu(rec-slid)  0x7f;



I have a feeling that this function doesn't handle the src_path_bits as 
it should because
it doesn't care what is the LMC value of the slid (i think that if the 
LMC is  8) wrong bits
may be set in the src_path_bits.

I think that no one noticed any failure in this code (so far) because 
not many users use LMC  0
in their subnet, and most of the code that will call this function will 
use it with the base port LID.



thanks
Dotan

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



[openib-general] [PATCH] osm: Flushing log file after OSM_SYS_LOG message

2007-02-25 Thread Yevgeny Kliteynik
Hi Hal,

OSM log should be flushed when OSM_SYS_LOG message is
printed. We had this once, but somehow it has disappeared.

This fix has to go both to trunk and to 1.2.

Thanks,

--Yevgeny

Signed-off-by: Yevgeny Kliteynik [EMAIL PROTECTED]
---
 osm/opensm/osm_log.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/osm/opensm/osm_log.c b/osm/opensm/osm_log.c
index d76031d..f95ed85 100644
--- a/osm/opensm/osm_log.c
+++ b/osm/opensm/osm_log.c
@@ -204,7 +204,8 @@ osm_log(
 #endif
  
 /*  flush log */
-if (ret  0  (p_log-flush || (verbosity  OSM_LOG_ERROR)) 
+if ( ret  0  
+(p_log-flush || (verbosity  OSM_LOG_ERROR) || (verbosity  
OSM_LOG_SYS)) 
 fflush( p_log-out_port )  0)
   ret = -1;
 
-- 
1.4.4.1.GIT


___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



[openib-general] ofa_1_2_kernel 20070225-0736 daily build status

2007-02-25 Thread vlad
This email was generated automatically, please do not reply


Common build parameters:  --with-ipoib-mod --with-sdp-mod --with-srp-mod 
--with-user_mad-mod --with-user_access-mod --with-mthca-mod --with-core-mod 
--with-addr_trans-mod --with-cxgb3-mod --with-rds-mod 

Passed:
Passed on i686 with 2.6.15-23-server
Passed on i686 with linux-2.6.19
Passed on i686 with linux-2.6.17
Passed on i686 with linux-2.6.18
Passed on i686 with linux-2.6.15
Passed on i686 with linux-2.6.12
Passed on i686 with linux-2.6.16
Passed on i686 with linux-2.6.13
Passed on i686 with linux-2.6.14
Passed on powerpc with linux-2.6.19
Passed on x86_64 with linux-2.6.19
Passed on x86_64 with linux-2.6.20
Passed on x86_64 with linux-2.6.12
Passed on x86_64 with linux-2.6.18
Passed on x86_64 with linux-2.6.16
Passed on x86_64 with linux-2.6.17
Passed on x86_64 with linux-2.6.13
Passed on x86_64 with linux-2.6.14
Passed on ppc64 with linux-2.6.14
Passed on powerpc with linux-2.6.13
Passed on powerpc with linux-2.6.18
Passed on x86_64 with linux-2.6.15
Passed on ia64 with linux-2.6.15
Passed on powerpc with linux-2.6.17
Passed on ppc64 with linux-2.6.12
Passed on x86_64 with linux-2.6.9-42.ELsmp
Passed on ppc64 with linux-2.6.15
Passed on ppc64 with linux-2.6.13
Passed on ia64 with linux-2.6.16
Passed on powerpc with linux-2.6.14
Passed on powerpc with linux-2.6.12
Passed on ppc64 with linux-2.6.19
Passed on powerpc with linux-2.6.15
Passed on ia64 with linux-2.6.18
Passed on ppc64 with linux-2.6.17
Passed on powerpc with linux-2.6.16
Passed on ia64 with linux-2.6.14
Passed on x86_64 with linux-2.6.16.21-0.8-smp
Passed on ppc64 with linux-2.6.16
Passed on ia64 with linux-2.6.13
Passed on ia64 with linux-2.6.17
Passed on ppc64 with linux-2.6.18
Passed on ia64 with linux-2.6.12
Passed on ia64 with linux-2.6.19
Passed on ia64 with linux-2.6.16.21-0.8-default
Passed on x86_64 with linux-2.6.18-1.2798.fc6

Failed:
Build failed on x86_64 with linux-2.6.9-34.ELsmp
Log:
/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-34.ELsmp_x86_64_check/drivers/net/cxgb3/cxgb3_offload.c:
 In function 'add_adapter':
/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-34.ELsmp_x86_64_check/drivers/net/cxgb3/cxgb3_offload.c:1061:
 error: 'adapter_list_lock' undeclared (first use in this function)
/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-34.ELsmp_x86_64_check/drivers/net/cxgb3/cxgb3_offload.c:
 In function 'remove_adapter':
/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-34.ELsmp_x86_64_check/drivers/net/cxgb3/cxgb3_offload.c:1068:
 error: 'adapter_list_lock' undeclared (first use in this function)
make[3]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-34.ELsmp_x86_64_check/drivers/net/cxgb3/cxgb3_offload.o]
 Error 1
make[2]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-34.ELsmp_x86_64_check/drivers/net/cxgb3]
 Error 2
make[1]: *** 
[_module_/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-34.ELsmp_x86_64_check]
 Error 2
make[1]: Leaving directory `/home/vlad/kernel.org/x86_64/linux-2.6.9-34.ELsmp'
make: *** [kernel] Error 2
--
Build failed on x86_64 with linux-2.6.9-22.ELsmp
Log:
/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-22.ELsmp_x86_64_check/drivers/net/cxgb3/vsc8211.c:167:
 error: 'ADVERTISE_PAUSE_CAP' undeclared (first use in this function)
/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-22.ELsmp_x86_64_check/drivers/net/cxgb3/vsc8211.c:167:
 error: (Each undeclared identifier is reported only once
/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-22.ELsmp_x86_64_check/drivers/net/cxgb3/vsc8211.c:167:
 error: for each function it appears in.)
/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-22.ELsmp_x86_64_check/drivers/net/cxgb3/vsc8211.c:170:
 error: 'ADVERTISE_PAUSE_ASYM' undeclared (first use in this function)
make[3]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-22.ELsmp_x86_64_check/drivers/net/cxgb3/vsc8211.o]
 Error 1
make[2]: *** 
[/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-22.ELsmp_x86_64_check/drivers/net/cxgb3]
 Error 2
make[1]: *** 
[_module_/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.9-22.ELsmp_x86_64_check]
 Error 2
make[1]: Leaving directory `/home/vlad/kernel.org/x86_64/linux-2.6.9-22.ELsmp'
make: *** [kernel] Error 2
--
Build failed on x86_64 with linux-2.6.5-7.244-smp
Log:
/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.5-7.244-smp_x86_64_check/net/rds/af_rds.c:
 In function 'rds_exit':
/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.5-7.244-smp_x86_64_check/net/rds/af_rds.c:467:
 error: implicit declaration of function 'proto_unregister'
/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.5-7.244-smp_x86_64_check/net/rds/af_rds.c:
 In function 'rds_init':
/home/vlad/tmp/ofa_1_2_kernel-20070225-0736_linux-2.6.5-7.244

Re: [openib-general] [openfabrics-ewg] new OFED 1.2 package

2007-02-25 Thread Michael S. Tsirkin
 Quoting r. Woodruff, Robert J [EMAIL PROTECTED]:
 Subject: Re: [openfabrics-ewg] new OFED 1.2 package
 
 I am also still seeing the issue with the rdma_cm abi_version on RedHat
 EL4-U3,
 bug number, 347. The bug report contains the patch that should fix this.

OK, here's a somewhat cleaned-up patch.  However, I have a question: should not 
the
module cleanup function remove ucma_class and class_attr_abi_version that were
created at module initialization?



diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c
index e2e8d32..e9e024e 100644
--- a/drivers/infiniband/core/ucma.c
+++ b/drivers/infiniband/core/ucma.c
@@ -847,13 +847,12 @@ static struct miscdevice ucma_misc = {
.fops   = ucma_fops,
 };
 
-static ssize_t show_abi_version(struct device *dev,
-   struct device_attribute *attr,
-   char *buf)
+static struct class *ucma_class;
+static ssize_t show_abi_version(struct class *class_dev, char *buf)
 {
return sprintf(buf, %d\n, RDMA_USER_CM_ABI_VERSION);
 }
-static DEVICE_ATTR(abi_version, S_IRUGO, show_abi_version, NULL);
+static CLASS_ATTR(abi_version, S_IRUGO, show_abi_version, NULL);
 
 static int __init ucma_init(void)
 {
@@ -863,7 +862,13 @@ static int __init ucma_init(void)
if (ret)
return ret;
 
-   ret = device_create_file(ucma_misc.this_device, dev_attr_abi_version);
+   ucma_class = class_create(THIS_MODULE, infiniband_ucma);
+   if (IS_ERR(ucma_class)) {
+   printk(KERN_ERR rdma_ucm: couldn't create class 
infiniband_ucma\n);
+   goto err;
+   }
+
+   ret = class_create_file(ucma_class, class_attr_abi_version);
if (ret) {
printk(KERN_ERR rdma_ucm: couldn't create abi_version attr\n);
goto err;
@@ -876,7 +881,6 @@ err:
 
 static void __exit ucma_cleanup(void)
 {
-   device_remove_file(ucma_misc.this_device, dev_attr_abi_version);
misc_deregister(ucma_misc);
idr_destroy(ctx_idr);
 }


-- 
MST

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



Re: [openib-general] [PATCH] osm: Flushing log file after OSM_SYS_LOG message

2007-02-25 Thread Sasha Khapyorsky
On 16:23 Sun 25 Feb , Yevgeny Kliteynik wrote:
 Hi Hal,
 
 OSM log should be flushed when OSM_SYS_LOG message is
 printed. We had this once, but somehow it has disappeared.
 
 This fix has to go both to trunk and to 1.2.
 
 Thanks,
 
 --Yevgeny
 
 Signed-off-by: Yevgeny Kliteynik [EMAIL PROTECTED]
 ---
  osm/opensm/osm_log.c |3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
 
 diff --git a/osm/opensm/osm_log.c b/osm/opensm/osm_log.c
 index d76031d..f95ed85 100644
 --- a/osm/opensm/osm_log.c
 +++ b/osm/opensm/osm_log.c
 @@ -204,7 +204,8 @@ osm_log(
  #endif
   
  /*  flush log */
 -if (ret  0  (p_log-flush || (verbosity  OSM_LOG_ERROR)) 
 +if ( ret  0  
 +(p_log-flush || (verbosity  OSM_LOG_ERROR) || (verbosity  
 OSM_LOG_SYS)) 

verbosity  (OSM_LOG_ERROR|OSM_LOG_SYS)?

Sasha

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



[openib-general] [PATCH] opensm: faster min hops

2007-02-25 Thread Sasha Khapyorsky

After gprof output analyzing, I noticed that current lmx (switch's lid
matrix) implementation is extremely slow. This simple hops matrix
reimplementation makes lid matrices build process two times faster.

Signed-off-by: Sasha Khapyorsky [EMAIL PROTECTED]
---
 osm/include/opensm/osm_port_profile.h |1 -
 osm/include/opensm/osm_router.h   |1 -
 osm/include/opensm/osm_switch.h   |  182 -
 osm/opensm/osm_switch.c   |  115 ++---
 osm/opensm/osm_ucast_ftree.c  |3 -
 osm/opensm/osm_ucast_mgr.c|   16 +--
 osm/opensm/osm_ucast_updn.c   |2 +-
 7 files changed, 124 insertions(+), 196 deletions(-)

diff --git a/osm/include/opensm/osm_port_profile.h 
b/osm/include/opensm/osm_port_profile.h
index 952393d..a07b057 100644
--- a/osm/include/opensm/osm_port_profile.h
+++ b/osm/include/opensm/osm_port_profile.h
@@ -55,7 +55,6 @@
 #include opensm/osm_subnet.h
 #include opensm/osm_node.h
 #include opensm/osm_port.h
-#include opensm/osm_matrix.h
 #include opensm/osm_fwd_tbl.h
 #include opensm/osm_mcast_tbl.h
 
diff --git a/osm/include/opensm/osm_router.h b/osm/include/opensm/osm_router.h
index 168ce77..63c7566 100644
--- a/osm/include/opensm/osm_router.h
+++ b/osm/include/opensm/osm_router.h
@@ -52,7 +52,6 @@
 #include opensm/osm_madw.h
 #include opensm/osm_node.h
 #include opensm/osm_port.h
-#include opensm/osm_matrix.h
 #include opensm/osm_fwd_tbl.h
 #include opensm/osm_mcast_tbl.h
 #include opensm/osm_port_profile.h
diff --git a/osm/include/opensm/osm_switch.h b/osm/include/opensm/osm_switch.h
index 053b18a..19381f8 100644
--- a/osm/include/opensm/osm_switch.h
+++ b/osm/include/opensm/osm_switch.h
@@ -53,7 +53,6 @@
 #include opensm/osm_madw.h
 #include opensm/osm_node.h
 #include opensm/osm_port.h
-#include opensm/osm_matrix.h
 #include opensm/osm_fwd_tbl.h
 #include opensm/osm_mcast_tbl.h
 #include opensm/osm_port_profile.h
@@ -105,10 +104,12 @@ typedef struct _osm_switch
cl_map_item_t   map_item;
osm_node_t  *p_node;
ib_switch_info_tswitch_info;
-   osm_fwd_tbl_t   fwd_tbl;
-   osm_lid_matrix_tlmx;
uint16_tmax_lid_ho;
+   unsignednum_ports;
+   unsignednum_hops;
+   uint8_t **hops;
osm_port_profile_t  *p_prof;
+   osm_fwd_tbl_t   fwd_tbl;
osm_mcast_tbl_t mcast_tbl;
uint32_tdiscovery_count;
void*priv;
@@ -124,19 +125,25 @@ typedef struct _osm_switch
 *  switch_info
 *  IBA defined SwitchInfo structure for this switch.
 *
-*  fwd_tbl
-*  This switch's forwarding table.
+*  max_lid_ho
+*  Max LID that is accessible from this switch.
+*
+*  num_ports
+*  Number of ports for this switch.
 *
-*  lmx
+*  num_hops
+*  Size of hops table for this switch.
+* 
+*  hops
 *  LID Matrix for this switch containing the hop count
 *  to every LID from every port.
 *
-*  max_lid_ho
-*  Max LID that is accessible from this switch.
-* 
-*  p_pro
+*  p_prof
 *  Pointer to array of Port Profile objects for this switch.
 *
+*  fwd_tbl
+*  This switch's forwarding table.
+*
 *  mcast_tbl
 *  Multicast forwarding table for this switch.
 *
@@ -149,70 +156,9 @@ typedef struct _osm_switch
 *  Switch object
 */
 
-/f* OpenSM: Switch/osm_switch_construct
+/f* OpenSM: Switch/osm_switch_delete
 * NAME
-*  osm_switch_construct
-*
-* DESCRIPTION
-*  This function constructs a Switch object.
-*
-* SYNOPSIS
-*/
-void
-osm_switch_construct(
-   IN osm_switch_t* const p_sw );
-/*
-* PARAMETERS
-*  p_sw
-*  [in] Pointer to a Switch object to construct.
-*
-* RETURN VALUE
-*  This function does not return a value.
-*
-* NOTES
-*  Allows calling osm_switch_init, and osm_switch_destroy.
-*
-*  Calling osm_switch_construct is a prerequisite to calling any other
-*  method except osm_switch_init.
-*
-* SEE ALSO
-*  Switch object, osm_switch_init, osm_switch_destroy
-*/
-
-/f* OpenSM: Switch/osm_switch_destroy
-* NAME
-*  osm_switch_destroy
-*
-* DESCRIPTION
-*  The osm_switch_destroy function destroys the object, releasing
-*  all resources.
-*
-* SYNOPSIS
-*/
-void
-osm_switch_destroy(
-   IN osm_switch_t* const p_sw );
-/*
-* PARAMETERS
-*  p_sw
-*  [in] Pointer to the object to destroy.
-*
-* RETURN VALUE
-*  None.
-*
-* NOTES
-*  Performs any necessary cleanup of the specified object.
-*   

[openib-general] [PATCH] opensm: remove osm_matrix.* files

2007-02-25 Thread Sasha Khapyorsky

Following previously submitted min hops reimplementation this removes
unused osm_matrix.* files.

Signed-off-by: Sasha Khapyorsky [EMAIL PROTECTED]
---
 osm/include/Makefile.am |1 -
 osm/include/opensm/osm_matrix.h |  456 ---
 osm/opensm/Makefile.am  |2 +-
 osm/opensm/osm_matrix.c |  156 -
 4 files changed, 1 insertions(+), 614 deletions(-)
 delete mode 100644 osm/include/opensm/osm_matrix.h
 delete mode 100644 osm/opensm/osm_matrix.c

diff --git a/osm/include/Makefile.am b/osm/include/Makefile.am
index cf1b0e7..57b5296 100644
--- a/osm/include/Makefile.am
+++ b/osm/include/Makefile.am
@@ -17,7 +17,6 @@ EXTRA_DIST = \
$(srcdir)/opensm/osm_madw.h \
$(srcdir)/opensm/osm_subnet.h \
$(srcdir)/opensm/osm_sweep_fail_ctrl.h \
-   $(srcdir)/opensm/osm_matrix.h \
$(srcdir)/opensm/osm_sa_lft_record.h \
$(srcdir)/opensm/osm_sa_mft_record.h \
$(srcdir)/opensm/osm_resp.h \
diff --git a/osm/include/opensm/osm_matrix.h b/osm/include/opensm/osm_matrix.h
deleted file mode 100644
index 65db20a..000
--- a/osm/include/opensm/osm_matrix.h
+++ /dev/null
@@ -1,456 +0,0 @@
-/*
- * Copyright (c) 2004, 2005 Voltaire, Inc. All rights reserved.
- * Copyright (c) 2002-2005 Mellanox Technologies LTD. All rights reserved.
- * Copyright (c) 1996-2003 Intel Corporation. All rights reserved.
- *
- * This software is available to you under a choice of one of two
- * licenses.  You may choose to be licensed under the terms of the GNU
- * General Public License (GPL) Version 2, available from the file
- * COPYING in the main directory of this source tree, or the
- * OpenIB.org BSD license below:
- *
- * Redistribution and use in source and binary forms, with or
- * without modification, are permitted provided that the following
- * conditions are met:
- *
- *  - Redistributions of source code must retain the above
- *copyright notice, this list of conditions and the following
- *disclaimer.
- *
- *  - Redistributions in binary form must reproduce the above
- *copyright notice, this list of conditions and the following
- *disclaimer in the documentation and/or other materials
- *provided with the distribution.
- *
- * THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND,
- * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
- * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
- * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
- * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
- * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
- * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE.
- *
- */
-
-/*
- * Abstract:
- * Declaration of osm_lid_matrix_t.
- * This object represents a two dimensional array of port numbers
- * and LID values.
- * This object is part of the OpenSM family of objects.
- *
- * Environment:
- * Linux User Mode
- *
- * $Revision: 1.5 $
- */
-
-#ifndef _OSM_MATRIX_H_
-#define _OSM_MATRIX_H_
-
-#include iba/ib_types.h
-#include complib/cl_vector.h
-#include opensm/osm_base.h
-
-#ifdef __cplusplus
-#  define BEGIN_C_DECLS extern C {
-#  define END_C_DECLS   }
-#else /* !__cplusplus */
-#  define BEGIN_C_DECLS
-#  define END_C_DECLS
-#endif /* __cplusplus */
-
-BEGIN_C_DECLS
-
-/h* OpenSM/LID Matrix
-* NAME
-*  LID Matrix
-*
-* DESCRIPTION
-*  The LID Matrix object encapsulates the information needed by the
-*  OpenSM to manage fabric routes.  It is a two dimensional array
-*  index by LID value and Port Number.  Each element contains the
-*  number of hops from that Port Number to the LID.
-*  Every Switch object contains a LID Matrix.
-*
-*  The LID Matrix is not thread safe, thus callers must provide
-*  serialization.
-*
-*  This object should be treated as opaque and should be
-*  manipulated only through the provided functions.
-*
-* AUTHOR
-*  Steve King, Intel
-*
-*/
-
-/s* OpenSM: LID Matrix/osm_lid_matrix_t
-* NAME
-*  osm_lid_matrix_t
-*
-* DESCRIPTION
-*
-*  The LID Matrix object encapsulates the information needed by the
-*  OpenSM to manage fabric routes.  It is a two dimensional array
-*  indexed by LID value and Port Number.  Each element contains the
-*  number of hops from that Port Number to the LID.
-*  Every Switch object contains a LID Matrix.
-*
-*  The LID Matrix is not thread safe, thus callers must provide
-*  serialization.
-*
-*  The num_ports index into the matrix serves a special purpose, in that it
-*  contains the shortest hop path for that LID through any port.
-*
-*  This object should be treated as opaque and should be
-*  manipulated only through the provided functions.
-*
-* SYNOPSIS
-*/
-typedef struct _osm_lid_matrix_t
-{
-   cl_vector_t   

[openib-general] [PATCH] opensm: remove some unneeded osm_switch functions

2007-02-25 Thread Sasha Khapyorsky

Following introduced simplification this patch removes single field
access functions from osm_switch.

Signed-off-by: Sasha Khapyorsky [EMAIL PROTECTED]
---
 osm/include/opensm/osm_switch.h |  176 ---
 osm/opensm/osm_mcast_mgr.c  |   27 ++
 osm/opensm/osm_mtree.c  |4 +-
 osm/opensm/osm_node_info_rcv.c  |2 +-
 osm/opensm/osm_state_mgr.c  |4 +-
 osm/opensm/osm_sw_info_rcv.c|   14 ++--
 osm/opensm/osm_switch.c |6 +-
 osm/opensm/osm_ucast_file.c |   11 +--
 osm/opensm/osm_ucast_ftree.c|   41 +-
 osm/opensm/osm_ucast_lash.c |4 +-
 osm/opensm/osm_ucast_mgr.c  |   34 
 osm/opensm/osm_ucast_updn.c |8 +-
 12 files changed, 72 insertions(+), 259 deletions(-)

diff --git a/osm/include/opensm/osm_switch.h b/osm/include/opensm/osm_switch.h
index 19381f8..4e0d46d 100644
--- a/osm/include/opensm/osm_switch.h
+++ b/osm/include/opensm/osm_switch.h
@@ -623,93 +623,6 @@ osm_switch_get_max_block_id_in_use(
 *  Switch object
 */
 
-/f* OpenSM: Switch/osm_switch_get_node_ptr
-* NAME
-*  osm_switch_get_node_ptr
-*
-* DESCRIPTION
-*  Returns a pointer to the Node object for this switch.
-*
-* SYNOPSIS
-*/
-static inline osm_node_t*
-osm_switch_get_node_ptr(
-   IN const osm_switch_t* const p_sw )
-{
-   return( p_sw-p_node );
-}
-/*
-* PARAMETERS
-*  p_sw
-*  [in] Pointer to an osm_switch_t object.
-*
-* RETURN VALUES
-*  Returns a pointer to the Node object for this switch.
-*  
-* NOTES
-*
-* SEE ALSO
-*  Switch object
-*/
-
-/f* OpenSM: Switch/osm_switch_get_max_lid_ho
-* NAME
-*  osm_switch_get_max_lid_ho
-*
-* DESCRIPTION
-*  Returns the maximum LID (host order) value contained
-*  in the switch routing tables.
-*
-* SYNOPSIS
-*/
-static inline uint16_t
-osm_switch_get_max_lid_ho(
-   IN const osm_switch_t* const p_sw )
-{
-   return p_sw-max_lid_ho;
-}
-/*
-* PARAMETERS
-*  p_sw
-*  [in] Pointer to a switch object.
-*
-* RETURN VALUES
-*  Returns the maximum LID (host order) value contained
-*  in the switch routing tables.
-*
-* NOTES
-*
-* SEE ALSO
-*/
-
-/f* OpenSM: Switch/osm_switch_get_num_ports
-* NAME
-*  osm_switch_get_num_ports
-*
-* DESCRIPTION
-*  Returns the number of ports in this switch.
-*
-* SYNOPSIS
-*/
-static inline uint8_t
-osm_switch_get_num_ports(
-   IN const osm_switch_t* const p_sw )
-{
-   return p_sw-num_ports;
-}
-/*
-* PARAMETERS
-*  p_sw
-*  [in] Pointer to an osm_switch_t object.
-*
-* RETURN VALUES
-*  Returns the number of ports in this switch.
-*
-* NOTES
-*
-* SEE ALSO
-*/
-
 /f* OpenSM: Switch/osm_switch_get_fwd_tbl_block
 * NAME
 *  osm_switch_get_fwd_tbl_block
@@ -1330,95 +1243,6 @@ osm_switch_is_in_mcast_tree(
 * SEE ALSO
 */
 
-/f* OpenSM: Node/osm_switch_discovery_count_get
-* NAME
-*  osm_switch_discovery_count_get
-*
-* DESCRIPTION
-*  Returns a pointer to the physical port object at the
-*  specified local port number.
-*
-* SYNOPSIS
-*/
-static inline uint32_t
-osm_switch_discovery_count_get(
-   IN const osm_switch_t* const p_switch )
-{
-   return( p_switch-discovery_count );
-}
-/*
-* PARAMETERS
-*  p_switch
-*  [in] Pointer to an osm_switch_t object.
-*
-* RETURN VALUES
-*  Returns the discovery count for this node.
-*
-* NOTES
-*
-* SEE ALSO
-*  Node object
-*/
-
-/f* OpenSM: Node/osm_switch_discovery_count_reset
-* NAME
-*  osm_switch_discovery_count_reset
-*
-* DESCRIPTION
-*  Resets the discovery count for this node to zero.
-*  This operation should be performed at the start of a sweep.
-*
-* SYNOPSIS
-*/
-static inline void
-osm_switch_discovery_count_reset(
-   IN osm_switch_t* const p_switch )
-{
-   p_switch-discovery_count = 0;
-}
-/*
-* PARAMETERS
-*  p_switch
-*  [in] Pointer to an osm_switch_t object.
-*
-* RETURN VALUES
-*  None.
-*
-* NOTES
-*
-* SEE ALSO
-*  Node object
-*/
-
-/f* OpenSM: Node/osm_switch_discovery_count_inc
-* NAME
-*  osm_switch_discovery_count_inc
-*
-* DESCRIPTION
-*  Increments the discovery count for this node.
-*
-* SYNOPSIS
-*/
-static inline void
-osm_switch_discovery_count_inc(
-   IN osm_switch_t* const p_switch )
-{
-   p_switch-discovery_count++;
-}
-/*
-* PARAMETERS
-*  p_switch
-*  [in] Pointer to an osm_switch_t object.
-*
-* RETURN VALUES
-*  None.
-*
-* NOTES
-*
-* SEE ALSO
-*  Node object
-*/
-
 END_C_DECLS
 
 #endif /* _OSM_SWITCH_H_ */
diff --git a/osm/opensm/osm_mcast_mgr.c b/osm/opensm/osm_mcast_mgr.c
index a5ad024..cf8ae7d 100644
--- a/osm/opensm/osm_mcast_mgr.c
+++ b/osm/opensm/osm_mcast_mgr.c
@@ -319,9 +319,7 @@ __osm_mcast_mgr_find_optimal_switch(
 
 if( osm_log_is_active( p_mgr-p_log, OSM_LOG_DEBUG ) )
 {
-  sw_guid_ho = cl_ntoh64( 

Re: [openib-general] [PATCH] osm: Flushing log file after OSM_SYS_LOG message

2007-02-25 Thread Yevgeny Kliteynik

Sasha Khapyorsky wrote:
 On 16:23 Sun 25 Feb , Yevgeny Kliteynik wrote:
 Hi Hal,

 OSM log should be flushed when OSM_SYS_LOG message is
 printed. We had this once, but somehow it has disappeared.

 This fix has to go both to trunk and to 1.2.

 Thanks,

 --Yevgeny

 Signed-off-by: Yevgeny Kliteynik [EMAIL PROTECTED]
 ---
  osm/opensm/osm_log.c |3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)

 diff --git a/osm/opensm/osm_log.c b/osm/opensm/osm_log.c
 index d76031d..f95ed85 100644
 --- a/osm/opensm/osm_log.c
 +++ b/osm/opensm/osm_log.c
 @@ -204,7 +204,8 @@ osm_log(
  #endif
   
  /*  flush log */
 -if (ret  0  (p_log-flush || (verbosity  OSM_LOG_ERROR)) 
 +if ( ret  0  
 +(p_log-flush || (verbosity  OSM_LOG_ERROR) || (verbosity  
 OSM_LOG_SYS)) 
 
 verbosity  (OSM_LOG_ERROR|OSM_LOG_SYS)?

Sure - why not

-- Yevgeny
 
 Sasha
 

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



[openib-general] bugs filed for problems compiling OFED 1.2 alpha1

2007-02-25 Thread Scott Weitzenkamp (sweitzen)
Please fix these bugs for beta.  
 
I've compiled for RHEL4 and SLES10 on x86_64, i686, ia64, and ppc64.  I
compiled all MPIs with GNU, Intel, and PGI compilers.

*   380 OFED 1.2 alpha1 gcc MVAPICH won't compile on RHEL4 IA64
*   381 OFED 1.2 alpha1 MVAPICH2 won't compile on RHEL4 IA64
with Intel compiler
*   382 OFED 1.2 alpha1 mpitests won't compile with Intel
compiler for Open MPI (RHEL4 IA64)
*   383 OFED 1.2 alpha1 core/addr.c won't compile on SLES10 IA64
*   384 OFED 1.2 alpha1 ib-bonding won't compile on RHEL4 U3
ppc64
*   386 OFED 1.2 alpha1 gcc MVAPICH2 won't compile on RHEL4
ppc64 (add -m64)
*   387 OFED 1.2 alpha1 Open MPI won't compile on SLES10 ppc64

Scott Weitzenkamp
SQA and Release Manager
Server Virtualization Business Unit
Cisco Systems
 
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

[openib-general] bugs filed for OFED 1.2 alpha1 MPI compiler support

2007-02-25 Thread Scott Weitzenkamp (sweitzen)
Please fix these bugs for beta.  
 
I've compiled for RHEL4 and SLES10 on x86_64, i686, ia64, and ppc64.  I
compiled all MPIs with GNU, Intel, and PGI compilers, and tried
compiling and running C, C++, Fortran 77, and Fortran 90 programs with
each combo.

*   370 OFED 1.2 alpha1 MVAPICH does not have Intel Fortran
support
*   372 MVAPICH2 GNU mpif90 uses PGI not GNU compiler
*   373 MVAPICH2 Intel mpif90 does not include -rpath like
mpif77 does
*   374 MVAPICH2 PGI mpif90 link failure: undefined reference
..Dm_mpi
*   375 Open MPI PGI C++ failure at runtime

Scott Weitzenkamp
SQA and Release Manager
Server Virtualization Business Unit
Cisco Systems
 
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Re: [openib-general] bugs filed for problems compiling OFED 1.2 alpha1

2007-02-25 Thread Michael S. Tsirkin
 Quoting Scott Weitzenkamp (sweitzen) [EMAIL PROTECTED]:
 Subject: bugs filed for problems compiling OFED 1.2 alpha1
 
 Please fix these bugs for beta. 
  

Scott, you have assigned all bugs to [EMAIL PROTECTED]
To have the bugs resolved, please assign them to maintainers of
appropriate module.

For example, bonding module owner is Moni Shoua [EMAIL PROTECTED],
so I think bug 384 should be assigned to him.

-- 
MST

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



[openib-general] [Bug 384] OFED 1.2 alpha1 ib-bonding won't compile on RHEL4 U3 ppc64

2007-02-25 Thread bugzilla-daemon
https://bugs.openfabrics.org/show_bug.cgi?id=384


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]




--- Comment #1 from [EMAIL PROTECTED]  2007-02-25 23:49 ---
Scott, you have assigned all bugs to [EMAIL PROTECTED]
To have the bugs resolved, please assign them to maintainers of
appropriate module.

For example, bonding module owner is Moni Shoua [EMAIL PROTECTED],
so I think bug 384 should be assigned to him.

-- 
MST


-- 
Configure bugmail: https://bugs.openfabrics.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



Re: [openib-general] bugs filed for problems compiling OFED 1.2 alpha1

2007-02-25 Thread Scott Weitzenkamp (sweitzen)

 Scott, you have assigned all bugs to [EMAIL PROTECTED]
 To have the bugs resolved, please assign them to maintainers of
 appropriate module.

Not sure what you mean by all, only 384 was not assigned to a specific
person.

Scott

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general



Re: [openib-general] bugs filed for problems compiling OFED 1.2 alpha1

2007-02-25 Thread Michael S. Tsirkin
 Quoting Scott Weitzenkamp (sweitzen) [EMAIL PROTECTED]:
 Subject: bugs filed for problems compiling OFED 1.2 alpha1
 
 Please fix these bugs for beta. 
  
 I've compiled for RHEL4 and SLES10 on x86_64, i686, ia64, and ppc64.  I
 compiled all MPIs with GNU, Intel, and PGI compilers.
 
   • 380 OFED 1.2 alpha1 gcc MVAPICH won't compile on RHEL4 IA64
   • 381 OFED 1.2 alpha1 MVAPICH2 won't compile on RHEL4 IA64 with Intel
 compiler
   • 382 OFED 1.2 alpha1 mpitests won't compile with Intel compiler for 
 Open
 MPI (RHEL4 IA64)
   • 383 OFED 1.2 alpha1 core/addr.c won't compile on SLES10 IA64
   • 384 OFED 1.2 alpha1 ib-bonding won't compile on RHEL4 U3 ppc64
   • 386 OFED 1.2 alpha1 gcc MVAPICH2 won't compile on RHEL4 ppc64 (add
 -m64)
   • 387 OFED 1.2 alpha1 Open MPI won't compile on SLES10 ppc64

Some of these might be fixed in recent nightly builds.
Specifically I know 383 was fixed yesterday. Please check this and let us know.

-- 
MST

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Re: [openib-general] bugs filed for problems compiling OFED 1.2 alpha1

2007-02-25 Thread Michael S. Tsirkin
 Quoting Scott Weitzenkamp (sweitzen) [EMAIL PROTECTED]:
 Subject: RE: bugs filed for problems compiling OFED 1.2 alpha1
 
 
  Scott, you have assigned all bugs to [EMAIL PROTECTED]
  To have the bugs resolved, please assign them to maintainers of
  appropriate module.
 
 Not sure what you mean by all, only 384 was not assigned to a specific
 person.

Correct. Sorry about that.

-- 
MST

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general