Re: [openib-general] [PATCH] [RFC] ofed_1_2 - SLES9SP3 Backport -IWCM workaroundfor ip_dev_find() bug.

2007-02-08 Thread Steve Wise 
Michael, 

From your email, it sounded like you would regression test this.  Is it
ready to pull in?  

Thanks!

Steve.


On Tue, 2007-02-06 at 17:39 -0600, Steve Wise wrote:
 Here it is (only tested with rping over iWARP on sles9sp3):
 
 
 
 
 xxx_ip_dev_find() must use scope HOST.
 
 From: Steve Wise [EMAIL PROTECTED]
 
 Function xxx_ip_dev_find(RT_SCOPE_LINK) returns the wrong interface on
 some kernels.  The correct scope is RT_SCOPE_HOST.
 
 Signed-off-by: Steve Wise [EMAIL PROTECTED]
 ---
 
  .../backport/2.6.11/include/linux/inetdevice.h |2 +-
  .../backport/2.6.11_FC4/include/linux/inetdevice.h |2 +-
  .../backport/2.6.12/include/linux/inetdevice.h |2 +-
  .../backport/2.6.13/include/linux/inetdevice.h |2 +-
  .../2.6.13_suse10_0_u/include/linux/inetdevice.h   |2 +-
  .../backport/2.6.14/include/linux/inetdevice.h |2 +-
  .../backport/2.6.15/include/linux/inetdevice.h |2 +-
  .../2.6.15_ubuntu606/include/linux/inetdevice.h|2 +-
  .../backport/2.6.16/include/linux/inetdevice.h |2 +-
  .../backport/2.6.17/include/linux/inetdevice.h |2 +-
  .../2.6.5_sles9_sp3/include/linux/inetdevice.h |2 +-
  .../backport/2.6.9_U2/include/linux/inetdevice.h   |2 +-
  .../backport/2.6.9_U3/include/linux/inetdevice.h   |2 +-
  .../backport/2.6.9_U4/include/linux/inetdevice.h   |2 +-
  14 files changed, 14 insertions(+), 14 deletions(-)
 
 diff --git a/kernel_addons/backport/2.6.11/include/linux/inetdevice.h 
 b/kernel_addons/backport/2.6.11/include/linux/inetdevice.h
 index 7244487..2d3c50f 100644
 --- a/kernel_addons/backport/2.6.11/include/linux/inetdevice.h
 +++ b/kernel_addons/backport/2.6.11/include/linux/inetdevice.h
 @@ -13,7 +13,7 @@ static inline struct net_device *xxx_ip_
  
   read_lock(dev_base_lock);
   for (dev = dev_base; dev; dev = dev-next) {
 - ip = inet_select_addr(dev, 0, RT_SCOPE_LINK);
 + ip = inet_select_addr(dev, 0, RT_SCOPE_HOST);
   if (ip == addr) {
   dev_hold(dev);
   break;
 diff --git a/kernel_addons/backport/2.6.11_FC4/include/linux/inetdevice.h 
 b/kernel_addons/backport/2.6.11_FC4/include/linux/inetdevice.h
 index 7244487..2d3c50f 100644
 --- a/kernel_addons/backport/2.6.11_FC4/include/linux/inetdevice.h
 +++ b/kernel_addons/backport/2.6.11_FC4/include/linux/inetdevice.h
 @@ -13,7 +13,7 @@ static inline struct net_device *xxx_ip_
  
   read_lock(dev_base_lock);
   for (dev = dev_base; dev; dev = dev-next) {
 - ip = inet_select_addr(dev, 0, RT_SCOPE_LINK);
 + ip = inet_select_addr(dev, 0, RT_SCOPE_HOST);
   if (ip == addr) {
   dev_hold(dev);
   break;
 diff --git a/kernel_addons/backport/2.6.12/include/linux/inetdevice.h 
 b/kernel_addons/backport/2.6.12/include/linux/inetdevice.h
 index 7244487..2d3c50f 100644
 --- a/kernel_addons/backport/2.6.12/include/linux/inetdevice.h
 +++ b/kernel_addons/backport/2.6.12/include/linux/inetdevice.h
 @@ -13,7 +13,7 @@ static inline struct net_device *xxx_ip_
  
   read_lock(dev_base_lock);
   for (dev = dev_base; dev; dev = dev-next) {
 - ip = inet_select_addr(dev, 0, RT_SCOPE_LINK);
 + ip = inet_select_addr(dev, 0, RT_SCOPE_HOST);
   if (ip == addr) {
   dev_hold(dev);
   break;
 diff --git a/kernel_addons/backport/2.6.13/include/linux/inetdevice.h 
 b/kernel_addons/backport/2.6.13/include/linux/inetdevice.h
 index 7a32313..fd0aa36 100644
 --- a/kernel_addons/backport/2.6.13/include/linux/inetdevice.h
 +++ b/kernel_addons/backport/2.6.13/include/linux/inetdevice.h
 @@ -11,7 +11,7 @@ static inline struct net_device *xxx_ip_
  
   read_lock(dev_base_lock);
   for (dev = dev_base; dev; dev = dev-next) {
 - ip = inet_select_addr(dev, 0, RT_SCOPE_LINK);
 + ip = inet_select_addr(dev, 0, RT_SCOPE_HOST);
   if (ip == addr) {
   dev_hold(dev);
   break;
 diff --git 
 a/kernel_addons/backport/2.6.13_suse10_0_u/include/linux/inetdevice.h 
 b/kernel_addons/backport/2.6.13_suse10_0_u/include/linux/inetdevice.h
 index 7a32313..fd0aa36 100644
 --- a/kernel_addons/backport/2.6.13_suse10_0_u/include/linux/inetdevice.h
 +++ b/kernel_addons/backport/2.6.13_suse10_0_u/include/linux/inetdevice.h
 @@ -11,7 +11,7 @@ static inline struct net_device *xxx_ip_
  
   read_lock(dev_base_lock);
   for (dev = dev_base; dev; dev = dev-next) {
 - ip = inet_select_addr(dev, 0, RT_SCOPE_LINK);
 + ip = inet_select_addr(dev, 0, RT_SCOPE_HOST);
   if (ip == addr) {
   dev_hold(dev);
   break;
 diff --git a/kernel_addons/backport/2.6.14/include/linux/inetdevice.h 
 b/kernel_addons/backport/2.6.14/include/linux/inetdevice.h
 index 7a32313..fd0aa36 100644
 ---

Re: [openib-general] [PATCH] [RFC] ofed_1_2 - SLES9SP3 Backport-IWCM workaroundfor ip_dev_find() bug.

2007-02-08 Thread Michael S. Tsirkin 
 Quoting Steve Wise [EMAIL PROTECTED]:
 Subject: Re: [openib-general] [PATCH] [RFC] ofed_1_2 - SLES9SP3 Backport-IWCM 
 workaroundfor ip_dev_find() bug.
 
 Michael, 
 
 From your email, it sounded like you would regression test this.

Not yet, we had lab restructuring - hopefully next week.


-- 
MST

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Re: [openib-general] [PATCH] [RFC] ofed_1_2 - SLES9SP3 Backport -IWCM workaroundfor ip_dev_find() bug.

2007-02-06 Thread Michael S. Tsirkin 
 Quoting Steve Wise [EMAIL PROTECTED]:
 Subject: Re: [PATCH] [RFC] ofed_1_2 - SLES9SP3 Backport -IWCM workaroundfor 
 ip_dev_find() bug.
 
 On Tue, 2007-02-06 at 23:36 +0200, Michael S. Tsirkin wrote:
   How shall I fix this?  
  
  Patch?
  
 
 Riiight.  I'm afraid if I use HOST instead of LINK that I'll break some
 strange SDP loopback feature or some such thing.  And I'm not in a
 position to test that.
 
 But I can post a patch.  Shall I just change sles9sp3 since we don't see
 (yet) any problems with the other distros?

If you post one that updates all kernels it will be easier to test.

-- 
MST

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

Re: [openib-general] [PATCH] [RFC] ofed_1_2 - SLES9SP3 Backport -IWCM workaroundfor ip_dev_find() bug.

2007-02-06 Thread Steve Wise 
Here it is (only tested with rping over iWARP on sles9sp3):




xxx_ip_dev_find() must use scope HOST.

From: Steve Wise [EMAIL PROTECTED]

Function xxx_ip_dev_find(RT_SCOPE_LINK) returns the wrong interface on
some kernels.  The correct scope is RT_SCOPE_HOST.

Signed-off-by: Steve Wise [EMAIL PROTECTED]
---

 .../backport/2.6.11/include/linux/inetdevice.h |2 +-
 .../backport/2.6.11_FC4/include/linux/inetdevice.h |2 +-
 .../backport/2.6.12/include/linux/inetdevice.h |2 +-
 .../backport/2.6.13/include/linux/inetdevice.h |2 +-
 .../2.6.13_suse10_0_u/include/linux/inetdevice.h   |2 +-
 .../backport/2.6.14/include/linux/inetdevice.h |2 +-
 .../backport/2.6.15/include/linux/inetdevice.h |2 +-
 .../2.6.15_ubuntu606/include/linux/inetdevice.h|2 +-
 .../backport/2.6.16/include/linux/inetdevice.h |2 +-
 .../backport/2.6.17/include/linux/inetdevice.h |2 +-
 .../2.6.5_sles9_sp3/include/linux/inetdevice.h |2 +-
 .../backport/2.6.9_U2/include/linux/inetdevice.h   |2 +-
 .../backport/2.6.9_U3/include/linux/inetdevice.h   |2 +-
 .../backport/2.6.9_U4/include/linux/inetdevice.h   |2 +-
 14 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/kernel_addons/backport/2.6.11/include/linux/inetdevice.h 
b/kernel_addons/backport/2.6.11/include/linux/inetdevice.h
index 7244487..2d3c50f 100644
--- a/kernel_addons/backport/2.6.11/include/linux/inetdevice.h
+++ b/kernel_addons/backport/2.6.11/include/linux/inetdevice.h
@@ -13,7 +13,7 @@ static inline struct net_device *xxx_ip_
 
read_lock(dev_base_lock);
for (dev = dev_base; dev; dev = dev-next) {
-   ip = inet_select_addr(dev, 0, RT_SCOPE_LINK);
+   ip = inet_select_addr(dev, 0, RT_SCOPE_HOST);
if (ip == addr) {
dev_hold(dev);
break;
diff --git a/kernel_addons/backport/2.6.11_FC4/include/linux/inetdevice.h 
b/kernel_addons/backport/2.6.11_FC4/include/linux/inetdevice.h
index 7244487..2d3c50f 100644
--- a/kernel_addons/backport/2.6.11_FC4/include/linux/inetdevice.h
+++ b/kernel_addons/backport/2.6.11_FC4/include/linux/inetdevice.h
@@ -13,7 +13,7 @@ static inline struct net_device *xxx_ip_
 
read_lock(dev_base_lock);
for (dev = dev_base; dev; dev = dev-next) {
-   ip = inet_select_addr(dev, 0, RT_SCOPE_LINK);
+   ip = inet_select_addr(dev, 0, RT_SCOPE_HOST);
if (ip == addr) {
dev_hold(dev);
break;
diff --git a/kernel_addons/backport/2.6.12/include/linux/inetdevice.h 
b/kernel_addons/backport/2.6.12/include/linux/inetdevice.h
index 7244487..2d3c50f 100644
--- a/kernel_addons/backport/2.6.12/include/linux/inetdevice.h
+++ b/kernel_addons/backport/2.6.12/include/linux/inetdevice.h
@@ -13,7 +13,7 @@ static inline struct net_device *xxx_ip_
 
read_lock(dev_base_lock);
for (dev = dev_base; dev; dev = dev-next) {
-   ip = inet_select_addr(dev, 0, RT_SCOPE_LINK);
+   ip = inet_select_addr(dev, 0, RT_SCOPE_HOST);
if (ip == addr) {
dev_hold(dev);
break;
diff --git a/kernel_addons/backport/2.6.13/include/linux/inetdevice.h 
b/kernel_addons/backport/2.6.13/include/linux/inetdevice.h
index 7a32313..fd0aa36 100644
--- a/kernel_addons/backport/2.6.13/include/linux/inetdevice.h
+++ b/kernel_addons/backport/2.6.13/include/linux/inetdevice.h
@@ -11,7 +11,7 @@ static inline struct net_device *xxx_ip_
 
read_lock(dev_base_lock);
for (dev = dev_base; dev; dev = dev-next) {
-   ip = inet_select_addr(dev, 0, RT_SCOPE_LINK);
+   ip = inet_select_addr(dev, 0, RT_SCOPE_HOST);
if (ip == addr) {
dev_hold(dev);
break;
diff --git 
a/kernel_addons/backport/2.6.13_suse10_0_u/include/linux/inetdevice.h 
b/kernel_addons/backport/2.6.13_suse10_0_u/include/linux/inetdevice.h
index 7a32313..fd0aa36 100644
--- a/kernel_addons/backport/2.6.13_suse10_0_u/include/linux/inetdevice.h
+++ b/kernel_addons/backport/2.6.13_suse10_0_u/include/linux/inetdevice.h
@@ -11,7 +11,7 @@ static inline struct net_device *xxx_ip_
 
read_lock(dev_base_lock);
for (dev = dev_base; dev; dev = dev-next) {
-   ip = inet_select_addr(dev, 0, RT_SCOPE_LINK);
+   ip = inet_select_addr(dev, 0, RT_SCOPE_HOST);
if (ip == addr) {
dev_hold(dev);
break;
diff --git a/kernel_addons/backport/2.6.14/include/linux/inetdevice.h 
b/kernel_addons/backport/2.6.14/include/linux/inetdevice.h
index 7a32313..fd0aa36 100644
--- a/kernel_addons/backport/2.6.14/include/linux/inetdevice.h
+++ b/kernel_addons/backport/2.6.14/include/linux/inetdevice.h
@@ -11,7 +11,7 @@ static inline struct net_device *xxx_ip_
 
read_lock(dev_base_lock);

Re: [openib-general] [PATCH] [RFC] ofed_1_2 - SLES9SP3 Backport -IWCM workaroundfor ip_dev_find() bug.

2007-02-06 Thread Michael S. Tsirkin 
 Quoting Steve Wise [EMAIL PROTECTED]:
 Subject: Re: [PATCH] [RFC] ofed_1_2 - SLES9SP3 Backport -IWCM workaroundfor 
 ip_dev_find() bug.
 
 Here it is (only tested with rping over iWARP on sles9sp3):
 
 
 
 
 xxx_ip_dev_find() must use scope HOST.
 
 From: Steve Wise [EMAIL PROTECTED]
 
 Function xxx_ip_dev_find(RT_SCOPE_LINK) returns the wrong interface on
 some kernels.  The correct scope is RT_SCOPE_HOST.
 
 Signed-off-by: Steve Wise [EMAIL PROTECTED]

OK. I don't have access to the lab at the moment, but hope to test this
by next week.

-- 
MST

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general