Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
Hoang-Nam Nguyen wrote: > Thanks for this. Will do in next couple of days. > Regards > Nam Nguyen > I had a mistake in the version number - you should call it 1.1.1 Tziporet ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
Hello Tziporet! > I suggest that you fix what you want and create 1.0.1.1. You can place > it in the svn releases area > and direct people that need ehca to this version. > We did something similar when we published 1.0.1 for which we added > SLES9 SP3 support. > Please place it on > https://openib.org/svn/gen2/branches/1.1/ofed/releases/ (I assume you > have a check-in permission to svn). Thanks for this. Will do in next couple of days. Regards Nam Nguyen ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
Hoang-Nam Nguyen wrote: > Now libehca is broken in ofed-1.1. How can we fix that until 1.2? > > I suggest that you fix what you want and create 1.0.1.1. You can place it in the svn releases area and direct people that need ehca to this version. We did something similar when we published 1.0.1 for which we added SLES9 SP3 support. Please place it on https://openib.org/svn/gen2/branches/1.1/ofed/releases/ (I assume you have a check-in permission to svn). Tziporet ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
Hello Tziporet! > I regret that some of the latest patches could not be included in the final release, but the main issue was that the > patches came too late. Why didn't you tell me that when I reported you, Vladimir and Michael, also via direct emails asking for help, about the issues with ofed build procedure, ie. openib.spec and rpm build, one week ago? Also when you asked the group for release schedule and I told you about the issues? > Please note: > 1. ehca was added to OFED 1.1 in RC3, 31-Aug (http://openib.org/pipermail/openfabrics-ewg/2006-August/001234.html) > 2. Most user space issues raised by IBM were reported only on RC7, which was supposed to be the final RC, with no more > major changes. > We nevertheless accepted patches that you submitted at that late phase which affected only ehca. However, the patch > in question (on the configure file for user space) touches ALL components of the userspace build, and was a very large > patch as well. At that late date (2 days before final release!), it is impossible to start testing a change of this > magnitude on ALL platforms to verify that the change was not harmful. No. As you can see and I explained clearly in previous emails the patch in question is in libehca only. For clarity again: The actual patch (libehca/configure.in and libehca/config.h.in) adds 8 lines. The other libehca/configure patch is a large file generated by the packaing/build process from Vladimir and is not part of as Michael pointed out. The only reason you told us that they are non-blocking issues because ehca is in preview tech state and hence the patch is rejected. > I agree we should learn from this experience: in the future, please start your testing as early as possible so that > problems of this nature are caught early in the development cycle, and do not need to be addressed at the last possible moment. I agree with this and will do. On the other hand you still have to consider that bugs can be found at late phase. Looking at Bugzilla Bug 283 "libmthca and libipathverbs 32 bit are not installed on x86_64", which also came late in 1.1, I see much analogies with the issues I found with libehca on ppc64. > I am sure that in the next release things will go more smoothly since this was IBM's first participation in an OFED release. Now libehca is broken in ofed-1.1. How can we fix that until 1.2? Regards Nam Nguyen ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
Chet Mehta wrote: Tziporet, I understand that OFED1.1-rc7 was released without the requested change below despite the fact that the request came in before the deadline. As things stand, userspace is broken for ehca in OFED 1.1. Was the request rejected because ehca is considered a technology preview for this OFED release and if so are there well understood (documented) rules/limitations on how their submissions are handled? I'm asking to (a) learn from this experience (b) understand what we could/should have done differently (c) help avoid issues of this type in the future for us or other contributors. I would appreciate hearing back from you. Thx! :Chet. Hi Chet, I regret that some of the latest patches could not be included in the final release, but the main issue was that the patches came too late. Please note: 1. ehca was added to OFED 1.1 in RC3, 31-Aug (http://openib.org/pipermail/openfabrics-ewg/2006-August/001234.html) 2. Most user space issues raised by IBM were reported only on RC7, which was supposed to be the final RC, with no more major changes. We nevertheless accepted patches that you submitted at that late phase which affected only ehca. However, the patch in question (on the configure file for user space) touches ALL components of the userspace build, and was a very large patch as well. At that late date (2 days before final release!), it is impossible to start testing a change of this magnitude on ALL platforms to verify that the change was not harmful. I agree we should learn from this experience: in the future, please start your testing as early as possible so that problems of this nature are caught early in the development cycle, and do not need to be addressed at the last possible moment. I am sure that in the next release things will go more smoothly since this was IBM's first participation in an OFED release. Tziporet ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
Tziporet, I understand that OFED1.1-rc7 was released without the requested change below despite the fact that the request came in before the deadline. As things stand, userspace is broken for ehca in OFED 1.1. Was the request rejected because ehca is considered a technology preview for this OFED release and if so are there well understood (documented) rules/limitations on how their submissions are handled? I'm asking to (a) learn from this experience (b) understand what we could/should have done differently (c) help avoid issues of this type in the future for us or other contributors. I would appreciate hearing back from you. Thx! :Chet. Hoang-Nam Nguyen/Germany/[EMAIL PROTECTED] 10/19/2006 09:41 AM To Tziporet Koren <[EMAIL PROTECTED]> cc "Michael S. Tsirkin" <[EMAIL PROTECTED]>, [EMAIL PROTECTED], openib-general@openib.org, Vladimir Sokolovsky <[EMAIL PROTECTED]>, Chet Mehta/Austin/[EMAIL PROTECTED] Subject Re: [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfsLink Hi, > The release is closed. We only updating the documents now (will be > closed in the coming few hours only). > Since ehca is in technology preview state these issues are not blockers. > Please document all issues in ehca release_notes (or send me parts you > want to include). Even though ehca is in technology preview state, there are certainly some ones who would like to use it. In current ofed the build process is incomplete for ehca user space. We did send the patches yesterday as discussed w/ Vladimir and Michael and considered to be on the category "2. Small updates for the install". It's very important for us that one can get ehca compiled and built with ofed. Since those patches do not touch any other components and we were one day before todays deadline, we're very surprised that you reject this code now. What should be the next steps? Regards Nam ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
Hi Vladimir! > No, the updated configure.in and config.h.in are not in OFED-1.1. > In any case, I believe that most of the checks you have added to > configure scripts are provided by OFED installation scripts. > So, in case OFED installation fails, ehca configure would fail as well. Created a bugzilla as libehca could not be found by libibverbs, http://openib.org/bugzilla/show_bug.cgi?id=285. I guess I was not precise enough in that configure does not only check libsysfs, but also generates corresponding define HAVE_SYSFS_LIBSYSFS_H in config.h to enable/export openib_driver_init() from libehca. So we really need configure.in and config.h.in to enable libehca for user space. Without them ehca configure still goes through. Regards Nam ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
so this means this problem we try to fix is already covered by your new setup? Do you have a version we could try? Gruss / Regards . . . Christoph Raisch christoph raisch, HCAD teamlead, IODF2 (d/3627), ibm boeblingen lab, phone: (+49/0)7031-16 4584, fax: -16 2042, loc: 71032-05-003, internet: [EMAIL PROTECTED] "Vladimir Sokolovsky" <[EMAIL PROTECTED] To .il> Hoang-Nam Nguyen/Germany/[EMAIL PROTECTED] cc 19.10.2006 17:07 "Michael S. Tsirkin" <[EMAIL PROTECTED]>, <[EMAIL PROTECTED]>, <[EMAIL PROTECTED] >, , "Tziporet Koren" <[EMAIL PROTECTED]>, Christoph Raisch/Germany/[EMAIL PROTECTED] Subject RE: [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs No, the updated configure.in and config.h.in are not in OFED-1.1. In any case, I believe that most of the checks you have added to configure scripts are provided by OFED installation scripts. So, in case OFED installation fails, ehca configure would fail as well. Regards, Vladimir > -Original Message- > From: Hoang-Nam Nguyen [mailto:[EMAIL PROTECTED] > Sent: Thursday, October 19, 2006 4:56 PM > To: Vladimir Sokolovsky > Cc: Michael S. Tsirkin; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; > openib-general@openib.org; Tziporet Koren; Christoph Raisch > Subject: Re: [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca > configure: fix missing check of libsysfs > > Hi Vlad, > > The code that fixes lib/lib64 issue on ppc64 and libehca.so > to be in > > libehca RPM is in OFED-1.1. > Thanks! Can you pls confirm if configure.in and config.h.in are in > OFED-1.1 as well? > Regards > Nam > ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
No, the updated configure.in and config.h.in are not in OFED-1.1. In any case, I believe that most of the checks you have added to configure scripts are provided by OFED installation scripts. So, in case OFED installation fails, ehca configure would fail as well. Regards, Vladimir > -Original Message- > From: Hoang-Nam Nguyen [mailto:[EMAIL PROTECTED] > Sent: Thursday, October 19, 2006 4:56 PM > To: Vladimir Sokolovsky > Cc: Michael S. Tsirkin; [EMAIL PROTECTED]; > [EMAIL PROTECTED]; > openib-general@openib.org; Tziporet Koren; Christoph Raisch > Subject: Re: [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca > configure: fix missing check of libsysfs > > Hi Vlad, > > The code that fixes lib/lib64 issue on ppc64 and libehca.so > to be in > > libehca RPM is in OFED-1.1. > Thanks! Can you pls confirm if configure.in and config.h.in are in > OFED-1.1 as well? > Regards > Nam > ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
Hi Vlad, > The code that fixes lib/lib64 issue on ppc64 and libehca.so to be in > libehca RPM is in OFED-1.1. Thanks! Can you pls confirm if configure.in and config.h.in are in OFED-1.1 as well? Regards Nam ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
Hi Nam, The code that fixes lib/lib64 issue on ppc64 and libehca.so to be in libehca RPM is in OFED-1.1. Regards, Vladimir > -Original Message- > From: Hoang-Nam Nguyen [mailto:[EMAIL PROTECTED] > Sent: Thursday, October 19, 2006 4:41 PM > To: Tziporet Koren > Cc: Michael S. Tsirkin; [EMAIL PROTECTED]; > openib-general@openib.org; Vladimir Sokolovsky; Chet Mehta > Subject: Re: [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca > configure: fix missing check of libsysfs > > Hi, > > The release is closed. We only updating the documents now (will be > > closed in the coming few hours only). > > Since ehca is in technology preview state these issues are > not blockers. > > Please document all issues in ehca release_notes (or send > me parts you > > want to include). > Even though ehca is in technology preview state, there are > certainly some ones who would like to use it. In current ofed > the build process is incomplete for ehca user space. We did > send the patches yesterday as discussed w/ Vladimir and > Michael and considered to be on the category "2. Small > updates for the install". It's very important for us that one > can get ehca compiled and built with ofed. Since those > patches do not touch any other components and we were one day > before todays deadline, we're very surprised that you reject > this code now. What should be the next steps? > Regards > Nam > ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
Hi, > The release is closed. We only updating the documents now (will be > closed in the coming few hours only). > Since ehca is in technology preview state these issues are not blockers. > Please document all issues in ehca release_notes (or send me parts you > want to include). Even though ehca is in technology preview state, there are certainly some ones who would like to use it. In current ofed the build process is incomplete for ehca user space. We did send the patches yesterday as discussed w/ Vladimir and Michael and considered to be on the category "2. Small updates for the install". It's very important for us that one can get ehca compiled and built with ofed. Since those patches do not touch any other components and we were one day before todays deadline, we're very surprised that you reject this code now. What should be the next steps? Regards Nam ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] [openfabrics-ewg] [PATCH OFED-1.1-rc7] libehca configure: fix missing check of libsysfs
Hoang-Nam Nguyen wrote: > As Michael indicated in previous email configure is a generated file > from autogen.sh. And I'm not sure if your packaging script does generate > it automatically when you build the whole OFED tgz-file. > The actual patches in configure.in and config.h.in are needed because > I got compile error like: > static declaration of ibv_read_sysfs_file() does not match previous > declaration in infiniband/driver.h > Thanks! > Nam > > The release is closed. We only updating the documents now (will be closed in the coming few hours only). Since ehca is in technology preview state these issues are not blockers. Please document all issues in ehca release_notes (or send me parts you want to include). Tziporet ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
