[openib-general] RE: [PATCH] Opensm - handling immediate error in vendor_send new
Hi again Yael, On Wed, 2005-10-12 at 03:53, Yael Kalka wrote: > > > I decided to remove the checking for zero in the atomic_dec after > all, > > > since as I mentioned before - clearing it is not a fix, and we > will > > > see the value in other infos in the log file. > > > > But there is danger is these counters wrap, right ? > > > There is still some danger - as you noted - the counters can wrap. > This will happen if there is some problem in the lower layer. > For example - if we get the same mad twice, and we allocated it > already for another request (after getting the first answer). > It shouldn't happen if the lower layer is functioning correctly. I think that it's more than lower layer malfunction that can cause this to occur. -- Hal ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[openib-general] RE: [PATCH] Opensm - handling immediate error in vendor_send new
Title: RE: [PATCH] Opensm - handling immediate error in vendor_send new Hi Hal, Hal Rosenstock wrote: > Hi Yael, > > On Tue, 2005-10-11 at 04:28, Yael Kalka wrote: > > Attached is a new patch with several fixes for this issue. > > Thanks. Applied. > > There were still extra whitespace issues which I fixed by hand. Please > try to eliminate these so I don't have to do hand touch ups. > I will. Sorry. > > I decided to remove the checking for zero in the atomic_dec after all, > > since as I mentioned before - clearing it is not a fix, and we will > > see the value in other infos in the log file. > > But there is danger is these counters wrap, right ? > There is still some danger - as you noted - the counters can wrap. This will happen if there is some problem in the lower layer. For example - if we get the same mad twice, and we allocated it already for another request (after getting the first answer). It shouldn't happen if the lower layer is functioning correctly. > Also, in looking further at the code, the same issue does not appear to > occur for QP1 handling, right ? > No. There is no such issue in the QP1 handling. > -- Hal > ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[openib-general] Re: [PATCH] Opensm - handling immediate error in vendor_send new
Hi Yael, On Tue, 2005-10-11 at 04:28, Yael Kalka wrote: > Attached is a new patch with several fixes for this issue. Thanks. Applied. There were still extra whitespace issues which I fixed by hand. Please try to eliminate these so I don't have to do hand touch ups. > I decided to remove the checking for zero in the atomic_dec after all, > since as I mentioned before - clearing it is not a fix, and we will > see the value in other infos in the log file. But there is danger is these counters wrap, right ? Also, in looking further at the code, the same issue does not appear to occur for QP1 handling, right ? -- Hal ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
