[openib-general] Re: [PATCH] [NET]: Move destructor from neigh-ops to neigh_params
The following patch moves this field to neigh_parms where it can be safely set, together with its twin neigh_setup. Two additional patches in the patch series update ipoib to use this new interface. Guys, is there any chance this patch can make it into 2.6.16 still? I actually didn't push this since I didn't know about net/atm/clip.c, but now I see that without this patch, in 2.6.16 we have two net drivers modifying ops-destructor: net/atm/clip.c and drivers/infiniband/ipoib, so they conflict. -- Michael S. Tsirkin Staff Engineer, Mellanox Technologies ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[openib-general] Re: [PATCH] [NET]: Move destructor from neigh-ops to neigh_params
Quoting r. Michael S. Tsirkin [EMAIL PROTECTED]: Subject: Re: [PATCH] [NET]: Move destructor from neigh-ops to neigh_params The following patch moves this field to neigh_parms where it can be safely set, together with its twin neigh_setup. Two additional patches in the patch series update ipoib to use this new interface. Guys, is there any chance this patch can make it into 2.6.16 still? I actually didn't push this since I didn't know about net/atm/clip.c, but now I see that without this patch, in 2.6.16 we have two net drivers modifying ops-destructor: net/atm/clip.c and drivers/infiniband/ipoib, so they conflict. On a further look, they don't, since clip.c has its own neigh ops structure which won't ever land on ipoib. So forget it. -- Michael S. Tsirkin Staff Engineer, Mellanox Technologies ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[openib-general] Re: [PATCH] net: Move destructor from neigh-ops to neigh_params
Roland Dreier [EMAIL PROTECTED] wrote: struct neigh_ops currently has a destructor field, which no in-kernel drivers outside of infiniband use. net/atm/clip.c begs to disagree. I'm also wondering why a combination of the net and infiniband trees does this: drivers/infiniband/ulp/ipoib/ipoib_multicast.c: In function `ipoib_mcast_free': drivers/infiniband/ulp/ipoib/ipoib_multicast.c:118: error: structure has no member named `destructor' ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Re: [PATCH] net: Move destructor from neigh-ops to neigh_params
I'm also wondering why a combination of the net and infiniband trees does this: drivers/infiniband/ulp/ipoib/ipoib_multicast.c: In function `ipoib_mcast_free': drivers/infiniband/ulp/ipoib/ipoib_multicast.c:118: error: structure has no member named `destructor' I guess this patch needs to be combined with another ipoib-neigh patch, which hasn't been checked into infiniband/ipoib yet. Thanks Shirley Ma IBM Linux Technology Center 15300 SW Koll Parkway Beaverton, OR 97006-6063 Phone(Fax): (503) 578-7638 ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[openib-general] Re: [PATCH] net: Move destructor from neigh-ops to neigh_params
Roland struct neigh_ops currently has a destructor field, which
Roland no in-kernel drivers outside of infiniband use.
Andrew net/atm/clip.c begs to disagree.
err... my fault for trusting the patch changelog and not
double-checking. I think the fix is as simple as, although, given my
lack of ATM gear, this is untested:
diff --git a/net/atm/clip.c b/net/atm/clip.c
index 73370de..9d72817 100644
--- a/net/atm/clip.c
+++ b/net/atm/clip.c
@@ -289,7 +289,6 @@ static void clip_neigh_error(struct neig
static struct neigh_ops clip_neigh_ops = {
.family = AF_INET,
- .destructor = clip_neigh_destroy,
.solicit = clip_neigh_solicit,
.error_report = clip_neigh_error,
.output = dev_queue_xmit,
@@ -346,6 +345,7 @@ static struct neigh_table clip_tbl = {
/* parameters are copied from ARP ... */
.parms = {
+ .destructor = clip_neigh_destroy,
.tbl= clip_tbl,
.base_reachable_time= 30 * HZ,
.retrans_time = 1 * HZ,
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[openib-general] Re: [PATCH] net: Move destructor from neigh-ops to neigh_params
Andrew I'm also wondering why a combination of the net and Andrew infiniband trees does this: Andrew drivers/infiniband/ulp/ipoib/ipoib_multicast.c: In Andrew function `ipoib_mcast_free': Andrew drivers/infiniband/ulp/ipoib/ipoib_multicast.c:118: error: Andrew structure has no member named `destructor' A cock-up on my part. I think I fixed this when testing the patch, and promptly forgot about doing it. Then when I reposted the patch to netdev, I decided to be very careful about things, so I went back to pristine sources from Michael's message, which of course is missing the following chunk: diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c index fde442a..93c462e 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c @@ -115,7 +115,6 @@ static void ipoib_mcast_free(struct ipoi if (neigh-ah) ipoib_put_ah(neigh-ah); *to_ipoib_neigh(neigh-neighbour) = NULL; - neigh-neighbour-ops-destructor = NULL; kfree(neigh); } ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[openib-general] Re: [PATCH] net: Move destructor from neigh-ops to neigh_params
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 06 Mar 2006 21:44:50 -0800 Roland struct neigh_ops currently has a destructor field, which Roland no in-kernel drivers outside of infiniband use. Andrew net/atm/clip.c begs to disagree. err... my fault for trusting the patch changelog and not double-checking. I think the fix is as simple as, although, given my lack of ATM gear, this is untested: Looks good to me, applied. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[openib-general] Re: [PATCH] net: Move destructor from neigh-ops to neigh_params
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 23 Jan 2006 13:27:32 -0800 I'd like to get an ACK or NAK of it from Dave Dave is in New Zealand at linux.conf.au, don't expect him to be too active for at least a week... ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
