[openib-general] Re: [PATCH] sa_query: Add service record support

[Roland Dreier]

Michael> Can this be renamed to struct ib_sa_service_rec_query,
Michael> please?  Or does it mean something else?

Makes sense.  The style I tried to follow in the SA client module was
that everything was named the same was as the IBA spec, except that
StudlyCaps are replaced with underscores (ie StudlyCaps ->
studly_caps).

 - R.
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

[openib-general] Re: [PATCH] sa_query: Add service record support

[Michael S. Tsirkin]

Quoting r. Hal Rosenstock <[EMAIL PROTECTED]>:
> > Can this be renamed to struct ib_sa_service_rec_query, please?
> > Or does it mean something else?
> 
> Sure but ib_sa_service_query would be more in keeping.

The functions are called "ib_sa_service_rec_query", I guess you'll rename
that too?

-- 
MST
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

[openib-general] Re: [PATCH] sa_query: Add service record support

[Hal Rosenstock]

On Tue, 2005-06-28 at 17:34, Michael S. Tsirkin wrote:
> Quoting r. Hal Rosenstock <[EMAIL PROTECTED]>:
> > Subject: [PATCH] sa_query: Add service record support
> > 
> > sa_query: Add service record support
> > 
> > Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]>
> >
> > ...
> >
> > +struct ib_sa_srvrec_query {
> > +   void (*callback)(int, struct ib_sa_service_rec *, void *);
> > +   void *context;
> > +   struct ib_sa_query sa_query;
> > +};
> > +
> 
> Can this be renamed to struct ib_sa_service_rec_query, please?
> Or does it mean something else?

Sure but ib_sa_service_query would be more in keeping.

I'll wait to see what other comments come back before posting an updated patch.

-- Hal

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general

[openib-general] Re: [PATCH] sa_query: Add service record support

[Michael S. Tsirkin]

Quoting r. Hal Rosenstock <[EMAIL PROTECTED]>:
> Subject: [PATCH] sa_query: Add service record support
> 
> sa_query: Add service record support
> 
> Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]>
>
> ...
>
> +struct ib_sa_srvrec_query {
> + void (*callback)(int, struct ib_sa_service_rec *, void *);
> + void *context;
> + struct ib_sa_query sa_query;
> +};
> +

Can this be renamed to struct ib_sa_service_rec_query, please?
Or does it mean something else?

-- 
MST
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general