Re: [openib-general] Re: [PATCH 04/16] ehca: userspace support
> >Do you really need this heavy debug logging in the first place? You > >can use kprobes for arbitrary run-time inspection anyway, so logging > >everything seems wasteful. > > The problem I see with kprobes is that you have to set several kernel > configuration options (e.g. CONFIG_KPROBES, CONFIG_DEBUG_INFO, etc.) > on compile time to use it. Same problem with pr_debug(). Note that one usage of debug code is for a vendor to ask a customer to turn it on to figure out weird problems that the vendor can't replicate. Customers are more likely to cooperate if the effort is small... rebuilding the kernel is not a small effort compared to turning on debug that's already compiled in. -- greg ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Re: [PATCH 04/16] ehca: userspace support
> >>The problem I see with pr_debug() is that it could only activated via > >>a compile flag. To use the debug outputs you have to re-compile / > >>compile your own kernel. > > > >Do you really need this heavy debug logging in the first place? You > >can use kprobes for arbitrary run-time inspection anyway, so logging > >everything seems wasteful. > > The problem I see with kprobes is that you have to set several kernel > configuration options (e.g. CONFIG_KPROBES, CONFIG_DEBUG_INFO, etc.) > on compile time to use it. Same problem with pr_debug(). It might be worth to move the s390 debug feature to common code. At least it has proven many times to be very useful in device driver debugging... See Documentation/s390/s390dbf.txt and arch/s390/kernel/debug.c. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Re: [PATCH 04/16] ehca: userspace support
Hello, On 28.04.2006, at 08:32, Pekka Enberg wrote: The problem I see with pr_debug() is that it could only activated via a compile flag. To use the debug outputs you have to re-compile / compile your own kernel. Do you really need this heavy debug logging in the first place? You can use kprobes for arbitrary run-time inspection anyway, so logging everything seems wasteful. The problem I see with kprobes is that you have to set several kernel configuration options (e.g. CONFIG_KPROBES, CONFIG_DEBUG_INFO, etc.) on compile time to use it. Same problem with pr_debug(). Regards, Heiko ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Re: [PATCH 04/16] ehca: userspace support
On Fri, 2006-04-28 at 09:32 +0300, Pekka Enberg wrote: > Hi Heiko, > > On 4/28/06, Heiko J Schick <[EMAIL PROTECTED]> wrote: > > The problem I see with pr_debug() is that it could only activated via > > a compile flag. To use the debug outputs you have to re-compile / > > compile your own kernel. > > Do you really need this heavy debug logging in the first place? You > can use kprobes for arbitrary run-time inspection anyway, so logging > everything seems wasteful. Yeah, I really don't think you want to be running with that kind of debugging gunk in a production kernel. Is someone who can't build their own kernel really going to be able to make sense of the output? cheers -- Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc Description: This is a digitally signed message part ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Re: [PATCH 04/16] ehca: userspace support
Hi Heiko, On 4/28/06, Heiko J Schick <[EMAIL PROTECTED]> wrote: > The problem I see with pr_debug() is that it could only activated via > a compile flag. To use the debug outputs you have to re-compile / > compile your own kernel. Do you really need this heavy debug logging in the first place? You can use kprobes for arbitrary run-time inspection anyway, so logging everything seems wasteful. Pekka ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Re: [PATCH 04/16] ehca: userspace support
Hello Michael, On 28.04.2006, at 00:36, Michael Ellerman wrote: Try pr_debug() in include/linux/kernel.h The problem I see with pr_debug() is that it could only activated via a compile flag. To use the debug outputs you have to re-compile / compile your own kernel. Regards, Heiko ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[openib-general] Re: [PATCH 04/16] ehca: userspace support
On Thu, 2006-04-27 at 13:43 +0200, Jörn Engel wrote: > More minors. > > On Thu, 27 April 2006 12:48:22 +0200, Heiko J Schick wrote: > > + > > + EDEB_EN(7, > > + "vm_start=%lx vm_end=%lx vm_page_prot=%lx vm_fileoff=%lx " > > + "address=%lx", > > + vma->vm_start, vma->vm_end, vma->vm_page_prot, fileoffset, > > + address); > > Gesundheit! Seriously, I suspect "EDEB_EN" is not the best possible > name to pick. Try pr_debug() in include/linux/kernel.h cheers -- Michael Ellerman IBM OzLabs wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person signature.asc Description: This is a digitally signed message part ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[openib-general] Re: [PATCH 04/16] ehca: userspace support
More minors.
On Thu, 27 April 2006 12:48:22 +0200, Heiko J Schick wrote:
> +
> + EDEB_EN(7,
> + "vm_start=%lx vm_end=%lx vm_page_prot=%lx vm_fileoff=%lx "
> + "address=%lx",
> + vma->vm_start, vma->vm_end, vma->vm_page_prot, fileoffset,
> + address);
Gesundheit! Seriously, I suspect "EDEB_EN" is not the best possible
name to pick.
> +if (cq->ownpid!=cur_pid) {
Coding style would require spaces around binary operators.
Jörn
--
He that composes himself is wiser than he that composes a book.
-- B. Franklin
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
