Re: [openib-general] Rollup patch for ipath and OFED
Quoting r. Greg Lindahl <[EMAIL PROTECTED]>: > Subject: Re: Rollup patch for ipath and OFED > > On Wed, Aug 23, 2006 at 06:01:32PM +0300, Michael S. Tsirkin wrote: > > > So this seems to be ripping out chunks of upstream code (ipath_ht400) > > replacing them with something else (ipath_iba6110, ipath_iba6120.o) > > To answer this piece of the question, we were acquired last April, and > of course we have to rename all our devices. Since patch doesn't have > a rename feature, this looks much worse than it really is. Fine, but I wander why rush this cosmetic change for ofed 1.1? Anyway, so is that right that there's basically just the mmap enhancement plus a lot of file renames? -- MST ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Rollup patch for ipath and OFED
Bryan O'Sullivan wrote: > SVN is not a high priority for me personally. Fixing things so that I > can send meaningful patches upstream in a timely manner us. Why not remove your code from SVN? - Sean ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Rollup patch for ipath and OFED
On Wed, 2006-08-23 at 10:58 -0700, Woodruff, Robert J wrote: > I hate to tell you I told you so, but this is exactly why you guys > should not be off working behind closed doors and then submit some > mongo patch. That's precisely what I'm working to avoid. It's not as if I didn't know this. > If you would just submit the code as you go in smaller > patches and check in the smaller patches daily to SVN, we would not > have such an integration mess at the end. SVN is not a high priority for me personally. Fixing things so that I can send meaningful patches upstream in a timely manner us. http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Rollup patch for ipath and OFED
Bryan wrote, >On Wed, 2006-08-23 at 18:01 +0300, Michael S. Tsirkin wrote: >> Guys, I just looked at ipath-fixes.patch in ofed. With 36 files changed, 4623 >> insertions, 4774 deletions, it's quite a biggie with no description what it does >> whatsoever. Can't this be split to smaller chunks doing one thing at a time, >> please? You'll have to do this for upstream inclusion anyway, so why not for >> OFED? >We were in a rush to get a working patch out, is all. I've been >splitting that monster up into sensibly-sized chunks in the usual way. > http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Rollup patch for ipath and OFED
On Wed, Aug 23, 2006 at 06:01:32PM +0300, Michael S. Tsirkin wrote: > So this seems to be ripping out chunks of upstream code (ipath_ht400) > replacing them with something else (ipath_iba6110, ipath_iba6120.o) To answer this piece of the question, we were acquired last April, and of course we have to rename all our devices. Since patch doesn't have a rename feature, this looks much worse than it really is. -- greg ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Rollup patch for ipath and OFED
On Wed, 2006-08-23 at 18:01 +0300, Michael S. Tsirkin wrote: > Guys, I just looked at ipath-fixes.patch in ofed. With 36 files changed, 4623 > insertions, 4774 deletions, it's quite a biggie with no description what it > does > whatsoever. Can't this be split to smaller chunks doing one thing at a time, > please? You'll have to do this for upstream inclusion anyway, so why not for > OFED? We were in a rush to get a working patch out, is all. I've been splitting that monster up into sensibly-sized chunks in the usual way. http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[openib-general] Rollup patch for ipath and OFED
Guys, I just looked at ipath-fixes.patch in ofed. With 36 files changed, 4623 insertions, 4774 deletions, it's quite a biggie with no description what it does whatsoever. Can't this be split to smaller chunks doing one thing at a time, please? You'll have to do this for upstream inclusion anyway, so why not for OFED? Oh well. However, this baby also does for example: diff -r d2661c9eff49 -r 198ed6310295 drivers/infiniband/hw/ipath/Makefile --- a/drivers/infiniband/hw/ipath/Makefile Thu Aug 10 16:19:45 2006 -0700 +++ b/drivers/infiniband/hw/ipath/Makefile Wed Aug 16 11:01:29 2006 -0700 @@ -1,36 +1,34 @@ EXTRA_CFLAGS += -DIPATH_IDSTR='"QLogic k EXTRA_CFLAGS += -DIPATH_IDSTR='"QLogic kernel.org driver"' \ -DIPATH_KERN_TYPE=0 -obj-$(CONFIG_IPATH_CORE) += ipath_core.o obj-$(CONFIG_INFINIBAND_IPATH) += ib_ipath.o -ipath_core-y := \ +ib_ipath-y := \ + ipath_cq.o \ ipath_diag.o \ ipath_driver.o \ ipath_eeprom.o \ ipath_file_ops.o \ ipath_fs.o \ - ipath_ht400.o \ + ipath_iba6110.o \ + ipath_iba6120.o \ ipath_init_chip.o \ ipath_intr.o \ + ipath_keys.o \ ipath_layer.o \ - ipath_pe800.o \ - ipath_stats.o \ - ipath_sysfs.o \ - ipath_user_pages.o - -ipath_core-$(CONFIG_X86_64) += ipath_wc_x86_64.o - -ib_ipath-y := \ - ipath_cq.o \ - ipath_keys.o \ ipath_mad.o \ ipath_mr.o \ ipath_qp.o \ ipath_rc.o \ ipath_ruc.o \ ipath_srq.o \ + ipath_stats.o \ + ipath_sysfs.o \ ipath_uc.o \ ipath_ud.o \ - ipath_verbs.o \ - ipath_verbs_mcast.o + ipath_user_pages.o \ + ipath_verbs_mcast.o \ + ipath_verbs.o + +ib_ipath-$(CONFIG_X86_64) += ipath_wc_x86_64.o +ib_ipath-$(CONFIG_PPC64) += ipath_wc_ppc64.o So this seems to be ripping out chunks of upstream code (ipath_ht400) replacing them with something else (ipath_iba6110, ipath_iba6120.o) This might be a good change for all I know. But I'd like to ask What exactly does this fixes patch, fix? Can there be a list of things it provides at the top? How about a Signed-off-by line? Was this posted on openib-general even once? There's a single unmerged ipath patch posted on openib-general: mmap()ed userspace work queues for ipath. So where does the rest come from? Googling for ipath_iba6110 gets no hits. Thanks, -- MST ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
