Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
Roland Dreier wrote: > OK, I pulled this in to my for-2.6.21 branch and I will ask Linus to > pull later today. Thanks for the review. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
OK, I pulled this in to my for-2.6.21 branch and I will ask Linus to pull later today. Thanks. - R. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
Or Gerlitz wrote: > Roland Dreier wrote: >> I merged the "increment port number" and "remove redundant '_wq'" >> patches from git.openfabrics.org/~shefty/scm/rdma-dev.git for-roland >> >> I plan to review to multicast stuff next week and I hope to merge it >> for 2.6.21. Or, have you or anyone else at Voltaire read over the >> code in addition to using it? Do you see anything that should be >> cleaned up? > > OK, I spent some time today on reviewing and playing with the ib_sa: > track multicast join/leave requests patch - and have no special > comments. I think the two patches are ready for merge, let me know if > you have any specific question. Roland - any progress here? Or. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
Roland Dreier wrote: > I merged the "increment port number" and "remove redundant '_wq'" > patches from git.openfabrics.org/~shefty/scm/rdma-dev.git for-roland > > I plan to review to multicast stuff next week and I hope to merge it > for 2.6.21. Or, have you or anyone else at Voltaire read over the > code in addition to using it? Do you see anything that should be > cleaned up? OK, I spent some time today on reviewing and playing with the ib_sa: track multicast join/leave requests patch - and have no special comments. I think the two patches are ready for merge, let me know if you have any specific question. Or. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
> IMO, probably worth it to init just this one field rather than use up > initialized memory - and I think it's clearer. What do you mean by using up initialized memory? kzalloc() just does a memset(0), and it's not like there's a limit on the number of times we're allowed to call memset(). - R. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
> > + > > > > It seems same goes for > > > > + mc = kzalloc(sizeof(*mc), GFP_KERNEL); > > + if (!mc) > > + return NULL; > > We would need to set events_reported. IMO, probably worth it to init just this one field rather than use up initialized memory - and I think it's clearer. -- MST ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
> + member = kzalloc(sizeof *member, gfp_mask); > + if (!member) > + return ERR_PTR(-ENOMEM); This appears okay to replace with kmalloc. > + group = kzalloc(sizeof *group, gfp_mask); > + if (!group) > + return NULL; > + We would need additional initialize code to clear the members array, set the state, and set last_join fields. > and same here: > > + iter = kzalloc(sizeof *iter + attr_size, GFP_KERNEL); > + if (!iter) > + return ERR_PTR(-ENOMEM); I think this is coming from the local SA cache patch, which isn't part of this pull request. > + > > It seems same goes for > > + mc = kzalloc(sizeof(*mc), GFP_KERNEL); > + if (!mc) > + return NULL; We would need to set events_reported. > + bind_list = kzalloc(sizeof *bind_list, GFP_KERNEL); > + if (!bind_list) > + return -ENOMEM; This looks like it can be replaced with kmalloc. Roland, let me know how you'd like to handle any changes. - Sean ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
> > Or, have you or anyone else at Voltaire read over the > > code in addition to using it? Do you see anything that should be > > cleaned up? > > OK, I most the the review i did (and interaction with Sean to add changes) was > on the rdma_cm: add multicast communication support patch, and i was > less focused > on the ib_sa: track multicast join/leave requests patch, however i > recall that there were some discussions between Sean and Michael and > they reached an agreement. Yes, we reached an agreement. These patches have also seen some limited testing in the OFED tree. -- MST ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
On 2/9/07, Roland Dreier <[EMAIL PROTECTED]> wrote: > I plan to review to multicast stuff next week and I hope to merge it for > 2.6.21 thanks, good news! > Or, have you or anyone else at Voltaire read over the > code in addition to using it? Do you see anything that should be > cleaned up? OK, I most the the review i did (and interaction with Sean to add changes) was on the rdma_cm: add multicast communication support patch, and i was less focused on the ib_sa: track multicast join/leave requests patch, however i recall that there were some discussions between Sean and Michael and they reached an agreement. I will look on the ib_sa patch on Sunday and let Sean/you know if i have any comments. Or. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
> Quoting Roland Dreier <[EMAIL PROTECTED]>:
> Subject: Re: please pull for 2.6.21: fix + add IB multicast support
>
> I merged the "increment port number" and "remove redundant '_wq'"
> patches from git.openfabrics.org/~shefty/scm/rdma-dev.git for-roland
>
> I plan to review to multicast stuff next week and I hope to merge it
> for 2.6.21. Or, have you or anyone else at Voltaire read over the
> code in addition to using it? Do you see anything that should be
> cleaned up?
I looked at the code briefly, don't have much time at the moment
unfortunately.
+static void join_group(struct mcast_group *group, struct mcast_member *member,
+ u8 join_state)
+{
+ member->state = MCAST_MEMBER;
+ adjust_membership(group, join_state, 1);
+ group->rec.join_state |= join_state;
+ member->multicast.rec = group->rec;
+ member->multicast.rec.join_state = join_state;
+ list_del(&member->list);
+ list_add(&member->list, &group->active_list);
+}
Can be just list_move.
Patch allocates everything with kzalloc, but then goes ahead and initialize
everything.
So just kmalloc it - no reason to waste initialized memory if non-initialized
will do.
List of places:
+ member = kzalloc(sizeof *member, gfp_mask);
+ if (!member)
+ return ERR_PTR(-ENOMEM);
Same here:
+ group = kzalloc(sizeof *group, gfp_mask);
+ if (!group)
+ return NULL;
+
and same here:
+ iter = kzalloc(sizeof *iter + attr_size, GFP_KERNEL);
+ if (!iter)
+ return ERR_PTR(-ENOMEM);
+
It seems same goes for
+ mc = kzalloc(sizeof(*mc), GFP_KERNEL);
+ if (!mc)
+ return NULL;
in ucma.c - everything gets initied by calling function - but
a bit less sure, needs checking.
By the way, it seems same goes for
+ bind_list = kzalloc(sizeof *bind_list, GFP_KERNEL);
+ if (!bind_list)
+ return -ENOMEM;
in cma_alloc_any_port in the port randomization patch that was merged
and for cma_alloc_port in existing code.
--
MSTYou seem to be careful to do list_del_init for member->list all over,
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
I merged the "increment port number" and "remove redundant '_wq'" patches from git.openfabrics.org/~shefty/scm/rdma-dev.git for-roland I plan to review to multicast stuff next week and I hope to merge it for 2.6.21. Or, have you or anyone else at Voltaire read over the code in addition to using it? Do you see anything that should be cleaned up? - R. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
Or Gerlitz wrote: > Sean Hefty wrote: >>> Sean Hefty (3): >>>rdma_cm: Increment port number after close to avoid re-use. >>>ib_sa: track multicast join/leave requests >>>rdma_cm: add multicast communication support >> Assuming that you haven't look at this yet, I updated the ib_sa patch >> above to shorten the workqueue name, plus added a fourth patch to >> shorten the workqueue names for ib_addr and rdma_cm. E.g. "ib_mcast_wq" >> became "ib_mcast". > Roland, > We are working (developing and testing) with a userspace rdma cm based > multicast app over this code during the last two months and are very > satisfied with it. The testing included IPoIB, the user space app and > multicast interoperability between them. Roland, Can you comment on the status of this merge request? thanks, Or. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
> > Can you comment on the multicast changes merge for 2.6.21 status? > >Where are the final patches that you want to merge? Try the for-roland branch at git.openfabrics.org/~shefty/scm/rdma-dev.git. If this doesn't work, or you hit any snags, let me know, and I'll try to correct any issues so that simple pulls work in the future. Note that my tree is still at rc6. There should be 4 patches. - Sean ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
> Can you comment on the multicast changes merge for 2.6.21 status? Where are the final patches that you want to merge? - R. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
Sean Hefty wrote: >> Sean Hefty (3): >>rdma_cm: Increment port number after close to avoid re-use. >>ib_sa: track multicast join/leave requests >>rdma_cm: add multicast communication support > > Assuming that you haven't look at this yet, I updated the ib_sa patch > above to shorten the workqueue name, plus added a fourth patch to > shorten the workqueue names for ib_addr and rdma_cm. E.g. "ib_mcast_wq" > became "ib_mcast". > Let me know if you need any assistance. Roland, Can you comment on the multicast changes merge for 2.6.21 status? We are working (developing and testing) with a userspace rdma cm based multicast app over this code during the last two months and are very satisfied with it. The testing included IPoIB, the user space app and multicast interoperability between them. Or. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] please pull for 2.6.21: fix + add IB multicast support
> Sean Hefty (3): >rdma_cm: Increment port number after close to avoid re-use. >ib_sa: track multicast join/leave requests >rdma_cm: add multicast communication support Assuming that you haven't look at this yet, I updated the ib_sa patch above to shorten the workqueue name, plus added a fourth patch to shorten the workqueue names for ib_addr and rdma_cm. E.g. "ib_mcast_wq" became "ib_mcast". Let me know if you need any assistance. - Sean ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[openib-general] please pull for 2.6.21: fix + add IB multicast support
Roland, I've created a 'for-roland' branch off of my git tree: git://git.openfabrics.org/~shefty/rdma-dev.git with the following changes: Sean Hefty (3): rdma_cm: Increment port number after close to avoid re-use. ib_sa: track multicast join/leave requests rdma_cm: add multicast communication support The multicast patches combine additional patches posted to the list, including the fix for the multiple HCA issue reported by Michael. - Sean ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
