Re: [openib-general] [PATCH][iWARP] IW CM Verbs

2005-08-29 Thread Sean Hefty

James Lentini wrote:
Why does the ib_device need a cm structure for iWARP but not IB? If 
you used either Guy or Roland's generic RDMA connection API and did 
the iWARP implementation, would you still need to add the iw_cm 
structure?


Their connection protocol is implemented in hardware.  Even with a 
generic CM API, I believe that they'll need these calls.


- Sean
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general


RE: [openib-general] [PATCH][iWARP] IW CM Verbs

2005-08-29 Thread Steve Wise
 

> -Original Message-
> From: [EMAIL PROTECTED] 
> [mailto:[EMAIL PROTECTED] On Behalf Of James Lentini
> Sent: Monday, August 29, 2005 8:42 AM
> To: Tom Tucker
> Cc: openib-general@openib.org
> Subject: Re: [openib-general] [PATCH][iWARP] IW CM Verbs
> 
> 
> 
> On Fri, 26 Aug 2005, Tom Tucker wrote:
> 
> > Index: ib_verbs.h
> > ===
> > --- ib_verbs.h  (revision 3120)
> > +++ ib_verbs.h  (working copy)
> > @@ -804,6 +806,7 @@
> > struct ib_gid_cache   **gid_cache;
> >  };
> >  
> > +struct iw_cm;
> >  struct ib_device {
> > struct device*dma_device;
> >  
> > @@ -820,6 +823,8 @@
> >  
> > u32   flags;
> >  
> > +   struct iw_cm  *iwcm;
> > +
> > int(*query_device)(struct 
> ib_device *device,
> >struct 
> ib_device_attr *device_attr);
> > int(*query_port)(struct 
> ib_device *device,
> 
> Why does the ib_device need a cm structure for iWARP but not IB?

Some RNIC devices fully establish the connection in hardware.  However,
_all_ openib IB devices export the MAD interface, which is used to send
low level connection setup primitives, thus allowing connection setup in
the host. 

> If 
> you used either Guy or Roland's generic RDMA connection API and did 
> the iWARP implementation, would you still need to add the iw_cm 
> structure?

Yes.

The struct iw_cm allows the RNIC device to export a set of high level
connection verbs, if that device supports it.

Hope this helps...

Steve.

___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general


Re: [openib-general] [PATCH][iWARP] IW CM Verbs

2005-08-29 Thread James Lentini


On Fri, 26 Aug 2005, Tom Tucker wrote:

> Index: ib_verbs.h
> ===
> --- ib_verbs.h(revision 3120)
> +++ ib_verbs.h(working copy)
> @@ -804,6 +806,7 @@
>   struct ib_gid_cache   **gid_cache;
>  };
>  
> +struct iw_cm;
>  struct ib_device {
>   struct device*dma_device;
>  
> @@ -820,6 +823,8 @@
>  
>   u32   flags;
>  
> + struct iw_cm  *iwcm;
> +
>   int(*query_device)(struct ib_device *device,
>  struct ib_device_attr 
> *device_attr);
>   int(*query_port)(struct ib_device *device,

Why does the ib_device need a cm structure for iWARP but not IB? If 
you used either Guy or Roland's generic RDMA connection API and did 
the iWARP implementation, would you still need to add the iw_cm 
structure?
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general


Re: [openib-general] [PATCH][iWARP] IW CM Verbs

2005-08-26 Thread Nishanth Aravamudan
On 26.08.2005 [14:44:25 -0400], Tom Tucker wrote:
> 
> This is a cleaned up version of the iWARP CM verbs based 
> on feedback from Roland and Sean. I've added a new file to 
> contain the iw specific types and changed the iw specific
> type prefix to iw_.
> 
> Please comment, and if it looks good, I'll commit this to the
> iWARP branch tonight.

Just a small nit about your mailer perhaps :)

>   int(*query_device)(struct ib_device
> *device,

Seems like lines are getting wrapped? Any chance to get around this?
Makes it a bit hard to read the patches...

Thanks,
Nish
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general

To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general