Re: [PATCH] core/addr: fix compilation warning {was Re:[openib-general] Latest build test results}
On 17.10.2005 [10:54:21 -0700], Roland Dreier wrote: > Sean> Does anyone know the reason for this change? > > From the git tree, I can tell you that the change is from the commit: > > diff-tree f2ccd8fa06c8e302116e71df372f5c1f83432e03 (from > b6b99eb5409d75ae35390057cd28f3aedfbd4cf4) > Author: David S. Miller <[EMAIL PROTECTED]> > Date: Tue Aug 9 19:34:12 2005 -0700 > > [NET]: Kill skb->real_dev > > Bonding just wants the device before the skb_bond() > decapsulation occurs, so simply pass that original > device into packet_type->func() as an argument. > > It remains to be seen whether we can use this same > exact thing to get rid of skb->input_dev as well. > > Signed-off-by: David S. Miller <[EMAIL PROTECTED]> > > it looks like the networking stack now passes the real device into > packet_type.func as orig_dev, rather than having the function look at > skb->real_dev. So, if I understand David's comment correctly, it's a structure size reduction and a small API change? That probably means we've caught all the bugs that exist right now (compilation wise), as I'm not seeing any in the svn kernel tree with the handful of patches in this thread. And I guess there are any users of real_dev in the tree that we need to worry about, as those would have spat warnings too. Thanks, Nish ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [PATCH] core/addr: fix compilation warning {was Re:[openib-general] Latest build test results}
Sean> Does anyone know the reason for this change? >From the git tree, I can tell you that the change is from the commit: diff-tree f2ccd8fa06c8e302116e71df372f5c1f83432e03 (from b6b99eb5409d75ae35390057cd28f3aedfbd4cf4) Author: David S. Miller <[EMAIL PROTECTED]> Date: Tue Aug 9 19:34:12 2005 -0700 [NET]: Kill skb->real_dev Bonding just wants the device before the skb_bond() decapsulation occurs, so simply pass that original device into packet_type->func() as an argument. It remains to be seen whether we can use this same exact thing to get rid of skb->input_dev as well. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> it looks like the networking stack now passes the real device into packet_type.func as orig_dev, rather than having the function look at skb->real_dev. - R. ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [PATCH] core/addr: fix compilation warning {was Re: [openib-general] Latest build test results}
On Sat, 2005-10-15 at 12:56, Nishanth Aravamudan wrote:
> > Thanks for trying out these patches. Sorry for the manual intervention.
>
> No problem; it unfortunately wasn't as simple as just editing the
> patches, as when I did so, all the hunks would fail. So I just
> regenerated them locally against current-git. Not a big deal, since
> these were small changes.
>
> > I regenerated the patches for fib_frontend.c, at.c, and sdp_link.c and
> > they are in linux-kernel/patches. Hopefully these will work with your
> > automated build system. These are found in linux-kernel/patches as:
> > linux-2.6.14-rc3-at.diff
> > linux-2.6.14-rc3-fib-frontend.diff
> > linux-2.6.14-rc3-sdp_link.diff
>
> Those look great and are identical to the ones I generated. So, my
> Acked-by applies to those 3.
>
> > Dan will be checking in the iser.h fix.
>
> Ok, great!
>
> I think the core/addr.c problem can be fixed with the following:
>
> Thanks,
> Nish
>
> Description: Fix a compilation warning in core/addr.c due to
> packet_type's func member changing prototype.
>
> Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]>
>
> ---
>
> diff -urpN linux-2.6.14-rc4-git4-dev/drivers/infiniband/core/addr.c
> linux-2.6.14-rc4-git4-dev2/drivers/infiniband/core/addr.c
> --- linux-2.6.14-rc4-git4-dev/drivers/infiniband/core/addr.c 2005-10-15
> 09:52:26.0 -0700
> +++ linux-2.6.14-rc4-git4-dev2/drivers/infiniband/core/addr.c 2005-10-15
> 09:52:56.0 -0700
> @@ -310,7 +310,7 @@ void ib_addr_cancel(struct ib_addr *addr
> EXPORT_SYMBOL(ib_addr_cancel);
>
> static int addr_arp_recv(struct sk_buff *skb, struct net_device *dev,
> - struct packet_type *pkt)
> + struct packet_type *pkt, struct net_device *orig_dev)
> {
> struct arphdr *arp_hdr;
Thanks. I just added that one as
linux-kernel/patches/linux-2.6.14-rc3-addr.diff
-- Hal
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
[PATCH] core/addr: fix compilation warning {was Re: [openib-general] Latest build test results}
On 15.10.2005 [06:05:54 -0400], Hal Rosenstock wrote:
> Hi Nish,
>
> On Sat, 2005-10-15 at 01:24, Nishanth Aravamudan wrote:
> > On 11.10.2005 [23:15:27 -0400], Hal Rosenstock wrote:
> > > Hi again Nish,
> > >
> > > On Tue, 2005-10-11 at 21:39, Nishanth Aravamudan wrote:
> > > > > > > Update arp_recv functions to latest 2.6.14 netdevice.h API for
> > > > > > > struct
> > > > > > > packet_type
> > > > > >
> > > > > > Sorry for the delay, I haven't yet had time to test the patches :/
> > > > > > I'll
> > > > > > try to get to it tonight or tomorrow.
> > > > > >
> > > > > > Is there anyway you can send me patches against the kernel tree as
> > > > > > opposed to the svn repo? It makes my side of things *a lot* easier,
> > > > > > as
> > > > > > right now I have to take your patch against svn and either
> > > > > > hand-edit or
> > > > > > patch my checkout and then diff against the current kernel tree.
> > > > >
> > > > > Since you were reporting iSER, AT, and SDP compile warnings/errors,
> > > > > aren't you using the latest OpenIB svn tree with 2.6.14-rc3 ?
> > > >
> > > > Yes; but you have to understand that the automated build system I have
> > > > access to 1) does not have external internet access (i.e., to the svn
> > > > tree) and 2) only builds kernels unless I manually send commands to the
> > > > terminal.
> > > >
> > > > So, the way I'm doing things is:
> > > >
> > > > Send in 4 jobs for mainline (x86 and ppc64 with =y and =m) and then
> > > > generate a patch of the latest svn tree against the current -git release
> > > > (a patch to the kernel) and send it in as a parameter to my builds to
> > > > test the latest svn tree. This leads to another 4 jobs (x86 and ppc64
> > > > with =y and =m).
> > > >
> > > > I'm *only* doing kernel build testing right now.
> > > >
> > > > > Which patches are you referring to ? Was it the fib_frontend.c one ?
> > > > > Not sure why they would need any manual fixup. At least that one was
> > > > > pretty straightforward.
> > > >
> > > > In the sense that I have to edit them to kernel relative paths, not in
> > > > the content of the patch. To test any patch in the system I have access
> > > > to, it needs to be a normal kernel patch (-p1 applicable to the base
> > > > tree).
> > > >
> > > > Going through and manually applying patches to the svn tree and then
> > > > regenerating the diff completely defeats the purpose of automated
> > > > compilation testing.
> > >
> > > OK. Do you need any patches regenerated or is this more for the future ?
> >
> > Please check-in the at.c, sdp_link.c and iser.h fixes, as now gen2 code
> > builds on x86 and ppc64 with only the following warning (which I believe
> > is new)
> >
> > drivers/infiniband/core/addr.c:330: warning: initialization from
> > incompatible pointer type
> >
> > when the patches are applied. Without them the x86 build fails
> > completely and the ppc64 build emits several warning.
> >
> > Sorry for the *long* delay, it took a bit of effort to get the patches
> > to cooperate with our automated build system. Thanks to Hal for his
> > quick response and generous patience in waiting for my ack.
> >
> > So, officially, I give
> >
> > Acked-by: Nishanth Aravamudan <[EMAIL PROTECTED]>
> >
> > to the at.c, sdp_link.c and iser.h fixes.
>
> Thanks for trying out these patches. Sorry for the manual intervention.
No problem; it unfortunately wasn't as simple as just editing the
patches, as when I did so, all the hunks would fail. So I just
regenerated them locally against current-git. Not a big deal, since
these were small changes.
> I regenerated the patches for fib_frontend.c, at.c, and sdp_link.c and
> they are in linux-kernel/patches. Hopefully these will work with your
> automated build system. These are found in linux-kernel/patches as:
> linux-2.6.14-rc3-at.diff
> linux-2.6.14-rc3-fib-frontend.diff
> linux-2.6.14-rc3-sdp_link.diff
Those look great and are identical to the ones I generated. So, my
Acked-by applies to those 3.
> Dan will be checking in the iser.h fix.
Ok, great!
I think the core/addr.c problem can be fixed with the following:
Thanks,
Nish
Description: Fix a compilation warning in core/addr.c due to
packet_type's func member changing prototype.
Signed-off-by: Nishanth Aravamudan <[EMAIL PROTECTED]>
---
diff -urpN linux-2.6.14-rc4-git4-dev/drivers/infiniband/core/addr.c
linux-2.6.14-rc4-git4-dev2/drivers/infiniband/core/addr.c
--- linux-2.6.14-rc4-git4-dev/drivers/infiniband/core/addr.c2005-10-15
09:52:26.0 -0700
+++ linux-2.6.14-rc4-git4-dev2/drivers/infiniband/core/addr.c 2005-10-15
09:52:56.0 -0700
@@ -310,7 +310,7 @@ void ib_addr_cancel(struct ib_addr *addr
EXPORT_SYMBOL(ib_addr_cancel);
static int addr_arp_recv(struct sk_buff *skb, struct net_device *dev,
-struct packet_type *pkt)
+struct packet_type *pkt, struct net_device *orig_dev)
{
struct arphdr *arp_hdr;
_
Re: [openib-general] Latest build test results
Hi Nish, On Sat, 2005-10-15 at 01:24, Nishanth Aravamudan wrote: > On 11.10.2005 [23:15:27 -0400], Hal Rosenstock wrote: > > Hi again Nish, > > > > On Tue, 2005-10-11 at 21:39, Nishanth Aravamudan wrote: > > > > > > Update arp_recv functions to latest 2.6.14 netdevice.h API for > > > > > > struct > > > > > > packet_type > > > > > > > > > > Sorry for the delay, I haven't yet had time to test the patches :/ > > > > > I'll > > > > > try to get to it tonight or tomorrow. > > > > > > > > > > Is there anyway you can send me patches against the kernel tree as > > > > > opposed to the svn repo? It makes my side of things *a lot* easier, as > > > > > right now I have to take your patch against svn and either hand-edit > > > > > or > > > > > patch my checkout and then diff against the current kernel tree. > > > > > > > > Since you were reporting iSER, AT, and SDP compile warnings/errors, > > > > aren't you using the latest OpenIB svn tree with 2.6.14-rc3 ? > > > > > > Yes; but you have to understand that the automated build system I have > > > access to 1) does not have external internet access (i.e., to the svn > > > tree) and 2) only builds kernels unless I manually send commands to the > > > terminal. > > > > > > So, the way I'm doing things is: > > > > > > Send in 4 jobs for mainline (x86 and ppc64 with =y and =m) and then > > > generate a patch of the latest svn tree against the current -git release > > > (a patch to the kernel) and send it in as a parameter to my builds to > > > test the latest svn tree. This leads to another 4 jobs (x86 and ppc64 > > > with =y and =m). > > > > > > I'm *only* doing kernel build testing right now. > > > > > > > Which patches are you referring to ? Was it the fib_frontend.c one ? > > > > Not sure why they would need any manual fixup. At least that one was > > > > pretty straightforward. > > > > > > In the sense that I have to edit them to kernel relative paths, not in > > > the content of the patch. To test any patch in the system I have access > > > to, it needs to be a normal kernel patch (-p1 applicable to the base > > > tree). > > > > > > Going through and manually applying patches to the svn tree and then > > > regenerating the diff completely defeats the purpose of automated > > > compilation testing. > > > > OK. Do you need any patches regenerated or is this more for the future ? > > Please check-in the at.c, sdp_link.c and iser.h fixes, as now gen2 code > builds on x86 and ppc64 with only the following warning (which I believe > is new) > > drivers/infiniband/core/addr.c:330: warning: initialization from incompatible > pointer type > > when the patches are applied. Without them the x86 build fails > completely and the ppc64 build emits several warning. > > Sorry for the *long* delay, it took a bit of effort to get the patches > to cooperate with our automated build system. Thanks to Hal for his > quick response and generous patience in waiting for my ack. > > So, officially, I give > > Acked-by: Nishanth Aravamudan <[EMAIL PROTECTED]> > > to the at.c, sdp_link.c and iser.h fixes. Thanks for trying out these patches. Sorry for the manual intervention. I regenerated the patches for fib_frontend.c, at.c, and sdp_link.c and they are in linux-kernel/patches. Hopefully these will work with your automated build system. These are found in linux-kernel/patches as: linux-2.6.14-rc3-at.diff linux-2.6.14-rc3-fib-frontend.diff linux-2.6.14-rc3-sdp_link.diff Dan will be checking in the iser.h fix. -- Hal ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
On 11.10.2005 [23:15:27 -0400], Hal Rosenstock wrote: > Hi again Nish, > > On Tue, 2005-10-11 at 21:39, Nishanth Aravamudan wrote: > > > > > Update arp_recv functions to latest 2.6.14 netdevice.h API for struct > > > > > packet_type > > > > > > > > Sorry for the delay, I haven't yet had time to test the patches :/ I'll > > > > try to get to it tonight or tomorrow. > > > > > > > > Is there anyway you can send me patches against the kernel tree as > > > > opposed to the svn repo? It makes my side of things *a lot* easier, as > > > > right now I have to take your patch against svn and either hand-edit or > > > > patch my checkout and then diff against the current kernel tree. > > > > > > Since you were reporting iSER, AT, and SDP compile warnings/errors, > > > aren't you using the latest OpenIB svn tree with 2.6.14-rc3 ? > > > > Yes; but you have to understand that the automated build system I have > > access to 1) does not have external internet access (i.e., to the svn > > tree) and 2) only builds kernels unless I manually send commands to the > > terminal. > > > > So, the way I'm doing things is: > > > > Send in 4 jobs for mainline (x86 and ppc64 with =y and =m) and then > > generate a patch of the latest svn tree against the current -git release > > (a patch to the kernel) and send it in as a parameter to my builds to > > test the latest svn tree. This leads to another 4 jobs (x86 and ppc64 > > with =y and =m). > > > > I'm *only* doing kernel build testing right now. > > > > > Which patches are you referring to ? Was it the fib_frontend.c one ? > > > Not sure why they would need any manual fixup. At least that one was > > > pretty straightforward. > > > > In the sense that I have to edit them to kernel relative paths, not in > > the content of the patch. To test any patch in the system I have access > > to, it needs to be a normal kernel patch (-p1 applicable to the base > > tree). > > > > Going through and manually applying patches to the svn tree and then > > regenerating the diff completely defeats the purpose of automated > > compilation testing. > > OK. Do you need any patches regenerated or is this more for the future ? Please check-in the at.c, sdp_link.c and iser.h fixes, as now gen2 code builds on x86 and ppc64 with only the following warning (which I believe is new) drivers/infiniband/core/addr.c:330: warning: initialization from incompatible pointer type when the patches are applied. Without them the x86 build fails completely and the ppc64 build emits several warning. Sorry for the *long* delay, it took a bit of effort to get the patches to cooperate with our automated build system. Thanks to Hal for his quick response and generous patience in waiting for my ack. So, officially, I give Acked-by: Nishanth Aravamudan <[EMAIL PROTECTED]> to the at.c, sdp_link.c and iser.h fixes. Thanks, Nish ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
On 11.10.2005 [23:15:27 -0400], Hal Rosenstock wrote: > Hi again Nish, > > On Tue, 2005-10-11 at 21:39, Nishanth Aravamudan wrote: > > > > > Update arp_recv functions to latest 2.6.14 netdevice.h API for struct > > > > > packet_type > > > > > > > > Sorry for the delay, I haven't yet had time to test the patches :/ I'll > > > > try to get to it tonight or tomorrow. > > > > > > > > Is there anyway you can send me patches against the kernel tree as > > > > opposed to the svn repo? It makes my side of things *a lot* easier, as > > > > right now I have to take your patch against svn and either hand-edit or > > > > patch my checkout and then diff against the current kernel tree. > > > > > > Since you were reporting iSER, AT, and SDP compile warnings/errors, > > > aren't you using the latest OpenIB svn tree with 2.6.14-rc3 ? > > > > Yes; but you have to understand that the automated build system I have > > access to 1) does not have external internet access (i.e., to the svn > > tree) and 2) only builds kernels unless I manually send commands to the > > terminal. > > > > So, the way I'm doing things is: > > > > Send in 4 jobs for mainline (x86 and ppc64 with =y and =m) and then > > generate a patch of the latest svn tree against the current -git release > > (a patch to the kernel) and send it in as a parameter to my builds to > > test the latest svn tree. This leads to another 4 jobs (x86 and ppc64 > > with =y and =m). > > > > I'm *only* doing kernel build testing right now. > > > > > Which patches are you referring to ? Was it the fib_frontend.c one ? > > > Not sure why they would need any manual fixup. At least that one was > > > pretty straightforward. > > > > In the sense that I have to edit them to kernel relative paths, not in > > the content of the patch. To test any patch in the system I have access > > to, it needs to be a normal kernel patch (-p1 applicable to the base > > tree). > > > > Going through and manually applying patches to the svn tree and then > > regenerating the diff completely defeats the purpose of automated > > compilation testing. > > OK. Do you need any patches regenerated or is this more for the future ? If you could regen the patches, that would definitely speed things up for me, but I can handle these few, it's not a big deal. Definitely, in the future, it makes it an almost instantaneous build test if I have the kernel-relative patch. Thanks, Nish ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
Hi again Nish, On Tue, 2005-10-11 at 21:39, Nishanth Aravamudan wrote: > > > > Update arp_recv functions to latest 2.6.14 netdevice.h API for struct > > > > packet_type > > > > > > Sorry for the delay, I haven't yet had time to test the patches :/ I'll > > > try to get to it tonight or tomorrow. > > > > > > Is there anyway you can send me patches against the kernel tree as > > > opposed to the svn repo? It makes my side of things *a lot* easier, as > > > right now I have to take your patch against svn and either hand-edit or > > > patch my checkout and then diff against the current kernel tree. > > > > Since you were reporting iSER, AT, and SDP compile warnings/errors, > > aren't you using the latest OpenIB svn tree with 2.6.14-rc3 ? > > Yes; but you have to understand that the automated build system I have > access to 1) does not have external internet access (i.e., to the svn > tree) and 2) only builds kernels unless I manually send commands to the > terminal. > > So, the way I'm doing things is: > > Send in 4 jobs for mainline (x86 and ppc64 with =y and =m) and then > generate a patch of the latest svn tree against the current -git release > (a patch to the kernel) and send it in as a parameter to my builds to > test the latest svn tree. This leads to another 4 jobs (x86 and ppc64 > with =y and =m). > > I'm *only* doing kernel build testing right now. > > > Which patches are you referring to ? Was it the fib_frontend.c one ? > > Not sure why they would need any manual fixup. At least that one was > > pretty straightforward. > > In the sense that I have to edit them to kernel relative paths, not in > the content of the patch. To test any patch in the system I have access > to, it needs to be a normal kernel patch (-p1 applicable to the base > tree). > > Going through and manually applying patches to the svn tree and then > regenerating the diff completely defeats the purpose of automated > compilation testing. OK. Do you need any patches regenerated or is this more for the future ? -- Hal ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
On 11.10.2005 [21:27:15 -0400], Hal Rosenstock wrote: > Hi Nish, > > On Tue, 2005-10-11 at 17:45, Nishanth Aravamudan wrote: > > On 07.10.2005 [09:48:56 -0400], Hal Rosenstock wrote: > > > On Thu, 2005-10-06 at 15:26, Hal Rosenstock wrote: > > > > On Thu, 2005-10-06 at 15:20, Nishanth Aravamudan wrote: > > > > > On 06.10.2005 [13:25:35 -0400], Hal Rosenstock wrote: > > > > > > On Thu, 2005-10-06 at 13:11, Nishanth Aravamudan wrote: > > > > > > > On 06.10.2005 [19:40:40 +0300], Dan Bar Dov wrote: > > > > > > > > I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 > > > > > > > > in version 3682. > > > > > > > > > > > > > > Great! Thanks. > > > > > > > > > > > > > > I'm re-running the tests (due to a subtle flaw in my PATH, my > > > > > > > cronjobs > > > > > > > weren't running) now and will post the latest results. > > > > > > > > > > > > You might also want to apply > > > > > > https://openib.org/svn/gen2/trunk/src/linux-kernel/patches/linux-2.6.14-rc3-fib-frontend.diff > > > > > > to get rid of the AT and SDP warnings. > > > > > > > > > > This patch does remove the warning regarding undefined symbols during > > > > > modpost, but does not remove the warnings > > > > > > > > > > drivers/infiniband/core/at.c:1547: warning: initialization from > > > > > incompatible pointer type > > > > > > > > > > drivers/infiniband/ulp/sdp/sdp_link.c:752: warning: initialization > > > > > from incompatible pointer type > > > > > > > > Right. Roland reported a change to struct packet_type in 2.6.14. I'll > > > > work on a patch for this too. Thanks. > > > > > > Can you try this patch for the above 2 warnings ? If it works, I check > > > it into the patches directory. Thanks. > > > > > > -- Hal > > > > > > Update arp_recv functions to latest 2.6.14 netdevice.h API for struct > > > packet_type > > > > Sorry for the delay, I haven't yet had time to test the patches :/ I'll > > try to get to it tonight or tomorrow. > > > > Is there anyway you can send me patches against the kernel tree as > > opposed to the svn repo? It makes my side of things *a lot* easier, as > > right now I have to take your patch against svn and either hand-edit or > > patch my checkout and then diff against the current kernel tree. > > Since you were reporting iSER, AT, and SDP compile warnings/errors, > aren't you using the latest OpenIB svn tree with 2.6.14-rc3 ? Yes; but you have to understand that the automated build system I have access to 1) does not have external internet access (i.e., to the svn tree) and 2) only builds kernels unless I manually send commands to the terminal. So, the way I'm doing things is: Send in 4 jobs for mainline (x86 and ppc64 with =y and =m) and then generate a patch of the latest svn tree against the current -git release (a patch to the kernel) and send it in as a parameter to my builds to test the latest svn tree. This leads to another 4 jobs (x86 and ppc64 with =y and =m). I'm *only* doing kernel build testing right now. > Which patches are you referring to ? Was it the fib_frontend.c one ? > Not sure why they would need any manual fixup. At least that one was > pretty straightforward. In the sense that I have to edit them to kernel relative paths, not in the content of the patch. To test any patch in the system I have access to, it needs to be a normal kernel patch (-p1 applicable to the base tree). Going through and manually applying patches to the svn tree and then regenerating the diff completely defeats the purpose of automated compilation testing. > 2.6.14-rc4 is out now. Yes, I know. Thanks, Nish ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
Hi Nish, On Tue, 2005-10-11 at 17:45, Nishanth Aravamudan wrote: > On 07.10.2005 [09:48:56 -0400], Hal Rosenstock wrote: > > On Thu, 2005-10-06 at 15:26, Hal Rosenstock wrote: > > > On Thu, 2005-10-06 at 15:20, Nishanth Aravamudan wrote: > > > > On 06.10.2005 [13:25:35 -0400], Hal Rosenstock wrote: > > > > > On Thu, 2005-10-06 at 13:11, Nishanth Aravamudan wrote: > > > > > > On 06.10.2005 [19:40:40 +0300], Dan Bar Dov wrote: > > > > > > > I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 > > > > > > > in version 3682. > > > > > > > > > > > > Great! Thanks. > > > > > > > > > > > > I'm re-running the tests (due to a subtle flaw in my PATH, my > > > > > > cronjobs > > > > > > weren't running) now and will post the latest results. > > > > > > > > > > You might also want to apply > > > > > https://openib.org/svn/gen2/trunk/src/linux-kernel/patches/linux-2.6.14-rc3-fib-frontend.diff > > > > > to get rid of the AT and SDP warnings. > > > > > > > > This patch does remove the warning regarding undefined symbols during > > > > modpost, but does not remove the warnings > > > > > > > > drivers/infiniband/core/at.c:1547: warning: initialization from > > > > incompatible pointer type > > > > > > > > drivers/infiniband/ulp/sdp/sdp_link.c:752: warning: initialization from > > > > incompatible pointer type > > > > > > Right. Roland reported a change to struct packet_type in 2.6.14. I'll > > > work on a patch for this too. Thanks. > > > > Can you try this patch for the above 2 warnings ? If it works, I check > > it into the patches directory. Thanks. > > > > -- Hal > > > > Update arp_recv functions to latest 2.6.14 netdevice.h API for struct > > packet_type > > Sorry for the delay, I haven't yet had time to test the patches :/ I'll > try to get to it tonight or tomorrow. > > Is there anyway you can send me patches against the kernel tree as > opposed to the svn repo? It makes my side of things *a lot* easier, as > right now I have to take your patch against svn and either hand-edit or > patch my checkout and then diff against the current kernel tree. Since you were reporting iSER, AT, and SDP compile warnings/errors, aren't you using the latest OpenIB svn tree with 2.6.14-rc3 ? Which patches are you referring to ? Was it the fib_frontend.c one ? Not sure why they would need any manual fixup. At least that one was pretty straightforward. 2.6.14-rc4 is out now. -- Hal ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
On 07.10.2005 [09:48:56 -0400], Hal Rosenstock wrote: > On Thu, 2005-10-06 at 15:26, Hal Rosenstock wrote: > > On Thu, 2005-10-06 at 15:20, Nishanth Aravamudan wrote: > > > On 06.10.2005 [13:25:35 -0400], Hal Rosenstock wrote: > > > > On Thu, 2005-10-06 at 13:11, Nishanth Aravamudan wrote: > > > > > On 06.10.2005 [19:40:40 +0300], Dan Bar Dov wrote: > > > > > > I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 in > > > > > > version 3682. > > > > > > > > > > Great! Thanks. > > > > > > > > > > I'm re-running the tests (due to a subtle flaw in my PATH, my cronjobs > > > > > weren't running) now and will post the latest results. > > > > > > > > You might also want to apply > > > > https://openib.org/svn/gen2/trunk/src/linux-kernel/patches/linux-2.6.14-rc3-fib-frontend.diff > > > > to get rid of the AT and SDP warnings. > > > > > > This patch does remove the warning regarding undefined symbols during > > > modpost, but does not remove the warnings > > > > > > drivers/infiniband/core/at.c:1547: warning: initialization from > > > incompatible pointer type > > > > > > drivers/infiniband/ulp/sdp/sdp_link.c:752: warning: initialization from > > > incompatible pointer type > > > > Right. Roland reported a change to struct packet_type in 2.6.14. I'll > > work on a patch for this too. Thanks. > > Can you try this patch for the above 2 warnings ? If it works, I check > it into the patches directory. Thanks. > > -- Hal > > Update arp_recv functions to latest 2.6.14 netdevice.h API for struct > packet_type Sorry for the delay, I haven't yet had time to test the patches :/ I'll try to get to it tonight or tomorrow. Is there anyway you can send me patches against the kernel tree as opposed to the svn repo? It makes my side of things *a lot* easier, as right now I have to take your patch against svn and either hand-edit or patch my checkout and then diff against the current kernel tree. Thanks, Nish ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
On 07.10.2005 [09:48:56 -0400], Hal Rosenstock wrote: > On Thu, 2005-10-06 at 15:26, Hal Rosenstock wrote: > > On Thu, 2005-10-06 at 15:20, Nishanth Aravamudan wrote: > > > On 06.10.2005 [13:25:35 -0400], Hal Rosenstock wrote: > > > > On Thu, 2005-10-06 at 13:11, Nishanth Aravamudan wrote: > > > > > On 06.10.2005 [19:40:40 +0300], Dan Bar Dov wrote: > > > > > > I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 in > > > > > > version 3682. > > > > > > > > > > Great! Thanks. > > > > > > > > > > I'm re-running the tests (due to a subtle flaw in my PATH, my cronjobs > > > > > weren't running) now and will post the latest results. > > > > > > > > You might also want to apply > > > > https://openib.org/svn/gen2/trunk/src/linux-kernel/patches/linux-2.6.14-rc3-fib-frontend.diff > > > > to get rid of the AT and SDP warnings. > > > > > > This patch does remove the warning regarding undefined symbols during > > > modpost, but does not remove the warnings > > > > > > drivers/infiniband/core/at.c:1547: warning: initialization from > > > incompatible pointer type > > > > > > drivers/infiniband/ulp/sdp/sdp_link.c:752: warning: initialization from > > > incompatible pointer type > > > > Right. Roland reported a change to struct packet_type in 2.6.14. I'll > > work on a patch for this too. Thanks. > > Can you try this patch for the above 2 warnings ? If it works, I check > it into the patches directory. Thanks. Will try this along with the other patch you sent after I return from class (about 2 hours). Thanks, Nish ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
On Thu, 2005-10-06 at 15:26, Hal Rosenstock wrote:
> On Thu, 2005-10-06 at 15:20, Nishanth Aravamudan wrote:
> > On 06.10.2005 [13:25:35 -0400], Hal Rosenstock wrote:
> > > On Thu, 2005-10-06 at 13:11, Nishanth Aravamudan wrote:
> > > > On 06.10.2005 [19:40:40 +0300], Dan Bar Dov wrote:
> > > > > I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 in
> > > > > version 3682.
> > > >
> > > > Great! Thanks.
> > > >
> > > > I'm re-running the tests (due to a subtle flaw in my PATH, my cronjobs
> > > > weren't running) now and will post the latest results.
> > >
> > > You might also want to apply
> > > https://openib.org/svn/gen2/trunk/src/linux-kernel/patches/linux-2.6.14-rc3-fib-frontend.diff
> > > to get rid of the AT and SDP warnings.
> >
> > This patch does remove the warning regarding undefined symbols during
> > modpost, but does not remove the warnings
> >
> > drivers/infiniband/core/at.c:1547: warning: initialization from
> > incompatible pointer type
> >
> > drivers/infiniband/ulp/sdp/sdp_link.c:752: warning: initialization from
> > incompatible pointer type
>
> Right. Roland reported a change to struct packet_type in 2.6.14. I'll
> work on a patch for this too. Thanks.
Can you try this patch for the above 2 warnings ? If it works, I check
it into the patches directory. Thanks.
-- Hal
Update arp_recv functions to latest 2.6.14 netdevice.h API for struct
packet_type
Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]>
Index: core/at.c
===
--- core/at.c (revision 3691)
+++ core/at.c (working copy)
@@ -1258,7 +1258,7 @@ static void ib_at_arp_work(void *data)
}
static int ib_at_arp_recv(struct sk_buff *skb, struct net_device *dev,
-struct packet_type *pt)
+ struct packet_type *pt, struct net_device *orig_dev)
{
struct arp_work *work;
struct arphdr *arp_hdr;
Index: ulp/sdp/sdp_link.c
===
--- ulp/sdp/sdp_link.c (revision 3691)
+++ ulp/sdp/sdp_link.c (working copy)
@@ -716,7 +716,7 @@ done:
* sdp_link_arp_recv - receive all ARP packets
*/
static int sdp_link_arp_recv(struct sk_buff *skb, struct net_device *dev,
-struct packet_type *pt)
+struct packet_type *pt, struct net_device
*orig_dev)
{
struct sdp_work *work;
struct arphdr *arp_hdr;
___
openib-general mailing list
openib-general@openib.org
http://openib.org/mailman/listinfo/openib-general
To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
On 07.10.2005 [08:21:19 -0400], Hal Rosenstock wrote: > On Thu, 2005-10-06 at 14:11, Nishanth Aravamudan wrote: > > On 06.10.2005 [13:25:35 -0400], Hal Rosenstock wrote: > > > On Thu, 2005-10-06 at 13:11, Nishanth Aravamudan wrote: > > > > On 06.10.2005 [19:40:40 +0300], Dan Bar Dov wrote: > > > > > I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 in > > > > > version 3682. > > > > > > > > Great! Thanks. > > > > > > > > I'm re-running the tests (due to a subtle flaw in my PATH, my cronjobs > > > > weren't running) now and will post the latest results. > > > > > > You might also want to apply > > > https://openib.org/svn/gen2/trunk/src/linux-kernel/patches/linux-2.6.14-rc3-fib-frontend.diff > > > to get rid of the AT and SDP warnings. > > > > I already submitted several jobs for 2.6.14-rc3-git6, but I'll redo the > > gen2 ones with that patch, thanks. > > > > Here are the results from 2.6.14-rc3-git6 + gen2 3683 > > > > Looks like x86 is broken in the current svn tree. > > > > x86 and ppc64 mainline is fine with both =y and =m > > > > ppc64 + gen2 =y > > > > drivers/infiniband/ulp/srp/ib_srp.c: In function `srp_process_rsp': > > drivers/infiniband/ulp/srp/ib_srp.c:650: warning: long long unsigned int > > format, u64 arg (arg 2) > > > > drivers/infiniband/core/at.c:1547: warning: initialization from > > incompatible pointer type > > > > drivers/infiniband/ulp/sdp/sdp_link.c:752: warning: initialization from > > incompatible pointer type > > > > ppc64 + gen2 =m > > > > same as above, plus > > > > *** Warning: ".ip_dev_find" [drivers/infiniband/ulp/sdp/ib_sdp.ko] > > undefined! > > *** Warning: ".ip_dev_find" [drivers/infiniband/core/ib_at.ko] undefined! > > > > x86 + gen2 =y *FAILED* > > What gcc version are you using ? I believe the build systems on all the automated machines are 2.95: Reading specs from /usr/lib/gcc-lib/i386-linux/2.95.4/specs gcc version 2.95.4 20011002 (Debian prerelease) > > drivers/infiniband/ulp/iser/iser_conn.c: In function `iser_adaptor_release': > > drivers/infiniband/ulp/iser/iser_conn.c:195: parse error before `)' > > drivers/infiniband/ulp/iser/iser_conn.c:203: parse error before `)' > > drivers/infiniband/ulp/iser/iser_conn.c:206: parse error before `)' > > drivers/infiniband/ulp/iser/iser_conn.c: In function `iser_conn_establish': > > drivers/infiniband/ulp/iser/iser_conn.c:284: parse error before `)' > > drivers/infiniband/ulp/iser/iser_conn.c: In function > > `iser_post_receive_control': > > drivers/infiniband/ulp/iser/iser_conn.c:861: parse error before `)' > > drivers/infiniband/ulp/iser/iser_conn.c:873: parse error before `)' > > > > drivers/infiniband/ulp/iser/iser_initiator.c: In function > > `iser_reg_rdma_mem': > > drivers/infiniband/ulp/iser/iser_initiator.c:125: parse error before `)' > > drivers/infiniband/ulp/iser/iser_initiator.c:130: parse error before `)' > > drivers/infiniband/ulp/iser/iser_initiator.c:141: parse error before `)' > > drivers/infiniband/ulp/iser/iser_initiator.c:153: parse error before `)' > > > > drivers/infiniband/ulp/iser/iser_mod.c: In function `init_module': > > drivers/infiniband/ulp/iser/iser_mod.c:154: parse error before `)' > > drivers/infiniband/ulp/iser/iser_mod.c: In function `cleanup_module': > > drivers/infiniband/ulp/iser/iser_mod.c:243: parse error before `)' > > > > drivers/infiniband/ulp/iser/iser_lkdapl.c: In function > > `iser_create_ia_pz_evd': > > drivers/infiniband/ulp/iser/iser_lkdapl.c:147: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c: In function > > `iser_consume_events': > > drivers/infiniband/ulp/iser/iser_lkdapl.c:691: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c: In function > > `iser_event_handler_thread': > > drivers/infiniband/ulp/iser/iser_lkdapl.c:731: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c:749: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c: In function > > `iser_handle_conn_event': > > drivers/infiniband/ulp/iser/iser_lkdapl.c:776: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c:779: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c:782: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c:785: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c:788: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c:791: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c:794: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c:797: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c:800: parse error before `)' > > drivers/infiniband/ulp/iser/iser_lkdapl.c: In function > > `iser_handle_single_kdapl_event': > > drivers/infiniband/ulp/iser/iser_lkdapl.c:1025: parse error before `)' > > > > x86 + gen2 =m *FAILED* > > > > same as above > > Can you try this patch and see if it eliminates the iser errors ? > Thanks. Will try it in a bit.
Re: [openib-general] Latest build test results
On Thu, 2005-10-06 at 14:11, Nishanth Aravamudan wrote:
> On 06.10.2005 [13:25:35 -0400], Hal Rosenstock wrote:
> > On Thu, 2005-10-06 at 13:11, Nishanth Aravamudan wrote:
> > > On 06.10.2005 [19:40:40 +0300], Dan Bar Dov wrote:
> > > > I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 in
> > > > version 3682.
> > >
> > > Great! Thanks.
> > >
> > > I'm re-running the tests (due to a subtle flaw in my PATH, my cronjobs
> > > weren't running) now and will post the latest results.
> >
> > You might also want to apply
> > https://openib.org/svn/gen2/trunk/src/linux-kernel/patches/linux-2.6.14-rc3-fib-frontend.diff
> > to get rid of the AT and SDP warnings.
>
> I already submitted several jobs for 2.6.14-rc3-git6, but I'll redo the
> gen2 ones with that patch, thanks.
>
> Here are the results from 2.6.14-rc3-git6 + gen2 3683
>
> Looks like x86 is broken in the current svn tree.
>
> x86 and ppc64 mainline is fine with both =y and =m
>
> ppc64 + gen2 =y
>
> drivers/infiniband/ulp/srp/ib_srp.c: In function `srp_process_rsp':
> drivers/infiniband/ulp/srp/ib_srp.c:650: warning: long long unsigned int
> format, u64 arg (arg 2)
>
> drivers/infiniband/core/at.c:1547: warning: initialization from incompatible
> pointer type
>
> drivers/infiniband/ulp/sdp/sdp_link.c:752: warning: initialization from
> incompatible pointer type
>
> ppc64 + gen2 =m
>
> same as above, plus
>
> *** Warning: ".ip_dev_find" [drivers/infiniband/ulp/sdp/ib_sdp.ko] undefined!
> *** Warning: ".ip_dev_find" [drivers/infiniband/core/ib_at.ko] undefined!
>
> x86 + gen2 =y *FAILED*
What gcc version are you using ?
> drivers/infiniband/ulp/iser/iser_conn.c: In function `iser_adaptor_release':
> drivers/infiniband/ulp/iser/iser_conn.c:195: parse error before `)'
> drivers/infiniband/ulp/iser/iser_conn.c:203: parse error before `)'
> drivers/infiniband/ulp/iser/iser_conn.c:206: parse error before `)'
> drivers/infiniband/ulp/iser/iser_conn.c: In function `iser_conn_establish':
> drivers/infiniband/ulp/iser/iser_conn.c:284: parse error before `)'
> drivers/infiniband/ulp/iser/iser_conn.c: In function
> `iser_post_receive_control':
> drivers/infiniband/ulp/iser/iser_conn.c:861: parse error before `)'
> drivers/infiniband/ulp/iser/iser_conn.c:873: parse error before `)'
>
> drivers/infiniband/ulp/iser/iser_initiator.c: In function `iser_reg_rdma_mem':
> drivers/infiniband/ulp/iser/iser_initiator.c:125: parse error before `)'
> drivers/infiniband/ulp/iser/iser_initiator.c:130: parse error before `)'
> drivers/infiniband/ulp/iser/iser_initiator.c:141: parse error before `)'
> drivers/infiniband/ulp/iser/iser_initiator.c:153: parse error before `)'
>
> drivers/infiniband/ulp/iser/iser_mod.c: In function `init_module':
> drivers/infiniband/ulp/iser/iser_mod.c:154: parse error before `)'
> drivers/infiniband/ulp/iser/iser_mod.c: In function `cleanup_module':
> drivers/infiniband/ulp/iser/iser_mod.c:243: parse error before `)'
>
> drivers/infiniband/ulp/iser/iser_lkdapl.c: In function
> `iser_create_ia_pz_evd':
> drivers/infiniband/ulp/iser/iser_lkdapl.c:147: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c: In function `iser_consume_events':
> drivers/infiniband/ulp/iser/iser_lkdapl.c:691: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c: In function
> `iser_event_handler_thread':
> drivers/infiniband/ulp/iser/iser_lkdapl.c:731: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c:749: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c: In function
> `iser_handle_conn_event':
> drivers/infiniband/ulp/iser/iser_lkdapl.c:776: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c:779: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c:782: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c:785: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c:788: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c:791: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c:794: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c:797: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c:800: parse error before `)'
> drivers/infiniband/ulp/iser/iser_lkdapl.c: In function
> `iser_handle_single_kdapl_event':
> drivers/infiniband/ulp/iser/iser_lkdapl.c:1025: parse error before `)'
>
> x86 + gen2 =m *FAILED*
>
> same as above
Can you try this patch and see if it eliminates the iser errors ?
Thanks.
-- Hal
Signed-off-by: Hal Rosenstock <[EMAIL PROTECTED]>
Index: iser.h
===
--- iser.h (revision 3691)
+++ iser.h (working copy)
@@ -334,7 +334,7 @@ extern int iser_debug_level;
do {\
if (iser_debug_level > 0) \
printk(KERN_DEBUG PFX "%s:" fmt,\
- __func__,
Re: [openib-general] Latest build test results
On Thu, 2005-10-06 at 15:20, Nishanth Aravamudan wrote: > On 06.10.2005 [13:25:35 -0400], Hal Rosenstock wrote: > > On Thu, 2005-10-06 at 13:11, Nishanth Aravamudan wrote: > > > On 06.10.2005 [19:40:40 +0300], Dan Bar Dov wrote: > > > > I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 in > > > > version 3682. > > > > > > Great! Thanks. > > > > > > I'm re-running the tests (due to a subtle flaw in my PATH, my cronjobs > > > weren't running) now and will post the latest results. > > > > You might also want to apply > > https://openib.org/svn/gen2/trunk/src/linux-kernel/patches/linux-2.6.14-rc3-fib-frontend.diff > > to get rid of the AT and SDP warnings. > > This patch does remove the warning regarding undefined symbols during > modpost, but does not remove the warnings > > drivers/infiniband/core/at.c:1547: warning: initialization from incompatible > pointer type > > drivers/infiniband/ulp/sdp/sdp_link.c:752: warning: initialization from > incompatible pointer type Right. Roland reported a change to struct packet_type in 2.6.14. I'll work on a patch for this too. Thanks. -- Hal ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
On 06.10.2005 [13:25:35 -0400], Hal Rosenstock wrote: > On Thu, 2005-10-06 at 13:11, Nishanth Aravamudan wrote: > > On 06.10.2005 [19:40:40 +0300], Dan Bar Dov wrote: > > > I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 in > > > version 3682. > > > > Great! Thanks. > > > > I'm re-running the tests (due to a subtle flaw in my PATH, my cronjobs > > weren't running) now and will post the latest results. > > You might also want to apply > https://openib.org/svn/gen2/trunk/src/linux-kernel/patches/linux-2.6.14-rc3-fib-frontend.diff > to get rid of the AT and SDP warnings. This patch does remove the warning regarding undefined symbols during modpost, but does not remove the warnings drivers/infiniband/core/at.c:1547: warning: initialization from incompatible pointer type drivers/infiniband/ulp/sdp/sdp_link.c:752: warning: initialization from incompatible pointer type Thanks, Nish ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
On 06.10.2005 [13:25:35 -0400], Hal Rosenstock wrote: > On Thu, 2005-10-06 at 13:11, Nishanth Aravamudan wrote: > > On 06.10.2005 [19:40:40 +0300], Dan Bar Dov wrote: > > > I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 in > > > version 3682. > > > > Great! Thanks. > > > > I'm re-running the tests (due to a subtle flaw in my PATH, my cronjobs > > weren't running) now and will post the latest results. > > You might also want to apply > https://openib.org/svn/gen2/trunk/src/linux-kernel/patches/linux-2.6.14-rc3-fib-frontend.diff > to get rid of the AT and SDP warnings. I already submitted several jobs for 2.6.14-rc3-git6, but I'll redo the gen2 ones with that patch, thanks. Here are the results from 2.6.14-rc3-git6 + gen2 3683 Looks like x86 is broken in the current svn tree. x86 and ppc64 mainline is fine with both =y and =m ppc64 + gen2 =y drivers/infiniband/ulp/srp/ib_srp.c: In function `srp_process_rsp': drivers/infiniband/ulp/srp/ib_srp.c:650: warning: long long unsigned int format, u64 arg (arg 2) drivers/infiniband/core/at.c:1547: warning: initialization from incompatible pointer type drivers/infiniband/ulp/sdp/sdp_link.c:752: warning: initialization from incompatible pointer type ppc64 + gen2 =m same as above, plus *** Warning: ".ip_dev_find" [drivers/infiniband/ulp/sdp/ib_sdp.ko] undefined! *** Warning: ".ip_dev_find" [drivers/infiniband/core/ib_at.ko] undefined! x86 + gen2 =y *FAILED* drivers/infiniband/ulp/sdp/sdp_link.c:752: warning: initialization from incompatible pointer type drivers/infiniband/core/at.c:1547: warning: initialization from incompatible pointer type drivers/infiniband/ulp/iser/iser_conn.c: In function `iser_adaptor_release': drivers/infiniband/ulp/iser/iser_conn.c:195: parse error before `)' drivers/infiniband/ulp/iser/iser_conn.c:203: parse error before `)' drivers/infiniband/ulp/iser/iser_conn.c:206: parse error before `)' drivers/infiniband/ulp/iser/iser_conn.c: In function `iser_conn_establish': drivers/infiniband/ulp/iser/iser_conn.c:284: parse error before `)' drivers/infiniband/ulp/iser/iser_conn.c: In function `iser_post_receive_control': drivers/infiniband/ulp/iser/iser_conn.c:861: parse error before `)' drivers/infiniband/ulp/iser/iser_conn.c:873: parse error before `)' drivers/infiniband/ulp/iser/iser_initiator.c: In function `iser_reg_rdma_mem': drivers/infiniband/ulp/iser/iser_initiator.c:125: parse error before `)' drivers/infiniband/ulp/iser/iser_initiator.c:130: parse error before `)' drivers/infiniband/ulp/iser/iser_initiator.c:141: parse error before `)' drivers/infiniband/ulp/iser/iser_initiator.c:153: parse error before `)' drivers/infiniband/ulp/iser/iser_mod.c: In function `init_module': drivers/infiniband/ulp/iser/iser_mod.c:154: parse error before `)' drivers/infiniband/ulp/iser/iser_mod.c: In function `cleanup_module': drivers/infiniband/ulp/iser/iser_mod.c:243: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c: In function `iser_create_ia_pz_evd': drivers/infiniband/ulp/iser/iser_lkdapl.c:147: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c: In function `iser_consume_events': drivers/infiniband/ulp/iser/iser_lkdapl.c:691: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c: In function `iser_event_handler_thread': drivers/infiniband/ulp/iser/iser_lkdapl.c:731: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c:749: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c: In function `iser_handle_conn_event': drivers/infiniband/ulp/iser/iser_lkdapl.c:776: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c:779: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c:782: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c:785: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c:788: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c:791: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c:794: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c:797: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c:800: parse error before `)' drivers/infiniband/ulp/iser/iser_lkdapl.c: In function `iser_handle_single_kdapl_event': drivers/infiniband/ulp/iser/iser_lkdapl.c:1025: parse error before `)' x86 + gen2 =m *FAILED* same as above Thanks, Nish ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
On Thu, 2005-10-06 at 13:11, Nishanth Aravamudan wrote: > On 06.10.2005 [19:40:40 +0300], Dan Bar Dov wrote: > > I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 in version > > 3682. > > Great! Thanks. > > I'm re-running the tests (due to a subtle flaw in my PATH, my cronjobs > weren't running) now and will post the latest results. You might also want to apply https://openib.org/svn/gen2/trunk/src/linux-kernel/patches/linux-2.6.14-rc3-fib-frontend.diff to get rid of the AT and SDP warnings. -- Hal ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
On 06.10.2005 [19:40:40 +0300], Dan Bar Dov wrote: > I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 in version > 3682. Great! Thanks. I'm re-running the tests (due to a subtle flaw in my PATH, my cronjobs weren't running) now and will post the latest results. Thanks, Nish ___ openib-general mailing list openib-general@openib.org http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
Re: [openib-general] Latest build test results
I've fixed the 2.6.14-rc3 compilation warnings with iSER on x86 in version 3682. Dan On 10/4/05, Nishanth Aravamudan <[EMAIL PROTECTED]> wrote: > Hello, > > Here are the build results for 2.6.14-rc3 with and without the latest > gen2 trunk. > > Looks like all the builds were successful, with some warnings: > > - ppc64 + gen2 with =y > > drivers/infiniband/core/at.c:1547: warning: initialization from incompatible > pointer type > > drivers/infiniband/ulp/sdp/sdp_link.c:752: warning: initialization from > incompatible pointer type > > - same for =m, plus > > *** Warning: ".ip_dev_find" [drivers/infiniband/ulp/sdp/ib_sdp.ko] undefined! > *** Warning: ".ip_dev_find" [drivers/infiniband/core/ib_at.ko] undefined! > > WARNING: > /lib/modules/2.6.14-rc3-git3-autokern1/kernel/drivers/infiniband/core/ib_at.ko > needs unknown symbol ip_dev_find > WARNING: > /lib/modules/2.6.14-rc3-git3-autokern1/kernel/drivers/infiniband/ulp/sdp/ib_sdp.ko > needs unknown symbol ip_dev_find > > - x86 + gen2 with =y > > drivers/infiniband/ulp/iser/iser_conn.c: In function `iser_adaptor_release': > drivers/infiniband/ulp/iser/iser_conn.c:195: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_conn.c:203: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_conn.c:206: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_conn.c: In function `iser_conn_establish': > drivers/infiniband/ulp/iser/iser_conn.c:285: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_conn.c: In function `iser_conn_enable_rdma': > drivers/infiniband/ulp/iser/iser_conn.c:357: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_conn.c:431: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_conn.c: In function > `iser_post_receive_control': > drivers/infiniband/ulp/iser/iser_conn.c:933: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_conn.c:950: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_conn.c:981: warning: too few arguments for > format > > drivers/infiniband/ulp/iser/iser_memory.c: In function > `iser_all_mem_add_to_dto': > drivers/infiniband/ulp/iser/iser_memory.c:230: warning: cast from pointer to > integer of different size > > drivers/infiniband/ulp/iser/iser_mod.c: In function `init_module': > drivers/infiniband/ulp/iser/iser_mod.c:152: warning: too few arguments for > format > > drivers/infiniband/ulp/iser/iser_initiator.c: In function `iser_reg_rdma_mem': > drivers/infiniband/ulp/iser/iser_initiator.c:62: warning: too few arguments > for format > drivers/infiniband/ulp/iser/iser_initiator.c:67: warning: too few arguments > for format > drivers/infiniband/ulp/iser/iser_initiator.c:80: warning: too few arguments > for format > drivers/infiniband/ulp/iser/iser_initiator.c:95: warning: too few arguments > for format > > drivers/infiniband/ulp/iser/iser_lkdapl.c: In function > `iser_create_ia_pz_evd': > drivers/infiniband/ulp/iser/iser_lkdapl.c:147: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c: In function `iser_start_dto': > drivers/infiniband/ulp/iser/iser_lkdapl.c:660: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c: In function `iser_consume_events': > drivers/infiniband/ulp/iser/iser_lkdapl.c:758: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c: In function > `iser_event_handler_thread': > drivers/infiniband/ulp/iser/iser_lkdapl.c:800: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c:819: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c: In function > `iser_handle_conn_event': > drivers/infiniband/ulp/iser/iser_lkdapl.c:846: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c:849: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c:852: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c:855: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c:858: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c:861: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c:864: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c:867: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c:870: warning: too few arguments for > format > drivers/infiniband/ulp/iser/iser_lkdapl.c: In function > `iser_handle_single_kdapl_event': > drivers/infiniband/ulp/iser/iser_lkdapl.c:1116: warning: too few arguments > for format > > drivers/infiniband/ulp/iser/iser_mod.c: In function `cleanup_module': > drivers/infiniband/ulp/iser/iser_mod.c:241: warning: too few arguments for > format > > drivers/infiniband/ulp/sdp/sdp_link.c:
