hg: openjfx/2u/dev/rt: Added tag 2.2.40-b28 for changeset fac50f983ffa

[hang . vo]

Changeset: 6b5ccbc93d06
Author:hudson
Date:  2013-06-05 13:23 -0700
URL:   http://hg.openjdk.java.net/openjfx/2u/dev/rt/rev/6b5ccbc93d06

Added tag 2.2.40-b28 for changeset fac50f983ffa

! .hgtags

hg: openjfx/8/graphics/rt: Fix RT-27828 - Canvas GraphicsContext polygon/line primitives ignore translation

[hang . vo]

Changeset: 134fbe9f883e
Author:flar 
Date:  2013-06-11 17:37 -0700
URL:   http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/134fbe9f883e

Fix RT-27828 - Canvas GraphicsContext polygon/line primitives ignore translation

! javafx-ui-common/src/javafx/scene/canvas/GraphicsContext.java

hg: openjfx/8/graphics/rt: Modena: Fixed ModenaTest

[hang . vo]

Changeset: 70720b02efd2
Author:Alexander Kouznetsov
Date:  2013-06-11 16:34 -0700
URL:   http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/70720b02efd2

Modena: Fixed ModenaTest

! apps/experiments/Modena/src/modena/Modena.java

Re: NullPointer in BaseGraphics.drawTextureVO

[Daniel Zwolenski]

Thanks for the feedback,

Running it on jdk1.7.0_21-32bit I don't see that error any more (though I
am still having camera capture issues when integrating LTI CIVIL into JFX -
still trying to narrow down where the fault lies).

I do get this error however, but it seems to recover from it.

java.lang.NullPointerException
at
com.sun.prism.impl.BaseResourceFactory.clearTextureCache(BaseResourceFactory.java:47)
at
com.sun.prism.impl.BaseResourceFactory.getCachedTexture(BaseResourceFactory.java:102)
at com.sun.javafx.sg.prism.NGImageView.renderContent(NGImageView.java:115)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:187)
at com.sun.javafx.sg.prism.NGImageView.doRender(NGImageView.java:97)
at com.sun.javafx.sg.prism.NGImageView.doRender(NGImageView.java:20)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1145)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:204)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:187)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1145)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:204)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:187)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1145)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:204)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:187)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1145)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:204)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:187)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1145)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:204)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at
com.sun.javafx.sg.prism.NodeEffectInput.getImageDataForBoundedNode(NodeEffectInput.java:192)
at com.sun.javafx.sg.prism.NodeEffectInput.filter(NodeEffectInput.java:85)
at com.sun.scenario.effect.FilterEffect.filter(FilterEffect.java:167)
at com.sun.scenario.effect.Offset.filter(Offset.java:161)
at com.sun.scenario.effect.Merge.filter(Merge.java:147)
at com.sun.scenario.effect.DelegateEffect.filter(DelegateEffect.java:68)
at
com.sun.scenario.effect.impl.prism.PrEffectHelper.render(PrEffectHelper.java:156)
at com.sun.javafx.sg.prism.NGNode$EffectFilter.render(NGNode.java:748)
at com.sun.javafx.sg.prism.NGNode.renderEffect(NGNode.java:494)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1145)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:204)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:187)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1145)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:204)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:187)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1145)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:204)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:187)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1145)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:204)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:187)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1145)
at com.sun.javafx.tk.quantum.ViewPainter.doPaint(ViewPainter.java:117)
at
com.sun.javafx.tk.quantum.AbstractPainter.paintImpl(AbstractPainter.java:181)
at
com.sun.javafx.tk.quantum.PresentingPainter.run(PresentingPainter.java:73)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at
java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178)
at com.sun.prism.render.RenderJob.run(RenderJob.java:37)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at
com.sun.javafx.tk.quantum.QuantumRen

hg: openjfx/8/controls/rt: 70 new changesets

[hang . vo]

Changeset: 572b1ec2e971
Author:hudson
Date:  2013-06-06 19:44 -0700
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/572b1ec2e971

Added tag 8.0-b93 for changeset 40836a4b4d85

! .hgtags

Changeset: 51ca8a8468e9
Author:mv157916
Date:  2013-06-08 21:12 -0700
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/51ca8a8468e9

RT-31017: Update the JDK build number to b93 in rt/build.properties file in the 
JavaFX 8 Master forest.

! build.properties

Changeset: 4fcbd4317b9b
Author:David Grieve
Date:  2013-06-11 14:17 -0400
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/4fcbd4317b9b

Automated merge with ssh://jfxsrc.us.oracle.com//javafx/8.0/MASTER/jfx/rt


Changeset: eb4b66ebb62c
Author:Yao Wang 
Date:  2013-06-04 14:21 -0700
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/eb4b66ebb62c

RT-29890 Rendering Artifact on Cylinder and Sphere

! javafx-ui-common/src/javafx/scene/shape/Cylinder.java
! javafx-ui-common/src/javafx/scene/shape/Sphere.java

Changeset: 06fc41c8f8b1
Author:Alexander Kouznetsov
Date:  2013-06-04 15:10 -0700
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/06fc41c8f8b1

3DViewer: Improved optimizer to remove only middle KeyValues of a repeating 
sequences

! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/importers/Optimizer.java

Changeset: 3efe9d22038b
Author:Alexander Kouznetsov
Date:  2013-06-04 15:12 -0700
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/3efe9d22038b

3DViewer: Not comparing interpolators or KeyValues before fix for RT-30891 is 
in.

! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/importers/Optimizer.java

Changeset: 6b3080191250
Author:dmasada
Date:  2013-06-04 15:39 -0700
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/6b3080191250

RT-30913 Add Modena and 3DViewer to automated build

! apps/build.xml
! apps/experiments/3DViewer/build.xml
! apps/experiments/Modena/build.xml
! apps/experiments/Modena/nbproject/project.properties
+ apps/experiments/build.xml

Changeset: 39089954dc77
Author:"Jasper Potts"
Date:  2013-06-04 13:14 -0700
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/39089954dc77

3D Viewer App: Added optimize and Java Source export

! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/exporters/javasource/JavaSourceExporter.java
! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/importers/Importer3D.java
! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/importers/Optimizer.java
! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/ContentModel.java
! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/MainController.java
! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/main.fxml

Changeset: 597c09e7d90d
Author:"Jasper Potts"
Date:  2013-06-04 16:59 -0700
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/597c09e7d90d

3D Viewer App: Added timeline controls and display screen

! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/ContentModel.java
! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/MainController.java
+ 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/TimelineController.java
+ 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/TimelineDisplay.java
! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/main.fxml
! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/viewer.css
+ 
apps/experiments/3DViewer/src/test/java/com/javafx/experiments/exporters/javasource/JavaSourceExporterTestApp.java

Changeset: 1b69050a634b
Author:"Jasper Potts"
Date:  2013-06-04 16:59 -0700
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/1b69050a634b

Merge

! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/importers/Optimizer.java

Changeset: 4d270a8b1c08
Author:Martin Sladecek 
Date:  2013-06-05 11:08 +0200
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/4d270a8b1c08

[JAVADOC] RT-30848 Missing documentation of Region.layoutInArea
+ since tag to Parent#requestParentLayout

! javafx-ui-common/src/javafx/scene/Parent.java
! javafx-ui-common/src/javafx/scene/layout/Region.java

Changeset: 1960366c3157
Author:Martin Sladecek 
Date:  2013-06-05 11:08 +0200
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/1960366c3157

Automated merge with file:///home/martin/work/jfx-80-sync/rt


Changeset: d8cc9c99d9f4
Author:Martin Sladecek 
Date:  2013-06-05 11:08 +0200
URL:   http://hg.openjdk.java.net/openjfx/8/controls/rt/rev/d8cc9c99d9f4

Automated merge with file:///home/martin/work/jfx-80-sync/rt


Changeset: 8bebc4d79bfe
Author:Martin Sladecek 
Date:  2013-06-05 13:43

hg: openjfx/8/graphics/rt: Implement mesh skinning for triangle meshes using maya files as input.

[hang . vo]

Changeset: 4b1d8b929927
Author:axlee@AXLEE-LAP
Date:  2013-06-11 12:10 -0700
URL:   http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/4b1d8b929927

Implement mesh skinning for triangle meshes using maya files as input.

! 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/importers/maya/Loader.java
+ 
apps/experiments/3DViewer/src/main/java/com/javafx/experiments/shape3d/SkinningTriangleMesh.java

Re: Update on the FullScreen ESC API proposal.

[Werner Lehmann]

The only usecase possibly missing is:
- customize the hint while still naming the key combination, and
- keep the default key combination.

In this case you wouldn't know the default key combination since the 
docs do not guarantee it to be ESC and you couldn't put it in the 
customized hint. If the combination property was set to whatever the 
default is instead of null (maybe a platform specific combination), we 
wouldn't need NO_MATCH and that little problem goes away. Ok, a null 
combination would then turn it off.


Not a showstopper for me, just wanted to mention it.

Werner

On 11.06.2013 17:42, David Hill wrote:

* I want to customize the displayed hint *
stage.setFullScreenExitHint("Don't even think about leaving this game!");

Update on the FullScreen ESC API proposal.

[David Hill]

Richard has proposed an API for the FullScreen/ESC/Overlay issue in

https://javafx-jira.kenai.com/browse/RT-15314

The proposal is pasted below, please consider watching/updating in the jira 
with comments.

Dave


/**

  * Specifies what KeyCombination will allow the user to exit full screen mode.

  * A value of KeyCombination.NO_MATCH will not match any KeyEvent and will 
make it so

  * the user is not able to escape from Full Screen mode. A value of null means 
that

  * the default platform specific key combination should be used.

  */

public final void setFullScreenExitKeyCombination(KeyCombination 
keyCombination);

public final KeyCombination getFullScreenExitKeyCombination();

public final ObjectProperty fullScreenExitKeyProperty();



/**

  * Specifies the text to show when a user enters full screen mode, usually used

  * to indicate the way a user should go about exiting out of full screen mode. 
A

  * value of null will result in the default per-locale message being 
displayed. If set

  * to the empty string, then no message will be displayed.

  */

public final void setFullScreenExitHint(String value);

public final String getFullScreenExitHint();

public final BooleanProperty fullScreenExitHintProperty();







We would also add (as the JavaDocs above indicate) a NO_MATCH public
static final KeyCombination to KeyCombination, which would be a
KeyCombination who's "match" always returns false, thereby never
matching anything. This API allows you to solve the following use cases
in, what I think, is a pretty minimally invasive manner:



 * I want to customize what key is used to exit *



stage.setFullScreenExitKeyCombination(new KeyCharacterCombination("w", 
KeyCombination.CONTROL_DOWN));



Note that this should also play into the default exit hint text, such that it should now say 
"CTRL+W" instead of "ESC"



* I want to customize the displayed hint *



stage.setFullScreenExitHint("Don't even think about leaving this game!");



* I want to show my own exit hint *



stage.setFullScreenExitHint("");

// then in your own code construct your own message



* I want to hide the exit hint but still allow the user to exit *



stage.setFullScreenExitHint("");



* I want to disallow the user from exiting full screen *



stage.setFullScreenExitKeyCombination(KeyCombination.NO_MATCH);



* I want to restore the default exit hint *



stage.setFullScreenExitHint("Some hint");

stage.setFullScreenExitHint(null); // restore to default





Changing either property would result in a SecurityException when necessary by 
an installed SecurityManager.



Note that we could also have a command line property:
-Djavafx.fullScreenExitEnabled=false which would ignore these settings
and turn off exiting in all cases. I'm not sure that it is important to
have a system property for this with proper API also being available, so
 I would opt to just go with the API for now and add the system property
 later if we want? Alternatively we could go with
-Djavafx.stage.fullScreenDefault=disabled or some other way to specify
that the default behavior is disabled, but if a specific stage has
provided a different default key combination / hint then we'll use that
instead. Or we could add API to Application later which would be
applicable to all Stages. But for now I would start with just the API on
 Stage and see how far that takes us.
David Hill 
Java Embedded Development

One of the keys to happiness is a bad memory.
-- Rita Mae Brown

Re: NullPointer in BaseGraphics.drawTextureVO

[Kevin Rushforth]

I take it there's no way to avoid the resources issue in the old JFX, 
it's just a plain and simple bug?


I don't know of a way to completely avoid it. As far as we know there 
aren't any actual leaks in the more recent FX 2.2.x texture code, but 
the resource disposal is not deterministic and if you hit the limit of 
texture memory it does not recover gracefully (or at all).


Jim might have more insight, since he implemented the new texture 
management system for FX 8.;


-- Kevin



Daniel Zwolenski wrote:
This is an older version, probably JFX from around jdk1.7.0_02. 

I'm running it now on jdk1.7.0_21 to see what happens (takes about an 
hour to get to the point of failure, which is why I didn't pick it up 
when I wrote the code originally).


Unfortunately chunks of the system are broken when it runs on this 
newer code. Lots of backwards compatibility breaks, especially visual 
ones with CSS that just make it screwy. This is an old project and I 
don't really want to be touching this code but they have this video 
capture bug which is killing everything. 

I take it there's no way to avoid the resources issue in the old JFX, 
it's just a plain and simple bug?




On Tue, Jun 11, 2013 at 11:10 PM, Kevin Rushforth 
mailto:kevin.rushfo...@oracle.com>> wrote:


Is this from FX 2.2.x or FX 8? The stack trace suggests an earlier
version of FX. The only thing I can think of off hand is that the
HW texture couldn't be created, probably because you ran out of
resources. There are a few issues relating to this, which we
believe are fixed in FX 8 with the implementation of RT-25323.

-- Kevin



Daniel Zwolenski wrote:

Can anyone tell me what might cause the exception below in Prism?

It's from an app that captures video via a native library
(LTI-CIVIL) and
then converts that image to JFX display via:

BufferedImage buffImage =
AWTImageConverter.toBufferedImage(image);
jfxImage =
javafx.scene.image.Image.impl_fromExternalImage(buffImage);
previewView.setImage(jfxImage);


java.lang.NullPointerException
at
com.sun.prism.impl.BaseGraphics.drawTextureVO(BaseGraphics.java:365)
at
com.sun.prism.impl.BaseGraphics.drawTexture(BaseGraphics.java:334)
at
com.sun.prism.impl.ps

.BaseShaderGraphics.drawTexture(BaseShaderGraphics.java:103)
at
com.sun.javafx.sg.prism.NGImageView.renderContent(NGImageView.java:315)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:205)
at
com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:205)
at
com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:205)
at
com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:205)
at
com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at
com.sun.javafx.tk.quantum.PaintRunnable.doPaint(PaintRunnable.java:214)
at

com.sun.javafx.tk.quantum.PaintRunnable.paintImpl(PaintRunnable.java:145)
at
com.sun.javafx.tk.quantum.PaintRunnable.run(PaintRunnable.java:349)
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at

java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351)
at
java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178)
at com.sun.prism.render.RenderJob.run(RenderJob.java:29)
at

java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at

java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecut

Re: [API Review]: Add "margin" property to node and make it styleable from CSS

[Tom Eugelink]

On 2013-06-11 15:36, Martin Sladecek wrote:

Means new *Constraint class and new "add" method for each layout *Pane class. Also one of 
the nice side-effects of having this as a property is that we can style it using 
"-fx-margin" CSS property.


Yup, constraint classes with values that are relevant for / supported by the 
used layout. The one layout may support totally different layout parameters 
than another. By adding this to the node, basically all layout must be modified 
to support this.

Tom

Re: [API Review]: Add "margin" property to node and make it styleable from CSS

[Martin Sladecek]

On 06/11/2013 03:01 PM, Tom Eugelink wrote:


I know I'm reiterating, but just to keep the point alive; personally I 
would still prefer to have such information placed in an explicit 
layout constraint class.


node.setMargin(x); layout.getChildren().add(node);
vs
layout.add(node, new Constraint().margin(x));

It also prevents the Node class from bloating.


Means new *Constraint class and new "add" method for each layout *Pane 
class. Also one of the nice side-effects of having this as a property is 
that we can style it using "-fx-margin" CSS property.


Regards,
-Martin

Re: Status or JDK/JFX8 builds for arm Linux

[Daniel Blaukopf]

Re: NullPointer in BaseGraphics.drawTextureVO

[Daniel Zwolenski]

This is an older version, probably JFX from around jdk1.7.0_02.

I'm running it now on jdk1.7.0_21 to see what happens (takes about an hour
to get to the point of failure, which is why I didn't pick it up when I
wrote the code originally).

Unfortunately chunks of the system are broken when it runs on this newer
code. Lots of backwards compatibility breaks, especially visual ones with
CSS that just make it screwy. This is an old project and I don't really
want to be touching this code but they have this video capture bug which is
killing everything.

I take it there's no way to avoid the resources issue in the old JFX, it's
just a plain and simple bug?



On Tue, Jun 11, 2013 at 11:10 PM, Kevin Rushforth <
kevin.rushfo...@oracle.com> wrote:

> Is this from FX 2.2.x or FX 8? The stack trace suggests an earlier version
> of FX. The only thing I can think of off hand is that the HW texture
> couldn't be created, probably because you ran out of resources. There are a
> few issues relating to this, which we believe are fixed in FX 8 with the
> implementation of RT-25323.
>
> -- Kevin
>
>
>
> Daniel Zwolenski wrote:
>
>> Can anyone tell me what might cause the exception below in Prism?
>>
>> It's from an app that captures video via a native library (LTI-CIVIL) and
>> then converts that image to JFX display via:
>>
>> BufferedImage buffImage = AWTImageConverter.**toBufferedImage(image);
>> jfxImage = javafx.scene.image.Image.impl_**
>> fromExternalImage(buffImage);
>> previewView.setImage(jfxImage)**;
>>
>>
>> java.lang.NullPointerException
>> at com.sun.prism.impl.**BaseGraphics.drawTextureVO(**
>> BaseGraphics.java:365)
>> at com.sun.prism.impl.**BaseGraphics.drawTexture(**BaseGraphics.java:334)
>> at
>> com.sun.prism.impl.ps.**BaseShaderGraphics.**drawTexture(**
>> BaseShaderGraphics.java:103)
>> at com.sun.javafx.sg.prism.**NGImageView.renderContent(**
>> NGImageView.java:315)
>> at com.sun.javafx.sg.prism.**NGNode.doRender(NGNode.java:**185)
>> at com.sun.javafx.sg.prism.**NGNode.doRender(NGNode.java:**39)
>> at com.sun.javafx.sg.BaseNode.**render(BaseNode.java:1139)
>> at com.sun.javafx.sg.prism.**NGGroup.renderContent(NGGroup.**java:205)
>> at com.sun.javafx.sg.prism.**NGRegion.renderContent(**NGRegion.java:420)
>> at com.sun.javafx.sg.prism.**NGNode.doRender(NGNode.java:**185)
>> at com.sun.javafx.sg.prism.**NGNode.doRender(NGNode.java:**39)
>> at com.sun.javafx.sg.BaseNode.**render(BaseNode.java:1139)
>> at com.sun.javafx.sg.prism.**NGGroup.renderContent(NGGroup.**java:205)
>> at com.sun.javafx.sg.prism.**NGRegion.renderContent(**NGRegion.java:420)
>> at com.sun.javafx.sg.prism.**NGNode.doRender(NGNode.java:**185)
>> at com.sun.javafx.sg.prism.**NGNode.doRender(NGNode.java:**39)
>> at com.sun.javafx.sg.BaseNode.**render(BaseNode.java:1139)
>> at com.sun.javafx.sg.prism.**NGGroup.renderContent(NGGroup.**java:205)
>> at com.sun.javafx.sg.prism.**NGRegion.renderContent(**NGRegion.java:420)
>> at com.sun.javafx.sg.prism.**NGNode.doRender(NGNode.java:**185)
>> at com.sun.javafx.sg.prism.**NGNode.doRender(NGNode.java:**39)
>> at com.sun.javafx.sg.BaseNode.**render(BaseNode.java:1139)
>> at com.sun.javafx.sg.prism.**NGGroup.renderContent(NGGroup.**java:205)
>> at com.sun.javafx.sg.prism.**NGRegion.renderContent(**NGRegion.java:420)
>> at com.sun.javafx.sg.prism.**NGNode.doRender(NGNode.java:**185)
>> at com.sun.javafx.sg.prism.**NGNode.doRender(NGNode.java:**39)
>> at com.sun.javafx.sg.BaseNode.**render(BaseNode.java:1139)
>> at com.sun.javafx.tk.quantum.**PaintRunnable.doPaint(**
>> PaintRunnable.java:214)
>> at com.sun.javafx.tk.quantum.**PaintRunnable.paintImpl(**
>> PaintRunnable.java:145)
>> at com.sun.javafx.tk.quantum.**PaintRunnable.run(**
>> PaintRunnable.java:349)
>> at java.util.concurrent.**Executors$RunnableAdapter.**
>> call(Executors.java:471)
>> at
>> java.util.concurrent.**FutureTask$Sync.**innerRunAndReset(FutureTask.**
>> java:351)
>> at java.util.concurrent.**FutureTask.runAndReset(**FutureTask.java:178)
>> at com.sun.prism.render.**RenderJob.run(RenderJob.java:**29)
>> at
>> java.util.concurrent.**ThreadPoolExecutor.runWorker(**
>> ThreadPoolExecutor.java:1110)
>> at
>> java.util.concurrent.**ThreadPoolExecutor$Worker.run(**
>> ThreadPoolExecutor.java:603)
>> at
>> com.sun.javafx.tk.quantum.**QuantumRenderer$**PipelineRunnable.run(**
>> QuantumRenderer.java:101)
>> at java.lang.Thread.run(Thread.**java:722)
>>
>>
>

Re: NullPointer in BaseGraphics.drawTextureVO

[Kevin Rushforth]

I missed the fact that this is using the non-public 
impl_fromExternalImage() method. This was replaced in FX 2.2 by 
SwingFXUtils.toFXImage as Werner mentions and has been removed from FX 8 
entirely.


One more thing to check is that jfxImage is non-null, although it is 
still more likely than not that you are running out of resources.


-- Kevin


Werner Lehmann wrote:

Is this the same as SwingFXUtils.toFXImage?

On 11.06.2013 14:27, Daniel Zwolenski wrote:

 BufferedImage buffImage = AWTImageConverter.toBufferedImage(image);
 jfxImage = 
javafx.scene.image.Image.impl_fromExternalImage(buffImage);

 previewView.setImage(jfxImage);

Re: NullPointer in BaseGraphics.drawTextureVO

[Kevin Rushforth]

Is this from FX 2.2.x or FX 8? The stack trace suggests an earlier 
version of FX. The only thing I can think of off hand is that the HW 
texture couldn't be created, probably because you ran out of resources. 
There are a few issues relating to this, which we believe are fixed in 
FX 8 with the implementation of RT-25323.


-- Kevin


Daniel Zwolenski wrote:

Can anyone tell me what might cause the exception below in Prism?

It's from an app that captures video via a native library (LTI-CIVIL) and
then converts that image to JFX display via:

BufferedImage buffImage = AWTImageConverter.toBufferedImage(image);
jfxImage = javafx.scene.image.Image.impl_fromExternalImage(buffImage);
previewView.setImage(jfxImage);


java.lang.NullPointerException
at com.sun.prism.impl.BaseGraphics.drawTextureVO(BaseGraphics.java:365)
at com.sun.prism.impl.BaseGraphics.drawTexture(BaseGraphics.java:334)
at
com.sun.prism.impl.ps.BaseShaderGraphics.drawTexture(BaseShaderGraphics.java:103)
at com.sun.javafx.sg.prism.NGImageView.renderContent(NGImageView.java:315)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:205)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:205)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:205)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:205)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.tk.quantum.PaintRunnable.doPaint(PaintRunnable.java:214)
at com.sun.javafx.tk.quantum.PaintRunnable.paintImpl(PaintRunnable.java:145)
at com.sun.javafx.tk.quantum.PaintRunnable.run(PaintRunnable.java:349)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at
java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178)
at com.sun.prism.render.RenderJob.run(RenderJob.java:29)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at
com.sun.javafx.tk.quantum.QuantumRenderer$PipelineRunnable.run(QuantumRenderer.java:101)
at java.lang.Thread.run(Thread.java:722)
  

Re: [API Review]: Add "margin" property to node and make it styleable from CSS

[Tom Eugelink]

I know I'm reiterating, but just to keep the point alive; personally I would 
still prefer to have such information placed in an explicit layout constraint 
class.

node.setMargin(x); layout.getChildren().add(node);
vs
layout.add(node, new Constraint().margin(x));

It also prevents the Node class from bloating.




On 2013-06-11 14:47, Martin Sladecek wrote:

Hi,

JIRA issue: https://javafx-jira.kenai.com/browse/RT-27785
This API change is about adding marginProperty() to Node that would be then 
used by layout Panes instead of the current constraints (static methods 
getMargin/setMargin). The getMargin/setMargin on these Panes will just delegate 
to the property.

Unfortunately, it's not possible to update Region.layoutInArea and 
Region.positionInArea methods to use child.getMargin() internally, as there's 
an overloaded method (in both cases) that already doesn't have Margin in it's 
parameters and uses Insets.EMPTY instead. Changing this to child.getMargin() 
might cause backward incompatibility issues.

Thanks,
-Martin

Re: NullPointer in BaseGraphics.drawTextureVO

[Werner Lehmann]

Is this the same as SwingFXUtils.toFXImage?

On 11.06.2013 14:27, Daniel Zwolenski wrote:

 BufferedImage buffImage = AWTImageConverter.toBufferedImage(image);
 jfxImage = javafx.scene.image.Image.impl_fromExternalImage(buffImage);
 previewView.setImage(jfxImage);

[API Review]: Add "margin" property to node and make it styleable from CSS

[Martin Sladecek]

Hi,

JIRA issue: https://javafx-jira.kenai.com/browse/RT-27785
This API change is about adding marginProperty() to Node that would be 
then used by layout Panes instead of the current constraints (static 
methods getMargin/setMargin). The getMargin/setMargin on these Panes 
will just delegate to the property.


Unfortunately, it's not possible to update Region.layoutInArea and 
Region.positionInArea methods to use child.getMargin() internally, as 
there's an overloaded method (in both cases) that already doesn't have 
Margin in it's parameters and uses Insets.EMPTY instead. Changing this 
to child.getMargin() might cause backward incompatibility issues.


Thanks,
-Martin

NullPointer in BaseGraphics.drawTextureVO

[Daniel Zwolenski]

Can anyone tell me what might cause the exception below in Prism?

It's from an app that captures video via a native library (LTI-CIVIL) and
then converts that image to JFX display via:

BufferedImage buffImage = AWTImageConverter.toBufferedImage(image);
jfxImage = javafx.scene.image.Image.impl_fromExternalImage(buffImage);
previewView.setImage(jfxImage);


java.lang.NullPointerException
at com.sun.prism.impl.BaseGraphics.drawTextureVO(BaseGraphics.java:365)
at com.sun.prism.impl.BaseGraphics.drawTexture(BaseGraphics.java:334)
at
com.sun.prism.impl.ps.BaseShaderGraphics.drawTexture(BaseShaderGraphics.java:103)
at com.sun.javafx.sg.prism.NGImageView.renderContent(NGImageView.java:315)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:205)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:205)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:205)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.sg.prism.NGGroup.renderContent(NGGroup.java:205)
at com.sun.javafx.sg.prism.NGRegion.renderContent(NGRegion.java:420)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:185)
at com.sun.javafx.sg.prism.NGNode.doRender(NGNode.java:39)
at com.sun.javafx.sg.BaseNode.render(BaseNode.java:1139)
at com.sun.javafx.tk.quantum.PaintRunnable.doPaint(PaintRunnable.java:214)
at com.sun.javafx.tk.quantum.PaintRunnable.paintImpl(PaintRunnable.java:145)
at com.sun.javafx.tk.quantum.PaintRunnable.run(PaintRunnable.java:349)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at
java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:351)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:178)
at com.sun.prism.render.RenderJob.run(RenderJob.java:29)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at
com.sun.javafx.tk.quantum.QuantumRenderer$PipelineRunnable.run(QuantumRenderer.java:101)
at java.lang.Thread.run(Thread.java:722)

hg: openjfx/8/graphics/rt: 2 new changesets

[hang . vo]

Changeset: 06aad33a6e6b
Author:Martin Sladecek 
Date:  2013-06-11 12:39 +0200
URL:   http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/06aad33a6e6b

RT-30902 FlowPane, TilePane and HBox may not handle the baseline correctly

! javafx-ui-common/src/javafx/scene/layout/AnchorPane.java
! javafx-ui-common/src/javafx/scene/layout/BorderPane.java
! javafx-ui-common/src/javafx/scene/layout/FlowPane.java
! javafx-ui-common/src/javafx/scene/layout/GridPane.java
! javafx-ui-common/src/javafx/scene/layout/HBox.java
! javafx-ui-common/src/javafx/scene/layout/Region.java
! javafx-ui-common/src/javafx/scene/layout/TilePane.java
! javafx-ui-common/src/javafx/scene/layout/VBox.java
! javafx-ui-common/test/unit/javafx/scene/layout/GridPaneTest.java
! javafx-ui-common/test/unit/javafx/scene/layout/RegionTest.java

Changeset: f236bb3f7fe6
Author:Martin Sladecek 
Date:  2013-06-11 12:40 +0200
URL:   http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/f236bb3f7fe6

Automated merge with file:///home/martin/work/jfx-80-sync/rt

! javafx-ui-common/src/javafx/scene/layout/Region.java

hg: openjfx/8/graphics/rt: RT-17666 Webview and HTMLEditor should support printing their content

[hang . vo]

Changeset: 17fa39d79a6f
Author:peterz
Date:  2013-06-11 11:14 +0400
URL:   http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/17fa39d79a6f

RT-17666 Webview and HTMLEditor should support printing their content

! webview/native/Source/WebCore/mapfile-macosx
! webview/native/Source/WebCore/mapfile-vers
! webview/native/Source/WebCore/platform/java/WebPage.cpp
! webview/native/Source/WebCore/platform/java/WebPage.h
! webview/src/com/sun/javafx/scene/web/skin/HTMLEditorSkin.java
! webview/src/com/sun/webkit/WebPage.java
! webview/src/javafx/scene/web/HTMLEditor.java
! webview/src/javafx/scene/web/WebEngine.java