[8u20] Review request: RT-13275 - 0 radius blurs produce low resolution output

2014-02-21 Thread Jim Graham

Kevin, Chien, Felipe,

I'm tagging 3 people on this review to hopefully get some more critical 
feedback mostly because the webrev is large, though most of the changes 
are simple due to some method signature changes...


Jira: https://javafx-jira.kenai.com/browse/RT-13275
webrev: http://cr.openjdk.java.net/~flar/RT-13275/webrev.00/

More information about the content of the changes appears in the latest 
comment in the Jira.


Compiled on Mac and Win7.
Test cases run on Mac with es2,sw.
Test cases run on Win7 with d3d,es2,sw.
Ensemble8 and some other samples tested on Mac.

...jim


Re: SnapCode JavaFX

2014-02-21 Thread Jim Weaver
Oh snap, Jeff :-)  Very impressive!  I added the SnapStudio video to the 
JavaFX Community site:

https://www.java.net/community/javafx/video/snapcode-studio-animations

Thanks,
Jim Weaver

On 2/21/14 3:22 PM, Jeff Martin wrote:

For some Friday night light posting, here is an update on an app I hope will 
become a great showcase, educational and promotional app for JavaFX and Java:

JavaFX Animation:   http://www.reportmill.com/snap/gallery/StudioIntro
Pen Graphics:   http://www.reportmill.com/snap/gallery/PenIntro

Maybe this could make take over for our stalled Tower defense app. I plan to 
integrate major new JavaFX features every week.

jeff



--
Regards,
Jim Weaver
Java Technology Ambassador
Oracle Corporation
james.wea...@oracle.com



hg: openjfx/8u-dev/rt: 6 new changesets

2014-02-21 Thread hang . vo
Changeset: 6514aab3e660
Author:David Grieve
Date:  2014-02-21 16:14 -0500
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6514aab3e660

[DOCS-ONLY] RT-35218: update cssref and Scene#getStylesheets to better explain 
how the url is handled

! modules/graphics/src/main/docs/javafx/scene/doc-files/cssref.html
! modules/graphics/src/main/java/javafx/scene/Parent.java
! modules/graphics/src/main/java/javafx/scene/Scene.java

Changeset: e439dd791cd2
Author:David Grieve
Date:  2014-02-21 16:14 -0500
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e439dd791cd2

[DOCS-ONLY] RT-34827: clarify pseudo-classes and properties of ProgressBar in 
cssref

! modules/graphics/src/main/docs/javafx/scene/doc-files/cssref.html

Changeset: 4dbd0719ad69
Author:David Grieve
Date:  2014-02-21 16:14 -0500
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4dbd0719ad69

[DOCS-ONLY] RT-29766: correct cssref for correct default value of HBox 
-fx-fill-height

! modules/graphics/src/main/docs/javafx/scene/doc-files/cssref.html

Changeset: fe134d5a8c64
Author:David Grieve
Date:  2014-02-21 16:14 -0500
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/fe134d5a8c64

[DOCS-ONLY] RT-28867: reword BorderRepeat javadoc so first sentence of comment 
is a more complete description

! modules/graphics/src/main/java/javafx/scene/layout/BorderRepeat.java

Changeset: 3272b83f1212
Author:David Grieve
Date:  2014-02-21 16:14 -0500
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/3272b83f1212

[DOCS-ONLY] RT-27544: clarify default values for h/vmax h/vmin and scrollbar 
max/min.

! modules/controls/src/main/java/javafx/scene/control/ScrollBar.java
! modules/controls/src/main/java/javafx/scene/control/ScrollPane.java

Changeset: ce4559bab54e
Author:David Grieve
Date:  2014-02-21 16:14 -0500
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ce4559bab54e

[DOCS-ONLY] RT-26878: add ContextMenu to cssref.

! modules/graphics/src/main/docs/javafx/scene/doc-files/cssref.html



Re: SnapCode JavaFX

2014-02-21 Thread Jeff Martin
Thanks Felix! Hopefully, if we can get students playing with it, we can get 
thousands more complex animations (or millions?). SnapCode has a great 
architecture for simply incorporating pure JavaFX. Here is an older video from 
a few weeks ago that shows an animation with a JavaFX background and custom 
code for DropShadows:

Studio Background: 
http://www.reportmill.com/snap/gallery/StudioBackground

jeff

On Feb 21, 2014, at 2:57 PM, Felix Bembrick  wrote:

> Very impressive Jeff! I'd really love to see you build some complex 
> animations with SnapCode and add in effects etc.
> 
> Keep up the great work! We really need apps that showcase the awesomeness and 
> potential of JavaFX.
> 
> Cheers,
> 
> Felix
> 
>> On 22 Feb 2014, at 7:22, Jeff Martin  wrote:
>> 
>> For some Friday night light posting, here is an update on an app I hope will 
>> become a great showcase, educational and promotional app for JavaFX and Java:
>> 
>>   JavaFX Animation:   http://www.reportmill.com/snap/gallery/StudioIntro
>>   Pen Graphics:   http://www.reportmill.com/snap/gallery/PenIntro
>> 
>> Maybe this could make take over for our stalled Tower defense app. I plan to 
>> integrate major new JavaFX features every week.
>> 
>> jeff



hg: openjfx/8u-dev/rt: NETBEANS ONLY: fix IDE files to be able to run from the IDE

2014-02-21 Thread hang . vo
Changeset: 67793658fe7c
Author:snorthov
Date:  2014-02-21 15:56 -0500
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/67793658fe7c

NETBEANS ONLY: fix IDE files to be able to run from the IDE

! netbeans/builders/nbproject/project.properties
! netbeans/controls/nbproject/build-impl.xml
! netbeans/controls/nbproject/genfiles.properties
! netbeans/controls/nbproject/project.properties
! netbeans/controls/nbproject/project.xml
! netbeans/fxpackager/nbproject/project.properties
! netbeans/graphics/nbproject/build-impl.xml
! netbeans/graphics/nbproject/genfiles.properties
! netbeans/graphics/nbproject/project.properties
! netbeans/graphics/nbproject/project.xml



Re: SnapCode JavaFX

2014-02-21 Thread Felix Bembrick
Very impressive Jeff! I'd really love to see you build some complex animations 
with SnapCode and add in effects etc.

Keep up the great work! We really need apps that showcase the awesomeness and 
potential of JavaFX.

Cheers,

Felix

> On 22 Feb 2014, at 7:22, Jeff Martin  wrote:
> 
> For some Friday night light posting, here is an update on an app I hope will 
> become a great showcase, educational and promotional app for JavaFX and Java:
> 
>JavaFX Animation:   http://www.reportmill.com/snap/gallery/StudioIntro
>Pen Graphics:   http://www.reportmill.com/snap/gallery/PenIntro
> 
> Maybe this could make take over for our stalled Tower defense app. I plan to 
> integrate major new JavaFX features every week.
> 
> jeff


SnapCode JavaFX

2014-02-21 Thread Jeff Martin
For some Friday night light posting, here is an update on an app I hope will 
become a great showcase, educational and promotional app for JavaFX and Java:

JavaFX Animation:   http://www.reportmill.com/snap/gallery/StudioIntro
Pen Graphics:   http://www.reportmill.com/snap/gallery/PenIntro

Maybe this could make take over for our stalled Tower defense app. I plan to 
integrate major new JavaFX features every week.

jeff

hg: openjfx/8u-dev/rt: ECLIPSE ONLY: fix .classpath

2014-02-21 Thread hang . vo
Changeset: 882650a79868
Author:snorthov
Date:  2014-02-21 13:25 -0500
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/882650a79868

ECLIPSE ONLY: fix .classpath

! modules/graphics/.classpath
+ modules/jmx/.classpath
+ modules/jmx/.project



Re: JavaFX suggestions from Alex Kishko

2014-02-21 Thread David Grieve


On 2/21/14, 11:36 AM, Aliaksei Kishko wrote:

Hello.

I allow me to express several opinions on the JavaFX:


5) Styles need get pseudo classes via setStyle(), for example:
menuItem.setStyle(":focused {-fx-background-color: yellow;}");
The Node#setStyle(String) API is analogous to the 'style' attribute of 
HTML. To my knowledge, the style attribute in HTML does not allow for 
pseudo-class state.


This kind of functionality does fall under the umbrella of 
https://javafx-jira.kenai.com/browse/RT-17293 and I encourage you to add 
your comments there.

6) Custom properties need be realized in easier manner as pseudo classes
and StyleableProperty inheritance. In my prototype I use my own wrapper,
but I think that it need be a part of JavaFX.


I'm not sure what you mean here. What is it your wrapper does?


TextField memory leak (RT-22716) - any JDK 7 workarounds?

2014-02-21 Thread Lesley Perkins
I posted on the ticket, but also wanted to ask the community if there are any 
good workarounds for this bug in JDK 7?  I've confirmed that the leaked 
references are being held through the TextField caret animation.  This has 
become a critical issue for my project, as now a number of our clients are 
running out of memory.

What I've tried so far is to add event handler for WindowEvent.WINDOW_HIDING, 
and try to change focus to something that is NOT a text field, followed by 
setDisable(true) on the Scene's root node.  This appeared to work briefly, but 
now I'm still seeing the leak.

Any suggestions would be appreciated.

--Andy


This message may contain confidential information and is intended for specific 
recipients unless explicitly noted otherwise. If you have reason to believe you 
are not an intended recipient of this message, please delete it and notify the 
sender. This message may not represent the opinion of IntercontinentalExchange, 
Inc. (ICE), its subsidiaries or affiliates, and does not constitute a contract 
or guarantee. Unencrypted electronic mail is not secure and the recipient of 
this message is expected to provide safeguards from viruses and pursue 
alternate means of communication where privacy or a binding message is desired.


JavaFX suggestions from Alex Kishko

2014-02-21 Thread Aliaksei Kishko
Hello.

I allow me to express several opinions on the JavaFX:

1) JavaFX need interfaces - many controls have similar methods, but not
interface: for example ComboBox, ChoiceBox, MenuButton, Menu, ContextMenu
have the method void hide(), but no inherited interface. The ComboBox and
ChoiceBox seem similar as a list wrapper, but no common list interface.

2) The abstract class Parent has private ObservableList children and
protected ObservableList getChildren(), but ChoiceBox, ComboBox,
SplitMenuButton, GridPane, Accordion, TabPane, ScrollPane etc.  - they all
are Parent too, but don't use children and have different containers:
children, items, panes,  content etc... I would like to have one way to get
children.

3) The class MenuItem need be Node, because has a lot of same methods.

I can't use these classes in utility methods or factory class. I must write
so long checker:

If (control instanceof ChoiceBox){
   ((ChoiceBox) control).getItems()...
} else If (control instanceof Accordion){
   ((ChoiceBox) control).getTabs()...
} ...

It is ineffectively.

4) All of Number property classes, for example IntegerProperty,
FloatProperty, DoubleProperty etc   implement Property... Why not
, ,  etc.?
I can't use it in collaboration with StringConverter - I need use
accordingly StringConverter, StringConverter,
StringConverter...

5) Styles need get pseudo classes via setStyle(), for example:
menuItem.setStyle(":focused {-fx-background-color: yellow;}");

6) Custom properties need be realized in easier manner as pseudo classes
and StyleableProperty inheritance. In my prototype I use my own wrapper,
but I think that it need be a part of JavaFX.

I have some more suggestions, if it is interesting I write further.


REMINDER: IMPORTANT: Rampdown / stabilization of 8u20 for milestone M2

2014-02-21 Thread Kevin Rushforth
As a reminder:  We are approaching the M2 freeze as described in #5 
below. All approved (see #4) changesets for the M2 milestone build 
should be pushed by 11:00 PM Pacific time on Sunday, Feb 23.


-- Kevin


Kevin Rushforth wrote:

Hi OpenJFX committers,

After this coming Monday's FX build, which will go into 8u20-b02, we 
will start ramping down for our M2 milestone build (aka 8u20-b03). 
This particular milestone is important for the embedded platform. As a 
result, you will need to observe the following rules for any commit.


1) Sunday, Feb 16 at 11:00 pm Pacific time:  All planned changes for 
b02 should be in (our test build is scheduled to start at 11pm that 
day). The usual rules apply for changesets pushed prior to that time.



2) All changesets that are pushed after 11:00 pm Pacific time on 
Sunday, Feb 16 will need additional scrutiny to go in. In addition to 
your normal reviewer you must get a "+1" from one of the following, 
even if you would normally do a post-commit review:


  Daniel Blaukopf
  Steve Northover
  Kevin Rushforth
  Lisa Selle


3) Monday, Feb 17:  We will do our usual "(In)Sanity Testing" and then 
hand off the bits to release engineering for 8u20-b02.



4) Week of Feb 17 - 14:  Bug fixes can go in subject to the extra 
approval noted above, but please hold off making any risky changes 
until after M2.



5) Sunday, Feb 23 at 11:00 pm Pacific time:  We will do a soft freeze, 
during which time we will be locked except for critical issues 
discovered during testing, for b03 (milestone M2).



6) Monday, Feb 24:  We will do our usual "(In)Sanity Testing", with 
extra emphasis on testing anything that changed after b02, and then 
hand off the bits to release engineering for 8u20-b03.



7) I will send a subsequent announcement as to when the repo is "open 
for normal business".



Thank you.

-- Kevin



FBX importer library

2014-02-21 Thread Uwe Sander
Hi,

we have built an FBX importer for JavaFX which we are considering to publish as 
an open source library. Before we do that, we would like to evaluate the 
community's general interest in such an endeavour. That's why I'd like to plug 
this little survey:

https://www.surveymonkey.com/s/T3XTYX2

It would help us a great deal if many people invested 1 minute of their time to 
fill out these five questions. The more we know about the general interests, 
the better we can tailor the library accordingly.

Cheers,
Uwe