hg: openjfx/8u-dev/rt: RT-37801: [Text] Hitting an empty Text returns insertion index out of text bounds
Changeset: d205ff5593c2 Author:Felipe Heidrich Date: 2014-07-03 16:45 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d205ff5593c2 RT-37801: [Text] Hitting an empty Text returns insertion index out of text bounds ! modules/graphics/src/main/java/com/sun/javafx/text/TextRun.java
[8u40] post-commit notification: RT-37812 - Potential NPE if es2 pipeline initialization fails
I just pushed a trivial fix for the following bug: JIRA: https://javafx-jira.kenai.com/browse/RT-37812 Details and changeset are in the JIRA. Thanks, - Chien
hg: openjfx/8u-dev/rt: Fix to RT-37812: Potential NPE if es2 pipeline initialization fails.
Changeset: b205d3c0b524 Author:Chien Yang Date: 2014-07-03 15:08 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b205d3c0b524 Fix to RT-37812: Potential NPE if es2 pipeline initialization fails. ! modules/graphics/src/main/java/com/sun/prism/es2/ES2Pipeline.java
hg: openjfx/8u-dev/rt: Fix to RT-37789: Embedded, 3D: Rendering artifacts on the Freescale iMX6 device
Changeset: 5343b3c3f733 Author:Chien Yang Date: 2014-07-03 13:38 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/5343b3c3f733 Fix to RT-37789: Embedded, 3D: Rendering artifacts on the Freescale iMX6 device Reviewed by kcr. ! modules/graphics/src/main/resources/com/sun/prism/es2/glsl/main.vert
hg: openjfx/8u-dev/rt: RT-37602: [Spec] Cursor.setVisible behavior is unspecified
Changeset: ea458832eefc Author:Anthony Petrov Date: 2014-07-04 00:23 +0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ea458832eefc RT-37602: [Spec] Cursor.setVisible behavior is unspecified Reviewed-by: dblaukop ! modules/graphics/src/main/java/com/sun/glass/ui/Cursor.java ! modules/graphics/src/main/java/com/sun/glass/ui/mac/MacCursor.java ! modules/graphics/src/main/native-glass/mac/GlassCursor.m
In(Sanity) Testing Mondays
Due to the US holiday tomorrow, I'm sending the reminder out today... You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/8u20 We'll be sanity testing 8u-dev. Happy holidays, and happy testing! Lisa
hg: openjfx/8u-dev/rt: 2 new changesets
Changeset: 998e2655b303 Author:kcr Date: 2014-07-03 11:08 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/998e2655b303 [BUILD] Fix build failure on linux-arm (follow-up to RT-37630) Contributed-by: yjoan ! build.gradle Changeset: 0ac23d3086e3 Author:kcr Date: 2014-07-03 11:09 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/0ac23d3086e3 RT-37790: Various source files are missing from javafx-src.zip Reviewed-by: fheidric ! build.gradle
Re: Review Request: RT-37788
Try #2, after running it through the the Xcode leak analyzer and unit testing
(FYI keep your persistent domains lower case).
WebRev: http://cr.openjdk.java.net/~shemnon/RT-37788/webrev.01/rt.patch
JIRA: https://javafx-jira.kenai.com/browse/RT-37788
And let’s move further discussion to the JIRA issue.
On Jul 2, 2014, at 10:22 PM, Petr Pchelko wrote:
> Hello, Danno.
>
> I’ve noticed that you are leaking userDefaults and expandedOptions objects.
> Adding autorelease to them would save you some memory.
>
> With best regards. Petr.
>
>> On Jul 3, 2014, at 1:43 AM, Danno Ferrin wrote:
>>
>> Yes, this has to be fixed in native code. 8u40 it is then.
>>
>> I can make it cause a crash, but that starts with shooting myself in the
>> foot, and not much can be done to fix it (by passing in bogus VM arguments).
>>
>>
>> On Jul 2, 2014, at 3:40 PM, Stephen F Northover
>> wrote:
>>
>>> Personally, I wouldn't change any native code at this point unless it was
>>> fixing a crash. The review is for 8u40, correct?
>>>
>>> Steve
>>>
>>> On 2014-07-02, 5:38 PM, Chris Bensen wrote:
I’m not sure about for 8u20. Seems fairly straight forward, and your Obj-C
seems as good as any Obj-C. My only complaint at the moment is the
following:
358 if ([pathParts count] > 2) {
359 // for 3 or more steps, the domain is first.second.third and
the keys are "/first/second/third/", "fourth/", "fifth/"... etc
360 persistentDomain = [NSString stringWithFormat: @"%@.%@.%@",
[pathParts objectAtIndex: 0],
361 [pathParts objectAtIndex: 1], [pathParts
objectAtIndex: 2]];
362
363 [dictPath replaceObjectAtIndex: 0 withObject: [NSString
stringWithFormat:@"/%@/%@/%@", [pathParts objectAtIndex: 0],
364[pathParts
objectAtIndex: 1], [pathParts objectAtIndex: 2]]];
365 [dictPath removeObjectAtIndex: 2];
366 [dictPath removeObjectAtIndex: 1];
367 } else {
368 // for 1 or two steps, the domain is first.second.third and
the keys are "/", "first/", "second/"
369 persistentDomain = @DEFAULT_JAVA_PREFS_DOMAIN;
370 [dictPath insertObject: @"" atIndex:0];
371 }
what if [pathParts count] is 0? I’d probably do a switch:
switch ([pathParts count]) {
case 0:
//error
return/break;
case 1:
case 2:
368 // for 1 or two steps, the domain is first.second.third and
the keys are "/", "first/", "second/"
369 persistentDomain = @DEFAULT_JAVA_PREFS_DOMAIN;
370 [dictPath insertObject: @"" atIndex:0];
default:
359 // for 3 or more steps, the domain is first.second.third and
the keys are "/first/second/third/", "fourth/", "fifth/"... etc
360 persistentDomain = [NSString stringWithFormat: @"%@.%@.%@",
[pathParts objectAtIndex: 0],
361 [pathParts objectAtIndex: 1], [pathParts
objectAtIndex: 2]];
362
363 [dictPath replaceObjectAtIndex: 0 withObject: [NSString
stringWithFormat:@"/%@/%@/%@", [pathParts objectAtIndex: 0],
364[pathParts
objectAtIndex: 1], [pathParts objectAtIndex: 2]]];
365 [dictPath removeObjectAtIndex: 2];
366 [dictPath removeObjectAtIndex: 1];
}
Make sense? Clear as mud?
Chris
On Jul 2, 2014, at 2:15 PM, Danno Ferrin wrote:
> Chris, Kevin, Steve,
>
> Please review this fix for RT-37788. Since I am not an objective C any
> comments are welcome. Also, please consider if this is too much for an
> 8u20 fix (the diff is against the current 8u40 codebase).
>
> Webrev: http://cr.openjdk.java.net/~shemnon/RT-37788/webrev.00/
> JIRA: https://javafx-jira.kenai.com/browse/RT-37788
>
> —Danno
>
hg: openjfx/8u-dev/rt: [SCENEBUILDER] Inspector search now obeys min max size defined in FXML
Changeset: 8039c0edd7d4 Author:mchicharro Date: 2014-07-03 15:26 +0100 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8039c0edd7d4 [SCENEBUILDER] Inspector search now obeys min max size defined in FXML ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/inspector/Inspector.fxml ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/inspector/InspectorPanelController.java
hg: openjfx/8u-dev/rt: RT-36424 [Monocle] Implement software solution for double buffering
Changeset: a83aa0a73ee5 Author:Daniel Blaukopf Date: 2014-07-03 15:09 +0300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a83aa0a73ee5 RT-36424 [Monocle] Implement software solution for double buffering ! modules/graphics/src/main/java/com/sun/glass/ui/monocle/FBDevScreen.java ! modules/graphics/src/main/java/com/sun/glass/ui/monocle/LinuxFrameBuffer.java
hg: openjfx/8u-dev/rt: RT-37804 [Monocle] Mouse input in VirtualBox not recognized
Changeset: eced589ac7e0 Author:Daniel Blaukopf Date: 2014-07-03 15:05 +0300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/eced589ac7e0 RT-37804 [Monocle] Mouse input in VirtualBox not recognized ! modules/graphics/src/main/java/com/sun/glass/ui/monocle/LinuxInputDevice.java
hg: openjfx/8u-dev/rt: RT-37802 [Monocle] GetEvent shows events as integer values instead of constant names
Changeset: b072265d6928 Author:Daniel Blaukopf Date: 2014-07-03 15:01 +0300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b072265d6928 RT-37802 [Monocle] GetEvent shows events as integer values instead of constant names ! modules/graphics/src/main/java/com/sun/glass/ui/monocle/LinuxInput.java
hg: openjfx/8u-dev/rt: RT-37799 api doc of Task.call incomplete
Changeset: 27b166eab071 Author:Martin Sladecek Date: 2014-07-03 13:29 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/27b166eab071 RT-37799 api doc of Task.call incomplete ! modules/graphics/src/main/java/javafx/concurrent/Task.java
hg: openjfx/8u-dev/rt: RT-37389 Bindings class spits out a lot of unneeded log messages
Changeset: ebff56b4399f Author:Martin Sladecek Date: 2014-07-03 13:22 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ebff56b4399f RT-37389 Bindings class spits out a lot of unneeded log messages ! modules/base/src/main/java/javafx/beans/binding/Bindings.java
hg: openjfx/8u-dev/rt: [SCENEBUILDER] CSS workarounds for RT-37787 and fixed badly formatted comment
Changeset: fe8653e9d681 Author:mchicharro Date: 2014-07-03 12:15 +0100 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/fe8653e9d681 [SCENEBUILDER] CSS workarounds for RT-37787 and fixed badly formatted comment ! apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/css/ThemeDark.css ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/css/Theme.css
hg: openjfx/8u-dev/rt: RT-37758 Relax restriction on creating Scene only on FX App thread
Changeset: 1efcff018597 Author:Martin Sladecek Date: 2014-07-03 09:08 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/1efcff018597 RT-37758 Relax restriction on creating Scene only on FX App thread Reviewed by: kcr, anthony, snorthov ! modules/graphics/src/main/java/javafx/scene/Node.java ! modules/graphics/src/main/java/javafx/scene/Parent.java ! modules/graphics/src/main/java/javafx/scene/Scene.java ! modules/graphics/src/main/java/javafx/scene/SubScene.java
hg: openjfx/8u-dev/rt: RT-37630: Hook up SceneBuilder for building
Changeset: a99bffdb9f5d Author:yjoan Date: 2014-07-03 09:05 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a99bffdb9f5d RT-37630: Hook up SceneBuilder for building Summary: SceneBuilder is now compiled when "gradle apps" is called Reviewed-by: ddhill, kcr ! apps/build.xml ! apps/scenebuilder/SceneBuilderApp/nbproject/project.properties ! apps/scenebuilder/SceneBuilderKit/nbproject/project.properties ! apps/scenebuilder/build.xml ! build.gradle
