[8u40] post-commit review: RT-38485: [Quantum] Cleanup renderLock usage to call QuantumToolkit runWith/WithoutRenderLock
Post-commit review for: JIRA: https://javafx-jira.kenai.com/browse/RT-38485 Changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e0ac95b3aef1 Simple refactoring to move common code to a utility method in QuantumToolkit as a follow-up to https://javafx-jira.kenai.com/browse/RT-38289 -- Kevin
Re: [8u40] post-commit review: RT-38457: Creating a ContextMenu on the JavaFX-Launcher thread causes an IllegalStateException
Take 2. I had to revert the original fix because it exposed a bug in StubToolkit causing several test failures. Rather than fixing the (rather fragile) StubToolkit, I just moved the fix for RT-38457 to QuantumToolkit. JIRA: https://javafx-jira.kenai.com/browse/RT-38457 Changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e04700b71f72 -- Kevin Kevin Rushforth wrote: Post-commit review for: JIRA: https://javafx-jira.kenai.com/browse/RT-38457 Changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/5e65b34a175b This fixes a problem that was exposed by the fix for https://javafx-jira.kenai.com/browse/RT-17716 and is needed to allow creation of ContextMenu and Toolip prior to the start method from being called (prior to the creation of the first Stage). -- Kevin
hg: openjfx/8u-dev/rt: 2 new changesets
Changeset: e0ac95b3aef1 Author:kcr Date: 2014-08-29 15:47 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e0ac95b3aef1 RT-38485: [Quantum] Cleanup renderLock usage to call QuantumToolkit runWith/WithoutRenderLock ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/EmbeddedScene.java ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/GlassAppletWindow.java ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/GlassViewEventHandler.java ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/GlassWindowEventHandler.java ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/PaintCollector.java ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/ViewScene.java ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java Changeset: e04700b71f72 Author:kcr Date: 2014-08-29 11:10 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e04700b71f72 RT-38457: Creating a ContextMenu on the JavaFX-Launcher thread causes an IllegalStateException ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java + tests/system/src/test/java/com/sun/javafx/application/SceneGraphThread1Test.java + tests/system/src/test/java/com/sun/javafx/application/SceneGraphThread2Test.java + tests/system/src/test/java/com/sun/javafx/application/SceneGraphThread3Test.java + tests/system/src/test/java/com/sun/javafx/application/SceneGraphThread4Test.java + tests/system/src/test/java/com/sun/javafx/application/SceneGraphThreadCommon.java
hg: openjfx/8u-dev/rt: Fix RT-38183: ManagedResource error warnings when screen configuration changes
Changeset: 1777099fe570 Author:flar Date: 2014-08-29 14:28 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/1777099fe570 Fix RT-38183: ManagedResource error warnings when screen configuration changes Reviewed by: Felipe ! modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGNode.java ! modules/graphics/src/main/java/com/sun/scenario/effect/impl/ImagePool.java + modules/graphics/src/main/java/com/sun/scenario/effect/impl/PoolFilterable.java ! modules/graphics/src/main/java/com/sun/scenario/effect/impl/Renderer.java ! modules/graphics/src/main/java/com/sun/scenario/effect/impl/prism/PrDrawable.java
[8u40] Code Review Request: RT-26108 - Implement auto-mipmap support
Hi Kevin and Jim, Can you please the proposed implementation? https://javafx-jira.kenai.com/browse/RT-26108 Thanks, - Chien
hg: openjfx/8u-dev/rt: Revert fix for RT-38457 which broke several tests using the StubToolkit
Changeset: dec228482740 Author:kcr Date: 2014-08-29 13:52 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/dec228482740 Revert fix for RT-38457 which broke several tests using the StubToolkit Backed out changeset 5e65b34a175b ! modules/graphics/src/main/java/com/sun/javafx/application/PlatformImpl.java - tests/system/src/test/java/com/sun/javafx/application/SceneGraphThread1Test.java - tests/system/src/test/java/com/sun/javafx/application/SceneGraphThread2Test.java - tests/system/src/test/java/com/sun/javafx/application/SceneGraphThread3Test.java - tests/system/src/test/java/com/sun/javafx/application/SceneGraphThread4Test.java - tests/system/src/test/java/com/sun/javafx/application/SceneGraphThreadCommon.java
Re: In(Sanity) Testing... Tuesday!!!
To be extra clear, the lock is from 1am PDT TUESDAY morning (only in Hawaii is it still Monday night at that time). -- Kevin Lisa Selle wrote: Due to the US holiday on Monday, we'll do our sanity testing on Tuesday instead of Monday this week. The repo will be locked from 1am PDT on MONDAY (not Sunday) until 11am PDT on TUESDAY. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing If you are in a geo that is working Monday, feel free to push changes but please hold off on anything really disruptive, but do NOT push changes on Tuesday (until after the repo is unlocked). Happy testing! Lisa
In(Sanity) Testing... Tuesday!!!
Due to the US holiday on Monday, we'll do our sanity testing on Tuesday instead of Monday this week. The repo will be locked from 1am PDT on MONDAY (not Sunday) until 11am PDT on TUESDAY. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing If you are in a geo that is working Monday, feel free to push changes but please hold off on anything really disruptive, but do NOT push changes on Tuesday (until after the repo is unlocked). Happy testing! Lisa
[8u40] post-commit review: RT-38457: Creating a ContextMenu on the JavaFX-Launcher thread causes an IllegalStateException
Post-commit review for: JIRA: https://javafx-jira.kenai.com/browse/RT-38457 Changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/5e65b34a175b This fixes a problem that was exposed by the fix for https://javafx-jira.kenai.com/browse/RT-17716 and is needed to allow creation of ContextMenu and Toolip prior to the start method from being called (prior to the creation of the first Stage). -- Kevin
hg: openjfx/8u-dev/rt: 2 new changesets
Changeset: 566591f1da88 Author:kcr Date: 2014-08-29 11:10 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/566591f1da88 RT-38289: [Quantum] Control ActionEvent is fired on Stage closing and the App hangs if modal window is then shown Reviewed-by: anthony, felipe, snorthov ! modules/graphics/src/main/java/com/sun/glass/ui/Accessible.java ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/GlassViewEventHandler.java ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/GlassWindowEventHandler.java ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java + tests/system/src/test/java/renderlock/RenderLock1Test.java + tests/system/src/test/java/renderlock/RenderLockCommon.java Changeset: 5e65b34a175b Author:kcr Date: 2014-08-29 11:10 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/5e65b34a175b RT-38457: Creating a ContextMenu on the JavaFX-Launcher thread causes an IllegalStateException ! modules/graphics/src/main/java/com/sun/javafx/application/PlatformImpl.java + tests/system/src/test/java/com/sun/javafx/application/SceneGraphThread1Test.java + tests/system/src/test/java/com/sun/javafx/application/SceneGraphThread2Test.java + tests/system/src/test/java/com/sun/javafx/application/SceneGraphThread3Test.java + tests/system/src/test/java/com/sun/javafx/application/SceneGraphThread4Test.java + tests/system/src/test/java/com/sun/javafx/application/SceneGraphThreadCommon.java
Re: Any plans to support CSS transitions?
Although the CSS features for 9 haven't been settled yet, this is high on my wish list. On 8/29/14, 12:06 PM, Mike Hearn wrote: I enjoy iterating on my UI using JFX CSS and a simple hot reload feature I added to my app, but I still have to drop back into writing code for doing animations. In practice this means I use fewer nice animations than I otherwise would, as perfecting them takes longer. CSS3 has a way to denote transitions of any styleable property. Given that JFX already has all the infrastructure, has a similar mechanism been considered for it?
Any plans to support CSS transitions?
I enjoy iterating on my UI using JFX CSS and a simple hot reload feature I added to my app, but I still have to drop back into writing code for doing animations. In practice this means I use fewer nice animations than I otherwise would, as perfecting them takes longer. CSS3 has a way to denote transitions of any styleable property. Given that JFX already has all the infrastructure, has a similar mechanism been considered for it?
hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix issue when deleting Root object
Changeset: de7ad70a06f9 Author:slions Date: 2014-08-29 17:35 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/de7ad70a06f9 [SCENEBUILDER] Fix issue when deleting Root object ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/SetDocumentRootJob.java
hg: openjfx/8u-dev/rt: [SCENEBUILDER] FindBugs MS_SHOULD_BE_FINAL
Changeset: 190eb7e2d1ff Author:yjoan Date: 2014-08-29 17:31 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/190eb7e2d1ff [SCENEBUILDER] FindBugs MS_SHOULD_BE_FINAL ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/util/Deprecation.java
hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix DTL-6842: Cleanup the code returning URL of CSS files
Changeset: 4d31c9c55102 Author:yjoan Date: 2014-08-29 16:58 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4d31c9c55102 [SCENEBUILDER] Fix DTL-6842: Cleanup the code returning URL of CSS files ! apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/preview/PreviewWindowController.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/EditorPlatform.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/ContentPanelController.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/WorkspaceController.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/util/CssInternal.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/util/Deprecation.java
TableView column header bug?
Hi guys, it's me again J I found another bug in TableView. I didn't find a JIRA issue for it, so again I want to check if it's known. To reproduce: . Start Java 8 / Modena Ensemble app. . Load TableView control. . Increase the size of one of the columns so they spill outside the available space and a scrollbar appears. . Scroll all the way to the right. . Maximize the ensemble app to full screen. . Observe that the column header positions are out of sync with the columns, like so: http://i.imgur.com/IadhcwO.png Known bug? Cheers, Rob
hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6846 (Dropping an object between two GridPane rows does not reorganize the grid content correctly).
Changeset: 8a83d139c837 Author:eric.le.pon...@oracle.com Date: 2014-08-29 16:03 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8a83d139c837 [SCENEBUILDER] Fix for DTL-6846 (Dropping an object between two GridPane rows does not reorganize the grid content correctly). ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/InsertColumnJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/InsertRowJob.java
hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix latent bug in row/column jobs by using a LinkedHashSet instead of unsorted HashSet.
Changeset: c157e2f9a534 Author:slions Date: 2014-08-29 15:54 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c157e2f9a534 [SCENEBUILDER] Fix latent bug in row/column jobs by using a LinkedHashSet instead of unsorted HashSet. This should fix the SB unit tests instability. ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/AddColumnConstraintsJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/AddColumnJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/AddRowConstraintsJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/AddRowJob.java
AW: TableView bug?
Ah yep, that looks like it. Cheers, Rob
hg: openjfx/8u-dev/rt: RT-38483: [CSS] add indefinite as a value for duration type
Changeset: 4c3674e9ab57 Author:David Grieve Date: 2014-08-29 09:37 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4c3674e9ab57 RT-38483: [CSS] add indefinite as a value for duration type ! modules/graphics/src/main/docs/javafx/scene/doc-files/cssref.html ! modules/graphics/src/main/java/com/sun/javafx/css/converters/DurationConverter.java ! modules/graphics/src/main/java/com/sun/javafx/css/parser/CSSParser.java ! modules/graphics/src/test/java/com/sun/javafx/css/parser/CSSParserTest.java
hg: openjfx/8u-dev/rt: [SCENEBUILDER] FindBugs SBSC_USE_STRINGBUFFER_CONCATENATION
Changeset: fd2937307d22 Author:yjoan Date: 2014-08-29 15:41 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/fd2937307d22 [SCENEBUILDER] FindBugs SBSC_USE_STRINGBUFFER_CONCATENATION ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/library/BuiltinLibrary.java
Re: TableView bug?
Possibly https://javafx-jira.kenai.com/browse/RT-38013? On 8/29/14, 8:29 AM, Robert Fisher wrote: Hi guys, I am having some difficulties fine-tuning the style of my TableView and I'm wondering if I've found a bug. It may well be related to an existing JIRA issue, so I thought I'd check here first to see if I should create a new one. http://i.imgur.com/9tGc2FB.png These screenshots are taken from the latest Ensemble app. Look carefully at the separator between the two column headers. Initially, and after resizing a column, you see the top version. The header width is 1 pixel too short, and the border is therefore drawn 1 pixel too far to the left. After clicking on the header to change the sorting of rows, you see the bottom version. This looks better. Is this a known bug? Cheers, Rob
TableView bug?
Hi guys, I am having some difficulties fine-tuning the style of my TableView and I'm wondering if I've found a bug. It may well be related to an existing JIRA issue, so I thought I'd check here first to see if I should create a new one. http://i.imgur.com/9tGc2FB.png These screenshots are taken from the latest Ensemble app. Look carefully at the separator between the two column headers. Initially, and after resizing a column, you see the top version. The header width is 1 pixel too short, and the border is therefore drawn 1 pixel too far to the left. After clicking on the header to change the sorting of rows, you see the bottom version. This looks better. Is this a known bug? Cheers, Rob
hg: openjfx/8u-dev/rt: [SCENEBUILDER] FindBugs SBSC_USE_STRINGBUFFER_CONCATENATION
Changeset: d1505b59555d Author:yjoan Date: 2014-08-29 14:29 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d1505b59555d [SCENEBUILDER] FindBugs SBSC_USE_STRINGBUFFER_CONCATENATION ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/library/BuiltinLibrary.java
hg: openjfx/8u-dev/rt: RT-37810: [SwingNode]: Swing Nodes have serious rendering artifacts when first displayed on the primary Stage
Changeset: f1184656721a Author:Anthony Petrov Date: 2014-08-29 16:09 +0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f1184656721a RT-37810: [SwingNode]: Swing Nodes have serious rendering artifacts when first displayed on the primary Stage Summary: A partial fix. It eliminates a serious rendering artifact that could cause the whole FX Scene to paint black if there's a SwingNode present. Reviewed-by: ant ! modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGExternalNode.java ! modules/swing/src/main/java/javafx/embed/swing/SwingNode.java
hg: openjfx/8u-dev/rt: 6 new changesets
Changeset: f3731ef0c7f4 Author:slions Date: 2014-08-29 08:57 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f3731ef0c7f4 [SCENEBUILDER] Going on fixing DTL-6783: Rationalize job implementation between Hierarchy and Content Panels => Adapt Span jobs ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/SpanJob.java Changeset: 2def7cb07a48 Author:slions Date: 2014-08-29 08:58 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/2def7cb07a48 [SCENEBUILDER] Going on fixing DTL-6783: Rationalize job implementation between Hierarchy and Content Panels => Adapt Set Document Root jobs ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/SetDocumentRootJob.java + apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/atomic/SetFxomRootJob.java Changeset: 3d617cc276d6 Author:slions Date: 2014-08-29 10:12 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/3d617cc276d6 [SCENEBUILDER] Going on fixing DTL-6783: Rationalize job implementation between Hierarchy and Content Panels => Adapt Modify Object jobs (BatchModifyObject and BatchModifyFxId removed) - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/BatchModifyFxIdJob.java - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/BatchModifyObjectJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ModifyObjectJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/mouse/ResizeColumnGesture.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/mouse/ResizeGesture.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/mouse/ResizeRowGesture.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/mouse/ResizeTableColumnGesture.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/gesture/mouse/ResizeTreeTableColumnGesture.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/content/mode/EditModeController.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/hierarchy/treeview/HierarchyTreeCell.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/inspector/InspectorPanelController.java Changeset: c314c8bcf9d7 Author:slions Date: 2014-08-29 10:16 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c314c8bcf9d7 [SCENEBUILDER] Going on fixing DTL-6783: Rationalize job implementation between Hierarchy and Content Panels => Adapt Modify Selection jobs (BatchModifySelectionJob renamed ModifySelectionJob) ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/EditorController.java - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/BatchModifySelectionJob.java + apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ModifySelectionJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/inspector/InspectorPanelController.java Changeset: f9ce9cad93e8 Author:slions Date: 2014-08-29 10:20 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f9ce9cad93e8 Fix comments ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ModifySelectionJob.java Changeset: c594508c4f54 Author:slions Date: 2014-08-29 10:24 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c594508c4f54 [SCENEBUILDER] Merge (no conflict)
hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix DTL-6845: Add a non empty flavor of DialogPane in the Library
Changeset: a3783295a258 Author:yjoan Date: 2014-08-29 09:48 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a3783295a258 [SCENEBUILDER] Fix DTL-6845: Add a non empty flavor of DialogPane in the Library ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/panel/library/LibraryListCell.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/library/BuiltinLibrary.java + apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/library/builtin/DialogPane.fxml
