Re: RFR: JDK-8075550 - Error "JavaFX runtime not found" in nashorn when load predefines scripts to import JavaFX packages

2016-04-08 Thread Kevin Rushforth
There are no public types exported by javafx.deploy so the change to use 
that module seems unneeded (I see that you used to include the SWT 
classes, which is likely what you want, but for which we don't yet have 
a solution in JDK 9).


Everything else looks good to me.

+1

-- Kevin


Jim Laskey (Oracle) wrote:

The code was reworked to use jrtfs: instead of reading from javafx.jar.

http://cr.openjdk.java.net/~jlaskey/8075550/webrev/index.html
https://bugs.openjdk.java.net/browse/JDK-8075550



  


RFR: JDK-8075550 - Error "JavaFX runtime not found" in nashorn when load predefines scripts to import JavaFX packages

2016-04-08 Thread Jim Laskey (Oracle)
The code was reworked to use jrtfs: instead of reading from javafx.jar.

http://cr.openjdk.java.net/~jlaskey/8075550/webrev/index.html
https://bugs.openjdk.java.net/browse/JDK-8075550





In(Sanity) Testing Mondays

2016-04-08 Thread Vadim Pakhnushev

Reminder, Monday is our weekly sanity testing.

You can find your testing assignment at:
https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing

Also please remember that the repo will be locked from 1am PST until 1pm 
PST.


Happy testing!

Thanks,
Vadim